Commits · 5b3da55b2ff6aeb63f8abcfd43a8ca1d008e243f · eriksson monteiro / tangled

22 Sep, 2011 40 commits

bulach@chromium.org authored Sep 22, 2011

BUG=
TEST=
TBR=dslomov@chromium.org

Review URL: http://codereview.chromium.org/7990001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102269 0039d316-1c4b-4281-b951-d872f2087c98

5b3da55b

Revert 102266 - Revert 102217 - Enable the Overhang pattern resource on TOUCH_UI builds. · 745aca25

tommi@chromium.org authored Sep 22, 2011

BUG=none
TEST=manually


Review URL: http://codereview.chromium.org/7983043

TBR=fsamuel@chromium.org
Review URL: http://codereview.chromium.org/7989002

TBR=tommi@chromium.org
Review URL: http://codereview.chromium.org/7993004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102268 0039d316-1c4b-4281-b951-d872f2087c98

745aca25

Revert 102101 - Displaying the extensions count in extensions settings page. · 68e5274a

finnur@chromium.org authored Sep 22, 2011

(Vetoed by the UI leads)
BUG=96855TEST=Load chrome://settings/extensionSettings and see that the title format is now Extensions (xx) where xx is the number of installed extensions in the list. Also if there are no extensions loaded then the title should be Extensions.Patch by naveenbobbili@motorola.comReview URL: http://codereview.chromium.org/7932021TBR=naveenbobbili@motorola.com
Review URL: http://codereview.chromium.org/7993001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102267 0039d316-1c4b-4281-b951-d872f2087c98

68e5274a

Revert 102217 - Enable the Overhang pattern resource on TOUCH_UI builds. · ec8984f5

tommi@chromium.org authored Sep 22, 2011

BUG=none
TEST=manually


Review URL: http://codereview.chromium.org/7983043

TBR=fsamuel@chromium.org
Review URL: http://codereview.chromium.org/7989002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102266 0039d316-1c4b-4281-b951-d872f2087c98

ec8984f5

Revert 102263 - Revert 102216 - Fix activation problem when showing bubble view · 8987694e

tommi@chromium.org authored Sep 22, 2011

If a bubble view was shown immediately after creating a browser window the bubble view would get a deactivate event causing it to close.

The problem was that when the browser window's page was commited it would switch focus to the location bar. This caused the bubble view to lose focus and close.

Fix was to have the browser winodw switch focus to the location bar only if it was the active window. Thus if a bubble view was shown it wouldn't switch focus.

This change also modifies InProcessBrowserTest::CreateBrowserForPopup() to show the browser window before navigating to a blank page. This fixes a problem where the browser window wouldn't become active.

BUG=95146
TEST=

Review URL: http://codereview.chromium.org/7960001

TBR=sail@chromium.org
Review URL: http://codereview.chromium.org/7988001

TBR=tommi@chromium.org
Review URL: http://codereview.chromium.org/7991001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102265 0039d316-1c4b-4281-b951-d872f2087c98

8987694e

Pass name of a devtools extension when adding it to DevTools. · 26c362d2

caseq@chromium.org authored Sep 22, 2011

BUG=none
TEST=none


Review URL: http://codereview.chromium.org/7980035

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102264 0039d316-1c4b-4281-b951-d872f2087c98

26c362d2

Revert 102216 - Fix activation problem when showing bubble view · 5045b06a

tommi@chromium.org authored Sep 22, 2011

If a bubble view was shown immediately after creating a browser window the bubble view would get a deactivate event causing it to close.

The problem was that when the browser window's page was commited it would switch focus to the location bar. This caused the bubble view to lose focus and close.

Fix was to have the browser winodw switch focus to the location bar only if it was the active window. Thus if a bubble view was shown it wouldn't switch focus.

BUG=95146
TEST=

Review URL: http://codereview.chromium.org/7960001

TBR=sail@chromium.org
Review URL: http://codereview.chromium.org/7988001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102263 0039d316-1c4b-4281-b951-d872f2087c98

5045b06a

Reverting my revert... · e4f2081b

tommi@chromium.org authored Sep 22, 2011

Revert 102259 - Revert 102215 - Pull libcros v173

Lots of functions have been deprecated recently.
We should update the DEPS and wait for a while before
removing them.

BUG=chromium-os:20648
TEST=build chrome

Review URL: http://codereview.chromium.org/7980030

TBR=satorux@chromium.org
Review URL: http://codereview.chromium.org/7977046

TBR=tommi@chromium.org
Review URL: http://codereview.chromium.org/7983060

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102261 0039d316-1c4b-4281-b951-d872f2087c98

e4f2081b

When the Sign in page is shown, speak the title if accessibility is turned on · 777b6369

zork@chromium.org authored Sep 22, 2011


R=hashimoto@chromium.org
BUG=chromium-os:19649
TEST=Manual


Review URL: http://codereview.chromium.org/7978054

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102260 0039d316-1c4b-4281-b951-d872f2087c98

777b6369

Revert 102215 - Pull libcros v173 · 58e006ae

tommi@chromium.org authored Sep 22, 2011

Lots of functions have been deprecated recently.
We should update the DEPS and wait for a while before
removing them.

BUG=chromium-os:20648
TEST=build chrome

Review URL: http://codereview.chromium.org/7980030

TBR=satorux@chromium.org
Review URL: http://codereview.chromium.org/7977046

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102259 0039d316-1c4b-4281-b951-d872f2087c98

58e006ae

Make the OOBE network menu accessible by improving keyboard handling · 6a99e0c2

dmazzoni@chromium.org authored Sep 22, 2011

and adding ARIA attributes.

BUG=96906
TEST=manual testing

Review URL: http://codereview.chromium.org/7917015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102258 0039d316-1c4b-4281-b951-d872f2087c98

6a99e0c2

Removing singelton property of MediaStreamManager. · ab45ceff

mflodman@chromium.org authored Sep 22, 2011

This is almost the same patch [1] as was reverted last week due to flakiness in one of the Win tests, but for one change: MediaStreamManager is not called from MediaStreamDispatcherHost::OnChannelClosing, to avoid shut-down crash. This will be changed as soon as the shut-down issue is solved.

[1] http://codereview.chromium.org/7649016/

Review URL: http://codereview.chromium.org/7948004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102255 0039d316-1c4b-4281-b951-d872f2087c98

ab45ceff

Make isimpledom write shared generated files to SHARED_INTERMEDIATE_DIR · b54b7c6c

rsleevi@chromium.org authored Sep 22, 2011

BUG=97186
TEST=none


Review URL: http://codereview.chromium.org/7973006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102254 0039d316-1c4b-4281-b951-d872f2087c98

b54b7c6c

Updating trunk VERSION from 889.0 to 890.0 · e3bbe9e6
chrome-release@google.com authored Sep 22, 2011
```
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102253 0039d316-1c4b-4281-b951-d872f2087c98
```
e3bbe9e6

Allow word separators in a few more Autofill regexes. · a489cbbf

isherman@chromium.org authored Sep 22, 2011

This also fixes an issue where inferred sections were not being updated after server types were returned.

BUG=93595
TEST=browser_tests --gtest_filter=*DataDrivenHeuristics*16*

Review URL: http://codereview.chromium.org/7981047

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102251 0039d316-1c4b-4281-b951-d872f2087c98

a489cbbf

Enable working part of ppapi_bad test with NaCl glibc. · f0debcc1

halyavin@chromium.org authored Sep 22, 2011

BUG= http://code.google.com/p/nativeclient/issues/detail?id=2191
TEST= run ./scons --mode=dbg-host,nacl platform=x86-64 --nacl_glibc run_ppapi_bad_browser_test
Review URL: http://codereview.chromium.org/7979018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102250 0039d316-1c4b-4281-b951-d872f2087c98

f0debcc1

[windows] Filter --flag-switches-begin and --flag-switches-end from being sent... · 0b8522c2

eroman@chromium.org authored Sep 22, 2011

[windows] Filter --flag-switches-begin and --flag-switches-end from being sent in the breakpad metadata.

Review URL: http://codereview.chromium.org/7981038

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102249 0039d316-1c4b-4281-b951-d872f2087c98

0b8522c2

CUPS printing: Define CUPS_PRINTER_SCANNER for Linux if CUPS is < 1.4 · ef4cdfaf

chrelad@gmail.com authored Sep 22, 2011

BUG=97409
TEST=Try compiling on Linux with CUPS < 1.4


Review URL: http://codereview.chromium.org/7980036

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102248 0039d316-1c4b-4281-b951-d872f2087c98

ef4cdfaf

Make iaccessible2 write shared generated files to SHARED_INTERMEDIATE_DIR · 2b733b3e

rsleevi@chromium.org authored Sep 22, 2011

BUG=97186
TEST=none


Review URL: http://codereview.chromium.org/7971008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102247 0039d316-1c4b-4281-b951-d872f2087c98

2b733b3e

Fix memory leak in SyncableExtensionSettingsStorage. · 5b92bc6a

akalin@chromium.org authored Sep 22, 2011

Original patch by kalman@chromium.org

BUG=97511
TEST=
TBR=kalman@chromium.org

Review URL: http://codereview.chromium.org/7978053

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102246 0039d316-1c4b-4281-b951-d872f2087c98

5b92bc6a

Fix unittest-only leak in ExtensionSettingsUIWrapper. · 746ba221

akalin@chromium.org authored Sep 22, 2011

Original patch by kalman@chromium.org

BUG=97511
TEST=
TBR=kalman@chromium.org

Review URL: http://codereview.chromium.org/7976043

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102245 0039d316-1c4b-4281-b951-d872f2087c98

746ba221

Actually fix memory leak in ExtensionSettingsStorageQuotaEnforcer. · d4161691

akalin@chromium.org authored Sep 22, 2011

Original patch by kalman@chromium.org.

BUG=97511
TEST=
TBR=kalman@chromium.org

Review URL: http://codereview.chromium.org/7980060

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102244 0039d316-1c4b-4281-b951-d872f2087c98

d4161691

Tiny clean-up of ibus_cotroller. · cc1ac48e

yusukes@chromium.org authored Sep 22, 2011

BUG=None
TEST=1) ran unit_tests with and without touchui=1 2) built touchui=1 image and manually tested it.

Review URL: http://codereview.chromium.org/7976021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102243 0039d316-1c4b-4281-b951-d872f2087c98

cc1ac48e

Fix print preview workflow to reflect settings of selected printer. · c7a90019

arthurhsu@chromium.org authored Sep 22, 2011

BUG=95110
TEST=none


Review URL: http://codereview.chromium.org/7831041

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102242 0039d316-1c4b-4281-b951-d872f2087c98

c7a90019

MenuConfig::Create passes HFONT to Font ctor but this HFONT isn't deleted.... · 19cc5b46

yosin@chromium.org authored Sep 22, 2011

MenuConfig::Create passes HFONT to Font ctor but this HFONT isn't deleted. PlatformFontWin keeps copied HFONT by InitWIthCopyOfHFONT rather than keeping passed HFONT.

BUG=96872
TEST=Manual on Win7

Review URL: http://codereview.chromium.org/7978021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102241 0039d316-1c4b-4281-b951-d872f2087c98

19cc5b46

Don't ask the browser for Autofill suggestions for non-autofillable form fields. · 283ba4ca

isherman@chromium.org authored Sep 22, 2011

BUG=69914
TEST=browser_tests --gtest_filter=FormAutofillTest.*


Review URL: http://codereview.chromium.org/7978048

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102240 0039d316-1c4b-4281-b951-d872f2087c98

283ba4ca

Moving where I'm doing dropEffect normalization. · 902f0291

dbeam@chromium.org authored Sep 22, 2011

BUG=95719
R=estade@chromium.org
TEST=Drag a tile element over the trash or navdot on Windows and check the
e.dataTransfer.dropEffect in TilePage#onDragEnd_.

Review URL: http://codereview.chromium.org/7951011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102239 0039d316-1c4b-4281-b951-d872f2087c98

902f0291

Update .DEPS.git · c41da691

chrome-admin@google.com authored Sep 22, 2011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102238 0039d316-1c4b-4281-b951-d872f2087c98

c41da691

Rolling ANGLE 754:762 · 1b42d370

jbauman@chromium.org authored Sep 22, 2011

759: Optimize uniform handling by storing both decorated and undecorated names.
760: Decorate arrays uniforms with "ar_" to identify arrays of size 1.
761: Optimize string comparisons by avoiding the creation of temporary substrings.
762: Save stream source 0 in stateblock when doing masked color clear.

BUG=97267
TEST=try-bots, webgl conformance tests

Review URL: http://codereview.chromium.org/7983049

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102237 0039d316-1c4b-4281-b951-d872f2087c98

1b42d370

Fix permission. · 51f0ca35

yzshen@chromium.org authored Sep 22, 2011

TBR=yzshen@chromium.org
BUG=None
TEST=check_perms test should pass.

Review URL: http://codereview.chromium.org/7977044

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102236 0039d316-1c4b-4281-b951-d872f2087c98

51f0ca35

Make chrome.tabs.update's tabId parameter optional. · a994358f

miket@chromium.org authored Sep 22, 2011

BUG=97330
TEST=added appropriate browser test


Review URL: http://codereview.chromium.org/7981040

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102235 0039d316-1c4b-4281-b951-d872f2087c98

a994358f

Mouse lock implementation, including the renderer side and the Windows version of the browser side. · 67bfb83f

yzshen@chromium.org authored Sep 22, 2011

BUG=41781
TEST=Manual test in ppapi/examples/mouse_lock


Review URL: http://codereview.chromium.org/7863003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102234 0039d316-1c4b-4281-b951-d872f2087c98

67bfb83f

Don't call OnNativeWidgetVisibilityChange in NativeWidgetGtk · 88de6c01

oshima@chromium.org authored Sep 22, 2011

BUG=chromium-os:20545
TEST=added a test case in FindInPageControllerTest.AcceleratorRestoring. See bug for repro step.

Review URL: http://codereview.chromium.org/7978015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102233 0039d316-1c4b-4281-b951-d872f2087c98

88de6c01

Update .DEPS.git · 9f7e241b

chrome-admin@google.com authored Sep 22, 2011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102232 0039d316-1c4b-4281-b951-d872f2087c98

9f7e241b

Roll gyp 1050:1051. · 8b801ff7

thakis@chromium.org authored Sep 22, 2011

1051: make: Fix regression where bundle targets without postbuilds called postbuilds
of a different target.

BUG=none
TEST=`make chrome` on groby's mbp works again
TBR=mark

Review URL: http://codereview.chromium.org/7977040

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102231 0039d316-1c4b-4281-b951-d872f2087c98

8b801ff7

Update screen locker UI to match webui login · 4c4332ec

oshima@chromium.org authored Sep 22, 2011

 remove all rounded corders in the pod.
 add 1x border around pod
 change background to c0c0c0.

BUG=chromium-os:20652
TEST=see bug for new ui mock


Review URL: http://codereview.chromium.org/7980029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102230 0039d316-1c4b-4281-b951-d872f2087c98

4c4332ec

Add std prefix for find(). · b05c3dbf

zhenghao@google.com authored Sep 22, 2011


BUG=none
TEST=none


Review URL: http://codereview.chromium.org/7980049

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102227 0039d316-1c4b-4281-b951-d872f2087c98

b05c3dbf

Don't block the Native Client plug-in when plug-ins are blocked by content settings. · f482b59a

bbudge@chromium.org authored Sep 22, 2011

Instead, allow Native Client when Javascript is allowed.
BUG=91571
TEST=manual

Review URL: http://codereview.chromium.org/7978037

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102226 0039d316-1c4b-4281-b951-d872f2087c98

f482b59a

Fix infinite loop in GetInputMethod. · 232211d7

oshima@google.com authored Sep 22, 2011

RWHVV shouldn't update ime if there is no inputmethod associated with the view.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/7976028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102225 0039d316-1c4b-4281-b951-d872f2087c98

232211d7

Update global error UI on sync error change · 5afcbf4f

sail@chromium.org authored Sep 22, 2011

BUG=92803
TEST=


Review URL: http://codereview.chromium.org/7978013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102223 0039d316-1c4b-4281-b951-d872f2087c98

5afcbf4f