- 16 Nov, 2017 40 commits
-
-
Siddhartha authored
The Experiment results are stated in https://goo.gl/EfU2ti. BUG=715852 Change-Id: Ic4fc697bc5dcf627a89263e3faf61c78d5b1fb85 Reviewed-on: https://chromium-review.googlesource.com/762343 Commit-Queue: Siddhartha S <ssid@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#517060}
-
Lucas Garron authored
TBR=nparker@chromium.org Bug: 785494 Change-Id: I4962501edae4815c60c4d00107053ee6f577639a Reviewed-on: https://chromium-review.googlesource.com/773281 Commit-Queue: Lucas Garron <lgarron@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#517059}
-
David Roger authored
Reconciliation now ignores unverified accounts. Bug: 780041 Change-Id: Iebec322ca38b512d1f4ef56f9a09ad779fb08680 Reviewed-on: https://chromium-review.googlesource.com/749943 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#517058}
-
Yoshifumi Inoue authored
This patch adds a comment to |LineLayoutInlineItem::SetAncestorLineBoxDirty()|. Change-Id: I504e7a12494e92752c7ab60916b6549e523c870d Reviewed-on: https://chromium-review.googlesource.com/773455Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#517057}
-
Takashi Toyoshima authored
Implement simple FetchRequestMode check in CORSURLLoader, and add kDisallowedByMode CORSError to pass the error type to Blink. CORSError::GetErrorString() supports the kDisallowedByMode error and DocumentThreadableLoader uses it to generate console errors. TBR: mkwst@chromium.org Bug: 736308 Change-Id: I0b3a5f77732e00598b729648aeb18d9c969d696b Reviewed-on: https://chromium-review.googlesource.com/743883 Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#517056}
-
Sylvain Defresne authored
Convert TextToSpeechListener to directly track the registration with the observed WebState instead of relying on the deprecated code in WebStateObserver. Remove TextToSpeechWebStateObserver and convert the TextToSpeechListener to implement CRWWebStateObserver. Bug: 775684 Change-Id: I40592a8cd9e5819168e1a65b9b0738b54d429b38 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Reviewed-on: https://chromium-review.googlesource.com/768715 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#517055}
-
Olivier Robin authored
Follow up of https://chromium-review.googlesource.com/c/chromium/src/+/744012 Bug: 785673, 775684 Change-Id: I85e06ac43db3098ed4d297ea6ad9c242dd8ecae2 Reviewed-on: https://chromium-review.googlesource.com/774261Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#517054}
-
Vadym Doroshenko authored
This feature for many years was set enabled by default, so let's remove the feature and leave enabled behaviour. Bug: Change-Id: I3e3ccdbda73a0ac8043aaa439b1d0a1e9844b114 Reviewed-on: https://chromium-review.googlesource.com/771811Reviewed-by:
Vaclav Brozek <vabr@chromium.org> Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#517053}
-
Jérôme Lebel authored
When opening the profile switcher menu using the shortcut (cmd-shift-m), the first profile (other than the current one) in the list should be highlighted. This should happens only when opening the menu with the keyboard (and not with the mouse). This was done with Cocoa implementation: crrev.com/2638853003 It should have been done when moving the profile chooser menu to views-toolkit: crrev.com/c/750901 Bug: 728141 Change-Id: I724d08ce626ec88144edabe7d928d8315606fd71 Reviewed-on: https://chromium-review.googlesource.com/771753 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#517052}
-
Dominic Mazzoni authored
Note that most Chrome developers and a fraction of Canary users have dchecks on, so this is causing real crashes. Bug: 756435 Change-Id: I33150f6565da96f5d2004b4e22ea2fa229119a69 Reviewed-on: https://chromium-review.googlesource.com/772076Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#517051}
-
Alex Clarke authored
Bug: 777763 Change-Id: I7c311ade27f40c723f9afbe0dad1ebbcb632099c Reviewed-on: https://chromium-review.googlesource.com/771631 Commit-Queue: Alex Clarke <alexclarke@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#517050}
-
Sylvain Defresne authored
Convert JavaScriptDialogBlockingState to directly track registration with the observed WebState instead of relying on the deprecated code in WebStateObserver. Bug: 775684 Change-Id: I5add60c72e6046400c2dc1c4a609e9f443ecb782 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Reviewed-on: https://chromium-review.googlesource.com/768420 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
-
tanvir.rizvi authored
SetMark caches the VisibleSelection and is always set by FrameSelection::ComputeVisibleSelectionInDOMTreeDeprecated. So instead of passing VisibleSelection, this CL passes FrameSelection, and then compute the visible selection at call site. With this, it also prepares for the movement of is_directional_ to FrameSelection. Bug: 740804 Change-Id: I0e7a27af4d926ae0c68f15fbba612cb7d9a5f268 Reviewed-on: https://chromium-review.googlesource.com/766027Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Tanvir Rizvi <tanvir.rizvi@samsung.com> Cr-Commit-Position: refs/heads/master@{#517048}
-
Martin Sramek authored
Corresponding spec change: https://github.com/w3c/webappsec-clear-site-data/pull/43 Bug: 607897 Change-Id: Ib9d0c994917ff801dd64404734efdcb34c9507e1 Reviewed-on: https://chromium-review.googlesource.com/771890Reviewed-by:
-
cm.sanchi authored
From discussion on chromium-dev, it was decided to remove 'chrome' namespace. Bug: 289619 Change-Id: I7e424529d4dacd61e8c272f8c4261546db55407a Reviewed-on: https://chromium-review.googlesource.com/768469 Commit-Queue: srirama chandra sekhar <srirama.m@samsung.com> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#517046}
-
Vaclav Brozek authored
This CL adds a test for handling a bigger number of stored passwords in iOS settings than how much fit on a single screen. Bug: 750884 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I459ecbda1ad18b046ba54652c2fb393c51c708e2 Reviewed-on: https://chromium-review.googlesource.com/593012 Commit-Queue: Vaclav Brozek <vabr@chromium.org> Reviewed-by:
Mike Baxley <baxley@chromium.org> Reviewed-by:
Mike Pinkerton <pinkerton@chromium.org> Cr-Commit-Position: refs/heads/master@{#517045}
-
Yoshifumi Inoue authored
This patch gets rid of redundant function call introduces by the patch[1] from |LayoutInline::DirtyLinesFromChangedChild()| and checking runtime flag before calling non-cheap function call |EnclosingNGBlockFlow()| to avoid speed regression. This patch also removes a TODO comment from |SetAncestorLineBoxDirty()| call site since the patch[2] explains it. [1] http://crrev.com/c/768257: [LayoutNG] LayoutInline::DirtyLinesFromChangedChild() [2] http://crrev.com/c/773455: Add a comment to LineLayoutInlineItem::SetAncestorLineBoxDirty() Change-Id: I7eedd7753b0c901380c55c8234cc78ae65f82574 Reviewed-on: https://chromium-review.googlesource.com/774339Reviewed-by:
-
Hiroki Nakagawa authored
chromium/ directory is no longer necessary because tests were upstreamed to WPT and all remaining tests under http/tests/worklet/ are chromium-specific. Bug: n/a Change-Id: I9540b3d889f45e311cdd43562c2b23dd9cededda Reviewed-on: https://chromium-review.googlesource.com/770917 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#517043}
-
Friedrich Horschig authored
Finch config groups for testing. Should include the Control group as it changes the default behavior. Change-Id: I41c2f03bd4acd421c227291a961cc7353b8bff63 Reviewed-on: https://chromium-review.googlesource.com/768720Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Friedrich Horschig <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#517042}
-
Greg Thompson authored
BUG=717091 R=nikunjb@chromium.org, skare@chromium.org Change-Id: I1e8d1d9ac4dd7f5f9e1feb80aaad38dfea6ba7cc Reviewed-on: https://chromium-review.googlesource.com/544817 Commit-Queue: Greg Thompson <grt@chromium.org> Reviewed-by:
Patrick Monette <pmonette@chromium.org> Cr-Commit-Position: refs/heads/master@{#517041}
-
Mikel Astiz authored
This includes user-initiated navigations to other pages (click-like events), which could otherwise lead to favicon mixups (the favicon of the landing page could be associated to the page where the event was initiated by the user. BUG=776346,759631 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation Change-Id: Ic8536c848fd2ce93b2b558320fb97211a933042d Reviewed-on: https://chromium-review.googlesource.com/758356 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Brett Wilson <brettw@chromium.org> Cr-Commit-Position: refs/heads/master@{#517040}
-
Mihai Sardarescu authored
This CL logs the following metrics for the DICE flow to sign in to Chrome: 1. Sign-in started: * histogram: Signin.SigninStartedAccessPoint * user action Signin_Signin_From<AccessPoint> 2. Sign-in completed: * histograms: Signin.SigninCompletedAccessPoint and Signin.SigninReason This CL also removes the usage of the continue_url from OneSigninSyncStarter as it was never used. acronym: DICE = Desktop Identity Consistency Bug: 772365 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ie5b6e42baa5b771051e1f9fc1afc7d60f9f605ca Reviewed-on: https://chromium-review.googlesource.com/768744Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#517039}
-
webrtc-autoroll@chromium.org authored
https://webrtc.googlesource.com/src.git/+log/7aee3d538c54..801b868bd8e3 $ git log 7aee3d538..801b868bd --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I70f184407e5ad8a14efdd05f14c1c873209a7bdc Reviewed-on: https://chromium-review.googlesource.com/773453Reviewed-by:
WebRTC Roll Bot <webrtc-autoroll@chromium.org> Commit-Queue: WebRTC Roll Bot <webrtc-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#517038}
-
Mikhail Pozdnyakov authored
The 'qpc_position' result of IAudioClock::GetPosition must be converted to raw QPC value before base::TimeTicks::FromQPCValue can be called on it. Bug: 783784 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I4918c71e439d87b4e231cd9f8d73ac5ed6c69abb Reviewed-on: https://chromium-review.googlesource.com/768682Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Henrik Andreasson <henrika@chromium.org> Commit-Queue: Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> Cr-Commit-Position: refs/heads/master@{#517037}
-
Guido Urdaneta authored
This reverts commit 02192497. Reason for revert: The following tests started failing consistently right after this CL landed: ChromeNetworkServiceRestartBrowserTest.StoragePartitionGetNetworkContext ChromeNetworkServiceRestartBrowserTest.SystemNetworkContextManagerGetContext First failure: https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/64657 Sample logs: [330/331] ChromeNetworkServiceRestartBrowserTest.SystemNetworkContextManagerGetContext (TIMED OUT) [331/331] PrerenderBrowserTestWithExtensions.StreamsTest (6672 ms) Retrying 1 test (retry #2) Still waiting for the following processes to finish: ".\browser_tests.exe" --brave-new-test-launcher --cfi-diag=0 --gtest_also_run_disabled_tests --gtest_filter=ChromeNetworkServiceRestartBrowserTest.SystemNetworkContextManagerGetContext --single_process --test-launcher-bot-mode --test-launcher-output="C:\Users\CHROME~2\AppData\Local\Temp\scoped_dir4976_15072\results4976_25891\test_results.xml" --test-launcher-summary-output="e:\b\s\w\io7tx1xz\output.json" --user-data-dir="C:\Users\CHROME~2\AppData\Local\Temp\scoped_dir4976_15072\d4976_10509" Still waiting for the following processes to finish: ".\browser_tests.exe" --brave-new-test-launcher --cfi-diag=0 --gtest_also_run_disabled_tests --gtest_filter=ChromeNetworkServiceRestartBrowserTest.SystemNetworkContextManagerGetContext --single_process --test-launcher-bot-mode --test-launcher-output="C:\Users\CHROME~2\AppData\Local\Temp\scoped_dir4976_15072\results4976_25891\test_results.xml" --test-launcher-summary-output="e:\b\s\w\io7tx1xz\output.json" --user-data-dir="C:\Users\CHROME~2\AppData\Local\Temp\scoped_dir4976_15072\d4976_10509" Still waiting for the following processes to finish: ".\browser_tests.exe" --brave-new-test-launcher --cfi-diag=0 --gtest_also_run_disabled_tests --gtest_filter=ChromeNetworkServiceRestartBrowserTest.SystemNetworkContextManagerGetContext --single_process --test-launcher-bot-mode --test-launcher-output="C:\Users\CHROME~2\AppData\Local\Temp\scoped_dir4976_15072\results4976_25891\test_results.xml" --test-launcher-summary-output="e:\b\s\w\io7tx1xz\output.json" --user-data-dir="C:\Users\CHROME~2\AppData\Local\Temp\scoped_dir4976_15072\d4976_10509" [ RUN ] ChromeNetworkServiceRestartBrowserTest.SystemNetworkContextManagerGetContext [1320:5532:1115/211725.385:WARNING:chrome_browser_main_win.cc(613)] Command line too long for RegisterApplicationRestart: --brave-new-test-launcher --cfi-diag=0 --gtest_also_run_disabled_tests --gtest_filter=ChromeNetworkServiceRestartBrowserTest.SystemNetworkContextManagerGetContext --single_process --test-launcher-bot-mode --test-launcher-output="C:\Users\CHROME~2\AppData\Local\Temp\scoped_dir4976_15072\results4976_25891\test_results.xml" --test-launcher-summary-output="e:\b\s\w\io7tx1xz\output.json" --user-data-dir="C:\Users\CHROME~2\AppData\Local\Temp\scoped_dir4976_15072\d4976_10509" --disable-offline-auto-reload --no-first-run --no-default-browser-check --enable-logging=stderr --safebrowsing-disable-auto-update --disable-default-apps --wm-window-animations-disabled --disable-component-update --test-type=browser --force-color-profile=srgb --disable-zero-browsers-open-for-tests --ipc-connection-timeout=45 --allow-file-access-from-files --dom-automation --log-gpu-control-list-decisions --disable-backgrounding-occluded-windows --disable-gl-drawing-for-tests --override-use-software-gl-for-tests --force-color-profile=srgb --enable-features=NetworkService,TestFeatureForBrowserTest1 --disable-features=NetworkPrediction,TestFeatureForBrowserTest2 --flag-switches-begin --flag-switches-end --restore-last-session about:blank [5536:4644:1115/211726.031:INFO:media_foundation_video_encode_accelerator_win.cc(370)] Windows versions earlier than 8 are not supported. [332/332] ChromeNetworkServiceRestartBrowserTest.SystemNetworkContextManagerGetContext (TIMED OUT) Retrying 1 test (retry #3) Still waiting for the following processes to finish: ".\browser_tests.exe" --brave-new-test-launcher --cfi-diag=0 --gtest_also_run_disabled_tests --gtest_filter=ChromeNetworkServiceRestartBrowserTest.SystemNetworkContextManagerGetContext --single_process --test-launcher-bot-mode --test-launcher-output="C:\Users\CHROME~2\AppData\Local\Temp\scoped_dir4976_15072\results4976_29411\test_results.xml" --test-launcher-summary-output="e:\b\s\w\io7tx1xz\output.json" --user-data-dir="C:\Users\CHROME~2\AppData\Local\Temp\scoped_dir4976_15072\d4976_16217" Still waiting for the following processes to finish: ".\browser_tests.exe" --brave-new-test-launcher --cfi-diag=0 --gtest_also_run_disabled_tests --gtest_filter=ChromeNetworkServiceRestartBrowserTest.SystemNetworkContextManagerGetContext --single_process --test-launcher-bot-mode --test-launcher-output="C:\Users\CHROME~2\AppData\Local\Temp\scoped_dir4976_15072\results4976_29411\test_results.xml" --test-launcher-summary-output="e:\b\s\w\io7tx1xz\output.json" --user-data-dir="C:\Users\CHROME~2\AppData\Local\Temp\scoped_dir4976_15072\d4976_16217" Still waiting for the following processes to finish: ".\browser_tests.exe" --brave-new-test-launcher --cfi-diag=0 --gtest_also_run_disabled_tests --gtest_filter=ChromeNetworkServiceRestartBrowserTest.SystemNetworkContextManagerGetContext --single_process --test-launcher-bot-mode --test-launcher-output="C:\Users\CHROME~2\AppData\Local\Temp\scoped_dir4976_15072\results4976_29411\test_results.xml" --test-launcher-summary-output="e:\b\s\w\io7tx1xz\output.json" --user-data-dir="C:\Users\CHROME~2\AppData\Local\Temp\scoped_dir4976_15072\d4976_16217" [ RUN ] ChromeNetworkServiceRestartBrowserTest.SystemNetworkContextManagerGetContext [4852:4412:1115/211810.497:WARNING:chrome_browser_main_win.cc(613)] Command line too long for RegisterApplicationRestart: --brave-new-test-launcher --cfi-diag=0 --gtest_also_run_disabled_tests --gtest_filter=ChromeNetworkServiceRestartBrowserTest.SystemNetworkContextManagerGetContext --single_process --test-launcher-bot-mode --test-launcher-output="C:\Users\CHROME~2\AppData\Local\Temp\scoped_dir4976_15072\results4976_29411\test_results.xml" --test-launcher-summary-output="e:\b\s\w\io7tx1xz\output.json" --user-data-dir="C:\Users\CHROME~2\AppData\Local\Temp\scoped_dir4976_15072\d4976_16217" --disable-offline-auto-reload --no-first-run --no-default-browser-check --enable-logging=stderr --safebrowsing-disable-auto-update --disable-default-apps --wm-window-animations-disabled --disable-component-update --test-type=browser --force-color-profile=srgb --disable-zero-browsers-open-for-tests --ipc-connection-timeout=45 --allow-file-access-from-files --dom-automation --log-gpu-control-list-decisions --disable-backgrounding-occluded-windows --disable-gl-drawing-for-tests --override-use-software-gl-for-tests --force-color-profile=srgb --enable-features=NetworkService,TestFeatureForBrowserTest1 --disable-features=NetworkPrediction,TestFeatureForBrowserTest2 --flag-switches-begin --flag-switches-end --restore-last-session about:blank [2460:2636:1115/211811.151:INFO:media_foundation_video_encode_accelerator_win.cc(370)] Windows versions earlier than 8 are not supported. [333/333] ChromeNetworkServiceRestartBrowserTest.SystemNetworkContextManagerGetContext (TIMED OUT) 1 test timed out: ChromeNetworkServiceRestartBrowserTest.SystemNetworkContextManagerGetContext (../../chrome/browser/chrome_network_service_restart_browsertest.cc:96) +------------------------------------------------------------------------+ Original change's description: > Handle NetworkContext error in StoragePartitionImpl and SystemNetworkContextManager > > This CL: > 1.Adds reconnect logic to |StoragePartitionImpl::GetNetworkContext()| > and |SystemNetworkContextManager::GetContext()| to makes sure they return > valid interface after crash. > 2.Adds browser tests to ensure the new |NetworkContext| can make URL > requests. > > Note: > * This CL only makes sure the returned |NetworkContext| is valid. More > tests will be added to ensure other NetworkContext providers > (e.g. IOThread) and |URLLoaderFactoryGetter| is working. > > Bug: 780956 > Change-Id: Ie8bc4e2bb2e86c5e72f946eef1eb84fb8102910f > Reviewed-on: https://chromium-review.googlesource.com/758831 > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Reviewed-by: Matt Menke <mmenke@chromium.org> > Commit-Queue: Chong Zhang <chongz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#516766} TBR=jam@chromium.org,yzshen@chromium.org,mmenke@chromium.org,chongz@chromium.org Change-Id: If30e7394e6f2e4a9c14d7671a4106243aa72b9c1 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 780956 Reviewed-on: https://chromium-review.googlesource.com/774398Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#517036}
-
Bruce Dawson authored
This is a reland of b58d6940 Original change's description: > Get base building with -Wshadow > > Variable shadowing is legal and well defined but can make code harder to > read and can hide some classes of bugs. This change gets base building > with -Wshadow. The changes required seem to improve the code in most > cases, and neutral in others. > > This CL uses a number of techniques to avoid shadowing > * reuse - don't declare a new variable if not needed > * rename - if a new variable is needed, use a new name > * reduce - make the scope smaller > * remove - remove duplicate constant declarations > > I particularly like the for loop technique for reducing scope. We > should probably prefer 'for' over 'while' for many loops. > > Change-Id: Iad81f0ca22937653a36781e55d53aca8e38672aa > Reviewed-on: https://chromium-review.googlesource.com/767654 > Commit-Queue: Bruce Dawson <brucedawson@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#516850} Change-Id: I43258f86c51263b2aad665f61527823c3fea9db5 Reviewed-on: https://chromium-review.googlesource.com/773832Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#517035}
-
tzik authored
VideoLayerImpl used to hold the software ResourceID as a vector, so that it can hold more than one resource. However, it actually doesn't hold more than one, and causes multiple usage of ReleaseCallback, which should be used only once. Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: I79e4164bd889bf1a8b46ae55f03660f96e65835d Reviewed-on: https://chromium-review.googlesource.com/765611 Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#517034}
-
Takayoshi Kochi authored
We missed code to change cascading order mode (V0 or V1) when a shadow root moves across documents. The layout test checks if the cascade order is applied correctly. To check if the element adoption caused proper side effect on the internal cascade order and "MayContainV0Shadow" flag, a C++ unit test is necessary instead of layout tests. Bug: 783055 Change-Id: Idf967d9315d11948782777454de17548181038c9 Reviewed-on: https://chromium-review.googlesource.com/771270Reviewed-by:
Hayato Ito <hayato@chromium.org> Commit-Queue: Takayoshi Kochi <kochi@chromium.org> Cr-Commit-Position: refs/heads/master@{#517033}
-
Takashi Toyoshima authored
When I moved platform/loader/fetch from core/fetch to platform, I left ResourceResponseTest in webkit_unit_tests because it needs a thread support that blink_platform_unittests does not. This patch move the ResourceResponseTest to blink_platform_unittests, and add a thread support to TestingPlatformSupportWithMockScheduler. Bug: n/a Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I6e4f6274368e4abbf21ce5671cff99a4c3e2f70f Reviewed-on: https://chromium-review.googlesource.com/763192 Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
-
Yoichi Osato authored
We reassign SelectionState at the end of LayoutSelection::Commit() to avoid use-after-free. This patch changes it to call non virtual LayoutObject::SetSelectionState() and assign SelectionState to only target LayoutObjects. Bug: 739062 Change-Id: I5613257c99332b887501e1bcd4fe27482f9280d0 Reviewed-on: https://chromium-review.googlesource.com/773788Reviewed-by:
-
Yuta Kitamura authored
This patch is largely based on tzik's WIP patch: https://chromium-review.googlesource.com/c/chromium/src/+/742824 Bug: 771087 Change-Id: I20e2eb5ef09911a19e3b268e45ce6187d8edeffa Reviewed-on: https://chromium-review.googlesource.com/765749 Commit-Queue: Yuta Kitamura <yutak@chromium.org> Reviewed-by:
Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#517030}
-
cm.sanchi authored
From discussion on chromium-dev, it was decided to remove 'chrome' namespace. Bug: 289619 Change-Id: I148dad79f57a0cc6392a327665aa8a33dfe18566 Reviewed-on: https://chromium-review.googlesource.com/770926Reviewed-by:
Tommi <tommi@chromium.org> Reviewed-by:
Raymes Khoury <raymes@chromium.org> Commit-Queue: srirama chandra sekhar <srirama.m@samsung.com> Cr-Commit-Position: refs/heads/master@{#517029}
-
Jaebaek Seo authored
As shown crbug.com/737777#c51, enabling --use-zoom-for-dsf locates Autofill popup in a wrong place. It is because AutofillPopupViewAndroid::OnSuggestionsChanged() and AwAutofillClient::ShowAutofillPopupImpl() passes element_bounds in the CSS scale as an argument to ViewAndroid::SetAnchorRect() that must receive the device scaled bounds argument when --use-zoom-for-dsf is enabled. This CL lets ViewAndroid::SetAnchorRect() receive the CSS scaled bounds argument and scales down the bounds argument as the CSS scale that ContentViewCore::ShowSelectPopupMenu() gives to ViewAndroid::SetAnchorRect(). In addition, this CL sets ViewAndroid::content_offset() as the CSS scale, which must be in the CSS scale for ViewAndroid::SetAnchorRect(), RenderWidgetHostImpl::WindowSnapshotReachedScreen(), ContextMenuHelper::ShowContextMenu(), and TabAndroid::ShowMediaDownloadInProductHelp(). By refactoring RenderWidgetHostViewAndroid::OnFrameMetadataUpdated(), it also relocates the position of IME CursorAnchorInfo API to the correct position when --use-zoom-for-dsf is enabled. BUG=737777 Change-Id: I8f2268562735b822478455dab7581b6418a397fd Reviewed-on: https://chromium-review.googlesource.com/771491 Commit-Queue: Jaebaek Seo <jaebaek@chromium.org> Reviewed-by:
Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#517028}
-
cm.sanchi authored
CONTENT_SETTINGS_TYPE_PUSH_MESSAGING is exactly equivalent with CONTENT_SETTINGS_TYPE_NOTIFICATIONS now. This patch removes all its references Bug: 781672 Change-Id: I81f6f0938d75a30db97c140f3232784931b6d027 Reviewed-on: https://chromium-review.googlesource.com/758456 Commit-Queue: srirama chandra sekhar <srirama.m@samsung.com> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
-
Lucas Garron authored
TBR=palmer@chromium.org Bug: Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I736179a07a78d5af2bfbfb95702aa6dcc241f2fe Reviewed-on: https://chromium-review.googlesource.com/773787 Commit-Queue: Lucas Garron <lgarron@chromium.org> Reviewed-by:
Lucas Garron <lgarron@chromium.org> Cr-Commit-Position: refs/heads/master@{#517026}
-
Tatsuhisa Yamaguchi authored
Only the description, meaning, and the original text is sent to translators, without relevance with other items. So we need to describe that this text is for spoken feedback, as opposed to screen text or braille. Bug: 771050 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ibb14142654a38043567fbc0eb96cb98e26cf6f58 Reviewed-on: https://chromium-review.googlesource.com/768331Reviewed-by:
Naoki Fukino <fukino@chromium.org> Reviewed-by:
Satoru Takabayashi <satorux@chromium.org> Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Cr-Commit-Position: refs/heads/master@{#517025}
-
Darren Shen authored
This patch: - Moves CSSRotation tests to a subfolder containing all the other CSSStylevalue subclasses. - Adds the appropriate meta and link tags. - Clean up the test code a bit. Note: Following the WPT guidelines, our test structure closely follows the spec structure. Therefore, serialization and normalization of rotation values will be done in a separate file as it is a separate section in the spec. Spec: https://drafts.css-houdini.org/css-typed-om-1/#cssrotation WPT Guidelines: http://web-platform-tests.org/writing-tests/general-guidelines.html Tests are currently failing because: 1) CSSRotation should take numberishes 2) CSSRotation should also take CSSMathValues Bug: 774887 Change-Id: I55a77ad25167c0b0a0c650f6c774b6a117eb2ba1 Reviewed-on: https://chromium-review.googlesource.com/768594Reviewed-by:
meade_UTC10 <meade@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#517024}
-
Min Qin authored
TBR=dtrainor@chromium.org Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: Iee27f0bbf46466726d507982bfdcd6763b9af1f8 Reviewed-on: https://chromium-review.googlesource.com/774179Reviewed-by:
Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#517023}
-
Julian Pastarmov authored
When RestoreOnStartup is managed it should be the only source of tabs to be shown to the user on first, second or any other browser start unless the user is restarting from a crash or starting the browser with an url on the command line. BUG=756545 TEST=unit_tests, browser_tests Change-Id: I5da256009d6e254ecb8f0756cf08b2de991c9c26 Reviewed-on: https://chromium-review.googlesource.com/763532 Commit-Queue: Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Georges Khalil <georgesak@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#517022}
-
Dominick Ng authored
PermissionResponseCallback is created when a permission is requested, and it holds a weak pointer to the PermissionManager. At shutdown, the PermissionManager destructor destroys the permission context objects that it holds. If there are in-flight permission requests, there will be outstanding PermissionResponseCallback objects, which will be destroyed and try to access the PermissionManager in their destructor. Since the PermissionManager is already in the process of being destroyed, it has zeroed the weak pointer and triggers a crash. Typically the PermissionRequestManager is destroyed before the PermissionManager, which would cancel in-flight requests. This crash only triggers in cases where the PermissionManager is destroyed first. This CL fixes the crash by checking the weak pointer in the PermissionResponseCallback destructor before using it. BUG=751020 Change-Id: Id9712896d9abd1f85260a021a9063c76537131aa Reviewed-on: https://chromium-review.googlesource.com/773795 Commit-Queue: Dominick Ng <dominickn@chromium.org> Reviewed-by:
Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#517021}
-
