GitLab

IdlDefinition, IdlOperation, IdlAttribute etc should know the name of an IDL file
where they are defined. We want to pass these names to PrivateScriptRunner's methods
so that PrivateScriptRunner can understand the names of JS files of the DOM attributes/methods
that the PrivateScriptRunner is running.

Binding componentization for partial interfaces also need this change.

BUG=341031

Review URL: https://codereview.chromium.org/473893002

git-svn-id: svn://svn.chromium.org/blink/trunk@180275 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=haraken
BUG=397473

Review URL: https://codereview.chromium.org/476663002

git-svn-id: svn://svn.chromium.org/blink/trunk@180274 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Fix UI regression.
See: https://codereview.chromium.org/474453002/

BUG=
NOTRY=true

Review URL: https://codereview.chromium.org/471703003

git-svn-id: svn://svn.chromium.org/blink/trunk@180273 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Cleanup blink:: prefix usage in Source/core/modules/[battery/*.cpp to indexeddb/*.cpp]

- Merge multiple |namespace blink {}| blocks
- Remove unnecessary blink:: prefixes
- Make blank lines consistent

BUG=None

Review URL: https://codereview.chromium.org/464353002

git-svn-id: svn://svn.chromium.org/blink/trunk@180272 bbb929c8-8fbe-4397-9dbb-9b2b20218538

These are the last instances of namespace indentation in public/.

BUG=none
TEST=none; no behavior changes.

Review URL: https://codereview.chromium.org/476633002

git-svn-id: svn://svn.chromium.org/blink/trunk@180271 bbb929c8-8fbe-4397-9dbb-9b2b20218538

All places where raw TimelineAgent.Record was used are fixed.

BUG=403684,398785

Review URL: https://codereview.chromium.org/461323003

git-svn-id: svn://svn.chromium.org/blink/trunk@180270 bbb929c8-8fbe-4397-9dbb-9b2b20218538

We do not need update caret rectangle synchronously because we just need 
updated caret in painting.
Thus this CL delays computing new caret rectangle.

Source/core/editing/FrameSelection.cpp:
- Add ResetCaretBlinkOption to updateAppearance(). The option is set 
to ResetCaretBlink when it is called from setSelection.
If ResetCaretBlink, we reset caret blinking.
If we need to repaint caret, set |m_caretRectDirty| flag.
If |m_caretRectDirty| is set, we call PageAnimator::scheduleVisualUpdate to 
trigger repaint.
For range, create VisibleSelection without validation like 
HTMLTextFormControlElement::setSelectionRange.
- Add the setCaretRectNeedsUpdate function to just set |m_caretRectDirty| flag
 and call new scheduleVisualUpdate function, which calls
PageAnimator::scheduleVisualUpdate.
- FrameSelection::invalidateCaretRect does
 1. Checks the dirty flag.
 2. Gets new caret rectangle and node which has the caret renderer.
 3. if caret is changed, invalidate the new caret rect and the old caret rect.
 4. Caches the new caret rect and node. Sets dirty flag off.
This function is similar to old recomputeCaretRect(deleted).
- Delete unused updateRenderTreeIfneeded() from notifyRenderOfSelectionChange().
In old days, notifyRenderOfSelectionChange() used renderer.
- Refactor FrameSelection::absoluteCaretBounds() to call updateCaretRect
 directly. Since we update layout, ASSERT that document's lifecycle is not in
InPaintInvalidation.


Source/core/editing/Caret.cpp:
- Remove document->updateRenderTreeIfNeeded() from CaretBase::updateCaretRect
 and call it from caller.
- In FrameSelection::paintCaret, call without updateRenderTreeIfNeeded because
the tree must be updated on the painting phase.
Source/core/frame/FrameView.cpp:
- FrameView::invalidateTreeIfNeeded calls FrameSelection::InvalidateCaretRect
to invalidate caret rect for each frame.

Source/core/html/HTMLTextFormControlElementTest.cpp:
- Add new test to confirm setSelectionRange with another start/end not cause 
layout.
- Delete FrameSelectionLocalCaretRectDoesNotCauseLayout because localCaretRect 
is removed.

Layouttests:
- This cl reduces redundant RenderObject::invalidatePaintRectangle calls so we 
need to delete lines from expected.txt but result images are still same.
 
BUG=382809, 397303, 403317
TEST=Layouttests/fast/forms/textarea-scrollbar.html, textarea-scrolled-type.html

Review URL: https://codereview.chromium.org/431983005

git-svn-id: svn://svn.chromium.org/blink/trunk@180269 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Source/devtools/front_end/inspectorStyle.css:1891 hide-disclosure-buttons
Never used.

Source/devtools/front_end/timelinePanel.css:358 timeline-loading
There is no aggregates stats in popover anymore.

Source/devtools/front_end/elementsPanel.css:648 css-font-value
https://codereview.chromium.org/59993003

Source/devtools/front_end/inspectorStyle.css:1821 console-filter-top
https://bugs.webkit.org/show_bug.cgi?id=68155

BUG=

Review URL: https://codereview.chromium.org/471873002

git-svn-id: svn://svn.chromium.org/blink/trunk@180268 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Review URL: https://codereview.chromium.org/476683002

git-svn-id: svn://svn.chromium.org/blink/trunk@180267 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Review URL: https://codereview.chromium.org/476673002

git-svn-id: svn://svn.chromium.org/blink/trunk@180266 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Before this patch, the ServiceWorkerRegistration object could be garbage
collected prematurely and it caused renderer crash.

This change keeps the registration object alive until stop() is called, and
notifies WebServiceWorkerRegistration of the stop event.


BUG=396400
TEST=https://codereview.chromium.org/466723002/

Review URL: https://codereview.chromium.org/467133002

git-svn-id: svn://svn.chromium.org/blink/trunk@180265 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=aandrey

Review URL: https://codereview.chromium.org/470143002

git-svn-id: svn://svn.chromium.org/blink/trunk@180264 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Because RenderSelectionInfoBase subclasses don't add Member<> fields,
RenderSelectionInfoBase::trace is not virtual.

BUG=398342

Review URL: https://codereview.chromium.org/426083005

git-svn-id: svn://svn.chromium.org/blink/trunk@180263 bbb929c8-8fbe-4397-9dbb-9b2b20218538

When there is an existing ServiceWorkerRegistration, getOrCreate() shouldn't
release the given WebServiceWorkerRegistration object because it has already
been taken by the existing registration.


BUG=396400
TEST=https://codereview.chromium.org/466723002/

Review URL: https://codereview.chromium.org/469273002

git-svn-id: svn://svn.chromium.org/blink/trunk@180262 bbb929c8-8fbe-4397-9dbb-9b2b20218538

After this CL:

- |className| means a class name of a dependency interface (e.g., "Document").

- |scriptClassName| means a class name of the script (e.g., "DocumentXSLT").

BUG=341031

Review URL: https://codereview.chromium.org/473783003

git-svn-id: svn://svn.chromium.org/blink/trunk@180261 bbb929c8-8fbe-4397-9dbb-9b2b20218538

All call sites compensate for the inclusive end column by adding 1
to token.endColumn to get the actual token text.

R=lushnikov

Review URL: https://codereview.chromium.org/472793002

git-svn-id: svn://svn.chromium.org/blink/trunk@180260 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://fullscreen.spec.whatwg.org/#model
https://www.w3.org/Bugs/Public/show_bug.cgi?id=26326

TEST=LayoutTests/fullscreen/model/remove-*.html (new)
TEST=LayoutTests/fullscreen/full-screen-remove-*.html (no regression)

The distinction between fullyExitFullscreen() and exitFullscreen() was
not tested, but the new remove-last.html test fails with the old code.

BUG=383813

Review URL: https://codereview.chromium.org/476433002

git-svn-id: svn://svn.chromium.org/blink/trunk@180259 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Problem:
 Nodes are not revealed and not highlighted.
 Search box constantly loose focus.

Solution:
 Do not focus dataGrid on node reveal.
 Avoid refresh of all nodes on node reveal.
 Fix parameter type passed to revealer.
 Match and highlight same element.
 Reval node before highlight.

Most probably regressed by:
https://codereview.chromium.org/391083003

BUG=

Review URL: https://codereview.chromium.org/470093002

git-svn-id: svn://svn.chromium.org/blink/trunk@180258 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=erik.corry@gmail.com
BUG=

Review URL: https://codereview.chromium.org/474943002

git-svn-id: svn://svn.chromium.org/blink/trunk@180257 bbb929c8-8fbe-4397-9dbb-9b2b20218538

These checks make the tests longer and don't seem particularly useful.

Review URL: https://codereview.chromium.org/462253003

git-svn-id: svn://svn.chromium.org/blink/trunk@180256 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch makes the creation of custom elements through type
extension, to be case insenstive.

BUG=282467

Review URL: https://codereview.chromium.org/442343002

git-svn-id: svn://svn.chromium.org/blink/trunk@180255 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This is a follow-up fix for https://codereview.chromium.org/462423003/.
It's inconsistent that workerGlobalScopeDestroyed is called while
workerGlobalScopeStarted is not called. In fact, workerGlobalScopeDestroyed
is a signal to let the WorkerMessagingProxy know that the worker thread
is terminated, it should be renamed to workerThreadTerminated.

BUG=403179

Review URL: https://codereview.chromium.org/468883002

git-svn-id: svn://svn.chromium.org/blink/trunk@180254 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This allows for a better code structure and code reuse by alternative
devtools frontends.

R=pfeldman@chromium.org, pfeldman, vsevik

Review URL: https://codereview.chromium.org/471433004

git-svn-id: svn://svn.chromium.org/blink/trunk@180253 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=pfeldman@chromium.org, pfeldman, vsevik
BUG=403087

Review URL: https://codereview.chromium.org/475713002

git-svn-id: svn://svn.chromium.org/blink/trunk@180252 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Before this patch, register() always returns new registration object
even if the same registration already exists. This patch makes
register() return the existing object if it's available.

Chromium-side change: https://codereview.chromium.org/470843002/

NOTE: ServiceWorkerRegistration is still disabled and this change does
not affect the existing code/behavior.


BUG=396400
TEST=https://codereview.chromium.org/466723002/
NOTRY=true

Review URL: https://codereview.chromium.org/473743002

git-svn-id: svn://svn.chromium.org/blink/trunk@180251 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=apavlov
NOTRY=true

Review URL: https://codereview.chromium.org/474783003

git-svn-id: svn://svn.chromium.org/blink/trunk@180250 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Use |element| for the variable (italic in spec) and add missing word:
https://www.w3.org/Bugs/Public/show_bug.cgi?id=26580

NOTRY=true

Review URL: https://codereview.chromium.org/473803002

git-svn-id: svn://svn.chromium.org/blink/trunk@180249 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=180241

BUG=350404
TBR=h.joshi@samsung.com

Review URL: https://codereview.chromium.org/476633003

git-svn-id: svn://svn.chromium.org/blink/trunk@180248 bbb929c8-8fbe-4397-9dbb-9b2b20218538

 - Remove blink:: prefix
 - Remove *using namespace* usage

BUG=

Review URL: https://codereview.chromium.org/471503002

git-svn-id: svn://svn.chromium.org/blink/trunk@180247 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=403430
R=eustas@chromium.org, lushnikov@chromium.org

Review URL: https://codereview.chromium.org/468043004

git-svn-id: svn://svn.chromium.org/blink/trunk@180245 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Review URL: https://codereview.chromium.org/464273002

git-svn-id: svn://svn.chromium.org/blink/trunk@180244 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This exemption allowed the fullscreen element stack to get into a state
not otherwise possible, namely with elements in any order as opposed to
in tree order. It also seemed possible to enter fullscreen in a sibling
iframe, leading to a (cross-document) set of fullscreen elements forming
a tree instead of a simple chain, a case without any test coverage.

Removing the exemption means that a webkitfullscreenerror event will be
fired if one is already in fullscreen and requests fullscreen for an
element other than a descendant of the current fullscreen element.

The use counter was intended to tell whether any content depends on this
or not, but data will not be available for a long time yet. In order to
be affected one needs to, in fullscreen, have a currently visible button
request fullscreen for an element currently not visible, which seems
far-fetched, so site compat is probably not a problem.

The use counter for webkitRequestFullScreen() provides an upper bound:
http://www.chromestatus.com/metrics/feature/timeline/popularity/177

BUG=383813

Review URL: https://codereview.chromium.org/458223003

git-svn-id: svn://svn.chromium.org/blink/trunk@180243 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=haraken
BUG=
NOTRY=true

Review URL: https://codereview.chromium.org/471823002

git-svn-id: svn://svn.chromium.org/blink/trunk@180242 bbb929c8-8fbe-4397-9dbb-9b2b20218538

ThirdWidth, QuarterWidth and will take complex path
while rendering.

BUG=350404

Review URL: https://codereview.chromium.org/263363005

git-svn-id: svn://svn.chromium.org/blink/trunk@180241 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=180228

BUG=351981
TBR=yosin@chromium.org

Review URL: https://codereview.chromium.org/477563002

git-svn-id: svn://svn.chromium.org/blink/trunk@180240 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=398742

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180013

Review URL: https://codereview.chromium.org/451603002

git-svn-id: svn://svn.chromium.org/blink/trunk@180239 bbb929c8-8fbe-4397-9dbb-9b2b20218538

SVGElementRareData is including more than it needs to, this patch reduces it.

Review URL: https://codereview.chromium.org/468553004

git-svn-id: svn://svn.chromium.org/blink/trunk@180238 bbb929c8-8fbe-4397-9dbb-9b2b20218538

At the moment alerts are being stored both at
http://sheriff-o-matic.appspot.com/alerts and
http://auto-sheriff.appspot.com/data . auto-sheriff will be turned
down, so stop reading alerts from there.

BUG=401358
NOTRY=true

Review URL: https://codereview.chromium.org/476593002

git-svn-id: svn://svn.chromium.org/blink/trunk@180237 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This is for consistency with ScriptForbiddenScope,
which is often used with EventDispatchForbiddenScope.

Review URL: https://codereview.chromium.org/446063007

git-svn-id: svn://svn.chromium.org/blink/trunk@180236 bbb929c8-8fbe-4397-9dbb-9b2b20218538

There's not really a useful difference between unittests and integration
tests in webkitpy these days, so this removes the integrationtest concept
and renames the files for consistency w/ everything else.

This is being done in preparation for replacing test-webkitpy with the
generic python test runner (by removing nonstandard things from test-webkitpy).

This also removes the custom TestLoader I wrote since we don't need it any more.

R=eseidel@chromium.org
BUG=402172

Review URL: https://codereview.chromium.org/454223003

git-svn-id: svn://svn.chromium.org/blink/trunk@180235 bbb929c8-8fbe-4397-9dbb-9b2b20218538