- 16 Feb, 2018 21 commits
-
-
Dmitry Titov authored
This causes some test breakage since feature is still in development. The previously landed CL is https://chromium.googlesource.com/chromium/src/+/ccee22ccb0ed0ebf4f1ec417bddee0a0219132e2 Bug: 812899 Change-Id: I16657bc47fd69048cb8673ee4eca0aa77686da64 Reviewed-on: https://chromium-review.googlesource.com/923167Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Commit-Queue: Dmitry Titov <dimich@chromium.org> Cr-Commit-Position: refs/heads/master@{#537127}
-
Aaron Leventhal authored
The keyword hint, which is shown when a tab key will begin a keyword search, tells users about the feature and should be spoken via screen readers. - The alert ends up being fired only when the keyword changes. - It is fired the first time the hint is shown and not again until a different hint his shown, even if the hint disappears and reappears during that time (e.g backspace + retyping a character). this is less noisy overall for the screen reader user. - The alert event exists on all platforms we support. Bug: 812647 Change-Id: Ibcfa0da3e40aeb54cc8da43e77b869a3eb20836f Reviewed-on: https://chromium-review.googlesource.com/922021Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#537126}
-
David Bokan authored
Fixes DevTools' inspector-protocol getLayoutMetrics call to use the actual layout viewport when --root-layer-scrolls is turned on, rahter than explicitly using the FrameView. When the flag is on, this will be the LayoutView's PaintLayerScrollableArea (and FrameView if the flag is off). TEST=inspector-protocol/page/get-layout-metrics.js Bug: 417782 Change-Id: I2fad0323e40fd153b578253d86bb152c39077423 Reviewed-on: https://chromium-review.googlesource.com/923007Reviewed-by:
Steve Kobes <skobes@chromium.org> Reviewed-by:
Stefan Zager <szager@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#537125}
-
Charles 'Buck' Krasic authored
R=rch@chromium.org Change-Id: Ie34f61b29a3c686968e92d214e4279a30e0dec1f Bug: 802894 Change-Id: Ie34f61b29a3c686968e92d214e4279a30e0dec1f Reviewed-on: https://chromium-review.googlesource.com/922864 Commit-Queue: Buck Krasic <ckrasic@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#537124}
-
Yixin Wang authored
This may cause the client to send HTTP/2 PRIORITY frames to inform server of new HTTP/2 stream dependencies. Change-Id: I025cd6ad4d1a887fa8190e7cd21bc7f92642b4e3 Reviewed-on: https://chromium-review.googlesource.com/914109 Commit-Queue: Yixin Wang <wangyix@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#537123}
-
Malay Keshav authored
The clip path for tab is not being scaled based on the device scale leading to incorrectly clipped tabs at HiDPI. Bug: 812472 Change-Id: I4f016dec409dbd61eb569efc21eeab98dc3cfd74 Component: Tab, Clipping Reviewed-on: https://chromium-review.googlesource.com/922454Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Malay Keshav <malaykeshav@chromium.org> Cr-Commit-Position: refs/heads/master@{#537122}
-
Aaron Leventhal authored
Address a collection of missing a11y names in browser UI found by iterating through views in the primary UI and checking for non-empty accessible names where the view is focusable. The browser view itself intentionally has no name, so it uses the explicitly empty name attribute flag. The textfield control has been updated so that SetAssociatedLabel can be used to automatically set the name. When this is used the accessibility labelledby relationship is also automatically set. Bug: 781485 Change-Id: Ie6359af94938156ae2ee7f36b73059fe2830cbdc Reviewed-on: https://chromium-review.googlesource.com/905592 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#537121}
-
chcunningham authored
Several flakes over last few days. Potentially related to some difference in Mac 10.13. Disabling while owners investigate. Bug: 811685 Change-Id: Ided6dafc0f9589af9434a076bdcdcebd72d98b48 TBR: ellyjones@chromium.org,tkent@chromium.org,yosin@chromium.org Reviewed-on: https://chromium-review.googlesource.com/922961Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Chrome Cunningham <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#537120}
-
Carlos IL authored
Added an AboutUI page for chrome://connection-help, that displays a subset of the information available at support.google.com/chrome/answer/6098869. On a separate CL, logic will be added to redirect users who visit the online help center and get an interstitial to the chrome://connection-help site. Bug: 811382 Change-Id: Ic53d81a902fd8f59894f935a691b90c6eec98c11 Reviewed-on: https://chromium-review.googlesource.com/854793 Commit-Queue: Carlos IL <carlosil@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Cr-Commit-Position: refs/heads/master@{#537119}
-
https://pdfium.googlesource.com/pdfium.git/+log/625e6fec9ddd..2388506a1ba1 $ git log 625e6fec9..2388506a1 --date=short --no-merges --format='%ad %ae %s' 2018-02-15 dsinclair Revert "Actually enable -Wimplicit-fallthrough for pdfium." 2018-02-15 thakis Actually enable -Wimplicit-fallthrough for pdfium. 2018-02-15 npm Fix roll-freetype script 2018-02-15 dsinclair Make the CFX_XMLNode a MaybeOwned pointer Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I62db53c68c48e431a74452e5e967f6f785b07efb Reviewed-on: https://chromium-review.googlesource.com/923086Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#537118}
-
Joshua Bell authored
Quota operates in terms of origins, but the code is old. Update the QuotaClient interface implemented by storage back-ends to use the dedicated Origin type instead of URL. For storage back-ends that have been internally converted from GURL to Origin, this eliminates Origin<->URL at the API boundary: Indexed DB, Cache Storage. For storage back-ends that have not been converted, this introduces additional conversions which will go away: Service Workers, File System, WebSQL. The Quota system still uses GURLs internally, so it conversions are also introduced there. Additional follow-on work includes using BindOnce/OnceCallback, and converting the public interfaces that chrome/browser/browsing_data uses to query usage over to use url::Origin. Bug: 598424 Change-Id: I4d2d5c5872e0d02307bb624b4e62b2b3d76b1052 Reviewed-on: https://chromium-review.googlesource.com/920782Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#537117}
-
Ned Nguyen authored
Bug: 785603 Change-Id: Ie5192c13f41299aeb784b23ced796f6c540daf73 Reviewed-on: https://chromium-review.googlesource.com/922875Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#537116}
-
Charles Harrison authored
In preparation for a beta experiment. Bug: 661629 Change-Id: Ie63bdcbfb9e610bdfa0aa925b3f9e21644baacb8 Reviewed-on: https://chromium-review.googlesource.com/922002Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#537115}
-
Kurt Horimoto authored
If you animate a UIScrollView's contentOffset while it's decelerating, the CADisplayLink powering the deceleration scrolling is not stopped. As a result, the deceleration will continue after the contentOffset animation is completed. This CL updates fullscreen's scroll to top animation to allow the built-in UIScrollView scroll to top animation, which cancels the deleration CADisplayLink. Bug: 811294 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I2fbb572dca7963e760b3ec417eb3157d9e4a5baf Reviewed-on: https://chromium-review.googlesource.com/922273Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#537114}
-
Danyao Wang authored
This is a code cleanup before changing ReloadWithUserAgentType() to work also with WKBasedNavigationManager, which would not be appropriate to add to tab.mm. This CL also fixed an apparent bug where IsItemRedirectItem() in tab.mm seemed to have always used the wrong polarity in detecting redirect items. Bug: 798836 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Id39b3788a566fc8b188bdceb3a02803e5e182364 Reviewed-on: https://chromium-review.googlesource.com/920101 Commit-Queue: Danyao Wang <danyao@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#537113}
-
chrome://ukmMohamad Ahmadi authored
Bug: 809507 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I584f0412c197f24236b5402f97d9000a9bf92d66 Reviewed-on: https://chromium-review.googlesource.com/916707Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Peter Lee <pkl@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#537112}
-
Gary Kacmarcik authored
Bug: 677564 Change-Id: Ie12715cb93b6339571109978d6f198ec4e6113f6 Reviewed-on: https://chromium-review.googlesource.com/910318 Commit-Queue: Gary Kacmarcik <garykac@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#537111}
-
Victor Costan authored
Bug: 805814 Change-Id: Ib2441c3ed2060e73062c3993a6876314cac9a669 Reviewed-on: https://chromium-review.googlesource.com/921321 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#537110}
-
Mohammad Refaat authored
Bug: 759229, 779106 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ia79cc0ba778e1b24de5cfddab2068f165b77d64e Reviewed-on: https://chromium-review.googlesource.com/922924Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Cr-Commit-Position: refs/heads/master@{#537109}
-
Steven Bennetts authored
i18n() asserts if any unsafe tags are passed to it. We need to HTMLEscape any network names passed to i18n(). Bug: 811562 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I3112dc2f38b0560d1d6ad9fdde91581f1c498a45 Reviewed-on: https://chromium-review.googlesource.com/920903Reviewed-by:
Toni Barzic <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#537108}
-
Steven Bennetts authored
Bug: 811659 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Id8937bcbd6828c8fc38b0e27e6505582ce6c25ca Reviewed-on: https://chromium-review.googlesource.com/920647Reviewed-by:
Toni Barzic <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#537107}
-
- 15 Feb, 2018 19 commits
-
-
Matthew Jones authored
This reverts commit 106dd071. Reason for revert: ToastHWATest still breaking because of this patch: https://ci.chromium.org/buildbot/chromium.android/Lollipop%20Phone%20Tester/18803 Original change's description: > Second reland of "Encapsulate Chrome thread profiling setup into a single class" > > Fixes Android test failure by avoiding implicit creation of the render > thread. Also moves the decision on whether to profile extension processes into > the StackSamplingConfiguration, and cleans up comments. > > This is a reland of f8ad6e3e. > > Original change's description: > > Reland "Encapsulate Chrome thread profiling setup into a single class" > > > > This is a reland of aa63fc1d. > > > > Original change's description: > > > Encapsulate Chrome thread profiling setup into a single class > > > > > > Creates a simple abstraction around the fairly complex profiling setup. > > > This CL switches over the GPU and renderer process usage to this class. > > > The browser process usage will be converted to use this class after it > > > is extended to support periodic profiling (in a follow-on CL). > > > > > > Bug: 808588 > > > Change-Id: I6195571bf3ddd08291f288f475569bd9a88795ef > > > Reviewed-on: https://chromium-review.googlesource.com/905451 > > > Reviewed-by: Scott Violet <sky@chromium.org> > > > Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> > > > Commit-Queue: Mike Wittman <wittman@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#535125} > > > > TBR=sky > > > > Bug: 808588 > > Change-Id: I34f1910116c4e7a500e353c27b85bf7534be43c7 > > Reviewed-on: https://chromium-review.googlesource.com/907508 > > Reviewed-by: Mike Wittman <wittman@chromium.org> > > Commit-Queue: Mike Wittman <wittman@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#535170} > > Bug: 808588 > Change-Id: Id34e6a3e57c144697413ecced43146bf3e6521e9 > Reviewed-on: https://chromium-review.googlesource.com/917197 > Commit-Queue: Mike Wittman <wittman@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Cr-Commit-Position: refs/heads/master@{#537023} TBR=sky@chromium.org,wittman@chromium.org Change-Id: I38fc0f48e73cb4f7c4ac1a31235f655c406f85b4 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 808588 Reviewed-on: https://chromium-review.googlesource.com/922942Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#537106}
-
Ella Ge authored
This Cl add deprecate warning for document.createTouch and createTouchList. This two feature has been deprecate from spec and has very low usage now. To be removed in M68 intent to deprecate and Remove: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/GLbUpUUnQzc Bug: 518868 Change-Id: Id043619f55a241e982fc6347cab26061ed664112 Reviewed-on: https://chromium-review.googlesource.com/915035 Commit-Queue: Ella Ge <eirage@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#537105}
-
Xianzhu Wang authored
Previously we called CompositedLayerRasterInvalidator:: GenerateForPropertyChanged() for each GraphicsLayer that didn't need repaint. This caused performance issues during 1) document lifecycle update when nothing changed 2) GraphicsLayer::Paint called from cc_blink::WebContentLayerImpl which are supposed to be super fast. Instead of calling the function for each GraphicsLayer, now call SetNeedsRepaint for non-composited fixed-position layers on viewport scroll to ensure performance for the critical case. This CL will improve SPv175 record_time (fully cached situation) by about 20% (https://ct.skia.org/results/cluster-telemetry/tasks/chromium_perf_runs/wangxianzhu-20180215060448/html/index.html). Bug: 803867 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I5a3a4fe538f0d807d8bc3dba1dda201e7d659901 Reviewed-on: https://chromium-review.googlesource.com/920658 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#537104}
-
Martin Sramek authored
Currently, consent auditor only supports one feature (Chrome Sync), but we use the enum-type histogram for extensibility in the future. As this histogram didn't fit into existing categories, a new top-level category "Privacy" is introduced. TBR=markusheintz@chromium.org Bug: 781765 Change-Id: I6e4d93e1a45ce1f06e4d18b0cb6e5fa5b4673273 Reviewed-on: https://chromium-review.googlesource.com/911572 Commit-Queue: Martin Šrámek <msramek@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#537103}
-
Yuke Liao authored
FullscreenTestCase/testShowHeaderWhenChildTabCloses is flaky on devices. Bug: 812664 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I7e632efa8823e253264c0d20012ac80c628562e7 Reviewed-on: https://chromium-review.googlesource.com/922261Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#537102}
-
Chris Hamilton authored
This also fixes a small bug in the UpdateTitle function. Receiving a title is not an indication of data having been received as renderers have code for setting an empty title before data has started to arrive. This will be used by an upcoming component that tracks the number of WebContents that are simultaneously loading, in order to give session-restore's TabLoader a better view of the work being performed on the system. BUG=749785 Change-Id: I2fac76f18f122926af5e09f7ae41ff0d83eef225 Reviewed-on: https://chromium-review.googlesource.com/909334Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#537101}
-
Matthew Jones authored
This change replaces the browser controls update logic in overlay panels with a native mojo version. This was the only usage of updateBrowserControls in java web contents which can now be removed. The number of parameters used by the function in OverlayPanel has been reduced to handle how it is being used -- either completely shown or completely hidden. BUG=810937 Change-Id: If17709f43a150dec30b0b9cd0644161b1f5ad265 Reviewed-on: https://chromium-review.googlesource.com/917218 Commit-Queue: Matthew Jones <mdjones@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#537100}
-
chcunningham authored
New test fast/layers/scrollable-area-removed-on-scroll-crash.html Test was added yesterday here https://chromium.googlesource.com/chromium/src/+/3ab971569afab25c6e330b3898fba29288b68732 No-Tree-Checks: true No-Try: true TBR: flackr@chromium.org Bug: 812702 Change-Id: I456220e68f10a39fd607bbce55b5300ff25041e6 Reviewed-on: https://chromium-review.googlesource.com/922266Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Chrome Cunningham <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#537099}
-
Nico Weber authored
Namely, Wtautological-unsigned-zero-compare and Wtautological-unsigned-enum-zero-compare, see http://llvm.org/viewvc/llvm-project?view=revision&revision=322901 If we have to disable them again in the future, it's probably better to use -Wno-tautological-in-range-compare then. Bug: 763392,767059 Change-Id: I8374fc2b9854618052b784be0371f8744b057701 Reviewed-on: https://chromium-review.googlesource.com/922022Reviewed-by:
Hans Wennborg <hans@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#537098}
-
Anita Woodruff authored
- The test method was unused since crrev.com/c/906491 Change-Id: Ia298a907a0eb3fc147b14cbb9ba724e515d70876 Reviewed-on: https://chromium-review.googlesource.com/922082 Commit-Queue: Anita Woodruff <awdf@chromium.org> Commit-Queue: Peter Beverloo <peter@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#537097}
-
Torne (Richard Coles) authored
Instead of hardcoding startswith('Class') to try to deal with generics (which doesn't work when disassembling a class file as the type is java.lang.Class there), just use the existing _StripGenerics function to remove generics from types before converting them to C types. Bug: 787557 Change-Id: Iae2b760bcb8f1407e1e13ba9d692cd463a5a3ad2 Reviewed-on: https://chromium-review.googlesource.com/922501Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#537096}
-
https://pdfium.googlesource.com/pdfium.git/+log/46f79aaad833..625e6fec9ddd $ git log 46f79aaad..625e6fec9 --date=short --no-merges --format='%ad %ae %s' 2018-02-15 rharrison Correctly seek when header size is larger then expected Created with: roll-dep src/third_party/pdfium BUG=811733 The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I7ce520f7395224d24f8d793ff1e58035b8d75033 Reviewed-on: https://chromium-review.googlesource.com/922382Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#537095}
-
bsheedy authored
Adds a new xr.webvr.live.static benchmark. This is a superset of xr.webvr.wpr.static, as some of the sites we would like to run using WPR don't work properly when replayed. So, run against the live sites for these pages. Bug: 808597 Change-Id: I520d9a71c8a13878f02c8c6bddfbced2240ab9bd Reviewed-on: https://chromium-review.googlesource.com/912548 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#537094}
-
Min Qin authored
During annotation, an extra 16 characters(zone identifier) are appended to the file name. That may cause the file path to exceed the 260 character limit. This CL fixes that problem by truncating the file name when generating it. BUG=809759 Change-Id: Ie0baa318ccf5824e3ed4df8cf23386653b6747d7 Reviewed-on: https://chromium-review.googlesource.com/919445 Commit-Queue: Min Qin <qinmin@chromium.org> Reviewed-by:
Eric Lawrence <elawrence@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#537093}
-
Matthew Jones authored
This change is a bit of pre-work before adding an asset for the location bar background for Chrome Modern in the compositor. Params have been renamed (and don't necessarily control anything) and some obsolete code has been removed. BUG=803098 Change-Id: I0dd4ec76b9a583a434bda94ecf06f131d1b05925 Reviewed-on: https://chromium-review.googlesource.com/909300Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#537092}
-
kylechar authored
With the pass through command decoder there is no QueryManager instance. It looks like CommandBufferStub was updated to take this into account but not InProcessCommandBuffer. Add equivalent logic to InProcessCommandBuffer so it doesn't crash. This was causing a crash on Windows with the VizDisplayCompositor feature. Bug: 787099 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Iea195682548737cbfdfdb53c1521b1931fb5224f Reviewed-on: https://chromium-review.googlesource.com/921925Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#537091}
-
kylechar authored
Add an OutputSurface for Windows that supports overlays when running with --enable-features=VizDisplayCompositor. The OutputSurface just needs to provide a CompositorOverlayCandidateValidatorWin. Bug: 787486 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I01cf5baea5298386e53d831d0674bde79d1fce28 Reviewed-on: https://chromium-review.googlesource.com/921661 Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#537090}
-
Yuke Liao authored
NavigationAndLoadCallbacksTest.StopFinishedNavigation is failing consistently on devices. Bug: 812669 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I35912dc09646bf8dcfdbbbccebe5774cdc060ef2 Reviewed-on: https://chromium-review.googlesource.com/922321Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#537089}
-
Joe Mason authored
R=csharp Change-Id: I69cd8dcb037e782cb0a1538a35ea0383a7d39b6e Reviewed-on: https://chromium-review.googlesource.com/922163Reviewed-by:
Chris Sharp <csharp@chromium.org> Commit-Queue: Chris Sharp <csharp@chromium.org> Cr-Commit-Position: refs/heads/master@{#537088}
-