GitLab

This CL reverts this commit which actually removes building the
unittests. It also adds the unittests to cast_tests.

https://chromium-review.googlesource.com/c/chromium/src/+/1005027

Bug: 73746352
Test: unittests

Change-Id: I341649507f0440a62905f8eccd442215388130dd
Reviewed-on: https://chromium-review.googlesource.com/1007842
Commit-Queue: Mina Almasry <almasrymina@chromium.org>
Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550674}

Two tokens were missing from the list: allow-orientation-lock and
allow-presentation. In addition, allow-downloads was reported as being
supported, when it actually depends on a runtime flag which is off by
default.

Bug: 739787
Change-Id: Iadea9ebf45c7c0b63e8775f5c10aaa0c764a6807
Reviewed-on: https://chromium-review.googlesource.com/1005414
Commit-Queue: Ian Clelland <iclelland@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550673}

This partially reverts commit 0d72bb14.

Now libwidevinecdmadapter.so has been removed, fix the TODO and remove
default_fatal_linker_warnings since it's not needed anywhere.

Bug: 795158
Change-Id: Icbc62d55657f56cac45b252393d86a3e533f7597
Reviewed-on: https://chromium-review.googlesource.com/1011566Reviewed-by: Hans Wennborg <hans@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550672}

Those fields are private. This removes one more obstacle to making
SSL_SESSION opaque.

Bug: none
Change-Id: I77f8ee631c6b1e0e2f26618d4b6fe8cb1aede9fe
Reviewed-on: https://chromium-review.googlesource.com/1011111
Commit-Queue: Steven Valdez <svaldez@chromium.org>
Reviewed-by: Steven Valdez <svaldez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550671}

Bug: 829773
Change-Id: I54489ef9b232a20065d3fe78d884609bb65b4a87
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.win:win_chrome_official;master.tryserver.chromium.linux:linux_chromium_cfi_rel_ng
Reviewed-on: https://chromium-review.googlesource.com/1011411Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550670}

Allows iOS code in components/, e.g., AutofillManager, to use the class.

Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ie43f72dc09bdce3e4165da9ad9700b79d83f6f5e
Reviewed-on: https://chromium-review.googlesource.com/1011102Reviewed-by: Dominic Battré <battre@chromium.org>
Reviewed-by: Peter Lee <pkl@chromium.org>
Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550669}

Without persisting them, server-side provided intervals are less efficient on
platforms with relatively short app lifetime.

This also allows lower poll intervals for latency-sensitive use cases in cases
when our notifications are not reliable enough (yet).

Bug: 832019
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I69abdc89273dd16301fb32f3a0df6ba51712adf3
Reviewed-on: https://chromium-review.googlesource.com/1010662
Commit-Queue: Tim Schumann <tschumann@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550668}

- Creates a RestoreMounts() function that gets the remembered file systems
from the FSP service and then attempts to remount them. Any shares that fail
to remount will be unmounted from FSP so they are not remounted again.
- Logs when an attempted remount fails.

Bug: chromium:757625
Change-Id: Id7edf64150ddde1df912c8cc733dc2c834b42797
Reviewed-on: https://chromium-review.googlesource.com/990581
Commit-Queue: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550667}

This CL also adds some infrastructure for a more general "condition
tracker" in the throttle.

Bug: 829042
Change-Id: Ib8399025bed474395fa9b709c1b68469ccc34476
Reviewed-on: https://chromium-review.googlesource.com/1006378
Commit-Queue: Charlie Harrison <csharrison@chromium.org>
Reviewed-by: Josh Karlin <jkarlin@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550666}

TBR=cmumford@chromium.org

Bug: 769401
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I9e976ebd5d9a345f86980fe5b1e963c0c3f4b1fe
Reviewed-on: https://chromium-review.googlesource.com/1012128Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550665}

Removed section referencing Electron.

Bug: none
Change-Id: I37267cf9ca3a70cd004f3f96ae3b5a3b3c7c4af2
Reviewed-on: https://chromium-review.googlesource.com/1012188Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Crystal Lambert <crystallambert@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550664}

This CL implements UnifiedSystemTrayView::ChildPreferredSizeChanged so
that the bubble size grows when a notification is added dynamically
during the bubble is open.

TEST=manual
BUG=828752

Change-Id: I2a1146dd8d43b857d72d767987c7d31a8dfe8471
Reviewed-on: https://chromium-review.googlesource.com/1011462Reviewed-by: Evan Stade <estade@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550663}

This CL adds a UI updater for the popup menu. This updater is in charge
of spotlighting the button acting as an anchor for the popup menu and
dimming all the other controls of the toolbar, reducing their alpha.

This new UI updater replace the TabHistoryUIUpdater as the TabHistory
is replaced by the popup menu.

Bug: 830552
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I5dd7391d184c5177ffa3fb1fb5c2479098acb615
Reviewed-on: https://chromium-review.googlesource.com/1010348
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550662}

Creates a new class, SelfSizingTableView, which is a table view that
is capable of calculating its intrinsic size.
Use this class for the omnibox popup table view.

Bug: 821817
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Icc01dfcd20ed1f14e15162ac0085f40273747eac
Reviewed-on: https://chromium-review.googlesource.com/973617
Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550661}

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: If6cd3d0db570e157d76183d5fc5a832340144dc3
Reviewed-on: https://chromium-review.googlesource.com/1005890
Commit-Queue: Aleks Totic <atotic@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550660}

We'd like to remove redundant enums from content/ and chrome/ related
to the Presentation API, and the associated typemapping code.

Eventually we will eliminate all the Presentation API typemaps from content/.

This change eliminates one enum from content, others will follow.

Bug: 817903
Change-Id: I944f114886bee6a10348f33a4355262f3feb5901
Reviewed-on: https://chromium-review.googlesource.com/1003772Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Derek Cheng <imcheng@chromium.org>
Commit-Queue: mark a. foltz <mfoltz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550659}

The target width can be set to zero when the action bar has no
icons. Zero in this case is a valid target width that should be
used instead of the current width when animating.

BUG=831560

Change-Id: Ib6604a9c56a6b922025cd3d3bce2773f78d3eda4
Reviewed-on: https://chromium-review.googlesource.com/1008871
Commit-Queue: Ahmed Fakhry <afakhry@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550658}

This is primarily motivated by the chrome://settings case, which
currently is never autocompleted because the builtin provider only
autocompletes in cases where there is a single suggestion. And any input
that matches chrome://settings also matches subpages such as
chrome://settings/autofill.

However, this change also affects one other current case,
chrome://chrome and chrome://chrome-urls. The former will now be inline
autocompleted.

Bug: 816450
Change-Id: I9671033c27c7f8bab1f7cfcbb2989e507e1aeee5
Reviewed-on: https://chromium-review.googlesource.com/976397
Commit-Queue: Justin Donnelly <jdonnelly@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550657}

TBR=jbudorick@chromium.org

Bug: 832374
Change-Id: I7500d930c5e8de66661e10867e35333d13d04355
Reviewed-on: https://chromium-review.googlesource.com/1011622
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Reviewed-by: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550656}

The recording could have already being stopped by the time auto stop kicks in.

BUG=832332

Change-Id: Ia25f8b7c3fc9c0ba62956ed5d8286fdcc786cdee
Reviewed-on: https://chromium-review.googlesource.com/1011399Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Alexei Filippov <alph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550655}

Bug: 758632
Change-Id: I12b77b94313845e2b38d03313915a23663363a5e
Reviewed-on: https://chromium-review.googlesource.com/1011574Reviewed-by: Ashley Enstad <ashleymarie@chromium.org>
Commit-Queue: Emily Hanley <eyaich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550654}

Currently media gallery api reads media data from a blob in browser
process with extension's blob reader.

This CL abstracts a factory class to create MediaDataSource, so that
Android can implement a different source that read data from local file.

Eventually, media gallery api will not depend on extension, which is
not supported on Android, and can have different data source.

Bug: 826021,826975
Change-Id: I6d9d6c0ffc8cbae42cd036af34fb4944cf25e685
Reviewed-on: https://chromium-review.googlesource.com/997012
Commit-Queue: Xing Liu <xingliu@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550653}

BUG=824954

Change-Id: I473641d51907cdab567df7110b6c4415876c03f8
Reviewed-on: https://chromium-review.googlesource.com/1011583Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550652}

This is a follow-up CL for
https://chromium-review.googlesource.com/c/chromium/src/+/994552/12/third_party/blink/renderer/platform/scheduler/public/frame_or_worker_global_scope_scheduler.h#13

Bug: 826203
Change-Id: Id43950524c7f74f797942bc43b7f51c5abe805be
Reviewed-on: https://chromium-review.googlesource.com/1006837
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Hajime Hoshi <hajimehoshi@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Yuta Kitamura <yutak@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550651}

This CL fixes a bug where when zooming out from the tab grid, the
selection state change wasn't animated. It also makes the slection state
change animations longer.

Bug: 804536
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ic3dba63a1c83bb967e66e110de299ce7cb898006
Reviewed-on: https://chromium-review.googlesource.com/1012073
Commit-Queue: Mark Cogan <marq@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550650}

This reverts commit 7c3d1d13.

Reason for revert: WebviewLoginTest.Basic is still flaky on linux-chromeos-rel
https://ci.chromium.org/buildbot/chromium.chromiumos/linux-chromeos-rel/6886
https://ci.chromium.org/buildbot/chromium.chromiumos/linux-chromeos-rel/6887


Original change's description:
> Reland: Use PostTask to schedule cross-process postMessage forwarding.
> 
> Changes from original attempt at https://crrev.com/c/999182:
> - fix flakiness in two additional ChromeOS login tests
> - fix CSP WPT tests to not depend on ordering between iframe's onload
>   and postMessage - see https://crbug.com/832319.
> 
> Previously, we sent the IPC to forward a cross-process postMessage
> immediately.  This caused a behavioral difference from the
> same-process case where the postMessage is always scheduled.  Namely,
> in a scenario like this:
> 
>   frame.postMessage(...);
>   doSomethingThatSendsIPCsToFrame(frame);
> 
> the IPCs from JS following the postMessage would've been ordered
> incorrectly, causing |frame| to see their side effects after the
> postMessage dispatch in the cross-process case, whereas they would be
> seen before the postMessage dispatch in the same-process case.  One
> example of this is frame.focus(), and another is a frame element
> onload event (dispatched via FrameHostMsg_DispatchLoad) arriving after
> a postMessage dispatched from an inline script while the frame was
> still loading.
> 
> To resolve these ordering concerns, this CL changes cross-process
> postMessage to do a PostTask on the sender side before sending the
> message to the browser process.  This improves the current state of
> the world, but does not yet achieve a perfect match for the IPC
> ordering in the same-process case - see discussion on the bug.
> 
> Bug: 828529
> Change-Id: I62a627c501526d09900be4f5bd2c899acf4d1e07
> Reviewed-on: https://chromium-review.googlesource.com/999182
> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Commit-Queue: Alex Moshchuk <alexmos@chromium.org>
> Cr-Original-Commit-Position: refs/heads/master@{#550284}
> Reviewed-on: https://chromium-review.googlesource.com/1011287
> Cr-Commit-Position: refs/heads/master@{#550621}

TBR=xiyuan@chromium.org,dcheng@chromium.org,alexmos@chromium.org

Change-Id: Ic0637a6038bed6e5334a26e1934bee81faad3b9e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 828529
Reviewed-on: https://chromium-review.googlesource.com/1012138Reviewed-by: Ben Pastene <bpastene@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550649}

Now with only 2 callers to PrintJob::UpdatePrintedDocument(), it is easy
to see the "settings_ = " assignment inside it is just a case of:

doc_settings = settings_;
settings_ = doc_settings;

Change-Id: I5a82ab9c0b3631585e3a65a1e74f16bf9b1e4b6c
Reviewed-on: https://chromium-review.googlesource.com/1000959
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550648}

Design doc: go/chrome-no-searchdomaincheck

Bug: 825255
Change-Id: I6be6ca5928a52901fba2fbd24405a1b11fd9d54a
Reviewed-on: https://chromium-review.googlesource.com/1002842
Commit-Queue: Quentin Fiard <qfiard@google.com>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550647}

Move MojoChannel code out of ArcBridgeHostImpl into its own file
to be shared.

Bug: 768439
Change-Id: I730ae1f498893455f3aa2e768f47893409109768
Reviewed-on: https://chromium-review.googlesource.com/1012136Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
Commit-Queue: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550646}

NOTRY=true

Bug: 779634
Change-Id: If5bd29aa5715477be41120278d003ebe6dcdeb78
Reviewed-on: https://chromium-review.googlesource.com/1012127
Commit-Queue: Emily Hanley <eyaich@chromium.org>
Reviewed-by: Ashley Enstad <ashleymarie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550645}

AudioDecoderConfig was changed to a type map a while back. EncryptionPattern
has no implementation anyway.

BUG=611224
TEST=media_mojo_unittests passes

Change-Id: I20a83d4ca20819447c563fd19207914fe04f0381
Reviewed-on: https://chromium-review.googlesource.com/1011360Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: John Rummell <jrummell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550644}

Bug: 832591
Change-Id: I8d104a7e0ede58f20d71bb5ce00f8b398cf8e28b
Reviewed-on: https://chromium-review.googlesource.com/1012023Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Michal Pichlinski <mpichlinski@opera.com>
Cr-Commit-Position: refs/heads/master@{#550643}

BUG=832019

Change-Id: I593499bea1ccaad680d96d572f119b19c8fdc6aa
Reviewed-on: https://chromium-review.googlesource.com/1010344
Commit-Queue: Tim Schumann <tschumann@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550642}

There were three minor bugs left in the implementation:

  - We threw on lists-in-custom-iterators instead of just ignoring them.
  - We returned all properties on the keyframe rather than just those
    defined on the keyframe itself (e.g. we would include prototype
    properties, against spec).
  - We didn't access the properties in ascending unicode order.

Bug: 827573
Change-Id: I213ae5b24e1f35d7f28d16625025122950a6ba88
Reviewed-on: https://chromium-review.googlesource.com/989261Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550641}

Also refator CdmService so that we can override service release delay for
testing.

Bug: 826039
Change-Id: I595a26c019ee760c49a2bac638c4f928101f6423
Reviewed-on: https://chromium-review.googlesource.com/1011404Reviewed-by: John Rummell <jrummell@chromium.org>
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550640}

dma-buf memory mapping is supported upstream, so there is no longer any
need to check for this on non-ChromeOS platforms.

Bug: b/72096671
Test: Ran on non-ChromeOS device and ensured DCHECK isn't hit.
Change-Id: Id0a1d35207c40167dfa765c89d4e75db79f171f6
Reviewed-on: https://chromium-review.googlesource.com/1012142Reviewed-by: Alex Sakhartchouk <alexst@chromium.org>
Commit-Queue: Daniel Nicoara <dnicoara@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550639}

Change-Id: I32144548e5427a1e50491259dadf729a743a54df
Bug: 831610
Reviewed-on: https://chromium-review.googlesource.com/1000134Reviewed-by: agrieve <agrieve@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Commit-Queue: Brandon Jones <bajones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550638}

Replace UpdatePrintedDocument(nullptr) with ClearPrintedDocument().
The two methods are simpler to understand than the existing combined
method.

Also get rid of all "new" uses in PrintJob.

Change-Id: I55a51233b0cc9f30c45301703e57b311738f3891
Reviewed-on: https://chromium-review.googlesource.com/1000956Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550637}

arraysize is already exposed via including base/macros.h in the
std_lib_extras.h header file. So it makes no sense to reimplement
WTF_ARRAY_LENGTH.

Replaced via
git grep -l WTF_ARRAY_LENGTH | xargs -x sed -i "s/WTF_ARRAY_LENGTH/arraysize/g

BUG=None

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I1aa659bb689605d878c09f83ca0d4857baebe683
Reviewed-on: https://chromium-review.googlesource.com/1012125Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550636}

- Creates a helper class that manages the creation and parsing of
a compound file_system_id.
- Switches to these functions.

Bug: chromium:757625
Change-Id: I611cfdf213da104f1dc63ce7ba442298bd362f41
Reviewed-on: https://chromium-review.googlesource.com/990580
Commit-Queue: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550635}