GitLab

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/7eee1a626bd1..80a89976c142

git log 7eee1a626bd1..80a89976c142 --date=short --no-merges --format='%ad %ae %s'
2019-11-08 yangguo@chromium.org Simplify build

Created with:
  gclient setdep -r src/third_party/devtools-frontend/src@80a89976c142

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC v8-waterfall-sheriff@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

TBR=v8-waterfall-sheriff@grotations.appspotmail.com

Bug: None
Change-Id: I6082e6fa1d9fecd32a369126a4531121929c0e19
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906714Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#713960}

Chrome is a special extenision app, which doesn't launch a new tab,
but reuses the current item in shelf, when click the icon in
app_list. So work around the issue for Chrome. When AppService
Instance feature is ready, AppService should check the shelf id or
window for Chrome, and not re-launch a new tab.

BUG=1022541

Change-Id: Iddac3f0749f8bad4fc5396f1152a73cef5c2ad54
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1905303Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Nancy Wang <nancylingwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#713959}

Creates another VoteAggregator class that allows expressing "priority
boosting" votes, which can be used to resolve priority inversions.

BUG=971272

Change-Id: If84f0a7a22598de5f7a8897eb12066fbc5a00ccb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1853867Reviewed-by: Etienne Pierre-Doray <etiennep@chromium.org>
Commit-Queue: Chris Hamilton <chrisha@chromium.org>
Cr-Commit-Position: refs/heads/master@{#713958}

Change base::Bind to base::BindOnce or base::BindRepeating as
appropriate..

Bug: 1007798
Change-Id: I0bc1f2049624a4c4a1423139fd061ae84d6aa0ff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902269Reviewed-by: Olga Sharonova <olka@chromium.org>
Commit-Queue: Raymond Toy <rtoy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#713957}

Chromium's only exists for historic reasons, currently serving
documentation purposes only. AndroidX's version is supported by
Android lint, though the check at build time is not currently
working (crbug.com/1022939). This check is still useful for
Android Studio.

Bug: 889467
Change-Id: I491efe7472e03cddfdc20009341955ed92bc7e81
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1907194Reviewed-by: Yuchen Liu <yucliu@chromium.org>
Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#713956}

The code was actually removed a while ago but the histogram hadn't yet
been marked obsolete.

Bug: 1018793
Change-Id: Idade711cc8782aa6415058e4ce97e469493a3b55
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906259Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Commit-Queue: Doug Arnett <dougarnett@chromium.org>
Cr-Commit-Position: refs/heads/master@{#713955}

This reverts commit 2b5d8199.

Reason for revert: Causing consistent base_unittests StackTraceTest.OutputToStream failures on:
https://ci.chromium.org/p/chrome/builders/ci/chromeos-kevin-google-rel/3709

Original change's description:
> [base] Cleanup StackTraceTest.OutputToStream #ifdef soup.
> 
> Bug: 999737, 706728
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1780074
> Commit-Queue: Wez <wez@chromium.org>
> Reviewed-by: Albert J. Wong <ajwong@chromium.org>
> Auto-Submit: Wez <wez@chromium.org>
> Cr-Original-Commit-Position: refs/heads/master@{#712377}
> Change-Id: I627b5250055233ea89718a9143de356c85633add
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1905270
> Cr-Commit-Position: refs/heads/master@{#713876}

TBR=ajwong@chromium.org,wez@chromium.org

Change-Id: I2e09ac22e3c2fa66312d142664e7b03c1950989f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 999737, 706728
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906545Reviewed-by: Michael Wasserman <msw@chromium.org>
Commit-Queue: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#713954}

Three tests are timing out occasionally on Mac FYI Retina Release
(NVIDIA). Mark as RetryOnFailure to suppress failures as Mac Nvidia
drivers are unlikely to get fixed.

Bug: 1022831
Change-Id: If241719809f135546d89ca13fb69e4107a06cb9c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906879Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Commit-Queue: kylechar <kylechar@chromium.org>
Auto-Submit: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#713953}

Move common test helpers to TabUiTestHelper for easier reuse. This is a
rather mechanical moving without functional changes.

Bug: 983170
Change-Id: I7aaace040a1a93f653761cc73661c46ec92dd591
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903691Reviewed-by: Mei Liang <meiliang@chromium.org>
Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#713952}

Bug: 923594
Change-Id: I20025d7919c07d29b466a4d36d7a2c36b47d5cb6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896299
Commit-Queue: Max Li <themaxli@chromium.org>
Reviewed-by: Josh Nohle <nohle@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#713951}

Address review comments from jdarpinian.

Bug: 681341
Change-Id: I68923295cbc6699c1a313e18af4dd8c0ea226354
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1907106Reviewed-by: James Darpinian <jdarpinian@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#713950}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/d5c0b56e84e0..039522eb577e

git log d5c0b56e84e0..039522eb577e --date=short --no-merges --format='%ad %ae %s'
2019-11-08 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).

Created with:
  gclient setdep -r src/third_party/depot_tools@039522eb577e

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/depot-tools-chromium-autoroll
Please CC agable@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

TBR=agable@chromium.org

Bug: None
Change-Id: I935c94bd9772a227a33aa644625a0c62c18a68f8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906710Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#713949}

The test helpers will be moved to TabUiTestHelper for easier reuse.

Bug: 983170
Change-Id: I6266e4599028258e97c0c69238f09293fc42cff2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904824Reviewed-by: Yue Zhang <yuezhanggg@chromium.org>
Reviewed-by: Mei Liang <meiliang@chromium.org>
Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#713948}

Iterators in TransactionalLevelDB are evicted when there are any
changes to the database. There is an edge case where an iterator is
evicted while on the 'last' key of the database, and that key is
deleted. When reloaded, it Seek()s to the previous key, only to
become 'Invalid' because it reaches the end of the database.
Unfortunately leveldb doesn't allow 'Prev' to be called from the end
of the database and instead just stays invalid.

The fix checks for the state where 'the iterator was valid before
eviction and is invalid after reloading' in the Prev() method. In
this state, there must be no no keys at or after the previously
loaded key. Thus calling SeekToLast() will correctly position the
iterator at the first element 'Prev' the previously loaded key.

Bug: 1022594
Change-Id: Ifa938b441683ea9f2cac5d926ff22b734ab4bb67
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1897007
Commit-Queue: Daniel Murphy <dmurph@chromium.org>
Auto-Submit: Daniel Murphy <dmurph@chromium.org>
Reviewed-by: Ken Rockot <rockot@google.com>
Cr-Commit-Position: refs/heads/master@{#713947}

TBR: changwan@chromium.org
Bug: 1022954
Change-Id: I3d5d259e3b045181f3c57ff70dcd3fcb4b1a279a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1907191Reviewed-by: Shimi Zhang <ctzsm@chromium.org>
Reviewed-by: Changwan Ryu <changwan@chromium.org>
Commit-Queue: Shimi Zhang <ctzsm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#713946}

Looks like intrusive_heap doesn't work on explicitly move-deleted types
any more because vector::push_back doesn't. It seems this unit test is
the only place this happens so far.

This CL takes the temporary fix from crrev.com/c/1881953/1..2 (namely,
remove test cases of move-deleted value types and add a comment about
why), in order to unblock the LKGM uprev (e.g. crrev.com/c/1900888).

Bug: chromium:1022033, chromium:1022576
Tested: Compiled with cros-sdk --version 12651.0.0
Change-Id: Ifbb93b7b3b17a2880bf4f0bab274fb505f32ee39
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904550Reviewed-by: vmpstr <vmpstr@chromium.org>
Commit-Queue: Aga Wronska <agawronska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#713945}

Use WTF::String instead, now that the classes are solely used
within Blink.

BUG=787254
R=guidou@chromium.org, haraken@chromium.org

Change-Id: I0b43eefea87bf48367903a935ee06bb22f245113
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906507
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#713944}

This CL updates the text alignment issues for RTL layout in
1 - Download home list item title text
2 - Download home storage summary text
3 - Ephemeral tab's title and URL bar

Bug: 1022549
Change-Id: I85ade78c8e308299dbc5df3add598d253a0404be
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904499Reviewed-by: David Trainor <dtrainor@chromium.org>
Auto-Submit: Shakti Sahu <shaktisahu@chromium.org>
Commit-Queue: Shakti Sahu <shaktisahu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#713943}

Bug: 1021236
Change-Id: I1d1b5180048eb36fa78406a02fc3277cba0dcf63
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904809
Commit-Queue: Eric Roman <eroman@chromium.org>
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Auto-Submit: Eric Roman <eroman@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#713942}

https://chromium.googlesource.com/angle/angle.git/+log/dc98ca69edd0..50919254cbc7

git log dc98ca69edd0..50919254cbc7 --date=short --no-merges --format='%ad %ae %s'
2019-11-08 enga@chromium.org Only enable addAndTrueToLoopCondition feature on Mac Intel

Created with:
  gclient setdep -r src/third_party/angle@50919254cbc7

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC jonahr@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=jonahr@google.com

Bug: chromium:1021900,chromium:644669
Change-Id: Ie641626a4886f4f031e8f52eb65764238bf0e571
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906110Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#713941}

Ensure that the toast message is the correct width while still centered.
Prior to this CL, the toast message is too elongated for short messages.
This CL ensures that the width of the toast message is just long enough
while centered.

screenshots (both after):
https://screenshot.googleplex.com/2veWnqVG26S
https://screenshot.googleplex.com/Ljyu6q9gACR

Bug: 1022312
Change-Id: Ieb85e48ac7dda031c789bcd3b70d55130d62b390
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903596Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Commit-Queue: Regan Hsu <hsuregan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#713940}

GetImmersiveVrDisplayInfo (and the EnsureInitialized call it triggered)
were WebVr compatibility methods that, with the removal of webvr, were
no longer called.

Bug: 1017872
Change-Id: Ia4b5350d4a2fea47e155ae9ddfa0cb125bf979c5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900134
Commit-Queue: Alexander Cooper <alcooper@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Piotr Bialecki <bialpio@chromium.org>
Cr-Commit-Position: refs/heads/master@{#713939}

Removes unused webvr_default_framebuffer_scale and display_name attributes
now that WebVr has been deleted. Additionally removes the
VRDisplayCapabilities struct and corresponding attribute. Only two values
of this struct were referenced outside of being set:
 * can_provide_environment_integration - This was only used as a DCHECK
 in xr.cc to validate the return value from the browser process, which
 should be trusted from the start. Additionally, if the device cannot
 provide environment integration GetEnvironmentIntegrationProvider call
 will report an error, which should serve the same purpose for development
 purposes.
 * has_external_display - This was used to set a bool on frame submit
 which didn't actually impact any behavior except for a DCHECK that the
 value was as expected for the xr_frame_transport type.

Devices that only set the webxr_default_framebuffer_scale attribute to the
default value no longer set it. This will pave the way for any future
changes to that attribute to be made more easily.

Bug: 1017843
Change-Id: I52cafc242654ea10c39dbd9d8b7428c390801c65
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902074Reviewed-by: Brandon Jones <bajones@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Klaus Weidner <klausw@chromium.org>
Reviewed-by: Ian Vollick <vollick@chromium.org>
Commit-Queue: Alexander Cooper <alcooper@chromium.org>
Cr-Commit-Position: refs/heads/master@{#713938}

Migrates RetrieveDMToken calls and class member to use the new
BrowserDMToken class.

Bug: 1020296
Change-Id: Id86d2a41a640d27abf175434faf923b041d764e6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904273
Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org>
Reviewed-by: Daniel Rubery <drubery@chromium.org>
Reviewed-by: Roger Tawa <rogerta@chromium.org>
Reviewed-by: Tien Mai <tienmai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#713937}

Because weblayer is packaged together with WebView the
upstream vs downstream (i.e. public vs internal)
implementations need to be compiled depending on the
existing targets. For example we can have AOSP targets
(with clank/ present) in which case we still need to
use the upstream version of the safebrowsing related
class (GmsBridgeImpl.java).

To have this effect this patch updates the
upstream_only_deps variable to include the weblayer
safebrowsing upstream target. It also updates the deps
of WebLayerSupport.apk to always have the upstream
(public) target.

Analogously the downstream build configs will be updated
to include the downstream version (in a separate
downstream patch).

BUG=1015418

Change-Id: I0a38295610b306a018c1565b4e96f89a080ca20a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895658
Commit-Queue: Tim Volodine <timvolodine@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#713936}

CL 1893118 introduced a new dump test that uses PosInSet/SizeOfSet,
which are not available on Win7's UIA implementation. This change
adds an expected file for Win7 that does not include these properties

Original CL:
https://chromium-review.googlesource.com/c/chromium/src/+/1893118


Change-Id: I2d6b43a67b18e30dd864e46f83479b5819e9e5d2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906927Reviewed-by: Kevin Babbitt <kbabbitt@microsoft.com>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Commit-Queue: Kevin Babbitt <kbabbitt@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#713935}

Bug: 1021236
Change-Id: I821d12f4a420a59e61722f85a024ff7253b871a2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904759
Auto-Submit: Eric Roman <eroman@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#713934}

* Don't expose FrameView as it's not public
* Allow non ARC window to fill the caption related fields.

Bug: 1021604
Test: covered by unittests

Change-Id: I87b0f645be901bed3c078fa000837d34e39cdc44
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902115Reviewed-by: Jun Mukai <mukai@chromium.org>
Commit-Queue: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#713933}

The primary motivation is that the previous incantation looked
suspicions: even though the rules of C++ are very clear about type
casting when adding 255 as a uint8 and 1 as an int and then using it as
an argument for a function that takes a uint64, it is too much to think
about.  This CL uses RandBytes() instead of read a single byte.

(Incidentally RandGenerator() implementation is a bit complicated, and
always reads 64 random bytes, quite unnecessarily in this case.)

Bug: 1020233
Change-Id: I3e5610779c1643f86f2d615915931903d4962448
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906466
Commit-Queue: Ryan Hamilton <rch@chromium.org>
Reviewed-by: Ryan Hamilton <rch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#713932}

https://skia.googlesource.com/skia.git/+log/2e30fde04687..f0ade8a687ee

git log 2e30fde04687..f0ade8a687ee --date=short --no-merges --format='%ad %ae %s'
2019-11-08 jlavrova@google.com Fixing no icu situation
2019-11-08 reed@google.com add flatten test to SkFont
2019-11-08 csmartdalton@google.com Defer stencil attachment until opsTask execution
2019-11-08 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2019-11-08 mtklein@google.com add SkColorTypeIsNormalized()

Created with:
  gclient setdep -r src/third_party/skia@f0ade8a687ee

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC ethannicholas@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=ethannicholas@google.com

Bug: None
Change-Id: Idde543a693c80123430a1860bfb532f661b4c169
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906713Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#713931}

The old EncryptionScheme is deprecated and replaced by EncryptionMode.
So rename EncryptionMode to EncryptionScheme.

Now Audio/VideoDecoderConfig only carries EncryptionScheme.
EncryptionPattern is passed to Renderer in DecryptConfig/DecoderBuffer.

Bug: 825041
Test: CQ, build, media_unittests
Change-Id: Iecf8720a20141939460f150d2b6abf092e621117
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885501Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: John Rummell <jrummell@chromium.org>
Commit-Queue: Yuchen Liu <yucliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#713930}

This change moves the definition of DidChangeThemeColor
from FrameHost to LocalFrameHost in blink. It removes the public
definition on the WebLocalFrameClient as it isn't necessary anymore.

BUG=1008432

Change-Id: I7c78c34d0dc4b81733b649dc8b3bf8aab334f3e9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899321
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#713929}

The heavy ad intervention currently does not trigger when a blocklist
is not available. We do not setup the blocklist in incognito mode.

This change creates a blocklist for incognito profiles with no
backing store, which simply creates an in-memory blocklist. This allows
us to have very similar behavior across incognito & non-incognito.

Bug: 1022806
Change-Id: I0d1e48adc08eb6dd93fb8a9ac6dd6b848f0ca348
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902528
Commit-Queue: John Delaney <johnidel@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#713928}

This reverts commit 1cc1acb5.

Reason for revert: caused Mac ASan 64 Tests (1) browser_tests to fail:
PasswordChangeAuthenticatorUnitTest.DetectPingSuccess
PasswordChangeAuthenticatorUnitTest.DetectAzureSuccess
PasswordChangeAuthenticatorUnitTest.DetectAdfsSuccess
https://ci.chromium.org/p/chromium/builders/ci/Mac%20ASan%2064%20Tests%20%281%29/58281
Reverting as discussed in chat, hopefully this will make the tree a little greener?

Original change's description:
> Disable new JS test for ASAN properly
> 
> JS tests don't work on ASAN, which is a known bug:
> https://crbug.com/1010561
> 
> Use the existing "include_js_tests" flag to exclude
> password_change_authenticator_test as it is intended,
> instead of an ad-hoc solution.
> 
> Bug: 1022385
> Change-Id: Ia81d148dd2c38c17813a2b007be27aa932849679
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904197
> Commit-Queue: Nico Weber <thakis@chromium.org>
> Reviewed-by: Nico Weber <thakis@chromium.org>
> Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#713806}

TBR=thakis@chromium.org,rsorokin@chromium.org,olsen@chromium.org

Change-Id: I68be33e1819fa3c705db82b7e9a49bd5e08e55b3
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1022385
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1907128Reviewed-by: Michael Wasserman <msw@chromium.org>
Commit-Queue: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#713927}

https://android.googlesource.com/platform/external/perfetto.git/+log/5e3eacac1ca1..60c88fd3ec68

git log 5e3eacac1ca1..60c88fd3ec68 --date=short --no-merges --format='%ad %ae %s'
2019-11-08 rsavitski@google.com Merge "ui: remove "idle process" process/thread tracks (utid 0)"
2019-11-08 lalitm@google.com trace_processor: fix counter values best index logic

Created with:
  gclient setdep -r src/third_party/perfetto@60c88fd3ec68

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

TBR=perfetto-bugs@google.com

Bug: None
Change-Id: I8526018d5502b37e34be1b18a5ef0616c056e1fd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906926Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#713926}

Bug: chromium:1021682
Change-Id: Id35d9656d8c278c5b0eeaccf0efe905c58454b0c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900248Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#713925}

When navigating over the network list in the system tray, announce all
visible details including: name, connection status, signal strength,
managed by administrator, secured, etc.

Fixes: 1006390, 1006019
Change-Id: I8b37d4711a329df94c6f16f17e378c3e3de66f5f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899068Reviewed-by: Samuel Huang <huangs@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Jon Mann <jonmann@chromium.org>
Cr-Commit-Position: refs/heads/master@{#713924}

Fix ContentViewRenderView's usage of postOnAnimation
which can lead to leak after destroy as well.

Bug: 1018148
Change-Id: I8d6509eed77355359a285e2ddb67bb80ac1e79de
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903688
Commit-Queue: Bo <boliu@chromium.org>
Reviewed-by: Tobias Sargeant <tobiasjs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#713923}

On the bots, we see phantom time being lost during startup of the
webkit_layout_tests step on each swarming bot. Looking at the logs
from https://bugs.chromium.org/p/chromium/issues/detail?id=982208#c0
we see 25-40s of lost time after "Manifest generation completed".

I narrowed down the majority of this time to be spent inside
_wpt_test_urls_matching_paths(). This method was called 213 times,
once for each virtual test suite, and iterates through multiple
WPT dirs, and then over 30k test paths from the WPT manifest files.

The inner loops of this process was doing far more work than they
needed to do.

We change _all_virtual_tests() to pass a set of virtual test paths
to _wpt_test_urls_matching_paths(), calling it a single time. This
allows us to generate and load the WPT manifests a single time instead
of hundreds of times, saving about 4 seconds of time on my local
machine.

We then re-order the nesting of the loops and move work that needs
to be done to the outer-most loop based on the inputs it depends on.
And we simplify the matching done inside the inner-most loop to a
single string.startswith() call. This saves another 9 seconds of time
on my local machine.

Locally this takes this phantom time from about 14 seconds down to 2
seconds. As the bots have larger phantom time (25-40 seconds) we can
expect to see a larger proportional win there:

On linux-rel we see the phantom time after generating WPT manifests
drop from 19 to 4 seconds (-15 seconds) and on
win10_chromium_x64_rel_ng we see the phantom time drop from 23 to 5
seconds (-18 seconds).

Overall this is reducing the post-manifest phantom time by about
80% (about 20s -> 4s).
It is reducing total time to first test by about 20% (about
90s -> 70s).

R=dpranke@chromium.org

Bug: 982208
Change-Id: Ibb8d6287e456f0910ee43f80e8072743d21bc2f4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903725
Commit-Queue: danakj <danakj@chromium.org>
Reviewed-by: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#713922}

Change the bookmarks Web UI build to be more similar to other Web UI
pages (e.g. extensions, settings, Print Preview) by adding individual
grd files for its resources, and building the optimized page from
an unpak folder.

This will allow the page to leverage existing logic in unpack_pak to
place generated Polymer 3 JS files and non-generated JS module files
in the same folder structure for bundling when the page is migrated
to Polymer 3.

Bug: 1022213
Change-Id: If27d96cefbca79f7b4b238b5123482dab465b4c1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904450Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#713921}