GitLab

Since panels have a promoted -[NSWindow level], OSX prefers them to
browser windows when it needs to activate a window. One case this
happens is whenever an autofill popup is dismissed (e.g. when tabbing
between text fields on a web page).

Sometimes, a panel window may be activated in this case since it thinks
it was the "previous" key window, when actually it was a browser window.

The "previous" key window case doesn't really seem to add much. So
remove it. It means that a panel can lose focus (and not immediately
regain it) when another panel window is closed, but that seems
preferable to tabbing into a Hangouts chat window instead of a password
field when a username autofill popup is dismissed. (Note it doesn't
happen if a *browser* window is closed, since the native close button
doesn't activate a window, but the non-native hangouts close button
does).

The "allow previous" logic was included in r127517 (to fix
http://crbug.com/112038). Closing hangouts windows seems to be the only
use case it supports, and I don't think that use case will be missed.

BUG=546509, 112038

Review URL: https://codereview.chromium.org/1575743003

Cr-Commit-Position: refs/heads/master@{#369347}

IsPlatformSupported() function in extensions/renderer/resources/binding.js
doesn't include 'chromeos' in 'linux' platform.
So, it should do the same to generate correct macros for api registration.

BUG=517773
TEST=None

Review URL: https://codereview.chromium.org/1558413002

Cr-Commit-Position: refs/heads/master@{#369346}

The new audio player has 4px top padding, which is shown white under the window header.
The window size calculation didn't consider it, which causes issues.
- Playlist height grows (issue 576622)
- Scroll bar can be shown when it shouldn't be.
This CL fixes the calculation.

BUG=576622
TEST=manually

Review URL: https://codereview.chromium.org/1576093006

Cr-Commit-Position: refs/heads/master@{#369345}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/dd08748a..302c89a0

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org

Review URL: https://codereview.chromium.org/1582943004

Cr-Commit-Position: refs/heads/master@{#369344}

BUG=295792

Review URL: https://codereview.chromium.org/1579253003

Cr-Commit-Position: refs/heads/master@{#369343}

BUG=none

Review URL: https://codereview.chromium.org/1586853003

Cr-Commit-Position: refs/heads/master@{#369342}

BUG=538612

Review URL: https://codereview.chromium.org/1581083004

Cr-Commit-Position: refs/heads/master@{#369341}

BUG=577010

Review URL: https://codereview.chromium.org/1580653006

Cr-Commit-Position: refs/heads/master@{#369340}

BUG=577246

Review URL: https://codereview.chromium.org/1586863002

Cr-Commit-Position: refs/heads/master@{#369339}

Done by running third_party/polymer/v1_0/reproduce.sh.

Fixes compile error found in https://codereview.chromium.org/1521433002/

BUG=none

Review URL: https://codereview.chromium.org/1561893002

Cr-Commit-Position: refs/heads/master@{#369338}

Part 3 of several.

Adds Chrome specific strings, which are gated to Chrome branded builds.

BUG=560457

Review URL: https://codereview.chromium.org/1573333002

Cr-Commit-Position: refs/heads/master@{#369337}

Handle the case when the display route for a device the user is currently viewing controls for is updated to a different route.

BUG=577335

Review URL: https://codereview.chromium.org/1587803002

Cr-Commit-Position: refs/heads/master@{#369336}

This patch fixes not to break surrogate pairs when word-wrap:
break-word with fit-content.

This combination needs a larger fix in crbug.com/380667, but this fix
is small enough to take at this point, and it is reasonable to handle
trailing pairs when we handle leading pairs.

BUG=574577

Review URL: https://codereview.chromium.org/1575333002

Cr-Commit-Position: refs/heads/master@{#369335}

This function is that calculate distance squared between
Rectangle and Point.

BUG=445329

Review URL: https://codereview.chromium.org/1580363002

Cr-Commit-Position: refs/heads/master@{#369334}

MediaRecorder is supposed to fire an Error event if the amount
of tracks of the associated MediaStream varies. This CL adds
monitoring of said amount and Error firing.

There's no need to stop the MediaRecorder: adding a Track
would not start automatically recording it, and removing it
guarantees it would not be recorded not recording. Moreover,
the spec does not say if MRecorder should stop if the
#Tracks varies, and also instructs to throw an Exception,
which is not possible since the error is asynchronous.

Also this CL removes superfluous test variables.

BUG=545156

Review URL: https://codereview.chromium.org/1578973002

Cr-Commit-Position: refs/heads/master@{#369333}

This is to keep LSAN bots happy.

BUG=561803,574325
TBR=ben

Review URL: https://codereview.chromium.org/1589693002

Cr-Commit-Position: refs/heads/master@{#369332}

under GN. GYP has the same define as well.

Makes packaging webview under a different package (for external
developers) easier. Plus I personally use it for development.

Review URL: https://codereview.chromium.org/1581253002

Cr-Commit-Position: refs/heads/master@{#369331}

Add UserWindow[Controller|Observer] interfaces and impls.
Move shelf code from mojo:system_ui to mojo:shelf.
Add views_examples and task_viewer buttons to the shelf.
Show buttons for open user windows; they focus on press.
Cleanup mash deps tree (move data_deps from all to shell).

BUG=557406
TEST=mojo:mash_shell shelf has rudimentary functionality.
R=sky@chromium.org

Review URL: https://codereview.chromium.org/1576683002

Cr-Commit-Position: refs/heads/master@{#369330}

This adds the ability for experimental API keys to be cryptographically verified
in the browser. There is currently a single fixed signing key, whose public key
is embeddded in the browser code.

This makes use of Ed25519 cryptographic signature verification in boringssl, so
boringssl is added as a dependency to content/common for all platforms (except
iOS)

BUG=543215

Review URL: https://codereview.chromium.org/1522813002

Cr-Commit-Position: refs/heads/master@{#369329}

BUG=557422
R=rickyz@chromium.org
TBR=jam@chromium.org

Review URL: https://codereview.chromium.org/1586833002

Cr-Commit-Position: refs/heads/master@{#369328}

BUG=571121

Review URL: https://codereview.chromium.org/1586903002

Cr-Commit-Position: refs/heads/master@{#369327}

Make sure the right connection maps the window id for the client.

BUG=none
R=sky@chromium.org

Review URL: https://codereview.chromium.org/1584053002

Cr-Commit-Position: refs/heads/master@{#369326}

Most noticeably, default apps like Drive, YouTube, etc. appear on
chrome://apps and are downloaded and "installed" whenever a new profile
is created, and so were getting shortcuts created on Mac.

For shortcut creation, Chrome doesn't currently distinguish these
"default" installs from things installed from the WebStore. But the
logic on Mac was incorrectly triggering shortcut creation for all hosted
app installs, which differs from other platforms. On other platforms,
shortcuts for hosted apps can only created via chrome://apps, or the
bookmark app flow.

This has been for happening for new profile creations on Mac since
r316113 (m42), since it caused web_app::ShouldCreateShortcutFor()  to
unconditionally return `true` even for automated codepaths.

To fix, skip creation of these hosted app shortcuts on Mac when
triggered by AppShortcutManager::OnExtensionWillBeInstalled() by making
web_app::ShouldCreateShortcutFor(..) more closely follow other
platforms.

However, Mac has the problem that shortcuts can break, and require
repair, across Chrome versions. To address this, use custom logic in
web_app_mac.mm rather than relying on
web_app::ShouldCreateShortcutFor(..) for determining what to upgrade,
and ensure shortcuts are not newly created during a batch upgrade.

When the default app is downloaded and installed on profile creation, a
user can still create a shortcut for these by going to chrome://apps and
selecting "Create Shortcut..." from the context menu.

BUG=571310
TEST=On Mac, create a new profile. Nothing new should appear in
`~Applications/Chrome Apps`. (Note this needs an official build: default
apps are not installed for Chromium).

Review URL: https://codereview.chromium.org/1533273002

Cr-Commit-Position: refs/heads/master@{#369325}

BUG=566605
TBR=sullivan@chromium.org

Review URL: https://codereview.chromium.org/1589673002

Cr-Commit-Position: refs/heads/master@{#369324}

https://drafts.css-houdini.org/worklets/

WorkerScriptController renamed to GlobalScopeScriptController to share
code with WorkletScriptController.

Additional super-class (AbstractGlobalScope) created for
WorkerGlobalScope and WorkletGlobalScope to share ExecutionContext
related implementation.

Notable pieces left to implement:
 - support for Worklet::importScript
 - devtools integration
 - off-main-thread implementation for compositorworklet & audioworklet

Intent to implement: https://groups.google.com/a/chromium.org/d/msg/blink-dev/kl8ct3ub3a8/-WfzBTkCAgAJ

BUG=567358

Review URL: https://codereview.chromium.org/1535943005

Cr-Commit-Position: refs/heads/master@{#369323}

In a previous patch, crrev.com/1e8c4674, we started rejecting selectors
with unknown namespace prefixes. However the patch had a bug, where in a
compound selector an unknown namespace prefix and additional components,
we would ignore the elemental selector portion instead of marking the
entire selector as invalid. This patch fixes this case.

BUG=565611

Review URL: https://codereview.chromium.org/1583713003

Cr-Commit-Position: refs/heads/master@{#369322}

BUG=574499

Review URL: https://codereview.chromium.org/1579333003

Cr-Commit-Position: refs/heads/master@{#369321}

Cr-Commit-Position: refs/heads/master@{#369320}

BUG=575103

Review URL: https://codereview.chromium.org/1582093002

Cr-Commit-Position: refs/heads/master@{#369319}

There's no need to make a subclass for this purpose; a single NSObject that is used everywhere will do fine.

Review URL: https://codereview.chromium.org/1588703002

Cr-Commit-Position: refs/heads/master@{#369318}

If file left, it could affect other tests that uses the same download
source.

BUG=286315

Review URL: https://codereview.chromium.org/1586593003

Cr-Commit-Position: refs/heads/master@{#369317}

When DevTools mobile device emulation is on, page resize also means
device size has change, and therefore device-dependent media queries
should be re-evaluated similarly to viewport-dependent ones.

Previous solution for this was forcing styles reset on each resize
while DevTools emulation was enabled, which turned out to be very slow.
Now DevToolsEmulator uses setting resizeIsDeviceSizeChange to control
new behavior.

BUG=540864
TEST=DeviceEmulationTest.DeviceSizeInvalidatedOnResize

Review URL: https://codereview.chromium.org/1583913003

Cr-Commit-Position: refs/heads/master@{#369316}

BUG=574798
TEST=as in comment 8 in that bug

Review URL: https://codereview.chromium.org/1580943006

Cr-Commit-Position: refs/heads/master@{#369315}

This bug was introduced with the fix of adding SUs with the same name. The problem is that the callback that is called when SU are refreshed does not know whether it is called after a new user is created. This causes the dialog to think that it needs to create the error bubble. For some reason the overlay is not closed after the creation of account is done, so the solution is to expose the creationInProgress, so the callback does not proceed. This requires the onSuccess callback to not change the state (otherwise the receiveSupervisedUsers callback continues to be called and cause the error).
BUG=575134

Review URL: https://codereview.chromium.org/1564063002

Cr-Commit-Position: refs/heads/master@{#369314}

Use a more conservative 2,500 maximum instead of 10,000
on Android to avoid the cache being a memory hog.

BUG=577306

Review URL: https://codereview.chromium.org/1587843002

Cr-Commit-Position: refs/heads/master@{#369313}

Conceptually, the observers should be called after the
mojo's error handler setting.

BUG=n/a
TEST=Ran trybots.

Review URL: https://codereview.chromium.org/1584763002

Cr-Commit-Position: refs/heads/master@{#369312}

Review URL: https://codereview.chromium.org/1573243011

Cr-Commit-Position: refs/heads/master@{#369311}

BUG=577492
TBR=agrieve
NOTRY=true
NOPRESUBMIT=true

Review URL: https://codereview.chromium.org/1588723004

Cr-Commit-Position: refs/heads/master@{#369310}

[DevTools] More Device Mode polish.
- fixed ruler in overlay with page scale factor;
- dimming zoom label based on some content being cropped;
- added dpr and ua type labels;
- fixed fit calculations;
- string updates.
BUG=540864

Original patch: https://codereview.chromium.org/1575203003
TBR=pfeldman

Review URL: https://codereview.chromium.org/1586773002

Cr-Commit-Position: refs/heads/master@{#369309}

Implements:
 1. Selecting from default images.
 2. Selecting the 'old' image (from a file, old camera shot, deprecated default image).
 3. Selecting the Google profile photo.

Missing from this implmentation:
 1. Larger preview image on the side.
 2. Ability to take new pictures with the camera, and flip it.
 3. Ability to select an image from the file.
 4. Lots of polish.

BUG=563721

Review URL: https://codereview.chromium.org/1575543003

Cr-Commit-Position: refs/heads/master@{#369308}