GitLab

NOTRY=true

Review-Url: https://codereview.chromium.org/2856203002
Cr-Commit-Position: refs/heads/master@{#469009}

To prevent races, make sure that code that runs after
TaskTracker::Flush() sees memory changed by all tasks it was waiting
for.

BUG=717527

Review-Url: https://codereview.chromium.org/2857613002
Cr-Commit-Position: refs/heads/master@{#469008}

Because the first MakeCurrent call against a virtual GL context leaves
the real context state indeterminate (since the GLES2Decoder isn't
initialized and by definition neither is the GLStateRestorer), force
it to be made current again after initialization.

This fixes a longstanding bug where if the next GLES2Decoder to do
significant work was the same one that was just created, it would do
this work with the majority of the real GL context state set to that
of the previous virtual GL context.

BUG=694359
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2862443002
Cr-Commit-Position: refs/heads/master@{#469007}

(patchset #6 id:140001 of https://codereview.chromium.org/2779643002/ )

This reverts commit 9fb1c8b9.

It relands the original patch by fixing an uninitialized read in the related
browser test.

BUG=685905,717315

Review-Url: https://codereview.chromium.org/2857663002
Cr-Commit-Position: refs/heads/master@{#469006}

This CL makes ProxyScriptFetcherImpl use highest priority and
LOAD_IGNORE_LIMITS, and adds an OnShutdown method to ProxyService,
which must be called before teardown when the ProxyService makes
requests using a URLRequestContext that it is also used with.

No consumer currently uses the new functionality.  I plan to
switch IOThread/ProfileIOData to using it in another CL, and
add a call in URLRequestContextStorage's destructor.  May also
be worth making it mandatory as well, though that will involve
more changes.

BUG=715697

Review-Url: https://codereview.chromium.org/2845643003
Cr-Commit-Position: refs/heads/master@{#469005}

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2820383002
Cr-Commit-Position: refs/heads/master@{#469004}

https://skia.googlesource.com/skia.git/+log/131154be103d..e188f8b14b6a

$ git log 131154be1..e188f8b14 --date=short --no-merges --format='%ad %ae %s'
2017-05-03 ethannicholas Revert "Revert "eliminated GrGLSLExpr""

Created with:
  roll-dep src/third_party/skia


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=scroggo@chromium.org

Change-Id: I970c03546e108b49912be7694fd60ee56b5d9f1f
Reviewed-on: https://chromium-review.googlesource.com/493842Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#469003}

Two changes:
 1. Call setBluetoothFakeAdapter('') to clean up any adapters left
    by legacy tests.
 2. Change 'available' to 'supported' to match the functions name.

BUG=569709

Review-Url: https://codereview.chromium.org/2859673003
Cr-Commit-Position: refs/heads/master@{#469002}

A class with virtual methods should have a virtual destructor.

BUG=697810

Review-Url: https://codereview.chromium.org/2858683005
Cr-Commit-Position: refs/heads/master@{#469001}

WebRestrictionsResourceThrottleTest.WillStartRequest_Subresource is
flaking heavily on most Android bots:
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=components_unittests&tests=WebRestrictionsResourceThrottleTest.WillStartRequest_Subresource

NOTREECHECKS=true
NOTRY=true
BUG=718066
TBR=aberent@chromium.org

Review-Url: https://codereview.chromium.org/2854423003
Cr-Commit-Position: refs/heads/master@{#469000}

Network traffic annotation is added to network request of
components/policy/core/common/cloud/device_management_service.cc
components/policy/core/common/cloud/external_policy_data_fetcher.cc
components/policy/core/common/cloud/user_info_fetcher.cc

BUG=656607

Review-Url: https://codereview.chromium.org/2800653002
Cr-Commit-Position: refs/heads/master@{#468999}

With audio moving to a separate process, device info access is allowed through AudioSystem interface only.
We want to avoid AudioManager device info interface leakage.

* AudioManager device info methods moved to protected.
* AudioSystem becomes AudioManager's friend.
* For the unit tests of the functionality moving to audio process (media unit tests):
AudioDeviceInfoAccessorForTests class is introduced, which is AudioManager's friend and is compiled only for media_unittests target.

BUG=672468
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2799363005
Cr-Commit-Position: refs/heads/master@{#468998}

This CL makes the layout tests harness more resiliant against
a situation where testRunner.notifyDone() is called simultaneously in
more than 1 renderer process.  Such situation usually indicates a bug in
the test (e.g. see https://crbug.com/716085#c13), but this shouldn't
cause a crash or other problems in the layout tests harness.

BUG=716085

Review-Url: https://codereview.chromium.org/2852753003
Cr-Commit-Position: refs/heads/master@{#468997}

R=timvolodine@chromium.org,alexander.shalamov@intel.com,mikhail.pozdnyakov@intel.com,rijubrata.bhaumik@intel.com

Review-Url: https://codereview.chromium.org/2857013002
Cr-Commit-Position: refs/heads/master@{#468996}

In particular the min-height on buttons wasn't working.

BUG=701033

Review-Url: https://codereview.chromium.org/2854863003
Cr-Commit-Position: refs/heads/master@{#468995}

This CL rewrites code that manually iterates over frames of WebContents
to find a frame with a matching RenderFrameHost::GetFrameName.

Tests above //content are rewritten to use
content::FrameMatchingPredicate from
content/public/test/browser_test_utils.h (instead of manually iterating
over the frames and manually looking at RenderFrameHost::GetFrameName).

//content code is rewritten to use content::FrameTree::FindByName.

This CL has no intended behavior change (except changing messages in
gtest assertions that verify that exactly 1 frame matches).

BUG=

Review-Url: https://codereview.chromium.org/2849603005
Cr-Commit-Position: refs/heads/master@{#468994}

-fsanitize-coverage={edge,bb,func} are deprecated.

-fsanitize-coverage={edge,bb,func},trace-pc-guard should be used instead (edge is default).

BUG=651540

Review-Url: https://codereview.chromium.org/2860643002
Cr-Commit-Position: refs/heads/master@{#468993}

https://pdfium.googlesource.com/pdfium.git/+log/cadb4711bdc9..f45ade3a0af9

$ git log cadb4711b..f45ade3a0 --date=short --no-merges --format='%ad %ae %s'
2017-05-03 npm Add a ToUnicode mapping when loading CID fonts
2017-05-02 tsepez XFA Nits: Dead CreateCharIter(), auto CFXJSE_Value unique ptr.

Created with:
  roll-dep src/third_party/pdfium


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


TBR=dsinclair@chromium.org

Change-Id: I9192fa7f5c5f4ed6a938002e357de93a8ce8ba07
Reviewed-on: https://chromium-review.googlesource.com/493873
Reviewed-by: <pdfium-deps-roller@chromium.org>
Commit-Queue: <pdfium-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#468992}

net/url_request/test_url_fetcher_factory.cc
net/url_request/url_fetcher.cc
net/url_request/url_fetcher_core.h
net/url_request/url_fetcher_core.cc
net/url_request/url_fetcher_impl.h
net/url_request/url_fetcher_impl.cc
net/url_request/url_fetcher_impl_unittest.cc

BUG=656607

Review-Url: https://codereview.chromium.org/2846873002
Cr-Commit-Position: refs/heads/master@{#468991}

Now uses test normalizer and delegate.
BUG=None
TEST=existing

Review-Url: https://codereview.chromium.org/2860563002
Cr-Commit-Position: refs/heads/master@{#468990}

Sometimes it's useful to view symbols by address, and clustering them
makes doing so a non-trivial task.

Diff() already have a TODO that it didn't work quite properly for
nested groups. This addresses the TODO by having it act upon the
unclustered symbols.

Moves cluster logic to its own file, and maps it to
SymbolGroup.Cluster().

BUG=681694

Review-Url: https://codereview.chromium.org/2854173003
Cr-Commit-Position: refs/heads/master@{#468989}

https://chromium.googlesource.com/angle/angle.git/+log/d262799..ba29fa4

BUG=chromium:717558,chromium:717385

TBR=geofflang@chromium.org

TEST=bots

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2860743002
Cr-Commit-Position: refs/heads/master@{#468988}

This fixes an oversight from https://codereview.chromium.org/2344343002/

BUG=620813

Review-Url: https://codereview.chromium.org/2852693003
Cr-Commit-Position: refs/heads/master@{#468987}

Currently, to prevent native pinch-zoom from interfering with how we
handle pinch-zoom in the PDF viewer, we preventDefault the 2 finger
touchstart that corresponds to the gesture pinch start. However, this
also prevents 2 finger tap gestures.

We now preventDefault the 2 finger touchmoves so that native pinch-zoom
is still prevented, while 2 finger tap gestures are not affected.

BUG=716123
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2847893005
Cr-Commit-Position: refs/heads/master@{#468986}

TBR=sdefresne
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=718043

Review-Url: https://codereview.chromium.org/2861773002
Cr-Commit-Position: refs/heads/master@{#468985}

Revert of Remove dangling PlayingState pointers in WebRtcAudioRenderer. (patchset #4 id:60001 of https://codereview.chromium.org/2758453004/ )

Reason for revert:
This causes a memory use increase across the board on Android, even when WebRTC isn't used.

Original issue's description:
> Remove dangling PlayingState pointers in WebRtcAudioRenderer.
>
> This solution is a bit of a hack, but it works. Did manual testing and ran
> unit tests. Bug 697256 does not reproduce with this patch.
>
> R=tommi@chromium.org
>
> BUG=697256
>
> Review-Url: https://codereview.chromium.org/2758453004
> Cr-Commit-Position: refs/heads/master@{#458025}
> Committed: https://chromium.googlesource.com/chromium/src/+/ba21ffd704aebcc8a5e5e1ab1f072e9b79b51fcb

TBR=tommi@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=697256,703743

Review-Url: https://codereview.chromium.org/2856943003
Cr-Commit-Position: refs/heads/master@{#468984}

Marks AudioAndroidInputTest.StartInputStreamCallbacks and
AudioAndroidInputTest.StartInputStreamCallbacksNonDefaultParameters
as flaky. They've been failing on chromium.android/KitKat Tablet Tester,
chromium.linux/Android Tests and chromium.linux/Android Tests (dbg) due
to timeouts, sometimes turning the build red.

BUG=683408
TBR=braveyao@chromium.org
NOTRY=true
SKIPTREECHECKS=true
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2852323004
Cr-Commit-Position: refs/heads/master@{#468983}

Review-Url: https://codereview.chromium.org/2851263002
Cr-Commit-Position: refs/heads/master@{#468982}

Fixed MSan issue (https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.memory%2FMac_ASan_64_Tests__1_%2F29660%2F%2B%2Frecipes%2Fsteps%2Fbrowser_tests%2F0%2Flogs%2FBookmarkFolderAppleScriptTest.DeleteBookmarkItems%2F0)

See delta between patchsets 2 and 3 for the fix

Original description:
Yes, with RTL thrown in, since this is specifically designed to make it almost free.

Two major things here:
- The bar is no longer relaid-out directly in response to changes in view size, bookmark model etc. Instead, a new UI-direction-agnostic view model (BookmarkBarLayout) is created from the current state, and if it's different from before, it's applied to the view.
- Removed a bunch of layout-related code that's no longer necessary

BUG=648560

Review-Url: https://codereview.chromium.org/2751573002
Cr-Commit-Position: refs/heads/master@{#468364}
Committed: https://chromium.googlesource.com/chromium/src/+/2644729cb7722a702a76cc2758d0ce372e1e6f92

patch from issue 2751573002 at patchset 180001 (http://crrev.com/2751573002#ps180001)

Review-Url: https://codereview.chromium.org/2853373002
Cr-Commit-Position: refs/heads/master@{#468981}

This CL adds service tests to test basic functionality of the implementation
of identity_manager.mojom. Note that if/as service tests of other
interfaces are added, the utility code that sets up the Identity Service
can and should be split out of this test into a base class.

BUG=683120

Review-Url: https://codereview.chromium.org/2854083002
Cr-Original-Commit-Position: refs/heads/master@{#468921}
Committed: https://chromium.googlesource.com/chromium/src/+/1a4c6321d2ab77267160bfb0297411e43d0daaab
Review-Url: https://codereview.chromium.org/2854083002
Cr-Commit-Position: refs/heads/master@{#468980}

Network traffic annotation is added to network request of:
content/browser/loader/resource_dispatcher_host_impl.cc.

BUG=656607

Review-Url: https://codereview.chromium.org/2843403002
Cr-Commit-Position: refs/heads/master@{#468979}

https://skia.googlesource.com/skia.git/+log/24b2063a48ef..131154be103d

$ git log 24b2063a4..131154be1 --date=short --no-merges --format='%ad %ae %s'
2017-05-02 fmalita Reland: Remove SkLights include from SkCanvas.h
2017-05-03 recipe-roller Roll recipe dependencies (nontrivial).
2017-05-03 reed remove unused etc logic

Created with:
  roll-dep src/third_party/skia


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=scroggo@chromium.org

Change-Id: I6276a8ec40a63894e078579fc54ee49f3335bcf0
Reviewed-on: https://chromium-review.googlesource.com/493620Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#468978}

This was introduced in https://codereview.chromium.org/2800313002/ while
the parent class added the code in
https://codereview.chromium.org/2812303003/.

BUG=none
R=marq@chromium.org,edchin@chromium.org

Review-Url: https://codereview.chromium.org/2820703002
Cr-Commit-Position: refs/heads/master@{#468977}

Reland of https://codereview.chromium.org/2808873002/

BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2851303006
Cr-Commit-Position: refs/heads/master@{#468976}

This CL connects the PIN entry view to the connection status view. It also adds a layer in the UI for connecting to the host, instead of going strait to the GLK view, we first end up on the new connection status view that will guide and inform the user about the state of their connection, prompting for PIN (or third party auth in time?). After a successful connection has been made the view is replaced with the HostViewController with the desktop rendering, etc.

Review-Url: https://codereview.chromium.org/2846603002
Cr-Commit-Position: refs/heads/master@{#468975}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/328f6575..b4916264

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2857953002
Cr-Commit-Position: refs/heads/master@{#468974}

TBR=bzanotti
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=718023

Review-Url: https://codereview.chromium.org/2857993002
Cr-Commit-Position: refs/heads/master@{#468973}

TBR=zmo@chromium.org
NOTRY=true

BUG=602688
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2857983002
Cr-Commit-Position: refs/heads/master@{#468972}

BUG=251774
TBR=jam@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2857613003
Cr-Commit-Position: refs/heads/master@{#468971}

These tests were marked as flaky/crashy but after the revert in
 https://bugs.chromium.org/p/chromium/issues/detail?id=707689#c7
and the extra CLs
 https://bugs.chromium.org/p/chromium/issues/detail?id=707689#c8
and
 https://bugs.chromium.org/p/chromium/issues/detail?id=707689#c9

we should be good again, so let's reconnect these tests and
monitor
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_tests&tests=shapedetection%2F

BUG=707689

Review-Url: https://codereview.chromium.org/2857803002
Cr-Commit-Position: refs/heads/master@{#468970}