- 22 Feb, 2019 40 commits
-
-
Nico Weber authored
Only enables the warning for chromium_code.n Also fix the last few -Wextra-semi instances in sanitizer and linux/ozone builds. Getting to this state required fixing > 3000 unique warnings in 15+ different repositories. If this breaks some internal-only build somewhere, either consider using no_chromium_code for your internal code, or fix the warnings -- it's pretty easy. (Build with treat_warnings_as_errors=false, then open the error log in vim, run `:%g/warning:/t$` to copy the warnings to the end of the buffer, remove all but just those lines, run `:sort u` to get uniques, then save as `tmp.txt` and run `:cf %` and then use something like `:map m :w<cr>:cn<cr>` to go through them quickly.) TBR=rsesek Bug: 926235 Change-Id: Ica629737523ff6bbd756edc44d182f35ff6cf8ac Reviewed-on: https://chromium-review.googlesource.com/c/1483396Reviewed-by:
Scott Violet <sky@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#634826}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/045e7629..6b0fdfce Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Iab67f081e437402a2b3d5fa397c239d0a3ad74d0 Reviewed-on: https://chromium-review.googlesource.com/c/1483353Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#634825}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/bf36568f5a9a..f6be20565150 Created with: gclient setdep -r src-internal@f6be20565150 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:932292,chromium:790153,chromium:790158,chromium:790159,chromium:790163,chromium:790153,chromium:790158,chromium:790159,chromium:790163 TBR=mmoss@chromium.org Change-Id: I209ba4517387614ec6ccfce883e97358c6d30672 Reviewed-on: https://chromium-review.googlesource.com/c/1483611Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#634824}
-
Bence Béky authored
https://quiche.googlesource.com/quiche.git/+log/e72b8874b23a..3cab5a95cea8 $ git log e72b8874b..3cab5a95c --date=short --no-merges --format='%ad %ae %s' 2019-01-30 quiche-dev Replace calls to deprecated googletest macros *TEST_CASE() with *TEST_SUITE() 2019-01-30 quiche-dev Replace calls to deprecated googletest macros *TEST_CASE() with *TEST_SUITE(). Created with: roll-dep src/net/third_party/quiche/src Change-Id: Ide881ea35ff659707aa010e438c3a0d2a21df33a Reviewed-on: https://chromium-review.googlesource.com/c/1483262Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Commit-Queue: Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#634823}
-
David Benjamin authored
RtpTransceiverInterface::mid returns a temporary absl::optional<std::string>. This line below could avoid an extra copy by moving out of the return value. https://cs.chromium.org/chromium/src/content/renderer/media/webrtc/transceiver_state_surfacer.cc?rcl=76cea1da07cfc1bbbf571219cde4dcccaa259e01&l=102 (The caller didn't need to be changed because it was already returning a temporary.) Bug: none Change-Id: I5ec3964953febe8152086f374f9a8f3e89c8b43a Reviewed-on: https://chromium-review.googlesource.com/c/1481996 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Auto-Submit: David Benjamin <davidben@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#634822}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/12aef8732ec6..1aecf87b9620 git log 12aef8732ec6..1aecf87b9620 --date=short --no-merges --format='%ad %ae %s' 2019-02-22 thakis@chromium.org Whitespace change to trigger bots. 2019-02-22 thestig@chromium.org Make FX_ParseStringString() faster. Created with: gclient setdep -r src/third_party/pdfium@1aecf87b9620 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:934825,chromium:934403 TBR=dsinclair@chromium.org Change-Id: I9b7a65e27982ea50ae4694228134ff8cad62f30c Reviewed-on: https://chromium-review.googlesource.com/c/1483473Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#634821}
-
Matt Falkenhagen authored
Somehow we're getting Mojo calls like DispatchFetchEvent (on the ServiceWorker interface, example crash/fe94cd10d8ba922d) and C++ calls like DispatchOrQueueFetchEvent (from ControllerServiceWorkerImpl, example crash/974589224224beec) at a time where context_ is null. That doesn't make sense because if context_ is null we would have destroyed both the blink::mojom::ServiceWorker binding and ControllerServiceWorkerImpl. Add instrumentation to try to figure out why. Bug: 934622, 907311 Change-Id: I0c1d8e858245d51f10a084f8d6d0b5e20ac9ecc3 Reviewed-on: https://chromium-review.googlesource.com/c/1482440 Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#634820}
-
Yusuf Ozuysal authored
This adds the necessary strings and constants for the three IPH that will be shown for Tab Groups. It also adds a utility class to facilitate showing the IPH. Also adds a string for context menu changes. BUG=930970,930965 Change-Id: Ide45f0a89a66bdab0096213ec8676303df37efe4 Reviewed-on: https://chromium-review.googlesource.com/c/1482592Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#634819}
-
Erik Jensen authored
Also adds basic tests for IpcFileOperations. Bug: 679313 Change-Id: I6ab03fb0cab5c5c5d60117c3687fe3c166b4e6ff Reviewed-on: https://chromium-review.googlesource.com/c/1477307 Commit-Queue: Erik Jensen <rkjnsn@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Reviewed-by:
Martin Barbella <mbarbella@chromium.org> Cr-Commit-Position: refs/heads/master@{#634818}
-
Michael Moss authored
This should be referenced as chrome/chromium.chrome everywhere now, instead of chromium/chromium.chrome. Also remove the chromium.chrome builders from the "main" waterfall, since the presubmits seem to want anything included there to have a local console definition, and complains about: Missing subwaterfall console for set([u'chromium.chrome']) BUG=790153,790158,790159,790163 R=jbudorick@chromium.org, tandrii@chromium.org Change-Id: I3062bdb1c868fc9e9d9d5f7e1e8f73e4e2aaeedc Reviewed-on: https://chromium-review.googlesource.com/c/1483363 Auto-Submit: Michael Moss <mmoss@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#634817}
-
Varun Khaneja authored
See https://bugs.chromium.org/p/chromium/issues/detail?id=934786#c3 for detailed analysis R=nparker Bug: 934786,907280 Change-Id: Ib53720fc1ea0d10ba7efbfe3b1192097448f694f Reviewed-on: https://chromium-review.googlesource.com/c/1483930 Commit-Queue: Varun Khaneja <vakh@chromium.org> Auto-Submit: Varun Khaneja <vakh@chromium.org> Reviewed-by:
Nathan Parker <nparker@chromium.org> Cr-Commit-Position: refs/heads/master@{#634816}
-
Daniel Nicoara authored
Move the wp_presentation interface into its own files. This change only moves code around, no functional changes. Bug: 896710 Test: Build and run exo_unittests Change-Id: I221c199074376420f3ca842dcd063c4bd4057589 Reviewed-on: https://chromium-review.googlesource.com/c/1480995 Commit-Queue: Daniel Nicoara <dnicoara@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#634815}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/cf9b2853a7e7..d09546e1ec90 git log cf9b2853a7e7..d09546e1ec90 --date=short --no-merges --format='%ad %ae %s' 2019-02-22 jmadill@chromium.org D3D: Fall back to old compiler DLL. Created with: gclient setdep -r src/third_party/angle@d09546e1ec90 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:920704 TBR=geofflang@chromium.org Change-Id: I3d4e1946bfd9b010b69d39238bae968c3bdcd553 Reviewed-on: https://chromium-review.googlesource.com/c/1483471Reviewed-by:
-
Yun Liu authored
As agrieve@ suggested, changed to use android_deps tool to get androidx test libraries from maven. This can be easier to add more binaries and upgrade by version later. Doc: https://chromium.googlesource.com/chromium/src/+/HEAD/tools/android/roll/android_deps/README.md Bug: 900746 Change-Id: I631ed39e4bb07719ffe7d49c928380223def29af Reviewed-on: https://chromium-review.googlesource.com/c/1478257Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Yun Liu <yliuyliu@google.com> Cr-Commit-Position: refs/heads/master@{#634813}
-
Antonio Gomes authored
R=jbroman@chromium.org CC=blink-reviews-onion-soup@chromium.org BUG=891908 Change-Id: I6d13142d63c924632370a1abd57b4effdb596f3c Reviewed-on: https://chromium-review.googlesource.com/c/1483570 Auto-Submit: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#634812}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/29f9cd9358ee..487c09bb73c1 git log 29f9cd9358ee..487c09bb73c1 --date=short --no-merges --format='%ad %ae %s' 2019-02-22 srte@webrtc.org Adds FakeNetworkPipeTest to rtc_unittests. Created with: gclient setdep -r src/third_party/webrtc@487c09bb73c1 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I368eb8e46ad5e24365cf83e0cd4986eeb93def29 Reviewed-on: https://chromium-review.googlesource.com/c/1483470Reviewed-by:
-
Dmitry Gozman authored
Virtual time should only be paused while body loader is active. Bug: none Change-Id: I479bc7e85c7dd30dfaf5fc8f61c5be6cd6859288 Reviewed-on: https://chromium-review.googlesource.com/c/1483215 Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#634810}
-
Kristi Park authored
This reverts commit 48c013c2. Reason for revert: Suspected cause of webkit_layout_tests failure for virtual/layout_ng_experimental/fast/multicol/span/abspos-containing-block-outside-spanner.html Original change's description: > [LayoutNG] Handle OOF descendants stored in LegacyBlocks directly > > This CL changes how NG deals with OOF Elements held by Legacy. > > NG and Legacy use different mechanisms to "bind" OOF Elements > to their container. > NG binds OOF Elements to their container by propagating them > up the tree during layout. > Legacy LayoutBlocks keeps a list of PositionedObjects, and > add and remove from this list directly from OOF child. > > The case tackled in this CL is this: > NG is the container, and has a positioned child that > has not propagated trought the tree during NG layout because > Legacy was on a path between child and its container. > > For example: > <div#container position:relative> > <div#legacy display:flex> > <div#oof position:absolute> > > When #container is placing OOF descendants, its NG > list of descendants will not contain #oof, because > #legacy was laid out with Legacy code. Instead, #oof > is in the Legacy's list of #container.PositionedObjects. > > The interesting part here is computing the static position > of #oof wrt #container. > > What previous code did was this: > - it let Legacy decide when PositionedObjects are laid out. > - when NG positioned object got called to Layout(), it > would compute abspos constraints (static_position, > constraint_space), create a new NGOutOfFlowLayoutPart > - NGOutOfFlowLayoutPart would place the object > > The new code changes who triggers layout of these objects. > Instead of waiting of Legacy to layout its positioned > objects, it pulls them out of Legacy, and places them during > NGOutOfFlowLayoutPart::Run. > > This makes computing static position for Legacy elements > tricky. Container has not copied its data back to Legacy, > and its children have not had their offset set. > Legacy code that computes static offset needs children's > offset, and that information is no longer available from > LayoutObjects. That information can be found in > NGContainerFragmentBuilder. That is why builder gets passed in > to LayoutBlock::ComputeBlockStaticDistance > > The code also contains some minor fixes: > 1) to bugs that were exposed by this change. > 2) for bugs that would otherwise be caused by this change. > > NGContainerFragmentBuilder::AddChild needed to take > relative position into account when propagating OOF > descendants. > > NGContainerFragmentBuilder::GetChildOffset could be called > on a grandchild, if child is a linebox. > > Bug: 921396 > Change-Id: Ib9a26596f21971374854cf6ec2729b10b3cd834a > Reviewed-on: https://chromium-review.googlesource.com/c/1476087 > Reviewed-by: Morten Stenshorne <mstensho@chromium.org> > Commit-Queue: Aleks Totic <atotic@chromium.org> > Cr-Commit-Position: refs/heads/master@{#634743} TBR=ikilpatrick@chromium.org,atotic@chromium.org,mstensho@chromium.org Change-Id: Ibf15ae8c091172f9365b0d8dc165fc9cb040618f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 921396,934972 Reviewed-on: https://chromium-review.googlesource.com/c/1483933Reviewed-by:
Kristi Park <kristipark@chromium.org> Commit-Queue: Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#634809}
-
Saman Sami authored
Due to another optimization that I landed at the same time as the original CL, one of the unit tests became invalid. This CL slightly tunes the LocalSurfaceIds used in the original unittests. A child should not be throttled if the parent is blocked on it. Otherwise the parent is guaranteed to hit the deadline, causing jank. TBR=kylechar@chromium.org Bug: 933610 Change-Id: Iff450c568a904d14c9f00fad24f5748a08c6a505 Reviewed-on: https://chromium-review.googlesource.com/c/1482949 Commit-Queue: Saman Sami <samans@chromium.org> Reviewed-by:
Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#634808}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/698937087797..8546335d2d40 git log 698937087797..8546335d2d40 --date=short --no-merges --format='%ad %ae %s' 2019-02-22 scroggo@google.com Allow setting an SkColorSpace on SkAnimatedImage 2019-02-22 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 7aafb27453d3..8a718cb58343 (2 commits) 2019-02-22 benjaminwagner@google.com [infra] Remove Ubuntu17 jobs 2019-02-22 ethannicholas@google.com Revert "Revert "SkSL now supports null child processors"" 2019-02-22 bsalomon@google.com Skip newly added TextureIdleProcFlushTest test on Mac/Metal. It crashes. 2019-02-22 brianosman@google.com Add local vs world flag for particle velocity 2019-02-22 jvanverth@google.com Blacklist fontregen on IntelIris655-Vulkan 2019-02-22 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader b607bc8800c1..7aafb27453d3 (1 commits) Created with: gclient setdep -r src/third_party/skia@8546335d2d40 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:b/123301872,chromium:837351 TBR=jvanverth@chromium.org Change-Id: I645312c7f1828fc23fa3f64adeb3673c122bf6c4 Reviewed-on: https://chromium-review.googlesource.com/c/1483472Reviewed-by:
-
Chris Cunningham authored
Note, we're experimenting with all 3 of the linked bugs below, but the testing infra only tries one experiment, so the json just mentions my favorite of the 3. Bug: 920473, 920476, 920472 Change-Id: I7adeeb506d38b9aaa284b863b10e225aa46814f0 Reviewed-on: https://chromium-review.googlesource.com/c/1481123 Commit-Queue: Steven Holte <holte@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Auto-Submit: Chrome Cunningham <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#634806}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/8a718cb58343..e53533d6fdf9 git log 8a718cb58343..e53533d6fdf9 --date=short --no-merges --format='%ad %ae %s' 2019-02-22 chrisforbes@google.com Silence emit-time warnings for many instructions 2019-02-22 chrisforbes@google.com Remove alpha test plumbing Created with: gclient setdep -r src/third_party/swiftshader@e53533d6fdf9 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@chromium.org Change-Id: If360a019d8901063db1421b683ccaf6d8d65e705 Reviewed-on: https://chromium-review.googlesource.com/c/1483127Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/a51d3d9f2233..ec484527b643 git log a51d3d9f2233..ec484527b643 --date=short --no-merges --format='%ad %ae %s' 2019-02-22 johnkslang@users.noreply.github.com Merge pull request #1709 from KhronosGroup/fix-pp Created with: gclient setdep -r src/third_party/glslang/src@ec484527b643 The AutoRoll server is located here: https://autoroll.skia.org/r/glslang-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Ic0ebe4c10263a91fd254cfd015c2694d222651c9 Reviewed-on: https://chromium-review.googlesource.com/c/1483126Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/2e6cfed0e664..0d90920be7af git log 2e6cfed0e664..0d90920be7af --date=short --no-merges --format='%ad %ae %s' 2019-02-22 dhanyaganesh@chromium.org metrics: Send metric fields only as kwargs and not args 2019-02-22 mikenichols@chromium.org Revert "constants: Remove lakitu from PreCQ coverage" 2019-02-22 mikenichols@chromium.org constants: Remove lakitu from PreCQ coverage Created with: gclient setdep -r src/third_party/chromite@0d90920be7af The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@chromium.org Change-Id: I8448b764900bae2cf074f6bc5f99d83db45229b3 Reviewed-on: https://chromium-review.googlesource.com/c/1483474Reviewed-by:
-
David Benjamin authored
This function is unused. Unlike the rest of that file, it wraps an NSS-specific concept, whereas the rest is just parsing which we can do ourselves in the future. Bug: none Change-Id: I5ab99a96d76ce95a4a8ef893e4b13f49b4d2d9f9 Reviewed-on: https://chromium-review.googlesource.com/c/1482114 Commit-Queue: Matt Mueller <mattm@chromium.org> Auto-Submit: David Benjamin <davidben@chromium.org> Reviewed-by:
Matt Mueller <mattm@chromium.org> Cr-Commit-Position: refs/heads/master@{#634802}
-
David Benjamin authored
https://boringssl.googlesource.com/boringssl/+log/7ef4223fb32431529a797c5b8d3bf26ece6c138b..f109f2087349712d3ac717d15fab48e130618110 (https://boringssl-review.googlesource.com/c/34868 adds a dbghelp dependency to the tests, but it looks like that's part of the default libraries and Windows cross-compile wasn't working, so just seeing if the CQ is happy as-is.) Bug: none Change-Id: I000f41d8662c793cee70cb1be3b5495e1a828725 Reviewed-on: https://chromium-review.googlesource.com/c/1483216 Commit-Queue: David Benjamin <davidben@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Auto-Submit: David Benjamin <davidben@chromium.org> Reviewed-by:
-
Jeff Fisher authored
The launch_chrome.js npm script doesn't currently support the CHROMIUM_PATH variable like it does on other platforms. This change simply copies the same logic from Linux/Mac. Change-Id: Ic2a340f47b1dc87f9c7eefcdcf4de5ed39638c6e Reviewed-on: https://chromium-review.googlesource.com/c/1481116Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Jeff Fisher <jeffish@microsoft.com> Cr-Commit-Position: refs/heads/master@{#634800}
-
Kristi Park authored
Failing on linux-chromeos-rel trybot TBR=tetsui@chromium.org Bug: 934939 Change-Id: Ib5609f172645de4a71e4f7a28042a76553b47284 Reviewed-on: https://chromium-review.googlesource.com/c/1483818Reviewed-by:
-
Eyor Alemayehu authored
The VoiceInteractionHotwordEnabled preference needs to be managed by an administrator for G-Suite accounts. Added a policy for the preference. In addition, updated the settings UI so that the widgets controlled by the policy are disabled when controlled by ab administrator. Bug: b:124113875 Change-Id: If2c3ff8a50b69e8694a48c1c67e12ccd3212e069 Reviewed-on: https://chromium-review.googlesource.com/c/1465070 Commit-Queue: Eyor Alemayehu <eyor@google.com> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#634798}
-
Nicolas Ouellet-payeur authored
This improves the compatibility with actual IEEM sitelists, especially the doNotTransition attribute. Previously: - "exclude" meant "invert this rule" - "doNotTransition" meant "apply to greylist instead of sitelist" Now: - "exclude" means "this rule does nothing (but can have sub-rules)" - "doNotTransition" means "invert this rule" Bug: 933577 Change-Id: I84f516ad2cc7d6e0f400b8ae26bf81e470b55816 Reviewed-on: https://chromium-review.googlesource.com/c/1481796Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Cr-Commit-Position: refs/heads/master@{#634797}
-
Evan Stade authored
for packaged apps, Settings, and frameless platform apps. These don't use NonClientFrameViewAsh, so MakeGestureDraggableInImmersiveMode is never called. We will be able to remove this code when Mash is default. Bug: 931855 Change-Id: If3ba4e8cf92b059b944d0cf3dc794c05bf5f2fd7 Reviewed-on: https://chromium-review.googlesource.com/c/1480210Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/b4fdbb737c98..e4abf4c59be6 git log b4fdbb737c98..e4abf4c59be6 --date=short --no-merges --format='%ad %ae %s' 2019-02-22 crouleau@chromium.org Use the correct path for zipping. Created with: gclient setdep -r src/third_party/catapult@e4abf4c59be6 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:932615 TBR=sullivan@chromium.org Change-Id: I8fb625bd8e8a57fbc1c7478ca6d72502c2b5beb2 Reviewed-on: https://chromium-review.googlesource.com/c/1483124Reviewed-by:
-
Sylvain Defresne authored
Change client code to work as if IdentityManager::GetPrimaryAccount where returning a CoreAccountInfo instead of an AccountInfo. Method will be updated in a followup CL. Bug: 926204 Change-Id: I0941676744c9e0f277862e5f58999dc3635bd71e Reviewed-on: https://chromium-review.googlesource.com/c/1482465 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Nathan Parker <nparker@chromium.org> Reviewed-by:
-
Chris Lu authored
Creates FindInPageManagerTest to test FindInPageManager and FindInPageManagerDelegate. Bug: 919685 Change-Id: Ie226e5b56ce39c30252a948d7065e0c23b5ce4a7 Reviewed-on: https://chromium-review.googlesource.com/c/1482941Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#634793}
-
Daniel Nicoara authored
Move the wp_viewporter interface into its own files. This change only moves code around, no functional changes. Bug: 896710 Test: Build and run exo_unittests Change-Id: Ie9e2ea1a52ab26f77da3eca392f96d9099198fbc Reviewed-on: https://chromium-review.googlesource.com/c/1481061 Commit-Queue: Daniel Nicoara <dnicoara@chromium.org> Reviewed-by:
-
Sonny Sasaka authored
The Property of type map<string, vector<byte>> was created to read BlueZ's property which unfortunately was weirdly encoded as a{sv} (array of dictionary of string -> variant) instead of a{say} (array of dictionary of string -> array of bytes). In the future NewBlue won't code this D-Bus data the same weird way as BlueZ but will use a{say} instead so Chrome's reader has to be able to accept both format for the transition period. BUG=chromium:927021 Change-Id: I68bf79afe1899695fc0c04e9e429c7fc71efda6d Reviewed-on: https://chromium-review.googlesource.com/c/1450260Reviewed-by:Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
Sonny Sasaka <sonnysasaka@chromium.org> Commit-Queue: Sonny Sasaka <sonnysasaka@chromium.org> Cr-Commit-Position: refs/heads/master@{#634791}
-
Avery Musbach authored
This CL addresses a case where one user profile has one and only one window and it is snapped, and another user profile has no windows. Overview mode shall end when you switch from the profile with the snapped window to the one with no windows. Test: manual Bug: 934477 Change-Id: I9f55ee8c5adfde148d6b27e5e0aee9d52f788985 Reviewed-on: https://chromium-review.googlesource.com/c/1481799Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Avery Musbach <amusbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#634790}
-
Oystein Eftevaag authored
Adds support for enabling tracing on only the processes enabled in the tracing config (used by DevTools). Also fixed the ping to linearize with connected process, to happen at BeginTracing time and not connection time. R=ssid@chromium.org,eseckler@chromium.org TBR=dcheng@chromium.org Bug: 839084 Change-Id: I2f526b6124b096c8b068f513be92a31a8c3c6192 Reviewed-on: https://chromium-review.googlesource.com/c/1481797 Commit-Queue: oysteine <oysteine@chromium.org> Reviewed-by:
ssid <ssid@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#634789}
-
Frank Tang authored
This the Chromium side of adding usage counter for String.prototype.normalize() Bug: v8:8844 Change-Id: Ibda8f0ddda9159a6d52d6cf41d48b24a1a578920 Reviewed-on: https://chromium-review.googlesource.com/c/1482130 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#634788}
-
Zhongyi Shi authored
The config param is "retransmittable_on_wire_timeout_milliseconds". If not specified, the default value is 100ms. Bug: 933534, 934029 Change-Id: Ic7ef2459d76a8ce072b918cb525d1288840224b1 Reviewed-on: https://chromium-review.googlesource.com/c/1479942 Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#634787}
-
