- 11 Jun, 2014 40 commits
-
-
hidehiko@chromium.org authored
Now we're switching LoadNexeAndStart from synchronous implementation to asynchronous one. Under PPAPI implementation, the async callbacks are handled on main thread. To keep the similicity of the thread model, this CL introduces the limitation that Plugin::LoadNexeAndStart must be called on the main thread. TEST=Ran browser_tests --gtest_filter=NaCl* locally and trybots. BUG=333950 R=teravest@chromium.org Review URL: https://codereview.chromium.org/321053004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276371 0039d316-1c4b-4281-b951-d872f2087c98
-
keybuk@chromium.org authored
In order to use the chrome.bluetoothSocket and chrome.bluetoothLowEnergy APIs you will need to add "socket": true or "low_energy": true respectively to the "bluetooth" manifest section. BUG=376607,365839 TEST=tests updated Review URL: https://codereview.chromium.org/325893002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276370 0039d316-1c4b-4281-b951-d872f2087c98
-
brianderson@chromium.org authored
BUG=380987 Review URL: https://codereview.chromium.org/311263016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276369 0039d316-1c4b-4281-b951-d872f2087c98
-
jackhou@chromium.org authored
This test creates shims in the user data dir and actually starts them up and expects them to connect to the IPC socket. BUG=168080 Review URL: https://codereview.chromium.org/316493002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276368 0039d316-1c4b-4281-b951-d872f2087c98
-
mtomasz@chromium.org authored
By moving the options to a list, we can add more fields in the future without breaking backward compatibility. This CL is the first part of the cleanup. Arguments for callbacks will be refactored separately. TEST=unit_tests, browser_tests: *FileSystemProvider* BUG=373165 Review URL: https://codereview.chromium.org/329483002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276367 0039d316-1c4b-4281-b951-d872f2087c98
-
timurrrr@chromium.org authored
This way, the LKGR builder and the developers who want to try ASan (or just Clang) on Windows won't get a broken Clang revision. The FYI bots got LLVM_WIN_REVISION=HEAD in r276301 so won't be affected. BUG=82385,345874 NOTRY=true Review URL: https://codereview.chromium.org/320383004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276366 0039d316-1c4b-4281-b951-d872f2087c98
-
tasak@google.com authored
Should provide creation context and isolate for WebArrayConverter::toV8Value and WebArrayConverter::createFromV8Value. BUG=369451 Review URL: https://codereview.chromium.org/301883002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276361 0039d316-1c4b-4281-b951-d872f2087c98
-
cpu@chromium.org authored
The _Module object is used by ATL COM classes to lock the module, like so _pAtlModule->Lock(); For example when CreateInstance is called: BrowserAccessibility* BrowserAccessibility::Create() { CComObject<BrowserAccessibilityWin>* instance; HRESULT hr = CComObject<BrowserAccessibilityWin>::CreateInstance(&instance); We need to get rid of WTL so we can get rid of ATL since it causes many problems. See bug for details. BUG=5027 TEST=chrome runs. Accessibility works. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275987 Review URL: https://codereview.chromium.org/323723002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276360 0039d316-1c4b-4281-b951-d872f2087c98
-
kinaba@chromium.org authored
The current code is calling updateGearMenu_() before changing the currentVolumeInfo_ that is referred by the updating function. BUG=none TEST=Open a zip file. Close by eject icon. Check no error in background page console. Review URL: https://codereview.chromium.org/328003004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276359 0039d316-1c4b-4281-b951-d872f2087c98
-
jbauman@chromium.org authored
Allocating these can be expensive (especially on OS X) so it's best not to block the IO thread while doing that. BUG= Review URL: https://codereview.chromium.org/317973004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276358 0039d316-1c4b-4281-b951-d872f2087c98
-
holte@chromium.org authored
Adds Rappor metrics for Default Search Engine, Default Startup Tabs, and New Tab Pages. BUG=381325 Review URL: https://codereview.chromium.org/311133006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276357 0039d316-1c4b-4281-b951-d872f2087c98
-
zmo@chromium.org authored
BUG=368874,368910 TEST=gpu waterfall TBR=bajones@chromium.org Review URL: https://codereview.chromium.org/325063002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276356 0039d316-1c4b-4281-b951-d872f2087c98
-
xrenishere@gmail.com authored
When we invoke +[ExtensionPopupController showURL:...], we close the old Popup using [gPopup close],but we don't release it here. So host_ is only released when -[ExtensionPopupController windowWillClose] is invoked. At this time, the new popup might be ready. And when we use chrome.extension.getViews or some other apis we might get the dying window. So move shutdown of host_ from -[ExtensionPopupController windowWillClose] into -[ExtensionPopupController close]. BUG=376511 Review URL: https://codereview.chromium.org/321093002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276355 0039d316-1c4b-4281-b951-d872f2087c98
-
oshima@chromium.org authored
BUG=372212 R=mukai@chromium.org TBR=sky@chromium.org Review URL: https://codereview.chromium.org/326073005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276354 0039d316-1c4b-4281-b951-d872f2087c98
-
leng@chromium.org authored
This fixes a bug where links on the page underneath the bubble couldn't be clicked. Now, when the permission bubble first appears, the bubble will not immediately become the key window. However, if the user clicks within the bubble, it will be come key window, requiring a click within the content area to have the content area become key window again. BUG=381287 Review URL: https://codereview.chromium.org/324223002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276353 0039d316-1c4b-4281-b951-d872f2087c98
-
yoz@chromium.org authored
BUG=381889 Review URL: https://codereview.chromium.org/326673004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276352 0039d316-1c4b-4281-b951-d872f2087c98
-
aiolos@chromium.org authored
The bug says to "require" that people put the permissions in their page sets, but from talking to people it sounded like an optional parameter was better. If this should be more restrictive, let me know. R=dtu@chromium.org BUG=356956 Review URL: https://codereview.chromium.org/324503002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276350 0039d316-1c4b-4281-b951-d872f2087c98
-
michaeln@chromium.org authored
BUG=352447 TBR=sky Review URL: https://codereview.chromium.org/199153003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276348 0039d316-1c4b-4281-b951-d872f2087c98
-
jamesr@chromium.org authored
R=jbauman@chromium.org Review URL: https://codereview.chromium.org/327103002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276347 0039d316-1c4b-4281-b951-d872f2087c98
-
joaodasilva@chromium.org authored
The BookmarkClient can now provide additional nodes to the root of the BookmarkModel, which are optional. Currently none of those nodes should sync; this change makes that intention explicit in the bookmarks sync glue code. BUG=49598 Review URL: https://codereview.chromium.org/319133007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276346 0039d316-1c4b-4281-b951-d872f2087c98
-
about://indexeddb-internalsericu@chromium.org authored
BUG=none Review URL: https://codereview.chromium.org/327943004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276345 0039d316-1c4b-4281-b951-d872f2087c98
-
sergeyu@chromium.org authored
Previously decoded frames were returned using the DecodeCB callback, which is called in response to Decode(). This didn't work very well, particularly for GPU decoder, because decode buffers do not always map to decoded frames 1 to 1. BUG=338529 Review URL: https://codereview.chromium.org/297553002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276344 0039d316-1c4b-4281-b951-d872f2087c98
-
finnur@chromium.org authored
BUG=None R=rdevlin.cronin@chromium.org, sky@chromium.org TBR=sky Review URL: https://codereview.chromium.org/312943002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276343 0039d316-1c4b-4281-b951-d872f2087c98
-
newt@chromium.org authored
If the user opens many tabs and navigates to a NativePage in each tab, the NativePages may use enough memory to cause a Java out-of-memory error. This adds a method Tab.freezeNativePage() which destroys the current native page and replaces it with a FrozenNativePage, which allows querying getTitle(), getUrl(), etc, but can't be displayed. BUG=359573 Review URL: https://codereview.chromium.org/322253002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276342 0039d316-1c4b-4281-b951-d872f2087c98
-
andresantoso@chromium.org authored
Textfields require RenderTextHarfBuzz to work properly on the Mac because RenderTextMac's implementation is not complete. But RenderTextMac is used by the Cocoa UI to perform string sizing and elliding, HarfBuzz will not give the same answers. So for now we turn on HarfBuzz conditionally on OS_MACOSX and TOOLKIT_VIEWS. TextFieldModel and StyledLabel unit tests now pass without failures. BUG=378134 Review URL: https://codereview.chromium.org/326093004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276341 0039d316-1c4b-4281-b951-d872f2087c98
-
clamy@chromium.org authored
In layout tests in blink, WebTestProxyBase::WillSendRequest is used to dump the content of a request and compare it to an expected output. It should do so after RenderFrameImpl::willSendRequest has run, since we are moving the setting of parameters to RenderFrameImpl::willSendRequest. BUG=376025 Review URL: https://codereview.chromium.org/317413002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276340 0039d316-1c4b-4281-b951-d872f2087c98
-
sammc@chromium.org authored
Review URL: https://codereview.chromium.org/325093002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276339 0039d316-1c4b-4281-b951-d872f2087c98
-
vabr@chromium.org authored
This replaces the explanation/headline of chrome://password-manager-internals with a text suggestion from the UX team. BUG=347927 Review URL: https://codereview.chromium.org/323043003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276338 0039d316-1c4b-4281-b951-d872f2087c98
-
sammc@chromium.org authored
Review URL: https://codereview.chromium.org/311273003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276336 0039d316-1c4b-4281-b951-d872f2087c98
-
phajdan.jr@chromium.org authored
This avoids flooding the logs with lots of data that gums up the infrastructure. The summary contains the full snippet for debugging. BUG=382648 R=sky@chromium.org Review URL: https://codereview.chromium.org/324893004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276335 0039d316-1c4b-4281-b951-d872f2087c98
-
rsleevi@chromium.org authored
BUG=378079 R=jam@chromium.org Review URL: https://codereview.chromium.org/314053003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276334 0039d316-1c4b-4281-b951-d872f2087c98
-
mukai@chromium.org authored
InfolistWindow is just a view bubble, it shouldn't grab the focus. BUG=382201 R=shuchen@chromium.org, msw@chromium.org TEST=None Review URL: https://codereview.chromium.org/323943002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276333 0039d316-1c4b-4281-b951-d872f2087c98
-
achaulk@chromium.org authored
BUG=383031 TBR=zork Review URL: https://codereview.chromium.org/328863002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276332 0039d316-1c4b-4281-b951-d872f2087c98
-
ericu@chromium.org authored
Speed up IDB by trimming down the BlobChangeMaps. Check to see if we need each entry before adding it. BUG=380789 Review URL: https://codereview.chromium.org/322203004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276331 0039d316-1c4b-4281-b951-d872f2087c98
-
jbauman@chromium.org authored
This removes the dependency on LayerTreeHost, which was a layering violation. BUG=378549 Review URL: https://codereview.chromium.org/319133010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276329 0039d316-1c4b-4281-b951-d872f2087c98
-
simonb@chromium.org authored
- Forked from: android/platform/ndk/2b709a01b4d9fd1302689277ccfd475cab70a5e4 BUG= Review URL: https://codereview.chromium.org/322433006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276328 0039d316-1c4b-4281-b951-d872f2087c98
-
michaelpg@chromium.org authored
With --enable-settings-window, only Settings and Help should be shown in the left nav bar when opening settings or help. Likewise, history and extensions should be the only two nav items when loading those pages. This is a temporary change to unblock Settings in a Window. Going forward, we will remove the left nav entirely from the Settings window, so the logic for having nav item groups here is only temporary. See issue 294023013 for how this will be done after the branch. BUG=375425 R=dbeam@chromium.org,sky@chromium.org TBR=estade@chromium.org NOTRY=true # win_chromium_x64_rel flaky failures Review URL: https://codereview.chromium.org/313363004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276327 0039d316-1c4b-4281-b951-d872f2087c98
-
zea@chromium.org authored
BUG=none Review URL: https://codereview.chromium.org/329693003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276326 0039d316-1c4b-4281-b951-d872f2087c98
-
rmsousa@chromium.org authored
Refactor/clean-up individual policy processing. Separate policy application for config-dependent policies, and re-apply them when the config changes. BUG=381762 Review URL: https://codereview.chromium.org/320123002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276325 0039d316-1c4b-4281-b951-d872f2087c98
-
estade@chromium.org authored
BUG=382777 Review URL: https://codereview.chromium.org/328843002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276323 0039d316-1c4b-4281-b951-d872f2087c98
-