- 24 Mar, 2018 39 commits
-
-
Nasko Oskov authored
This CL tries to verify that whenever WCO::ReadyToCommitNavigation has been dispatched, subsequent WCO::DidFinishNavigation will return the same RenderFrameHost consistently. Change-Id: I3797b6c55b038941a65a92aa3439526e3ca62537 Reviewed-on: https://chromium-review.googlesource.com/977050 Commit-Queue: Nasko Oskov <nasko@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#545675}
-
wutao authored
This cl adds a11y support to pronounce how many search results are displaying Keyboard Shortcut Viewer (KSV). Bug: 757261, 817622 Test: manual test. Change-Id: Iaa79cb83dc3f97bb0e2ceb73b946116af39ad9de Reviewed-on: https://chromium-review.googlesource.com/978457 Commit-Queue: Tao Wu <wutao@chromium.org> Reviewed-by:
Qiang Xu <warx@google.com> Cr-Commit-Position: refs/heads/master@{#545674}
-
Dale Curtis authored
This moves the upload stage to VideoFrameStream via a new mechanism called "preparation." Callers can provide a PrepareCB to the stream which is called when there is sufficient space in |ready_outputs_|. This is an improvement over the current copy done by VideoRendererImpl because the VideoFrameStream (which sits between the renderer and the decoder) may hold undelivered frames until a subsequent Read(). At which point the frame still needs to be copied. This approach builds on top of lessons learned from the decoder based upload approach, https://crrev.com/c/947383, by avoiding upload of outputs as soon as they are delivered to OutputCB. This prevents a large memory regression with bursts of outputs. Performance is still improved just like the decoder wrapper approach, but just like there, it's a small improvement: ~16% reduction in read time for 4000 4K60 VP9 frames: https://www.youtube.com/watch?v=1La4QzGeaaQ (4K60 VP9) The real improvement will come later when we paralleize the decoding for offloaded decoders: https://crrev.com/c/945029 BUG=801245 TEST=updated VideoFrameStream unittests. VRI tests still pass. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ib4fa788dad14631caff3f877484fa89fdebca119 Reviewed-on: https://chromium-review.googlesource.com/976582 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#545673}
-
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/82a6480a3a0d..dbbf350a34ab $ git log 82a6480a3..dbbf350a3 --date=short --no-merges --format='%ad %ae %s' 2018-03-23 iannucci Fix trailing whitespace test. 2018-03-23 iannucci Fix actual pylint errors. Created with: roll-dep src/third_party/depot_tools BUG=chromium:825290,chromium:825174,chromium:825290,chromium:825174 The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: If3ca536bc4f21f1f692b3c6ebdffae05203db93b Reviewed-on: https://chromium-review.googlesource.com/979293Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#545672}
-
Shimi Zhang authored
This CL is introducing an interface allow us to add more menu items under certain circumstance. A doc to explain weird decisions is here: https://docs.google.com/document/d/1Zzeg9w0LQDG7hUkuJY4YNXFVKEknNiH8tv2zAOUh4G0 Bug: 808510, b/70523982 Change-Id: I3bec6ad76ad8ec5a3a54b406d0e47f7c0c2168ac Reviewed-on: https://chromium-review.googlesource.com/977222Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Pedro Amaral <amaralp@chromium.org> Commit-Queue: Shimi Zhang <ctzsm@chromium.org> Cr-Commit-Position: refs/heads/master@{#545671}
-
https://webrtc.googlesource.com/src.git/+log/9718711deed8..2bd41f9e0ea2 $ git log 9718711de..2bd41f9e0 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ib3f115757d84a6913753c72bc657c60d6c559349 Reviewed-on: https://chromium-review.googlesource.com/979255Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#545670}
-
https://chromium.googlesource.com/angle/angle.git/+log/ad4f9642a655..26ed93d7db23 $ git log ad4f9642a..26ed93d7d --date=short --no-merges --format='%ad %ae %s' 2018-03-23 ynovikov Reduce number of uniforms in UniformsBenchmark perf test Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=jmadill@chromium.org Change-Id: I4bcd135f5f2033c5eeb620f6ddf4d9037ac601db Reviewed-on: https://chromium-review.googlesource.com/979165Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#545669}
-
Robert Iannucci authored
R=jbudorick@chromium.org Bug: 825290 Change-Id: Ic87937f62f390c567c7d0a5ed48795096574afff Reviewed-on: https://chromium-review.googlesource.com/979257Reviewed-by:
Marc-Antoine Ruel <maruel@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Robbie Iannucci <iannucci@chromium.org> Cr-Commit-Position: refs/heads/master@{#545668}
-
Alexis Hetu authored
This function is required for YUV decoding in Chromium on MacOS using EGL. Fixes WebGL conformance test: conformance/extensions/oes-texture-float-with-video.html Bug: chromium:757974 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I143d69d30251b361daad13b4c0190e13f66795f8 Reviewed-on: https://chromium-review.googlesource.com/956247Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Alexis Hétu <sugoi@chromium.org> Cr-Commit-Position: refs/heads/master@{#545667}
-
Dale Curtis authored
There's a mix of in-header and in-class initialization for default values, switch everything that's not a constructor to being done in-header. BUG=none TEST=none Change-Id: Ib097435d06509484fa80e277381990dc2faab52e Reviewed-on: https://chromium-review.googlesource.com/978586Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#545666}
-
https://chromium.googlesource.com/catapult.git/+log/c4e9b1332818..fe230b67399b $ git log c4e9b1332..fe230b673 --date=short --no-merges --format='%ad %ae %s' 2018-03-23 eakuefner [Build] Fix tracing Python tests Created with: roll-dep src/third_party/catapult BUG=chromium:825174 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=sullivan@chromium.org Change-Id: Ic39c3da2c175d4b435cc3cc7cb6c4989a3d812d9 Reviewed-on: https://chromium-review.googlesource.com/979170 Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#545665}
-
Alexei Filippov authored
The thread selector supposed to be in sync across all views. The patch fixes the regression. Change-Id: Idea1cfd3d85a402af64d251ea5e55555ce26429e Reviewed-on: https://chromium-review.googlesource.com/979253Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#545664}
-
Wenzhao Zang authored
The only file remaining in the directory is |wallpaper_manager_policy_browsertest.cc|, and these tests mainly test the code path in |chrome_user_manager_impl|, so it makes sense to put them together. //ash/wallpaper does not rely on these tests. There's sufficient test coverage in //ash for user policy and device policy wallpapers already. In addition, remove //ash dependency to make it work under Mash. Bug: NONE Test: browser_tests Change-Id: I187e9d34c69cfc63c8119c05886f96274a41dc8c Reviewed-on: https://chromium-review.googlesource.com/978838Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#545663}
-
Hirokazu Honda authored
This introduces ProtectedBufferAllocator. ProtectedSharedMemory or ProtectedNativePixmap can be allocated/deallocated by using ProtectedBufferAllocator. By now, GpuArcVideoDecodeAccelerator allocates/dealllcates directly calling ProtectedBufferManager. It instead allocates/deallocates by ProtectedBufferAllocator which is provided by ProtectedBufferManager. ProtectedBufferHandle can deprecated thanks to ProtectedBufferAllocator. BUG=b:72354215 BUG=chromium:804687 TEST=Play Secure video using EXO Player. TEST=CtsMediaTestCases TEST=GtsMediaTestCases Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: Id54f4099f5cc1f494d5c9946e1f8cc859819bf7f Reviewed-on: https://chromium-review.googlesource.com/963877Reviewed-by:
Pawel Osciak <posciak@chromium.org> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#545662}
-
Jay Civelli authored
Fixes several local NTP tests with the network service by registering the chrome-search scheme with the appropriate URLDataLoader. That fixes the last interactive UI test failure and the associated filter file is removed. Bug: 819249 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: Ie7b01dc92cd74238d941bc358ed287d860831c97 Reviewed-on: https://chromium-review.googlesource.com/978847 Commit-Queue: Jay Civelli <jcivelli@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#545661}
-
Chris Palmer authored
Marginally. Bug: None Change-Id: I6f5008a6e0cf2c22570fdf44a81ef1fa352a151b Reviewed-on: https://chromium-review.googlesource.com/979037Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Chris Palmer <palmer@chromium.org> Cr-Commit-Position: refs/heads/master@{#545660}
-
Wenzhao Zang authored
Reading from VPD is supported by StatisticsProvider so IMO we can reuse the code. There will be a follow-up Chrome OS CL to deal with writing to VPD specifically. Bug: 820783 Change-Id: I57de7212ca3b5366731789f0836ab5c6fcca294f Reviewed-on: https://chromium-review.googlesource.com/969942 Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Cr-Commit-Position: refs/heads/master@{#545659}
-
Avi Drissman authored
BUG=714018 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I2ca24193658c5d25d4038151b04b7216bb4bf2ba Reviewed-on: https://chromium-review.googlesource.com/976392 Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#545658}
-
Mitsuru Oshima authored
This is a temp fix. It looks like it's trying to reveal first when created, but it doesn't work that way. This could be either regression, or wrong, and I'll look into separately. BUG=825260 Change-Id: Idc605ef9f42b48b847c3bc562ebd1d9a3a0c33c6 Reviewed-on: https://chromium-review.googlesource.com/978891 Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#545657}
-
Lei Zhang authored
BUG=788243 Change-Id: Icd243edd24295125599f09adbebcadec62487e89 Reviewed-on: https://chromium-review.googlesource.com/976689 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#545656}
-
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/0d9ecc925d38..82a6480a3a0d $ git log 0d9ecc925..82a6480a3 --date=short --no-merges --format='%ad %ae %s' 2018-03-23 iannucci [presubmit_canned_checks] Stop exporting sys.path into PYTHONPATH. Created with: roll-dep src/third_party/depot_tools BUG=chromium:825290,chromium:825174 The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: Ic28a910f52c64051a17e2a9f94a3886f7bb237f2 Reviewed-on: https://chromium-review.googlesource.com/979114Reviewed-by:
-
David Bokan authored
ScrollIntoView is a virtual method on ScrollableArea. In ScrollableArea, the param implies the rect param is in content coordinates. However, implementations varied. RootFrameViewport required content/document coordinates but PLSA assumed it was in absolute coordinates. This CL ensures the interface and all implementations take the param in absolute coordinates and cleans up the callsites in LayoutBox's ScrollRectToVisibleRecursive. I've also cleaned up some variable names where I found ambiguity. There's also a change in LayoutBox::Autoscroll to change RootFrameToContents to RootFrameToAbsolute. This is a bit misleading since RootFrameToContents uses the term "contents" to mean "frame" when root-layer-scrolling is turned on. This means the code is correct but looks strange. Changing it to RootFrameToAbsolute has no functional difference (the code is the same) but fits better with the naming scheme (and we'll likely remove RootFrameToContents once root-layer-scrolling is fully shipped). Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I2d9ab7e851d63c0e5d9e5d2e2025b1f8bbf460c1 Reviewed-on: https://chromium-review.googlesource.com/972430 Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by:
Sandra Sun <sunyunjia@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#545654}
-
Jun Mukai authored
It seems this causes repositions of the toggle buttons when subtitles are set / cleared. Bug: 823656 Change-Id: Id987bd7f6291d4debdfb17d7fac34daedbe21117 Reviewed-on: https://chromium-review.googlesource.com/978889Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Jun Mukai <mukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#545653}
-
Candice Sy authored
Bug: 824602 Change-Id: I1aa2c7c43ec1e6afc343a239c30846258a231644 Reviewed-on: https://chromium-review.googlesource.com/978545 Commit-Queue: Candice Sy <cmsy@google.com> Reviewed-by:
Cathy Li <chili@chromium.org> Cr-Commit-Position: refs/heads/master@{#545652}
-
Chris Palmer authored
We were in a maze of twisty #ifdefs, all alike. We are now somewhat less likely to be eaten by a grue. TBR=dcheng Bug: 766882 Change-Id: Ib72010a76cdf76fc1ec821b618cc0ad967d687ab Reviewed-on: https://chromium-review.googlesource.com/978860 Commit-Queue: Chris Palmer <palmer@chromium.org> Reviewed-by:
-
Scott Violet authored
This updates mojo, net and pdf. Targets go from foo_features to foo_buildflags And similarly the header now has buildflags in the name. BUG=814485 TEST=covered by build Change-Id: I279223aa2bdfc375288eee485a77bfad9b6db3d4 Reviewed-on: https://chromium-review.googlesource.com/978372 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#545650}
-
Lukasz Anforowicz authored
The move helps ensure that --site-per-process stays turned off by default in the //content layer (this is needed to avoid opting into --site-per-process all //content embedders like ChromeCast). The move enables selectively enabling --site-per-process at the //chrome layer. Bug: 824966 Change-Id: Icc3354dfeb2ff20c6027267890596b929331c1ed Reviewed-on: https://chromium-review.googlesource.com/976880 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#545649}
-
Miguel Casas-Sanchez authored
This CL corrects the usage of |fast_mode| (which is reversed on ToT), adds a note about CIDetectorMaxFeatureCount and improves unit tests. Anecdotically, Spec issue [1] primed me to wire the max-detected-faces option that was apparently available on 10.12; on a closer reading of the header files (not of the online docs), the setting is only actually available for rectangle detection. [1] https://github.com/WICG/shape-detection-api/issues/39 Cq-Include-Trybots: luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win10_chromium_x64_rel_ng Change-Id: I6d66b477d0a408c4950d8956d1e020c81e558269 Reviewed-on: https://chromium-review.googlesource.com/978511Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
-
Christopher Grant authored
BUG=824969 R=mthiesse Change-Id: Ifeb8f82e41ade9bdb10c7649cb7d2a4f1e06851c Reviewed-on: https://chromium-review.googlesource.com/978659Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#545647}
-
John Budorick authored
Bug: 755920 Change-Id: Idb7367fcd6e425d3a2a2e5c05599abc3fa5954ef Reviewed-on: https://chromium-review.googlesource.com/930178Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Shenghua Zhang <shenghuazhang@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#545646}
-
Christopher Grant authored
Have the button class itself assign default sounds. This ensures they all sound the same, in both enabled and disabled states. BUG=823413 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Id254c67f702d7cd7ccd169b55f68f9b79cf4eb49 Reviewed-on: https://chromium-review.googlesource.com/978631 Commit-Queue: Christopher Grant <cjgrant@chromium.org> Reviewed-by:
Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#545645}
-
Qiang Xu authored
Bug: none Test: covered by tests Change-Id: If2c3601446dd48391aed141e28bf8c3ee2e11c9e Reviewed-on: https://chromium-review.googlesource.com/978934 Commit-Queue: Qiang Xu <warx@google.com> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#545644}
-
Mike Wasserman authored
Avoid overriding the OzonePlatform instance with a test subclass. Instead, have PlatformDisplayDefault make StubWindows for invalid ids. Bug: 732987 Test: Automated Change-Id: I981e844861fbd045eee5436aede91a35c7f8f682 Reviewed-on: https://chromium-review.googlesource.com/978375Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Reviewed-by:
-
Steven Holte authored
Bug: 761524 Change-Id: Ia9f024dc01732814a8b8eaf7a5284f99e899e418 Reviewed-on: https://chromium-review.googlesource.com/976948 Commit-Queue: Steven Holte <holte@chromium.org> Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Siddhartha S <ssid@chromium.org> Cr-Commit-Position: refs/heads/master@{#545642}
-
Raymond Toy authored
Change-Id: Ibfefd9929b5f60b7c0de954ceee75142fdb6a838 Reviewed-on: https://chromium-review.googlesource.com/979016Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Commit-Queue: Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#545641}
-
Lukasz Anforowicz authored
Bug: 825325 Change-Id: I17d46070a5fc5a060b0881a2ba58f52ffce07f1d Reviewed-on: https://chromium-review.googlesource.com/978674 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
-
Jinsuk Kim authored
The WindowAndroid object for WebContents(or ContentViewCore) can be obtained through WebContents.getTopLevelNativeWindow. This CL removes the API in ContentViewCore that returns the same object. Internally, ContentViewCore uses the cached value updated via |updateWindowAndroid| instead. Bug: 598880 Change-Id: I19707db25ba9e7e55e85c1275e27d1c63e5167b4 Reviewed-on: https://chromium-review.googlesource.com/977101Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#545639}
-
Evangelos Foutras authored
Ensure ICU symbols have public visibility and are thus excluded from CFI checks and whole-program optimization. The former caused a startup crash and the latter has the potential to break virtual calls in weird ways. BUG=822820 Change-Id: Ia809eefcb9e93b3c612f2381d394db83bbc67120 Reviewed-on: https://chromium-review.googlesource.com/978008Reviewed-by:
Peter Collingbourne <pcc@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#545638}
-
Jialiu Lin authored
Bug: 825268 Change-Id: I575c9600b2989fbedc78bfa38f4888b8aec8965d Reviewed-on: https://chromium-review.googlesource.com/978505 Commit-Queue: Jialiu Lin <jialiul@chromium.org> Reviewed-by:
Luke Z <lpz@chromium.org> Cr-Commit-Position: refs/heads/master@{#545637}
-
- 23 Mar, 2018 1 commit
-
-
wutao authored
KeycodeConverter::DomKeyToKeyString cannot show correct string if the dom_key has no mapping. This cl handles this corner case to display alternative string in Keyboard Shortcut Helper (KSV). Bug: 824495 Test: On device with Swedish keyboard layout. Change-Id: I3c54941b89ce34244c8b69d4a905cb1ddbdffb11 Reviewed-on: https://chromium-review.googlesource.com/974474 Commit-Queue: Tao Wu <wutao@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#545636}
-
