- 09 Nov, 2018 40 commits
-
-
Balazs Engedy authored
Add a TRACE_EVENT to track how long it takes to initialize content_settings::PrefProvider, and record the number of exceptions parsed. Bug: 890129 Change-Id: Ic70783bc9c69f4ce0fdb84e5406701b59bbcbd10 Reviewed-on: https://chromium-review.googlesource.com/c/1326150Reviewed-by:
oysteine <oysteine@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Reviewed-by:
ssid <ssid@chromium.org> Commit-Queue: Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#606976}
-
danakj authored
During the navigation in the test, a renderer is loading a page and if it completes in time, sends a AddLinkRelPrerender IPC to the browser to start a link prerenderer. If this occurs before the navigation started by the test completes, then the test will fail with the wrong number of prerenderers. This seems to imply the test is exiting too quickly, and not observing the actual number of prerenderers that we create. TBR=droger@chromium.org NOTRY=true Change-Id: If74bf60f45b60f52041167532eca9915c6d604b3 Bug: 903695 Reviewed-on: https://chromium-review.googlesource.com/c/1330287Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#606975}
-
Roger McFarlane authored
Bug: 896719 Change-Id: I52ae96084f32210ef187a023fa6090f57928a654 Reviewed-on: https://chromium-review.googlesource.com/c/1330343Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Roger McFarlane <rogerm@chromium.org> Cr-Commit-Position: refs/heads/master@{#606974}
-
Martin Kreichgauer authored
This changes the return type of FidoAuthenticator::Options() from AuthenticatorSupportedOptions to base::Optional<AuthenticatorSupportedOptions>. The FidoAuthenticator subclass for the Windows WebAuthn API can potentially talk to a number of different authenticators with different capabilities and hence cannot return a sensible value for this method. It previously returned a "maximum possible" Options value; but that lead to a bug where GetAssertionHandler assumed it could set the user verification requirement of a request from "preferred" to "required" because the Windows authenticator reported itself as having a PIN set up (while the actual physical device might not even support PINs). By returning an Optional, we make the Windows case more explicit. The aforementioned bug is fixed by moving the "effective uv requirement" computation for GetAssertion into FidoDeviceAuthenticator. For MakeCredential, we have a similar bug: Because CtapMakeCredentialRequest only stores the UV requirement as a bool rather than the full enum, we currently default to uv=false for authenticators that *do* support UV (even in the non-Windows case), which is wrong. I'm going to address this in an immediate follow up CL. Bug: 898718 Change-Id: I3e40296578929c75585e820aa5764bd623e1fe79 Reviewed-on: https://chromium-review.googlesource.com/c/1321852 Commit-Queue: Martin Kreichgauer <martinkr@google.com> Reviewed-by:
Kim Paulhamus <kpaulhamus@chromium.org> Cr-Commit-Position: refs/heads/master@{#606973}
-
dpapad authored
This code should have been removed as part of https://chromium-review.googlesource.com/c/chromium/src/+/1029952/ Bug: 902959,828890 Change-Id: Ib7e00a646c864bea6b741924d6c592197ff2863d Reviewed-on: https://chromium-review.googlesource.com/c/1327227Reviewed-by:
Esmael El-Moslimany <aee@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#606972}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/6edb632ff8cd..e28390cc438f git log 6edb632ff8cd..e28390cc438f --date=short --no-merges --format='%ad %ae %s' 2018-11-09 pbos@chromium.org Add the opt-in/out commands to metrics notice Created with: gclient setdep -r src/third_party/depot_tools@e28390cc438f The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:None TBR=agable@chromium.org Change-Id: I2350f1de79641e10fbd18a95062641e2136e9495 Reviewed-on: https://chromium-review.googlesource.com/c/1329986Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#606971}
-
Dmitry Titov authored
Bug: 861647 Change-Id: I405a0221ff7a26b6e892ab738efca6102d2f54c9 Reviewed-on: https://chromium-review.googlesource.com/c/1329885 Commit-Queue: Dmitry Titov <dimich@chromium.org> Reviewed-by:
Dan H <harringtond@google.com> Cr-Commit-Position: refs/heads/master@{#606970}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/31d1c800f1a0..db21dac6ad7d Created with: gclient setdep -r src-internal@db21dac6ad7d The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:448088 TBR=mmoss@chromium.org Change-Id: I5b99814a47f06e430d86317cd0d80b4fcaf5d069 Reviewed-on: https://chromium-review.googlesource.com/c/1329987Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#606969}
-
David Tseng authored
Bug: 875437 Change-Id: I708517acb953d5ec0cb243c30c44c349f40fbe9b Reviewed-on: https://chromium-review.googlesource.com/c/1324869 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#606968}
-
weiliangc authored
This reverts commit b8e27a0d. Reason for revert: Fail at compile for GPU FYI bots. Linking error see crbug.com/903934 for more deails. Original change's description: > [skia][libFuzzer] Allow building targets from OSS-Fuzz on Windows > > Chrome ClusterFuzz has support for Windows while OSS-Fuzz does not. > Enable low hanging fruit that can easily be built in a Chromium build. > > Bug: 903632 > Change-Id: I9b6c9bf883271d33135a4fea31a05be3d13648df > Reviewed-on: https://chromium-review.googlesource.com/c/1328225 > Reviewed-by: Mike Klein <mtklein@chromium.org> > Commit-Queue: Jonathan Metzman <metzman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#606938} TBR=kjlubick@chromium.org,mtklein@chromium.org,metzman@chromium.org Change-Id: I9398c135a4dfaa96c8e24e6566d2af87f3212ab6 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 903632 Reviewed-on: https://chromium-review.googlesource.com/c/1330325Reviewed-by:
weiliangc <weiliangc@chromium.org> Commit-Queue: weiliangc <weiliangc@chromium.org> Cr-Commit-Position: refs/heads/master@{#606967}
-
David Black authored
AssistantWebView is the host for embedding the web contents used by Assistant Settings and Reminders. Previously, AssistantWebView did not handle either single- or multi-process mash, so the web contents would not be embedded. Now, we use Content Service which works in both single- and multi- process mash in the same pattern established for AppList in: https://chromium-review.googlesource.com/c/chromium/src/+/1269622 This required adding a few new abilities to NavigableContents that Assistant has the need for: - Adding min/max size for auto resizing. - Adding ability to navigate backwards in history stack. - Adding handling for target="_blank" links. Still TODO: Do the same for the Assistant cards that are embedded in Assistant's UiElementContainerView. Once this is complete, we will be able to remove WebContentsManager and associated classes/logic :) Bug: b:78078693 Change-Id: I4dd19a0a4c9506fc6b7f065d54fc1a75132d278f Reviewed-on: https://chromium-review.googlesource.com/c/1313745 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#606966}
-
John Abd-El-Malek authored
Bug: 891074 Change-Id: I8904c8d0285b8b2f245456509d88206f4789fc8d Reviewed-on: https://chromium-review.googlesource.com/c/1330064Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#606965}
-
Vaclav Brozek authored
Chrome currently won't autofill credentials into forms which have a "new-password" field. This includes change-password forms, which also have the "current-password" field. Filling that is actually useful for users. Therefore this CL changes the condition aginst autofilling to only pick forms which do not have the "current-password" field. This is limited to the kNewPasswordFormParsing feature, to make it easier to understand the impact of that change to the overall difference between the old parser and the new parser. Bug: 895781 Change-Id: I39cee16c725d108213e045f0cef94f52a6e80837 Reviewed-on: https://chromium-review.googlesource.com/c/1309742 Commit-Queue: Vaclav Brozek <vabr@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#606964}
-
Philip Rogers authored
This patch switches PaintTouchActionRects to status=test while the root-cause of https://crbug.com/903480 is investigated. This will turn the feature off for end-users and performance tests, though it is still on for layout tests and content shell. Bug: 903480 Change-Id: Iff6695cd6140c7caf29819a856a7b894fd4d6733 Reviewed-on: https://chromium-review.googlesource.com/c/1330070 Commit-Queue: Philip Rogers <pdr@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#606963}
-
Xi Cheng authored
Bug: 888716, 851163 Change-Id: I4ac176bf42d716f163717022352793dee763399a Reviewed-on: https://chromium-review.googlesource.com/c/1327704 Commit-Queue: Xi Cheng <chengx@chromium.org> Reviewed-by:
Mike Wittman <wittman@chromium.org> Cr-Commit-Position: refs/heads/master@{#606962}
-
David Quiroz Marin authored
Change-Id: I0ad5183c8d8af1432dc59504ffb589d7ba799afe Reviewed-on: https://chromium-review.googlesource.com/c/1327903Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Commit-Queue: David Quiroz Marin <davidqu@chromium.org> Cr-Commit-Position: refs/heads/master@{#606961}
-
Ken Rockot authored
Adds a globally_unique_id field to each service's Identity, generated and assigned by the Service Manager when starting any new service instance. This ensures that every running service instance has an Identity that is globally unique across space and time. TBR=jam@chromium.org Bug: 840127,895591 Change-Id: If32863b7d8562e3a2cd9625d8eed2db8e83c67cb Reviewed-on: https://chromium-review.googlesource.com/c/1318806 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#606960}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/ef4709b7850d..b07ed8fb0766 git log ef4709b7850d..b07ed8fb0766 --date=short --no-merges --format='%ad %ae %s' 2018-11-09 halcanary@google.com SkQP: revert change that broke something 2018-11-09 mtklein@google.com clean up SkBlitRow_opts 2018-11-09 halcanary@google.com SkQP run_skqp.sh catches crashes and failures now. 2018-11-09 jvanverth@google.com Merge common code for SkImage_Gpu and SkImage_GpuYUVA. 2018-11-09 mtklein@google.com move LCD blits to SkBlitter_ARGB32.cpp 2018-11-09 michaelludwig@google.com Improve degenerate 2pt conical gradient cases 2018-11-09 reed@google.com Reland "remove guards for hinting in google3" 2018-11-09 reed@google.com Revert "remove guards for hinting in google3" Created with: gclient setdep -r src/third_party/skia@b07ed8fb0766 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=allanmac@chromium.org Change-Id: I038cc1494a8bfa05745baea82304f7bb47aae1b7 Reviewed-on: https://chromium-review.googlesource.com/c/1330022Reviewed-by:
-
Douglas Creager authored
Piece by piece, we are moving the Reporting and NEL processing code from URLRequest and friends into HTTPNetworkTransaction, to make sure that we produce reports for network requests as defined by the spec. This patch moves the generation of the actual NEL reports, and includes some new WPT test cases that verify that we create reports correctly for redirects and cached responses. TBR=msramek@chromium.org Bug: 895823 Change-Id: Ie8e17a2a2b3571a7cdfd39057da486f5ad2c9f6f Reviewed-on: https://chromium-review.googlesource.com/c/1318169 Commit-Queue: Douglas Creager <dcreager@chromium.org> Reviewed-by:
Misha Efimov <mef@chromium.org> Cr-Commit-Position: refs/heads/master@{#606958}
-
Steven Bennetts authored
This will allow easier restriction of ui/keyboard from src/chrome. Bug: 876138 Change-Id: I3db0793734225229b45aec08df9887277dbef491 For trivial header renames in: chrome/browser/extensions/chrome_component_extension_resource_manager.cc chrome/browser/ui/views/select_file_dialog_extension_browsertest.cc chrome/common/extensions/chrome_manifest_url_handlers.cc TBR=sky@chromium.org Change-Id: I3db0793734225229b45aec08df9887277dbef491 Reviewed-on: https://chromium-review.googlesource.com/c/1316103 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#606957}
-
Greg Kerr authored
This adds a unit test that the V2 renderer sandbox profile cannot write to the homedir. Bug: 902597 Change-Id: I6b8c850bdafcb377070e22ed2a1459bcd631b69c Reviewed-on: https://chromium-review.googlesource.com/c/1321862Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Greg Kerr <kerrnel@chromium.org> Cr-Commit-Position: refs/heads/master@{#606956}
-
Ted Choc authored
BUG=903879 Change-Id: Ib032d8d0ef9c3b3804c14e79a2c4904f32453c9e Reviewed-on: https://chromium-review.googlesource.com/c/1330071Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#606955}
-
David Benjamin authored
This reverts commit 3fe2afdd. Reason for revert: The test failure is in a failure to run the test server, which points to an infrastructure issue around Python. Also, this change only affects client certs, which do not figure into any of the affected tests. Additionally, subsequent test runs show the test failure persists, so the revert didn't fix it: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.10%20Tests/36156 Original change's description: > Revert "Route SSLPrivateKey provider names into NetLog." > > This reverts commit db889e10. > > Reason for revert: Speculative revert: A bunch of SSL related tests failing on Mac: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.10%20Tests/36146 > > Original change's description: > > Route SSLPrivateKey provider names into NetLog. > > > > Improve debugging in the future so we don't have to keep asking "are you > > using a smartcard? which?". > > > > Bug: none > > Cq-Include-Trybots: luci.chromium.try:linux_mojo > > Change-Id: Ifbaf6f5aa0aa73dcd19be0ccc0046c2c2c069319 > > Reviewed-on: https://chromium-review.googlesource.com/c/1292509 > > Commit-Queue: David Benjamin <davidben@chromium.org> > > Reviewed-by: Maksim Ivanov <emaxx@chromium.org> > > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > > Reviewed-by: Ryan Sleevi <rsleevi@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#606700} > > TBR=rsleevi@chromium.org,kinuko@chromium.org,davidben@chromium.org,emaxx@chromium.org > > Change-Id: Icb8db36c96ba199e0857296cd21fa9d3e8826c90 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: none > Cq-Include-Trybots: luci.chromium.try:linux_mojo > Reviewed-on: https://chromium-review.googlesource.com/c/1328882 > Reviewed-by: Patrik Höglund <phoglund@chromium.org> > Commit-Queue: Patrik Höglund <phoglund@chromium.org> > Cr-Commit-Position: refs/heads/master@{#606779} TBR=rsleevi@chromium.org,kinuko@chromium.org,davidben@chromium.org,phoglund@chromium.org,emaxx@chromium.org Change-Id: I4a0a6488731e5ae527bf3f924724a9bafa62c7ad No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: none Cq-Include-Trybots: luci.chromium.try:linux_mojo Reviewed-on: https://chromium-review.googlesource.com/c/1329887Reviewed-by:
David Benjamin <davidben@chromium.org> Commit-Queue: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#606954}
-
Roger McFarlane authored
This CL adds the getAriaLabel() and getAriaDescription() helper functions to the __gCrWeb.fill "namespace". These functions return the ARIA label and description strings associated with an element. The ARIA Label is the text referenced by one or more containing element ids in the labelled elements aria-labelledby attribute, or the value of the element's aria-label attribute, with preference given to the aria-labelledby attribute. For example: <div id='foo-label'>Label for Foo</div> <input name='foo' aria-labelledby='foo-label'> <input name='bar' aria-label='Label for Bar'> The aria-description is similar to aria-labelledby. For example: <div id='foo-description'>Long descriptive text for Foo</div> <input name='foo' aria-describedby='foo-descrition'> Bug: 896719 Change-Id: Ib69154fe4a98389f466d8ce81cbb7c3b0cfe3215 Reviewed-on: https://chromium-review.googlesource.com/c/1329898Reviewed-by:Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Roger McFarlane <rogerm@chromium.org> Cr-Commit-Position: refs/heads/master@{#606953}
-
Egor Pasko authored
Remove the pagesets that were used for TBMv1 startup benchmarks. These benchmarks were removed already leaving the pagesets unused. We still depend on the json and the WPR archives in the TBMv2 benchmark (startup.mobile). Bug: 760498 Change-Id: I814840fd5696d8f7f696b29678c98ab4f0541b8b Reviewed-on: https://chromium-review.googlesource.com/c/1329662Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#606952}
-
Sunny Sachanandani authored
This reverts commit 6fb9951c. Reason for revert: Not responsible for test failures. See crbug.com/903931 Original change's description: > Revert "Reenable direct composition without video layers" > > This reverts commit eec86ff6. > > Reason for revert: Appears to break cc_unittests on the Linux CFI bot: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20CFI/11190 > > Original change's description: > > Reenable direct composition without video layers > > > > Reenable direct composition surface on devices without hardware overlays > > since it enables other power improvements like flip mode swap chain and > > disabling DWM redirection surface. > > > > To mitigate the original concerns about direct composition, this change > > makes DCLayerTree lazy initialize the video context and processor when > > a video layer is first used. On devices that don't support hardware > > overlays, the video context and processor will never be initialized. > > > > Bug: 894675, 900702 > > Change-Id: I8c9d5b78718de2620ca177410d4916390e7cb219 > > Reviewed-on: https://chromium-review.googlesource.com/c/1318808 > > Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> > > Reviewed-by: Zhenyao Mo <zmo@chromium.org> > > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > > Reviewed-by: Antoine Labour <piman@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#606312} > > TBR=dcheng@chromium.org,zmo@chromium.org,sunnyps@chromium.org,piman@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 894675, 900702 > Change-Id: I094721159277c50d9061dfded252bbac1084977f > Reviewed-on: https://chromium-review.googlesource.com/c/1328965 > Reviewed-by: Patrik Höglund <phoglund@chromium.org> > Commit-Queue: Patrik Höglund <phoglund@chromium.org> > Cr-Commit-Position: refs/heads/master@{#606810} TBR=dcheng@chromium.org,phoglund@chromium.org,zmo@chromium.org,sunnyps@chromium.org,piman@chromium.org Change-Id: I47896832307fc7be15acfcefffe1953411e15cad No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 894675, 900702, 903931 Reviewed-on: https://chromium-review.googlesource.com/c/1330284Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#606951}
-
Eugene But authored
Use existing currentWKItemURL variable instead of net::GURLWithNSURL(webView.backForwardList.currentItem.URL) Bug: None Change-Id: If84aca1551f43d6ccfc36eb404213967148cb030 Reviewed-on: https://chromium-review.googlesource.com/c/1329890Reviewed-by:
Danyao Wang <danyao@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#606950}
-
James Hawkins authored
R=hansberry@chromium.org Bug: 899324 Test: none Change-Id: Ic9ea29d50b11385db9641a0d106a80b68ea0b1da Reviewed-on: https://chromium-review.googlesource.com/c/1327417Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: James Hawkins <jhawkins@chromium.org> Cr-Commit-Position: refs/heads/master@{#606949}
-
Ahmed Fakhry authored
1) The Home Launcher used to use the wrong display ID when in Unified Desktop mode. 2) If (1) is fixed, we hit https://crbug.com/902601. The captive portal dialog widget used to be leaked and never destroyed. 3) If (2) is fixed, we crash on the first attempt to press the app list button. The reason is tablet mode triggers a switch to mirror mode. This switch happens asynchronously after the Home Launcher had already been created. Switching from Unified to mirror mode destroys the Unified host and the Home Launcher. That's why we need to ensure that the Home Launcher is recreated. TBR=oshima@chromium.org,weidongg@chromium.org BUG=900956, 902601 TEST=Added a test that crashes without the fix. Reviewed-on: https://chromium-review.googlesource.com/c/1325389 Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Weidong Guo <weidongg@chromium.org> Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#606687} Change-Id: Ia0558bf1eba4234535b3826e671929e37db8dee1 Reviewed-on: https://chromium-review.googlesource.com/c/1329550Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#606948}
-
Lei Zhang authored
In VerifyEndpoint(), the code that catches an exception tries to continue, only to hit an UnboundLocalError. Instead of doing that, raise an SystemExit to fail gracefully. Change-Id: Idf1174ef01fbe7a086712fa6e7b9cca7ada97a69 Reviewed-on: https://chromium-review.googlesource.com/c/1313561Reviewed-by:
Steve Kobes <skobes@chromium.org> Reviewed-by:
Prasad Vuppalapu <prasadv@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#606947}
-
Weidong Guo authored
This is a reland of 05e6d611 Original change's description: > Fix page slip issue after dragging > > Changes: > Update the selected page to be the target page of dragged item at the > end of dragging. > > Bug: 893832 > Change-Id: I91dcf8e03f62eab1597e3899bdbcafdad1fec2df > Reviewed-on: https://chromium-review.googlesource.com/c/1324851 > Commit-Queue: Weidong Guo <weidongg@chromium.org> > Reviewed-by: Alex Newcomer <newcomer@chromium.org> > Cr-Commit-Position: refs/heads/master@{#606585} Bug: 893832 Change-Id: I51c2d7d5d2a9a7ed4e752d71f3f6bee083ac84e0 Reviewed-on: https://chromium-review.googlesource.com/c/1329894Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Commit-Queue: Weidong Guo <weidongg@chromium.org> Cr-Commit-Position: refs/heads/master@{#606946}
-
Allen Bauer authored
Proper color is set by theme services using the color returned from COLOR_TAB_ALERT_CAPTURING. TBR=estade@chromium.org Bug: 870134 Change-Id: I23e153840ed10857054daa4c8ba97de8dcaae94c Reviewed-on: https://chromium-review.googlesource.com/c/1330065Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Allen Bauer <kylixrd@chromium.org> Cr-Commit-Position: refs/heads/master@{#606945}
-
Mason Freed authored
This test was made flaky by this CL: https://chromium-review.googlesource.com/c/chromium/src/+/1213864 TBR=masonfreed@chromium.org NOTRY=true Bug: 903019 Change-Id: Ifd936eb36d2a2731a66f391c54de5ec019963d5e Reviewed-on: https://chromium-review.googlesource.com/c/1330216Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#606944}
-
Thomas Guilbert authored
When flinging, we currently have 3 notifications show up. The notification surfaced from the Chrome MediaRouter offers a better path to control the media route directly, and the media session controls are redundant. This CL adds |is_flinging_| into UpdatePlayState's computations, in order to hide the MediaSession controller when using RemotePlayack. Bug: 790766 Change-Id: If1acd5eb845875cbc19f08b71b74e27aba048c50 Reviewed-on: https://chromium-review.googlesource.com/c/1327537Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#606943}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/f6ed3c5d..934bab09 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ib44db3e4d58ea958f082f39b104dda88e5439236 Reviewed-on: https://chromium-review.googlesource.com/c/1329886Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#606942}
-
Krishna Govind authored
R=kariah@chromium.org Change-Id: Id505548c23807e135477240e0ea82804e5ecfb78 Reviewed-on: https://chromium-review.googlesource.com/c/1330072Reviewed-by:
Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#606941}
-
Dominic Mazzoni authored
Previously we relied on Blink to correctly fill in the row and column index of every cell in a table. This tends to be expensive to do in Blink because it requires invalidating and reserializing the entire table if any cell changes. Instead, try to defer as much of those calculations to downstream to be computed when AT actually requests table attributes. This is more efficient, because Blink accessibility code needs to run any time the page is updated, like when a table is being built dynamically using JS - whereas AT typically only queries table attributes when users explore a table explicitly, so it makes sense to defer computation until then. This is also more accurate and less error-prone, as it allows us to completely validate the table in a single pass and fix any errors in table indexes. Finally, a potential added benefit is that this makes it easier to handle tables from Views or Arc++ that don't have all of the table attributes set, we can compute them automatically. A follow-up change will remove the code that computes some of these table attributes from Blink. Bug: 832289 Change-Id: I252a592c854e47cf6d6e5bd6b7c4bc5d51775e72 Reviewed-on: https://chromium-review.googlesource.com/c/1307840Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#606940}
-
ssid authored
Change-Id: I6cc93c62ca8c8d96929d3184f4b17b83d5371e63 Reviewed-on: https://chromium-review.googlesource.com/c/1330021Reviewed-by:
-
Jonathan Metzman authored
Chrome ClusterFuzz has support for Windows while OSS-Fuzz does not. Enable low hanging fruit that can easily be built in a Chromium build. Bug: 903632 Change-Id: I9b6c9bf883271d33135a4fea31a05be3d13648df Reviewed-on: https://chromium-review.googlesource.com/c/1328225Reviewed-by:
Mike Klein <mtklein@chromium.org> Commit-Queue: Jonathan Metzman <metzman@chromium.org> Cr-Commit-Position: refs/heads/master@{#606938}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/5fa11106b909..31d1c800f1a0 Created with: gclient setdep -r src-internal@31d1c800f1a0 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I994d668fe3a75e970e5fd0f684615bfd5e042d8b Reviewed-on: https://chromium-review.googlesource.com/c/1329983Reviewed-by:
-
