- 29 Feb, 2020 40 commits
-
-
Andrew Luo authored
Bug: 1049431 Test: python update_cts_test.py Change-Id: Ie99e692b094a01cbb1e2122f8865a9ad15efd44b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035063 Commit-Queue: Andrew Luo <aluo@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#745731}
-
Gabriel Charette authored
This CL is a logical no-op. It manually covers the use cases the script (https://crbug.com/1026641#c22) didn't cover in https://chromium-review.googlesource.com/c/chromium/src/+/2026350. A few of the affected files were also migrated to content::GetUIThreadTaskRunner() whenever surrounding code consistency was at stake (but the bulk of that migration is staged to happen after this one so this wasn't a priority in this batch). Most files intentionally kept base/task/post_task.h as an include. It is still required because of a cyclical dependency during the migration preventing base/task/thread_pool.h from implicitly providing base/task/task_traits.h to its users (callers that explicitly store TaskTraits and include task_traits.h don't have this problem). The post_task.h include will be cleaned up in a later phase. This CL was uploaded by git cl split. R=xiaohuic@chromium.org Bug: 1026641 Change-Id: I34e0294c917a1331449f2acbdbce7b13e7ad7a72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078425Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Auto-Submit: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#745730}
-
Nate Fischer authored
No change to logic. This moves GetAppPackageNameInternal into the shared component, reducing code duplication and making it an implementation detail of the class. Bug: 1015655 Test: run_components_unittests -f AndroidMetricsServiceClientTest.* Test: run_android_webview_unittests -f AwMetricsServiceClientTest.* Change-Id: I6612046d07dd75e781d9a5464a66ec8c0f16f625 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067657Reviewed-by:
Tobias Sargeant <tobiasjs@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#745729}
-
David Tseng authored
See go/unified-accessibility-component-extensions for additional details. This moves currently shared files from ChromeVox, Switch Access, and Select to Speak into the accessibility/common directory. Add a BUILD.gn file for it. accessibility/common will eventually also contain shared test resources; not done in this patch. Test: browser_tests Change-Id: Ib509413288be17872bdabb178866ee1de41fb670 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076209 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Anastasia Helfinstein <anastasi@google.com> Cr-Commit-Position: refs/heads/master@{#745728}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 7670cdb2. With Chromium commits locally applied on WPT: d5cd6b98 "SharedWorker: Assign unique names to SharedWorkers to avoid unintentional matching" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I30963250db4d5859626ef0603979f2dddc399ced Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2081071Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#745727}
-
Khushal authored
Be conservative when lowering down the refresh rate by waiting for a consistent state for at least 60 frames but immediately switch if the refresh rate should be increased. R=dcastagna@chromium.org Test: FrameRateDeciderTest.TogglesAfterMinNumOfFrames Bug: 976583 Change-Id: I9483357807e81a28966254e1d89418dd12f03f4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079264 Commit-Queue: Khushal <khushalsagar@chromium.org> Auto-Submit: Khushal <khushalsagar@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#745726}
-
Carlos IL authored
These histograms will be used to track the mixed image launch, so they're still needed for a few milestones. Bug: 1053149, 1053047, 1053046, 1053045, 1053044 Change-Id: I53e118264379fdb39162ad026c5ae7416454fd86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080781 Commit-Queue: Carlos IL <carlosil@chromium.org> Commit-Queue: Christopher Thompson <cthomp@chromium.org> Auto-Submit: Carlos IL <carlosil@chromium.org> Reviewed-by:
Christopher Thompson <cthomp@chromium.org> Cr-Commit-Position: refs/heads/master@{#745725}
-
Gabriel Charette authored
This CL is a logical no-op. It manually covers the use cases the script (https://crbug.com/1026641#c22) didn't cover in https://chromium-review.googlesource.com/c/chromium/src/+/2026350. A few of the affected files were also migrated to content::GetUIThreadTaskRunner() whenever surrounding code consistency was at stake (but the bulk of that migration is staged to happen after this one so this wasn't a priority in this batch). Most files intentionally kept base/task/post_task.h as an include. It is still required because of a cyclical dependency during the migration preventing base/task/thread_pool.h from implicitly providing base/task/task_traits.h to its users (callers that explicitly store TaskTraits and include task_traits.h don't have this problem). The post_task.h include will be cleaned up in a later phase. This CL was uploaded by git cl split. R=parastoog@google.com Bug: 1026641 Change-Id: I453fd810f52952b893ab9da89db9eee36f8ceeb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078667 Commit-Queue: Gabriel Charette <gab@chromium.org> Commit-Queue: Parastoo Geranmayeh <parastoog@google.com> Reviewed-by:
Parastoo Geranmayeh <parastoog@google.com> Auto-Submit: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#745724}
-
Tomasz Wiszkowski authored
This change updates the way SuggestionProcessors are built for AutocompleteMediator to allow the Mediator to be unit-tested. Bug: 1050813 Change-Id: Idb806c6ad108940add73ea7b16712376f8972561 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076006 Commit-Queue: Ender <ender@google.com> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Patrick Noland <pnoland@chromium.org> Cr-Commit-Position: refs/heads/master@{#745723}
-
Xiaohui Chen authored
Bug: 1054245 Change-Id: Ie330a0300a0659af1806d374c67ae1fb7c77ce2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080078Reviewed-by:
Ben Pastene <bpastene@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#745722}
-
Sahel Sharify authored
This cl postpones expiration of the following metrics by 1 year. PaymentRequest.Missing[Contacts|Shipping|Payment]Fields These metrics will be monitored before/during payment sheets UI changes. I also added web-payments-team as secondary owner for payments metrics Change-Id: I95a761fb0a045f437fa5feb155329e53b1f190cf Bug: 1050656 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2075964Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#745721}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/933525c2bdcf..ad5c586c30a6 git log 933525c2bdcf..ad5c586c30a6 --date=short --first-parent --format='%ad %ae %s' 2020-02-29 jalyn@microsoft.com Add telemetry for keyboard shortcuts Created with: gclient setdep -r src/third_party/devtools-frontend/src@ad5c586c30a6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:174309 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Id7df115ebb3a336d9317c9737ff0fe178921b919 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2081014Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#745720}
-
Toni Barzic authored
In active user session, shelf container has multiple widgets - navigation widget, hotseat widget, status area widget, shelf widget. Of these, shelf widget contains the shelf background, and its bounds intersect with all other widgets. For this reason, it's expected to be stacked at the bottom of the container. The shelf widget stacking is set up during widget creation. This works in active session state, as the shelf widget itself is not expected to be activated, and thus stacked at the top of the container. For login shelf, though, the shelf widget can get activated (it contains login shelf buttons, which can be focused, e.g. by tab traversal). Shelf widget being stacked above other windows in the container is not an issue on login/lock screen (login shelf widget does not interfere with the only other visible widget - status area widget), but when the session state changes, the shelf widget should ensure it gets restacked at the bottom again, so the shelf background does not get painted over other widgets. NOTE: This was not an issue before M-82, as shelf widget was in a separate window container. BUG=1051823 Change-Id: I65e34fc1347d20976cb5441da91e00efb96b0885 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2058998Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#745719}
-
Kuo-Hsin Yang authored
Move the available memory calculation from kernel to chrome. Use polling to check low memory condition instead of waiting for kernel low memory notification. BUG=b:149833548 TEST=run chromeos tast platform.MemoryStressBasic Change-Id: I2c21bddfc261727265c65420d143ad428501ca93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2058945 Commit-Queue: Kuo-Hsin Yang <vovoy@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Brian Geffon <bgeffon@chromium.org> Cr-Commit-Position: refs/heads/master@{#745718}
-
Shrek Shao authored
This reverts commit 5daa1294. Reason for revert: This seems to cause webgl-compressed-texture-astc.html?webglVersion=2 to fail Original change's description: > Fix compressed texture texStorage3D decompressed formats and types > > TextureManager::ExtractTypeFromStorageFormat returned type=0 for compressed > texture formats, and that is passed into texture_manager()->SetLevelInfo > thus ends up with INVALID_ENUM at glTexSubImage3DFn > > Bug: 1051217, 1056845 > Change-Id: Ia3f9e455a02a97aaef4f1de1e526d0c01963c2d9 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070827 > Reviewed-by: Kenneth Russell <kbr@chromium.org> > Commit-Queue: Shrek Shao <shrekshao@google.com> > Cr-Commit-Position: refs/heads/master@{#745321} TBR=kbr@chromium.org,shrekshao@google.com,lexa.knyazev@gmail.com Change-Id: Icd609083cec2f57e06558de0c2db4d1d27c73e15 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1051217, 1056845 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2081354Reviewed-by:
Shrek Shao <shrekshao@google.com> Commit-Queue: Shrek Shao <shrekshao@google.com> Cr-Commit-Position: refs/heads/master@{#745717}
-
Victor Fei authored
Consider the following web content where an ordered set item is nested in a list item: <ul role="tablist"> <li> <div role="tab" aria-posinset="3" aria-setsize="5"> item 3 of 5 </div> </li> <li> <div role="tab" aria-posinset="4" aria-setsize="5"> item 4 of 5 </div> </li> <li> <div role="tab" aria-posinset="5" aria-setsize="5"> item 5 of 5 </div> </li> </ul> We currently would get PosInSet=0 and SetSize=0 for the tab item in accessibility tree. The reason we are not getting PosInSet and SetSize value is because AXTree::RecursivelyPopulateOrderedSetItems is not recursing pass the list item element to add tree item to the ordered set for calculating PosInSet and SetSize. This change fixes this issue by allowing AXTree::RecursivelyPopulateOrderedSetItems to recurse through these parent elements and adding set items to ordered set, thereby giving correct calculation for PosInSet and SetSize. Bug: 1047025 Change-Id: Ieaf31db1e0b70c84923e2b10e5ba4413ba413696 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029189 Commit-Queue: Victor Fei <vicfei@microsoft.com> Reviewed-by:Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Ian Prest <iapres@microsoft.com> Reviewed-by:
Akihiro Ota <akihiroota@chromium.org> Cr-Commit-Position: refs/heads/master@{#745716}
-
Toni Barzic authored
Sets up login shelf gesture handler when marketing opt in screen is shown, which enables swipe gesture from the login shelf (and shows a shelf drag handle). Swipe handler will exit the screen. The handler is set up only if shelf navigation buttons would be hidden in the current environment - if tablet mode is on, and the buttons are not shown for accessibility. When the swipe is enabled, the screen's next button is hidden. While here, add LoginScreenBehavior to marketing opt in screen polymer element. BUG=976949 Change-Id: Idcc2828f21c85162be29c5e4706ea3281f1b6bbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080008Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#745715}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/7122d8cec827..b6ba6c0a2b36 git log 7122d8cec827..b6ba6c0a2b36 --date=short --first-parent --format='%ad %ae %s' 2020-02-28 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2020-02-28 benjaminwagner@google.com [infra] Upgrade iPhone7, iPhone8, and iPadPro to iOS 13.3.1. 2020-02-28 mtklein@google.com leak llvmcontexts for now 2020-02-28 herb@google.com SkVM implement min max 2020-02-28 mtklein@google.com bytes! Created with: gclient setdep -r src/third_party/skia@b6ba6c0a2b36 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jlavrova@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: jlavrova@google.com Change-Id: I284ceefa2c4f927ca8cc3a87d867f02a29aa1b9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2081013Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/2d7b0de1..5260234d Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ic0689f75518db74425cb41ad2da5cd6eeef22bd1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080972Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#745713}
-
Luke Zielinski authored
This includes flaky tests (multiple possible statuses) and subtest failures (where test status is OK but subtests have failures). This CL will turn off the WPTOutputUpdater post-processing step. All expectations and baselines will be handled by WPTMetadataBuilder. WPTOverrideExpectations is also updated with many new entries that were previously handled by WPTOutputUpdater. Bug: 937369 Change-Id: Ibb4081c76ec72b7660af30291aa43a48e2f6ddce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072639 Commit-Queue: Luke Z <lpz@chromium.org> Reviewed-by:
Aaron Gable <agable@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#745712}
-
Ahmed Mehfooz authored
Bug: 1056451 Change-Id: Ie624e1c5256da34bc99f6019ac70b14d5f5c3d26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079545Reviewed-by:
Tim Song <tengs@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Cr-Commit-Position: refs/heads/master@{#745711}
-
Nnamdi Theodore Johnson-Kanu authored
This CL moves chromeOS strings for settings google assistant page from settings_strings.grdp to os_settings_strings.grdp. It continues the process of moving all chromeOS specific strings. Bug: 967883 Change-Id: Id342dd26091b207f2da72b89fe879bc9448b6995 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067256 Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#745710}
-
Tao Bai authored
Bug: 1043703 Change-Id: I3feb3049687697d4ab0f56cbd58c4967ebf74745 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070963Reviewed-by:
-
Anastasia Helfinstein authored
This is the a step towards incorporating Sophie and Rose's code from last summer into the new navigation paradigm. Bug: 982004 Change-Id: Ic554562ad9ac1d887e682097450e9c0ade5e9a4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076441 Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Reviewed-by:
-
Carlos IL authored
The flag was previously removed, but the metadata was left behind. Change-Id: Ia2445a0858895a5921364e7fd6f78543570b7f17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080786 Auto-Submit: Carlos IL <carlosil@chromium.org> Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#745707}
-
Gabriel Charette authored
This CL is a logical no-op. It manually covers the use cases the script (https://crbug.com/1026641#c22) didn't cover in https://chromium-review.googlesource.com/c/chromium/src/+/2026350. A few of the affected files were also migrated to content::GetUIThreadTaskRunner() whenever surrounding code consistency was at stake (but the bulk of that migration is staged to happen after this one so this wasn't a priority in this batch). Most files intentionally kept base/task/post_task.h as an include. It is still required because of a cyclical dependency during the migration preventing base/task/thread_pool.h from implicitly providing base/task/task_traits.h to its users (callers that explicitly store TaskTraits and include task_traits.h don't have this problem). The post_task.h include will be cleaned up in a later phase. This CL was uploaded by git cl split. R=blundell@chromium.org Bug: 1026641 Change-Id: I7cf7c1eb644c733cd3bf43c53dc7f73444193b9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079080 Commit-Queue: Gabriel Charette <gab@chromium.org> Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#745706}
-
Hazem Ashmawy authored
- Add build fingerprint instead of device and populate it. - Add Android API level and populate it. - Populate Application name, package name and version. - Use WebView package name instead of package label name. - Remove instructions on how to get app link on the playstore to shorten the template length following the limits on the URL query length. - Add a new line to the template to guide the user to share additional comments on the crash. - Use the "description" query name instead of "comment" in the constructed URL following monorail deep links documentation[1]. [1] https://chromium.googlesource.com/infra/infra/+/master/appengine/monorail/doc/userguide/power-users.md#deep-links Fixed: 991594 Test: Press the report bug button and make sure the template is correctly populated Test: Make sure that monorail directs to the template after log-in from the first time Change-Id: Ie9296267915b12a5c940c625bd77bdab5647409a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2074880 Commit-Queue: Hazem Ashmawy <hazems@chromium.org> Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Ie3e14e9b5a240c76b8fba6fe4428d7b54c9f0835 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2081016Reviewed-by:
-
Anastasia Helfinstein authored
Groups static/instance methods and alphabetizes within the groupings. This change reorders functions and removes unused functions, but has no behavioral change. Bug: 982004 Change-Id: I043cde848aacf1d11e788871fda0baf9d301ebd5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076083 Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Reviewed-by:
Chris Hall <chrishall@chromium.org> Cr-Commit-Position: refs/heads/master@{#745703}
-
John Budorick authored
Tasks currently occasionally wind up running on arm xenial hosts, which unsurprisingly fails when it happens. Bug: 1040699 Change-Id: I79db1058cca0643ef9f65f06848ff535d950734a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080087 Commit-Queue: John Budorick <jbudorick@chromium.org> Reviewed-by:
Andrew Luo <aluo@chromium.org> Cr-Commit-Position: refs/heads/master@{#745702}
-
Jun Mukai authored
During the debug, I've just come to realize that the shield layer of the wallpaper view is zero-sized; so it does not make any visual effects. It needs to set bounds on creation. Bug: 1036804 Test: manually Change-Id: Ifa2dea70424355db12741f7d4bf41b8b3ce8bffa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080885Reviewed-by:
-
rbpotter authored
Autogenerate JS module version of search_settings.js and its test, in preparation for migrating basic_page/* to Polymer 3. Bug: 1026426 Change-Id: I2ec9498dffd3839947f2a365a7200036f781cf8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079901 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#745700}
-
Lily Chen authored
This makes it easier to debug cookie issues, as the SameSite cookie context is calculated based on these two parameters. Bug: None Change-Id: I05bf03533fb1a481fc71a610971da9f8e40de2f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068580 Commit-Queue: Lily Chen <chlily@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#745699}
-
Gabriel Charette authored
This CL is a logical no-op. It manually covers the use cases the script (https://crbug.com/1026641#c22) didn't cover in https://chromium-review.googlesource.com/c/chromium/src/+/2026350. A few of the affected files were also migrated to content::GetUIThreadTaskRunner() whenever surrounding code consistency was at stake (but the bulk of that migration is staged to happen after this one so this wasn't a priority in this batch). Most files intentionally kept base/task/post_task.h as an include. It is still required because of a cyclical dependency during the migration preventing base/task/thread_pool.h from implicitly providing base/task/task_traits.h to its users (callers that explicitly store TaskTraits and include task_traits.h don't have this problem). The post_task.h include will be cleaned up in a later phase. This CL was uploaded by git cl split. R=boliu@chromium.org Bug: 1026641 Change-Id: I444e19558bbb66741294e1b7035fc1897062906e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078659Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Auto-Submit: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#745698}
-
Li Lin authored
In some cases (clicking on top of the screen in full screen mode), there are not enough space to show Quick Answers view above the context menu. We would like to show it below the context menu instead. Mock at: go/quick-answers (slide 20). This CL also update the hover background color to match the context menu item hover background color. Bug: b/150388694 Change-Id: I281d091ecb8f8b039cda902c331f92db61fbaa4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079044 Commit-Queue: Li Lin <llin@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/953278adbf3e..55ab41d1856d git log 953278adbf3e..55ab41d1856d --date=short --first-parent --format='%ad %ae %s' 2020-02-28 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2020-02-28 ehmaldonado@google.com depot_tools: Make it possible to run custom git scripts using Python 3. 2020-02-28 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@55ab41d1856d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:984182 Tbr: agable@chromium.org Change-Id: I80b6cd4826d9f322523465673f56b6616207a7da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080991Reviewed-by:
-
Yulun Wu authored
Other changes: Add test methods to drag_handle class Modified shelf_widget GetDragHandle() to return DragHandle* instead of View* Modified DragHandle::ShowDragHandleNudge() to fetch timeout for current pref instead of taking it as an argument. Fixed bug where ShowDraghandleNudge did not call handleNudgeShown. Revert "Revert "Add unit tests for drag handle nudge."" This reverts commit 4b6df1eb. Bug: 1034168 Change-Id: I73258ce83cd681a936fec907b04ef065b6d10592 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080558Reviewed-by:
Manu Cornet <manucornet@chromium.org> Commit-Queue: Yulun Wu <yulunwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#745695}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/fb551728d77b..54bc3dab2064 git log fb551728d77b..54bc3dab2064 --date=short --first-parent --format='%ad %ae %s' 2020-02-28 geofflang@google.com Add the ANGLE Android developer options to the ANGLE repository. 2020-02-28 xiaoxuan.liu@arm.com Vulkan: Add robust init for NULL texture image. 2020-02-28 b.schade@samsung.com Add Android boot animation and rounding error test Created with: gclient setdep -r src/third_party/angle@54bc3dab2064 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: geofflang@google.com Change-Id: I6aafa12c1906e41bff26255e6cfa7f781967f76a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080730Reviewed-by:
-
Pavel Yatsuk authored
This CL moves InfoBarControlLayout, InfoBarMessageView, tests and related resources to chrome/browser/ui/messages BUG=1056346 R=mdjones@chromium.org Change-Id: I2d24ae99bcbe2186486154c883288eb6ddecb50a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076398 Commit-Queue: Pavel Yatsuk <pavely@chromium.org> Reviewed-by:
Jun Cai <juncai@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#745693}
-
Brian Sheedy authored
Disables BrowserMinidumpTest on Linux since there are unexpected crashes occurring either in the test or in previous tests which are causing it to fail. TBR=crouleau@chromium.org Bug: 1056235 Change-Id: I7d03de0f09df52c2ab6cb3f45809a71357500650 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080080Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#745692}
-
