GitLab

Use android_dbg_tests_recipe for manual try jobs instead of android_dbg & android_dbg_triggered_tests since that's what the CQ uses now.

BUG=403411
NOTRY=true

Review URL: https://codereview.chromium.org/496873002

Cr-Commit-Position: refs/heads/master@{#291520}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291520 0039d316-1c4b-4281-b951-d872f2087c98

NOTRY=true
NOTREECHECKS=true

Review URL: https://codereview.chromium.org/497853002

Cr-Commit-Position: refs/heads/master@{#291519}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291519 0039d316-1c4b-4281-b951-d872f2087c98

Fixed a regression introduced in cl 488163003. Manual navigation, e.g. typing
url or clicking bookmark, is not considered user gesture. Thus with the cl
488163003, chrome will ignore x-chrome-manage-account header on manual
navigation to gaia endpoints. We should honor header on both non web
triggerable transitions and web triggerable transitions with user gesture.

BUG=394869

Review URL: https://codereview.chromium.org/481053003

Cr-Commit-Position: refs/heads/master@{#291518}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291518 0039d316-1c4b-4281-b951-d872f2087c98

BUG=405871

Review URL: https://codereview.chromium.org/495403002

Cr-Commit-Position: refs/heads/master@{#291517}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291517 0039d316-1c4b-4281-b951-d872f2087c98

Cr-Commit-Position: refs/heads/master@{#291516}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291516 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=180784:180790&mode=html
TBR=wibling@chromium.org,gavinp@chromium.org
BUG=

Review URL: https://codereview.chromium.org/502613002

Cr-Commit-Position: refs/heads/master@{#291515}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291515 0039d316-1c4b-4281-b951-d872f2087c98

We don't have any.  We should.  Add some! :)
BUG=391280

Review URL: https://codereview.chromium.org/469973005

Cr-Commit-Position: refs/heads/master@{#291514}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291514 0039d316-1c4b-4281-b951-d872f2087c98

Otherwise, Windows Release incremental links fail with:

dom_distiller_core.distilled_page_prefs.obj : error LNK2019: unresolved external symbol "public: void __thiscall user_prefs::PrefRegistrySyncable::RegisterIntegerPref(char const *,int,enum user_prefs::PrefRegistrySyncable::PrefSyncStatus)" (?RegisterIntegerPref@PrefRegistrySyncable@user_prefs@@QAEXPBDHW4PrefSyncStatus@12@@Z) referenced in function "public: static void __cdecl dom_distiller::DistilledPagePrefs::RegisterProfilePrefs(class user_prefs::PrefRegistrySyncable *)" (?RegisterProfilePrefs@DistilledPagePrefs@dom_distiller@@SAXPAVPrefRegistrySyncable@user_prefs@@@Z)

R=nyquist@chromium.org
BUG=404809

Review URL: https://codereview.chromium.org/496323003

Cr-Commit-Position: refs/heads/master@{#291513}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291513 0039d316-1c4b-4281-b951-d872f2087c98

Server nudge delays override the local ones, but must be longer than the
default nudge delay. If set to 0, will reset the nudge to the default.

To accomplish this the delay logic was refactored and moved into the sync
scheduler, which is now aware of all delays for all types and sync cycles.

BUG=401600

Review URL: https://codereview.chromium.org/488843002

Cr-Commit-Position: refs/heads/master@{#291512}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291512 0039d316-1c4b-4281-b951-d872f2087c98

- make Print button blue and move it in front of Cancel
- change 'Backround images and colors' to 'Backround graphics'
- remove lines between options and reduce spacing
- add 'More/less options' button and make non-essential sections collapsible

BUG=397741

Review URL: https://codereview.chromium.org/477133004

Cr-Commit-Position: refs/heads/master@{#291511}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291511 0039d316-1c4b-4281-b951-d872f2087c98

Since the classes have virtual functions.

BUG=none

Review URL: https://codereview.chromium.org/497213002

Cr-Commit-Position: refs/heads/master@{#291510}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291510 0039d316-1c4b-4281-b951-d872f2087c98

This is necessary to switch app shell / chrome implementation.

BUG=397167
TEST= no functional change.
R=mukai@chromium.org, yoz@chromium.org

Review URL: https://codereview.chromium.org/487843003

Cr-Commit-Position: refs/heads/master@{#291509}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291509 0039d316-1c4b-4281-b951-d872f2087c98

Since we are changing where page actions will show up, it makes sense to not
rely on PageActionController (which is attached to the location bar) to clear
the page action values. Since we also have to clear browser action values, it
makes sense to combine these in the ExtensionActionAPI.

Cherries on top:
- Remove a duplicate histogram
- Make ExtensionActionManager::Get() use a BrowserContext

TBR=avi@chromium.org (cocoa - add profile.h to use a profile as a browser context)

BUG=397259

Review URL: https://codereview.chromium.org/482993003

Cr-Commit-Position: refs/heads/master@{#291508}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291508 0039d316-1c4b-4281-b951-d872f2087c98

Show the clock error page when the clock is too far in the future as well as
too far in the past.

Do not show text suggesting the user can fix it by reloading later; the
clock is definitely wrong and reloading won't help.

BUG=349653

Review URL: https://codereview.chromium.org/416403006

Cr-Commit-Position: refs/heads/master@{#291507}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291507 0039d316-1c4b-4281-b951-d872f2087c98

Also a speculative fix for an Android crash report.

BUG=406048
TEST=Open NTP with --site-per-process.

Review URL: https://codereview.chromium.org/496283006

Cr-Commit-Position: refs/heads/master@{#291506}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291506 0039d316-1c4b-4281-b951-d872f2087c98

NOTRY=true for comment only change.
BUG=None
Test=None, internal only change.

Review URL: https://codereview.chromium.org/493283002

Cr-Commit-Position: refs/heads/master@{#291505}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291505 0039d316-1c4b-4281-b951-d872f2087c98

Debug builds would hit a DCHECK(), but release builds would overflow
the int64 when manipulating kInfiniteDuration according to position.

Trying to estimate based on bytes when the duration is infinite is
just plain wrong, so skip estimation in that case. The buffered ranges
will now only update according to what FFmpegDemuxer/ChunkDemuxer
report in the infinite duration case.

BUG=400442
TEST=New layout test https://codereview.chromium.org/499513002/

Review URL: https://codereview.chromium.org/435303004

Cr-Commit-Position: refs/heads/master@{#291504}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291504 0039d316-1c4b-4281-b951-d872f2087c98

BUG=406574
TBR=wfh@chromium.org

Review URL: https://codereview.chromium.org/475173006

Cr-Commit-Position: refs/heads/master@{#291503}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291503 0039d316-1c4b-4281-b951-d872f2087c98

BUG=405686

Review URL: https://codereview.chromium.org/501513003

Cr-Commit-Position: refs/heads/master@{#291500}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291500 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Omnibox: Make URLs of Bookmarks Searchable (patchset #2 of https://codereview.chromium.org/489373005/)

Reason for revert:
Broke interactive_ui_tests on mac: https://build.chromium.org/p/chromium.mac/builders/Mac%2010.6%20Tests%20(dbg)(1)/builds/52199

Original issue's description:
> Omnibox: Make URLs of Bookmarks Searchable
> 
> This used to be controlled by a field trial created in
> https://codereview.chromium.org/184663002
> 
> After evaluating this change, we've decided to launch it.
> This change turns the flag on by default and removes the field trial code.
> It also removes the index_urls_ parameters everywhere because those will
> always be true forevermore.
> 
> I tested this interactively.
> Also, all the unit tests still apparently pass.  And yes some of these do
> exercise this feature.
> 
> TBR=joaodasilva
> (for trivial change to components/policy/core/browser/managed_bookmarks_tracker_unittest.cc )
> 
> BUG=157204,378854
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291445

TBR=pkasting@google.com,sky@chromium.org,pkasting@chromium.org,mpearson@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=157204,378854

Review URL: https://codereview.chromium.org/485483003

Cr-Commit-Position: refs/heads/master@{#291496}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291496 0039d316-1c4b-4281-b951-d872f2087c98

BUG=406406
R=zea@chromium.org

Review URL: https://codereview.chromium.org/497123002

Cr-Commit-Position: refs/heads/master@{#291494}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291494 0039d316-1c4b-4281-b951-d872f2087c98

This change also checks for another credential error message if gsutil commands were
run before 'gsutil config'.

BUG=399029
NOTRY=True

Review URL: https://codereview.chromium.org/497823003

Cr-Commit-Position: refs/heads/master@{#291492}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291492 0039d316-1c4b-4281-b951-d872f2087c98

As part of making component_updater a component, we are now moving over all the tests.

Before we do that, we're copying the test data over. We are deleting it from the original spot in a separate CL.

This patch will need to be dcommitted, since component1.dll file is executable bit, and CQ chokes on that.

Review of this change is here: https://codereview.chromium.org/497803002/

BUG=371463
R=waffles@chromium.org

Review URL: https://codereview.chromium.org/499633002

Cr-Commit-Position: refs/heads/master@{#291490}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291490 0039d316-1c4b-4281-b951-d872f2087c98

BUG=377978

Review URL: https://codereview.chromium.org/495853002

Cr-Commit-Position: refs/heads/master@{#291489}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291489 0039d316-1c4b-4281-b951-d872f2087c98

https://codereview.chromium.org/475543003/diff/160001/chrome/browser/resources/extensions/extension_list.js#newcode198

BUG=386842

Review URL: https://codereview.chromium.org/491703003

Cr-Commit-Position: refs/heads/master@{#291488}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291488 0039d316-1c4b-4281-b951-d872f2087c98

Now that its expected that extensions will be modifying bookmarks, we should
attempt to coalesce more of their writes into a single sync cycle.

BUG=401600

Review URL: https://codereview.chromium.org/478853003

Cr-Commit-Position: refs/heads/master@{#291486}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291486 0039d316-1c4b-4281-b951-d872f2087c98

Collapse fileapi, webkit_blob, webkit_database, quota, and webkit_common namespaces into single storage namespace

As discussed here:
https://groups.google.com/a/chromium.org/forum/#!topic/storage-dev/aQall8GOrS4

BUG=338338
TBR=cevans
NOTRY=true

Review URL: https://codereview.chromium.org/492873002

Cr-Commit-Position: refs/heads/master@{#291485}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291485 0039d316-1c4b-4281-b951-d872f2087c98

Previously, if a raster task had a resource size that was larger than
the throttling limit for the raster worker, that task would never get
scheduled.  This leads to starvation for that task, preventing tree
activation, and causing freezes.

The fix is to always allow such large tasks if it is the first task.

R=reveman@chromium.org
BUG=403446

Review URL: https://codereview.chromium.org/489293002

Cr-Commit-Position: refs/heads/master@{#291484}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291484 0039d316-1c4b-4281-b951-d872f2087c98

Adds os_exchange_data_win_unittest.cc to Windows (it was incorrecly excluded before). Fixed a compilation error in that file.

Reland of 291154

R=sky@chromium.org

Review URL: https://codereview.chromium.org/488173003

Cr-Commit-Position: refs/heads/master@{#291483}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291483 0039d316-1c4b-4281-b951-d872f2087c98

On some linux distributions, the DISTRIB_RELEASE field of
/etc/lsb-release cannot be parsed as a float. In that case, consider it
will be 0

R=
BUG=393022

Review URL: https://codereview.chromium.org/381293003

Cr-Commit-Position: refs/heads/master@{#291481}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291481 0039d316-1c4b-4281-b951-d872f2087c98

This change uses a NaCl embedder interface for getting the exit status inside
the loader process instead of receiving that information over SRPC.

The IPC message introduced here must be synchronous so that we're guaranteed to
report the exit status before the loader process exits.

BUG=397161
TEST=NaClBrowserTest.ExitStatus*
R=dmichael@chromium.org, jschuh@chromium.org, mseaborn@chromium.org

Review URL: https://codereview.chromium.org/484783002

Cr-Commit-Position: refs/heads/master@{#291480}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291480 0039d316-1c4b-4281-b951-d872f2087c98

The details toggle only happens when you actually click the button now,
and it no longer resizes columns and modifies the page when expanded.
Instead, the details column takes over the whole row, so its easier to
view and select text.

R=rlarocque@chromium.org
TBR=bauerb@chromium.org
BUG=401323

Review URL: https://codereview.chromium.org/454573002

Cr-Commit-Position: refs/heads/master@{#291478}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291478 0039d316-1c4b-4281-b951-d872f2087c98

BUG=380889
R=vmpstr

Review URL: https://codereview.chromium.org/470803007

Cr-Commit-Position: refs/heads/master@{#291477}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291477 0039d316-1c4b-4281-b951-d872f2087c98

BUG=395376

Review URL: https://codereview.chromium.org/501513002

Cr-Commit-Position: refs/heads/master@{#291476}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291476 0039d316-1c4b-4281-b951-d872f2087c98

Cr-Commit-Position: refs/heads/master@{#291474}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291474 0039d316-1c4b-4281-b951-d872f2087c98

Try jobs run in https://codereview.chromium.org/501483002/

TBR=hellner@chromium.org
BUG=

Review URL: https://codereview.chromium.org/502563002

Cr-Commit-Position: refs/heads/master@{#291473}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291473 0039d316-1c4b-4281-b951-d872f2087c98

TBR=szager@chromium.org
NOTRY=True
BUG=406454

Review URL: https://codereview.chromium.org/503453002

Cr-Commit-Position: refs/heads/master@{#291472}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291472 0039d316-1c4b-4281-b951-d872f2087c98

chrome://downloads.

R=benjhayden@chromium.org
BUG=none
TEST=browser_tests

Review URL: https://codereview.chromium.org/492323003

Cr-Commit-Position: refs/heads/master@{#291471}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291471 0039d316-1c4b-4281-b951-d872f2087c98

As part of making component_updater a component, we are now moving over all the tests.

Before we do that, we're copying the test data over. We are deleting it from the original spot in a separate CL.

BUG=371463

Review URL: https://codereview.chromium.org/497803002

Cr-Commit-Position: refs/heads/master@{#291470}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291470 0039d316-1c4b-4281-b951-d872f2087c98

When a directory substitution in a toolchain definition expands to the empty
string (i.e. it's the same as the root build directory), expand the name to "."
instead of the empty string to avoid corrupting filenames.

For example, if you specified "{{target_out_dir}}/foo" without this it would
expand to "/foo" for the default toolchain.

This removes the previous special-case hack for this case. That code only
worked when the entire string expanded to the filename (when the directory was
at the beginning of the string). When generating command lines, the directories
will be in the middle of the string and the previous special case didn't catch
them.

R=jamesr@chromium.org

Review URL: https://codereview.chromium.org/497193002

Cr-Commit-Position: refs/heads/master@{#291469}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291469 0039d316-1c4b-4281-b951-d872f2087c98