- 08 Nov, 2019 40 commits
-
-
Mugdha Lakhani authored
Because some of our bots don't have play services up to date, this disables the version check for the same from Background Sync code and attempts to re-enable Background Sync integration tests. Bug: 996664 Change-Id: I1f2081c16143873e10baf35a8d340174f96f6590 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893207Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Mugdha Lakhani <nator@chromium.org> Cr-Commit-Position: refs/heads/master@{#713789}
-
Sylvain Defresne authored
CRWMockWebStateDelegate did not forward any message to the represented object passed in its constructor, nor was used with any OCMock methods to expect/stub/reject invocation. Since it is a fake implementation of CRWWebStateDelegate and can subclass NSObject. Rename the class since it is not a mock. Bug: none Change-Id: I225cbc0da44f406060ea040108c6c735ca6cac94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903140 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#713788}
-
Juan Antonio Navarro Perez authored
Should now use "unmangled" story names, and no need for tir (or grouping) label. Bug: 1022349 Change-Id: I64cc2c17f1914afa8a0ff63f99972a5840385410 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903133 Auto-Submit: Juan Antonio Navarro Pérez <perezju@chromium.org> Reviewed-by:
Mikhail Khokhlov <khokhlov@google.com> Commit-Queue: Mikhail Khokhlov <khokhlov@google.com> Cr-Commit-Position: refs/heads/master@{#713787}
-
Dominik Röttsches authored
https://chromium.googlesource.com/external/github.com/harfbuzz/harfbuzz.git/+log/e637a4b3de2f..7cde68f10cdf Roll for fixing kerning in GillSans, which is an AAT font with a morx, GPOS and kern table. Apparently, kern needs to be applied, see HarfBuzz issue: https://github.com/harfbuzz/harfbuzz/issues/1982 $ git log e637a4b3d..7cde68f10 --date=short --no-merges --format='%ad %ae %s' 2019-11-02 ebrahim [ci] install pip in fedora bot 2019-11-02 ebrahim [ci] fix fedora bot 2019-09-23 ebrahim [serialize] Extract iterable copy, copy_all 2019-10-31 behdad Minor 2019-10-31 behdad If applying morx, apply kern table even if GPOS is present and has kern 2019-10-29 behdad 2.6.4 2019-10-29 ebrahim Add in_range in hb_bytes_t to merge range_checker_t with it 2019-10-29 ebrahim [ci] Check the recipt introduce in 7152ac3 2019-10-29 ebrahim [glyf] Use contour_bounds_t::empty to simplify get_extents logic 2019-10-29 ebrahim [glyf] Refactor contour_bounds_t use to make its fields protected 2019-10-29 ebrahim Remove contour_point_t so we won't need to zero its unused var 2019-10-29 jfkthame Use proper y-scale factor for height value 2019-10-28 behdad Fix build 2019-10-29 khaledhosny [cmap] Check GID before adding ranges in format 4 & 12 2019-10-28 behdad Hopefully fix up previous commit and bots 2019-10-28 behdad [config] Make HB_NO_ERRNO work with systems defining errno as a macro 2019-10-28 behdad 2.6.3 2019-10-28 behdad Actually add +hb_font_get_nominal_glyphs() 2019-10-28 behdad Revert "Don't include codepoint 0 in the results of collect_unicodes." 2019-10-28 grieger Don't include codepoint 0 in the results of collect_unicodes. It is always assumed to be the notdef glyph. 2019-10-22 ebrahim [gpos] Don't move pointer when match_glyph_data is not set 2019-10-25 qxliu crash fix : Heap-buffer-overflow READ 2 https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=18513 2019-10-24 qxliu fuzzer crash fix https://oss-fuzz.com/testcase-detail/5643107869917184 2019-10-24 ebrahim [ci] Use custom subset fuzzer timeout for failing sanitizer bots 2019-10-23 ebrahim [ci] Add HB_NO_MT on non HB_TINY no-build-system builds 2019-10-22 behdad Remove hb-warning.cc 2019-10-21 grieger Add a specialization of array_t:hash for hb_bytes_t and hb_ubytes_t. 2019-10-21 grieger Optimize intersects_array to fix fuzzer timeout. 2019-10-22 grieger Store the hash value of a key in item_t in hb_map to reduce the number of hash computations. 2019-10-21 qxliu fuzzer crash fix: Null-dereference WRITE https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=18363 2019-09-27 grieger Added profiling instructions to TESTING.md 2019-09-17 qxliu [subset] GPOS Lookup Type 2: PairPos 2019-10-21 ebrahim [fuzz] Add https://crbug.com/oss-fuzz/17898 testcase 2019-09-30 qxliu [subset] GSUB Lookup Type 6: ChainContextSubst 2019-10-16 grieger Add missing pop() for the failure case of script subsetting. 2019-10-02 grieger Rewrite hash and == function for hb_array_t as a plain loop. 2019-10-01 grieger Enforce HB_MAX_LANGSYS limit during layout subsetting. 2019-10-01 grieger Enforce HB_MAX_SCRIPTS during subsetting of the script table. 2019-10-09 behdad [buffer] Minor; improve HB_NO_BUFFER_MESSAGE 2019-10-16 ebrahim [doc] minor 2019-10-12 ebrahim [glyf] Use range_checker_t in composite_iter_t 2019-10-12 ebrahim [glyf] minor 2019-10-12 ebrahim [glyf] other cleanups 2019-10-12 ebrahim [glyf] Introduce glyf::Glyph, a hb_bytes_t/GlyphHeader pair 2019-10-12 ebrahim [glyf] minor 2019-10-12 ebrahim [glyf] Move get_contour_points to GlyphHeader 2019-10-10 bungeman Document hb_feature_t. Created with: roll-dep src/third_party/harfbuzz-ng/src R=bashi@chromium.org,behdad@chromium.org,bungeman@chromium.org,drott@chromium.org,eae@chromium.org,jshin@chromium.org Bug: 1004945 Change-Id: I1ac3540fe678bc0cbd7c1b9b14efb88c6ed5b587 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895350 Commit-Queue: Dominik Röttsches <drott@chromium.org> Reviewed-by:
Ben Wagner <bungeman@chromium.org> Cr-Commit-Position: refs/heads/master@{#713786}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/ae1f25fee85e..16787735601c git log ae1f25fee85e..16787735601c --date=short --no-merges --format='%ad %ae %s' 2019-11-08 jiawei.shao@intel.com Add vulkan-headers and vulkan-validation-layers to .gitignore Created with: gclient setdep -r src/third_party/dawn@16787735601c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel TBR=cwallez@google.com Bug: None Change-Id: I15f63d42456175c2bdda583a5b08f2658ee0d67a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1905280Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#713785}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/dc59b4b075e9..041f0a02493d git log dc59b4b075e9..041f0a02493d --date=short --no-merges --format='%ad %ae %s' 2019-11-07 afdx@google.com spirv-fuzz: simplify transformation for replacing an id with a synonym (#3020) 2019-11-07 alanbaker@google.com Re-enable OpReadClockKHR validation (#3013) 2019-11-07 dneto@google.com Python 3: remove deprecated U qualifier on 'open' (#3019) 2019-11-07 paulthomson@users.noreply.github.com Remove semicolon (#3022) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@041f0a02493d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 TBR=radial-bots+chrome-roll@google.com,jonahr@google.com Bug: None Change-Id: I7d66db1ec346d02ddbd638b0fc4d01394bdeef82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1905278Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#713784}
-
Rune Lillesveen authored
We allow getComputedStyle() for elements which are connected but outside the flat tree. That is, unassigned shadow host children or any of their descendants. As part of doing flat tree style recalc, we will skip traversing into these unassigned elements which means we have to clear their computed styles if any of the flat tree ancestors are dirty. Ideally, we would like to return empty styles for the elements outside the flat tree, which the csswg has resolved[1], but Firefox also still returns computed style in that case and there might be compat issues with removing that as well. With FlatTreeStyleRecalc enabled, we don't clear the enforced styles outside the flat tree in UpdateStyle(), so we have to make sure we clear ComputedStyle for elements which have been dirtied since the last time we did getComputedStyle on such elements. TEST=shadow-dom/v0/closed-mode-deep-combinator-and-shadow-pseudo.html TEST=fast/alignment/parse-alignment-of-root-elements.html TEST=fast/dom/custom/define-with-default-style.html [1] https://github.com/w3c/csswg-drafts/issues/1964#issuecomment-402387065 Bug: 972752 Change-Id: If0f10947263eb8e417fd7a87fc77ef5ea5ea47bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900991 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#713783}
-
Anatoliy Potapchuk authored
There was a comment in a previous CL I forgot to address - fixing it now. Bug: 1015383,1006230 Change-Id: Ia54ea6a21d81d5fc24f180b9d39a9d182d5ee900 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903137Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org> Cr-Commit-Position: refs/heads/master@{#713782}
-
Takashi Sakamoto authored
This reverts commit 241a69f6. Reason for revert: suspect causing browser_tests and content_browsertests failures on Linux CFI bot. Sample build: https://ci.chromium.org/p/chromium/builders/ci/Linux%20CFI/15556 browser_tests failed because of: PDFExtensionAccessibilityTreeDumpTest.HelloWorld/linux PDFExtensionAccessibilityTreeDumpTest.TextStyle/blink PDFExtensionAccessibilityTreeDumpTest.TextDirection/blink PDFExtensionAccessibilityTreeDumpTest.LinksImagesAndText/linux ...15 more failure(s) (19 total)... Sample log: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8897375577734940768/+/steps/browser_tests/0/logs/Deterministic_failure:_PDFExtensionAccessibilityTreeDumpTest.DirectionalTextRuns__x2f_blink__status_CRASH_/0 ../../content/test/browser_accessibility.cc:25:10: runtime error: control flow integrity check for type 'content::TestBrowserAccessibility' failed during cast to unrelated type (vtable address 0x561bd6c16bd8) 0x561bd6c16bd8: note: vtable is of type 'content::BrowserAccessibilityAuraLinux' Original change's description: > Stop exposing non-public a11y classes in content/public. > > Move content::AccessibilityTreeFormatter::FormatAccessibilityTree(), > which exposes BrowserAccessibility, to AccessibilityTreeFormatterBase, > and rename it to FormatAccessibilityTreeForTesting(), since the only > caller is in test support code. > > Then introduce content::TestBrowserAccessibility, which is an opaque > class that represents content::BrowserAccessibility. Use it inside > content/public/test to avoid exposing BrowserAccessibility publicly. > With TestBrowserAccessibility, add a static FormatAccessibilityTree() > method to give tests access to FormatAccessibilityTreeForTesting(), > which this CL took away from AccessibilityTreeFormatter. > > Change-Id: Ie89bfb6284f639fe3b8c34155b706b3808bdb4fb > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900360 > Commit-Queue: Kevin Babbitt <kbabbitt@microsoft.com> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Reviewed-by: Nektarios Paisios <nektar@chromium.org> > Reviewed-by: Kevin Babbitt <kbabbitt@microsoft.com> > Cr-Commit-Position: refs/heads/master@{#713559} TBR=kinuko@chromium.org,thestig@chromium.org,nektar@chromium.org,kbabbitt@microsoft.com,ankk@microsoft.com Change-Id: Ifbcf43ba2ee06ad49fae398cbd7c491091f8ffa1 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1905304Reviewed-by:
Takashi Sakamoto <tasak@google.com> Commit-Queue: Takashi Sakamoto <tasak@google.com> Cr-Commit-Position: refs/heads/master@{#713781}
-
Takashi Sakamoto authored
This reverts commit e41494d8. Reason for revert: this patch makes merge conflicts when reverting master#713559. The 713559 causes LinuxCFI bot failure. Original change's description: > Add end to end test for navigation through accessibility > > This CL adds a test to validate the end to end accessibility pipeline > for navigation. > > Bug: 981448 > Change-Id: I2fcb1aece4ad2164d73e2bf83511b361adf27033 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837559 > Commit-Queue: Ankit Kumar
🌪 ️ <ankk@microsoft.com> > Reviewed-by: Lei Zhang <thestig@chromium.org> > Reviewed-by: Kevin Babbitt <kbabbitt@microsoft.com> > Cr-Commit-Position: refs/heads/master@{#713598} TBR=thestig@chromium.org,kbabbitt@microsoft.com,kschmi@microsoft.com,iapres@microsoft.com,virens@microsoft.com,ankk@microsoft.com Change-Id: I77567dd947d335a67d0f235a5383377b1ec65019 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 981448 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1905305Reviewed-by:Takashi Sakamoto <tasak@google.com> Commit-Queue: Takashi Sakamoto <tasak@google.com> Cr-Commit-Position: refs/heads/master@{#713780}
-
Yang Guo authored
https://chromium.googlesource.com/devtools/devtools-frontend/+log/5cb14a4f30..3ee5ac7b0e TBR=tvanderlippe@chromium.org Change-Id: I22b26a2808c81c1ded1f9f976d81bc2af1b190b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904193Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#713779}
-
Sylvain Defresne authored
BrowserViewControllerTest just want to fake TabModel and provide stub implementation for webStateList and browserState properties so implement this with a nice mock & OCMStub(...).andReturn(...). Bug: none Change-Id: I64f3ddcef206f9ba6f9ce78b2827f37e984746b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903360 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#713778}
-
Sylvain Defresne authored
At initialisation, ios_web_unittests.app tries to load resources and prints the following error because the file cannot be found: [xxxx:ERROR:memory_mapped_file.cc(60)] Couldn't open .../ios_web_unittests.app/resources.pak Add a dependency on //ios/web/test:packed_resources to ensure that the resources are shipped with the application and thus can be found at runtime (currently it is not a problem because none of the test depends on the resources, but having them does not hurt). Bug: none Change-Id: Ic7b6194c3b6f0240bc12091e8cf944c9e76261a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903139 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#713777}
-
Javier Fernandez authored
This CL changes the runtime flag to stable and enables the feature by default. The intent-to-ship request [1] has been approved, under the condition of improving the test suite and increasing the testing coverage of the feature. These tests has been added already in a different CL [2]. [1] https://groups.google.com/a/chromium.org/d/msg/blink-dev/8qesjfh0a80/xrruWrixBwAJ [2] https://crrev.com/c/1904077 Bug: 905315 Change-Id: I1e78599777436989fefcd988c04074f33cbf452d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900002 Commit-Queue: Javier Fernandez <jfernandez@igalia.com> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#713776}
-
Mihai Sardarescu authored
Support for channel ID binding was removed from Chrome a while back. This CL removes some boolean that was referring to channel ID binding from uber token fetcher. Fixed: 1021455 Change-Id: I195056e7b3a2446afc1714c7394040b0171b6602 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899851Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#713775}
-
arthursonzogni authored
This is a preparatory CL for step 1.a from the "Unify CSP" document: https://docs.google.com/document/d/1v5mJnXJ5dSVXE_rgvJnNM9bzH0ni0YzdhPQ7GLqyhao Step 1.a is about merging the CSPSource strucs into one. This patch aligns the CSPSource struct. This moved "allow_self" and the implicit "allow_star" into the CSPSourceList. This is already what content/ and blink/ are doing. Follow-ups: https://chromium-review.googlesource.com/c/chromium/src/+/1899450 Bug: 1021462 Change-Id: I894bdcb8fbc5bd64b87b9a60334ec21874f5e8aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1901041Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Lucas Gadani <lfg@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#713774}
-
Mohamed Amir Yosef authored
Bug: 831123 Change-Id: Idbf82649bb3cf8fa66d9576c6f9ae34c37bae9f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900997 Auto-Submit: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#713773}
-
Armando Miraglia authored
While testing locally I have encountered and issue such that an interface would be bound while already bound. This fixes that behavior so that the related DCHECK is not triggered. Similar issue and fix: http://crbug.com/817873#c7 Bug: 997661 Change-Id: Ifcd1342bd9cbf2c2895e5b7f2c1967c06b2a84d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903197Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Armando Miraglia <armax@chromium.org> Cr-Commit-Position: refs/heads/master@{#713772}
-
Friedrich Horschig authored
Add a show_confirmation_button parameter. The current default and wanted behavior is "false". Bug: None Change-Id: I13f368e6822e3d26d041c671f2ab650976500ab6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904069Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#713771}
-
Friedrich Horschig authored
Change title case buttons to sentence cases. Bug: None Change-Id: I670aa17ce81ab1fa7bebe3897af005ea7621f88e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904066Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#713770}
-
Marc Treib authored
ChromeBrowserSyncAdapter was an old implementation of Sync invalidations which is not needed anymore, and hence was removed. However, it *also* caused Chrome to show up as a "syncable" app in Android settings. This CL brings back the required parts of ChromeBrowserSyncAdapter (and the corresponding ..Service and manifest entry) so that Chrome shows up in (and honors) Android's sync settings again. This is a partial revert of crrev.com/c/1821784 and crrev.com/c/1829201. Bug: 1021873 Change-Id: I13cb78fa2391f289763629620c69cf3a6c19e494 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903198Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#713769}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/f9004ee81c43..5758cc96a5f3 git log f9004ee81c43..5758cc96a5f3 --date=short --no-merges --format='%ad %ae %s' 2019-11-08 perezju@chromium.org Reland "[Telemetry] Hand over trace aggregation to Results Processor" Created with: gclient setdep -r src/third_party/catapult@5758cc96a5f3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC rmhasan@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=rmhasan@google.com Bug: chromium:981349 Change-Id: I7530a2bd445dc225e3efb7f82d385614d8b28b34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1905279Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#713768}
-
James Cook authored
store_factory_ is moved into then immediately moved out of. There are no other references other than the constructor, so remove it. Bug: none Change-Id: I5deb48f781937ef86c419c86d4aa3621f1e8ce77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903834 Commit-Queue: Marc Treib <treib@chromium.org> Auto-Submit: James Cook <jamescook@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#713767}
-
Armando Miraglia authored
This reverts commit b4f53fc9. Reason for revert: [WebRTC Sheriff] It looks like this has broken all webrtc bots (see https://ci.chromium.org/p/chromium/g/chromium.webrtc/console?limit=200). Original change's description: > Stop building frame_analyzer in gn_all. > > Building WebRTC's frame_analyzer when is_component_build=true will > fail after [1] lands. It is possible to build it only for release > builds but this CL tries to remove it since probably this is not > needed. > > [1] - https://chromium-review.googlesource.com/c/chromium/src/+/1874722 > > Bug: webrtc:9419 > Change-Id: I6da6973b8a50ea08b60f0eea0da57014cce830e2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904072 > Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > Cr-Commit-Position: refs/heads/master@{#713590} TBR=dpranke@chromium.org,ehmaldonado@chromium.org,mbonadei@chromium.org Change-Id: Ie9f312a7ac1e5d75acfd49f10fa648cbd9291876 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: webrtc:9419 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904174Reviewed-by:
Armando Miraglia <armax@chromium.org> Commit-Queue: Armando Miraglia <armax@chromium.org> Cr-Commit-Position: refs/heads/master@{#713766}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/652dbfc63e70..7f9c9a7fc001 git log 652dbfc63e70..7f9c9a7fc001 --date=short --no-merges --format='%ad %ae %s' 2019-11-08 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/spirv-tools/src dc59b4b075e9..041f0a02493d (4 commits) Created with: gclient setdep -r src/third_party/angle@7f9c9a7fc001 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jonahr@google.com Bug: chromium:None Change-Id: Ia517435cb28a3d2f33c8ff754662217736c40364 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1905277Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#713765}
-
Rob Buis authored
Make display:contents compute to display:none for MathML elements as specified here: https://drafts.csswg.org/css-display/#unbox-mathml Bug: 6606 Change-Id: Ifb68940dd345a41ca5fe083dc5b5ba9ace1af506 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903136Reviewed-by:
Frédéric Wang <fwang@igalia.com> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Rob Buis <rbuis@igalia.com> Cr-Commit-Position: refs/heads/master@{#713764}
-
Michael Lippautz authored
The idea of the bailout during incremental marking is correct. Unfortunately, the query used just returns whether local processing with the current set of buffers is done. This is wrong as we still may be marking incrementally. This CL switches to the proper accessor for incremental marking. Bug: 1019839, 1021171 Change-Id: I798ba08b8c491543095dd5018325812f7de0d6f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904169Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#713763}
-
John Budorick authored
Bug: 1022534 Change-Id: I60b30c79b20698e06fa2548af373498db68ac6fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904490 Commit-Queue: John Budorick <jbudorick@chromium.org> Auto-Submit: John Budorick <jbudorick@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#713762}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/cc4b158ee494..8c6f1f9af3f4 git log cc4b158ee494..8c6f1f9af3f4 --date=short --no-merges --format='%ad %ae %s' 2019-11-08 vapier@chromium.org dev-install: stop including the Chrome milestone 2019-11-08 vapier@chromium.org dev-install: stop including canary- version prefix Created with: gclient setdep -r src/third_party/chromite@8c6f1f9af3f4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I58e3adf5a0743cd9c5d31d1725f111f415c49f96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904237Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#713761}
-
Yuki Shiino authored
Bug: 839389 Change-Id: Icc586bb214f2198e96e9f7027066f1c7028d3990 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903243 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#713760}
-
Austin Tankiang authored
Bug: 1003238 Change-Id: I88ec141acd23900f7be259a34d27a8bc118e43ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896492 Commit-Queue: Austin Tankiang <austinct@chromium.org> Reviewed-by:
Sergei Datsenko <dats@chromium.org> Reviewed-by:
Stuart Langley <slangley@chromium.org> Cr-Commit-Position: refs/heads/master@{#713759}
-
Yoshifumi Inoue authored
This patch gets rid of unused function |NGCaretPosition::CurrentPaintFragment()| for improving code health. This is follow-up of the pathc[1] which introduce |CurrentPaintFragment()|. [1] http://crrev.com/c/1866101 Utilize NGInlineCursor in NGCaretPosition Bug: 982194 Change-Id: I20b4c332476462d3c0fdb079e4600f14580f6dee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1905294 Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#713758}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/76eaab6b8cef..99b558b594a1 git log 76eaab6b8cef..99b558b594a1 --date=short --no-merges --format='%ad %ae %s' 2019-11-08 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 cc0919dcb64b..652dbfc63e70 (7 commits) 2019-11-08 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 27a3d31d7a9d..d9ed1c2732ba (1 commits) Created with: gclient setdep -r src/third_party/skia@99b558b594a1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC ethannicholas@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ethannicholas@google.com Bug: chromium:None,chromium:None Change-Id: I1756c32d56fcbc2aff8858857bf69871d8b861d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1905269Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#713757}
-
Vadym Doroshenko authored
Bug: 959776 Change-Id: I3197389c82d969e96490d2ecbb2600a0332528e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1901080 Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#713756}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/29e8c96f..2af5f573 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ib80a22e220bcdd8e8f7abd1e6cf213fb938a1d2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1905008Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#713755}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Ibf47e8d539b96bba0860d200fca913f27f59064d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904345Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#713754}
-
Alan Cutter authored
This CL updates the PWA manifest update check to compare with a WebApplicationInfo generated from the page's blink::Manifest instead of the manifest directly. PWA installation uses the blink::Manifest -> WebApplicationInfo conversion so we must also use the same when comparing for differences. At the moment we only check theme_color which doesn't undergo any transformations at install time so it's fine. This is in preparation for comparing on other fields e.g. icon URLs which may go through sanitisation. This CL is a refactor with no changes in behaviour. Bug: 926083 Change-Id: I477f5e4ff936f4d4fee078be0e830b39730bf06a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1905041 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#713753}
-
Hiroki Nakagawa authored
This enables 'module' type option, static import, and dynamic import on dedicated workers. let worker = new Worker('worker.js', { type: 'module' }); Intent to ship: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/hnIOyxASKFU Chrome status: https://www.chromestatus.com/feature/5761300827209728 Bug: 680046 Change-Id: I463d3dcac57694415f815e3c81f2618ab8baf4db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844524Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#713752}
-
Austin Tankiang authored
This removes the code that handles the underlying operations of the file system. Bug: 1003238 Change-Id: I9ddfbc98d57837ca4c4e9df71a68048fdddf673e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896487 Commit-Queue: Austin Tankiang <austinct@chromium.org> Reviewed-by:
Sergei Datsenko <dats@chromium.org> Reviewed-by:
Stuart Langley <slangley@chromium.org> Cr-Commit-Position: refs/heads/master@{#713751}
-
Ryo Hashimoto authored
To reduce disk space usage and disk IO during startup. In Chrome OS, chromeos-chrome ebuild installs chrome.conf busconfig file whose only contents is: <includedir>/opt/google/chrome/dbus</includedir> concat_dbus_conf_files.py concatenates busconfig files in /opt/google/chrome/dbus by merging each conf file's <busconfig> into one. This is exactly the same thing as what <includedir> tag in chrome.conf does so there should be no functional changes. Before this CL: chrome.conf includes 17 busconfig files in /opt/google/chrome/dbus After this CL: chrome.conf includes only 2 files (i.e. chrome_dbus_services.conf and ash_dbus_services.conf). BUG=1020044 TEST=Manually confirmed the contents of out.conf after running chromeos/tools/concat_dbus_conffiles.py out.conf ash/dbus/*.conf TEST=Chrome boots after replacing the contents of /opt/google/chrome/dbus TEST=Can call org.chromium.LivenessServiceInterface.CheckLiveness with dbus-send Change-Id: Id0e572c2834a6ebec8f2e385bfbe6d1ee67fc37c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895021 Commit-Queue: Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#713750}
-