GitLab

BUG=none
TEST=GoogleUpdateSettings::SetCollectStatsConsent
TBR=cevans

Review URL: http://codereview.chromium.org/6281008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71773 0039d316-1c4b-4281-b951-d872f2087c98

BUG=68751
TEST=mac passes


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71772 0039d316-1c4b-4281-b951-d872f2087c98

TBR=hclam

BUG=70076
TEST=browser_tests
Review URL: http://codereview.chromium.org/6241007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71771 0039d316-1c4b-4281-b951-d872f2087c98

TBR=jam

BUG=70075
TEST=ipc_tests
Review URL: http://codereview.chromium.org/6304010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71770 0039d316-1c4b-4281-b951-d872f2087c98

We should probably have also more detailed OWNERS file below
in the file hierarchy. For example, for pyauto and webdriver.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6370003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71769 0039d316-1c4b-4281-b951-d872f2087c98

Change the Regkey helper to consistently use and return LONG
instead of bool.  Fix RegKey usage all over the code base and
get rid of workarounds due to lack of return value.

Reviewers:

brettw: everything (skip parts for other reviewers if you wish)
robertshield,grt: chrome_frame, installer
siggi: ceee


BUG=none
TEST=covered by existing tests



Review URL: http://codereview.chromium.org/6090006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71768 0039d316-1c4b-4281-b951-d872f2087c98

This still fixes the original bug and does it in a much simpler (and faster)
way. I was previously attempting to use an API to do this rather than just
setting the style directly but that API may have hidden side effects like
causing a window activation on some versions of Windows.

BUG=69724
TEST=WidgetWinTest::SetBoundsForZoomedWindow

Review URL: http://codereview.chromium.org/6331006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71767 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:8307
TEST=Compiled and saw it runs on netbook.

Review URL: http://codereview.chromium.org/6336005
Patch from Matt Falken <falken@chromium.org>.

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71766 0039d316-1c4b-4281-b951-d872f2087c98

BUG=70000
TEST=clang/linux bots are 5x as fast.

Review URL: http://codereview.chromium.org/6324007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71765 0039d316-1c4b-4281-b951-d872f2087c98

BUG=61609
TEST=none
Review URL: http://codereview.chromium.org/6310011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71764 0039d316-1c4b-4281-b951-d872f2087c98

This change just suppresses the leaks for Bug 70062. (Unfortunately, I'm not totally sure why these leaks happen on these bots because "net/socket/ssl_client_socket_nss.cc" has not been changed these days. Since the only change under 'net/socket' is r71739 <http://crrev.com/71739>, it emerged these leaks?)

TBR=thestig,timurrrr 
BUG=70062
TEST=make the "Linux Tests (valgrind)(3)" bot and the "Chromium OS UI (valgrind)(3)" bot green.
Review URL: http://codereview.chromium.org/6290007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71763 0039d316-1c4b-4281-b951-d872f2087c98

This change removes the suppression rule for Bug 69906 because this leak seems to be fixed by r71641 <http://crrev.com/71641>. (Our heapchecker bots already works well without the suppressions for this bug.)

TBR=thestig,timurrrr 
BUG=69906
TEST=make the valgrind bots green without suppressions.
Review URL: http://codereview.chromium.org/6254008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71762 0039d316-1c4b-4281-b951-d872f2087c98

BUG=http://code.google.com/p/chromium/issues/detail?id=63695
TEST=http://www.zontera.com/banners/clients_work/floating_flash/centered/dove/

Review URL: http://codereview.chromium.org/6266009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71761 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=manually, trybots

Review URL: http://codereview.chromium.org/6284003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71760 0039d316-1c4b-4281-b951-d872f2087c98

this isn't needed any more.

BUG=none
TEST=trybots

Review URL: http://codereview.chromium.org/6269010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71759 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/6327009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71756 0039d316-1c4b-4281-b951-d872f2087c98

return the chrome browser process pid. In ChromeFrame we don't use the launcher which results
in a crash while running a number of perf tests. Added a helper function to return the browser
pid.

Added a handler for intercepting and debugging pure call errors in chrome frame perf tests.

BUG=none
TEST=ChromeFrame perf tests should run to completion.
TBR=amit

Review URL: http://codereview.chromium.org/6306004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71755 0039d316-1c4b-4281-b951-d872f2087c98

extensions documents.

BUG=None
TEST=Run chrome/common/exensions/docs/build/build.py.  Extension
  documents should still be generated without errors.

Review URL: http://codereview.chromium.org/6315001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71754 0039d316-1c4b-4281-b951-d872f2087c98

BUG=69902
TEST=none

Review URL: http://codereview.chromium.org/6272008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71752 0039d316-1c4b-4281-b951-d872f2087c98

A couple of extensions sync tests were crashing due to a DCHECK, and
were marked as FAILS.

Disabling them, since the crashes causes sync runs to go red.

TBR=akalin@chromium.org
BUG=70028
TEST=sync_integration_tests

Review URL: http://codereview.chromium.org/6265011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71750 0039d316-1c4b-4281-b951-d872f2087c98

BUG=42073
TEST=manual,trybotss

Review URL: http://codereview.chromium.org/6303004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71749 0039d316-1c4b-4281-b951-d872f2087c98

The compiler gives an uninitialized variable warning when
CallbackArgsToBool() is inlined.

BUG=none
TEST=Trivial fix.

Patch from <asharif@chromium.org>

Review URL: http://codereview.chromium.org/6332004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71748 0039d316-1c4b-4281-b951-d872f2087c98

TBR=arv
BUG=none
TEST=none

Review URL: http://codereview.chromium.org/6250012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71746 0039d316-1c4b-4281-b951-d872f2087c98

builds.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/6012011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71745 0039d316-1c4b-4281-b951-d872f2087c98

This fixes truncation in general, and make rtl work much better.

BUG=70021
TEST=Startup page addition dialog should truncate with ellipsis, and look right in RTL mode.

Review URL: http://codereview.chromium.org/6361005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71740 0039d316-1c4b-4281-b951-d872f2087c98

KU_KEY_ENCIPHERMENT key usage to support the RSA key exchange algorithm.

Remove the incorrect workarounds for this bug.  In the
SSLServerSocketTest.DataTransfer unit test, do not proceed to data
transfer if the SSL connection cannot be established.

Not required for fixing this bug: create an RSA private key with all
applicable key usage bits to be future-proof.

R=hclam
BUG=67928
TEST=net_unittests --gtest_filter=SSLServerSocketTest.*
Review URL: http://codereview.chromium.org/6297008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71739 0039d316-1c4b-4281-b951-d872f2087c98

TEST=try
BUG=none

Review URL: http://codereview.chromium.org/6262006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71738 0039d316-1c4b-4281-b951-d872f2087c98

This might be causing the GPU to hang even when not viewing GPU hardware accelerated content. An example appears to be the ATI HD2600 on mac.

TEST=try
BUG=none

Review URL: http://codereview.chromium.org/6380001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71737 0039d316-1c4b-4281-b951-d872f2087c98

Rather than displaying a modal dialog, LoadLibrary and similar return an error. This allows the GPU process to fail or fall back without interacting with the user.

TEST=try
BUG=69610

Review URL: http://codereview.chromium.org/6271006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71736 0039d316-1c4b-4281-b951-d872f2087c98

TBR=tim@chromium.org

Review URL: http://codereview.chromium.org/6248008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71735 0039d316-1c4b-4281-b951-d872f2087c98

When the ALSA volume mixer is used (if PulseAudio is disabled), the current volume and mute settings will be stored in the browser prefs so they can be restored when starting a new session.

BUG=chrome-os:10470
TEST=Manual, volume and mute setting via keyboard should persist after rebooting.

Review URL: http://codereview.chromium.org/6118006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71734 0039d316-1c4b-4281-b951-d872f2087c98

to UITest::Setup. ChromeFrame perf tests override the Setup method and don't invoke the Base
UITest::Setup implementation. 

This causes a crash in UITest::TearDown invoked during the ChromeFrame perf test runs where 
we crash as the launcher is NULL. Added a check for the same.

BUG=none
TEST=chrome frame perf tests.
TBR=amit

Review URL: http://codereview.chromium.org/6321010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71733 0039d316-1c4b-4281-b951-d872f2087c98

randomly break as out requirement get out of line with the bots.

BUG=68303
TEST=reenabled on Linux

Review URL: http://codereview.chromium.org/6365003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71732 0039d316-1c4b-4281-b951-d872f2087c98

BUG=70031

Review URL: http://codereview.chromium.org/6298005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71730 0039d316-1c4b-4281-b951-d872f2087c98

A couple of extensions sync tests fail due to a DCHECK.

Marking tests as failed until the bug is fixed.

TBR=akalin@chromium.org
BUG=70028
TEST=sync_integration_tests

Review URL: http://codereview.chromium.org/6373005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71729 0039d316-1c4b-4281-b951-d872f2087c98

The location of:
 /chrome/browser/browser_theme_provider.cc

Changed to:
 /chrome/browser/themes/browser_theme_provider.cc

BUG=None
TEST=Visit the link now, it will work.

Review URL: http://codereview.chromium.org/6338007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71728 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/6323004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71727 0039d316-1c4b-4281-b951-d872f2087c98

BUG=65518
TEST=Look for 'backround' in http://code.google.com/chrome/extensions/extension.html; you should get no hits.
TBR=kurrik

Review URL: http://codereview.chromium.org/6185004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71725 0039d316-1c4b-4281-b951-d872f2087c98

1. Fix subsheet RTL.

for the record, and to whom it may concern:

"""
If neither 'left' nor 'right' is 'auto', the position is over-constrained, and one of them has to be ignored. If the 'direction' property of the containing block is 'ltr, the value of 'left' wins and 'right' becomes -'left'. If 'direction' of the containing block is 'rtl', 'right' wins and 'left' is ignored.
"""

2. add handlers to the body element to remove the subsheets when the user clicks outside them.

BUG=67849
TEST=
1. LANGUAGE=he_IL.utf-8 ./out/Release/chrome (looks right)
2. clicking away from the subsheets to dismiss them should still work.
3. clicking to the right (in ltr) of the subsheets should dismiss them (this is new)

Review URL: http://codereview.chromium.org/6277005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71724 0039d316-1c4b-4281-b951-d872f2087c98

than browser action icons.

BUG=40581
TEST=none

Review URL: http://codereview.chromium.org/6145004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71723 0039d316-1c4b-4281-b951-d872f2087c98