GitLab

Firefox's plugins directory. 

This allows extensions to override the user's default plugin for a particular
mime type.

BUG=15943
TEST=none
R=mpcomplete

Patch by Collin Jackson

Review URL: http://codereview.chromium.org/149346

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20185 0039d316-1c4b-4281-b951-d872f2087c98

Implements unique client ID generation for Posix.

Client ID generation happens once-per-install of Chromium (...well, this is
mostly true, at least).  On Windows, the code currently uses some system library
code that generates a GUID.  We don't ACTUALLY need a GUID, something that's
quite random and in the same format will work.  Since we don't want to add a
dependency on libuuid for POSIX, I created a less-random-but-still-good-enough
version.

BUG=15418
TEST=none

Review URL: http://codereview.chromium.org/149343

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20184 0039d316-1c4b-4281-b951-d872f2087c98

Also fixing the ScopedComPtrVector unit test.
The problem with the test was that it expected AddRef to be called twice and Release() once when pushing a pointer to the vector.  However that only happens when a push causes a reallocation.  When there's no reallocation, there's only a single call to AddRef and no call to Release, causing the test to report failure.  The fix is to simply use std::list instead and fix the expected values.

TEST=Run *ScopedComPtr* unit tests.
BUG=none
Review URL: http://codereview.chromium.org/149345

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20183 0039d316-1c4b-4281-b951-d872f2087c98

TEST=none
http://crbug.com/16054

Review URL: http://codereview.chromium.org/149235

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20182 0039d316-1c4b-4281-b951-d872f2087c98

things (and tests), no UI yet.

The model enforces that all pinned tabs occur at the beginning of the
model. For example, if there are no pinned tabs and you pin the 10th
tab, it is moved to the front of the tab strip. Similarly inserting a
tab before the last pinned tab implicitly pins it. Moving a pinned tab
beyond the set of pinned tabs implicitly unpins it.

I'll file a bug on this when the site allows me to.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/155228

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20181 0039d316-1c4b-4281-b951-d872f2087c98

and most likely some page cyclers.

Review URL: http://codereview.chromium.org/155236

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20180 0039d316-1c4b-4281-b951-d872f2087c98

The problem is scoped_ptr<ResourceRequestDetails> is used to delete an instance of ResourceRedirectDetails, however the base class's destructor is non-virtual, so ResourceRedirectDetails extra field (GURL new_url_) does not get torn down properly.

Note that the blame callstacks in the bug report appear unrelated, because std::string is doing some fancy refcounting under the hood. So as GURLs get passed around, they take over the GURL::spec's memory that got allocated earlier by the network stack.

BUG=http://crbug.com/10873
TEST=The "RedirectTest.*" ui tests when run on linux valgrind bots should show no leaks

Review URL: http://codereview.chromium.org/155204

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20179 0039d316-1c4b-4281-b951-d872f2087c98

Create watchlist for media changes.  The regex is pretty permissive because the media files are scattered in multiple directories with the only commonality being the word "media". (eg chrome/renderer/media, third_party/media, or more annoyingly webkit/glue/resources/media_pause.png, and webkit/api/src/WebMediaPlayerClientImpl.cpp)

Review URL: http://codereview.chromium.org/149232

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20178 0039d316-1c4b-4281-b951-d872f2087c98

TBR=nsylvian
BUG=13901

Review URL: http://codereview.chromium.org/155229

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20177 0039d316-1c4b-4281-b951-d872f2087c98

Shuffle the Mac valgind suppressions around a bit to match the other suppression file format. No actual changes to the suppressions except to get rid of a name duplication.

BUG=none
TEST=Mac valgrind bots should be unchanged.
Review URL: http://codereview.chromium.org/155225

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20176 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/149337

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20175 0039d316-1c4b-4281-b951-d872f2087c98

Since they have been ported to the browser tests framework, they are not required anymore.

BUG=None
TEST=None
Review URL: http://codereview.chromium.org/155224

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20174 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/149305

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20173 0039d316-1c4b-4281-b951-d872f2087c98

temporary_glue.cc includes webview_impl.h, which brings in headers
that include wtf/Assertions.h.  However, it also brings in logging.h.
The workaround is to include wtf/Assertions.h in temporary_glue.cc
and then #undef LOG.  This effectively mimics what we do elsewhere
in glue.

TEST=none
BUG=none
R=brettw

Review URL: http://codereview.chromium.org/149339

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20172 0039d316-1c4b-4281-b951-d872f2087c98

BUG=15906
TEST=chromium builds should have video enabled

Review URL: http://codereview.chromium.org/155107

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20171 0039d316-1c4b-4281-b951-d872f2087c98

Correctly implementing GetPeerName() to point to TCPClientSocket::GetPeerName(). This is used by the SSL layer in Linux to resolve Peer Names, which caused a trap to be generated ( http://crbug/16166 )

BUG=16166
TEST=fix of the above BUG

Review URL: http://codereview.chromium.org/149242

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20170 0039d316-1c4b-4281-b951-d872f2087c98

These 14 layout tests are passing consistently on build slaves.
TBR=scherkus

Review URL: http://codereview.chromium.org/149340

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20169 0039d316-1c4b-4281-b951-d872f2087c98

Fix the problem that the temp worker directory is not deleted if the http server process is still holding it.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/155177

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20168 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/149335

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20165 0039d316-1c4b-4281-b951-d872f2087c98

passing off the data to gdk_pixbuf.  This is required in the theme
code for tinted bitmaps.

Review URL: http://codereview.chromium.org/150151


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20164 0039d316-1c4b-4281-b951-d872f2087c98

ffmpeg_video_decoder_unittest.cc is a much more comprehensive test!

BUG=16008
TEST=none

Review URL: http://codereview.chromium.org/155198

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20162 0039d316-1c4b-4281-b951-d872f2087c98

TEST=none
BUG=none
Review URL: http://codereview.chromium.org/155199

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20161 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20160 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/150086

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20159 0039d316-1c4b-4281-b951-d872f2087c98

to reduce the number of layouts needed at startup.

This also fixes an issue where starting in LIST mode did not work.

And it also fixes an issue where the width transition wasn't working
correctly.

BUG=13362

TEST=Starting in small and normal mode should still work

Review URL: http://codereview.chromium.org/155116

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20158 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20157 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=Fewer leaks on the Mac valgrind UI test bots
Review URL: http://codereview.chromium.org/155190

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20156 0039d316-1c4b-4281-b951-d872f2087c98

BUG=14920
TEST=context menus on tabs.
Review URL: http://codereview.chromium.org/155173

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20155 0039d316-1c4b-4281-b951-d872f2087c98

Remove obsolete SupportsURL function from when we have TabContents types.

Review URL: http://codereview.chromium.org/155171

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20154 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/155184

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20153 0039d316-1c4b-4281-b951-d872f2087c98

the scope, this patch just contains those delegate functions implemented only
by TabContents, plus the favicon functions implemented by the FavIconHelper.
The only changes are re-ordering and moving the functions, and changes in the
way that the functions are called through the new optional delegate.
Review URL: http://codereview.chromium.org/149239

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20152 0039d316-1c4b-4281-b951-d872f2087c98

Some code had been removed from FirstRun::IsChromeFirstRun() so that it may return true then false when later invoked.This caused a bug where we would show the info-bar warning that Chromium is not the default browser after the first run.This patch resurrects that code and changes the first run UI, as it was relying on that behavior.BUG=http://crbug.com/15833TEST=Make IE or Firefox your default browser. Open Chromium so it shows the 1st run UI. Unselect the "make chromium my default browser" button, then press start. When Chromium shows up, there should be no info-bar warning you Chromium is not your default browser.     Also test that the first run UI still works as expected.
Review URL: http://codereview.chromium.org/155168

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20151 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/149303

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20150 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/155221

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20149 0039d316-1c4b-4281-b951-d872f2087c98

After this change it should correctly handle all cases of multiple 230 welcome responses. It also fixes some other related bugs.

TEST=Covered by net_unittests.
BUG=none

Review URL: http://codereview.chromium.org/149211

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20148 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/149329

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20147 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/155217

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20146 0039d316-1c4b-4281-b951-d872f2087c98

Also, do some housekeeping for our current shortcuts.

* Command-Option-l - Downloads [same shortcut as Safari].
* Command-Shift-[/] - Back/forward tab.
* cntrl-pageup/pagedn - Back/forward tab.

Global Keyboard events are intercepted by a new BrowserWindow custom class.

BUG=12537,15486
TEST=Check that above keyboard shortcuts work as advertised.

Review URL: http://codereview.chromium.org/149325

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20145 0039d316-1c4b-4281-b951-d872f2087c98

adding custom words to the dictionary on platforms other than 
windows. This functionality has now been implemented on all
platforms. Patch from pwicks86@gmail.com (Paul Wicks)
BUG=None
TEST=Adding words to dictionary on mac and linux.

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20144 0039d316-1c4b-4281-b951-d872f2087c98

Convert GetScreenInfo to be sync and routed.

http://crbug.com/13113
R=darin@chromium.org, jam@chromium.org, amanda@chromium.org
TEST=See bug.

Review URL: http://codereview.chromium.org/151130

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20143 0039d316-1c4b-4281-b951-d872f2087c98