- 29 May, 2020 40 commits
-
-
Tao Bai authored
This reverts commit 5f3490b1. Reason for revert: This is known issue in android-pie-x86-rel bot, The similar test is flaky on the specific x86 bot, I will add @RetryOnFailure to see if it is improved. Original change's description: > Revert "Send the datalist to Autofill Service" > > This reverts commit d606e82d. > > Reason for revert: Breaks android-pie-x86-rel > > Bug: 1087513 > > Original change's description: > > Send the datalist to Autofill Service > > > > - Send the datalist to Autofill Service > > - Autofill the datalist. > > - Also add the test. > > - This patch doesn't stop notifying Autofill service if the datalist is > > focused. > > > > Bug: 949555 > > Change-Id: Iedcefc3eba64b22cc2a87bb1442860944271d18f > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218912 > > Commit-Queue: Tao Bai <michaelbai@chromium.org> > > Reviewed-by: Dominic Battré <battre@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#772755} > > TBR=michaelbai@chromium.org,battre@chromium.org > > Change-Id: I25a1f19a4f60d8cfe2c141c1b94286ba923a6895 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 949555 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220158 > Reviewed-by: Tommy Nyquist <nyquist@chromium.org> > Commit-Queue: Tommy Nyquist <nyquist@chromium.org> > Cr-Commit-Position: refs/heads/master@{#772818} TBR=michaelbai@chromium.org,nyquist@chromium.org,battre@chromium.org # Not skipping CQ checks because this is a reland. Bug: 1087513, 949555 Change-Id: I97c267d8085503b1aeb2025a12771b1f26520eaf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220342Reviewed-by:
Tao Bai <michaelbai@chromium.org> Commit-Queue: Tao Bai <michaelbai@chromium.org> Cr-Commit-Position: refs/heads/master@{#772996}
-
François Degros authored
BUG=None Change-Id: Icfe308b3d0c40f82884ed8f658a4ec7ab191dbb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220406Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: François Degros <fdegros@chromium.org> Cr-Commit-Position: refs/heads/master@{#772995}
-
Kyle Horimoto authored
Fixed: 1086799 Change-Id: I358543042d29ab406ed77fd09bde7c48a4d1d083 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218674 Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#772994}
-
Thanh Nguyen authored
Bug: 1080427 Change-Id: Id1e6470e1823016ac8a4bce97c0be8bc4ff68027 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208311 Commit-Queue: Thanh Nguyen <thanhdng@chromium.org> Reviewed-by:
Jia Meng <jiameng@chromium.org> Cr-Commit-Position: refs/heads/master@{#772993}
-
David Lechner authored
This fixes BlueZ GATT service enumeration when there is more than one device. In the BluetoothDeviceBlueZ::UpdateGattServices() method, it is possible that the services for the requested device are not the first services in |service_paths|. If this is the case returning from inside the loop makes it appear as if the device has no services. By continuing the loop instead, all services associated with this device are made available (by calling NotifyGattDiscoveryComplete() on them). Bug: 1087648 Change-Id: I52dad45674330a52f7420b28a51fdd83439b4f9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214098 Commit-Queue: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#772992}
-
Haoyue Wang authored
Also add new flags and remove deprecated ones. https://quiche.googlesource.com/quiche.git/+log/05c3b7867dfb..64863213b10f $ git log 05c3b7867..64863213b --date=short --no-merges --format='%ad %ae %s' 2020-05-28 wub (n/a) deprecate --gfe2_reloadable_flag_quic_avoid_overestimate_bandwidth_with_aggregation. 2020-05-28 fayang Apply the amplification limit for all packets, not just handshake packets in ietf quic. also fixes an issue where shouldgeneratepacket doesn't check if the connection is connected. protected by gfe2_reloadable_flag_quic_move_amplification_limit. 2020-05-27 renjietang Add << operator for QUIC Encryption levels to make debugging easier. 2020-05-27 dschinazi Refactor TlsHandshaker interactions with the session's config 2020-05-27 dschinazi Refactor QuicConnection::AddIncomingConnectionId 2020-05-27 nharper Allow unknown/unsupported SANs in CertificateView 2020-05-27 fayang Always send the earliest ack in quicconnection::sendallpendingacks. protected by gfe2_reloadable_flag_quic_always_send_earliest_ack. Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src Change-Id: Idc93da0317f9be071085040adbd6c93cf201cfbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220476 Commit-Queue: Haoyue Wang <haoyuewang@chromium.org> Auto-Submit: Haoyue Wang <haoyuewang@chromium.org> Reviewed-by:
David Schinazi <dschinazi@chromium.org> Cr-Commit-Position: refs/heads/master@{#772991}
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/8cce349b0a59..b4e53be8a002 2020-05-28 mfoltz@chromium.org [Open Screen] Fix lint errors. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jophba@chromium.org Change-Id: I40b51b1ee10a8263f213a7c7f12cf9e194abb3c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220693Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#772990}
-
Joel Hockey authored
Bug: 846190 Change-Id: I07130721969f741891c1b8902cc22445c68032b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217936 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Auto-Submit: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Julian Watson <juwa@google.com> Cr-Commit-Position: refs/heads/master@{#772989}
-
Minoru Chikamune authored
HeapMojo wrappers require ExecutionContext to reset mojo objects when ExecutionContext is detached. Bug: 1049056 Change-Id: I2b352c1be1e8c0928227b08a6096d12c11d070b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218006Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Minoru Chikamune <chikamune@chromium.org> Cr-Commit-Position: refs/heads/master@{#772988}
-
Minoru Chikamune authored
HeapMojo wrappers require ExecutionContext to reset mojo objects when ExecutionContext is detached. Bug: 1049056 Change-Id: I700695284b09747846e75bb223c2a9f3e73053ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218005Reviewed-by:
-
Minoru Chikamune authored
HeapMojo wrappers can reset the mojo objects automatically. So no need to reset mojo objects in prefinalizer again. Bug: 1049056 Change-Id: I4e6f1ea5b4ffccc36193a9ae919285ba606b25e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217836Reviewed-by:
-
Minoru Chikamune authored
HeapMojo wrappers can reset the mojo objects automatically. So no need to reset mojo objects in prefinalizer again. Bug: 1049056 Change-Id: Ia6ee95899a6e13d0d7bd4e50cfc90600e7f6dab7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217837Reviewed-by:
-
Minoru Chikamune authored
HeapMojo wrappers can reset the mojo objects automatically. So no need to reset mojo objects in prefinalizer again. Bug: 1049056 Change-Id: I2c0107cd36e624ecb5de3a9d9cfbede7a653ed2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217918Reviewed-by:
-
Minoru Chikamune authored
HeapMojo wrappers can reset the mojo objects automatically. So no need to reset mojo objects in prefinalizer again. Bug: 1049056 Change-Id: Iaa0e99857eee508c6026d0aaba1356fbc8315a72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217719Reviewed-by:
-
Minoru Chikamune authored
HeapMojo wrappers can reset the mojo objects automatically. So no need to reset mojo objects in prefinalizer again. Bug: 1049056 Change-Id: Ib7276458a9edf9372f4d7cbae13cfa7ceae267ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217720Reviewed-by:
-
Minoru Chikamune authored
HeapMojo wrappers can reset the mojo objects automatically. So no need to reset mojo objects in prefinalizer again. Bug: 1049056 Change-Id: I6119eda011fb9dd06f95f1e1fd6db0e3778db321 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217526Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/1a4975642bf9..45b9192ad981 2020-05-28 kron@webrtc.org Add trace of enqueued and sent RTP packets If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I3448df985e09a14c390b81ff3dec622c1b7b0ccd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220692Reviewed-by:
-
Kyle Horimoto authored
This improves discoverability of the app, which was previously only available by clicking a link in settings or by right-clicking the desktop. Fixed: 1086197 Change-Id: Ia8037f3639ec33613cecef0aeb780b59b65cf5cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220337 Commit-Queue: Dominick Ng <dominickn@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#772979}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ie685dca794d6e8de0ba04c320109b818fcb11de9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220617Reviewed-by:
-
Fabian Sommer authored
Stop observing with scoped observers when the observed objects are destroyed. Fixed: 1086124 Change-Id: Ib0aa9e6eb3dc346a441ecdd0416649622ff03f17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215056Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#772977}
-
David Bertoni authored
on on Windows and Mac. TBR=rockot@google.com Bug: 1066138 Change-Id: I0ea1bf603f53872cd75f3af8683c69765426cd40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220361Reviewed-by:
David Bertoni <dbertoni@chromium.org> Commit-Queue: David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#772976}
-
David Bertoni authored
TBR=johnidel Bug: 1087406 Change-Id: I122cacf54ec7e000da17a29ead3c189c10c342cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220501Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/b28e75d6..468f8fff Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Iaf58dd730b850549ed34298cdc6debd9056aefc5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218390Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#772974}
-
Yuly Novikov authored
Since these tests use the native windowing system and thus need Xvfb when they run on GCEs. And also because these tests need to be wrapped by test_env.py to set up correct environment variables on ASAN, TSAN and CFI bots. gl_unittests already had it, but gl_tests did not, since they were "raw" isolate type. Unfortunately, gl_unittests had to be removed from 'Linux MSan Tests' as the result, for the same reason gl_tests were removed in crbug.com/830659. Probably a meaningful codepath was not tested before anyway. On another hand, gl_unittests can pass on GCEs now, so also removed the exception to launch them on HW GPU machines for Linux CFI bots, making them consistent with ASAN and TSAN bots. Also had to suppress a leak in NVIDIA libraries, since ASAN now really runs and detects it. And a minor cleanup removing 'use_xvfb' flag which is irrelevant for Swarming bots. Bug: 1081054 Change-Id: Iec8c2e3f54505eca6ae22333c86759a9553ed799 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199670 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#772973}
-
Dominic Farolino authored
We're interesting in implementing the HTML Standard notion of a parser document [1], which will replace CreateElementFlags::created_by_parser_ with a pointer to the document that the parser was created for. Therefore when marking a CreateElementFlags object as created-by-parser, one should also provide the document for the parser. As a part of this we're looking at all of the call-sites of CreateElementByFlags::{ByParser(),SetCreatedByParser()} to see which are actually related to parsing an HTML Document and require parser-inserted information. It seems that the VTT usages of CreateElementFlags::ByParser is unnecessary as it doesn't have anything to do with parsing an HTML document, and the parser-inserted information is never not queried for elements created here. [1]: https://html.spec.whatwg.org/C/#parser-document R=hiroshige@chromium.org, kouhei@chromium.org Bug: 1086507 Change-Id: Id40ddc2f7d87652cee8d6f2832e307bdf8f05d46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216314Reviewed-by:Mason Freed <masonfreed@chromium.org> Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Commit-Queue: Dominic Farolino <dom@chromium.org> Cr-Commit-Position: refs/heads/master@{#772972}
-
Moe Ahmadi authored
<dom-repeat> fires 'on-dom-change' event as soon as the items are updated in the DOM. This is a more accurate estimate of when the matches are rendered. This is still not 100% accurate since it take some time for blink to render the DOM. However this should be close enough and matches the local NTP implementation. Bug: 1087469 Change-Id: Ief9727ae89cb70d89fe04979d60268fef2a6eed9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220690 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Auto-Submit: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#772971}
-
Maggie Chen authored
Disable Direct Composition support when CreateSwapChainForComposition() fails. Bug: 1074582 Change-Id: I466c3febba7b63ccb0fc9f648a4b9cfaa7d8deba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219387 Commit-Queue: Maggie Chen <magchen@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#772970}
-
Daniel Rubery authored
Enterprises where users have not enabled Sync should still receive real time reporting events with profile user name. Fixed: 1084815 Change-Id: Ib60d9a3d03680341aeb6a540002a53c25e017ccd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215452 Commit-Queue: Daniel Rubery <drubery@chromium.org> Reviewed-by:
Bettina Dea <bdea@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Cr-Commit-Position: refs/heads/master@{#772969}
-
Ken Rockot authored
Types tagged with the [Stable] attribute can only depend on builtin mojom types or other user-defined types tagged with the [Stable] attribute. This attribute can be used to indicate that a mojom definition is safe to rely upon in situations where version skew must be tolerated. A follow-up CL will introduce a presubmit to ensure that types marked [Stable] do not change in a way that breaks backward-compatibility. Bug: 1070663 Change-Id: Ib7d966c15742f6acd6c8c12cd1ce3fee55aba7cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218803 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#772968}
-
Zhenyao Mo authored
BUG=1085729,1086820 TEST=manual R=rockot@google.com Change-Id: I6a5629a421753fa0e3d100f111e7251e78411bc5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220660 Commit-Queue: Zhenyao Mo <zmo@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Auto-Submit: Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#772967}
-
Scott Violet authored
If the height of the controls changes, then SynchronizeVisualProperties() needs to be called so that the renderer knows. Additionally, it appears that if the height changes onOffsetsChanged() isn't called. This ensures that happens. BUG=1086493 TEST=testRemoveAllFromTopView Change-Id: Ib978f50b3ea9c9bcee3adfd0f60bbd83d3e40eda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215460Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#772966}
-
François Degros authored
BUG=912236 TEST=browser_tests --gtest_filter="ZipFiles/*" TEST=browser_tests --gtest_filter="*/FilesApp*" Change-Id: Ica61d18e69555fa1d1fc136e51b462c16ad83d29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217766Reviewed-by:
-
Klaus Weidner authored
The EGL_ANDROID_native_fence_sync isn't reported as present to applications, so Chrome uses heuristics to infer if it's present. It's not usable in emulation or for SwiftShader. SurfaceControl assumes that GpuFence support is available, so don't use it if native fence sync is unavailable since that's used to implement GpuFence on Android. This check already existed but duplicated logic from gl_surface_egl, replace this with a feature check. Bug: 1086736 Change-Id: Ie2db42f605cb3eb90726b36b1bb264b4190bef80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217036Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
-
Karandeep Bhatia authored
Extension installation through the webstore involves creation of a dummy extension with an empty extension root path. The empty extension root path causes DNRManifestHandler::Parse to incorrectly raise an error while validating the paths for the extensions' ruleset files. This happens because ExtensionResource::empty() just checks whether the extension root path is empty. Fix this by replacing the ExtensionResource::empty() check with a more comprehensive check. BUG=1087348 TEST=Ensure https://chrome.google.com/webstore/detail/ajfdfkmbjmdjekckfgibicedaabjoong installs correctly. TBR=rdevlin.chronin@chromium.org Change-Id: I4e58cef19da771b17cc1d1541ccc7424b5b6f3af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219779 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Auto-Submit: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Kelvin Jiang <kelvinjiang@chromium.org> Cr-Commit-Position: refs/heads/master@{#772963}
-
Xiyuan Xia authored
EventGenerator uses WindowEventDispatcherObserver to throttle the mouse events. This does not work with nested loops in window moving/resizing or drag-n-drop. The mouse move event that triggers the nest loop does not finish until the nest loop quits. However, without further mouse events, the operation stalls and the nested loop would not quit. This CL revises the throttling part. It assumes that hitting the message pump implies the processing of the current event finishes and schedules the next event when that happens. Bug: 1032766 Change-Id: Ib32f06aa6d93b36372ea2b21d941e04293dbde2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220655Reviewed-by:
Jun Mukai <mukai@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#772962}
-
Darren Shen authored
This CL is a followup of https://crrev.com/c/2212198. IMEBridge is only used for Chrome OS, so move IMEBridge to a Chrome OS specific folder. Note, this CL changes the word NULL in comments to nullptr to pass a presubmit check. Bug: 1083803 Change-Id: I8e962996f59c7cebf7a95503ec957e5f57065f39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214590 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Keith Lee <keithlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#772961}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 99cdc265. With Chromium commits locally applied on WPT: 6956d3da "Avoid repeating a single row/column of tiled background images" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: rego@igalia.com: external/wpt/css/css-grid NOAUTOREVERT=true TBR=smcgruer No-Export: true Change-Id: Ia33ccf13537959dff7a6400cf9e7e3638c35d3a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217877Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#772960}
-
Christian Biesinger authored
This fixes a DCHECK, see https://crbug.com/991096#c29 Bug: 991096 Change-Id: I94bad7bc6a637754dbaf5b402d166cb27ab36574 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220283 Auto-Submit: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#772959}
-
Sigurdur Asgeirsson authored
Bug: 1080672 Change-Id: Ib075e13fc02c8527f14e6e2e86eaa0a627c54f1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218542 Commit-Queue: Joe Mason <joenotcharles@chromium.org> Auto-Submit: Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
Joe Mason <joenotcharles@chromium.org> Cr-Commit-Position: refs/heads/master@{#772958}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/4504fd580a5f..090475cde4fa 2020-05-28 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: I6ad58ce0ae58c61f5cde1f50cf2a9bd6b6a22002 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220708Reviewed-by:
-
