GitLab

Change-Id: I899bd9c76d5c78835cf14ecbf8bb9670e4cc7bd6
Reviewed-on: https://chromium-review.googlesource.com/c/1341479Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Commit-Queue: Xi Cheng <chengx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609445}

Currently when keyboard bounds change, KeyboardController notifies
the ChromeKeyboardUI to update the viewports of web contents on the
screen. This adds cruft to the KeyboardUI interface and will pose
problems for mash as well.

Alternatively, we could flip the relationship and have something in
Chrome observing keyboard bounds changes. This simplifies the
KeyboardUI interface and integrates nicely with the existing mojo
set up.

Bug: 845780
Change-Id: I0be697351f52619863f93e2b42dc263cd9dbab82
Reviewed-on: https://chromium-review.googlesource.com/c/1328481Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609444}

Thumbnails have been deprecated as of M69 and will be removed entirely.

Bug: 893362
Change-Id: I6d38edcdd809a48bed4ea36eac2da7d271361311
Reviewed-on: https://chromium-review.googlesource.com/c/1292601
Commit-Queue: Kristi Park <kristipark@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609443}

This reverts commit b5bd0713.

Reason for revert: It was decided to roll-back this change.

Original change's description:
> [AF] Add cross-link to Privacy settings page in Payments settings page.
> 
> Bug: 905114
> Change-Id: Ib8300998f6f183d7ffd0378ada0fbf02f118b9a2
> Reviewed-on: https://chromium-review.googlesource.com/c/1308769
> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
> Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#609311}

TBR=dpapad@chromium.org,sebsg@chromium.org

Change-Id: I100c8a76ca9dbd64aa4b6d0113dde027b9d47bf4
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 905114
Reviewed-on: https://chromium-review.googlesource.com/c/1343290Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609442}

Change-Id: I28cb8218d00908f12220ee37254020d58cc46606
Reviewed-on: https://chromium-review.googlesource.com/c/1342811Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Robbie McElrath <rmcelrath@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609441}

With vulkan, if a client (renderer, ui, etc) creates a texture with
wrong interface(GLES2Interface), the viz process will crash without
any useful information. This CL will fix the problem by logging a
error message instead of crashing.

Bug: 838899
Change-Id: I8e0c5ba162f8e4de3b0bd10899944c6b0ea89272
Reviewed-on: https://chromium-review.googlesource.com/c/1342802
Commit-Queue: Peng Huang <penghuang@chromium.org>
Reviewed-by: weiliangc <weiliangc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609440}

Fixes several failing VR tests caused by the expected URL being slightly
different from the actual URL.

TBR=billorr@chromium.org

Bug: 894796
Change-Id: Ibf01674f6694dc441bd0fb8ffaea151adce7fc47
Reviewed-on: https://chromium-review.googlesource.com/c/1343248Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609439}

Using wpt-import in Chromium 72954484.

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
jsbell@chromium.org:
  external/wpt/encoding

NOAUTOREVERT=true
TBR=raphael.kubo.da.costa@intel.com

No-Export: true
Change-Id: I7602924fb6fdecf394bb81671ef1ee9ce7d64c98
Reviewed-on: https://chromium-review.googlesource.com/c/1342701
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#609438}

Change-Id: I94d4e6e527b2987b6a77205af572737429882f89
Reviewed-on: https://chromium-review.googlesource.com/c/1340865Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Victor Miura <vmiura@chromium.org>
Commit-Queue: enne <enne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609437}

Bug: 906136
Change-Id: I1397149b56561b7cf230b960230c4304fd5be0b6
Reviewed-on: https://chromium-review.googlesource.com/c/1343043Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609436}

Bug: 833687
Change-Id: Id2e911dc2947d3c1d7c0ec23ec27f1cf27008d89
Reviewed-on: https://chromium-review.googlesource.com/c/1337297Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Greg Thompson <grt@chromium.org>
Reviewed-by: Sorin Jianu <sorin@chromium.org>
Commit-Queue: S. Ganesh <ganesh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609435}

This shell is built against Chrome's build of SQLite, which uses special
build flags. The shell can be useful for debugging SQLite bugs.

Change-Id: I5ac92c5f8be544743cd4987e8c13b00e4c817b36
Reviewed-on: https://chromium-review.googlesource.com/c/1340363Reviewed-by: Joshua Bell <jsbell@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609434}

Previously, all worker-request, a-tag, area-tag tests were excluded
because "redirection" field was not included in |selection_pattern|,
and thus "worker-requests-with-swap-origin-redirect" and
"overhead-for-redirection" entries in "excluded_tests" in spec.src.json
were applied to all redirection types.

This CL
- Includes "redirection" field in |selection_pattern| and
  instead remove "redirection" field from filenames, and
- Regenerates tests.

Therefore, this CL
- Adds new test files for worker-request, a-tag, area-tag, and
- Renames existing test files.

The only manual changes are
- referrer-policy/generic/tools/common_paths.py
- third_party/WebKit/LayoutTests/SlowTests
- third_party/WebKit/LayoutTests/SmokeTests
and all other modifications are made by
referrer-policy/generic/tools/generate.py.

Bug: 880027
Change-Id: Ie628f92b334d6e2adddc5957cc6cceaa8c69f322
Reviewed-on: https://chromium-review.googlesource.com/c/1330901Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609433}

Store base::TimeDeltas directly instead of converting to and from
TimeDeltaInternalType. This removes the use of To/FromInternalValue,
which are deprecated. No logic changes.

BUG=634507,b:116527691
TEST=Unit tests pass.

Change-Id: I7fe53e4c418651ff88da2a123c1ab943a590679b
Reviewed-on: https://chromium-review.googlesource.com/c/1340604Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Gabriel Marin <gmx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609432}

This will allow the GPU process to avoid worrying about the display scale
when setting up its Scenic resources.

Bug: 861853
Test: run_content_shell --ozone-platform=scenic --disable-gpu --enable-vulkan

Change-Id: I19571bd55ccbc004c42230ec7aba98dcd5370d11
Reviewed-on: https://chromium-review.googlesource.com/c/1342815Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Commit-Queue: Michael Spang <spang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609431}

Bug: 153782
Change-Id: I51220050f7b2a22e8da55bffcd1733092ff4c26d
Reviewed-on: https://chromium-review.googlesource.com/c/1338868Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609430}

With kCompositorTouchAction turned on, a touch event is acked from the
compositor thread instead of the main thread. Then the white listed
touch action is sent from the compositor to the browser from a separate
IPC. There is a potential race condition here, that the white listed
touch action would arrive before or after the ack. It could also happen
that the white listed touch action arrives after some gesture events
being dispatched, for example, the GSB might have reached the
TouchActionFilter while the white listed touch action is not arrived yet.

To solve this problem, this CL puts the white listed touch action as
a callback parameter, and send it through the ack, to the browser.

Bug: 905325, 876323
Change-Id: Ia9d0bb02b57291d2333f6cfe6959430ff41b5084
Reviewed-on: https://chromium-review.googlesource.com/c/1336071
Commit-Queue: Xida Chen <xidachen@chromium.org>
Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609429}

|UpdateExistingAccessPointRlz| involves file I/O, so it should be
posted on a task runner that has MayBlock() in its TaskTraits.
|background_task_runner_| serves this purpose.

Bug: 906293
Change-Id: If36215767a0dbcfbad56c0432b16b584f6185376
Reviewed-on: https://chromium-review.googlesource.com/c/1340607Reviewed-by: Roger Tawa <rogerta@chromium.org>
Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609428}

hidden.

SadTabView is a little unique in that it's a views::View which is
displayed on top of the web viewport. On macOS, this means that the
event system hit tests mouse down events to the inner WebContentsView native
view, instead of the outer BridgedContentView, which is responsible
for passing events into the views subsystem.

WebContentsView, on the other hand, is unaware of views at all, and
has no way of knowing that a sad tab is installed, and it should forward
events up to its superview for routing into the views system.

One way to get around this issue without plumbing through extra event
handling logic is to make it so events on the sad tab view hit test
to the BridgedContentView in the first place by hiding it. This change
facilitates that by propagating NativeViewHost's visibility to the
contained native view.

Bug: 896508
Change-Id: I51875903bc61eb7baef0d58e40c7ca3f6773eecc
Reviewed-on: https://chromium-review.googlesource.com/c/1334087
Commit-Queue: Leonard Grey <lgrey@chromium.org>
Reviewed-by: ccameron <ccameron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609427}

Skia has a problem to with GrResourceCache. This CL workaround the issue
by not keep a SkPaint object during frames.

Bug: 905337
Change-Id: I0f44eb7502d41cd54015fe651a373d8bae65fda8
Reviewed-on: https://chromium-review.googlesource.com/c/1342501
Commit-Queue: Peng Huang <penghuang@chromium.org>
Reviewed-by: weiliangc <weiliangc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609426}

The URL changed a while ago but the preload list entry was never updated.

R=nharper@chromium.org, palmer@chromium.org

Change-Id: I0cb0f9aad351f92585cb40cd8b1873881a10414c
Reviewed-on: https://chromium-review.googlesource.com/c/1341524Reviewed-by: Nick Harper <nharper@chromium.org>
Commit-Queue: Nick Harper <nharper@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609425}

Send policy-provided untrusted authority certificates to the network
service along with trust anchors.
Add a browsertest which checks that untrusted authority certificates
provided through user policy are respected.
Also, document certificate-related files in chromeos/test/data/network
and provide a script to generate those.

Bug: 897233
Test: browser_tests --gtest_filter=*PolicyProvided*
Change-Id: I1e66700b14e5d75805f16365e5979e84f278e8ec
Reviewed-on: https://chromium-review.googlesource.com/c/1336132
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609424}

CloseWidgetSoon will post DoDeferredClose, which will stop new frame
sinks from being made.

However WebPagePopupImpl destroys its Page/MainFrame etc when it calls
CloseWidgetSoon, which also detaches the WebFrameWidget. Then if a
RequestNewLayerTreeFrameSink was already in the task queue, it would
run before DoDeferredClose, and crash when it tries to get the URL from
the non-existant WebFrameWidget/MainFrame.

R=piman@chromium.org

Change-Id: I94ec48915b6dba207f783a9d3b380476e97da9da
Bug: 896836
Reviewed-on: https://chromium-review.googlesource.com/c/1342774Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609423}

The presubmit check ensures that the builders are sorted, first by group,
then by name. It also ensures that the file generated by the script is up
to date.

Bug: 902507

Change-Id: Iaaf7048b6b6edcc99befff7c3e8602adfd2c5681
Reviewed-on: https://chromium-review.googlesource.com/c/1327809
Commit-Queue: Stephen Martinis <martiniss@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609422}

https://webrtc.googlesource.com/src.git/+log/3a83748422c9..85340ce5166c


git log 3a83748422c9..85340ce5166c --date=short --no-merges --format='%ad %ae %s'
2018-11-19 mbonadei@webrtc.org Move rtc::scoped_refptr to api/.
2018-11-19 kron@webrtc.org Explicitly specify color space enum indices


Created with:
  gclient setdep -r src/third_party/webrtc@85340ce5166c

The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I3cad5cd282087e1a3ab6433b690cc335f4b2629c
Reviewed-on: https://chromium-review.googlesource.com/c/1342800Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#609421}

This CL:
- Moves ConvertReturnValue to IndexedDBReturnValue
- Moves ConvertBlobInfo to IndexedDBBlobInfo
- Moves ConvertAndEraseValue to IndexedDBValue

These are needed by a later change to move code out of
IndexedDBCallbacks and use Mojo's native async return calls, instead.

Bug: 717812
Change-Id: I9f02a26eb024a3e790eddc16185d426cf530108e
Reviewed-on: https://chromium-review.googlesource.com/c/1336660
Commit-Queue: Chase Phillips <cmp@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609420}

The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast
TBR=cr-fuchsia+bot@chromium.org

Change-Id: I7007071eaa5fe3ece5ba0159f1f6ac29be9f8b2e
Reviewed-on: https://chromium-review.googlesource.com/c/1343217Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#609419}

https://android.googlesource.com/platform/external/perfetto.git/+log/c7a232c866ae..96e14159c92b


git log c7a232c866ae..96e14159c92b --date=short --no-merges --format='%ad %ae %s'
2018-11-19 primiano@google.com Merge "UI: fix exceptions when only thread info is avilable"


Created with:
  gclient setdep -r src/third_party/perfetto@96e14159c92b

The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=perfetto-bugs@google.com

Change-Id: I546854175f5cb2c7d1b073f0e8d8f0205d728c91
Reviewed-on: https://chromium-review.googlesource.com/c/1342720Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#609418}

This fixes the test for UAv2.

Bug: 906639
Change-Id: Ic23f0384691b4cbc3936efabafa2c8cbd128c780
Reviewed-on: https://chromium-review.googlesource.com/c/1342773Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Commit-Queue: Mustaq Ahmed <mustaq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609417}

Change-Id: I76106686b24889ef34a436bef00f5a8fc2641696
Reviewed-on: https://chromium-review.googlesource.com/c/1341480Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Commit-Queue: Xi Cheng <chengx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609416}

Needs https://chromium-review.googlesource.com/c/chromium/tools/build/+/1330732
before this can land.

Bug: 866062
Change-Id: I2e802b8d72df043ddefc1f1caefee205fdfa3161
Reviewed-on: https://chromium-review.googlesource.com/c/1338839
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609415}

Server-side handling of the 1% of startup profiles has been validated.
Increase to 50% of all profiles to provide equivalent data for
comparison and validation of profile sizes.

Bug: 851163
Change-Id: Ib34239b7179939857667b8de9633b57ce247494f
Reviewed-on: https://chromium-review.googlesource.com/c/1342857
Commit-Queue: Mike Wittman <wittman@chromium.org>
Reviewed-by: Xi Cheng <chengx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609414}

This CL removes a call to OnTextInputStateChanged from
UpdateInputMethodObserver which could trigger a hide immediately
after a show.

Bug: 845780
Change-Id: I57e49ef011f3d3199ff9b72120d6388ebacc0847
Reviewed-on: https://chromium-review.googlesource.com/c/1338232Reviewed-by: Darren Shen <shend@chromium.org>
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609413}

This simplifies the public KeybardController interface and helps
prepare for supporting different InputMethodKeyboardController options
in Mash.

Bug: 845780
Change-Id: I8d857ca67c8ea57de76036ae1487abd9dbbbd91a
Reviewed-on: https://chromium-review.googlesource.com/c/1337287Reviewed-by: Darren Shen <shend@chromium.org>
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609412}

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/cd22b3155708..d652ed3029eb


git log cd22b3155708..d652ed3029eb --date=short --no-merges --format='%ad %ae %s'
2018-11-19 alanbaker@google.com Vulkan memory model: semantics validation


Created with:
  gclient setdep -r src/third_party/SPIRV-Tools/src@d652ed3029eb

The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: I60bf91aa2ddcbd3583ad6b79a20ec2421c158dcd
Reviewed-on: https://chromium-review.googlesource.com/c/1342478Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#609411}

Allow mouse cursor to be a green plus when dropping items to desktop

Bug: 905238
Change-Id: I90a6f7156e681271f577f1f604f1d75ada4beba2
Reviewed-on: https://chromium-review.googlesource.com/c/1334994Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609410}

This is not something that has been used for some time.

Change-Id: I25ad3a53653fc7734a40ae92851e8ed61cd6908b
Reviewed-on: https://chromium-review.googlesource.com/c/1342938Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Stephen White <senorblanco@chromium.org>
Commit-Queue: enne <enne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609409}

This failed previously because when SnapWindow is called after ToggleOverview,
it ends the overview start animations, which then activates the hidden
overview textfield. This causes OnWindowActivated to be called before
SnapWindow has finished, so IsSplitViewModeActive() still returns false.

Test: tested with DCHECKS enabled
Bug: 906707
Change-Id: Ic7b99eb8642f8bf1cd1badaa6fa6c981127987a7
Reviewed-on: https://chromium-review.googlesource.com/c/1342807
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609408}

Setting document.title should have no effect for non SVG/HTML documents,
see https://html.spec.whatwg.org/multipage/dom.html#document.title.

Behavior matches Firefox.

Bug: 906038

Change-Id: I724abf9ecd711536d71ad95ab45c72230c2e87b6
Reviewed-on: https://chromium-review.googlesource.com/c/1339959
Commit-Queue: Rob Buis <rbuis@igalia.com>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609407}

As documented in bug 847487, the DCHECK was a false alarm, being caused
by acceptable amounts of integer truncation rounding error. This change
removes the DCHECK, and also clarifies the logic a bit further: In the
case where even the rounding error causes the |next_generate_time_| to
be before |now|, that is close enough to warrant that a "skip-ahead"
correction be made.

Testing: Confirmed the logic works by manually freezing the audio
process during an audio loopback session, observing recovery, and also
examining the "GenerateMoreAudio Is Behind" TRACE_EVENTs (see crbug for
file attachment).

Bug: 847487
Change-Id: If19b3abd9745e28d9684965bde2364447722b5bc
Reviewed-on: https://chromium-review.googlesource.com/c/1341155Reviewed-by: Max Morin <maxmorin@chromium.org>
Commit-Queue: Yuri Wiitala <miu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609406}