- 24 Sep, 2020 40 commits
-
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1600775907-34bfad4572405dae937638ebe3b1eeb7936a17be.profdata to chrome-win32-master-1600905490-fe209194e056a39e0ecce0cfbf9501bffc967720.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC jeffyoon@google.com,liaoyuke@google.com,sebmarchand+pgo_roller@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com,sebmarchand+pgo_roller@google.com Change-Id: I7955d03fa0c10544c6f0e803645ad8fa88b72951 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427966Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#810171}
-
Christian Dullweber authored
Show confirmation for cookie deletion before deleting cookies. Screenshot: https://crbug.com/1077766#c50 Bug: 1077766 Change-Id: I916cdde882dcaf31b9313661a8f734c9112b2640 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426424Reviewed-by:
Ehimare Okoyomon <eokoyomon@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#810170}
-
Lei Zhang authored
This is a reland of 0ca8e290 The problem that triggered the revert has been resolved in https://crrev.com/810037 Original change's description: > Check for static initializers on linux-chromeos-rel. > > Bug: 537099 > Change-Id: I7d006d2a563de005b22945f0eabb723f86657862 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416563 > Commit-Queue: Lei Zhang <thestig@chromium.org> > Reviewed-by: Thomas Anderson <thomasanderson@chromium.org> > Reviewed-by: Nico Weber <thakis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#809945} Tbr: thakis@chromium.org,thomasanderson@chromium.org Bug: 537099 Change-Id: Ic4f699ac781c47412cbe4995e7e75139cfe4a631 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427294Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#810169}
-
Jan Wilken Dörrie authored
This change adds a separate header for forward declarations of password_manager::PasswordForm. Since this is currently only an alias of autofill::PasswordForm, a naive forward declaration does not work. Furthermore, this change creates a new target for password_form, making it easier to split up cycling dependencies between several password_manager sub components. Bug: 1067347 Change-Id: Ia5e6cd83dfd84b09c7dd3069d4f86ca2830102fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426449 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#810168}
-
Andrew Grieve authored
All usages have now moved to build_vars.json Bug: 1114750 Change-Id: Ibf6c74fdd24070ba2e32f2c8c43a9b40948d5beb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424525 Auto-Submit: Andrew Grieve <agrieve@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Reviewed-by:
Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#810167}
-
Stepan Khapugin authored
Move some methods from MainControllerGuts to StartupInformation, where I think these methods belong, as they are startup-related. Bug: 1045659 Change-Id: I1e915f9c95c7c965a9fbdb1858608feedc4cf32b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418406 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#810166}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: I26977782060c595e8d35df0e83203783e5b72465 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2428168Reviewed-by:
-
George Burgess IV authored
field_info is having `(char)field->initial_value_hash().value()` appended to it here. The actual number is probably what was intended. Bug: 1130867 Change-Id: I40a0c993938d354a19d79e3ea3673fd3f17d2f94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426344Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: George Burgess <gbiv@chromium.org> Cr-Commit-Position: refs/heads/master@{#810164}
-
Martynas Sinkievic authored
Change-Id: I9ffc936f26122a54297ec99e8f1f1a947cb854a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423884Reviewed-by:
Matthias Körber <koerber@google.com> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Martynas Sinkievič <marsin@google.com> Cr-Commit-Position: refs/heads/master@{#810163}
-
Hidehiko Abe authored
Bug: 1110266 Test: Built locally. Change-Id: I291f594060beed19d8497c5d6b7689effbe3dc9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413458Reviewed-by:
-
Danila Kuzmin authored
Tab keystroke from user options menu on a lock screen should move focus to the next available user pod or "Shut down" button, if there is no more user pods in a row. Also focus should stay in a dropdown menu, if keys other than Tab or Escape are pressed. Previously any keystroke from the “Remove account” button inside the dropdown menu has always moved focus to the “Shut down” button. Bug: 1107667 Change-Id: I8b0579e477b9f055ead9cd13e06a88982ab31db1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418572Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Danila Kuzmin <dkuzmin@google.com> Cr-Commit-Position: refs/heads/master@{#810161}
-
David Munro authored
In addition to the UseDLC flag, which controls whether we use DLC or component updater service, add an Enabled flag which controls if we try to call DLC service at all. If DLC service isn't available we want to skip calling it during uninstallation, since otherwise we can't distinguish between uninstall of DLC failing due to DLC service not supporting that board yet, or failing because e.g. DLC service just crashed, in which case we should fail too. This flag will be set by USE flag in future OS-side CLs. Bug: chromium:1121463 Test: Unit tests Change-Id: Ia901db50936c03fc133aabb81a1130665a0e9584 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2420193 Commit-Queue: David Munro <davidmunro@google.com> Reviewed-by:
Fergus Dall <sidereal@google.com> Cr-Commit-Position: refs/heads/master@{#810160}
-
Rushan Suleymanov authored
The feature toggle was enabled by default in M84. Bug: None Change-Id: I3006bcb11ca2043d0d880daaf2d4e8807c182f2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426445Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Rushan Suleymanov <rushans@google.com> Cr-Commit-Position: refs/heads/master@{#810159}
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: Idaf5cddaba336292e6a5114efb6ad0515b0527cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427155Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#810158}
-
Harald Alvestrand authored
Bug: chromium:1127309 Change-Id: I90602856ef9b021bf617fa8a7c95d872f87a8148 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423886Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#810157}
-
David Munro authored
It's enabled by default, but we still support Stretch so toggling the flag false is useful for testing. Bug: None Test: None Change-Id: I0dc8203835618166fb4df339c649fa8dff33992a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426211 Auto-Submit: David Munro <davidmunro@google.com> Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/4e32ab4dd7c3..f6b292d8a301 2020-09-24 treehugger-gerrit@google.com Merge "Ftrace: don't log errors in case of ENODEV" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: Ia5f470b9a178af150be58e2fde338e432ba1d58b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2428212Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/4ee4324d..5a952a34 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I83c86853d897b0457dbd22c9fb2ccaee6f16f3fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426771Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#810154}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: Icfd6030c581dd0a35695ff5587c6896d182665c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427585Reviewed-by:
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/6aadd31a5f98..a09406249fa3 2020-09-24 egranata@google.com Fix a linker problem with ARM/thumb compatibility If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I20deddcfde69d345280e0b6862d4a8f60641adfb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427744Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/60ce96e2ff10..0e7fe4d35baf 2020-09-24 Simran-B@users.noreply.github.com Add missing backticks around <result-id> (#3840) 2020-09-23 rharrison@google.com Validate SPIRV Version number when parsing binary header (#3834) 2020-09-23 stefanomil@google.com spirv-fuzz: Create synonym of int constant using a loop (#3790) 2020-09-22 58573781+richard-lunarg@users.noreply.github.com Fix compiler error on macOS with XCode12 (#3836) 2020-09-22 vasniktel@gmail.com spirv-fuzz: Handle OpPhis in TransformationInlineFunction (#3833) 2020-09-22 stevenperron@google.com Update CHANGES 2020-09-22 afdx@google.com spirv-fuzz: Refactor fuzzer, replayer and shrinker (#3818) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Tbr: radial-bots+chrome-roll@google.com,syoussefi@google.com Change-Id: I60436de8e821f74fd62aff32ad6ca4ab40cd265a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2428190Reviewed-by:
-
Sam McNally authored
https://chromium.googlesource.com/chromiumos/platform2/system_api.git/+log/9ae272cf722a..77b1345ec0eb $ git log 9ae272cf7..77b1345ec --date=short --no-merges --format='%ad %ae %s' 2020-09-11 sammc power: Add preferred_minimum_external_power to PowerSupplyProperties. Created with: roll-dep src/third_party/cros_system_api BUG=b:160854398 Change-Id: If5647a300c34ede6c809f8878d258c39ccc9e929 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427949 Auto-Submit: Sam McNally <sammc@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#810150}
-
Yutaka Hirano authored
Bug: 1058309 Change-Id: Icb86941037a48ef476cff0c6c41c11d76423f19f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417872 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Domenic Denicola <domenic@chromium.org> Cr-Commit-Position: refs/heads/master@{#810149}
-
Morten Stenshorne authored
Using page logical height as physical height isn't right, if writing mode is vertical. Use it as physical *width* then. Also update LayoutView::GetLayoutSize() documentation. Bug: 881727 Change-Id: I67ca50df01315ea8dc7af9c57781ee1809ba68f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362749 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Stefan Zager <szager@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#810148}
-
Omar Morsi authored
Change-Id: I9ca6ad82d45f396eef304f3337d84cbc0f707b79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424317Reviewed-by:
Pavol Marko <pmarko@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Omar Morsi <omorsi@google.com> Cr-Commit-Position: refs/heads/master@{#810147}
-
George Burgess IV authored
details.gallery_id is a `std::string`, but `gallery_id` is an `uint64_t`. As it stands, this assignment makes `gallery_id` equal to a single-character string, with the character value `(char)gallery_id`. This does not appear to be the intent. Bug: 1130867 Change-Id: Ic8a7ce58a8a452c8890a91bdc007234ae18b73c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424815Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: George Burgess <gbiv@chromium.org> Cr-Commit-Position: refs/heads/master@{#810146}
-
Omar Morsi authored
According to the style guide [*] there should rarely be a need to pass smart pointers by const ref. The current implementation of GetPrivateKey accepts a slot smart pointer by const ref. This CL changes this parameter to a raw pointer. [*] https://chromium.googlesource.com/chromium/src/+/master/styleguide/c++/c++.md#object-ownership-and-calling-conventions Bug: 1131435 Change-Id: I4060855d3580ef75e2983ca08ae47091c139b379 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426404Reviewed-by:
-
Raphael Kubo da Costa authored
SensorProviderProxy::From() can be too early a place to bind to the SensorProvider service in //services. When running Chrome via `wpt run', or actually when using ChromeDriver in general, ModulesInitializer::InitInspectorAgentSession() will be called very early on, and it will ultimately call SensorProviderProxy::From() through DeviceOrientationInspectorAgent's initialization sequence. The Mojo connection is not really needed at this point though, as SensorProvider::GetSensor() is only called later on when a Sensor object is being activated in a page. As such, bind to the Mojo service as close to the point where that method is called: * Do some small refactoring and, instead of letting SensorProviderProxy provide a direct pointer to the device::mojom::blink::SensorProvider pointer it holds, just make SensorProviderProxy itself available to its callers in SensorProxy and children, and add a wrapper for SensorProvider::GetSensor() that ensures |sensor_provider_| is bound before calling the remote method. * While here, remove the private SensorProviderProxy::IsInitialized() method and directly check if the HeapMojoRemote is bound in the code. This makes it easier to read. Fixed: 1126926 Change-Id: I07b118b289c0bc822856cfb7929f77035d803809 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421511 Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Auto-Submit: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/6c3942200a20..95ee2fa38cda 2020-09-24 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from d9fa0d46 to 08c26569 (2320 revisions) 2020-09-24 sergeyu@google.com Vulkan: Relax ASSERT in SemaphoreVk::wait() 2020-09-23 timvp@google.com Convert unordered_map to absl::flat_hash_map for select files 2020-09-23 jmadill@chromium.org Auto-generate restricted trace .gitignore. 2020-09-23 b.schade@samsung.com Use ImageHelper staging buffers for copyImageDataToBuffer 2020-09-23 m.maiya@samsung.com Vulkan: Enable OES_texture_storage_multisample_2d_array If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: chromium:1096746 Tbr: syoussefi@google.com Test: Test: angle_end2end_tests --gtest_filter=*ETC1CompressedImageDraws* Change-Id: I4a5fbd4a2b8f3bff64e3a261fa4e25bbbe04bc7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2428200Reviewed-by:
-
Antonio Gomes authored
This is the first step to be able to share BrowserNonClientFrameViewAsh between chromeos/chrome and lacros/chrome. The main premise is that lacros/chrome builds can not link to "ash" symbols. Hence, code that is going to be shared between both builds need to be relocated out of /ash/ directories and files. //ash/public/cpp/vector_icons is a dependency of //ash/public/cpp/caption_buttons, which will also be moved in a follow up CL. Both //ash/public/cpp/caption_buttuns/frame_caption_button_container_view.h and frame_back_button.h are included by browser_non_client_frame_view_ash.cc. This is phase 1.1 on the design document [1]. [1] https://docs.google.com/document/d/1xHwcHrAiEaWuA4usGEqKZ9zm1H8SGk3WkS-Jf2Q_los/ BUG=1113900 R=jamescook@chromium.org Change-Id: I2d6a981f17e905f6220388b8098b3c7e3e274eff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423987Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Antonio Gomes (GMT-4) <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#810142}
-
Hiroshige Hayashizaki authored
Previously, when an exception is thrown, ModulatorImplBase::ExecuteModule() returns ModuleEvaluationResult::Empty(), when CaptureEvalErrorFlag::kReport is used and top-level await is not enabled. This is considered as success, but this is inconsistent with - ModuleRecord::Evaluate() that returns ModuleEvaluationResult::FromException() (that is considered as non-success), and - Classic script evaluation. This CL makes ModulatorImplBase::ExecuteModule() return ModuleEvaluationResult with an exception in such cases. Behavior change: This changes WorkerReportingProxy::DidEvaluateTopLevelScript()'s |is_success| value from true to false when a module script have parse/evaluation/etc. errors. This makes serviceworker registration fails for such scripts, fixing crbug.com/1129795. This CL fixes content/test/data/service_worker/worker.js to use `globalThis` instead of `this`, because on module scripts `this` can't be used to get the global object. (Previously, the test using this script ServiceWorkerVersionBrowserTest.StartInstalledModuleScriptWhileOffline unexpectedly threw an exception during evaluation of `worker.js` as a module service worker top-level script, but didn't fail due to this issue) Bug: 1129795, 1129743, 1111134 Change-Id: I5443539c201e1ab220fd17f9291b307432853450 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419054 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Dominic Farolino <dom@chromium.org> Cr-Commit-Position: refs/heads/master@{#810141}
-
Morten Stenshorne authored
Spec: https://drafts.csswg.org/css-align/#baseline-export The "first baseline set" of a multicol container is the baseline of the first line box in the first column (i,e, ignore all other columns), or the baseline of the first line box in the first column spanner that has such a thing, whichever comes first. Multicol containers have no "last baseline set", and, as such, fast/multicol/inline-block-baseline.html is invalid, since an inline-block aligns with the "last baseline set". Remove the test, and replace it with its antithesis, baseline-008.html in wpt/css/css-multicol/. And added a bunch of tests, since this feature seemed to have no coverage, apart from the deleted test in fast/multicol/. Bug: 829028 Change-Id: I954de9618fde87dbfa37292786ca6a2dcce9fa1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421462Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#810140}
-
Tuukka Toivonen authored
The CL "X11 and Ozone: enable use_x11 and use_ozone" enabled both USE_OZONE and USE_X11 in the same build. (https://crrev.com/c/2315869) The feature IsUsingOzonePlatform() should be used to check whether Ozone is actually in use or not. VA-API support code did not do it properly, breaking VA-API with X11. This patch fixes that. Bug: 1129978 Change-Id: I64232207dd30b8a88bed7c250abc4ec2019210d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418379 Commit-Queue: Tuukka Toivonen <tuukka.toivonen@intel.com> Reviewed-by:
Maksim Sisov (GMT+3) <msisov@igalia.com> Reviewed-by:
Ted Meyer <tmathmeyer@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#810139}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/d1580d53b7bc..4005bb741040 2020-09-24 mark@chromium.org mac-arm64: Provide an arm64-native ninja-mac for builds in ¼ of the time If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1103315 Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: I017d9bd55ea916819944b2db3f4338cde653ee53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427963Reviewed-by:
-
Kent Tamura authored
Bug: 1040826 Change-Id: I4ed8de1d903563808985cea91aa13f125d06a275 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426212 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
-
Zufeng Wang authored
Make help app use message pipe instead postMessage directly. Copies a lot of how media app does it: - The changes in help_app_ui/resources are based on the files in media_app_ui/resources/js - browser_proxy.js copies from launch.js - The externs file is the same as the externs file in cl/333229584 - Add a mock app in app_bin.js - Changes in help_app_ui/test to switch to message pipe are mostly copied from media app: - Move runTestInGuest out of GuestDriver like media app - Delete GuestDriver because help app doesn't use it - Delete actionQuery because help app doesn't use it - Delete the tests for open feedback dialog and show parental controls. Test them in help_app_integration_browsertest.cc instead. Using message pipe and the externs file gives more type safety. Bug: b/166043485 Change-Id: Ifa155537505a8b3456cde0c1be4d8f1a8ca4c90d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405044 Commit-Queue: Zufeng Wang <zufeng@google.com> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Rachel Carpenter <carpenterr@chromium.org> Cr-Commit-Position: refs/heads/master@{#810136}
-
Kenichi Ishibashi authored
This CL changes the implementation of ServiceWorkerResourceReader not to depend on AppCacheResponseReader by effectively porting AppCacheResponseReader into ServiceWorkerResourceReaderImpl. See [1] for the reasoning of code duplication. This CL should not have behavior changes. Existing tests such as ServiceWorkerInstalledScriptsSenderTest and ServiceWorkerResourceStorageTest cover this change. [1] https://docs.google.com/document/d/1UhdZnaeEP8GywZR0Gik6wF6jKmNY3je6aDhPfJ05YhU/edit?usp=sharing Bug: 1117369 Change-Id: I38edd39b4073e9c8f3922a8c638def2e60a972b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367310 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#810135}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/5e85c8bc3139..0ed7f1fab2e9 2020-09-24 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision adce4958..532b3f34 (809911:810021) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I584db4201b52332cfc60d90ff4fc2562531c2d74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427965Reviewed-by:
-
Andreea Costinas authored
This CL reverts the change in CL:2367042. The privacy team revisited the initial decision to show the "Network may be monitored" warning for enterprise networks and concluded it's confusing and not helpful. Bug: 1130566, 1119754, 919691 Change-Id: Ie25dd43a61a25c0e332eda5ebcec9c08b4c59c5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426611Reviewed-by:
Andreea-Elena Costinas <acostinas@google.com> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Andreea-Elena Costinas <acostinas@google.com> Cr-Commit-Position: refs/heads/master@{#810133}
-
Koji Ishii authored
This patch renames: EmHeightAscent to NormalizedTypoAscent EmHeightDescent to NormalizedTypoDescent It was once discussed at whatwg to use normalized sTypo metrics as the definition of "em-height", but the plan was abondaned due to the lack of consensus. The algorithm is still useful for other purposes that this patch renames it and use the same way. We may want to switch this to other algorithms in future, as the standard evolves, and as we retrieve better metrics (e.g., BASE table) from fonts. This patch has no behavior changes. Change-Id: I6bbbaabb1b54795bf88a85730364581254066464 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425995 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#810132}
-
