- 17 Nov, 2020 40 commits
-
-
Sammie Quon authored
Close the tray bubble when entering capture mode via the tray bubble. Do not close app list or any tray bubbles in capture mode on click or touch. Test: manual Fixed: 1137889, 1141496 Change-Id: Idd231f28be3d58dba823d5f371d630c28c6afc9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487876 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#828282}
-
Xi Han authored
Bug: 1016952 Change-Id: I6707bf7a5e5caef6e002751f7759815f94f14e92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543687Reviewed-by:
Caitlin Fischer <caitlinfischer@google.com> Commit-Queue: Xi Han <hanxi@chromium.org> Cr-Commit-Position: refs/heads/master@{#828281}
-
Renato Silva authored
The custom element used for the Assistant screen now has a proper "-element" suffix to discern the dom-module from the rest of its uses throughout the code. This is a necessary change for using the HTMLImports polyfill in order to avoid clashes in the names. Bug: 1111387 Change-Id: Ib4ec56b74e2c9f035dc1a3166be8fd9b80a24b5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544543 Commit-Queue: Renato Silva <rrsilva@google.com> Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#828280}
-
Joe Downing authored
This CL moves some formatting code into EventTraceData so it can be shared between the file logger and Windows event logger. I've also fixed a few small things that I noticed (PLOG, comment changes). Change-Id: I3eeb4a9f581efebd2eeb19880b32af3c2df29422 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544742Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Commit-Queue: Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#828279}
-
Evan Stade authored
AppBannerInProductHelp is not slated for componentization. This moves the jni code which invokes the IPH UI from AppBannerManager.java, which is slated for componentization, to AppBannerInProductHelpControllerProvider.java, and thus removes some //chrome dependencies from the former class. Bug: 1147268 Change-Id: If8eb505ec32081b6c85f2b901eac4887b2a49543 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2541062 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Cr-Commit-Position: refs/heads/master@{#828278}
-
Joon Ahn authored
http://screen/5gd92ktsmdrZMQv Bug: 1125150 Test: screen/5gd92ktsmdrZMQv Change-Id: I2f517a58766730752866d940424e049c4501b6fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2541670 Auto-Submit: Joon Ahn <joonbug@chromium.org> Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#828277}
-
Renato Silva authored
OOBE initialization was being executed in the middle of the chain of JS files in cr_ui.js. This commit moves this initialization to its own file that gets included at the end of oobe.js and md_login.js. These changes are necessary for adopting the HTMLImports polyfill because this initialization part was being executed only later by waiting for the DOM content loaded event. Since we now guard the execution of JS until the polyfill is ready, cr_ui.js would be executed entirely when reached, creating some errors. Bug: 1111387 Change-Id: I6e08456fa29f0179eeba347c3c8b6831fa642265 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527173 Commit-Queue: Renato Silva <rrsilva@google.com> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#828276}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/f0f126063145..f69ec827f69b 2020-11-17 andoli@chromium.org Sets up infrastructure to migrate extensions of type 'setting' 2020-11-17 tvanderlippe@chromium.org Typecheck profiler/HeapSnapshotProxy.js with TypeScript 2020-11-17 alexrudenko@chromium.org Roll deps and update protocol definitions 2020-11-17 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2020-11-17 szuend@chromium.org [ts] Replace UI.__editingCount and Element.__editing with Set 2020-11-17 bmeurer@chromium.org [wasm] Add informative console messages when loading debug symbols. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1083146,chromium:1126328,chromium:1134103,chromium:1136484,chromium:1145997,chromium:1148495 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I43489237c1179bc5e81bc7dcb7aad29552c87d24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544254Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#828275}
-
Nnamdi Theodore Johnson-Kanu authored
- Fix issue where next button is not disabled in selection flow - Fix issued where next button does not navigate to esim/psim flows Bug: 1093185 Change-Id: If88329108eb094b5aed18fc8e0dc74930415ddb1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2541818Reviewed-by:
Azeem Arshad <azeemarshad@chromium.org> Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com> Cr-Commit-Position: refs/heads/master@{#828274}
-
Donn Denman authored
Removes the demo-level UI for Related Searches. The demo allowed a single tap to trigger Related Searches while preserving longpress as a regular Touch to Search. Going forward the Related Searches UX will be triggered by the same gesture as TTS. This is a partial rollback of https://crrev.com/c/2200437 with minor changes. BUG=1148874,1119585 Change-Id: Ifdefea88e23d189bd6347745fc96a733545a77bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538335 Auto-Submit: Donn Denman <donnd@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#828273}
-
Chromium WPT Sync authored
Using wpt-import in Chromium f2ba36a7. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: guidou@chromium.org, armax@chromium.org: external/wpt/mediacapture-streams guidou@chromium.org, emircan@chromium.org, emircan@chromium.org: external/wpt/screen-capture NOAUTOREVERT=true TBR=smcgruer@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-payments-fyi-rel Change-Id: I7b2b0e189389ee8dd4495db90627b46d096ed82f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544366Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#828272}
-
Klaus Weidner authored
WebXR AR DOM overlay mode no longer needs the local frame view's background color to be changed, this is now handled by CSS for the :xr-overlay pseudoclass. Remove this code to avoid potential complications such as incorrect background color restoration. Bug: 1149708 Change-Id: I130842a80eff6d56f58590c8611b2c5e5f7f2878 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543484Reviewed-by:
Piotr Bialecki <bialpio@chromium.org> Commit-Queue: Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#828271}
-
Sean Harrison authored
Project is taking a different approach that neccessitates a change to the flag name for accuracy. Change-Id: I45ce6026963c9fda614cc3f1b1c14645b1051405 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544542 Commit-Queue: Sean Harrison <harrisonsean@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Cr-Commit-Position: refs/heads/master@{#828270}
-
Evan Stade authored
Feature has been launched to stable. Bug: 1147291 Change-Id: I326292a7b38aba0f5a8d71f1dab908f4707c78b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542848 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Glenn Hartmann <hartmanng@chromium.org> Cr-Commit-Position: refs/heads/master@{#828269}
-
Christos Froussios authored
This metric tracks usage of backends and is useful long-term Bug: 1140055 Change-Id: Ie672922dd8d465da30472fec947582c216ef46f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2540611Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Christos Froussios <cfroussios@chromium.org> Cr-Commit-Position: refs/heads/master@{#828268}
-
Patrick Monette authored
This class was also slightly refactored to get rid of the logic in VoteData. Bug: 971272 Change-Id: If10c30d44371ebb00df5507e78dc4dcbd7a165e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533141 Commit-Queue: Patrick Monette <pmonette@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#828267}
-
Gauthier Ambard authored
This CL fixes navigating back to offline pages with the new error page workflow. It is allowing navigating to WebUI from the error page. It is also removing the decoding in the JavaScript of the error page as it was decoding the parameters of the URL which might create issue in parsing the URL. Bug: 1138228, 1138894 Change-Id: I8da6b84b295b3f9cbaf53c28fd3f766938409815 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2540982 Commit-Queue: Eugene But <eugenebut@chromium.org> Auto-Submit: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#828266}
-
Ian Wells authored
Bug: 1115463 Change-Id: I32a0f1c6efb76adc99e6182876541881753212b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2541571Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Ian Wells <iwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#828265}
-
Gayane Petrosyan authored
Bug: None Change-Id: Ia92791c401c483d2dff98ca3583f087baa9e4bcc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543691 Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org> Auto-Submit: Gayane Petrosyan <gayane@chromium.org> Reviewed-by:
Sebastien Lalancette <seblalancette@chromium.org> Cr-Commit-Position: refs/heads/master@{#828264}
-
Andres Medina authored
Followed process in //third_party/protobuf/README.chromium Highlights: * Some protobuf APIs started being deprecated. Moved sources in //chromecast and //components to start using the non-deprecated versions. * Removed most of the patches and updated the ones that are still needed. No new patches. * //components/subresource_filter/core/common/unindexed_ruleset.h: HadError is not const anymore. Size increase is caused by protobuf mainlining 2 functions to Serialize and Parse inside each *pb.cc file. This new methods are now the way protobuf serializes and deserializes messages so no way to avoid those without substantially changing protobuf internals. Binary-Size: Unavoidable. Increase intrinsic to new protobuf. Bug: 1144985 Change-Id: I23ce43f07da82fdda60575934a4b039200164f48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518036 Commit-Queue: Andres Medina <medinaandres@chromium.org> Auto-Submit: Andres Medina <medinaandres@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Luke Halliwell (slow) <halliwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#828263}
-
Paul Moy authored
Now that the CPU routines have good default parameter values and can look up board-specific parameters from cros_config, mark the duration parameters optional, so the end user doesn't need to know good values for these durations to effectively use the routines. Keep exposing the parameters because the routines have long runtimes, and it would still be useful to be able to configure them for cases like a CPU problem that only shows up after hours of stress testing. Also remove the |max_num| parameter from the prime search routine, because it has a good default value and should never need to be changed. Note that this value can still be tweaked on a per-device basis in cros_config if necessary. Bug: b:173062802 Change-Id: I53e01332606f2efb33e7205a0750536e2058e1ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2541574 Commit-Queue: Paul Moy <pmoy@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Oleh Lamzin <lamzin@google.com> Cr-Commit-Position: refs/heads/master@{#828262}
-
Torne (Richard Coles) authored
The previous change https://chromium-review.googlesource.com/c/chromium/src/+/2528804 updated one of the occurrences of the dubious URL "javascript:42" in this test class but not the other, and the remaining one is somehow causing test flakes rather than consistent failures. Change it to match the other to deflake the test. Bug: 1149051 Change-Id: I9a813f9272ad1b675d5f51d4a78e4574f7b7beed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542760 Auto-Submit: Richard Coles <torne@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Commit-Queue: Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#828261}
-
Sophie Chang authored
been successfully processed Having the prediction manager store use the models that are ready will be in the next CL. Bug: 1146151 Change-Id: Iab50e336a0c5853055a0ce4f9ed47bc8fefb5f3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536255Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Commit-Queue: Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/master@{#828260}
-
Ayu Ishii authored
This change adds initial draft of IDL for Storage Buckets. This does not have the full implementation of the API and only stores bucket names in the renderer. Implementation of the endpoints will come in following CLs. This CL adds the following. navigator.storageBuckets - openOrCreate(name): Stores bucket name if it doesn't exist already - keys(): Lists stored bucket names in the renderer - delete(name): Deletes specified bucket name from stored list Bug: 1107553 Change-Id: I84cd5f877cf5719b2bb74c9b50c75f1ffd604154 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308509Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Commit-Queue: Ayu Ishii <ayui@chromium.org> Cr-Commit-Position: refs/heads/master@{#828259}
-
W. James MacLean authored
As creis@ notes, the CL in https://chromium-review.googlesource.com/c/chromium/src/+/2534260 fails to correctly handle the case where an opt-in is attempted in a BrowsingInstance in a BrowserContext where the same origin previously did not opt-in, on account of the global walk not being initiated due to the presence of an opt-in for that origin in another BrowserContext. This CL splits the opt-in tracking to be per-BrowserContext in order to avoid that scenario. Bug: 1148379 Change-Id: I80dd70f2fec80101ba0260812eb8a2a12cd141d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2540749Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Commit-Queue: James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#828258}
-
Aaron Tagliaboschi authored
Bug: 1149575, 1070922, 1091285 Change-Id: If6118f86e0a7d7333513af52a01fbe8e61d83c12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2541924Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Aaron Tagliaboschi <aarontag@chromium.org> Cr-Commit-Position: refs/heads/master@{#828257}
-
Xiaoqian Dai authored
Extend the expiry data of this histograms of splitview. Bug: 1144814, 1144813, 1144808, 1144807, 1144806 Change-Id: If22e506af928b71834fa6db64123c6d442fe997e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543082Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#828256}
-
Jerome Jiang authored
https://chromium.googlesource.com/webm/libvpx.git/+log/94384b5c685a..b5d77a48d740 $ git log 94384b5c6..b5d77a48d --date=short --no-merges --format='%ad %ae %s' 2020-11-16 jianj Remove condition on copying svc loopfilter flag 2020-11-11 marpan vp9: Allow for disabling loopfilter per spatial layer 2020-11-05 chengchen Accumulate frame tpl stats and pass through rate control api 2020-10-29 jzern libs.mk: set LC_ALL=C w/egrep invocations 2020-09-20 wtc Add a comment about bitdeptharg and inbitdeptharg 2020-10-27 jzern vp9_ext_ratectrl_test: add missing override 2020-10-27 jianj Add cmd line option to control loopfilter for vpxenc 2020-10-26 angiebird Download bus_352x288_420_f20_b8.yuv properly 2020-10-20 angiebird Small changes of vp9_ext_ratectrl_test.cc 2020-10-16 angiebird Add ref frame info to vpx_rc_encodeframe_info_t 2020-10-12 angiebird Add vpx_rc_status_t 2020-10-15 angiebird Add unit test for vp9_ext_ratectrl Created with: roll-dep src/third_party/libvpx/source/libvpx R=jzern@google.com Change-Id: I48637e4f7b9d7c505157125afeb9f4823816c903 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543187Reviewed-by:
James Zern <jzern@google.com> Commit-Queue: Jerome Jiang <jianj@google.com> Cr-Commit-Position: refs/heads/master@{#828255}
-
Mark Schillaci authored
This CL is the fourth part of an effort to port the existing Desktop feature to Android. This feature enables a user to send an image to Google to process to generate a descriptive alt text if a website does not provide one. Design Doc: go/2020-q1-android-image-descriptions Slide Deck: go/clank-imageDescriptions Launch Bug: 1057168 Original Desktop Design Doc for reference: go/chrome-a11y-annotations-design This is a conservative approach, we use a separate set of profile Prefs for this feature rather than syncing with the Desktop Prefs. This can be updated in time as needed. We have also hidden the entire feature behind a feature flag, so this CL is not visible to an average user. ---------- This CL adds the following: - Enabling image descriptions from dialog - Enabling image descriptions through settings - Connection through JNI from Java to native code ---------- AX-Relnotes: Adds feature to enable generating alt image descriptions, currently behind a feature flag. Bug: 1057169 Change-Id: I6c0a81664f417a2f5ce1c06b9cb3153cc9c0d5d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327176Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Mark Schillaci <mschillaci@google.com> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Mark Schillaci <mschillaci@google.com> Cr-Commit-Position: refs/heads/master@{#828254}
-
Peter Kotwicz authored
This CL adds guava_android_target variable to build/config/android/config.gni in order to enable internal builds to switch the guava target being used to the internal target. BUG=1144019 Change-Id: Id93eb3c36256ee786801c7e122e82aefca625f2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544045Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#828253}
-
Ahmed Fakhry authored
Since UniqueWidgetPtr closes the native windows of the widgets created by the capture mode session asynchronously, they end up showing up in the captured screenshot. This CL fixes this by closing those windows immediately. BUG=1149423 TEST=Manually, added a test that fails without the fix. Change-Id: Idb5e0bcf734173a7577b56f311abd321e1ee85ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543201Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#828252}
-
chinsenj authored
This is a part of go/cros-bento which aims to improve virtual desks. Currently when a user creates a new desk, the desk mini view is created and given a default name. Clearing and focusing on the desk's renaming textfield will encourage users to actually rename their desks, increasing the intentionality of their desks. This CL alters the desk creation flow by clearing and focusing on the newly created desk's renaming textfield. Test: manual + modified existing tests Bug: 1143856 Change-Id: I62bce0251ba6e260c011d29aa7e85dd3d200db4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533364Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Commit-Queue: Jeremy Chinsen <chinsenj@chromium.org> Cr-Commit-Position: refs/heads/master@{#828251}
-
Connie Wan authored
Bug: 1148195, 1149950 Change-Id: I658e01ad6601f7cdf145502918419f2637bda8ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543127Reviewed-by:
Charlene Yan <cyan@chromium.org> Commit-Queue: Connie Wan <connily@chromium.org> Cr-Commit-Position: refs/heads/master@{#828250}
-
Robert Kaplow authored
This is a reland of ac21d86a Original change's description: > Reland "Deprecate uninstall_metrics." > > This is a reland of e15311e1 > > Original change's description: > > Deprecate uninstall_metrics. > > > > Remove the tracking/persisting of these metrics in prefs. Removed > > uploading in uninstaller. > > > > Bug: 1107516 > > Change-Id: I84499820cea86b5f785949d9274e8b2205714aae > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308133 > > Reviewed-by: Tommy Li <tommycli@chromium.org> > > Reviewed-by: Nate Fischer <ntfschr@chromium.org> > > Reviewed-by: Greg Thompson <grt@chromium.org> > > Commit-Queue: Robert Kaplow <rkaplow@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#825461} > > Bug: 1107516 > Change-Id: Id7a71c3b8d64dbe9984b2f7f33808207071550f5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2528581 > Reviewed-by: Nate Fischer <ntfschr@chromium.org> > Reviewed-by: Tommy Li <tommycli@chromium.org> > Reviewed-by: Greg Thompson <grt@chromium.org> > Reviewed-by: Denis Kuznetsov [CET] <antrim@chromium.org> > Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org> > Cr-Commit-Position: refs/heads/master@{#826222} Bug: 1107516 Change-Id: Id9371d0221fefe009730528eec967d5cbe87918b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532988 Commit-Queue: Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#828249}
-
Xiaocheng Hu authored
This patch changes how we implement 'list-style-type' internally: 1. It's parsed into a CustomIdentValue to support custom counter styles. Note that when CSSAtRuleCounterStyle flag is off, we discard values that are not predefined counter styles to match the existing behavior. 2. The computed value is represented by a new ListStyleTypeData class, which contains not only type and string value, but also a tree scope references. This allows accessing @counter-style rules defined in shadow trees. 3. ComputedStyle::ListStyleType() and ListStyleStringValue() are reimplemented on top of the new representation. This ensures that all the remaining code acts in the same way as before, and there is no behavior change. Bug: 687225 Change-Id: I110695ff11e2ab4e2378e9290ba57360e5ed1610 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538366Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#828248}
-
Marijn Kruisselbrink authored
This reverts commit f7713274. Reason for revert: The added browser tests appear to be (flakily) crashing on various builders: For example https://ci.chromium.org/p/chromium/builders/ci/Linux%20Tests/95504 with https://chromium-swarm.appspot.com/task?id=4fef1ab263264c10 [1303/1306] StartupBrowserWithWebAppTest.PRE_PRE_LastUsedProfilesWithWebApp (1571 ms) [ RUN ] StartupBrowserWithWebAppTest.PRE_LastUsedProfilesWithWebApp [11419:11462:1117/050706.931735:ERROR:object_proxy.cc(621)] Failed to call method: org.freedesktop.DBus.Properties.Get: object_path= /org/freedesktop/UPower: org.freedesktop.DBus.Error.ServiceUnknown: The name org.freedesktop.UPower was not provided by any .service files [11419:11462:1117/050706.931814:WARNING:property.cc(144)] DaemonVersion: GetAndBlock: failed. [11419:11462:1117/050706.932083:ERROR:object_proxy.cc(621)] Failed to call method: org.freedesktop.UPower.GetDisplayDevice: object_path= /org/freedesktop/UPower: org.freedesktop.DBus.Error.ServiceUnknown: The name org.freedesktop.UPower was not provided by any .service files [11419:11462:1117/050706.932300:ERROR:object_proxy.cc(621)] Failed to call method: org.freedesktop.UPower.EnumerateDevices: object_path= /org/freedesktop/UPower: org.freedesktop.DBus.Error.ServiceUnknown: The name org.freedesktop.UPower was not provided by any .service files BrowserTestBase received signal: Segmentation fault. Backtrace: #0 0x558aecd46cd9 base::debug::CollectStackTrace() #1 0x558aeccb6753 base::debug::StackTrace::StackTrace() #2 0x558aed26b5f6 content::(anonymous namespace)::DumpStackTraceSignalHandler() #3 0x7f26cd1224c0 (/lib/x86_64-linux-gnu/libc-2.23.so+0x354bf) #4 0x558ae929f9a0 StartupBrowserWithWebAppTest_PRE_LastUsedProfilesWithWebApp_Test::RunTestOnMainThread() #5 0x558aed26a407 content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() #6 0x558aecde10ef ChromeBrowserMainParts::PreMainMessageLoopRunImpl() #7 0x558aecddfed5 ChromeBrowserMainParts::PreMainMessageLoopRun() #8 0x558aeb16da36 content::BrowserMainLoop::PreMainMessageLoopRun() #9 0x558aeb5c3b13 content::StartupTaskRunner::RunAllTasksNow() #10 0x558aeb16ca17 content::BrowserMainLoop::CreateStartupTasks() #11 0x558aeb16f638 content::BrowserMainRunnerImpl::Initialize() #12 0x558aeb16af68 content::BrowserMain() #13 0x558aebc439c3 content::ContentMainRunnerImpl::RunServiceManager() #14 0x558aebc435b6 content::ContentMainRunnerImpl::Run() #15 0x558aebc40a64 content::RunContentProcess() #16 0x558aebc413ec content::ContentMain() #17 0x558aed269f34 content::BrowserTestBase::SetUp() #18 0x558aecca3c51 InProcessBrowserTest::SetUp() #19 0x558aea228198 testing::Test::Run() #20 0x558aea22902f testing::TestInfo::Run() #21 0x558aea229a07 testing::TestSuite::Run() #22 0x558aea237207 testing::internal::UnitTestImpl::RunAllTests() #23 0x558aea236b6f testing::UnitTest::Run() #24 0x558aecd97f74 base::TestSuite::Run() #25 0x558aecc8d252 ChromeTestSuiteRunner::RunTestSuite() #26 0x558aed299357 content::LaunchTests() #27 0x558aecc8d522 LaunchChromeTests() #28 0x558aecc8ac54 main #29 0x7f26cd10d840 __libc_start_main #30 0x558ae864e0aa _start [1304/1306] StartupBrowserWithWebAppTest.PRE_LastUsedProfilesWithWebApp (CRASHED) Similar crash also on https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%281%29/110376 (https://chromium-swarm.appspot.com/task?id=4feff52dc4172910) Original change's description: > Fix session restore after launching with PWA. > > The underlying issue is that the kProfilesLastActive pref gets > cleared when Chrome is launched with a specific profile, which > prevents Chrome from iterating over the last active profiles > and calling session restore on each of them. This CL stops > clearing the pref when launched with --app-id, and avoids > restoring sessions for the last active profiles > if launched with --app-id. Also, ignore browser opens and > closes if the browser window is for a web app, in order to prevent > kProfilesLastActive pref from getting overwritten. > > Bug: 1022795 > Change-Id: I350a54eaaf167dabb297b9bda9061fe965f0750e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984710 > Reviewed-by: Greg Thompson <grt@chromium.org> > Reviewed-by: David Roger <droger@chromium.org> > Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#827876} TBR=droger@chromium.org,grt@chromium.org,davidbienvenu@chromium.org Change-Id: Ib48b40d1c39911d9c5b1072fda35703a70be1f5a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1022795 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544744Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#828247}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/2f5d646c928e..d8e982264ce5 2020-11-17 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from 9d3ef3258715 to 0cb8cc8cfcb2 (4 revisions) 2020-11-17 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from e4c1a25cc679 to 04515da400d5 (3 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: cnorthrop@google.com Change-Id: Id8bec0df85348af3cba9fcd152531952d50ce9b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544251Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#828246}
-
Austin Sullivan authored
- These methods now return a tuple of FilePath, PathType - Pre-req for properly handling external path types for ChromeOS Bug: 1139907 Change-Id: I91638f4957e578f0dbf60b03d1a2c3facc82c034 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542805 Auto-Submit: Austin Sullivan <asully@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#828245}
-
Ben Joyce authored
Batch tests to speed up execution. See go/test-batching. Bug: 1149694 Change-Id: I953d198712ad60ba338344d446a0e4e99a5d9a53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542825 Commit-Queue: Ken Rockot <rockot@google.com> Auto-Submit: benjamin joyce <bjoyce@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#828244}
-
dpapad authored
This is in preparation of migrating to JS modules. Bug: 1149868 Change-Id: I98dfdf93b7d8d6e8fc024dc0594a2c871b62cbfc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2478900 Auto-Submit: dpapad <dpapad@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Reviewed-by:
John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#828243}
-