- 04 Jun, 2019 40 commits
-
-
dpapad authored
- Add minify_polymer.py script that uses rollup and uglify to bundle and minify Polymer3. - rollup will only be installed locally by whoever is rolling a new version of Polymer, and does not need to be checked-in to Chromium's toolchain for now. - Update reproduce.sh to call minify_polymer.py, and to update the paths of all iron-* and paper-* dependencies to point to the bundle file. - Update demo page accordingly. Bug: 965770 Test: chrome://print/polymer3/demo.html should still work Change-Id: Ia71c4779a7b2559affb3617c9c81c35e224555df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636274Reviewed-by:
Dan Beam <dbeam@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#666009}
-
Daniel McArdle authored
The coverage was non-zero for CRLSet::Parse, but it appears the fuzzers never managed to get the bottom of the function. As such, ReadCRL had no coverage. This CL improves the coverage by creating a new fuzzer specifically for CRLSet::Parse with a seed corpus. I just grabbed files from net/data/ssl/certificates/ that contained "crl" in their name -- this was enough to get the fuzzer to venture into ReadCRL. Change-Id: I67618a448b23c36313ea7c8df09536529522075c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643908Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Commit-Queue: Dan McArdle <dmcardle@chromium.org> Cr-Commit-Position: refs/heads/master@{#666008}
-
Lowell Manners authored
This reverts commit 58fe1e69. Reason for revert: This looks like it breaks an ios internal trybot https://ci.chromium.org/p/chrome/builders/luci.chrome.ci/ios-internal-chromium-tot Original change's description: > Delete GaiaCookieManagerServiceObserver in favor of callbacks. > > This CL replaces GaiaCookieManagerServiceObserver with vanilla > callbacks. Now that GCMS is owned by IdentityManager, and cannot have > multiple observers, a callback interface seems more natural than an > Observer class. > > This also has the nice side effect of removing transitive includes of > gaia_cookie_manager_service.h via identity_manager.h. > > Change-Id: I9cdac56c8237c9a09eb2c2ce87f41f48872a9fb6 > Bug: 939372 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1630162 > Reviewed-by: Mihai Sardarescu <msarda@chromium.org> > Reviewed-by: Colin Blundell <blundell@chromium.org> > Commit-Queue: Lowell Manners <lowell@chromium.org> > Cr-Commit-Position: refs/heads/master@{#665616} TBR=blundell@chromium.org,msarda@chromium.org,lowell@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 939372 Change-Id: I777df13eb9bc5eddeea46640b973c287d6622061 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642232Reviewed-by:
Lowell Manners <lowell@chromium.org> Commit-Queue: Lowell Manners <lowell@chromium.org> Cr-Commit-Position: refs/heads/master@{#666007}
-
Guido Urdaneta authored
The test was disabled waiting for https://crrev.com/c/1617498 to land. Bug: 927949 Change-Id: Ie1d555d21eb21d04b4b859ff007767d8bb77847b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643529 Auto-Submit: Guido Urdaneta <guidou@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#666006}
-
Katie D authored
Does not actually implement scrolling, and the UI is hidden behind --enable-experimental-accessibility-autoclick. Bug: 947068 Change-Id: I9e66dcbe589c09f6819b2822c179240e48c0cd0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1639362 Commit-Queue: Katie Dektar <katie@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Anastasia Helfinstein <anastasi@google.com> Cr-Commit-Position: refs/heads/master@{#666005}
-
Evan Stade authored
These three colors are never set to non-default values, so hard-code them in the only place where they're used (NativeThemeBase). Bug: none Change-Id: I0c3d8ee2efd0f5fd428917341dadc54c1a3f958d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642271Reviewed-by:
Leonard Grey <lgrey@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#666004}
-
Theresa authored
Tablets don't have an overview mode when an accessibility service is not enabled. Restrict the test to phones only. BUG=970184 Change-Id: If1d7f160203a1abc96f9cb837098f11b58d17ec5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643105Reviewed-by:
Becky Zhou <huayinz@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#666003}
-
Christopher Grant authored
A previous approach to splitting native code into DFMs benefited from having a different libmonchrome.so for bundles. The latest approach doesn't need a separate library, because the impact of splitting on the main lib is negligible. Therefore, return to using the same lib for both bundles and APKs. The first step is flipping the switch off in this CL, and removing some related code. Then, conditionals can be safely removed downstream, and finally, the flags and any remaining cruft can be purged from the public config. TBR: agrieve@chromium.org Bug: 962477 Change-Id: If5582f49894b053daf307b42df04406815133370 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1641387 Commit-Queue: Christopher Grant <cjgrant@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#666002}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/75841d73c2de..5b424e69101a git log 75841d73c2de..5b424e69101a --date=short --no-merges --format='%ad %ae %s' 2019-06-04 sugoi@google.com Revert Chromium vulkan unit test build for now 2019-06-04 sugoi@google.com Build fix for MacOS and Fuchsia 2019-06-03 sugoi@google.com Add vulkan unit tests to Chromium Created with: gclient setdep -r src/third_party/swiftshader@5b424e69101a The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Change-Id: I6bbbad70e874f8cdb12bb6cf8da54c6989be78aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643316Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#666001}
-
Siddhartha S authored
This CL adds the metadata fields for tracing. BUG=925151 Change-Id: I35d4e81c093dfd84574907221007c6dabb10189d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1639321Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: ssid <ssid@chromium.org> Cr-Commit-Position: refs/heads/master@{#666000}
-
Dan Sanders authored
AVDA has been deprecated for many releases and has been fully replaced by MediaCodecVideoDecoder. Bug: 970062, 789435 Change-Id: I76f32185f7e8a28153e87c38485ba83e29386850 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1641641Reviewed-by:
Frank Liberato <liberato@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Commit-Queue: Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#665999}
-
Saman Sami authored
Child throttling and BeginFrame throttling really have the same purpose, which is to prevent the client from sending further frames when there are frames that aren't drawn yet. I don't think there is a need for two different mechanisms to achieve this. Make BeginFrame throttling work across multiple surfaces (it currently only supports one), and remove child throttling. Bug: 938947 Change-Id: Id2765030eb52f4a8923535d86397cccbe70e829d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637526Reviewed-by:
Jonathan Ross <jonross@chromium.org> Commit-Queue: Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#665998}
-
Anastasia Helfinstein authored
The pref name referenced in the settings page did not match the setting created in ash/pref_names.cc. Bug: None Change-Id: I6a83ee7aa7d454276d9fd71e0a721afb86aa717e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642961Reviewed-by:
Dan Beam <dbeam@chromium.org> Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Cr-Commit-Position: refs/heads/master@{#665997}
-
Min Qin authored
BUG=942770 Change-Id: I2bf15ee1bf417e99a191a82160903a041ab39620 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636402 Commit-Queue: Min Qin <qinmin@chromium.org> Reviewed-by:
Nik Bhagat <nikunjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#665996}
-
Chris Hamilton authored
This breaks out the very common case of a single frame in a process into its own reporting bucket. BUG=960924 Change-Id: Id2e5b9a68b06ff02273ada9ab5756c977b08f9ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643208Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#665995}
-
Michael Giuffrida authored
The app window can sometimes get un-maximized, e.g. by snapping it to the side (crbug.com/966889). These changes ensure that even when these bugs happen, the app will be maximized again the next time it launches (ie, at next sign-in): * Removing the window ID ensures bad bounds aren't cached in the user's profile. * Calling window.maximize() in the window-created callback is usually a no-op, but guards against other bugs preventing the app window from opening maximized. Bug: 930285 Change-Id: Icb1edacef86dd71cc69f8b9dde2b8139b0c270b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638279 Auto-Submit: Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Bruno Santos <brunoad@chromium.org> Reviewed-by:
Bruno Santos <brunoad@chromium.org> Cr-Commit-Position: refs/heads/master@{#665994}
-
Robert Ogden authored
This metric is for a feature that hasn't fully launched yet and is still actively being tracked. Bug: 969949 Change-Id: I526aef04178f3db728f3e087fb81e28180095deb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1641462 Commit-Queue: Robert Ogden <robertogden@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#665993}
-
Caitlin Fischer authored
The Autofill.SuggestionAcceptIndex metric encompasses credit card and address forms. Note that "address forms" is generally used to refer to forms that use data from AutofillProfiles--including forms without addresses, e.g. a sign-up form with name, phone, and email fields. The present logging does not allow us to answer form-specific questions such as "What percentage of users select one of the first three suggestions for credit card forms?" "For address forms?" Given our findings about the differences between the number of credit cards and the number of profiles that users have, which influences the number of suggestions we show in each context, and hence, the suggestion accepted index, it would be more useful to split this metric by form type: (1) CreditCard (2) Profile (3) Other Please refer to the findings in the table on page 3 (Googlers only): https://docs.google.com/document/d/1qU7jJ6DmNgC1WLG9HrxGdgDoPWmQSAi9mAldIy9X8rU/edit Bug: 964422 Change-Id: I422af5fd995b4032ec3bc931697e43a8eac1cab9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617092 Auto-Submit: Caitlin Fischer <caitlinfischer@google.com> Reviewed-by:
Nik Bhagat <nikunjb@chromium.org> Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Cr-Commit-Position: refs/heads/master@{#665992}
-
Sergey Ulanov authored
Previously ASR tests were asserting that Chi-square value for each bit were below 24.0. On 64-bit platforms that condition is tested about 19000 times, so probability that at least one test fails was about 2%. Increased the limit to 35. Bug: 811881 Change-Id: Ia192ccf62abdd125053a0d005e632d55e8374538 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642109 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Bill Budge <bbudge@chromium.org> Cr-Commit-Position: refs/heads/master@{#665991}
-
Ben Kelly authored
Historically the simple disk_cache backend has assumed all accesses occurred on the browser IO thread. In order to support running cache_storage on a separate sequence this CL removes the IO thread assumptions from simple disk_cache. Bug: 960012 Change-Id: Idde0f6049aad403318d32b65a160515ee5d67fa6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643234Reviewed-by:
Maks Orlovich <morlovich@chromium.org> Commit-Queue: Ben Kelly <wanderview@chromium.org> Cr-Commit-Position: refs/heads/master@{#665990}
-
Victor Hugo Vianna Silva authored
As we no longer collect favicon availability metrics in FaviconSource, we can remove the icon_request_origin member once added to the struct. No behavior is changed. Change-Id: I975d6f612a56be1e2fd7711dfa3b17e0db1fffba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643173Reviewed-by:
Esmael El-Moslimany <aee@chromium.org> Commit-Queue: Victor Vianna <victorvianna@google.com> Cr-Commit-Position: refs/heads/master@{#665989}
-
Yuchen Liu authored
This patch adds new enum DOLBYVISION_PROFILE8 and DOLBYVISION_PROFILE9, and updates all the other related codes. Bug: internal b/134099245 Test: DV stream, Netflix, Vudu Change-Id: Ic238eefedde39387924356ef105fac8dc89075d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637983Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Sergey Volk <servolk@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Yuchen Liu <yucliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#665988}
-
Matthew Jones authored
Bug: 970270 Change-Id: Ia2ebf2c17a0851f517ea355ac16228cf7a9e4024 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642952Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#665987}
-
Vladimir Levin authored
This patch ensures that we proceed with re-enqueing a request if the referrer policy has changed. R=chrishtr@chromium.org Bug: 884505 Change-Id: I515f3185e783e356311b2a4a84a6898132fb6baa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1641426Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#665986}
-
Ken Rockot authored
A Channel message can have some extra header space for stashing e.g. encoded handle values on Windows, Mac, and Fuchsia. On those platforms the size is always validated against other header metadata. On other platforms the size is ignored and never validated. Meanwhile, when deserializing Channel messages we extract and validate some basic metadata before allocated a data buffer in which to reconstruct a sanitized message. On platforms which don't use extra header bytes, the reconstructed message will always have zero extra header bytes. In cases where we receive a malformed message on these platforms, with some non-zero extra header size, the reconstructed message's total payload size will differ from the message being deserialized. We have a DCHECK in place to assert that this never happens, and so such messages can hit the DCHECK. While this doesn't end up affecting production behavior in any meaningful way, it does break some ClusterFuzz test cases. This updates the deserialization path such that messages with extra header bytes are rejected on platforms which never use them. Bug: 968637 Change-Id: I5fa32d3c1f9208472fd899d61f91656b2a710a17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638882Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#665985}
-
Mehran Mahmoudi authored
This adds some unit tests for the KeyFunctionsMediator class. Tests involving Distillability will be added in a future CL for end-to-end tests. Bug: 967457 Change-Id: I7c33e0c03081eb90074516b00915b3bb48a2c970 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1640826Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Mehran Mahmoudi <mahmoudi@chromium.org> Cr-Commit-Position: refs/heads/master@{#665984}
-
Raphael Kubo da Costa authored
The Wake Lock spec has dropped all event handling from the text, and we adapted our implementation accordingly in commit 0463bfde ("wake lock: Adapt to the latest version of the spec (9a17e1f48)"), so the entry in DEPS is no longer needed. Bug: 257511 Change-Id: I69e4ce2c921b672951474aac233597c72089e490 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643552 Auto-Submit: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Commit-Queue: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#665983}
-
Denis Kuznetsov authored
Last changes to crd host implementation include adding new message type ("error") that have semantics very close to "hostStateChanged". This CL adds handling of this message so that in case of CRD error the remote command would also complete with with proper error result. Bug: 965039 Change-Id: I3d1590d21e05287ed904188af6d394077810f13c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1641243 Commit-Queue: Denis Kuznetsov <antrim@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#665982}
-
Rayan Kanso authored
Pass the properties as a parameter of their own since `options` dictionaries don't generally include required parameters. Change-Id: Icce60989009611cab2c23fd336981ffae4c1234b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643512 Commit-Queue: Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#665981}
-
Sebastien Marchand authored
This will make it easier to move performance_manager to //component at some point. Change-Id: I807e55aef0c4a0a85fda6c6df2bf78af94a2bbf1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636260Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Sigurður Ásgeirsson <siggi@chromium.org> Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#665980}
-
Yann Dago authored
Bug: 962665 Change-Id: Icf34f4214189aed2f8cdae8b3d3028eb39337a4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1615671 Commit-Queue: Yann Dago <ydago@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#665979}
-
Jenny Zhang authored
TBR=holte@chromium.org Bug: 969200 Change-Id: I3ffd5d6382f680297dfe71d6554419711afe5cbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638881 Commit-Queue: Jenny Zhang <jennyz@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#665978}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/009bc1a74cf5..29e2ec5aa31e Created with: gclient setdep -r src-internal@29e2ec5aa31e The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=harringtond@google.com,orphis@google.com,shend@google.com Change-Id: Ia62b855b921554c334c7997ad5f999c2846f7616 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643323Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#665977}
-
BUG=762641 TBR=derat@chromium.org Change-Id: I3ac7753802a8933d037a6a1bb2fcbc57178ccd9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642810Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#665976}
-
Mason Freed authored
Prior to this CL, no filters testing was performed at device_scale_factor != 1. This adds both the css3/filters and the WPT/css/filter-effects tests to device_scale_factor 2 testing. SHERIFFS: if this CL causes flakiness in any of the new /virtual/scalefactor200/* tests, please disable those tests in TestExpectations rather than reverting this CL. There is a section for 968791 that you can add to. Thanks! Bug: 968791 Change-Id: I1c63a50cc80b75d6ba7eef80afbe1ba36b84be7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638661Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Mason Freed <masonfreed@chromium.org> Auto-Submit: Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#665975}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/62fd2c32bbe6..ac79ca16c651 git log 62fd2c32bbe6..ac79ca16c651 --date=short --no-merges --format='%ad %ae %s' 2019-06-04 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skia/third_party/skcms ca5b4470be98..386ae89d2b64 (1 commits) 2019-06-04 robertphillips@google.com Switch all internel uses of GrContext::createBackendTexture over to initialized versions 2019-06-04 jvanverth@google.com Create FenceSync implementation that works for all Metal configs 2019-06-04 herb@google.com Convert over more sites to SkStrikeSpecStorage, and remove unused calls 2019-06-04 rmistry@google.com Add Tecno Spark3 Pro devices to the tree 2019-06-04 michaelludwig@google.com Move GrPathUtils, GrRect, and GrShape into src/gpu/geometry/ Created with: gclient setdep -r src/third_party/skia@ac79ca16c651 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jcgregorio@google.com Change-Id: Ia037d71ead470caa6926caeafc85f2e1d6415e06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643322Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#665974}
-
Yao Xiao authored
The bug: multiple downloads protection is bypassed when there are multiple <a download> download attempts and they end up triggering a x-origin redirect to another download. The cause: Each x-origin redirect following the <a download> is being treated as a navigation. (See DownloadManagerImpl::InterceptDownload() (NetworkService enabled), DownloadResourceHandler::OnRequestRedirected() (NetworkService disabled)). The navigation will hit DownloadRequestLimiter::TabDownloadState::DidStartNavigation that resets some state of the limiter, and future downloads won't be prevented. The solution: plumb |from_download_cross_origin_redirect| to NavigationRequest, and skip resetting the limiter state when the flag is true. Bug: 959640 Change-Id: I7d8aca09670be5258e149e34e3e6f2f3107442ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627209Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Yao Xiao <yaoxia@chromium.org> Cr-Commit-Position: refs/heads/master@{#665973}
-
James Cook authored
Fix implicit global, use of 'var', and binding a variable 'arguments'. Bug: none Test: browser_tests Change-Id: Ibfecdac67163f2b09e0c10ea9fc17696e1eaf1dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1641519 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#665972}
-
Caleb Rouleau authored
This is a reland of 4decd028 I deleted some change detector test cases that I think are unnecessary (since we already have the json output to look at). Original change's description: > [Perf waterfall] Set io_timeout to 4 hours. > > TBR=simonhatch@chromium.org > > Bug: 969819 > Change-Id: I772891cbfacaae9c6d0c233e2934e54826bec69c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1639576 > Reviewed-by: Caleb Rouleau <crouleau@chromium.org> > Commit-Queue: Caleb Rouleau <crouleau@chromium.org> > Auto-Submit: Caleb Rouleau <crouleau@chromium.org> > Cr-Commit-Position: refs/heads/master@{#665701} Bug: 969819 Change-Id: I9443072ace353596a652242815f28b9014cafb7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1639733 Auto-Submit: Caleb Rouleau <crouleau@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#665971}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/0f476788122d..2c48f24c7f88 git log 0f476788122d..2c48f24c7f88 --date=short --no-merges --format='%ad %ae %s' 2019-06-04 ehmaldonado@chromium.org git-cl: Report presubmit execution time. Created with: gclient setdep -r src/third_party/depot_tools@2c48f24c7f88 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:970113 TBR=agable@chromium.org Change-Id: I3861feba970a7a179e119d1050df3a164a27b159 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643320Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#665970}
-