GitLab

When Xlib handles events, it parses them from the wire format with
no way to get the wire data.  XProto will require the wire data to
parse events, so this CL switches the ownership of the event queue
from Xlib to XCB.  XCB does alter the event, but only by inserting
a 4-byte extended sequence number after the first 32 bytes of the
event, so it's easy to recover the wire event.

Caveats: now Xlib APIs like XNextEvent and XPending don't work, so
all usages need to be switched over to use x11::Connection.  New
functionality like x11::Connection::ReadResponses are added to
take over this responsibility.  I tried to audit all usages of these
functions, but it's possible I may have missed some.

Finally, to facilitate a gradual transition from Xlib to XProto,
we'll need to temporarily have both XEvents and x11::Events.  But
the only way to get Xlib to parse an event from the wire format
is to use _XEnq, which is part of the private API.  This is
unfortunate, but it's the only way to get it working AFAIK, and I
don't think it's likely the _XEnq interface will change anyway.

Followup CLs will add an XProto event parser and start switching
things over.

BUG=1066670
R=nickdiego,sky
CC=​msisov

Change-Id: I1601a311a3ed73207858a01e0d2fa91ae83f56a9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220635Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Nick Yamane <nickdiego@igalia.com>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Auto-Submit: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#775744}

The test seems to not be flaky any more with improvements made to the
web test harness for site isolation. If wrong.. we can revert and
investigate.

Local run of 20 runs had 0 failures and TestExpectations claims it was
very flaky.

R=vmpstr@chromium.org

Bug: 891427
Change-Id: Ia1f35a741436042a14f79a0df4e01e4dc76ff829
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2232747Reviewed-by: vmpstr <vmpstr@chromium.org>
Commit-Queue: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#775743}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/d27e40cf55af..cf2d770d51db

2020-06-05 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/depot-tools-chromium-autoroll
Please CC agable@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: agable@chromium.org
Change-Id: Ie5a248ad71e332c150ae0c57459b1f63b1bcf84f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2232794Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#775742}

Bug: 1090033
Change-Id: I98baf2c718ce8fdfcc019891091ae8a59b95a466
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227293
Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#775741}

https://boringssl.googlesource.com/boringssl/+log/2309f645e509507a1cc8f9845771110fcf986fd9..88024df12147e56b6abd66b743ff441a0aaa09a8

Bug: none
Change-Id: I89e991a99d88123bbbcaccd71fdba66383ba64af
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231590
Commit-Queue: David Benjamin <davidben@chromium.org>
Commit-Queue: Steven Valdez <svaldez@chromium.org>
Auto-Submit: David Benjamin <davidben@chromium.org>
Reviewed-by: Steven Valdez <svaldez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#775740}

This change implements support for persistent permissions in
SerialChooserContext and assigns devices a persistent ID based on the
Windows "device instance ID" path. This is the path used internally by
the Windows Plug-and-Play infrastructure to track the identity of
devices.

Unlike the Web Bluetooth or WebUSB APIs we cannot only use properties
provided by the device because there is not a consistent transport for
serial devices. UARTs that are part of the hardware platform especially
do not have useful identifiers. The operating system is aware of the
overall device tree and can provide something that is stable enough
for our purposes.

Bug: 908836
Change-Id: I98628278f16f57efa58c0e019687660c33a22c0c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231981Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org>
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#775739}

When two text nodes are shaped together (e.g., <span>foo</span><span>bar</span>),
we only use the first node's Font. If they have different Font objects,
then the FontFallbackList on the second node becomes stale.

This patch makes sure that when calling Font::ShouldSkipDrawing() on the
second node, we always use the up-to-date FontFallbackList, so that we
don't hit a DCHECK about stale FontFallbackList.

Bug: 1050564
Change-Id: I92db1875faebb7311a179d70512b413b43f408aa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231905
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Reviewed-by: Dominik Röttsches <drott@chromium.org>
Cr-Commit-Position: refs/heads/master@{#775738}

The LiteVideoHintcache provides information per origin on whether
LiteVideos should be triggered and the target parameters for throttling
(via a LiteVideoHint).

A future change will use the LiteVideoHintCache to make a decision on
triggering the LiteVideo optimization.

Bug: 1088027
Change-Id: Iec191875f3f8a62a95e0d7203f339491ef0d81fc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222882
Commit-Queue: Michael Crouse <mcrouse@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: rajendrant <rajendrant@chromium.org>
Auto-Submit: Michael Crouse <mcrouse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#775737}

* weblayer_bundle_test
* weblayer_instrumentation_test_apk

Almost all the tests fail with ClassNotFoundException for the class
org.chromium.weblayer_private.WebLayerFactoryImpl

Bug: 1088013
Change-Id: Ieb1b90dcbbb73547b44f9de11762c10019ce29fd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2232810
Auto-Submit: Haiyang Pan <hypan@google.com>
Reviewed-by: Yuke Liao <liaoyuke@chromium.org>
Commit-Queue: Yuke Liao <liaoyuke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#775736}

Initializing WidgetDelegate's pointer to its Widget before adding the
root view to the Widget allows for using WidgetDelegate::GetWidget()
within an AddedToWidget handler, which is sometimes useful (eg the
linked bug).

Bug: 1038620
Change-Id: I561c959e14351e117189903c0b9ac3f3860a2515
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2233458
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Robert Liao <robliao@chromium.org>
Reviewed-by: Robert Liao <robliao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#775735}

This CL renames method ScrollIntoView() to ScrollAnnotationIntoView()
and changes the input params to take an annotation and a page index
instead of a rect. This change was needed as we have another caller
for ScrollAnnotationIntoView().

Bug: 1085614
Change-Id: I8cc6725944ab3e870865c3d47942721ea4e1c97d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228430Reviewed-by: Kevin Babbitt <kbabbitt@microsoft.com>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Ankit Kumar 🌪️ <ankk@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#775734}

Previously, this feature would cause the iframe element in the parent
document to be composited. With this change, the iframe need not be
composited, but the inner LayoutView will be.

Change-Id: I9e3012969c755596acfbe597e18d29776f112b08
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231546Reviewed-by: Philip Rogers <pdr@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Commit-Queue: Stefan Zager <szager@chromium.org>
Cr-Commit-Position: refs/heads/master@{#775733}

Events on other tracks or events with explicit timestamps should not
emit a thread timestamp, as this timestamp is not reflective of their
track or timestamp.

Change-Id: I0c38488bbbb8f048151f971f68c5e4070109d14d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2233018
Commit-Queue: Eric Seckler <eseckler@chromium.org>
Auto-Submit: Eric Seckler <eseckler@chromium.org>
Reviewed-by: Stephen Nusko <nuskos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#775732}

This will make debugging bugs easier.
To enable these logs you need to enable VLOGS when launching chrome:
    --enable-logging=stderr --vmodule="assistant*=1"

Otherwise the observer will simply not be created.

Example output:

[<snip>] Assistant: OnInteractionStarted: Text interaction with query 'open Play Store'
[<snip>] Assistant: OnTextResponse: 'OK'
[<snip>] Assistant: OnHtmlResponse:
[<snip>] Assistant: OnSuggestionsResponse: { '👍', '👎',  }
[<snip>] Assistant: OnOpenAppResponse: with app 'com.android.vending'
[<snip>] Assistant: OnInteractionFinished: with resolution AssistantInteractionResolution::kNormal

Bug: b/157144814
Test: manually executed
Change-Id: I328cbf4b4372169f161a7309028f2e4911dfef99
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225249Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Commit-Queue: Jeroen Dhollander <jeroendh@google.com>
Cr-Commit-Position: refs/heads/master@{#775731}

Trying to run Widevine CDM on linux-chromeos is not supported
and will crash.
Previously this was disabled indirectly because the library
libc++.so.1 was missing, but now this library will be present
if the GN arg |use_cros_on_device_assistant = true| is set.

Test: Ensured Widevine is disabled on linux, and enabled when building for device
Change-Id: I886f6df806de079169ca1367fc81df7aee169fba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2232754Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Commit-Queue: Jeroen Dhollander <jeroendh@google.com>
Cr-Commit-Position: refs/heads/master@{#775730}

https://chromium.googlesource.com/openscreen.git/+log/c9201dd611b0..977bb0c2f35a

2020-06-05 jophba@chromium.org Fix openscreen.ci linux_arm64_debug bot

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/openscreen-chromium
Please CC jophba@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: chromium:1067809
Tbr: jophba@chromium.org
Change-Id: Id8fd47cbcce93908f3ba01f34030dc1c3f6c82f5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2232786Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#775729}

This test is flaky on Mac and Linux:
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=unit_tests%20(with%20patch)&tests=PrerenderTest.LinkManagerAddTwiceCancelTwice

TBR=ryansturm@chromium.org

Bug: 1087735
Change-Id: I2b1235e43423eed9585db89552c4ced769076311
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2232815Reviewed-by: Yi Gu <yigu@chromium.org>
Commit-Queue: Yi Gu <yigu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#775728}

Bug: 1091256
Change-Id: I244afe4d9735901937b39c0d0c554eddaf88eace
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2230493Reviewed-by: Richard Coles <torne@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#775727}

This adds a new fuzzing target for Advertisement parsing. Note that the
parsing is already running in a sandboxed utility process, but it's
still good to verify with a fuzzer that raw data handling does not have
any unexpected issues.

Bug: 1091349
Change-Id: I3b1af84e5144fb2e88531ee6dc342dfc6ddc661b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2203381Reviewed-by: Ken Rockot <rockot@google.com>
Reviewed-by: Alex Gough <ajgo@chromium.org>
Commit-Queue: Richard Knoll <knollr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#775726}

Add debug assertions against misuses of PolicyBundle in
self-assignment or self-modifying constructions.

This CL doesn't bring proper support of such scenarios, but should at
least make it more obvious that they're not supported (by documenting
it and by catching during automated tests).

Bug: none
Change-Id: Ie92cf76b4b95b4bf253651eb1544cc884116a511
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2232859Reviewed-by: Aya Elsayed <ayaelattar@google.com>
Commit-Queue: Maksim Ivanov <emaxx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#775725}

This CL reverses a change made in Chromium 83 that changed all selected
text to color:black.

Bug: 1074752
Change-Id: Ia705305ff746672454233427d32f0e906f1f0e28
Cq-Do-Not-Cancel-Tryjobs: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231461
Commit-Queue: Mason Freed <masonfreed@chromium.org>
Reviewed-by: Ionel Popescu <iopopesc@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#775724}

This is a reland of 7a213fda

Deflaked the test by adding a missing RunLoop and having more robust
detection in the OutgoingVisualPropertiesIPCWatcher's, similar to the
pattern we see in VisualPropertiesPropagation_VisibleViewportSize.

Original change description:
> Add window segments concept to the content layer
>
> This change adds a the window segments concept to the
> SynchronizeVisualProperties cascade. A display feature splits a view by,
> e.g., a fold or a mask - an accessor is added to RenderWidgetHostViewBase
> to provide this information during the calculation of visual properties.
> When the root render widget is split by the display feature, there are
> multiple 'window segments' that web authors will be able to use to split
> their view and have a logical separation of content (either through
> JavaScript or CSS).
>
> The root widget window segments are computed by the root
> RenderWidgetHostImpl, based on the display feature on the
> RenderWidgetHostView. The segments are then propagated to child local
> frame roots via RenderFrameProxy and CrossProcessFrameConnector via the
> new member on VisualProperties.
>
> Follow-up changes will finish hooking this information up to Blink in
> order to expose it to the web, and also integrate with the platform
> specific APIs in order to get the display feature information from the
> underlying operating system.
>
> Explainers:
> https://github.com/webscreens/window-segments/blob/master/EXPLAINER.md
> https://github.com/MicrosoftEdge/MSEdgeExplainers/blob/master/Foldables/explainer.md
>
> i2p:
> https://groups.google.com/a/chromium.org/d/msg/blink-dev/_1_ljYsaqrU/qOoHJ7MhAgAJ
> https://groups.google.com/a/chromium.org/d/msg/blink-dev/KsPRO3hkOGw/md4jgIAaAgAJ
>
> Bug: 1039050 1039051
> Change-Id: I6805cda5946bd5379ad6dcd68e092e5d7d9be42d
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2205123
> Commit-Queue: Daniel Libby <dlibby@microsoft.com>
> Reviewed-by: danakj <danakj@chromium.org>
> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#773545}

TBR=kinuko@chromium.org

Change-Id: Ieb1d01d917fc75c84d01a37c455a7f12b836875f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229668
Commit-Queue: Daniel Libby <dlibby@microsoft.com>
Reviewed-by: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#775723}

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Tbr: perfetto-bugs@google.com
Change-Id: Id9f4a0e3d7fe9d23da04fa07efe2035317519060
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2232823Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#775722}

This CL copies site settings related proguard flags from Chrome's
proguard.flags file to WebView's. These missing flags would cause
site settings to crash on launch when the webview provider was
trichrome or system webview.

Bug: 1087880
Change-Id: I24957f945ea37aa8d74e191b8679758e1c234966
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219601Reviewed-by: Sam Maier <smaier@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Reviewed-by: Finnur Thorarinsson <finnur@chromium.org>
Commit-Queue: Robbie McElrath <rmcelrath@chromium.org>
Cr-Commit-Position: refs/heads/master@{#775721}

In preparation for the Windows native spell checker integration launch
experiment, there are certain important histograms that need to be
extended for the duration of the experiment. We want to make sure that
the Windows native spell checker integration does not regress spell
check quality for users, and the ratios of misspelled words, suggestion
hit and word replacement are great indicators of that.

Since these histograms were still in the internal list for historical
reasons, I am moving them to the open source repo to extend them.

See the launch bug for more info:
crbug.com/978460

Bug: 978460
Change-Id: Iced9122820b1404ec0f442ef1bd9d4e997817961
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2232768Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Commit-Queue: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#775720}

This test currently has a large number of cheap style resolves, which
is not appropriate for testing MatchedPropertiesCache effectiveness.

Hence this CL makes each style much more expensive by adding an
all:unset declaration. Also, the number of elements have been scaled
back such that the running time of the performance test stays
reasonable.

Bug: 1057072
Change-Id: Ib025d8d6b064d3924e4bc2d11285dc07d3949536
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231350Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org>
Cr-Commit-Position: refs/heads/master@{#775719}

This change makes 'only' behave like any other <custom-ident>.

The used color-scheme is now matching the preferred if listed, but can
also be 'dark' if 'light' is the preferred color-scheme but the computed
color-scheme only contains 'dark'.

These changes are per resolution[1]. Also improves interop with Safari.

Intent to ship: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/3RhZFvZE1LM
[1] https://github.com/w3c/csswg-drafts/issues/3881#issuecomment-634799613

Bug: 1087115
Change-Id: I1b7aa199c0dab665ec72703c201ddc2831233cd3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218828
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Cr-Commit-Position: refs/heads/master@{#775718}

Update the text based on translation feedback.

1) Add a space after "Google Chrome".
2) Avoid mention 'Chrome' when talking about channel.

Bug: 1076560
Change-Id: If8de47512a76545c274bcf198308ec34b4d93751
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2230226Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Commit-Queue: Owen Min <zmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#775717}

The test is flaky under virtual/cors/ test suite. See linked bug for
details.

NOTRY=true
TBR=ricea@chromium.org

Bug: 1091250
Change-Id: Ie5f6f6200623006557db3b32ec6fcd13e3bce314
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2232812Reviewed-by: Yi Gu <yigu@chromium.org>
Commit-Queue: Yi Gu <yigu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#775716}

https://skia.googlesource.com/skia.git/+log/cd75b17943ab..9f7485b4bbeb

2020-06-05 senorblanco@chromium.org Dawn: fix unsupported writePixels mode and test.
2020-06-05 johnstiles@google.com Pass input stage color to child processors.
2020-06-05 senorblanco@chromium.org Dawn: fix for crash on GrContextFactory_sharedContexts unit test.
2020-06-05 herb@google.com remove forceW system
2020-06-05 kjlubick@google.com [canvaskit] Add MacOS specific notes for setup

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC tdenniston@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: tdenniston@google.com
Change-Id: I5a3209f0b160911ff5c2cdebc4c517284b51c82b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2232790Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#775715}

This CL does the following things:
(1) Create a structure which defines the hotseat state transition, such
as the transition between the home launcher state and the hidden state.
Implement the member function of HotseatWidget to calculate the state
transition.

(2) Add a new enum type to HotseatState to indicate the empty state.

(3) Refactor the code block which layouts the hotseat widget so that
the hotseat animation is set only when the animation is used.

This CL should not introduce any noticeable difference.

Bug: 1042911
Change-Id: Ied8997e8e25b67e954620b95d83e59247b3155c7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231257Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Andrew Xu <andrewxu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#775714}

This change adds a metric that calculates the amount of time WebView
spends on different frequencies.

Bug: b/157855323
Change-Id: Ibb1fa61cc2ba1479f2b76ef642dc03c64a9a14b5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231452Reviewed-by: Mikhail Khokhlov <khokhlov@google.com>
Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#775713}

This patch makes empty editable flex box to have height to pass the test[1]
for enabling EditingNG.

In legacy layout, this is implemented in |LayoutFlexibleBox::LayoutFlexItems()|
  if (HasLineIfEmpty()) {
    // Even if ComputeNextFlexLine returns true, the flexbox might not have
    // a line because all our children might be out of flow positioned.
    // Instead of just checking if we have a line, make sure the flexbox
    // has at least a line's worth of height to cover this case.
    LayoutUnit min_height = MinimumLogicalHeightForEmptyLine();
    if (Size().Height() < min_height)
      SetLogicalHeight(min_height);
  }

Note: CL[2] introduces |LayoutBox::LogicalHeightForEmptyLine()| by extracting
from |MinimumLogicalHeightForEmptyLine()|

[1] fast/events/key-events-in-editable-flexbox.html
[2] http://crrev.com/c/2232242 [EditingNG] Introduce LayoutBox::
LogicalHeightForEmptyLine()

Bug: 707656
Change-Id: I1d8071902027b42203238f464e0caef332b401cd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2230552
Commit-Queue: Christian Biesinger <cbiesinger@chromium.org>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Auto-Submit: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#775712}

Add debug assertions against misuses of PolicyMap in self-assignment or
self-modifying constructions.

This CL doesn't bring proper support of such scenarios, but should at
least make it more obvious that they're not supported (by documenting
it and by catching during automated tests).

Bug: none
Change-Id: I9e8a60e48986fd5e3b61b15792b2a24cd6067b9e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2233238
Commit-Queue: Maksim Ivanov <emaxx@chromium.org>
Reviewed-by: Aya Elsayed <ayaelattar@google.com>
Cr-Commit-Position: refs/heads/master@{#775711}

Add an additional 'Unsubscribe anytime' to the end of the string
that is shown to users on the last screen of OOBE.

TBR=antrim@chromium.org

Bug: 1091304
Change-Id: I05ad88e0613b9eb73c85b1d06ec0110a26fcc75a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2232769Reviewed-by: Renato Silva <rrsilva@google.com>
Commit-Queue: Renato Silva <rrsilva@google.com>
Cr-Commit-Position: refs/heads/master@{#775710}

Creates a field trial to control the SplitSettingsSync feature. The
trial is client controlled because SplitSettingsSync controls the
out-of-box experience (OOBE) sync consent dialog, which shows up
before a variations seed is available.

The trial group chosen on first run is persisted to local state prefs
and reused on subsequent runs. This keeps the in-session sync settings
UI stable between runs. Local state prefs can be reset via powerwash,
which will result in re-randomization, but this also sends the user
through the first-run flow again and they will see the appropriate
consent flow.

Bug: 1090989
Test: Went through OOBE, verified trial group is random then persists

Change-Id: I241407a47179ddeed1da06f2aa1189fac936c70f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2230771
Commit-Queue: James Cook <jamescook@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#775709}

No change to logic. This componentizes ReportAboutFlagsHistogram (which
is responsible for logging the Launch.FlagsAtStartup and
Login.FlagsAtStartup histograms). This will be used later by Android
WebView to log a similar histogram.

This does not componentize AboutFlagsHistogramTest because this still
depends on iterating over Chrome's kFeatureEntries list.

Bug: 1084178
Test: unit_tests -f 'AboutFlagsHistogramTest.*'
Change-Id: If9f0f844d1e3b8e9dd7b4b7207b6c82996d88d86
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231446
Commit-Queue: Theresa  <twellington@chromium.org>
Auto-Submit: Nate Fischer <ntfschr@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#775708}

The 'list-style-image' property accepts an <image> value to be used as
the marker image for the list item. The problem was when specifying a
linear-gradient(), which has no intrinsic sizes. It would initially be
sized using half of the font ascent, but when dynamically changing the
'zoom' property, it would become 300x150.

This patch fixes it by changing LayoutImageResourceStyleImage::ImageSize
to use custom default sizes for list markers.

BUG=1091289

TEST=external/wpt/css/css-lists/list-style-image-zoom-dynamic.html

Change-Id: I746e2421ffb329df884457f0f973b30280fb23b3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2230475
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#775707}

The is_svg was added to separate out svg image classification. But
svg images are classified using same mechanism which is used for other
image types. Current usage of is_svg is just set and check in tests.
As this not the extracted feature, in image classification, it is
neither used in decision tree nor in NN model. This patch removes it.

Bug: 1091095

Change-Id: I6e4cdc49e1d5f54278e16194fa505f4d24d38acf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2170748
Commit-Queue: Prashant Nevase <prashant.n@samsung.com>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#775706}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/73c5db6dfb0c..e32669d4cb17

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC yigu@google.com,tbansal@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: yigu@google.com,tbansal@google.com
Change-Id: If7607fb106560853b319866406fb3feac6f4693e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2232782Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#775705}