GitLab

BUG=143302
TEST=desktopui_DocViewing should be green in chromeos BVT

R=craigdh@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10836303

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152005 0039d316-1c4b-4281-b951-d872f2087c98

BUG=138139
TEST=none


Review URL: https://chromiumcodereview.appspot.com/10827280

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152004 0039d316-1c4b-4281-b951-d872f2087c98

I'm in the process of adding a new option to the gcc compiler in ChromeOS, that does vtable pointer verification before virtual method calls.  The new compiler flag is "-fvtable-verify=std" or "-fvtable-verify=preinit".  I'm modifying the Chrome ebuild flag in Chrome OS to allow "USE=vtable_verify" and which causes 'use_vtable_verify' to be defined and set to 1. 

In this CL I have modified common.gypi to add the compiler flag '-fvtable-verify=std' if it sees use_vtable_verify set to 1; and I have modified allocator.gyp to change '-fvtable-verify=std' into '-fvtable-verify=preinit' (tcmalloc stuff requires this special flag).


BUG=
TEST=Built Chrome with GYP_DEFINES=use_vtable_verify=1


Review URL: https://chromiumcodereview.appspot.com/10854031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152003 0039d316-1c4b-4281-b951-d872f2087c98

R=bauerb@chromium.org
TBR=phajdan.jr@chromium.org
BUG=139028
TEST=None


Review URL: https://chromiumcodereview.appspot.com/10796116

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152002 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152001 0039d316-1c4b-4281-b951-d872f2087c98

R=groby@chromium.org
BUG=None


Review URL: https://chromiumcodereview.appspot.com/10855066

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152000 0039d316-1c4b-4281-b951-d872f2087c98

Run the disk cache tests in scoped temporary directories instead of a fixed directory so that they can run in parallel.

BUG=139272
Review URL: https://chromiumcodereview.appspot.com/10824336

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151999 0039d316-1c4b-4281-b951-d872f2087c98

BUG=96123
TEST=manual & run pyauto tracing smoke tests


Review URL: https://chromiumcodereview.appspot.com/10855062

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151998 0039d316-1c4b-4281-b951-d872f2087c98

BUG=


Review URL: https://chromiumcodereview.appspot.com/10825368

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151997 0039d316-1c4b-4281-b951-d872f2087c98

Notify the Chrome metro driver component when a full screen toggle is occurring. The metro driver in its notification
would restore the original scroll position if the window was scrolled because it was covered by the OSK.

BUG=142439
R=sky
Review URL: https://chromiumcodereview.appspot.com/10823376

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151996 0039d316-1c4b-4281-b951-d872f2087c98

These cleanup changes were pulled out from:
http://codereview.chromium.org/10834203

Use the cloud print device displayName instead of name.
(these are editable names shown on the cloud print dash)
Call NOTREACHED on any task posting failure.
Extract UpdateCommandState utility function.
Rename & refactor RefreshAccessToken->RequestAccessToken.
Rename RequestSearch->RequestDeviceSearch.
Make HasMobiles const; consolidate access_token_ DCHECKs.
Misc comment updates.

BUG=102709
TEST=No Chrome To Mobile regressions, device display names reflected.

Review URL: https://chromiumcodereview.appspot.com/10828353

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151995 0039d316-1c4b-4281-b951-d872f2087c98

The address of the adapter is often not present at the initial call to
ChangeAdapter (it hasn't been fetched yet), so it must be updated along
with other properties when an update notification is received.

BUG=none
TEST=manual


Review URL: https://chromiumcodereview.appspot.com/10823371

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151994 0039d316-1c4b-4281-b951-d872f2087c98

ManagedModeURLFilter will eventually allow special treatment (e.g. blocking, notifying) for URLs that aren't on a defined whitelist.

BUG=134417


Review URL: https://chromiumcodereview.appspot.com/10824257

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151993 0039d316-1c4b-4281-b951-d872f2087c98

This is needed to make it easier to handle sets of extension icons that are not
defined in extension manifest (e.g. default icons for browser_actions)

BUG=138025,  135271
TEST=existing tests

For mechanical changes caused by moving ExtensionIcons from ExtensionIconSet to extension_misc namespace (patchset 14):
TBR=ben@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10843014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151992 0039d316-1c4b-4281-b951-d872f2087c98

run_webkit_tests doesn't like Content-Length: 0 headers

BUG=none
TEST=none


Review URL: https://chromiumcodereview.appspot.com/10836291

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151991 0039d316-1c4b-4281-b951-d872f2087c98

Toast flavors 0 and 1 are affected because we dereference a null pointer

BUG=129499
TEST=see bug
TBR=sky@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10836298

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151990 0039d316-1c4b-4281-b951-d872f2087c98

Added ifdefs around NSRect, added iOS to gyp.

BUG=None.


Review URL: https://chromiumcodereview.appspot.com/10834362

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151989 0039d316-1c4b-4281-b951-d872f2087c98

BUG=141429


Review URL: https://chromiumcodereview.appspot.com/10854151

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151988 0039d316-1c4b-4281-b951-d872f2087c98

Revert 151932 (caused gpu_throughput_tests to start failing on Mac GPU bots) - Hook up Mac OSX VSync parameters to compositor thread

Also fixes precision error on Windows.

BUG=137794

Review URL: https://chromiumcodereview.appspot.com/10830347

TBR=jbates@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10825406

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151982 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151979 0039d316-1c4b-4281-b951-d872f2087c98

This pulls in the following Native Client changes:

r9435: (shcherbina) Validator_ragel: move checkdecoder test from Makefile to scons
r9436: (halyavin) Remove commented out code.
r9437: (dschuff) Update pnacl TC revision to 9432
r9438: (kschimpf) Define baseline classes for instruction in table simd_dp of ARM validator.
r9439: (jvoung) Actually ignore -export-dynamic flag from rev r9423, instead.
r9440: (jvoung) Bump gold rev to pull in Tdata change and llvm for cherry pick:
r9441: (bradchen) Update enuminsts/ragel_tester.c to fully check base register usage.
r9442: (mcgrathr) Extend fpu_control_word test for ARM
r9443: (mseaborn) Fix compile-time assertions to check what was intended
r9444: (bsy) LOG_FATAL if NACL_EXE_STDERR style I/O redirection fails. handle /dev/null.
r9445: (mseaborn) Cleanup: Remove unused #defines of "_WINDOWS" and "_CONSOLE"
r9446: (mseaborn) x86-32: Cleanup: Remove "union PtrAbstraction"
r9447: (phosek) Make the NaClVmmapUpdate internal and provide NaClVmmapAddWithOverwrite and NaClVmmapRemove public interface
r9448: (mseaborn) Debug stub: Remove std_types.h, which duplicates NaCl's portability.h
r9449: (mseaborn) Debug stub: Remove unused IPlatform::CreateThread() function
r9450: (mseaborn) Debug stub: Cleanup: Remove IPlatform::Log*() functions
r9451: (mseaborn) Cleanup: Remove unneeded NaClOopDebugger*() hook functions
r9452: (halyavin) Update cygwin version which includes latest crash fixes.
r9453: (halyavin) Update scripts to include new cygwin core libraries snapshot.
r9454: (shcherbina) Validator_ragel build script: properly call python on windows
r9455: (jvoung) Update pnacl version to 9453.
r9456: (jvoung) Add pnacl precise bot to trybots list.
r9457: (khim) Add options argument to the ValudateChunk{AMD64,IA32} function.
r9458: (mcgrathr) Save and restore FPSCR register in ARM trusted<->untrusted context switch
r9459: (mseaborn) Cleanup: Remove NaClAppThread's unused "sysret" field
r9460: (mseaborn) Debug stub tests: Remove disabled pyauto-based browser test
r9461: (khim) Initialize variables in the decoder
r9462: (sehr) Add an API to MCSectionData that tracks known offsets for text emitted into a
r9463: (phosek) Removed NaClMemObj because it is no longer needed and replaced its use with enumerator.
r9464: (jfb) Refactor ARM validator register interfaces.
r9465: (shcherbina) Validator_ragel: factor out ProcessInvalidJumpTargets
r9466: (mseaborn) Debug stub: Switch to a thread-suspension-based model for catching faults
r9467: (mseaborn) Cleanup: Use "#if NACL_WINDOWS" instead of #ifdefs on WIN32 or _WIN32
r9468: (dschuff) Build LLVM from gerrit instead of hg/codesite
r9469: (jvoung) Update llvm rev to pull in revert of MC changes:
r9470: (dschuff) Dont auto-update depot tools when getting pnacl DEPS.
r9471: (noelallen) Fix PyAuto issues on integration bots.
r9473: (mcgrathr) Do not leak VFP/NEON register state to untrusted code
r9474: (mseaborn) Debug stub test: Ignore "Access denied" error from terminating sel_ldr
r9475: (mseaborn) Debug stub: Remove the now-unused IEvent class
r9476: (halyavin) Fix modifying parameters in CommandSelLdrTestNacl.
r9477: (kschimpf) Don't allow rex.w and data 66 prefixes for instructions with default 64 size.
r9478: (ncbray) Fix bug where SConstruct choked on failiures with multiple outputs.
r9479: (dschuff) Add script for merging in LLVM git repo
r9480: (bradnelson) Revert 9471 - Fix PyAuto issues on integration bots.
r9482: (dschuff) add git-has-changes back to common-tools.sh
r9483: (mseaborn) Cleanup: Remove unused "tools/tests" directory and CommandGdbTestNacl()
r9484: (jvoung) Add 1 elem structs to the calling conv test (mainly to test
r9485: (mseaborn) Thread suspension: Remove unused SuspendAllButOne()/ResumeAllButOne() functions
r9486: (phosek) The protection for anonymous mapping is stored incorrectly.
r9487: (khim) Refactoring the R-DFA validator interface.
r9488: (shcherbina) Validator_ragel dfacheckdecoder: change binutils revision
r9489: (mseaborn) Debug stub: Disallow memory accesses outside of the sandbox address space
r9490: (dschuff) Update Pnacl toolchain revision to 9476
r9491: (khim) Disable branch prediction prefixes for loop/loope/loopne.
r9492: (kschimpf) Make loop a conditional jump, and don't allow branch hints on loop, loope,
r9493: (bradnelson) Prefer SCons environment methods for functions acting on environments.
r9494: (mseaborn) x86-64: Undo removal of the "unused_padding" field from r9443

BUG=none
TEST=nacl_integration

Review URL: https://chromiumcodereview.appspot.com/10854186

TBR=mseaborn@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10832353

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151978 0039d316-1c4b-4281-b951-d872f2087c98

Reason for revert: See bug 143214. CredentialCacheService::GetLastUpdatedTime() is causing a crash in canary builds during upgrade scenarios from older versions. A real fix for the root cause is under review. The earlier revert in https://chromiumcodereview.appspot.com/10830362 is unlikely to fix the root cause. Until then, the safe thing to do is to disable the feature, by reverting r151169.

Original CL description:

Sync credential caching is a Win 8 feature that allows Metro and Desktop
to share sync credentials under some circumstances. The feature is
slated to ship with M23, and was disabled for the M22 branch point.
Now that M22 has been branched off, it is time to re-enable the feature.

This patch turns on the feature by default, and provides users with the
"--disable-sync-credential-caching" flag if the feature must be disabled.

BUG=139712,143214
TEST=Sign in on Win 8 and make sure that "Sync Credentials" is written to the default profile directory
Old review URL: https://chromiumcodereview.appspot.com/10855063

TBR=tim@chromium.org,zea@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10836297

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151976 0039d316-1c4b-4281-b951-d872f2087c98

This should get rid of the spurious ERROR messages when closing tabs, and log backtraces when we need them.

BUG=141055


Review URL: https://chromiumcodereview.appspot.com/10834355

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151975 0039d316-1c4b-4281-b951-d872f2087c98

Currently planning 6 steps for this feature:
1. (this step) Create/delete shortcuts in general (few edge cases)
2. Add functionality for the checkbox- allow the user to select whether they want a shortcut or not from the create/manage profile dialogs
3. Find shortcuts on the desktop by their arguments instead of the path.
4. Handle edge case of 1 to 2 and 2 to 1 profiles (adding/removing icon and name from the shortcut)
5. Update shortcuts when the user changes their name/icon
6. Repopulate shortcuts map when browser starts up (to allow delete/update on new browser instances) 

This CL depends on: Issue 10826188

BUG=133585
TEST=manual testing

Review URL: https://chromiumcodereview.appspot.com/10823217

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151974 0039d316-1c4b-4281-b951-d872f2087c98

The host process is launched in in two steps now. An instance of remote_service.exe is launched in a user session (CreateProcessAsUser) and then it launches the host requesting elevation (ShellExecuteEx). This is needed because Windows 8 refuses to inject Alt+Tab unless uiAccess='true' is specified in the manifest, which in its turn requires ShellExecuteEx() to be used.

Lifetime of launched processes is controlled by assigning them to a job object.

Message loop changes are required to be able to process job object notifications on the I/O message loop.

BUG=135217

Review URL: https://chromiumcodereview.appspot.com/10831271

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151973 0039d316-1c4b-4281-b951-d872f2087c98

This makes the ImageSkia resizing code mirror the SkBitmap resizing code more closely.

BUG=141146

Review URL: https://chromiumcodereview.appspot.com/10823358

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151972 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none


Review URL: https://chromiumcodereview.appspot.com/10829353

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151970 0039d316-1c4b-4281-b951-d872f2087c98

Also fixed several issues with managing chromoting from the webapp. Now it is
possible to start the app and change PIN.

BUG=120950

Review URL: https://chromiumcodereview.appspot.com/10824286

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151969 0039d316-1c4b-4281-b951-d872f2087c98

BUG=122753

Review URL: https://chromiumcodereview.appspot.com/10836296

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151968 0039d316-1c4b-4281-b951-d872f2087c98

Track crashes when running the s/w rasterizer separately. Also fix an off
by one error in the crash counts.

BUG=


Review URL: https://chromiumcodereview.appspot.com/10825378

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151966 0039d316-1c4b-4281-b951-d872f2087c98

Also, add OWNERS file

BUG=none
TEST=no spam on console


Review URL: https://chromiumcodereview.appspot.com/10827372

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151965 0039d316-1c4b-4281-b951-d872f2087c98

Add the ability to build and run Linux host changes.
Add the ability to specify which version of the example to run.
Prints a warning the TOOLCHAIN and/or CONFIG specified are invalid.

Review URL: https://chromiumcodereview.appspot.com/10827363

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151964 0039d316-1c4b-4281-b951-d872f2087c98

The smoke test is simple - it checks that Chrome can load nexes. The more
interesting part of this CL is that it lays the groundwork for adding more NaCl
tests to browser_tests. This will allow many nacl_integration tests to be
rewritten as browser_tests. This CL adds an extensible jig for decoding
messages from Javascript, which makes it easier to add test logic in the web
page. This CL also establishes locations in the build directory for nexes and
other test data.

There are two followup CLs planned: 1) simplify how nexes are built in GYP
and 2) share the code for running tests in Javascript with the PPAPI test
suite.

This is a recommit of r151716 with Linux ASAN tests disabled and GYP tweaks for
VS2010.

BUG= http://code.google.com/p/nativeclient/issues/detail?id=2959
TEST= browser_tests --gtest_filter=NaClBrowserTest*

Review URL: https://chromiumcodereview.appspot.com/10827357

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151963 0039d316-1c4b-4281-b951-d872f2087c98

BUG=143209

Review URL: https://chromiumcodereview.appspot.com/10854169

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151962 0039d316-1c4b-4281-b951-d872f2087c98

BUG=115482


Review URL: https://chromiumcodereview.appspot.com/10837255

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151961 0039d316-1c4b-4281-b951-d872f2087c98

BUG=141537
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/10831249

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151959 0039d316-1c4b-4281-b951-d872f2087c98

BUG=130222
TEST=unittest & browser_test

Review URL: https://chromiumcodereview.appspot.com/10692160

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151956 0039d316-1c4b-4281-b951-d872f2087c98

BUG=142966
TEST=dunno repro steps; hope we crash less


Review URL: https://chromiumcodereview.appspot.com/10831340

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151955 0039d316-1c4b-4281-b951-d872f2087c98

BUG=141146

Review URL: https://chromiumcodereview.appspot.com/10830341

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151954 0039d316-1c4b-4281-b951-d872f2087c98

BUG=143013

Review URL: https://chromiumcodereview.appspot.com/10855191

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151953 0039d316-1c4b-4281-b951-d872f2087c98