GitLab

R=scottmg@chromium.org

Review URL: https://codereview.chromium.org/336633002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276773 0039d316-1c4b-4281-b951-d872f2087c98

This is forked off of https://codereview.chromium.org/266613002 The code to compile yasm itself is mostly from that patch, with a few updates for the other changes.

Adds a template for running compiled binaries. Compared to Albert's patch above, this assumes the binary is generated by the source tree so can have a cleaner interface (just specify the label of the tool you use).

The yasm rule is new compared to Albert's patch. It uses a special wrapper script instead of the new compiled_action templates so it can properly support depfiles. This also adds convenient support for defines and include dirs.

This adds some trivial ios changes to the content/public/browser. This should be a NOP now.

Fixes a bug in GN depfile creation. Previously, the .d file was emitted as an output of the script, but this confuses ninja. This change just removes that.

BUG=
R=ajwong@chromium.org

Review URL: https://codereview.chromium.org/321323004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276772 0039d316-1c4b-4281-b951-d872f2087c98

Previously, when a user blacklisted an iPhoto/iTunes library, there was no way to get it back without editing the preferences file by hand.

Now, when a user adds a directory under the iPhoto/iTunes library directory, it adds back the device library.

BUG=375503
TEST=manual tested iTunes on Win

Review URL: https://codereview.chromium.org/329643002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276771 0039d316-1c4b-4281-b951-d872f2087c98

Unit test for the fix submitted with https://codereview.chromium.org/316553007

BUG=375921

Review URL: https://codereview.chromium.org/316403004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276770 0039d316-1c4b-4281-b951-d872f2087c98

BUG=378549

Review URL: https://codereview.chromium.org/329833002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276769 0039d316-1c4b-4281-b951-d872f2087c98

Note that this doesn't apply to roots. If an app is embedded and its root node is reordered, there is no notification to the app. I figure this is up to the window manager to expose an API for this type of thing.

R=sky@chromium.org
http://crbug.com/365012

Review URL: https://codereview.chromium.org/327073003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276768 0039d316-1c4b-4281-b951-d872f2087c98

R=rouslan@chromium.org
TBR=rouslan@chromium.org
NOTRY=true
NOTREECHECKS=true
BUG=383975

Review URL: https://codereview.chromium.org/327323011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276767 0039d316-1c4b-4281-b951-d872f2087c98

TBR=antrim@chromium.org
NOTRY=true
NOTREECHECKS=true

Review URL: https://codereview.chromium.org/337573002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276766 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Introduce SessionManager that will contain code to start user session on Chrome OS (https://codereview.chromium.org/318853004/)

Reason for revert:
Appears to have broken the kiosk and auth browser tests in http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29/builds/30916

Original issue's description:
> Introduce SessionManager that will contain code to start user session on Chrome OS
> 
> Move profile creation / session initialization (prefs/RLZ) as well as some of OAuth session init
> related code from LoginUtils to SessionManager. LoginUtils will temporarily implement
> SessionManager::Delegate interface till existing test coverage is migrated from LoginUtils interface.
> SessionManager will later use concept of UserSession (see design proposal at http://goto/cros-login-c14n).
> 
> LoginUtils::OnPrepareProfile() is split into
> StartSession()
> --PreStartSession() - things like switching logging dest
> --CreateUserSession() - will eventually create UserSession instance
> --StartCrosSession() - notify cros::SessionManager
> --NotifyUserLoggedIn() - UserManager::UserLoggedIn()
> --PrepareProfile()
> 
> PrepareProfile() - calls PM::CreateProfileAsync()
> --OnProfileCreated()
> ----InitProfilePreferences() - early initialization
> ----UserProfileInitialized()
> ------transfer signin profile auth date (cookies/proxy auth/certs)
> ------RestoreAuthSessionImpl() - OAuth2LoginManager::RestoreSession()
> ----FinalizePrepareProfile(()
> ------Own TPM (if it didn't happen for some reason)
> ------Notify SAML offline signin limiter
> ------Notify ProfileImpl
> ------chrome::NOTIFICATION_LOGIN_USER_PROFILE_PREPARED
> ------InitRLZ (for primary user)
>   
> 
> Minor cleanup
> * Unify DemoApp profile initialization flow with regular one
> * Don't pass display_email to LoginUtils::PrepareProfile
> * Move powerwash related prefs registration to ResetScreenHandler
> * Cleanup M31 migration code for |prefs::kProfileIsManaged| in LoginUtilsImpl::InitProfilePreferences()
> 
> BUG=370175,276163
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276626

TBR=antrim@chromium.org,bauerb@chromium.org,nkostylev@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=370175,276163

Review URL: https://codereview.chromium.org/328383003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276760 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276759 0039d316-1c4b-4281-b951-d872f2087c98

This pulls in the following Native Client changes:

r13310: (dyen) Commands for toolchain_build are now filtered before invoking anything.
r13311: (dyen) Fix for needing to push to ssh URL for toolchain_build sources.
r13312: (mcgrathr) Disable seccomp-bpf tests under ASan
r13313: (mcgrathr) Disable LSan (leak detection) in ASan tests
r13314: (mseaborn) Enable the -Wstrict-prototypes warning for untrusted code in the Gyp build
r13315: (dyen) Python logging now organized to use loggers instead of global variables.
r13316: (jfb) PNaCl: Update LLVM revision in pnacl/COMPONENT_REVISIONS
r13317: (jfb) Update revision for PNaCl r13281->r13311
r13318: (jfb) Update revision for PNaCl r13311->r13316
r13319: (mcgrathr) Fix leaks in gio tests
r13320: (mcgrathr) Fix leak of SRPC string argument template buffers
r13321: (dyen) Make sure git cache dir is not referenced directly in case of cygwin.
r13322: (noelallen) Roll bionic
r13323: (mcgrathr) Don't close stderr in ncval_stubout
r13324: (jvoung) Change torture_test.py to use toolchain_build/src instead of pnacl/git.
r13325: (mcgrathr) Use LC_ALL=C rather than LANG=en_US.UTF-8 in build_nexe.py
r13326: (mcgrathr) meaningless change to kick bots
r13327: (petarj) [MIPS] Accept SIGTRAP from __builtin_trap
r13328: (mseaborn) Untrusted Gyp build: Apply -Wstrict-prototypes to NaCl-side code only

BUG=none
TEST=browser_tests and nacl_integration
CQ_EXTRA_TRYBOTS=tryserver.chromium:linux_rel_precise32,linux_arm_cross_compile,linux_nacl_sdk_build

Review URL: https://codereview.chromium.org/333503006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276758 0039d316-1c4b-4281-b951-d872f2087c98

TBR=tonyg@chromium.org
NOTRY=true
BUG=

Review URL: https://codereview.chromium.org/334713002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276757 0039d316-1c4b-4281-b951-d872f2087c98

This is the first half of the work to disambiguate the message center
notifications originated from different profiles.
It clarifies the semantics of message center as the backend of
notification by:

1) Adding comments on the usage of id in the MessageCenter interface.
2) Adding a FindVisibleNotificationById(id) method to message center
interface so users can directly find backend notifications without
going to the notification ui manager interface.
3) Removing the redundant HasNotification() method since the
FindVisibleNotificationById() can server the same purpose. 

Reviewers:
* davemoore: please review chrome/browser/chromeos/*
* jamescook: please review ash/*

TBR=davemoore@chromium.org
BUG=297867

Review URL: https://codereview.chromium.org/324583002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276756 0039d316-1c4b-4281-b951-d872f2087c98

NOTRY=true

Review URL: https://codereview.chromium.org/330653002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276755 0039d316-1c4b-4281-b951-d872f2087c98

The behavior once invoked by the
SkPicture::kUsePathBoundsForClip_RecordingFlag is now
 the default so this flag is going away.
Skia 9f1c241e 
(Remove SkPicture::kUsePathBoundsForClip_RecordingFlag -
 https://codereview.chromium.org/316143003/)

cc: enne@
skia: fmalita@

Review URL: https://codereview.chromium.org/322123002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276754 0039d316-1c4b-4281-b951-d872f2087c98

cc side of change.

TBR=phajdan.jr@chromium.org
BUG=382738

Review URL: https://codereview.chromium.org/326283002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276753 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=covered
R=asvitkine@chromium.org, mark@chromium.org

Review URL: https://codereview.chromium.org/325423005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276752 0039d316-1c4b-4281-b951-d872f2087c98

This provides the Service Worker for the implementation of navigator.serviceWorker.waiting in Blink. This will be covered by subsequent layout tests in Blink.

BUG=379012

Review URL: https://codereview.chromium.org/317953004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276751 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276750 0039d316-1c4b-4281-b951-d872f2087c98

R=niklase@chromium.org

Review URL: https://codereview.chromium.org/329773004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276749 0039d316-1c4b-4281-b951-d872f2087c98

Particularly the '\\' in fileline_prefix would need to be '\\\\' in a
normal (non-raw) python string.

NOTRY=true

Review URL: https://codereview.chromium.org/330573003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276748 0039d316-1c4b-4281-b951-d872f2087c98

content_browsertests with Dr.Memory MFYI bot

TBR=thestig@chromium.org
BUG=NONE

Review URL: https://codereview.chromium.org/337553002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276747 0039d316-1c4b-4281-b951-d872f2087c98

This will be used on Clusterfuzz, and we might ship this on the Canary sometimes if the performances are reasonable.

BUG=

Review URL: https://codereview.chromium.org/321303002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276746 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
R=darin@chromium.org

Review URL: https://codereview.chromium.org/324823002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276745 0039d316-1c4b-4281-b951-d872f2087c98

Missing header include would result in symbols being defined locally
only.

TBR=spang@chromium.org
NOTRY=true
BUG=none

Review URL: https://codereview.chromium.org/335663002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276744 0039d316-1c4b-4281-b951-d872f2087c98

> Turn FaviconClient into a Keyed service.
> 
> This is an intermediary CL.
> The end goal is having the FaviconServiceFactory be able to obtain a FaviconClient to pass it to the FaviconService's constructor.
> 
> BUG=377505
> 
> Review URL: https://codereview.chromium.org/301613004

TBR=jif@chromium.org
BUG=383952

Review URL: https://codereview.chromium.org/334613004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276743 0039d316-1c4b-4281-b951-d872f2087c98

Enabled here: https://codereview.chromium.org/315713002/
Disable here: https://codereview.chromium.org/312303003/

BUG=332418
TEST=GestureRecognizerTest.*

Review URL: https://codereview.chromium.org/318853005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276742 0039d316-1c4b-4281-b951-d872f2087c98

Extend and use android_profiling_helper.py to set up a symfs for VTune.
Queries the required libraries from the profiler's output and pulls them from
the device. This allows VTune to resolve all symbols in the profiling output.

BUG=

Review URL: https://codereview.chromium.org/308123002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276740 0039d316-1c4b-4281-b951-d872f2087c98

The callback no longer receive an HistoryService::Handle as first parameter
and the caller should use the returned base::CancelableTaskTrasker::TaskId
to cancel a request early.

Instead of passing a CancelableRequestConsumer to the query, the caller
pass a base::CancelableTaskTracker. The lifetime of the callback can be
associated to the request by using base::Passed().

Remove unused types and fix usage of the values passed to the result
callback (check success before using the URLRow or the VisitVector).

BUG=371818
TBR=bauerb,sky,asargent,gavinp,shess,pkasting

Review URL: https://codereview.chromium.org/314293005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276739 0039d316-1c4b-4281-b951-d872f2087c98

BUG=368716

Review URL: https://codereview.chromium.org/302603004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276738 0039d316-1c4b-4281-b951-d872f2087c98

There's more optimization done on a PGO build than on a regular one, this results in some "Unreachable code" warnings that we don't see normally.

But probably anything that this would catch that wouldn't be caught in a normal build isn't going to actually be a bug, so the incremental value of C4702 for PGO builds is likely very small and blocks the setup of the PGO bots.

BUG=380175

Review URL: https://codereview.chromium.org/315323002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276737 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
R=dewittj@chromium.org

Review URL: https://codereview.chromium.org/315053006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276736 0039d316-1c4b-4281-b951-d872f2087c98

Reason for revert:
should be safe to land now

Original issue's description:
> Revert of Remove now obsolete checkdeps copy (https://codereview.chromium.org/307333003/)
> 
> Reason for revert:
> Still referenced from blink
> 
> Original issue's description:
> > Remove now obsolete checkdeps copy
> > 
> > BUG=none
> > R=brettw@chromium.org
> > 
> > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275419
> 
> TBR=brettw@chromium.org
> NOTREECHECKS=true
> NOTRY=true
> BUG=none
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275482

TBR=brettw@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=none

Review URL: https://codereview.chromium.org/334743002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276734 0039d316-1c4b-4281-b951-d872f2087c98

> Fix slop region boundary handling.
> 
> Ensure the screenPosition of touches is never truncated to an integer.
> 
> Check if the unified gesture detector is enabled before disabling
> the inclusive slop region.
> 
> BUG=381174
> TEST=RenderWidgetHostViewAuraTest.TouchEventPositionsArentRounded
> 
> Review URL: https://codereview.chromium.org/328733003

TBR=tdresser@chromium.org

Review URL: https://codereview.chromium.org/330613003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276732 0039d316-1c4b-4281-b951-d872f2087c98

Ensure the screenPosition of touches is never truncated to an integer.

Check if the unified gesture detector is enabled before disabling
the inclusive slop region.

BUG=381174
TEST=RenderWidgetHostViewAuraTest.TouchEventPositionsArentRounded

Review URL: https://codereview.chromium.org/328733003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276728 0039d316-1c4b-4281-b951-d872f2087c98

Shrinks the padding and image size for a smaller screen. As an added bonus, also improves RTL handling (blue button should swap sides).

BUG=381260,331453

Review URL: https://codereview.chromium.org/328293002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276727 0039d316-1c4b-4281-b951-d872f2087c98

The Ctrl-Shift-9 combination is used by Gmail to change formatting. Ctrl-Alt-P seems to be a viable alternative based on the discussion in the bug.

BUG=307661

Review URL: https://codereview.chromium.org/309293002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276726 0039d316-1c4b-4281-b951-d872f2087c98

Ensure that size passed into drag_utils_win.cc's SetDragImageOnDataObject function is in pixels and is obtained from the SkBitmap instance.

This is needed for the drag image to show up without being clipped.

Removed the size parameter from the drag_utils::SetDragImageOnDataObject functions as it is not needed. We can get the size from the ImageSkia object as needed.

BUG=381611
R=sky

Review URL: https://codereview.chromium.org/328993002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276725 0039d316-1c4b-4281-b951-d872f2087c98

After this change, if libppGoogleNaClPluginChrome.so is placed in the install
directory it correctly starts and attempts to create a subprocess.

BUG= https://code.google.com/p/nativeclient/issues/detail?id=3032
R=bradnelson@google.com, darin@chromium.org

Review URL: https://codereview.chromium.org/329853002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276724 0039d316-1c4b-4281-b951-d872f2087c98

This CL changes:
- "IsManaged" and similar methods in Profile, ProfileInfoCache, and a few other places (which mostly forward to either of those)
- Enum and constant names
- Variable names
- Comments

Still missing:
- I almost certainly missed a few variables and comments
- The actual SU implementation, i.e. c/b/managed_mode/
- JavaScript
- Resource names

But since this CL is already way too huge, I'll try to commit this part now and do the rest in one or more followup CLs.

TBR=thakis@chromium.org (chrome/)
TBR=rogerta@chromium.org (google_apis/)
TBR=haitaol@chromium.org (sync/ and components/sync_driver/)

All the TBRs are simple renames.

BUG=none

Review URL: https://codereview.chromium.org/316863002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276722 0039d316-1c4b-4281-b951-d872f2087c98