GitLab

According to the C++ standard, the three arguments overload
of std::string::assign accepts an std::basic_string:
http://en.cppreference.com/w/cpp/string/basic_string/assign

Fixing the usage, where char* instead of std::string was passed.

This popped up after libc++ became more standard compliant,
and now it throws a compiler error.

BUG=630681

Review-Url: https://codereview.chromium.org/2177653004
Cr-Commit-Position: refs/heads/master@{#407302}

BUG=
TEST=webgl2_conformance
TBR=qiankun.miao@intel.com
NOTRY=true
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2177653005
Cr-Commit-Position: refs/heads/master@{#407301}

Whether the reference was local or not was disregarded, meaning that
any URL with a valid fragment part could potential result in a valid
clip - regardless of whether it was local or not. I.e foo.svg#bar would
reference an element with the id 'bar' in the local document.

Check if the URL reference resolver flagged the reference as being local,
and only pass a non-null fragment if it was.

BUG=629826

Review-Url: https://codereview.chromium.org/2174813003
Cr-Commit-Position: refs/heads/master@{#407300}

This implements the 'local url' handling per:

  https://drafts.csswg.org/css-values/#local-urls

which is also referenced from:

  https://svgwg.org/svg2-draft/linking.html#linkRefAttrs

Most of the logic is handled by a new helper class named
SVGURLReferenceResolver, which keeps state, resolves the URL
and extracts the fragment identifier as needed.

BUG=470608

Review-Url: https://codereview.chromium.org/2174833002
Cr-Commit-Position: refs/heads/master@{#407299}

This CL continues implementing ImageCapture:

- adds |iso|, |imageHeight| and |imageWidth| to PhotoCapabilities
 (each is a MediaSettingsRange).
- adds |imageHeight| and |imageWidth| to PhotoSettings.
- extends image_capture.mojom to support all the previous new
 fields
- wires Android's "old" and "new" Camera API to provide the
 capabilities and listen to the Settings (seems like the
 "old" does not reliably support ISO).
- extends the FakeVideoCaptureDeviceTest and the LayoutTests
 for these new features.

Note that setOptions() is not synchronous with takePhoto(),
so VideoCaptureDeviceAndroid holds on to the latest, if any,
requested capture resolution.

BUG=518807

Review-Url: https://codereview.chromium.org/2164473002
Cr-Commit-Position: refs/heads/master@{#407298}

https://chromium.googlesource.com/skia.git/+log/a1ce2163906e..0e72e9ee3b02

$ git log a1ce21639..0e72e9ee3 --date=short --no-merges --format='%ad %ae %s'
2016-07-22 egdaniel Remove asserts on scissor size in Vulkan
2016-07-22 mtklein Have SkRasterPipelineBlitter take over for 565 when it can.
2016-07-22 msarett Convert XYZ values from PNGs to D50
2016-07-22 herb In the current code, tiling and bilerp sampling are strongly tied together. They can be separated by taking advantage of observation that translating a sample point into filter points in the bilerp stage the filter points will be at most 0.5 outside the tile. This allows simplified repositioning for the various tiling modes; clamp and mirror use min and max while repeat has max -> 0 and 0-> max. This allows bilerp to simply treat the filter points that fall off the tile. This allows tiling and bilerp sampling to be totally separate.
2016-07-22 senorblanco Always init SkPathRef variables.

BUG=623195

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel
TBR=jcgregorio@google.com

Review-Url: https://codereview.chromium.org/2176873002
Cr-Commit-Position: refs/heads/master@{#407297}

BUG=603217
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2150763002
Cr-Commit-Position: refs/heads/master@{#407296}

Got reverted due to breaking MSVC build:
https://bugs.chromium.org/p/chromium/issues/detail?id=630335#c2
https://build.chromium.org/p/chromium/builders/Win%20x64/builds/2630/steps/compile/logs/stdio

This CL:
- moves GTEST_FAIL() lines so that they fail at the end of the functions.
- adds static_cast<> to avoid x64 issues.

Original description ----------------------------------------------

H264 HW encode using MediaFoundation

This CL adds MediaFoundationVideoEncodeAccelerator which enables H264 encode support
using MediaFoundation on Windows 8.1+. Also, it includes a refactor of common
MediaFoundation classes under mf_helpers.*.

Note that, this is the first CL and H264 codec is still behind a flag.

Design Doc(with perf measurements): http://goo.gl/UCnwyA

BUG=590060
TEST= Tested AppRTC loopback with Chrome flag "--enable-webrtc-hw-h264-encoding" and
"--enable-mf-h264-encoding" on https://apprtc.appspot.com/?debug=loopback&vsc=h264
Also, added WIN specific sections at vea_unittests.

TBR=ananta@chromium.org,avi@chromium.org,grt@chromium.org,sandersd@chromium.org,wuchengli@chromium.org

Review-Url: https://codereview.chromium.org/2173153002
Cr-Commit-Position: refs/heads/master@{#407295}

The mobile emulator was triggering a layout before it had reapplied the
original viewport parameters when it was being disabled, which with
use-zoom-for-dsf enabled was causing the wrong viewport size to be given
to various components, like plugins and scrollbars.

BUG=628501,628185

Review-Url: https://codereview.chromium.org/2168313002
Cr-Commit-Position: refs/heads/master@{#407294}

BUG=630355
NOTRY=true

Review-Url: https://codereview.chromium.org/2175903002
Cr-Commit-Position: refs/heads/master@{#407293}

Add dictionaries and seed corpora from AFL.
All of the additions were shown to significantly help afl-fuzz fuzz the target fuzzers.

BUG=611337

Review-Url: https://codereview.chromium.org/2168263005
Cr-Commit-Position: refs/heads/master@{#407292}

This CL nukes ContentBrowserClient::CreateGeolocationDelegate()
and their overrides, and transfers each embedder's callsite to the
appropriate correspondent BrowserMainParts. These embedders are
namely: android_webview,  blimp, cast, chrome and content_shell.

Continuation of https://crrev.com/2127973002/.

BUG=612334

Review-Url: https://codereview.chromium.org/2174613002
Cr-Commit-Position: refs/heads/master@{#407291}

This CL solves a problem with the side nav menu drawer staying open when
using the back/forward buttons. The drawer now closes when navigating
forward or back.

BUG=623903
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2170223002
Cr-Commit-Position: refs/heads/master@{#407290}

* Replaces the previous "Select shipping address" or "Select shipping option"
  prompts with gigantic [SELECT] and [ADD] buttons on the right of each
  incomplete section.

* Caches a copy of the SectionInformation in the relevant PaymentRequestSection
  instances so that we can determine if we need to prompt the user to SELECT
  or ADD new PaymentOptions.

* Buttons are enabled from top to bottom, with only one button enabled at a
  time.  This encourages users to move downward while filling out the form.
  When a button is visible for a section, the only way to interact with the
  section is via the button (no more clicking on incomplete sections to expand
  them).

* The shipping summary section, which combines both the shipping address and
  shipping option fields, can now display a button that shows either the
  button for the incomplete shipping address section or the incomplete shipping
  option section (prioritized in taht order).

* Get rid of and generalizes a bunch of unneeded strings.

* Because the logic is so complicated now, we consolidate most layout updates
  and view visibility checks to updateControlLayout().

* Updates the PaymentRequestDynamicShippingSingleAddressTest to account for the
  lack of summary text for incomplete sections.

* Edits the "select shipping address" string to add "and requirements" to the end.

Videos:
https://drive.google.com/open?id=0B7c8ZkXVwskDZDZWUkhDXzdvLUE
https://drive.google.com/open?id=0B7c8ZkXVwskDRm53UUhHUHZmeW8

BUG=603635

Review-Url: https://codereview.chromium.org/2170693002
Cr-Commit-Position: refs/heads/master@{#407289}

This class is mostly a stub but not quite. And it's also a stub of
LayerTreeHostSingleThreadClient. Break it up into two real stubs
of those interfaces. And it inherits from StubLayerTreeHostClient
and implements just what it needs to be the client for FakeLayerTreeHost.

Now stuff that isn't using FakeLayerTreeHost doesn't need to use
FakeLayerTreeHostClient, they can use the StubLayerTreeHostClient.

R=enne,dtrainor
TBR=miguelg
BUG=606056
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel

Review-Url: https://codereview.chromium.org/2174653002
Cr-Commit-Position: refs/heads/master@{#407288}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/0cea24e0..4fd7f380

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2172233003
Cr-Commit-Position: refs/heads/master@{#407287}

I don't understand how gyp works with mojo bindings, but this seems to
fix some compile failures introduced in https://codereview.chromium.org/2158913006

BUG=630666

Review-Url: https://codereview.chromium.org/2173883003
Cr-Commit-Position: refs/heads/master@{#407286}

Fixing soft undo

BUG=618803
R=lushnikov@chromium.org

Review URL: https://codereview.chromium.org/2166603002 .

Cr-Commit-Position: refs/heads/master@{#407285}

Previously, the image would grow larger than kTrayPopupDetailsIconWidth.

BUG=625251

Review-Url: https://codereview.chromium.org/2165133002
Cr-Commit-Position: refs/heads/master@{#407284}

Adds a new browser automation testing library for Autofill.
The library leverages ChromeDriver to playback tasks composed
of user actions. A action recorder extension is included in order
to assist in the process of creating test tasks.

BUG=

Review-Url: https://codereview.chromium.org/2116583004
Cr-Commit-Position: refs/heads/master@{#407283}

This CL adds ComputeTransformsToTarget method which takes a transform id
and effect id and calls this instead of ComputeTransforms when
destination is target.

BUG=622372
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel

Review-Url: https://codereview.chromium.org/2172003002
Cr-Commit-Position: refs/heads/master@{#407282}

BUG=610521

Review-Url: https://codereview.chromium.org/2113383002
Cr-Commit-Position: refs/heads/master@{#407281}

For tests other than a few LayerTreeTests, this changes all tests that
used a DirectRenderer to use a DelegatingRenderer instead.

FakeLayerTreeHostClient took options for allowing fake software
compositing, but it was unused. The REMOTE_DIRECT_RENDERER_TEST_F macro
was also unused now.

(Also enables SurfaceLayerSwapPromiseWithDraw which was disabled but
the bug is fixed.)

R=enne
TBR=miguelg
BUG=421923,606056
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel

Review-Url: https://codereview.chromium.org/2171143002
Cr-Commit-Position: refs/heads/master@{#407280}

BUG=630068

Review-Url: https://codereview.chromium.org/2167843005
Cr-Commit-Position: refs/heads/master@{#407279}

https://chromium.googlesource.com/skia.git/+log/f1491693527a..a1ce2163906e

$ git log f14916935..a1ce21639 --date=short --no-merges --format='%ad %ae %s'
2016-07-22 mtklein DM: don't redirect stderr to verbose.log

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel
TBR=jcgregorio@google.com

Review-Url: https://codereview.chromium.org/2174013002
Cr-Commit-Position: refs/heads/master@{#407278}

This CL organizes the typemaps in Blink GN build. Previously, we dump
typemaps in Blink to third_party/WebKit/Source/platform/mojo/blink_typemaps.gni,
even though some of them are used by third_party/WebKit/public/. This is wrong
and inconsistent with GYP build. So I added a new typemaps.gni in WebKit/public
to collect them separately.

TBR=pdr@chromium.org

BUG=629566

Review-Url: https://codereview.chromium.org/2172333002
Cr-Commit-Position: refs/heads/master@{#407277}

This is more consistent overall, GetGLImplementation() doesn't tell exactly
whether we're using the core profile, or which version of ES etc.
It also helps testing & fuzzing, because mocks/stubs may implement ES2 but don't
report kGLImplementationEGLGLES2, causing inconsistencies.

BUG=None
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2170293002
Cr-Commit-Position: refs/heads/master@{#407276}

This CL fixes both (1) the renderer crash originally fixed by
https://codereview.chromium.org/2165043002, and (2) reverts the part
of that CL which prevents ChromeOS from having zero-velocity
GestureFlingStarts, which caused a regression in two-finger swipe
navigation for touchpad. It also moves the DCHECK from the original CL
to a new location which would have prevented the renderer crashes from
being introduced in the first place.

This CL doesn't include a test, though the test proposed by
khmel@ in https://codereview.chromium.org/2168693003 presumably will
land shortly after this CL.

BUG=627227
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2173603002
Cr-Commit-Position: refs/heads/master@{#407275}

This should allow some unittests (specifically offline pages related
unittests) to create the UINQEService despite not being a browser
process with no IOThread.

BUG=

Review-Url: https://codereview.chromium.org/2172393002
Cr-Commit-Position: refs/heads/master@{#407274}

In the near future, SurfaceIdAllocator will live in clients
and so ui::ContextFactory should not create a
SurfaceIdAllocator directly. Instead, ui::ContextFactory
allocates a new surface client ID, which can be used to
create a SurfaceIdAllocator in clients.

This CL also moves calls to RegisterSurfaceClientId and
InvalidateSurfaceClientId close to
RegisterSurfaceClientFactory and
UnregisterSurfaceClientFactory respectively. In a
subsequent CL, these two will be merged together into
SurfaceFactory.

BUG=627283, 629940
TBR=reveman@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2166423002
Cr-Commit-Position: refs/heads/master@{#407273}

Context: https://codereview.chromium.org/2128793003/#msg29

BUG=

Review-Url: https://codereview.chromium.org/2176843002
Cr-Commit-Position: refs/heads/master@{#407272}

Unit tests for https://codereview.chromium.org/2149523002/.
BUG=628496, 624506
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2166923002
Cr-Commit-Position: refs/heads/master@{#407271}

On most platforms the monotonic clock is system wide which means it is
consistent across processes making conversion unnecessary. In fact not
only it is unnecessary but harmfull because the
InterProcessTimeTickConverter (IPTTC) conversion [1] is an estimation
which introduces some error.

The patch limits the usage of IPTTC to platforms that require it which
is any Windows where we cannot use |QueryPerformanceCounter|.

After this change we will only collect UMA metrics[2] for IPTTC on
platforms where it is used.

[1] https://docs.google.com/document/d/1RcaOZ1G8ttAez9YuilvbDJCkCaYuLKqNkVpQvIBqsvM/edit
[2] Affects InterProcessTimeTicks.*

BUG=616574
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2090783002
Cr-Commit-Position: refs/heads/master@{#407270}

This avoids problems with the timer being delayed by nested message
loops and ScopedPageLoadDeferrers, where code in the nested message
loop might access the document and not generate a notification.

The timer was originally added to prevent re-entrant calls to V8,
but that can now be prevented with ScriptForbiddenScope.

BUG=629542
TEST=See bug for repro steps.

Review-Url: https://codereview.chromium.org/2171063002
Cr-Commit-Position: refs/heads/master@{#407269}

The current implementation relies on SkPath::getBounds(), which
computes a conservative result (includes control points).

Use SkPathOps::TightBounds() instead, for an exact answer.

BUG=230599
R=fs@opera.com,pdr@chromium.org,schenney@chromium.org,caryclark@google.com

Review-Url: https://codereview.chromium.org/2168133002
Cr-Commit-Position: refs/heads/master@{#407268}

This provides autorelease support for Mac tasks.

BUG=553459

Review-Url: https://codereview.chromium.org/2172123003
Cr-Commit-Position: refs/heads/master@{#407267}

Review-Url: https://codereview.chromium.org/2179543002
Cr-Commit-Position: refs/heads/master@{#407266}

No-op cleanup extracted from https://codereview.chromium.org/2135413003/#ps40001

In this CL:

 - Explicitly document the threading requirements of the API after grokking its use of locks
   in some places and lack of in some others)
   - (It's mostly thread unsafe; except for a few calls which are okay from the owner
      as well as the underlying thread; and one method which is actually thread-safe)
   - Add assertions as such (and catch issues on try bots :-O -- http://crbug.com/629139)
   - Remove |thread_lock_| which is unnecessary under the documented conditions
     (delayed until http://crbug.com/629139 is fixed..).

 - C++11 member initializers (makes it cleaner to add new POD members and
                              makes constructors simpler -- e.g. |run_loop_| was uninitialized)
 - Assertions and tests for current API which allows Start/Stop/Start cycles
   but wasn't tested... (actually more than that is poorly/not tested in this class
   but I'm merely adding tests for parts I'm stressing in my actual follow-up CL).

 - Comment nits

 - Make event-based tests use WaitableEvent instead of sleeping + toggling a bool.

BUG=629716, 629139

Review-Url: https://codereview.chromium.org/2145463002
Cr-Commit-Position: refs/heads/master@{#407265}

Changes the associated bindings implementation for ChannelMojo
such that remote interfaces can be acquired immediately upon
ChannelMojo construction rather than having to wait for connection
on the IO thread.

Simplifies the Channel bootstrapping process, removing a round-trip
Init message (and in fact the entire IPC::mojom::Boostrap interface)
since there's no need to actually exchange associated interface handles
over the pipe. Instead both sides can assume the other will use a fixed,
reserved endpoint ID for their IPC::mojom::Channel interface.

This also removes the restriction that associated interfaces must be
added to a Channel after Init. Instead the same constraints apply as
with AddFilter: an associated interface, like a filter, may be added
at any time as long as either Init hasn't been called OR the remote
process hasn't been launched.

The result of this CL is that any place it's safe to AddFilter,
it's also safe to AddAssociatedInterface; and any place it's safe to
Send, it's also safe to GetRemoteAssociatedInterface and begin using
any such remote interface immediately.

Remote interface requests as well as all messages to remote interfaces
retain FIFO with respect to any Send calls on the same thread. Local
interface request dispatch as well as all messages on locally bound
associated interfaces retain FIFO with respect to any OnMessageReceived
calls on the same thread.

BUG=612500,619202

Committed: https://crrev.com/e1037f997da9e1d44ca3b09d4ff32f0465673091
Committed: https://crrev.com/508da24622f957a01b076ccd058bfdccc79068a4
Review-Url: https://codereview.chromium.org/2163633003
Cr-Original-Original-Commit-Position: refs/heads/master@{#406720}
Cr-Original-Commit-Position: refs/heads/master@{#407050}
Cr-Commit-Position: refs/heads/master@{#407264}

This CL also let chrome compile against 24.1.1 support library.

BUG=609085

Review-Url: https://codereview.chromium.org/2175513002
Cr-Commit-Position: refs/heads/master@{#407263}