GitLab

MessageLoopForIO will go away soon use ScopedTaskEnvironment instead.

ScopedTaskEnvironment will per default start a ThreadPool, which should
be fine in most of the cases. If you believe your test needs to make sure
that no ThreadPool runs let me know and I will update the patch.

BUG=891670
This CL was uploaded by git cl split.

R=jamesr@chromium.org

Change-Id: I6c82de2bdf0d0c819c5c185788f727b0be5dbe87
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733590
Commit-Queue: Wez <wez@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Auto-Submit: Carlos Caballero <carlscab@google.com>
Cr-Commit-Position: refs/heads/master@{#684124}

If the GPU works with MSAA we should use it. However the current code
will always fallback to CMAA on desktop GL because GL_EXT_multisampled_render_to_texture
is only available on ES profile.

While CMAA could be used by other GPUs than Intel, currently Chromium only
provides support for CMAA on Intel GPUs. This patch aligns with the behavior
of DrawingBuffer which is used to render the WebGL content.

Bug: 990923

Change-Id: Ie3a94a68a685fa0b34d573d48f6d4853d553be64
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730624Reviewed-by: Brandon Jones <bajones@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Alexis Menard <alexis.menard@intel.com>
Auto-Submit: Alexis Menard <alexis.menard@intel.com>
Cr-Commit-Position: refs/heads/master@{#684123}

When required, compress the height of the background tiles section in
order to keep the dialog within viewport boundaries.

Before:
http://screen/hiFC5HwrFsG.png

After:
http://screen/Ras1KXOdR69.png
http://screen/QZzwKp7BnF3.png
http://screen/aZeonNGjBEV.png

Bug: 990803
Change-Id: I6c83124e5490729b14fb7e8fb68da106af6c8caa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1736892
Commit-Queue: Kristi Park <kristipark@chromium.org>
Commit-Queue: Gayane Petrosyan <gayane@chromium.org>
Auto-Submit: Kristi Park <kristipark@chromium.org>
Reviewed-by: Gayane Petrosyan <gayane@chromium.org>
Cr-Commit-Position: refs/heads/master@{#684122}

This reverts commit 510e0f76.

Reason for revert: The GN rules are missing a dependency on the FIDL package for fuchsia.cdm, so the build flakily fails, depending on whether ninja happens to have generated the C++ bindings before or after building components that happen to be using it, e.g. see https://ci.chromium.org/p/chromium/builders/ci/fuchsia-arm64-cast/46713

Original change's description:
> [Fuchsia][EME] Basic skeleton for EME support on Fuchsia
> 
> In renderer process, FuchsiaCdmFactory initiates the request to Fuchsia
> CDM service. The request is passed to browser process via new mojo
> FuchsiaCdmProvider. FuchsiaCdm implements
> media::ContentDecryptionModule by calling Fuchsia CDM APIs directly from
> renderer process.
> 
> In browser process, FuchsiaCdmManager will complete the provision flow
> (if needed) and setup the channel between Chromium and the remote CDM
> service.
> 
> Bug: 966191
> Test: Shaka Player WV audio only test (with other CLs).
> Change-Id: I401e581214d945a2acbefa926f73fdb2ca84d780
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715908
> Reviewed-by: Wez <wez@chromium.org>
> Reviewed-by: John Rummell <jrummell@chromium.org>
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Reviewed-by: John Abd-El-Malek <jam@chromium.org>
> Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
> Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
> Commit-Queue: Yuchen Liu <yucliu@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#684087}

TBR=dcheng@chromium.org,wez@chromium.org,xhwang@chromium.org,jam@chromium.org,jrummell@chromium.org,sergeyu@chromium.org,yucliu@chromium.org

Change-Id: Id572ae4feadf1b87fe58601eb83601da07d61b8b
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 966191
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1737487Reviewed-by: Wez <wez@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#684121}

Fixes a race condition in XR tests that use the test_gamepad_button.html
test page. It was possible for finishJavaScriptStep() to be called
multiple times before the Java/C++ code could ack the first one, leading
to test failures.

Bug: 990843
Change-Id: I6e1a92c9cc3512862fb6441a1bad5efecff3a83c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1736801
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: Alexander Cooper <alcooper@chromium.org>
Cr-Commit-Position: refs/heads/master@{#684120}

The new command line switch allows users to disable high frequency
timers on Windows. Normally the browser will set a system-wide timer
resolution of 1ms on AC power, and 4ms on battery. The period used when
on battery power can be increased to 8ms if the experimental
SlowDCTimerInterrupts feature is enabled.

The switch is intended for use with headless browser processes running
on a server or VM, which is likely to be on AC power at all times. The
switch allows these processes to opt-in to the slower timer interrupt
frequency, acting as if they are running on battery. This should reduce
the amount of context switching and reduce CPU usage, which can be
helpful when attempting to run many headless browser processes in
parallel.

Bug: 986338
Change-Id: I8580f486aca3400fb51e0c4932c3783332a3a11a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715566Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Commit-Queue: Brandon Walderman <brwalder@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#684119}

This is part of EG1 to EG2 migration, which involves moving
EarlGrey code from app-side helpers into test code.
EarlGrey2 has multiprocess architecture,
where Chrome Test and Chrome App are separate processes

Change-Id: If2dc2115f5c11c906806edacef567bc6f1d02204
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733891
Commit-Queue: Maksym Onufriienko <monufriienko@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#684118}

This CL adds test to cover all functions in NotificationScheduler.

Bug: 963304
Change-Id: I9f63cd4ec9e1e3ed761c10ac7f2e0539294e026c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732289
Commit-Queue: Xing Liu <xingliu@chromium.org>
Reviewed-by: Hesen Zhang <hesen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#684117}

R=yusufo@chromium.org

Bug: 985386
Change-Id: I3667a7881cc5c9b2046217a647603777593de0ed
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730865
Commit-Queue: Matt Simmons <mattsimmons@chromium.org>
Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#684116}

https://webrtc.googlesource.com/src.git/+log/cdbaeeb73767..9b1700cfaef9

git log cdbaeeb73767..9b1700cfaef9 --date=short --no-merges --format='%ad %ae %s'
2019-08-05 orphis@webrtc.org Enable field trial LegacySimulcastLayerLimit by default
2019-08-05 peah@webrtc.org AEC3: Removing unused code in the echo subtractor

Created with:
  gclient setdep -r src/third_party/webrtc@9b1700cfaef9

The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=webrtc-chromium-sheriffs-robots@google.com

Bug: chromium:990823
Change-Id: Id638fa2e5f750a0d8fa719f9e98d0352c07fc63f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1735951Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#684115}

This CL updates SMS dialog to use xml layout.

I uploaded some screenshots of the SMS dialog on the issue page.

Bug: 987799
Change-Id: I46e27aefd19104b4bba5032076bc31b0b203a730
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725519
Commit-Queue: Jun Cai <juncai@chromium.org>
Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#684114}

Bug: 925165
Change-Id: Idcd84485128c8239d3cd811bf0309e1c3c2b8c0c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1736353
Commit-Queue: Lei Zhang <thestig@chromium.org>
Auto-Submit: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#684113}

Bug: 942178
Bug: 945164
Bug: 950339
Bug: 977216
Change-Id: I15b8cffe8c1ab47c5c4697b92f89d3cbe7ccbae0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717465
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Reviewed-by: Charlie Reis <creis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#684112}

Safari and blink legacy fail this; EdgeHTML, Firefox, and blink NG pass
it, but I think blink NG passes it by accident for now.

Change-Id: I38acc8ba98d3897aa77305a36c2ae6f2affec640
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713143
Commit-Queue: David Grogan <dgrogan@chromium.org>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#684111}

Bug: 990534
Change-Id: I6a980d68c33a08306286ff4e6628f291203f55bf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733894Reviewed-by: Theresa  <twellington@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Commit-Queue: Jenna Himawan <jhimawan@google.com>
Cr-Commit-Position: refs/heads/master@{#684110}

Bug: 988177
Test: manually verified the message shown on Assistant OOBE ready sreen.
Change-Id: I18be0fc6d09697c0076ef45d4e283c234ea12e16
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733846Reviewed-by: Yue Li <updowndota@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Meilin Wang <meilinw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#684109}

This reverts commit 6bbf3348.

Reason for revert: The issue is now fixed. Relanding.

Original change's description:
> Disable renderer CIG by default.
> 
> This is causing crashes on some configurations and needs investigation.
> 
> BUG=750886,990640
> 
> Change-Id: Idfdd06b219a95bed854cce9048860692ded011b3
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1736106
> Commit-Queue: Will Harris <wfh@chromium.org>
> Commit-Queue: James Forshaw <forshaw@chromium.org>
> Reviewed-by: James Forshaw <forshaw@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#683904}

TBR=forshaw@chromium.org,wfh@chromium.org

Change-Id: I84f75f23b897770fd5429a400086db78aff52479
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 750886, 990640
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1737434Reviewed-by: Will Harris <wfh@chromium.org>
Commit-Queue: Will Harris <wfh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#684108}

An IndexWriter was holding both the index's metadata (including id)
and an "IndexedDBIndexKeys" struct with the index's id and a vector
of keys.

Simplify to just holding the metadata and vector of keys, which
removes an indirection step in a few places in the code. Refactored
out of an upcoming change.

Change-Id: I8efefdc5350c48a61df58b46b51be4c685c94ca5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733014
Commit-Queue: Joshua Bell <jsbell@chromium.org>
Commit-Queue: Daniel Murphy <dmurph@chromium.org>
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Auto-Submit: Joshua Bell <jsbell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#684107}

This changeset simplifies database callback graph in open with GetMany provided
by leveldb service.

Previously OnDatabaseOpened called OnGotDatabaseVersion, and before calling
OnConnectionFinished it was block waiting on a barrier of OnGotNamespaces and
OnGotNextMapId. This changeset gets values of database version, namespaces and
next map id in one call, and processes the result sequentially.

Bug: 965723

Test: autoninja -C out/Default content/test:content_unittests. Passed all content_unittests
Change-Id: I968d92d93414cc6918e48d870fea27dc1d74b3d2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1714487
Commit-Queue: Daniel Murphy <dmurph@chromium.org>
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#684106}

https://chromium.googlesource.com/catapult.git/+log/53d495005f0c..698405a9f62a

git log 53d495005f0c..698405a9f62a --date=short --no-merges --format='%ad %ae %s'
2019-08-05 rmhasan@google.com [Telemetry] Created mapping between the old format expectations and new format tags

Created with:
  gclient setdep -r src/third_party/catapult@698405a9f62a

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=zhanliang@google.com

Bug: chromium:973936
Change-Id: I8dd88a6e22c232b75dc30f9d2bf235a6ada8d0d1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1736516Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#684105}

The section permission requested by the loader changed in 1903 so
one of the sanity checks in the intercept was failing.

BUG=990640,750886

Change-Id: I975f1225fc017cb9cd735e4632862451af8a0341
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1737042
Auto-Submit: Will Harris <wfh@chromium.org>
Reviewed-by: James Forshaw <forshaw@chromium.org>
Commit-Queue: Will Harris <wfh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#684104}

This class was previously used by DownloadRequestCore in
non network service code path. We no longer need this now.

BUG=934009

Change-Id: I827d2f644eed739fd95f544b3f402e1bc7e957f7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733420
Commit-Queue: Min Qin <qinmin@chromium.org>
Reviewed-by: Xing Liu <xingliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#684103}

BUG=762641
TBR=tbarzic@google.com

Change-Id: Ie924188cc35477d09be840f089af21568f7f2ab1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1734828Reviewed-by: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#684102}

https://chromium.googlesource.com/angle/angle.git/+log/9031bdd9ba3b..c13ca2affeed

git log 9031bdd9ba3b..c13ca2affeed --date=short --no-merges --format='%ad %ae %s'
2019-08-05 syoussefi@chromium.org Vulkan: Allow more than one atomic counter buffer binding
2019-08-05 ianelliott@google.com Vulkan: Enable more tests to run (and in most cases pass).
2019-08-05 jmadill@chromium.org Capture/Replay: Capture return values.

Created with:
  gclient setdep -r src/third_party/angle@c13ca2affeed

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=ynovikov@chromium.org

Bug: None
Change-Id: If1047c77e1352cc926b97ed4b6f04bef595a9309
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1735955Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#684101}

We are removing the WebLayerTreeView interface as it is redundant with
WebWidgetClient now that we always composite web contents.

More importantly this helps us Close/Restart the WebWidget parts of
WebViewImpl by not requiring plumbing 2 pointers with slightly different
lifetimes (WebLayerTreeView is created inside the Init of the
WebWidgetClient). This will help avoid a bunch of complexity in
creating WebFrameWidgets and other WebWidgets.

This method is not actually used from blink, so there's no need for it to exist
on WebLayerTreeView. All callsites can directly call into LayerTreeHost.

This CL is a refactor with no intended behavior change.

Bug: 912193
Change-Id: I748546f6b71c65fb11c816547c74553e758665ed
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731959
Commit-Queue: Erik Chen <erikchen@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Auto-Submit: Erik Chen <erikchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#684100}

Bug: 982018

Change-Id: I1b6b6e7f7a9a9dc76cfed5e318fb93981a782225
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731020Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Reviewed-by: anthonyvd <anthonyvd@chromium.org>
Reviewed-by: Ganggui Tang <gogerald@chromium.org>
Commit-Queue: Mia Glaese <glamia@chromium.org>
Cr-Commit-Position: refs/heads/master@{#684099}

This CL removes a TODO suggesting that the migration code should be
removed, replacing it with a comment describing why the migration code
should not be removed.

Bug: 445599
Change-Id: I78660240d3ed957bd76e3f3dbc2475dccba1751c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1737327
Commit-Queue: Scott Little <sclittle@chromium.org>
Commit-Queue: Ryan Sturm <ryansturm@chromium.org>
Auto-Submit: Scott Little <sclittle@chromium.org>
Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#684098}

We are removing the WebLayerTreeView interface as it is redundant with
WebWidgetClient now that we always composite web contents.

More importantly this helps us Close/Restart the WebWidget parts of
WebViewImpl by not requiring plumbing 2 pointers with slightly different
lifetimes (WebLayerTreeView is created inside the Init of the
WebWidgetClient). This will help avoid a bunch of complexity in
creating WebFrameWidgets and other WebWidgets.

This CL is mostly a refactor but has a slight behavior change.
WebViewImpl::DidUpdateBrowserControls had a conditional gated on
layer_tree_view_. This CL replaces the conditional with a check for local main
frame.

Change-Id: Iaab168eaef0aa2b396f92e9d2cd049176d4efbf9
Bug: 912193
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728339
Commit-Queue: Erik Chen <erikchen@chromium.org>
Auto-Submit: Erik Chen <erikchen@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#684097}

TBR=estade@chromium.org

Bug: 990692
Change-Id: Ia2f8b62c2e9864b34c54ec8250d1718678366e4f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1737103Reviewed-by: Chris Sharp <csharp@chromium.org>
Commit-Queue: Chris Sharp <csharp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#684096}

This expands MAC anonymization to allow for dash and underscore
separators which are generally seen in Bluetooth MACs. It also adds
anonymization of 32, 40 and 64 char length hex hash values and puts the
4 char hash prefix in the redacted value. It also looks for a special
case which was happening with modetest and ignores that so the data dump
there is preserved.

Bug: 940884
Test: Unit tests pass, uploaded feedback report redaction looks good
Change-Id: I7ced3399f9387392eed24c866d6b60652762e984
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733749
Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Reviewed-by: Jorge Lucangeli Obes <jorgelo@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: J Kardatzke <jkardatzke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#684095}

https://dawn.googlesource.com/dawn.git/+log/ccf805046ae3..38ee172a228d

git log ccf805046ae3..38ee172a228d --date=short --no-merges --format='%ad %ae %s'
2019-08-05 enga@chromium.org Fix dynamic bind group size in Animometer example

Created with:
  gclient setdep -r src/third_party/dawn@38ee172a228d

The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel
TBR=cwallez@google.com

Bug: None
Change-Id: I17c0011463ca186433e1c4ea9c8becc88b377e16
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1735953Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#684094}

Bug: 990789
Change-Id: I6d489a1f01397cdc611911dc9c5000a244648c05
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1737036
Commit-Queue: Kristi Park <kristipark@chromium.org>
Commit-Queue: Gayane Petrosyan <gayane@chromium.org>
Auto-Submit: Kristi Park <kristipark@chromium.org>
Reviewed-by: Gayane Petrosyan <gayane@chromium.org>
Cr-Commit-Position: refs/heads/master@{#684093}

The original CL was reverted because it triggered an MSAN use-after-free bug.
See issue 990192 for more details. The root cause is that in the CL, the
RenderView's destructor would call RenderWidget::Close, but RenderWidget is
ref-counted and would not actually be closed. Subsequently, RenderWidget's
delegate_ member would point to the now-destroyed RenderView, and accessing it
would cause UaF.

This reland makes RenderWidget have unique_ptr semantics, thereby fixing the
problem. This CL generally fixes the problem of accessing RenderWidget after
RenderWidget::Close.

This CL removes the method DidCloseWidget, as it added an unnecessary layer of
abstraction. RenderView can perform its own clean up.

> Make browser process own RenderView.
>
> Historically, RenderView and RenderWidget were 1:1, and their lifetimes were
> entwined.
> 1) RenderViewHost would create the RenderView.
> 2) RenderView would create a RenderWidget and pass ownership of itself to the
> RenderWidget.
> 3) RenderViewHost's destructor would destroy the RenderWidget, thus destroying
> the RenderView
>
> We want the lifetime of RenderView and RenderWidget to be decoupled. The first
> step of this is making RenderView explicitly owned by the browser. This means
> that instead of (3), RenderViewHost's destructor will destroy the RenderView,
> which will in turn destroy the RenderWidget.
>
> One subtlety is that prior to this CL, RenderWidget was always destroyed
> asynchronously. The original reason for supporting this -- dealing with
> re-entrancy from nested message loops -- is no longer applicable. The IPC that
> destroys RenderWidget is asynchronous, which means it can never be called from a
> re-entrant context. However, it is possible for a RenderWidget associated with a
> child-frame to be synchronously destroyed by JS. This can be re-entrant. This CL
> updates destruction of RenderWidget to be synchronous when called from IPC.

Bug: 987731, 990192
Change-Id: I1b1f1b70cc6b8e91286712d80ab42cd507e64e1a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733580Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Erik Chen <erikchen@chromium.org>
Auto-Submit: Erik Chen <erikchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#684092}

Make MediaCodecUtil::IsHEVCDecoderAvailable call IsDecoderSupportedByDevice
instead of IsEncoderSupportedByDevice. It looks like a typo, and isn't
harmless: it can cause content shell to stall at startup if built with
enable_hevc_demuxing=true when the renderer tries to query the encoder.

Apparently it's a case of doing something in the renderer that's not
allowed, as explained in
https://chromium-review.googlesource.com/c/chromium/src/+/1694241
(which happened to add this encoder/decoder typo).

BUG=980091, 980682
TEST=build with enable_hevc_demuxing=true, run content shell apk
R=chcunningham

Change-Id: Iaadc73e6dd4301b6e300891cbb0baf7afe8f5e63
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730163Reviewed-by: Chrome Cunningham <chcunningham@chromium.org>
Commit-Queue: Chrome Cunningham <chcunningham@chromium.org>
Cr-Commit-Position: refs/heads/master@{#684091}

- Flips feature flag to enable the updated Ui for settings
  printers.

Bug: 965721
Test: End to end manual, browsertests
Change-Id: I7187b4c7b05b4ae5d2a625b05b184a53909a5b4a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1714210
Commit-Queue: jimmy gong <jimmyxgong@chromium.org>
Reviewed-by: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#684090}

from MenuButton.

Bug: 984600

Change-Id: Ia811ef808ea9b67ee5375901384feecaf9241282
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717493Reviewed-by: Peter Boström <pbos@chromium.org>
Commit-Queue: Charlene Yan <cyan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#684089}

Added logic to hide the paste button when nothing has been copied
to the clipboard yet. This uses the clipboard API to add an event
listener.

Bug: 982004
Change-Id: I6aae1d1613a9271e1f4a88bd01d1e050667b6164
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730630
Commit-Queue: Rose Garcia <rosalindag@google.com>
Reviewed-by: Anastasia Helfinstein <anastasi@google.com>
Reviewed-by: Akihiro Ota <akihiroota@chromium.org>
Cr-Commit-Position: refs/heads/master@{#684088}

In renderer process, FuchsiaCdmFactory initiates the request to Fuchsia
CDM service. The request is passed to browser process via new mojo
FuchsiaCdmProvider. FuchsiaCdm implements
media::ContentDecryptionModule by calling Fuchsia CDM APIs directly from
renderer process.

In browser process, FuchsiaCdmManager will complete the provision flow
(if needed) and setup the channel between Chromium and the remote CDM
service.

Bug: 966191
Test: Shaka Player WV audio only test (with other CLs).
Change-Id: I401e581214d945a2acbefa926f73fdb2ca84d780
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715908Reviewed-by: Wez <wez@chromium.org>
Reviewed-by: John Rummell <jrummell@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Commit-Queue: Yuchen Liu <yucliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#684087}

https://skia.googlesource.com/skia.git/+log/4df3d5340ef3..f1138888e7ce

git log 4df3d5340ef3..f1138888e7ce --date=short --no-merges --format='%ad %ae %s'
2019-08-05 halcanary@google.com experimental/editor: StringSlice::fPtr type change
2019-08-05 bsalomon@google.com Pass GrBackendFormat to GrResourceProvider and GrGpu texture create
2019-08-05 halcanary@google.com tools/gyp: deleting old file
2019-08-05 michaelludwig@google.com Update benchmarks to use new filter factories

Created with:
  gclient setdep -r src/third_party/skia@f1138888e7ce

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=reed@google.com

Bug: None
Change-Id: I19899bb21aed5983e8b899697c0224f0c85b415c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1735952Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#684086}

This feature is launching soon so we should add this
flag to about flags so it can be tested easily.

BUG=965546

Change-Id: Id569e60e609b00c9ddc410996c2cb893d4f0f5e2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1737147Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#684085}