- 22 Mar, 2018 40 commits
-
-
Yafei Duan authored
In this CL: - Removed unused methods from ArchiveManager. - Reporting more storage stats from ArchiveManager, for multiple archive directories. - Fixed multiple tests related. There will be a followup change based on this one for reporting storage related UMAs from OfflinePageModelTaskified. Bug: NONE Change-Id: I8f9d2837b4c47a1f88fd380c86f63d0f5340c6e0 Reviewed-on: https://chromium-review.googlesource.com/967561 Commit-Queue: Yafei Duan <romax@chromium.org> Reviewed-by:
Peter Williamson <petewil@chromium.org> Cr-Commit-Position: refs/heads/master@{#544993}
-
https://skia.googlesource.com/skia.git/+log/4d4b3aaa20e1..f5720cc4d1dd $ git log 4d4b3aaa2..f5720cc4d --date=short --no-merges --format='%ad %ae %s' 2018-03-22 angle-skia-autoroll Roll skia/third_party/externals/angle2/ 8574357f1..3395c8b96 (5 commits) 2018-03-21 mtklein back to individual flags for :hsw 2018-03-20 benjaminwagner Remove some MSVC 32-bit Perf/Test jobs. 2018-03-21 ynovikov update_meta_config: Use new LUCI optional GPU Android trybot 2018-03-21 borenet [infra] Use new LUCI Mac trybot 2018-03-21 caryclark limit discrete path effect iterations 2018-03-21 joe Add Node as a bot asset. Created with: roll-dep src/third_party/skia BUG=chromium:731979,chromium:824467 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=jvanverth@chromium.org Change-Id: Ie69305f18965af2a4aa09b0c4dd129e83e72f70c Reviewed-on: https://chromium-review.googlesource.com/974757Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#544992}
-
Kent Tamura authored
It is a list of exceptional rules, and contains some Source/ paths. Bug: 578345 Change-Id: I17e65d35c4809b9c91217db086e1af10d82dea54 Reviewed-on: https://chromium-review.googlesource.com/974605 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Quinten Yearsley <qyearsley@chromium.org> Cr-Commit-Position: refs/heads/master@{#544991}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 863a31fc. With Chromium commits locally applied on WPT: 1c4a06ae "Make Range::intersectsNode() to follow the spec" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/14334 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: rouslan@chromium.org, mathp@chromium.org: external/wpt/payment-request TBR=robertma No-Export: true Change-Id: If30ad24bb4212460dde70e1bca739f51308f0797 Reviewed-on: https://chromium-review.googlesource.com/974799 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#544990}
-
Kent Tamura authored
Bug: 578345 Change-Id: Ic323ea326224eedfe84d1c9902fcaccaae853d9e Reviewed-on: https://chromium-review.googlesource.com/974803Reviewed-by:
-
Tetsui Ohkubo authored
According to UX spec, UnifiedSystemTray supports collapsed state. This CL * Adds SetExpanded to FeaturePodButton. If false, it hides labels. * Adds SetExpanded to FeaturePodsContainerView. If false, it uses layout that places all the buttons horizontally. Buttons exceed the limit will be hidden in the collapsed state. To support this behavior, FeaturePodButton::SetExpandedByContainer is also added. * Adds SetExpanded to UnifiedSystemTrayView and puts all sliders to |sliders_container_|, so that it can be easily hidden when collapsed. * Adds FeaturePodsContainerViewTest unit tests. Screencast: http://go/scrcast/NTk3Mzg1NzQwMzkyODU3NnxhZTNmMDI2ZS1kNA UnifiedSystemTray design doc: go/cros-qs-restyling TEST=FeaturePodsContainerViewTest BUG=819942 Change-Id: Ic7b7bcf56f1405b9eb0babab8f041f5a83d361f2 Reviewed-on: https://chromium-review.googlesource.com/964031Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#544988}
-
Xiaohan Wang authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/8bf5a724397c..a1ec7e112c5e $ git log 8bf5a7243..a1ec7e112 --date=short --no-merges --format='%ad %ae %s' 2018-03-21 xhwang chrome-sdk: Remove Widevine CDM adapter 2018-03-17 pberny atlas: Add master builder configuration Created with: roll-dep src/third_party/chromite TBR=achuith@chromium.org,vapier@chromium.org BUG=772160,823986 Change-Id: I12d8487657339b574b5285c6598a84e14fa4afed Reviewed-on: https://chromium-review.googlesource.com/974798Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#544987}
-
Kent Tamura authored
- Jinja template files have .tmpl extension now. - Remove should_skip_with_warning() We have no files match to _SKIPPED_FILES_WITH_WARNING. - Remove non-existent files from _SKIPPED_FILES_WITHOUT_WARNING. Change-Id: I5e7e11bc806cd4da3ad46aa1981e34ae5286c944 Reviewed-on: https://chromium-review.googlesource.com/974722Reviewed-by:
-
Jamie Madill authored
It seems new drivers have a regression with 3D textures. Bug: angleproject:2424 No-try: True Tbr: kbr@chromium.org Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Id1a94b1b95206551f6fd504043cf2fe0b48bbb56 Reviewed-on: https://chromium-review.googlesource.com/974459Reviewed-by:
Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Cr-Commit-Position: refs/heads/master@{#544985}
-
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ca08cc1b0773..6ad0221d7539 $ git log ca08cc1b0..6ad0221d7 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src-internal The AutoRoll server is located here: https://src-internal-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: If701aa0d0e8e10f1e66804928ed57423f233643b Reviewed-on: https://chromium-review.googlesource.com/974711Reviewed-by:
src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#544984}
-
Hiroki Nakagawa authored
This CL supports ES Modules on DedicatedWorker behind the ModuleDedicatedWorker flag and adds WPT tests. With the flag, you can specify 'type' option on the constructor of DedicatedWorker (i.e., new Worker) to start a dedicated worker as a module script. On DedicatedWorkerGlobalScope, static import is available, but dynamic import() hasn't been implemented yet. Bug: 680046 Change-Id: I3aca350228ec07be7884c7a2eb8cd351e7fd6b6e Reviewed-on: https://chromium-review.googlesource.com/967908 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#544983}
-
Jeremy Roman authored
bit_cast is more correct (memcpy, unlike use of inactive union members, is blessed by the standard), and besides, all uses are in WTF, which can use base. Change-Id: Ia9ac40c692db72d9339934e33e4c4ffbe7443bef Reviewed-on: https://chromium-review.googlesource.com/974318 Commit-Queue: Yuta Kitamura <yutak@chromium.org> Reviewed-by:
Yuta Kitamura <yutak@chromium.org> Cr-Commit-Position: refs/heads/master@{#544982}
-
tzik authored
This CL changes the ownership of base::Clock and base::TickClock from injectee-owned to injecter-owned. Before this CL, these instances are owned by the owner of the injectee or one of the injectees themselves. That makes the ownership handling complex. After this CL, the injectee of clocks never own the clock. Instead, injecters owns a clock for testing, and a shared clock is used on the production code. Bug: 789079 Change-Id: Ibd4de27bb774c8e00a9dc24e720452245b20c8da Reviewed-on: https://chromium-review.googlesource.com/956325 Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Reviewed-by:
Bartosz Fabianowski <bartfab@chromium.org> Cr-Commit-Position: refs/heads/master@{#544981}
-
Takuto Ikuta authored
There are many duplicate regexp compiles for joined tags. This patch improved the time to build chrome/app:generated_resources from 21.562s to 17.672s on Z840 Linux. Change-Id: I8b703e7ead06c8119cfa7b3e12ed8132c871eb7f Reviewed-on: https://chromium-review.googlesource.com/967903 Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#544980}
-
Alexandre Courbot authored
VDAs can be created without any GL context. In this case, VaapiPictureFactory fails to return pictures since it cannot rely on the GL implementation to decide an allocation method. Turn to Ozone in such a case, since this is the most sensible candidate and we plan to use this feature in unit tests mainly. BUG=819542 TEST=Verified that vdatest was still passing on eve, hana and kevin Change-Id: I08484d1619f32a6bf7613f3cb4663314a1f67c72 Reviewed-on: https://chromium-review.googlesource.com/961779Reviewed-by:
Miguel Casas <mcasas@chromium.org> Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Cr-Commit-Position: refs/heads/master@{#544979}
-
Xiaohan Wang authored
Less dependency is better. Media code should not need to know third_party plugins (ppapi/). This CL removes ppapi/ dependency from media/ to enforce this. Bug: 772160 Change-Id: Ib4e1bf6b6a5a87dde16e5130830e589769a2ca89 Reviewed-on: https://chromium-review.googlesource.com/974574 Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#544978}
-
Tetsui Ohkubo authored
This CL adds a feature pod button for VPN. By clicking on the button, it will show VPN detailed view of the existing SystemTray. This behavior is described as Development Stage 1 in the design doc: go/cros-qs-restyling Screenshot: http://screen/UGX2VC3yYpo TEST=manual BUG=813499 Change-Id: I5159f210279a92e8f17d5898050a7a678901fb86 Reviewed-on: https://chromium-review.googlesource.com/970003Reviewed-by:
-
tzik authored
This CL changes the ownership of base::Clock and base::TickClock from injectee-owned to injector-owned. Before this CL, these instances are owned by the owner of the injectee or one of the injectees themselves. That makes the ownership handling complex. After this CL, the injectee of clocks never own the clock. Instead, injecters owns a clock for testing, and a shared clock is used on the production code. Bug: 789079 Change-Id: I786ba9c6425e129770b75e764096284629fb4692 Reviewed-on: https://chromium-review.googlesource.com/955705Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#544976}
-
Daniele Castagna authored
This CL adds a unit test to make sure that we use the opaque fb when we schedule an overlay plane with alpha blending disabled. Bug: 789288, b/74997524 Change-Id: Ib8906e23e439ba936c280e0bf7b1f52d733fb38c Reviewed-on: https://chromium-review.googlesource.com/973890 Commit-Queue: Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#544975}
-
Charlie Harrison authored
This CL hooks into the pref added in [1] which controls tab-under protection. This allows enterprises to turn off tab-under protection. [1]: https://chromium-review.googlesource.com/c/chromium/src/+/970729 Bug: 823700 Change-Id: I49d32aa5f0a270e52bace8f9d509d996589d1ad5 Reviewed-on: https://chromium-review.googlesource.com/970846Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#544974}
-
Mike Frysinger authored
Change-Id: I855b81d7cef2353eb272ac918187188f1bb93608 Reviewed-on: https://chromium-review.googlesource.com/974792Reviewed-by:
Abhishek Arya <inferno@chromium.org> Commit-Queue: Abhishek Arya <inferno@chromium.org> Cr-Commit-Position: refs/heads/master@{#544973}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 85a5f770. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/14333 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: meade@chromium.org: external/wpt/web-animations TBR=robertma No-Export: true Change-Id: I50593598cf0f42b209db44caa5fe4c635395bdcd Reviewed-on: https://chromium-review.googlesource.com/974753 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
-
Yoshifumi Inoue authored
This patch change |Range::intersectsNode()| to follow the spec[1]. [1] https://dom.spec.whatwg.org/#dom-range-intersectsnode Bug: 822510 Change-Id: Ifd504443355da12482b759701cddd62e2a90d7a6 Reviewed-on: https://chromium-review.googlesource.com/970044Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#544971}
-
Adam Langley authored
This change allows VirtualU2fDevice to create custom attestation certificates at run-time. It also adds tests for attestation behaviour that depend on that ability. Change-Id: I88323de6baaba7883ab0db676c26ccdb4b0dafbb Reviewed-on: https://chromium-review.googlesource.com/967066Reviewed-by:
Balazs Engedy <engedy@chromium.org> Commit-Queue: Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#544970}
-
Fergal Daly authored
Add a part_pseudo_rules vector to RuleSet to hold rules with ::part selectors and update RuleSet::FindBestRuleSetAndAdd to populate this. Bug: 805271 Change-Id: If18cabbd8c933f49a252e2f659246cb0e0471e3f Reviewed-on: https://chromium-review.googlesource.com/972766 Commit-Queue: Fergal Daly <fergal@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#544969}
-
Wenzhao Zang authored
The entire new wallpaper picker is hidden behind flag. A mock of the info bar: https://goo.gl/NTLuik Bug: 824453 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I8cb106f76fc01fef361ed3c7ca0f0253484518c5 Reviewed-on: https://chromium-review.googlesource.com/961782Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#544968}
-
Junichi Uekawa authored
BUG=b/74363217 Change-Id: I4aa4a2758772685df3b71f7ad334fa6e6fff745a Reviewed-on: https://chromium-review.googlesource.com/974602Reviewed-by:
Shuhei Takahashi <nya@chromium.org> Commit-Queue: Junichi Uekawa <uekawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#544967}
-
Satoshi Niwa authored
(Marked as deprecated by crrev/c/583590 on Aug 19, 2017) Bug: chromium:748842 Change-Id: If77ed2ea38d91719f58abf76e7aedd9173783472 Reviewed-on: https://chromium-review.googlesource.com/970193Reviewed-by:
Jorge Lucangeli Obes <jorgelo@chromium.org> Reviewed-by:
Luis Hector Chavez <lhchavez@chromium.org> Commit-Queue: Satoshi Niwa <niwa@chromium.org> Cr-Commit-Position: refs/heads/master@{#544966}
-
Yoshifumi Inoue authored
This patch moves line granularity related tests from "VisibleUnitsTest.cpp" to "VisibleUnitsLineTest.cpp" for ease of maintenance. Change-Id: Id1044927113c33c2d9f2fb58e838096b3087189c Reviewed-on: https://chromium-review.googlesource.com/969804 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#544965}
-
https://chromium.googlesource.com/chromiumos/chromite.git/+log/1d37d531d536..8bf5a724397c $ git log 1d37d531d..8bf5a7243 --date=short --no-merges --format='%ad %ae %s' 2018-03-20 manojgupta cbuildbot: Only build virtual/target-fuzzers for fuzzer builders. 2018-03-15 dgarrett archive_lib: Stop appending trybot- for tryjobs. 2018-03-21 dgarrett precq_launcher: Fix swarming PreCQ hack. Created with: roll-dep src/third_party/chromite BUG=chromium:823787,chromium:667393,chromium:823445 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I7abe614767178c4d769dd22efaa488e7e6e9083e Reviewed-on: https://chromium-review.googlesource.com/974743Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#544964}
-
Ahmed Fakhry authored
In this CL: - The browser actions are laid out such that their button sizes match those of other toolbar buttons. - Adds the touchable chrome ink drop style. - Simplifies the logic by baking the icons' paddings inside the views' bounds. BUG=818034 Change-Id: I1da4347eccaaa8283635ec3c521acd63063ff1f3 Reviewed-on: https://chromium-review.googlesource.com/961722 Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#544963}
-
Saman Sami authored
This reverts commit 119455cb. Reason for revert: Seems to cause flakiness in MediaRouterIntegrationBrowserTest.Dialog_Basic Original change's description: > Surface synchronization: Add a diagnostic CHECK in ClientLayerTreeFrameSink > > There's a race in cc somewhere from commit to draw. I don't know exactly > how to repro the race yet even though I have a high probably fix. This > CL is intended to catch the race in the wild and produce a stack trace > in a crash log. Hopefully from there we can acertain repro steps. > > Once repo steps are produced locally (either via user interaction or > unit test) then this CL will be reverted. > > Bug: 672962 > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel > Change-Id: I3bce066591e15d5c3aac7d4c8685dce411e284b7 > Reviewed-on: https://chromium-review.googlesource.com/973987 > Reviewed-by: Saman Sami <samans@chromium.org> > Commit-Queue: Fady Samuel <fsamuel@chromium.org> > Cr-Commit-Position: refs/heads/master@{#544834} TBR=fsamuel@chromium.org,samans@chromium.org Change-Id: I324408ff045908e6d07b1f0e6868e79c10f92db9 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 672962 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/974208Reviewed-by:
Saman Sami <samans@chromium.org> Commit-Queue: Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#544962}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=mmoss@chromium.org Change-Id: Ic1a8d199f85dcfec95303b8307842559f2e00f00 Reviewed-on: https://chromium-review.googlesource.com/974787Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#544961}
-
Junichi Uekawa authored
It seems to have gone missing. BUG=None Change-Id: Ica644858d3f03d0dca7f0e2f206cd92c5bce63fb Reviewed-on: https://chromium-review.googlesource.com/970195Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Junichi Uekawa <uekawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#544960}
-
Lukasz Anforowicz authored
Bug: 801709 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: Ie059475b03953372cf9fcc9ddafd875ebc849e34 Reviewed-on: https://chromium-review.googlesource.com/973942 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Nick Carter <nick@chromium.org> Cr-Commit-Position: refs/heads/master@{#544959}
-
Avi Drissman authored
It hasn't been broadcast as a notification since r369162, more than two years ago. The code that listens for it is dead. BUG=268984 Change-Id: Ia8ed45dcf334c5eb96a8ea4c1fe6706f82b299b3 Reviewed-on: https://chromium-review.googlesource.com/974324Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#544958}
-
Yuwei Huang authored
Make HostViewController call EnableVideoChannel(false) when the app is inactive. This can save some battery for the device. Bug: 824554 Change-Id: Ic468344509bcb9458a592cf4eea8e5b28a939f90 Reviewed-on: https://chromium-review.googlesource.com/974506Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Commit-Queue: Yuwei Huang <yuweih@chromium.org> Cr-Commit-Position: refs/heads/master@{#544957}
-
Yuwei Huang authored
The weak_ptr_ in ChromotingSession seems to be unused. This CL removes it. Bug: 817566 Change-Id: I4f07be8e8047b76ce36f5fe658b17bf6cf45ec72 Reviewed-on: https://chromium-review.googlesource.com/974563Reviewed-by:
Joe Downing <joedow@chromium.org> Commit-Queue: Yuwei Huang <yuweih@chromium.org> Cr-Commit-Position: refs/heads/master@{#544956}
-
Steven Bennetts authored
This CL: * Delays setting Proxy.Type to PAC unless a PAC value is set. * Sets proxyModified_ = true otherwise so that the type is not overridden on an update. * Focus the appropriate input field when the proxy type changes. Bug: 822670 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I0e9a68fc8982d2286e144e57dfe14dc61fa84b1b Reviewed-on: https://chromium-review.googlesource.com/974119 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Toni Barzic <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#544955}
-
Steven Bennetts authored
Currently setting automatic_ may trigger automaticChanged_ before ipConfig_ is set, causing unexpected behavior. We should only trigger the automaticChanged_ function on user action. Bug: 823525 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Id653bb88bb20b22abd9c85d8c1417b2b8355f5ca Reviewed-on: https://chromium-review.googlesource.com/974510Reviewed-by:
-
