GitLab

ExtensionService::PromoteEphemeralApp() now clears the permission
escalation flag as well as enabling the app.

BUG=374018
TEST=browser_tests (EphemeralAppBrowserTest.*)

Review URL: https://codereview.chromium.org/345493002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278089 0039d316-1c4b-4281-b951-d872f2087c98

Based on patch 324913004 by johnme@chromium.org who is on holiday now.

BUG=350378

Review URL: https://codereview.chromium.org/338363003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278087 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278086 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=176360:176407&mode=html
TBR=schenney@chromium.org,jamesr@chromium.org
BUG=

Review URL: https://codereview.chromium.org/347533002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278085 0039d316-1c4b-4281-b951-d872f2087c98

Still to rename: MojoWaitFlagsState and WaitFlagsState (and
wait_flags_state.*).

Also, remove MOJO_WAIT_FLAG_EVERYTHING. People shouldn't use it (since
they'd get unexpected results if we added flags/signals). Tests can
still use ~MOJO_HANDLE_SIGNAL_NONE.

R=sky@chromium.org

Review URL: https://codereview.chromium.org/336313007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278084 0039d316-1c4b-4281-b951-d872f2087c98

Created new StringMappingListPolicyHandler class to provide general
mapping between policy string lists and generic pref types (int lists,
string lists, etc).

BUG=none

Review URL: https://codereview.chromium.org/341723002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278083 0039d316-1c4b-4281-b951-d872f2087c98

This patch fixes various problems in the bisect scripts that were
preventing their use for Chrome for Android. I have only tried these
using run-manual-bisect-test, and there could potentially be
further problems with bisect wrapper scripts.

Also fixes the --use-goma option to actually use Goma, rather than
simply increasing the number of threads.

BUG=none

Review URL: https://codereview.chromium.org/331593007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278082 0039d316-1c4b-4281-b951-d872f2087c98

As noted in https://codereview.chromium.org/10948035, this is not used by anyone in Chromium.

BUG=None
TBR=thakis@chromium.org

Review URL: https://codereview.chromium.org/339343002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278081 0039d316-1c4b-4281-b951-d872f2087c98

Adds also a few additional checks.

BUG=385143

Review URL: https://codereview.chromium.org/336423004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278080 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None

Review URL: https://codereview.chromium.org/340033002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278079 0039d316-1c4b-4281-b951-d872f2087c98

BUG=380825
TEST=run the test

Review URL: https://codereview.chromium.org/341783002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278078 0039d316-1c4b-4281-b951-d872f2087c98

In the compositor API example gcc 4.9 reports a possible
type narrowing when using fabs call. To fix this use fabsf instead.

BUG=385988
R=dmichael

Review URL: https://codereview.chromium.org/335383003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278076 0039d316-1c4b-4281-b951-d872f2087c98

based on
https://codereview.chromium.org/291193007/
https://codereview.chromium.org/278343002/

BUG=365710

Review URL: https://codereview.chromium.org/315923003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278073 0039d316-1c4b-4281-b951-d872f2087c98

Re-styled the App Info Dialog again according to new UI feedback. This
involves moving the 'Remove' and 'Create Shortcuts' buttons into a new
AppInfoFooterPanel, which is displayed at the bottom of the app info
dialog.

Depends on review https://codereview.chromium.org/327743002/.

BUG=266739

Review URL: https://codereview.chromium.org/335523002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278072 0039d316-1c4b-4281-b951-d872f2087c98

-While we're doing the initial scan of files to build up
 computed_hashes.json, if we notice a mismatch, report that right
 away. This also fixes problems where if you modify/delete
 computed_hashes.json, enforcement would never work.

-Avoid an infinite loop in ContentVerifyJob by making sure we stop
 checking newly read bytes after we've already reported a failure
 (we were stuck failing to advance to the next block after reporting
  a failure)

BUG=375992,375953

Review URL: https://codereview.chromium.org/329303007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278071 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278068 0039d316-1c4b-4281-b951-d872f2087c98

BUG=383435
TBR=reed@google.com,humper@google.com

Review URL: https://codereview.chromium.org/347583002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278067 0039d316-1c4b-4281-b951-d872f2087c98

(We could probably also get rid of a third one, namely the one used by
CHECK_EQ, etc. But I'd do that separately.)

R=brettw@chromium.org

Review URL: https://codereview.chromium.org/340573005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278066 0039d316-1c4b-4281-b951-d872f2087c98

Does not compile on Linux GN:
http://build.chromium.org/p/chromium.linux/builders/Linux%20GN%20%28dbg%29/builds/7304/steps/compile/logs/stdio

> gpu: Add base class for gpu service tests
> 
> This allows for properly setting up and tearing down GL bindings.
> Before this patch bindings were intialized in unittest_main.cc but also
> reinitialized with a different GL version and extension in some
> GLES2CmdDecoderTests which leaves room for problems depending on which order
> tests happen to run in.
> 
> More importantly, this will allow me to initialize GL bindings with a certain
> GL version and extension bindings for some tests.
> 
> Review URL: https://codereview.chromium.org/332303002

TBR=sievers@chromium.org

Review URL: https://codereview.chromium.org/346573002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278064 0039d316-1c4b-4281-b951-d872f2087c98

This change implements the OAuth2 implicit flow to fetch a third party token from the user.
1. Introduces a class ThirdPartyTokenFetcher to pop up a third party login page located at |tokenurl| in the browser.
2. Introduces a class OAuthRedirectActivity, which has an intent filter declared in the manifest to intercept the redirect URI upon a successful login.
3. It then starts the chromoting activity, which uses the ThirdPartyTokenFetcher to extract the code and token from the URI and pass it into the native component using JNI.

BUG=329109

Review URL: https://codereview.chromium.org/337013002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278062 0039d316-1c4b-4281-b951-d872f2087c98

Remove the operator to avoid misuse like the following:
  TRACE_EVENT1("a", "b", "c",
     condition ? TRACE_STR_COPY(short_live_string) : "literal");
In the above case, the argument value is actually const char*, not
TraceValueWithCopy because it is automatically converted back to
const char* with the const char* operator.

Found no errornous usages in chromium, but found one error in WebKit.

R=dsinclair
BUG=382789 (perhaps the reason)

Review URL: https://codereview.chromium.org/338653005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278061 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/342543002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278060 0039d316-1c4b-4281-b951-d872f2087c98

This allows for properly setting up and tearing down GL bindings.
Before this patch bindings were intialized in unittest_main.cc but also
reinitialized with a different GL version and extension in some
GLES2CmdDecoderTests which leaves room for problems depending on which order
tests happen to run in.

More importantly, this will allow me to initialize GL bindings with a certain
GL version and extension bindings for some tests.

Review URL: https://codereview.chromium.org/332303002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278059 0039d316-1c4b-4281-b951-d872f2087c98

BUG=132332

Review URL: https://codereview.chromium.org/261993006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278058 0039d316-1c4b-4281-b951-d872f2087c98

to find suitable tests running on MFYI

TBR=bruening@chromium.org
BUG=NONE

Review URL: https://codereview.chromium.org/344583004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278056 0039d316-1c4b-4281-b951-d872f2087c98

This CL fixes an issue where the ContentsSwitcherView would dereference a
pointer to a freed ContentsView.

BUG=384957

Review URL: https://codereview.chromium.org/334293005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278054 0039d316-1c4b-4281-b951-d872f2087c98

Strictly speaking this flag isn't here to force a deterministic build, it's here to help us to make sure that no build metadata ends up in the build artifacts to help us guarantee a deterministic build.

(See the discussion in https://codereview.chromium.org/324403006/ for more details)

FTR, Nico said he'll take care of getting rid of __DATE__ and __TIME__ so this
new define will not be necessary for that.

On the other hand we may have issues with absolute path in __FILE__ and whatever
unforeseen C++ issue. This would require #ifdef'ing them out. This is not
something devs would want to do normally so this flag is off by default.

Eventually we'll want to fix the build system to not have to hack __FILE__ out
by ensuring they are *always* relative paths but until then, this variable can
be used to make progress


R=maruel@chromium.org, thakis@chromium.org
TBR=brettw@chromium.org

BUG=314403

Review URL: https://codereview.chromium.org/330813003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278053 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278052 0039d316-1c4b-4281-b951-d872f2087c98

1928: use all processors instead of hard-coded 8.
1929: Fix msvs-ninja clean build command / target.
1930: ninja: Add option for link concurrency.
1931: Add unittest for 'AR' in 'make_global_settings'
1932: Override the user's language settings during tests
1933: ninja win: Remove old comment, check cc/cxx are always overridden
1934: Use context manager to manage OS environment in tests
1935: Teach Ninja generator about 'AR' in 'make_global_settings'
1936: First crack at adding a GYP_GENERATOR for determining various things
1937: Add unittest for 'LD' in 'make_global_settings'
1938: Remove unused parameters from test code.
1939: Revise unittest for 'LD' in 'make_global_settings'
1940: Revise unittest for 'AR' in 'make_global_settings'
1941: ninja: Read 'LD'/'LD.host' from 'make_global_settings_ld'.
1942: ninja: Read 'AR.host' from 'make_global_settings'.
1943: [gyp][Android] Implement TestGypAndroid.run_built_executable.
1944: ninja: Pass .so files outside of --start-group/--end-group.

BUG=362075,skia:2439,gyp:434
TBR=scottmg@chromium.org

Review URL: https://codereview.chromium.org/332683003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278051 0039d316-1c4b-4281-b951-d872f2087c98

Inform the adapter when a new, potentially unpaired device connects.
In addition to notifying any observers of this event, this prevents a
NULL pointer dereference in the existing logic.

BUG=385493
TEST=Establish a Bluetooth connection from an unpaired device.
     chrome.bluetooth.onDeviceAdded() should be called.
R=keybuk@chromium.org

Review URL: https://codereview.chromium.org/341433004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278050 0039d316-1c4b-4281-b951-d872f2087c98

- Remove local test timeouts;
- Add page flip history to PageFlipWaiter and use that for test expectations
  to solve the problem that a single Wait returns with multiple page flipping
  happened on valgrind;

BUG=385167

Review URL: https://codereview.chromium.org/339933005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278049 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278047 0039d316-1c4b-4281-b951-d872f2087c98

The seek timestamp should always be adjusted by the start time,
though this manipulation should not be visible to external (web)
clients.

Since this is an FFmpeg only problem, I've removed the concept
of start time from the Demuxer interface in favor of local method
only for FFmpegDemuxer.  FFmpegDemuxerStream's will now use this
value to adjust timestamps such that external clients always see
a zero based timeline.

Doing so required moving some of our ogg vorbis discard code into
the FFmpegDemuxerStream, which actually makes it more accurate and
more narrowly scoped to ogg w/ vorbis instead of all vorbis.

These changes subtly change how we handle seeking.  Previously we
would let FFmpeg choose the stream to perform seeking within.  Now
we will use the video stream only if it contains the seek timestamp,
if none exists or does not contain the seek timestamp, we'll use
the stream with the lowest start time.

I've extended the tests around non-zero start times to verify the
new behavior.

An FFmpeg DEPS roll is required for the new tests to pass:
5c3de80 Pass remaining command-line arguments to ffmpeg's configure
de80875 Change the sigs file to use c-style comments.
cb19b2d Update ffmpeg's GN build to use new yasm assemble format.
9c12290 Revert "avformat/mp3dec: fix start time in light of initial skip samples"
1e661a6 avcodec/vorbisdec: Reset first_frame
7d88be4 avformat/oggparsevorbis: Dont attempt to calculate timestamps from gp=0

BUG=377295
TEST=New unittests.  Demo page from bug works.  Layout tests pass.

Review URL: https://codereview.chromium.org/335273002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278046 0039d316-1c4b-4281-b951-d872f2087c98

BUG=383947

Review URL: https://codereview.chromium.org/326963002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278045 0039d316-1c4b-4281-b951-d872f2087c98

BUG=375545
TEST=try to edit an address to add address line 3 in chrome://settings

Review URL: https://codereview.chromium.org/332213004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278044 0039d316-1c4b-4281-b951-d872f2087c98

This test was disabled because it was failing. A few changes have been made:
-The page zoom cannot be assumed to be 100% on load as it will depend on the screen size being tested on. So testPageSize now doesn't make that assumption.
-testAccessibilityWithPage was flaking because accessibility information was not always returned for the two text boxes. I spent a bit of time investigating, but couldn't work it out so I've left it partially disabled for now and filed crbug.com/378091.
-The files have all been moved to a more appropriate location (in particular the test was moved out of the data directory).

BUG=303491

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273819

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274186

Review URL: https://codereview.chromium.org/290803007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278043 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/323693002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278042 0039d316-1c4b-4281-b951-d872f2087c98

BUG=-
TEST=none

Review URL: https://codereview.chromium.org/337423003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278041 0039d316-1c4b-4281-b951-d872f2087c98

This patch adds an optional argument to "tools/perf/run_benchmark help"
to show help for a specific test_runner.py command.

Review URL: https://codereview.chromium.org/309553008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278040 0039d316-1c4b-4281-b951-d872f2087c98

They're not used anymore.

R=abarth@chromium.org
BUG=None

Review URL: https://codereview.chromium.org/333293003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278039 0039d316-1c4b-4281-b951-d872f2087c98