GitLab

BUG=

Review URL: https://codereview.chromium.org/745793002

Cr-Commit-Position: refs/heads/master@{#308139}

BUG=441757
TBR=dbeam@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/798073002

Cr-Commit-Position: refs/heads/master@{#308138}

WeakPtrFactory members should always be last so that they invalidate WeakPtrs prior to other destructors running. These are mostly trivial/mechanical ones.

(We'll also need https://codereview.chromium.org/795003003/, which I split out)

BUG=303818
TBR=rockot,vitalybuka,cbentzel,shess,dmazzoni,stanisc,sky,tim,mathp,benjhayden,kinuko,scottmg,sergeyu,zork,ddorwin

Review URL: https://codereview.chromium.org/780713002

Cr-Commit-Position: refs/heads/master@{#308137}

This changes the way category filter processes multi-categories groups.
Previously, adding a disabled-by-default- category to a regular category
would prevent the event from matching filter if only regular category
is enabled. This is somewhat counter-intuitive, the expected behavior
is that each category is processed by the filter independently. The new
logic is:

1. if at least one category in event category group matches at
least one category enabled in the filter, the event passes;

2. if at least one category in event category group matches at least
one category explicitly excluded in the filter, the event is
filtered out;

3. the event is passed by default, if included categories list is empty
and event has at least one category that is not disabled-by-default-.

Note no existing tests were modified (though I'm not sure if (2) should
be the way it is).

BUG=

Review URL: https://codereview.chromium.org/788243003

Cr-Commit-Position: refs/heads/master@{#308136}

This is the implementation for the following steps of the register
algorithm[1]:

    'If the webapp is already registered, run the following substeps:
     1. Retrieve the push registration associated with the webapp.
     2. If there is an error, reject promise with a DOMException whose
        name is "AbortError" and terminate these steps.
     3. When the request has been completed, resolve promise with a
        PushRegistration providing the details of the retrieved push
        registration.'

Currently the implementation assumes that errors can be recovered from
and attempts to do a fresh push registration if accessing storage
fails; I left a TODO for us to decide this case later.

Depends on https://codereview.chromium.org/785983002

[1]: https://w3c.github.io/push-api/#widl-PushRegistrationManager-register-Promise-PushRegistration

BUG=401422,429212

Review URL: https://codereview.chromium.org/778243002

Cr-Commit-Position: refs/heads/master@{#308135}

Move serving_dirs to UserStorySet, delete Page.archive_path (instead using PageSet.WprFilePathForUserStory).
Update user_story_runner to no longer gate archive-specific logic with instanceof PageSet check.

BUG=439512

Review URL: https://codereview.chromium.org/725133005

Cr-Commit-Position: refs/heads/master@{#308134}

Also, remove the 'set noparent'; that was probably useful when
build/OWNERS had a wildcard, but it doesn't any more.

R=brettw@chromium.org
BUG=

Review URL: https://codereview.chromium.org/793083002

Cr-Commit-Position: refs/heads/master@{#308133}

As per review comments on the issue
https://codereview.chromium.org/573553004/#msg3
removing HistoryService::profile() method.

BUG=430070

Review URL: https://codereview.chromium.org/783963003

Cr-Commit-Position: refs/heads/master@{#308132}

Add power.lock_screen_dim_delay_ms and
power.lock_screen_off_delay_ms prefs that provide alternate
screen-dim and screen-off inactivity delays that are honored
while the screen is locked. They currently default to 30 and
40 seconds, respectively.

BUG=190499

Review URL: https://codereview.chromium.org/793973002

Cr-Commit-Position: refs/heads/master@{#308131}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/0ac8c78..a60b2ea

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=scroggo@google.com

Review URL: https://codereview.chromium.org/798993002

Cr-Commit-Position: refs/heads/master@{#308130}

The patch was useful only when we had forked version of libjingle
checked in in chromium, which hasn't been the case for very long
time.

TBR=hclam@chromium.org

Review URL: https://codereview.chromium.org/794643002

Cr-Commit-Position: refs/heads/master@{#308129}

The histogram was revived in https://codereview.chromium.org/772413004/ but caused jankiness on the UI thread.

BUG=441428

Review URL: https://codereview.chromium.org/800723004

Cr-Commit-Position: refs/heads/master@{#308128}

R=enne, vmpstr

Review URL: https://codereview.chromium.org/785273004

Cr-Commit-Position: refs/heads/master@{#308127}

Introduce iOS-specific implementation of SuggestionsServiceFactory
and an implementation of suggestions::ImageFetcher interface that
uses image_fetcher::ImageFetcher.

BUG=436897

Review URL: https://codereview.chromium.org/790773003

Cr-Commit-Position: refs/heads/master@{#308126}

The native_client_sdk directory contains auto-generated documentation that
includes PNGs that are flagged by the presubmit check. These PNGs are not used
by Chrome, so they should be ignored by the check.

BUG=150046
R=phajdan.jr@chromium.org

Review URL: https://codereview.chromium.org/802463002

Cr-Commit-Position: refs/heads/master@{#308125}

This is just a suggestion to reduce tommi's rubberstamping load.

R=tommi@chromium.org
BUG=None

Review URL: https://codereview.chromium.org/792433003

Cr-Commit-Position: refs/heads/master@{#308124}

Adding configuration protos. We probably want to handle most of these eventually, and some of them (i.e. token length) pretty soon. Adding them now will make it easier later.

Review URL: https://codereview.chromium.org/799793002

Cr-Commit-Position: refs/heads/master@{#308123}

These were only temporarily needed for root-causing some bot
flakiness.

BUG=396568
TBR=feng@chromium.org
NOTRY=True

Review URL: https://codereview.chromium.org/796163003

Cr-Commit-Position: refs/heads/master@{#308122}

Includes change to remove TraceEvent.begin()/end() calls.

BUG=439118

Review URL: https://codereview.chromium.org/792793004

Cr-Commit-Position: refs/heads/master@{#308121}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/f405722d..293e0e5

TBR=lushnikov@chromium.org,vsevik@chromium.org,dglazkov@chromium.org

Review URL: https://codereview.chromium.org/799913003

Cr-Commit-Position: refs/heads/master@{#308120}

Add sdefresne & stuartmorgan to OWNERS of
- //ios/consumer
- //ios/provider
- //ios/public/consumer
- //ios/public/producer

BUG=429756

Review URL: https://codereview.chromium.org/796843003

Cr-Commit-Position: refs/heads/master@{#308119}

Revert of Fix crash when we don't have a plane to display (patchset #2 id:20001 of https://codereview.chromium.org/779173007/)

Reason for revert:
Broke Linux ChromiumOS Ozone.
http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Ozone%20Builder/builds/8423

GetPrimaryPlane was changed to return a pointer, but a callsite was
not modified.

Original issue's description:
> Fix crash when we don't have a plane to display
>
> BUG=434115,438835
>
> Committed: https://crrev.com/208e6bf151685abc68ac836db5afb3543d8a1e92
> Cr-Commit-Position: refs/heads/master@{#308105}

TBR=dnicoara@chromium.org,achaulk@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=434115,438835

Review URL: https://codereview.chromium.org/800053002

Cr-Commit-Position: refs/heads/master@{#308118}

BUG=440405

Review URL: https://codereview.chromium.org/789853002

Cr-Commit-Position: refs/heads/master@{#308117}

This class is a wrapper around net::URLFetcherDelegate that is designed
specifically to fetch images. It will transcode WebP encoded images.

BUG=436897, 441327

Review URL: https://codereview.chromium.org/787903003

Cr-Commit-Position: refs/heads/master@{#308116}

See https://groups.google.com/a/chromium.org/forum/#!searchin/chromium-dev/AppLaunchParams/chromium-dev/uPckpeYSlNA/bwfwZAtbEEkJ
for a discussion of what I'm trying to do, and https://codereview.chromium.org/771003002 for more context of how I'm going to use
this to achieve it.

Review URL: https://codereview.chromium.org/757433004

Cr-Commit-Position: refs/heads/master@{#308115}

Review URL: https://codereview.chromium.org/792443004

Cr-Commit-Position: refs/heads/master@{#308114}

SelectFile() is getting called more than once for the same window
and causing NOTREACHED() failure on linux, since it tries to re-add
the observer.

To fix the failure, this patch adds a check that does an early-return
if the select file dialog is currently being shown to the specified
window.

BUG=432783

Review URL: https://codereview.chromium.org/772983002

Cr-Commit-Position: refs/heads/master@{#308113}

ManagePasswordBubbleView wants to monitor events on a specific window,
currently using aura specific code that won't work for MacViews.
views::EventMonitor is enhanced to support monitoring events on a window,
with both Mac and Aura implementations.

Also includes minor compile fixes in ZoomBubbleView and StatusBubbleView.

Originally reviewed in https://crrev.com/730833006/

BUG=425229

Review URL: https://codereview.chromium.org/793003004

Cr-Commit-Position: refs/heads/master@{#308112}

We always confirm, so we may as well remove the roundtrip together.

BUG=432527

Review URL: https://codereview.chromium.org/803523002

Cr-Commit-Position: refs/heads/master@{#308111}

BUG=437577

Review URL: https://codereview.chromium.org/749183004

Cr-Commit-Position: refs/heads/master@{#308110}

This change was needed for Chromecast, while avoiding adding yet another
preprocessor condition.

BUG=438331

Review URL: https://codereview.chromium.org/790903003

Cr-Commit-Position: refs/heads/master@{#308109}

Prior instrumentations showed that most of jank (13.3) comes from URLRequestJob::Read.

BUG=423948

Review URL: https://codereview.chromium.org/790723004

Cr-Commit-Position: refs/heads/master@{#308108}

BUG=435064

Review URL: https://codereview.chromium.org/743123002

Cr-Commit-Position: refs/heads/master@{#308107}

The kInstantProcess flag was used to check if the current frame belongs to instant and should be whitelisted. This would cause layering troubles once ContentSettingsObserver is componentised.

Instead, this CL moves the check back to the construction of the observer, in ChromeContentRendererClient, and only records the Boolean flag for whitelisting in the observer.

BUG=384874

Review URL: https://codereview.chromium.org/797993002

Cr-Commit-Position: refs/heads/master@{#308106}

BUG=434115,438835

Review URL: https://codereview.chromium.org/779173007

Cr-Commit-Position: refs/heads/master@{#308105}

Revert of suppress svg test until next blink roll (patchset #1 id:1 of https://codereview.chromium.org/801853002/)

Reason for revert:
blink roll has landed, so this is unneeded

Original issue's description:
> suppress svg test until next blink roll
>
> BUG=
> NOTRY=True
>
> Committed: https://crrev.com/85f7f361478f35bad79e180b69711e6923f886bd
> Cr-Commit-Position: refs/heads/master@{#308093}

TBR=fmalita@chromium.org,bungeman@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=

Review URL: https://codereview.chromium.org/798873003

Cr-Commit-Position: refs/heads/master@{#308104}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/8e6fc6d..f405722d

TBR=lushnikov@chromium.org,vsevik@chromium.org,dglazkov@chromium.org

Review URL: https://codereview.chromium.org/795353007

Cr-Commit-Position: refs/heads/master@{#308103}

Extensions that ship with plugins may use them. Since the viewer is a
builtin plugin, it doesn't get whitelisted by the usual mechanism.
Explicitly whiltelist it.

BUG=409813
R=bauerb@chromium.org

Review URL: https://codereview.chromium.org/794903005

Cr-Commit-Position: refs/heads/master@{#308102}

BUG=441785
TBR=jbauman@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/800923003

Cr-Commit-Position: refs/heads/master@{#308101}

Refactoring of ProtectedMediaIdentifierPermissionContext to derive from
PermissionContextBase class to conform with other APIs like geolocation
and midi. This has the advantage of less code and a consistent path for
all permissions. Also it makes it easier to implement PermissionService
because some functionality like HasPermission() can be implemented at
the level of PermissionContextBase.

Also add the corresponding UMA bits in histograms.xml and
permission_context_uma_util.cc.

BUG=

Review URL: https://codereview.chromium.org/769103002

Cr-Commit-Position: refs/heads/master@{#308100}