- 22 Jan, 2021 40 commits
-
-
Shane Fitzpatrick authored
In the case where only 1 item is being sent, the spec calls for the format '<item_type> received...'. The previous functionality had it as '1 <item_type> received...'. This change aligns the strings to the spec. I opted for separate capitialized and non-capitialized version to reduce the risk of a runtime determination being wrong for some locales. Confirmed with Shiba that this new functionality is as expected. Fixed: 1158069 Change-Id: I2d12e305aa52b7c52389c71f53c6c5586f13be44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643696Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Commit-Queue: Shane Fitzpatrick <shanefitz@google.com> Cr-Commit-Position: refs/heads/master@{#846310}
-
Daniel Hosseinian authored
Also check-in the requisite encrypted PDF. Fixed: 1167036 Change-Id: I4234d3bfd3cb600907f3e9262e64aaf3cace9e8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638916 Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#846309}
-
Eugene But authored
Bug: None Change-Id: If9375f350e354325a6eccd56ab47ace3d3c7130a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642755Reviewed-by:
Ali Juma <ajuma@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#846308}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/bf47f1bdf381..8ce2fad80022 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC katydek@google.com,nsatragno@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1138953,chromium:1150968,chromium:1169257 Tbr: katydek@google.com,nsatragno@google.com Change-Id: Ibf7adf0821311ebc64d322918f73ddffc99ac6ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2644734Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#846307}
-
Yicheng Li authored
https://chromium.googlesource.com/chromiumos/platform2/system_api.git/+log/1ee85a708f6a..2260ccd36830 $ git log 1ee85a708..2260ccd36 --date=short --no-merges --format='%ad %ae %s' 2021-01-13 yichengli u2fd: Add API to check whether u2f is enabled 2021-01-16 kimjae minios: Add DBus adaptor + service to minios Created with: roll-dep src/third_party/cros_system_api Bug: b/165724836 Change-Id: Iad34f9b1bb781bbf1742d66f17cd10bef84134ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2645208 Commit-Queue: Yicheng Li <yichengli@chromium.org> Commit-Queue: Martin Kreichgauer <martinkr@google.com> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#846306}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/5397151e88ff..07bd252238b7 2021-01-22 ehmaldonado@chromium.org Change whitespace.txt If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: I7c0ece816639446208d408796eaaf0fdaba6a3a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2645326Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#846305}
-
Katie Dektar authored
Bug: 1046784 Change-Id: I2779fd3a8ac092ab7f4cb69b77ae44740f3ab8f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2645204 Commit-Queue: Katie Dektar <katie@chromium.org> Auto-Submit: Katie Dektar <katie@chromium.org> Reviewed-by:
Nina Satragno <nsatragno@chromium.org> Cr-Commit-Position: refs/heads/master@{#846304}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/72cd1a5e8953..2c32fa647608 2021-01-22 cwallez@chromium.org Make ComboVertexStateDescriptor non-copyable non-movable. 2021-01-22 enga@chromium.org d3d12/vulkan: Skip descriptor update/creation if resource is destroyed If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC sarahmashay@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: sarahmashay@google.com Change-Id: Ia52a17b6185cb08d38cf0de371696e9c212572c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2644729Reviewed-by:
-
Xida Chen authored
This CL is intended to fix a flaky layout test. I cannot repro the flakiness locally, so this would be a speculative. We suspect that when the test ends, even though the text matches exactly, the rendering of the result is not updated yet so we need another rendering frame to show the correct result. Bug: 623434 Change-Id: Ib1a521114d31db9d698929761d9e4cd928798e60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2644722Reviewed-by:
Kevin Ellis <kevers@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#846302}
-
Rohan Pavone authored
Defines web_engine_shell target in isolate map, while also adding additional build targets for fuchsia-builder-perf-fyi. Change-Id: I9e11dda427f6461ce948ba104a7e09d1657511d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2644345Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Rohan Pavone <rohpavone@chromium.org> Cr-Commit-Position: refs/heads/master@{#846301}
-
Alice Gong authored
Implement OAuth2 authentication flow for Box to obtain authorization, refresh token, and access token using a pop-up window, and store tokens into profile prefs. This is part of a series that will eventually, if enabled by enterprise admin, replace regular DownloadItemRenameHandler with FileSystemConnectorRenameHandler, which uses FileSystemConnector to redirect downloaded local temporary files to get uploaded through a series of BoxApiCallFlow steps. This CL does the following: 1/ Create new profile prefs to hold the OAuth2 tokens needed for file system connectors. (connectors/connectors_prefs.h/cc) 2/ Implement UX for gathering Box user consent. This is being implemented as pop-up window hosting the Box consent flow, much like the force sign in dialog hosts the Google sign in flow. (connectors/ file_system/signin_dialog_delegate.h/cc) 3/ Implement OAuth2 flow to mint access and refresh tokens from user consent’s auth_code. 4/ Implement OAuth2 flow to mint access and refresh tokens from the previous refresh token. (connectors/file_system/ box_access_token_fetcher.h/cc) BUG=1168607 Change-Id: If4882440315151a7cc23f2a6f56430bdb2bc09bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2591667 Commit-Queue: Alice Gong <alicego@google.com> Auto-Submit: Alice Gong <alicego@google.com> Reviewed-by:
Nicolas Ouellet-Payeur <nicolaso@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Reviewed-by:
Marc-André Decoste <mad@chromium.org> Reviewed-by:
Dominique Fauteux-Chapleau <domfc@chromium.org> Cr-Commit-Position: refs/heads/master@{#846300}
-
Tommy Li authored
Currently, when Chrome adds a new engine from the OpenSearch description file, it can delete the Default Search Engine if it is is safe_for_autoreplace() and not prepopulated. This is an edge case, but there are crash reports of this triggering our CHECK. From what I can tell, this issue has existed for a long time, but was never caught because we had a DCHECK instead of a CHECK. This CL does two things: 1. Prevents that happening by no longer returning an |existing_engine| from the CanAddAutogeneratedKeyword() method. Since Add() can now automatically do ranking and deduplication, there's no need for the caller to manually Remove() engines like before. 2. Makes OpenSearch outrank form-search autogenerated engines in TemplateURL::IsBetterThanEngineWithConflictingKeyword(). We always treated it this way, but this formalizes it in our sorting function, which helps us build our total ordering of TemplateURLs. In summary: This CL makes the auto-generated engine adding logic reuse our existing deduplication logic, rather than relying on its own custom logic, which didn't respect the default search provider. This is meant to be merged into M89. Bug: 1166372 Change-Id: I410a0f8870f65cd16001f5ebd120ccbf04aadd93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2644936Reviewed-by:Peter Kasting <pkasting@chromium.org> Reviewed-by:
Orin Jaworski <orinj@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#846299}
-
Nathan Zabriskie authored
Currently with some texture sizes GLES2Util::ComputeImageDataSizesES3 will attempt to add row padding when calculating the size of a VideoFrame plane. This is because it's currently assumed that each row aligns on a 4 byte boundary based on GL_UNPACK_ALIGNMENT but VideoFrames make no such guarantee as they may be densely packed. This CL removes the GL_UNPACK_ALIGNMENT assumption so that we only use the VideoFrame's stride when calculating padding. Bug: 1166504, 1161131 Change-Id: I2484f5dfd2ad85b088fee57758776a5c9bd01d95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642765Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Commit-Queue: Nathan Zabriskie <nazabris@microsoft.com> Cr-Commit-Position: refs/heads/master@{#846298}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/1d5174b9dc3b..3fe96b789504 2021-01-22 capn@google.com Target macOS 10.14 on ARM64 to enable C++17 2021-01-22 bclayton@google.com Merge changes I6c21b03d,Ic6136d02,I988c0288,I21d11818,I79fa8162, ... 2021-01-21 capn@google.com Implement non-void indirect Reactor Call() support 2021-01-21 amaiorano@google.com Make RoutineT::getEntry() type safe 2021-01-21 swiftshader.regress@gmail.com Regres: Update test lists @ b3e5c440 2021-01-21 capn@google.com Target macOS 10.12 when building LLVM 2021-01-21 capn@google.com Use aligned allocation for classes with aligned members 2021-01-21 nicolascapens@google.com Enable and require C++17 compilation If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I00e926222eb0c3c21c1eca6556da874af335badb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2645058Reviewed-by:
-
yilkal authored
This cl makes sure that the dialog size and bounds are consistent with the rest of onboarding flow. Bug: 1169786 Change-Id: Ie433562bf353a287eaa8449cc8e50c27c0bce4b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2645298Reviewed-by:
Dan S <danan@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Yilkal Abe <yilkal@chromium.org> Cr-Commit-Position: refs/heads/master@{#846296}
-
Andre Vincent authored
As of now, the Drive Service fetches an access token. Fixed: 1166345 Change-Id: I9446d5811ea1726c8865c7f3604da1554cce4fe5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628048 Commit-Queue: Andre Vincent <andrevincent@google.com> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#846295}
-
Klaus Weidner authored
The onbeforexrselect event is supposed to be part of GlobalEventHandlers and separately inherited by {HTML,MathML,SVG}Element, Window, and Document. The current implementation had added it at the Element level which isn't correct, causing test failures in the idlharness test. Update the implementation to fix the inheritance, which unfortunately adds a bit of extra boilerplate. Also add objects to the idlharness test to verify the inheritance. Spec: https://immersive-web.github.io/dom-overlays/#onbeforexrselect Fixed: 1108685 Change-Id: I8df73304b7b2d9bd93df30b78953aa9b378f8cad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317813 Commit-Queue: Klaus Weidner <klausw@chromium.org> Reviewed-by:Philip Jägenstedt <foolip@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#846294}
-
Reilly Grant authored
This change converts callbacks from base::Bind and base::Callback to Once/Repeating in //chrome/browser/chromeos/app_mode. Bug: 1148570 Change-Id: I92338ffa90e975cf9c79e151f2c784a55ddd2556 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2645404 Commit-Queue: Reilly Grant <reillyg@chromium.org> Commit-Queue: Sergey Poromov <poromov@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Auto-Submit: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#846293}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1611316382-256aee3c7474e8e8ef074b7619cf9a4131f41980.profdata to chrome-mac-master-1611338398-fa58905b438c50560fef9145146b7c6ec25beb1e.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I67b394ba47370b8116884835e0a51d44fa6e297b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2645325Reviewed-by:
-
Gauthier Ambard authored
This CL ensures that the fakebox width is correct when the screenshot of the NTP is taken. It was wrong as the width was first computed while the collection view had a zero width. The width is now re-computed when the NTP is added to its parent ViewController. Fixed: 1165956 Change-Id: I63cf57584fe185280956779791973495092dfbb9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640440 Auto-Submit: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#846291}
-
Roberto Carrillo authored
Also, accept a flag on builder() to specify this, but make it False by default. R=chanli,nodir,bpastene@chromium.org Bug: 1074407 Change-Id: Ic27a484138f7ccedab2f0daebed4bccc448a435d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2644319 Commit-Queue: Roberto Carrillo <robertocn@chromium.org> Reviewed-by:
Nodir Turakulov <nodir@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Reviewed-by:
Chan Li <chanli@chromium.org> Cr-Commit-Position: refs/heads/master@{#846290}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/5b2a5204087d..57144c8685d3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I739bd6b4cdda298c4d9bdc58d4684fe389806a8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2644524Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1611316382-94c9fd181d84cd42486f5188444029563baefc6b.profdata to chrome-linux-master-1611338398-a577d8d6149e541857ea88692e66f5943d6a799b.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I171a65164c559f4147ebe0b8b95f160d7a130012 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2645324Reviewed-by:
-
Victor Costan authored
This CL replaces calls to base::TaskEnvironment::RunUntilIdle() with a base::RunLoop that is Quit() when the tested function's base::Callback is executed. A few minor cleanups are included. Change-Id: I94488c922df13fe67bdd246c80c7f15064a1bda8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2644144 Commit-Queue: Jarryd Goodman <jarrydg@chromium.org> Reviewed-by:
Jarryd Goodman <jarrydg@chromium.org> Auto-Submit: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#846287}
-
Jonah Chin authored
This CL parameterizes PaintCanvasVideoRendererWithGLTests to run tests with and without OOP raster. It also updates RasterInProcessContext to use the thread's task runner instead of TestSimpleTaskRunner. This ensures that OOPR tests can still use base::RunLoop::Run to trigger their posted callbacks. Bug: 1115217 Change-Id: I663bf6c2cb9ce2d13222a2bb8bc7f6189a91e517 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519172Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Commit-Queue: Jonah Chin <jochin@microsoft.com> Cr-Commit-Position: refs/heads/master@{#846286}
-
Mikel Astiz authored
In this patch, GaiaScreenHandler adds support to deal with the received sync trusted vault keys. This information is wrapped in a new class (SyncTrustedVaultKeys) and propagated via UserContext to UserSessionManager, where during profile preparation is propagated to SyncService and consumed. Browser tests are introduced to exercise the whole integration, from the server (FakeGaia) to the final storage (TrustedVaultClient). Change-Id: I3cdc16086b2eec2b2a603255ed644c7b1f53192e Bug: 1081651 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2590035 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#846285}
-
Mohamed Amir Yosef authored
... in AutofillBubbleHandler. Before this patch: Each bubble used to call the enum value using its own class name. (specifically SaveCardBubbleViews and LocalCardMigrationBubbleViews) After this patch: LocationBarBubbleDelegateView is used instead when referring to USER_GESTURE and AUTOMATIC enum values. Change-Id: I4bfb79713443f608cee6d245af8c2064793e6d3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2644624 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Auto-Submit: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#846284}
-
Martin Rodriguez authored
In policy_test_cases.json there is a typo in the test definition of `ClearBrowsingDataOnExitList`, `policy_pref_mapping_test` (the suffix should be `tests`). This typo make to skip this test. This CL fix this typo making the policy mapping be tested. Bug: b/178171564 Change-Id: Id432006e15ad7747de1ea0e12c152aca28cb0be6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643722Reviewed-by:
Alexander Hendrich <hendrich@chromium.org> Commit-Queue: Martin Rodriguez <rodmartin@google.com> Cr-Commit-Position: refs/heads/master@{#846283}
-
Jeffrey Young authored
This is a reland of d82af7a9 Move ambient photo controller reset to fix use-after-free. Fix possible race condition with |AmbientPhotoController| by clearing photo cache upon sending network request to update settings. Old behavior showing bug: * User toggles on Ambient Mode, changes photo setting * |UpdateSettings| is called and sends network request * User toggles off Ambient mode, |AmbientPhotoController| is destructed * Network request resolves and |AmbientPhotoController::ClearCache| is called Original change's description: > ambient: construct photo_controller on enabled > > AmbientPhotoController and AmbientPhotoCache are only necessary > when a user is logged in and ambient mode is enabled. Construct them > at that time, and destruct them if ambient mode is disabled. > > Schedule fetching backup images when AmbientPhotoController is > constructed, rather than in OnFirstSessionStarted. > > BUG=b:176094707 > TEST=ash_unittests --gtest_filter="AmbientControllerTest.*" > > Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome > Change-Id: Id87bb16e6d4cc14074dd9bdb352fb5795d0f8915 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605744 > Commit-Queue: Jeffrey Young <cowmoo@chromium.org> > Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org> > Reviewed-by: Tao Wu <wutao@chromium.org> > Reviewed-by: Jeroen Dhollander <jeroendh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#842133} Bug: b:176094707 Change-Id: I485fef447e6afb92ac5f66a7991e7ec477be30da Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626511 Commit-Queue: Jeffrey Young <cowmoo@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#846282}
-
Christian Biesinger authored
No need for this test to be async; I think this was copy-pasted from the video or img test which do need async. R=masonfreed@chromium.org Change-Id: I0f9a6e651fa3914fb8ae35ec8cd856cc839a8e25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643071 Auto-Submit: Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Mason Freed <masonfreed@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#846281}
-
Mark Edward Winter authored
Use constexpr maps when possible inside the browser/ui directories R=chromium-chrome-browser-ui-views-reviews@google.com Bug: 1150744 Change-Id: I2ecfc10c911d6242cf7bafafe9878673a9ba2c06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642384Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Allen Bauer <kylixrd@chromium.org> Cr-Commit-Position: refs/heads/master@{#846280}
-
Michael Thiessen authored
We can get into a situation where an Activity is finished before Deferred startup finishes, then the old DeferredStartupHandler finishes during startup of the next test and a new instance is created before we wait for deferred startup completion. The solution is just to hold onto the DeferredStartupHandler instance in tests during startup to ensure a new instance isn't created. The test that's actually flaky under these circumstances is TabbedActivityLaunchCauseMetricsTest#testMainIntentMetrics Change-Id: I4e172f77c3ebad45f5b3236b68614b2b152c718c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643030Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#846279}
-
Michael Hansen authored
This change lets us observe screen idle state (on/off state) so that we can invalidate send and receive surfaces in response. This also collapses PowerClientChromeos into PowerClient since we no longer need to guard Chrome OS-specific functionality. Fixed: 1169262 Change-Id: I893df57d113590c0e09a81a381c3a291b74fd00a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643918Reviewed-by:
-
Jun Mukai authored
On the failed case of ui.HotseatAnimation tast test, app-list is actually animating, and HomeLauncherStateWaiter is not used, thus the callback is never invoked. This CL cleans up the condition for HomeLauncherStateWaiter to be used. Note: this CL also adds a test case of autotestPrivate API. However, this new test case does NOT reproduce the reported problem -- it passes even without the change of autotest_private_api_utils.cc. I couldn't find the way to reproduce the reported problem within browser_tests. Still, I think it's better to have a basic test case of waitForLauncherState in tablet-mode, as its internal code path is significantly different. Bug: 1167225 Test: ui.HotseatAnimation.non_overflow_shelf tast test Change-Id: I33352f216af795e20d651942ce219feb5c4f052a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640928 Commit-Queue: Jun Mukai <mukai@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Reviewed-by:
-
Fabian Sommer authored
This CL implements the core part of SecurityTokenSessionController. The controller observes security tokens and triggers lock / logout when a token that was used for login is removed, alongside UI implemented in previous CLs. This behavior can be controlled by the SecurityTokenSessionBehavior and SecurityTokenSessionNotificationSeconds policies, which this CL activates. This CL also adds browser tests for both policies. In doing so, it also adds a test for SecurityTokenRestrictionView. The CL renames the should_fail_certificate_requests property in TestCertificateProviderExtension to should_provide_certificates, which more accurately reflects its purpose. Fixed: 1131450 Change-Id: I8cf4e25fbbcb8ae4ab607ace254a85197f594f5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632990 Commit-Queue: Fabian Sommer <fabiansommer@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#846276}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/bef4c393..783a881e Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I82258411117e2f8f0b647cf54410211e72f21de5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2644639Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#846275}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/cc6961b9ac5e..793871779799 2021-01-22 johnstiles@google.com Update folding tests to return pass/fail status. 2021-01-22 johnstiles@google.com Add checkpointing functionality to the Parser. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC scroggo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: scroggo@google.com Change-Id: Ia4b973008a18377d790f17908d30cf2de494ff48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643189Reviewed-by:
-
Abigail Klein authored
one of their languages. Since Live Caption currently only works for English, we should not advertise the feature to users who we do not expect to want English captions. We can make a guess as to which users would want English caption by checking whether English is one of the user's fluent languages, found in chrome://settings/languages. Bug: 1169760, 1055150 Change-Id: Id16e99de1edb777b8d5b2d793f0dcbefc925935d AX-Relnotes: Live Caption only promoted to English-language users. Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643443Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Abigail Klein <abigailbklein@google.com> Cr-Commit-Position: refs/heads/master@{#846273}
-
Yusuke Sato authored
The function has been moved to platform2/arc/setup/. BUG=chromium:1163122 TEST=try Change-Id: I12fe15ee0d86a5be443f27ec7640e0298114102b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611179 Commit-Queue: Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Cr-Commit-Position: refs/heads/master@{#846272}
-
Wenyu Fu authored
Fix the flaky test by adding a dummy view. This helps collecting the focus when it is cleared in RadioButtonWithEditText. This is however a short-term solution and should be revisited with a fix on the widget itself. For more details see the original crbug. Change-Id: Ibae61514ffc98c253db4a8bd63498967178d523f Bug: 1169215 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2644935 Commit-Queue: Wenyu Fu <wenyufu@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#846271}
-
