GitLab

If we receive a data frame without a status or without
a version header, we close the stream with a PROTOCOL ERROR.

Small bug fix to HttpNetworkTransaction to access the
ResponseHeaders only if headers are there.

In SpdyStream, retrun a SPDY_PROTOCOL_ERROR if we have pending
data frames, but we haven't received "status" and "version"
headers. (rch: removed the DCHECK for unit tests).

SpdyHttpStream's OnDataReceived used to expect that it would
be called only when all required headers are received. Converted
the DCHECK into an error condition and SpdyStream closes the
stream with PROTOCOL ERROR if OnDataReceived returns a network
error.

BUG=135485
R=rch@chromium.org
TEST=network unittests

Review URL: https://chromiumcodereview.appspot.com/10836084

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150121 0039d316-1c4b-4281-b951-d872f2087c98

R=scottbyer@chromium.org,shishir@chromium.org
BUG=140466


Review URL: https://chromiumcodereview.appspot.com/10825188

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150120 0039d316-1c4b-4281-b951-d872f2087c98

(Try bots currently failing on pak build. Not sure that this is the cause, but
I don't see a lot of other plausible candidates. I'll revert this revert if it
doesn't help.)

R=scottmg,joi
BUG=123026

Review URL: https://chromiumcodereview.appspot.com/10832121

TBR=iannucci@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10834182

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150118 0039d316-1c4b-4281-b951-d872f2087c98

We had fixed race condition bugs with checnked upload
in http://src.chromium.org/viewvc/chrome?view=rev&revision=146255

We had renamed all SpdyHttpStreamSpdyTest.* tests as
SpdyHttpStreamSpdy2Test and SpdyHttpStreamSpdy3Test and the old suppression
is not needed. We have been running SpdyHttpStreamSpdy*Test* for a while.

R=rnk@chromium.org
BUG=95007
TEST=valgrind unittests
Review URL: https://chromiumcodereview.appspot.com/10852005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150117 0039d316-1c4b-4281-b951-d872f2087c98

This is the first step toward implementing crbug.com/136816 (Implement dragging window from one display to another).

BUG=136816
TEST=try

Review URL: https://chromiumcodereview.appspot.com/10835047

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150116 0039d316-1c4b-4281-b951-d872f2087c98

Chrome uses "id" as the Indonesian language code while Android uses the
deprecated code "in". Similarly for Yiddish. This handles translating
between the two.

BUG=
TEST=


Review URL: https://chromiumcodereview.appspot.com/10701179

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150115 0039d316-1c4b-4281-b951-d872f2087c98

BUG=139700


Review URL: https://chromiumcodereview.appspot.com/10807088

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150112 0039d316-1c4b-4281-b951-d872f2087c98

Try to get more information to track down 140054, specifically to see whether OnChannelError is being called.
Review URL: https://chromiumcodereview.appspot.com/10836115

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150111 0039d316-1c4b-4281-b951-d872f2087c98

Gyp targets shouldn't contain source with identical basenames.

Fallout from http://src.chromium.org/viewvc/chrome?view=rev&revision=149842


Review URL: https://chromiumcodereview.appspot.com/10828152

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150110 0039d316-1c4b-4281-b951-d872f2087c98

BUG=133109
R=cpu
Review URL: https://chromiumcodereview.appspot.com/10853008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150109 0039d316-1c4b-4281-b951-d872f2087c98

BUG=139576

Review URL: https://chromiumcodereview.appspot.com/10826132

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150108 0039d316-1c4b-4281-b951-d872f2087c98

  which one it was in logs.

Review URL: https://chromiumcodereview.appspot.com/10825199

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150107 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150106 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/10854006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150105 0039d316-1c4b-4281-b951-d872f2087c98

OnSetIcon (and OnSetText) were removed in crrev.com/111858.
That was a speculative fix for crbug.com/97808.

DefWindowProc for WM_SETICON does weird non-client painting.
We need a ScopedRedrawLock to avoid flickering on title/icon updates.

TEST=No Windows classic theme titlebar flickering.
BUG=97808,140674

Review URL: https://chromiumcodereview.appspot.com/10826160

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150104 0039d316-1c4b-4281-b951-d872f2087c98

BUG=140336
TBR=oshima

Review URL: https://chromiumcodereview.appspot.com/10829175

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150103 0039d316-1c4b-4281-b951-d872f2087c98

BUG=140265
R=sadrul

Review URL: https://chromiumcodereview.appspot.com/10836094

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150102 0039d316-1c4b-4281-b951-d872f2087c98

Also hides tray before login.

BUG=137155
TBR=sky@chromium.org (for ash_strings.grd)

Review URL: https://chromiumcodereview.appspot.com/10834164

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150101 0039d316-1c4b-4281-b951-d872f2087c98

IN_PROC_BROWSER_TEST_F(Foo, PRE_Bar) {
  do something
}

IN_PROC_BROWSER_TEST_F(Foo, Bar) {
  verify something persisted from before
}

This is recursive, so PRE_PRE_Bar works.
Review URL: https://chromiumcodereview.appspot.com/10832106

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150096 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=net_unittests

Review URL: https://chromiumcodereview.appspot.com/10824081

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150095 0039d316-1c4b-4281-b951-d872f2087c98

BUG=114631
TEST=Open Google Talk.  Try to alt+tab away from it, and then back.


Review URL: https://chromiumcodereview.appspot.com/10700057

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150094 0039d316-1c4b-4281-b951-d872f2087c98

(previously 149749).

Again, we use the interface to use the cache when available, or to
load from a temporary file in incognito, when the cache is not available.

Differences from previous try:
* double-fd-close bug.
* compiler warnings that show up in scons build.

BUG= http://code.google.com/p/nativeclient/issues/detail?id=2683

Review URL: https://chromiumcodereview.appspot.com/10834173

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150093 0039d316-1c4b-4281-b951-d872f2087c98

I regressed this in r149891.

BUG=140689

Review URL: https://chromiumcodereview.appspot.com/10853018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150092 0039d316-1c4b-4281-b951-d872f2087c98

Not used anywhere yet.

BUG=138550

Review URL: https://chromiumcodereview.appspot.com/10836105

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150091 0039d316-1c4b-4281-b951-d872f2087c98

BUG=140248
TEST=Install pkidpnnapnfgjhfhkpmjpbckkbaodldb from the web store, wait for it to finish downloading voice data, then turn speech feedback on/off with Ctrl+Alt+Z and you should hear the high-quality voice.
TBR=derat
Review URL: https://chromiumcodereview.appspot.com/10850018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150089 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150088 0039d316-1c4b-4281-b951-d872f2087c98

TBR=dimich@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10855003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150087 0039d316-1c4b-4281-b951-d872f2087c98

Reviewers:
Ben Goodger: chrome/browser/ui/views/download/download_item_view.*, chrome/browser/plugin_installer.*, chrome/browser/automation/automation_provider.cc
rdsmith, asanka: all
Nico (thakis): chrome/browser/ui/cocoa/download/download_item_mac.*
Achuith: chrome/browser/chromeos/gdata/gdata_download_observer.*
Evan (estade): chrome/browser/ui/gtk/download/download_item_gtk.*, chrome/browser/ui/webui/downloads_dom_handler.*
Scott (sky): chrome/browser/history/history_unittest.cc
Aaron (aa): chrome/browser/extensions/webstore_installer.*

Add DownloadItem::Observer::OnDownloadRemoved() to signal when a download is being removed from history.
Make chrome.downloads.onErased trigger from DownloadItem::Observer::OnDownloadRemoved() so that extensions don't think that all downloads are being erased just because the browser is closing.

Review URL: https://chromiumcodereview.appspot.com/10704026

BUG=140687
TBR=benjhayden@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10831177

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150086 0039d316-1c4b-4281-b951-d872f2087c98

Refactor GrabWindowSnapshot and GrabWindowSnapshotImpl names to GrabWindowSnapshotForUser and GrabWindowSnapshot respectively.
Use GrabWindowSnapshot (the old internal version) in tests.


BUG=139694


Review URL: https://chromiumcodereview.appspot.com/10830158

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150085 0039d316-1c4b-4281-b951-d872f2087c98

BUG=138921

Review URL: https://chromiumcodereview.appspot.com/10824164

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150084 0039d316-1c4b-4281-b951-d872f2087c98

It fails flakily.

BUG=chromium:140765
TBR=satish@chromium.org, hans@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10824179

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150083 0039d316-1c4b-4281-b951-d872f2087c98

Make the LICENSE file more explicit about the fact that the headers used by Chromium use a BSD license.

BUG=138921

Review URL: https://chromiumcodereview.appspot.com/10843032

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150082 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150081 0039d316-1c4b-4281-b951-d872f2087c98

- gold - r149858 - Fix license metadata for gold
- acid3 - r150075 - Fix license metadata for acid3

BUG=138921
TBR=cmp,thestig

Review URL: https://chromiumcodereview.appspot.com/10855005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150080 0039d316-1c4b-4281-b951-d872f2087c98

Creating OWNERS file for extensions team so that this does not need to be covered by chrome/OWNERS.

BUG=none


Review URL: https://chromiumcodereview.appspot.com/10834151

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150079 0039d316-1c4b-4281-b951-d872f2087c98

TBR=nirnimesh@chromium.org
BUG=140760

Review URL: https://chromiumcodereview.appspot.com/10825197

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150078 0039d316-1c4b-4281-b951-d872f2087c98

BUG=139611
TEST=unit_tests

Review URL: https://chromiumcodereview.appspot.com/10843041

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150074 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150073 0039d316-1c4b-4281-b951-d872f2087c98

Depends on https://bugs.webkit.org/show_bug.cgi?id=92933
Not used anywhere yet, so no observable effect.

BUG=138550


Review URL: https://chromiumcodereview.appspot.com/10853010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150071 0039d316-1c4b-4281-b951-d872f2087c98

This depends on: http://codereview.chromium.org/10662003/

Based on the HTML to Platform Accessibility APIs Implementation Guide
(http://www.w3.org/TR/html-aapi/), add some new tests to assert the
correct behavior for computing the text alternative for a
checkbox, button, and text field, then fix the implementation to
match the test.

BUG=124314
TBR=dtseng

Review URL: https://chromiumcodereview.appspot.com/10823073

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150070 0039d316-1c4b-4281-b951-d872f2087c98