- 02 May, 2018 40 commits
-
-
Xiaocheng Hu authored
This patch introduces a utility function to check if a unicode character is a bidi control character defined in UAX9: http://unicode.org/reports/tr9/#Directional_Formatting_Characters This is also preparation for crrev.com/c/1039145 Bug: 822575 Change-Id: I6a011f7fc871c3508c811c41cb21208139fa71cd Reviewed-on: https://chromium-review.googlesource.com/1040648Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#555588}
-
Peng Huang authored
This CL adds several methods in SkiaOutputSurfaceImpl to support drawing render pass. The working flow is: * Prepare the content of a render pass 1 SkiaRenderer calls BeginPaintRenderPass(render_pass_id) to get a SkCanvas from a DDL recorder for the render pass. 2 SkiaRenderer draws the content of the render pass into the SkCanvas. 3 SkiaRenderer calls FinishPaintRenderPass() to schedule a GPU task to play the DDL back on an offscreen SkSurface for the render pass. * Use the content of a render pass 1 SkiaRenderer calls MakePromiseSkImageFromRenderPass(render_pass_id) to create a promise SkImage for a render pass. 2 SkiaTenderer uses the SkImage as a normal image. For more detail please check https://goo.gl/xtZppF Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Iafc8f22f244117c31a8aa7f03b14b4127139e79c Reviewed-on: https://chromium-review.googlesource.com/996457Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#555587}
-
rbpotter authored
Include <strings.html> wherever we rely on load_time_data or i18n. Bug: 773928 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I7474fcc83359503464a99df5e4d73a152f39c50d Reviewed-on: https://chromium-review.googlesource.com/1040274Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#555586}
-
erikchen authored
This CL is a refactor with no intended behavior change. Bug: 832879 Change-Id: Ic90818e6ce6fff15b323aefbe7e0150cf9bb9f8c Reviewed-on: https://chromium-review.googlesource.com/1040474Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#555585}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/38a08436886e..90864a21c4ab $ git log 38a084368..90864a21c --date=short --no-merges --format='%ad %ae %s' 2018-05-02 herb Simplify textToGlyphs 2018-05-02 skcms-skia-autoroll Roll skia/third_party/skcms baef14c..aee343c (1 commits) 2018-05-02 reed allow div by zero 2018-05-02 brianosman Add toggle for 'real' vs. 'fake' perspective in Viewer 2018-05-02 brianosman Switch to skcms_MakeUsableAsDestination 2018-05-02 reed check for bad xIntervals before multiply 2018-05-02 reed check for huge cubics in patchutils 2018-05-02 skcms-skia-autoroll Roll skia/third_party/skcms 513d372..baef14c (1 commits) Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=brianosman@chromium.org Change-Id: Icd9928dbf0dcdd03c6640c5212fdb58867d1d501 Reviewed-on: https://chromium-review.googlesource.com/1040733Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#555584}
-
https://pdfium.googlesource.com/pdfium.git/+log/303f9a3afc4a..6312bf94bb44 $ git log 303f9a3af..6312bf94b --date=short --no-merges --format='%ad %ae %s' 2018-05-02 hnakashima Use pointer instead of ref for XFA_RectWithoutMargin param. 2018-05-02 hnakashima Use pointer instead of ref for CXFA_Box::GetPathArcOrRounded param. 2018-05-02 hnakashima Use pointers instead of refs for GetPopupPos() params. 2018-05-02 rharrison Convert hand rolled buffer reader in CFX_MemoryStream 2018-05-02 hnakashima Transform in/out params from ref to pointer in CFX_(Txt|RTF)Break. 2018-05-02 hnakashima Transform in/out params from reference to pointer in CFDE_TextOut. Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I7ff4a91f01a0adc5ed0af4ab7a91d89d0c540151 Reviewed-on: https://chromium-review.googlesource.com/1040736 Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#555583}
-
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/1037c743e338..6c692edf010c $ git log 1037c743e..6c692edf0 --date=short --no-merges --format='%ad %ae %s' 2018-05-01 ehmaldonado Reland "bot_update: Set user.{name,email} when applying patch refs." Created with: roll-dep src/third_party/depot_tools BUG=chromium:643346 The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: Ieb31ccea1736d2f6164139b4fcc23d8c4042987c Reviewed-on: https://chromium-review.googlesource.com/1040531Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#555582}
-
Toni Barzic authored
Disabling flaky AutoLaunchedNonKioskEnabledAppTest.NotLaunched test while I investigate it. BUG=838992 Change-Id: I34f7f6c0f37ab08f6efa7ba087b8c18e7c11c408 Reviewed-on: https://chromium-review.googlesource.com/1040786Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Toni Barzic <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#555581}
-
https://chromium.googlesource.com/catapult.git/+log/5b2cfb7fa5f1..02bb4b7da4db $ git log 5b2cfb7fa..02bb4b7da --date=short --no-merges --format='%ad %ae %s' 2018-05-02 nednguyen Remove trace profiler Created with: roll-dep src/third_party/catapult BUG=chromium:839040 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=sullivan@chromium.org Change-Id: Ie9519e5232c398c781232594bab98de2daa2e794 Reviewed-on: https://chromium-review.googlesource.com/1040768 Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#555580}
-
Pete Williamson authored
Only checking the extension by looking for the last '.' Bug: 433486 Change-Id: Icbe336420feca82d545d00409fb9fc8c5ad8ced4 Reviewed-on: https://chromium-review.googlesource.com/1033482 Commit-Queue: Peter Williamson <petewil@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Jian Li <jianli@chromium.org> Cr-Commit-Position: refs/heads/master@{#555579}
-
https://chromium.googlesource.com/chromiumos/chromite.git/+log/9dea5038cdf1..5295eaac6d22 $ git log 9dea5038c..5295eaac6 --date=short --no-merges --format='%ad %ae %s' 2018-05-02 jhorwich Reorder target_os / cache_dir in gclient spec Created with: roll-dep src/third_party/chromite BUG=chromium:838847 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I48c42f1dab561e0fc5f8c18287dbd0b7acb6954f Reviewed-on: https://chromium-review.googlesource.com/1040770Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#555578}
-
Chris Blume authored
The LSI allocators previously did not store a copy of the last generated LSI. As a result, many call sites would have to keep their own copies. Now that the LSI allocators have their own copies, the call sites can be updated to no longer store a separate copy. OffscreenCanvasFrameDispatcherImpl is one such call site. BUG=759031 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I5e65ab848ba95c7b7f6f2f3a9eb31bce8c95fc94 Reviewed-on: https://chromium-review.googlesource.com/1034193Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Commit-Queue: Chris Blume <cblume@chromium.org> Cr-Commit-Position: refs/heads/master@{#555577}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 8b0c28df. With Chromium commits locally applied on WPT: 303956b6 "Enable WPT tests for the Generic Sensor classes" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/16699 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: cbiesinger@chromium.org: external/wpt/css/css-flexbox drott@chromium.org, kojii@chromium.org: external/wpt/css/css-fonts kojii@chromium.org: external/wpt/css/css-scoping TBR=kereliuk No-Export: true Change-Id: I12ae9548dd287430a688687b50c99b33cf7ac180 Reviewed-on: https://chromium-review.googlesource.com/1040472 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#555576}
-
Sky Malice authored
This allows us to constructor the FeedNetworkingHost by calling StoragePartition::GetURLLoaderFactoryForBrowserProcess() which is allowed on the UI thread. Bug: 819305 Change-Id: Ief172b4169585e46defca4eee18163dde463b594 Reviewed-on: https://chromium-review.googlesource.com/1040767Reviewed-by:
Patrick Noland <pnoland@chromium.org> Commit-Queue: Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#555575}
-
Eugene But authored
Old tests were loading http://mock/bad and because this URL did not exist the load was failing because of DNS resolution error. There were 3 tests to test frame load with and without timeout: testErrorPageInIFrame testErrorPageInIFrameAfterDelay testErrorPageNoUserInteraction (name did not reflect what the test did) And it was useful to test these 2 cases because UIWebView called load failure callbacks for iframes, and the error page could show up after iframe load failure. WKWebView callbacks are not called for iframes, so it's enough to have one test which verifies that web view loaded an iframe. New test uses EmbeddedTestServer, which closes the socket to simulate ERR_INTERNET_DISCONNECTED error. Bug: 694662 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I7e2021bbfec1539dd8787f40f20bfec6ad784700 Reviewed-on: https://chromium-review.googlesource.com/1038581 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Reviewed-by:
Danyao Wang <danyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#555574}
-
John Abd-El-Malek authored
The test class now works with frame requests when the network service is disabled. Bug: 776589 Change-Id: Ic543037e05ba164ab6c50f3af27f841200c92626 Reviewed-on: https://chromium-review.googlesource.com/1038424Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#555573}
-
Christopher Grant authored
This ensures that when the control key is held, input is not routed to the keyboard. This allows dumping of UI state without modifying text field state. BUG= R=acondor Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr Change-Id: Ia0bea5a1507299b0d3dd192a7394be8a69fcbd83 Reviewed-on: https://chromium-review.googlesource.com/1039874 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Christopher Grant <cjgrant@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#555572}
-
Daniele Castagna authored
On some devices we don't have a per-CRTC color transform matrix, but we do have a per-plane CTM that is currently not used. This CL emulates a per-crtc CTM on those devices. Bug: 749250 Test: Night light on RK3399 Change-Id: Id5135e00e72085b7890426dca7688d34cf6759f7 Reviewed-on: https://chromium-review.googlesource.com/1037403 Commit-Queue: Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#555571}
-
Allen Vicencio authored
This removes the initialization of TempFileManager in SmbService. With this change, Mount will be in a broken state and will be fixed in a future CL. Bug: 837492 Change-Id: I07689fd5a19e2bf56aac5d2f6cd9085d2352dcad Reviewed-on: https://chromium-review.googlesource.com/1040678 Commit-Queue: Allen Vicencio <allenvic@chromium.org> Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#555570}
-
erikchen authored
This CL is a refactor with no intended behavior change. Bug: 832879 Change-Id: I74ae0bf9b2e3cc7775025767999ffd4a661d4082 Reviewed-on: https://chromium-review.googlesource.com/1040470Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#555569}
-
Jennifer Apacible authored
When PictureInPictureWindowController is torn down, we should send a signal to exit Picture-in-Picture for the client, or media player. This will take the player The case where PictureInPictureWindowController is torn down without the client's initiator WebContents tab closing is when a video in another tab enters Picture-in-Picture mode. BUG: 823172 Change-Id: Id370c9ba088e1ad47b82939cee0df44cd0566233 Reviewed-on: https://chromium-review.googlesource.com/1033467 Commit-Queue: apacible <apacible@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#555568}
-
Antoine Labour authored
/usr/include should never be needed explicitly, and conflicts with the sysroot Bug: None Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ie07580c98136e9b0023ba7b650a0364397ff38fb Reviewed-on: https://chromium-review.googlesource.com/1040737Reviewed-by:
Chris Blume <cblume@chromium.org> Commit-Queue: Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#555567}
-
Tommy Steimel authored
This CL fixes the test by waiting for the "playing" event before starting to wait for the media controls hide timer. Bug: 833658 Change-Id: I85b769a970bbcdf862271b275a5454bcebb0791e Reviewed-on: https://chromium-review.googlesource.com/1040363Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Reviewed-by:
-
Aldo Culquicondor authored
Pressing L allows to toggle standalone mode. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr Change-Id: I3c7f03c478e934f19623d965d5bc3b976ecd1337 Reviewed-on: https://chromium-review.googlesource.com/1040665Reviewed-by:
Christopher Grant <cjgrant@chromium.org> Commit-Queue: Aldo Culquicondor <acondor@chromium.org> Cr-Commit-Position: refs/heads/master@{#555565}
-
Andrey Kosyakov authored
TBR=dgozman Change-Id: I9a8b4067f5adb9f70738d647cd636e02aed1186a Reviewed-on: https://chromium-review.googlesource.com/1040652Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#555564}
-
Xiaohan Wang authored
This tests CdmProxy creation and initialization using a ClearKeyCdmProxy running in the MediaService. This is a prerequisite CL to add test for Decryptor support in MediaService, which will be backed by the CdmProxy running in the MediaService. Bug: 806018 Test: More tests added Change-Id: I9c5dd11eb5db5db3b553c7acfdba9c8120fd2489 Reviewed-on: https://chromium-review.googlesource.com/1038812 Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#555563}
-
Becca Hughes authored
Parse the 'viewport-fit' key in the <meta> element and store it on ViewportDescription. BUG=838400 Change-Id: I0a037175791d4cfaadaa12dffa694eb92a60077d Reviewed-on: https://chromium-review.googlesource.com/1036532Reviewed-by:
Stefan Zager <szager@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#555562}
-
Brian Anderson authored
This is the high level helper class that will be used by all frame sources that we want to instrument. It takes in timing information about frames produced and displayed and calculates metrics for a frame's throughput, latency, latency speed, and latency acceleration. It forwards those computations to StreamAnalyzers which compute statistics of each metric over time, including mean, RMS, standard deviation, percentiles, and worst performing time period. Bug: 790761 Change-Id: Ibe2980e861acf0af3904b1e8d8caf134d9ef141b Reviewed-on: https://chromium-review.googlesource.com/979120Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Brian Anderson <brianderson@chromium.org> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Commit-Queue: Brian Anderson <brianderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#555561}
-
danakj authored
Replace with use of the cc/gfx types directly. Removes the WebLayerPositionConstraint and WebLayerStickyPositionConstraint types entirely. R=jbroman@chromium.org, pdr@chromium.org Bug: 738465 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I4effe1ae91cbaf53b78424851f94e72e93721bd6 Reviewed-on: https://chromium-review.googlesource.com/1033252 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#555560}
-
Xiaohan Wang authored
Test: No functionality change. Change-Id: I0a6bded2980f75f1e4d6981a3a95c1e13654473f Reviewed-on: https://chromium-review.googlesource.com/1038404 Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
John Rummell <jrummell@chromium.org> Cr-Commit-Position: refs/heads/master@{#555559}
-
Reza.Zakerinasab authored
This change list removes GPU readback from scaling and premul code path in ImageBitmap and adds a unit test to verify that. Bug: 740197,822724 Change-Id: Iff74a8cd2d2641b1caab275c22bf3384053b27d2 Reviewed-on: https://chromium-review.googlesource.com/1035790Reviewed-by:
Justin Novosad <junov@chromium.org> Commit-Queue: Mohammad Reza Zakerinasab <zakerinasab@chromium.org> Cr-Commit-Position: refs/heads/master@{#555558}
-
Oksana Zhuravlova authored
Bug: 831261 Change-Id: I507b031f970464c346d4dcef40537edd5fd7e116 Reviewed-on: https://chromium-review.googlesource.com/1033724 Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#555557}
-
Michael Thiessen authored
Oversight where I forgot to check if the VrClassesWrapper was null. TBR=tedchoc@chromium.org Bug: 838840, 838358 Change-Id: I87e562a50a34fe755572eb7176eea2ce4e2530ed Reviewed-on: https://chromium-review.googlesource.com/1040427Reviewed-by:
-
David Bokan authored
Some pages resize their main scroller to the viewport height as the URL bar is shown and hidden. In those cases, we should allow a valid root scroller at both heights. Otherwise, when the URL bar is hidden and the scroller resizes, it'll be demoted and the user will have to scroll all the way to the top to show the URL bar again. Currently, the root scroller must exactly match the initial containing block which does not resize in response to the URL bar. An obvious question would be why allow either height, rather than calculating the current viewport height and using that. In most cases a scroller we want to promote will not resize its height and we still want to keep those scrollers promoted. Bug: 798719 Change-Id: I11684ee5115a02f1f65868399f58074df43e764f Reviewed-on: https://chromium-review.googlesource.com/1036287 Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by:
-
https://webrtc.googlesource.com/src.git/+log/2a35c43779f6..c3d8bb1c522d $ git log 2a35c4377..c3d8bb1c5 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I05714c02ca9c080cf426994e0ac24fb4dba1fa44 Reviewed-on: https://chromium-review.googlesource.com/1040525Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#555554}
-
Chong Zhang authored
The original patch (Patchset 3) was reverted due to flaky tests under Linux TSan: https://crrev.com/c/1036490 This patch fixed the issue by using a wait condition runloop. --- Original Description --- Background: * Currently |TaskManager| tracks network usage through |net::NetworkDelegate|, which is not supported with Network Service. * https://crrev.com/c/978607 Tried to get the info from |content::WebContentsObserver| but failed due to too many corner cases. This CL: 1. Introduced |NetworkService::GetTotalNetworkUsages() => (array<NetworkUsage> total_network_usages);| 2. Updated |TaskManagerImpl| to query the above API 1/sec when active. (e.g. While showing the UI or queried by extensions.) 3. Still use the old codepath when Network Service was disabled. Note that |NetworkService| receives network usage reports from |URLLoader::NotifyCompleted()|, and we could improve the frequency when necessary. The API may be useful for |data_reduction_proxy| as well, see: https://docs.google.com/a/google.com/document/d/1qJYdvt0USWAHbJ9hvCkfauZ9ItMoyYCY2w0Fodvse0M/edit?disco=AAAAB203Cv8 Bug: 822415 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I96f4b3456b4fa8f599b76fbe614d1c724a9c9007 Reviewed-on: https://chromium-review.googlesource.com/1038803Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: Chong Zhang <chongz@chromium.org> Cr-Commit-Position: refs/heads/master@{#555553}
-
John Chen authored
Now that issue 826150 has been resolved, remove some debugging output that was added to Python test script for investigating that issue. Changes include: * Lower verbose logging level from 4 to default (3), by reverting part of r546473. * Stop running ps command upon timeout, by reverting r538464. Change-Id: I29f41ef40e7f2a94b932b1c2204ac19e19db986c Reviewed-on: https://chromium-review.googlesource.com/1036644Reviewed-by:
Jonathon Kereliuk <kereliuk@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#555552}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 718ccb47. With Chromium commits locally applied on WPT: 303956b6 "Enable WPT tests for the Generic Sensor classes" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/16698 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: cbiesinger@chromium.org: external/wpt/css/css-flexbox TBR=kereliuk No-Export: true Change-Id: I8f1b378d9ff2298854e59ee793fbabee91752f88 Reviewed-on: https://chromium-review.googlesource.com/1040385 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
-
Victor Costan authored
For historical reasons, OnRegistrationStored() is called when the promise returned by ServiceWorkerContainer.register() is resolved, which happens before the registration is written to disk. This means OnRegistrationStored() implementations cannot assume that ServiceWorkerContextCore will be able to retrieve the registration. This CL renames the method to a more appropriate name. A follow-up CL will add an OnRegistrationStored() method, which will be called when the registration is written to the database. TBR=benwells Bug: 729800 Change-Id: If273b3008ff55e4d5cd8f5be9e0e6090da2e5390 Reviewed-on: https://chromium-review.googlesource.com/1039083 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#555550}
-
John Chen authored
Change the initial DevTools connect timeout from 1 second to 2 seconds. While a timeout of 1 second was sufficient for Linux and Mac, it turned out to be too short for Windows, where a normal successful connection usually takes very close to 1 second. Change-Id: I685ac9aa45a7ce250f2af718959661c59dcf8f0d Reviewed-on: https://chromium-review.googlesource.com/1037806Reviewed-by:
-
