GitLab

Layout test
virtual/off-main-thread-websocket/http/tests/websocket/close-code-and-reason.html
was flaky with early versions of the off-main-thread WebSocket
implementation. It is no longer flaky, and this virtual test suite has
been switched to running the old "on main thread" WebSocket
implementation. So the flaky expectation is no longer needed. Remove it.

Bug: 831320
Change-Id: I6bb6b2430dbc0fbfad3c5e4ca629487cffaac7a3
Reviewed-on: https://chromium-review.googlesource.com/1036765Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Commit-Queue: Adam Rice <ricea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557096}

Use UKM for Element.createShadowRoot() to help investigate
which site is actively using Shadow DOM V0 API.  The motivation
is to drive the usage down, by outreaching those users.

As of today the usage is around 8% so we sample down by a
factor of 10 to reduce the data volume.

Bug: 806671
Change-Id: I9b183d7724c51979421fdfcb1ee9f19587a1f5ab
Reviewed-on: https://chromium-review.googlesource.com/890144
Commit-Queue: Takayoshi Kochi <kochi@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Hayato Ito <hayato@chromium.org>
Reviewed-by: Bryan McQuade <bmcquade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557095}

TBR=liberato@chromium.org

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I9497f5b0ba4b96a078a67f85a3febdc5621baf0e
Reviewed-on: https://chromium-review.googlesource.com/1050512Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557094}

The current logic to compute list of zoom levels for a display leads to
very big jumps on 4k or 8k displays. This patch reduces the jump
interval for higher resolution displays.

This patch also ensures that the inverse of the internal device scale
factor is present in the list of zoom levels. This ensures that the user
can reach the native resolution on the internal display.

This patch also changes the format in which we persistently store the
zoom level from an int to double. This is necessary because the
inverse dsf that we introduced can be an irrational number and we do not
want to lose precision due to multiple store -> retrieve -> store
operations.

Bug: 837512
Change-Id: If6870153f203f218ad52eafcbf1175ed588e0783
Component: Display zoom, settings slider, display pref
Reviewed-on: https://chromium-review.googlesource.com/1033587
Commit-Queue: Malay Keshav <malaykeshav@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557093}

The 'Share' button for Files.app previously did not work for sharing
files/folders in Team Drives. Instead, redirect the user to the same
behaviour as 'Manage in Drive' which opens the Drive webpage where the
user can manage the file.

This also disables the button for Folders, which currently do not
support 'Manage in Drive'.

Bug: 716301
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ib56c1aab91ca995dbdf0803348b71986781198c1
Reviewed-on: https://chromium-review.googlesource.com/1011466
Commit-Queue: Sasha Morrissey <sashab@chromium.org>
Reviewed-by: Naoki Fukino <fukino@chromium.org>
Reviewed-by: Stuart Langley <slangley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557092}

Also rename globals from "g_foo_" to "g_foo" since they are not member
variables.

Bug: 815022, 788075
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I5ecee5b3559572dc2f700ad8ae8eb784fc298456
Reviewed-on: https://chromium-review.googlesource.com/1050872
Commit-Queue: Mostyn Bramley-Moore <mostynb@vewd.com>
Reviewed-by: enne <enne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557091}

This changes some variable types to more proper types. For example, int to
size_t, bool, uint32_t or double.

BUG=chromium:834170
TEST=VDA unittest on kevin
TEST=VDA unittest on non-Chrome OS platforms in CQ.

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Ie41977c56edeb800fb2938d20fe0ed371fdfb131
Reviewed-on: https://chromium-review.googlesource.com/1039206
Commit-Queue: Hirokazu Honda <hiroh@chromium.org>
Reviewed-by: Pawel Osciak <posciak@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557090}

In hopes of better describinging what this class is for.

BUG=none
TEST=none

Change-Id: I9611dfa0d74b3ef788381436e6f18cce167a41c9
Reviewed-on: https://chromium-review.googlesource.com/1050878
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557089}

This reverts commit 6dc7843c.

Reason for revert: Added tests are failing on Windows Debug: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win7%20Tests%20%28dbg%29%281%29/68927

Original change's description:
> Reland "The SnooperNode: Audio loopback for a single stream."
> 
> This is a reland of f1b4c43b
> 
> Original change's description:
> > The SnooperNode: Audio loopback for a single stream.
> >
> > An audio::GroupMember::Snooper that records the audio from a GroupMember
> > on one thread, and re-renders it to the desired output format on another
> > thread. Since the data flow rates are known to be driven by different
> > clocks (audio hardware clock versus system clock), the SnooperNode also
> > uses its resampler to compensate for skew and re-synchronize the audio
> > going into and out of it.
> >
> > Bug: 824019
> > Change-Id: I87d410724fd00f9372232bfffdfbb89ada0b3de8
> > Reviewed-on: https://chromium-review.googlesource.com/1041657
> > Commit-Queue: Yuri Wiitala <miu@chromium.org>
> > Reviewed-by: Xiangjun Zhang <xjz@chromium.org>
> > Reviewed-by: Chrome Cunningham <chcunningham@chromium.org>
> > Reviewed-by: Olga Sharonova <olka@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#556719}
> 
> TBR=chcunningham@chromium.org,olka@chromium.org
> 
> Bug: 824019
> Change-Id: I579b99bda7bc53710004470c0cc07f8a06cdd8b5
> Reviewed-on: https://chromium-review.googlesource.com/1050403
> Reviewed-by: Yuri Wiitala <miu@chromium.org>
> Commit-Queue: Yuri Wiitala <miu@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#557008}

TBR=miu@chromium.org,chcunningham@chromium.org,olka@chromium.org,xjz@chromium.org

Change-Id: I535f97d802e211d1457e814aab997bf60ff2561a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 824019
Reviewed-on: https://chromium-review.googlesource.com/1051132Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557088}

The https://crrev.com/555640 regressed headless implementation of
Target.disposeBrowserContext() method and omitted the actual context
closing.

This patch brings back the missing method.

R=dgozman, alexclarke
TBR=alexclarke

Change-Id: I28677381be9fbb86daa5445978e9c0ce4bf388f7
Reviewed-on: https://chromium-review.googlesource.com/1050983
Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557087}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/da3ce5f235a2..8cf7ea75d5ff

$ git log da3ce5f23..8cf7ea75d --date=short --no-merges --format='%ad %ae %s'
2018-05-07 ihf chromeos_config: drop informational min_duts to 1.

Created with:
  roll-dep src/third_party/chromite
BUG=chromium:836360


The AutoRoll server is located here: https://chromite-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=chrome-os-gardeners@chromium.org

Change-Id: Ic54e8001594a313619da669d805a8c79e54974bf
Reviewed-on: https://chromium-review.googlesource.com/1050937Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#557086}

Currently, chrome's implementation of Target.disposeBrowserContext()
fails to dispose empty browser contexts.

We don't need to wait for browsers to close if there are no opened
browser windows to destroy a browser context.

R=dgozman

Change-Id: I7b41a1b55b398f543a547fd6ead9f83af7f8a843
Reviewed-on: https://chromium-review.googlesource.com/1050909Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557085}

Comment-only change: minor tweaks to the test comments.

No-Presubmit: true
No-Try: true
Bug: 833834
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: If9663947107da6ada7c422aeef87b74ae456c3f1
Reviewed-on: https://chromium-review.googlesource.com/1051130
Commit-Queue: Noel Gordon <noel@chromium.org>
Reviewed-by: Naoki Fukino <fukino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557084}

This patch moves selection type computing at ComputeVisibleSelection
to SelectionAdjuster for readability.

Bug: 787295
Change-Id: Ic17ed8e63c1e9a0033099afd20bc75ca3149991e
Reviewed-on: https://chromium-review.googlesource.com/1029754
Commit-Queue: Yoichi Osato <yoichio@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557083}

This CL adds ChromeOS.SystemTray.Interaction enum metrics to
both old SystemTray and UnifiedSystemTray.
The value records if the region inside system tray bubble is tapped,
or clicked.

TEST=manual(chrome://histograms)
BUG=none

Change-Id: I3592ef60c39c3e71962a81e931b8e2b9c570a6cc
Reviewed-on: https://chromium-review.googlesource.com/1032315
Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org>
Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557082}

In a follow-up CL, this will be used to add a message to the interstitial when
users have seen multiple errors in a browsing session.

Bug: 839969
Change-Id: I6e7f9c7e73f93b29c73f8fafa504acbfdd182e4c
Reviewed-on: https://chromium-review.googlesource.com/1048173
Commit-Queue: Emily Stark <estark@chromium.org>
Reviewed-by: Christopher Thompson <cthomp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557081}

MAX use a state expression for its implementation, and it's unavailable
in the file scope. Especially, it causes a compile error when the code
is compiled as C++17.

Bug: 752720
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I54a79021ef396e07c016db9a29df697d060dc6cb
Reviewed-on: https://chromium-review.googlesource.com/1049089Reviewed-by: edchin <edchin@chromium.org>
Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557080}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/9ad6814d5f1e..59e400635dcd

$ git log 9ad6814d5..59e400635 --date=short --no-merges --format='%ad %ae %s'

Created with:
  roll-dep src-internal
BUG=chromium:825063


The AutoRoll server is located here: https://src-internal-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: Ife6225fd68441d44a492552bee52bac634f59c8e
Reviewed-on: https://chromium-review.googlesource.com/1050882Reviewed-by: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#557079}

https://skia.googlesource.com/skia.git/+log/88b12e9a8628..499a9b21087e

$ git log 88b12e9a8..499a9b210 --date=short --no-merges --format='%ad %ae %s'
2018-05-09 angle-skia-autoroll Roll third_party/externals/angle2/ c009255c7..e95a7f077 (3 commits)

Created with:
  roll-dep src/third_party/skia


The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=egdaniel@chromium.org

Change-Id: I1ae5eceee1c2bbf99d63b403978f7e2153b91575
Reviewed-on: https://chromium-review.googlesource.com/1051030
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#557078}

Bug: 812926
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ieb2e6910fdfb52edd377dfee3e645b34ec267699
Reviewed-on: https://chromium-review.googlesource.com/1015644
Commit-Queue: Hector Carmona <hcarmona@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557077}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/276da0b4d90a..3806b7fbd0ea

$ git log 276da0b4d..3806b7fbd --date=short --no-merges --format='%ad %ae %s'
2018-05-08 ehmaldonado bot_update: Fetch references to be synced.

Created with:
  roll-dep src/third_party/depot_tools
BUG=chromium:840445


The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=agable@chromium.org

Change-Id: I998afbad5ae6387c19652bf06fd0e5f58c3121e2
Reviewed-on: https://chromium-review.googlesource.com/1050982
Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#557076}

Currently, when the screen resizes on Android (typically due to an
orientation change), Android immediately starts animating once it
receives any post-resize frame. Unfortunately, this frame typically
isn't the right size yet, and even if the overall frame is the right
size, the renderer contents are not.

To avoid this we now:
- Take the compositor lock when a renderer is resized and release it
  when we produce a frame of the right size.
- Check whether the browser frame being swapped is the right size
  before releasing the OS-level lock which triggers the animation.

Bug: 835102
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I58c2633f5fc94b4e472e6f182309e4d96f17353d
Reviewed-on: https://chromium-review.googlesource.com/1031129
Commit-Queue: Eric Karl <ericrk@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Khushal <khushalsagar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557075}

# This is an automated release commit.
# Do not revert without consulting chrome-pmo@google.com.
NOAUTOREVERT=true
TBR=govind@chromium.org

Change-Id: I62751e7603b75eacb4de983aec8870c3beb23f47
Reviewed-on: https://chromium-review.googlesource.com/1051008Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557074}

Add more documentation. Add an extra step to toggle the play button to
state play again at the end of the test: re-test the label, and player
state, to confirm that the UI indicates audio is playing.

For the record, this test does not exhibit to "Uncaught exception play
interrupted by pause" problem per this test's LOG in a DEBUG build. So
that's maybe a clue about that error (bug 835626 comment #3).

Test: browser_test --gtest_filter="AudioPlayerBrowserTest/TogglePlay*"
No-Presubmit: true
Bug: 835626
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I8af5abcdddfe9b19a22ac257327b359511e2d263
Reviewed-on: https://chromium-review.googlesource.com/1050165
Commit-Queue: Noel Gordon <noel@chromium.org>
Reviewed-by: Naoki Fukino <fukino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557073}

This reverts commit 6235a656.

Reason for revert: Broke chrome_public_test_apk on kitkat
https://ci.chromium.org/buildbot/chromium.android/KitKat%20Phone%20Tester%20%28dbg%29/6066

Original change's description:
> Android: Moves InterstitialPageDelegateAndroid to test
> 
> Java class InterstitialPageDelegateAndroid and its native class are
> used by content/chrome test only. This CL moves the classes to
> content/test/android. For this, content shell test apk is configured
> to have a native library of target name content_native_test_support.
> 
> Bug: 617324
> Change-Id: I81b757fe636e96139f61dce781d14fe55da341dd
> Reviewed-on: https://chromium-review.googlesource.com/1039305
> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
> Reviewed-by: Bo <boliu@chromium.org>
> Reviewed-by: Ted Choc <tedchoc@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#556773}

TBR=boliu@chromium.org,tedchoc@chromium.org,jinsukkim@chromium.org

Change-Id: If4d3c02b32b0887f6be6981dd5e8ea14af759ced
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 617324, 840974
Reviewed-on: https://chromium-review.googlesource.com/1051036Reviewed-by: agrieve <agrieve@chromium.org>
Commit-Queue: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557072}

https://chromium.googlesource.com/catapult.git/+log/f25391b703a2..718dbe7d3244

$ git log f25391b70..718dbe7d3 --date=short --no-merges --format='%ad %ae %s'
2018-05-07 dtu [pinpoint] Reorganize /job API response format.

Created with:
  roll-dep src/third_party/catapult


The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=sullivan@chromium.org

Change-Id: Ia14f73378f99265e72fcfbe2213eccdefeed62b2
Reviewed-on: https://chromium-review.googlesource.com/1050948Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#557071}

The current structure of //net is that there is a base
CTPolicyEnforcer that implements the "CT in Chrome" policy documented
at https://github.com/chromium/ct-policy/blob/master/ct_policy.md ,
and embedders or implementors that wish to override this can derive
from this base and override the concrete virtual method.

However, the CT policy expressed by the CTPolicyEnforcer is
intrinsically tied to the set of logs - both notions like "one Google,
and one non-Google log" (from the policy), but also the ability to
update and maintain those logs over the lifetime of the product. While
this is true for Chrome, this is not true for a number of embedders.

As part of moving the CT configuration 'out' of //net and closer to
the product-level configuration, this changes the CTPolicyEnforcer
to be a pure virtual base, and provides a DefaultCTPolicyEnforcer that
always treats the build as 'out of date' (equivalent to not making any
statement about CT, as it lacks timely details about the logs or the
status of the policy). Because EV treatment right now is mixed between
the cert layer (which flags CERT_STATUS_IS_EV) and the socket layer
(which removes CERT_STATUS_IS_EV if not CT qualified), the socket layer
is updated to allow 'out of date' CT status to grant EV. A future change
will move the EV policy check out of the socket and closer to the CT
policy, so that embedders like Chrome/Chromium can ensure an out of
date log list can result in EV status removal.

The Chrome-specific policy is now moved into
//components/certificate_transparency, the highest it can be moved while
still being usable by the Network Service. The Network Service gains a
new configuration parameter to configure enforcement of the Chrome CT
policy, which works for both the in-process URLRequestContext used by
Chrome and the out-of-process Network Service, as a temporary solution.

This is a significant change in the API contract of the
URLRequestContextBuilder, as it's now effectively moving to disable
CT-by-default for //net embedders other than Chrome/Chromium. This is
intentional, as the widescale rollout of enforcing CT is coupled to
reliable and rapid update mechanisms, and having stale clients with
old lists of logs or old policies can negatively impact the CT
ecosystem - both site operators worried about compatibility with these
products and for CAs wanting to ensure their certificates reliably work.

Mobile versions of Chrome/Chromium are, for the time being, also move to
disable enforcement, similar to how static HPKP is disabled for Android
and iOS. Additional work will be done to ensure that the list of logs
is reliably updatable for these clients, which will then facilitate
enabling CT enforcement.

BUG=702062

Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.linux:linux_mojo;master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ic5145b6759d8843cb9134e7718e5834c7b5bb010
Reviewed-on: https://chromium-review.googlesource.com/1020160
Commit-Queue: Ryan Sleevi <rsleevi@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Emily Stark <estark@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557070}

This change adds a new trigger to the downloading of thumbnails for
prefetched offline articles right after GeneratePageBundle is
requested. This is in addition to the later attempt made when a
prefetched article is successfully downloaded and aims at improving the
availability of article thumbnails.

Bug: 794828
Change-Id: Ic857ab91f4f2befb327e91300005c59c10bc417d
Reviewed-on: https://chromium-review.googlesource.com/1047991
Commit-Queue: Carlos Knippschild <carlosk@chromium.org>
Reviewed-by: Dmitry Titov <dimich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557069}

This also requires modifying layout padding on visibility change.

Bug: b:79387198
Change-Id: I6b7b734badd3bf054b63d6517d82b2c976a9ddf2
Reviewed-on: https://chromium-review.googlesource.com/1050734Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: David Black <dmblack@google.com>
Cr-Commit-Position: refs/heads/master@{#557068}

Unit test tracked in b/77656544. Requires writing a test version of
AshAssistantController which I will do after slight refactor.

Motion spec not yet defined.

Bug: b:79425648
Change-Id: Ic953d3c8c2e85af9929a425a55a794e55bab3a91
Reviewed-on: https://chromium-review.googlesource.com/1050582Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Commit-Queue: David Black <dmblack@google.com>
Cr-Commit-Position: refs/heads/master@{#557067}

This patch fixes a regression from [1] where
MapToVisualRectInAncestorSpaceInternal was changed to not apply a
counterscroll offset for fixed position descendants. Interest rect
calculations incorrectly relied on this behavior.

MapToVisualRectInAncestorSpace is exclusive of the clip and scroll on
the ancestor object. To account for this, the interest rect logic would
call MapToVisualRectInAncestorSpace and then apply the root clip and
scroll offset, but this is not correct if there are fixed-position
children.

This patch updates the callsite to MapToVisualRectInAncestorSpace to
map to nullptr instead of the root view which will include the layout
view's clip and scroll.

[1] http://crrev.com/e931d2aecb

Bug: 838111, 831380, 840504
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I14b023279ef58e0123febae367a2ea0c67733c50
Reviewed-on: https://chromium-review.googlesource.com/1047193Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557066}

Adds a new DISPLAY_BRIGHTNESS_CHANGED value to AvSettings's Event enum.

This event should be fired when display brightness is changed.

BUG=internal b/76421244
BUG=internal b/77479163
TEST=None

Change-Id: Ifd9661c63fb5684e04358b5a44e2035bee87c10c
Reviewed-on: https://chromium-review.googlesource.com/1045311Reviewed-by: Stephen Lanham <slan@chromium.org>
Reviewed-by: Sergey Volk <servolk@chromium.org>
Commit-Queue: Fergus Simpson <afergs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557065}

TBR=mmoroz@chromium.org

Change-Id: Ic835553e8955ca3618a6c0b3a4187d4e5f94ddfe
Reviewed-on: https://chromium-review.googlesource.com/1051034Reviewed-by: Abhishek Arya <inferno@chromium.org>
Reviewed-by: Max Moroz <mmoroz@chromium.org>
Commit-Queue: Abhishek Arya <inferno@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557064}

Bug: 755407
Change-Id: If7dc53455d023c653e184cdbfe5066875aea7052
Reviewed-on: https://chromium-review.googlesource.com/1028851
Commit-Queue: Steven Holte <holte@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Sam McNally <sammc@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557063}

https://chromium.googlesource.com/angle/angle.git/+log/de1c1db091aa..e95a7f077e8b

$ git log de1c1db09..e95a7f077 --date=short --no-merges --format='%ad %ae %s'
2018-05-08 jmadill Make EGLThreadTest cross-platform.
2018-05-08 fjhenigman Revert "ANGLETest: Reuse test windows per-renderer"

Created with:
  roll-dep src/third_party/angle


The AutoRoll server is located here: https://angle-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=fjhenigman@chromium.org

Change-Id: Ib0bdb0c1a729ccfad45e9df88e4bbfc6f2374ff9
Reviewed-on: https://chromium-review.googlesource.com/1050409Reviewed-by: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#557062}

BUG=840035
TEST=gpu_unittests
R=kbr@chromium.org,yang.gu@intel.com

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I24164e419c78d116d7ef665345690f17381764fb
Reviewed-on: https://chromium-review.googlesource.com/1045613
Commit-Queue: Zhenyao Mo <zmo@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557061}

This reverts commit a6598e5d.

Reason for revert: Partial reland that doesn't remove caching of tint_.

Original change's description:
> Revert "Use GG700 / Chrome icon color for toolbar"
>
> This reverts commit b5d6fee9.
>
> Reason for revert: Speculative revert for mash_browser_tests failure on linux-chromeos-rel
> https://ci.chromium.org/buildbot/chromium.chromiumos/linux-chromeos-rel/7672
>
> Original change's description:
> > Use GG700 / Chrome icon color for toolbar
> >
> > Replaces GG800 with GG700 as icon color in a couple of places:
> >
> > * Omnibox default chip (HTTP (i) icon for instance).
> > * BubbleIconView inside omnibar (these used to be GG700 but regressed
> >   to GG800 in Touchable / Refresh recently).
> > * Toolbar button icons.
> >
> > Bug: chromium:821996, chromium:834510
> > Change-Id: I9e953c9da1e0eee1da132e3e0e71474ff7877aef
> > Reviewed-on: https://chromium-review.googlesource.com/1040875
> > Commit-Queue: Peter Boström <pbos@chromium.org>
> > Reviewed-by: Peter Kasting <pkasting@chromium.org>
> > Reviewed-by: Evan Stade <estade@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#556646}
>
> TBR=pkasting@chromium.org,estade@chromium.org,pbos@chromium.org,bsep@chromium.org
>
> Change-Id: I1d56fd212cbe1ed50b620b61b9287cfa8abc5b48
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: chromium:821996, chromium:834510, chromium:840657
> Reviewed-on: https://chromium-review.googlesource.com/1049445
> Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#556700}

TBR=pkasting@chromium.org,estade@chromium.org,bsep@chromium.org

Change-Id: I280c016c9cf772ce5919c29ebee4dba8535e44e3
Bug: chromium:821996, chromium:834510, chromium:840657
Reviewed-on: https://chromium-review.googlesource.com/1050486
Commit-Queue: Peter Boström <pbos@chromium.org>
Reviewed-by: Peter Boström <pbos@chromium.org>
Reviewed-by: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557060}

ImageFrameGenerator ensures that accessing the cached ImageDecoders is
thread-safe using a mutex, locked for the duration of
ImageFrameGenerator::TryToResumeDecode. However, the bitmap returned by
this method holds a reference to the pixel buffer which can still be
mutated by the ImageDecoder. This can introduce a race between copying
the pixel buffer to the caller's memory and another thread writing to
it to decode a subsequent frame.

Ensure the above is avoided by holding the mutex for the duration of
the decode and copying the pixel buffer to the caller's memory if
necessary.

R=chrishtr@chromium.org
BUG=840946

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I110c54232385b5d335001f221a480371968f9551
Reviewed-on: https://chromium-review.googlesource.com/1050619
Commit-Queue: Khushal <khushalsagar@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557059}

Elements that use md-select are already directly including such style.

Bug: None
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ib7ac481f19a76ea46958220f66acb8c4b4f32543
Reviewed-on: https://chromium-review.googlesource.com/1048947Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557058}

Currently, the OverlayWindow does not adhere to the video aspect ratio
while resizing. It only does that the first time the window is created.

This changes makes the window snap to the original (and intended) aspect
ratio when the window is resized. The window will always keep to the
original orientation, whether landscape or portrait (or square).

This change includes a non-smooth behavior where the user is able to
make the window whatever aspect ratio while in the process of resizing.
After the user 'completes' the action, such as letting go of a mouse
drag, the window will snap to adhere to the aspect ratio.

The layer contents will only be refitted in the window when it's
adhering to the aspect ratio.

There will be future work on making this smooth.

BUG: 829677
Change-Id: Ic7bea948b901f7a5174ea5bd50c921c29fb2f487
Reviewed-on: https://chromium-review.googlesource.com/1043546
Commit-Queue: apacible <apacible@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557057}