- 01 Dec, 2017 40 commits
-
-
rajendrant authored
Bug: 781189 Change-Id: I1472076e579a94fe14c0ee1aa6d52d1d7cf0931f Reviewed-on: https://chromium-review.googlesource.com/801541Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: rajendrant <rajendrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#521102}
-
Will Chen authored
Now that lighthouse has succeeded our legacy audits panel, it's time to remove audits, the extension audits API, extension audits-related docs, and relevant tests. Bug: 790541 Change-Id: Ie2cf3fb439dab768a8511b151d81d6066b41a3a9 Reviewed-on: https://chromium-review.googlesource.com/798633Reviewed-by:
Ken Rockot <rockot@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Will Chen <chenwilliam@chromium.org> Cr-Commit-Position: refs/heads/master@{#521101}
-
Sandeep Vijayasekar authored
For taking the VP9 HDR metadata from the video container and passes it to MediaCodec Reference for packing HDR metadata in MediaFormat: https://github.com/google/ExoPlayer/pull/2729/commits/e93ce41a285fe6b0493faa91523b010469591be7 Bug: internal b/68950223 Test: none Change-Id: Id2b83c98a0844832f3bdfae7e3bd1dfa9c3728dc Reviewed-on: https://chromium-review.googlesource.com/755952Reviewed-by:
Fredrik Hubinette <hubbe@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Sergey Volk <servolk@chromium.org> Commit-Queue: Sandeep Vijayasekar <sandv@chromium.org> Cr-Commit-Position: refs/heads/master@{#521100}
-
Luke Halliwell authored
PopulateNetworkSessionParams was incorrectly missing some members (specifically, missing NetLog caused this bug). The existing builder method is designed to populate all members correctly. Bug: internal b/68856390 Test: cast on steak Change-Id: Ief423d5658a31ccd2eb35b6fd29b6721cc7c7910 Reviewed-on: https://chromium-review.googlesource.com/777786Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Reviewed-by:
Stephen Lanham <slan@chromium.org> Commit-Queue: Luke Halliwell <halliwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#521099}
-
Brett Wilson authored
The TabIcon will schedule its own painting when its state changes. This call was left from a previous iteration where it did not do so. Bug: 778461 Change-Id: I351f2c2e6e11c9ab942c98ccb3e002fd8cbfb67f Reviewed-on: https://chromium-review.googlesource.com/804239Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Brett Wilson <brettw@chromium.org> Cr-Commit-Position: refs/heads/master@{#521098}
-
Ivan Sandrk authored
Bug: chromium:775329 Change-Id: Ie4e9ec4b7e2e17a2081336fb7a525b37de5e1c75 Reviewed-on: https://chromium-review.googlesource.com/793171Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Ivan Šandrk <isandrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#521097}
-
Steven Bennetts authored
Bug: 780994 Change-Id: I549f606839d8fd36facd6a729fd1be27be9a3a09 Reviewed-on: https://chromium-review.googlesource.com/803628Reviewed-by:
Ben Chan <benchan@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#521096}
-
Christopher Grant authored
This change sees single-line text rendering properly update the vertical dimension of the underlying texture. In addition, the recently-added text unittest is reworked to allow more thorough and easy testing, by separating text layout from rendering and canvas, and also exposing the internal text layout to tests. BUG= R=bshe Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ib0ec5b678adf2727d58543e281685ce49ae691af Reviewed-on: https://chromium-review.googlesource.com/801955Reviewed-by:
Biao She <bshe@chromium.org> Commit-Queue: Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#521095}
-
Ahmed Fakhry authored
When detaching a tab to a new browser, we used to just fullscreen the window, which is different from the immersive fullscreen window. This caused the new window to block showing the shelf as well as revealing the tab strip. BUG=776557 TEST=interactive_ui_tests --gtest_filter=TabDragging/DetachToBrowserTabDragControllerTest.DetachToOwnWindowWhileInImmersiveFullscreenMode/* Change-Id: Idd3714fc9ec00e0e771ed93f77b40113c68b0ff9 Reviewed-on: https://chromium-review.googlesource.com/804174Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#521094}
-
Luis Hector Chavez authored
This change delays the discoverability of the interface pointer / version until after the full-duplex connection is established. Bug: None Test: git cl try Change-Id: Iadd980e93265f878c97a4c702be0fe6ae117e3b0 Reviewed-on: https://chromium-review.googlesource.com/801112 Commit-Queue: Luis Hector Chavez <lhchavez@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Cr-Commit-Position: refs/heads/master@{#521093}
-
David Dorwin authored
These histograms were just added so this should not affect data. Bug: 788768 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ibac06800a1f7e491cd53067e4c6f0f7c2e7edbfb Reviewed-on: https://chromium-review.googlesource.com/798733 Commit-Queue: David Dorwin <ddorwin@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Cr-Commit-Position: refs/heads/master@{#521092}
-
Darren Shen authored
FilteredComputedStylePropertyMap currently takes a ComputedStyleDeclaration in its constructor, but doesn't do anything with it. This patch removes it and moves the node parameter to the front (makes more sense). Bug: 785132 Change-Id: I6897004f98bef50df5d1129fd3eacd560e0b6e78 Reviewed-on: https://chromium-review.googlesource.com/790115 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#521091}
-
Elliot Glaysher authored
The OnPointerEventObserved() interface acts differently between mash and mus/classic. In mus/classic, the target window is taken from the LocatedEvent's target(), relying on previous event dispatch metadata. On mash, this event came from a remote service which hasn't been targeted, target is therefore the top of the window tree. In the --mash case only, target the event on the window and use that as the window we pass to the rest of the system. Bug: 698085 Change-Id: I8a1859055d9427b269cd5256c7ff114a1e97574d Reviewed-on: https://chromium-review.googlesource.com/801976Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Elliot Glaysher <erg@chromium.org> Cr-Commit-Position: refs/heads/master@{#521090}
-
Miguel Casas authored
This CL removes unnecessary media:: namespace resolution prefixes from //media/capture/video files. These prefixes were there because some files moved from //content a while ago. This CL was done with a bit of sed bricolage: sed -i -e '/media::mojom/b; s/media:://g' `grep -rn media:: media/capture/video | cut -d: -f1 | uniq` then reverting the media:: removals in unnamed namespaces, and finally doing a git cl format Change-Id: Id335f3f35f800ece00842cd36c14b1145fe07cb2 Reviewed-on: https://chromium-review.googlesource.com/803942Reviewed-by:
Christian Fremerey <chfremer@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#521089}
-
Bruce Dawson authored
Bug: Change-Id: If3faf6990ef89683b59bbb92e9c7200258e46f5e Reviewed-on: https://chromium-review.googlesource.com/803797Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#521088}
-
Alexis Hetu authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/3e2b109..a0aa5fd BUG=769026 TBR=kbr@chromium.org TEST=bots CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel,linux_chromium_cfi_rel_ng;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I9ddaa99728b00be85f8759f975d4fb85161e3d77 Reviewed-on: https://chromium-review.googlesource.com/803794 Commit-Queue: Alexis Hétu <sugoi@chromium.org> Reviewed-by:
Alexis Hétu <sugoi@chromium.org> Cr-Commit-Position: refs/heads/master@{#521087}
-
Luis Hector Chavez authored
This change addresses a comment that was added just before committing. Bug: None Test: git cl try Change-Id: If6d61b603b6fcaaad18ccaca795ba024c5e84c21 Reviewed-on: https://chromium-review.googlesource.com/804240Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Commit-Queue: Luis Hector Chavez <lhchavez@chromium.org> Cr-Commit-Position: refs/heads/master@{#521086}
-
Moja Hsu authored
The code will enter deadlock if the device has no JPEG decode accelerator. This CL fixes it. BUG=chromium:790838 TEST=test camera preview on minnie Change-Id: I695f80351a451614c7c830e3e31b40196fe9b457 Reviewed-on: https://chromium-review.googlesource.com/802935Reviewed-by:
Ricky Liang <jcliang@chromium.org> Reviewed-by:
Max Morin <maxmorin@chromium.org> Commit-Queue: Ricky Liang <jcliang@chromium.org> Cr-Commit-Position: refs/heads/master@{#521085}
-
Kurt Horimoto authored
This will allow it to be accessible to multiple parts of the UI via a shared ChromeBrowserState. Bug: 785663 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ia371a98681d27522443fbc0726fa4932e7666ae1 Reviewed-on: https://chromium-review.googlesource.com/802829 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#521084}
-
danakj authored
For ui::Compositors that don't need to embed anything (eg. tooltips) they may be set to use software compositing even if the system as a whole is using gpu compositing. This adds the flag to CreateRootCompositorFrameSink plumbing, all the way through to the GpuDisplayProvider. In GpuDisplayProvider it adds code to create (for most platforms) a SoftwareOutputDevice. It renames DisplayOutputSurface to GLOutputSurface, and adds a SoftwareOutputSurface, which is created in the software compositing case. This now crashes if software compositing is forced, as the ui compositor has a null SharedBitmapManager. Once we set up the SharedBitmapManager in the viz and browser processes we should be able to get software compositing pixels. Lots of TODOs aded as appropriate. The auto-fallback on fatal error making a GL context is not implemented yet in GpuDisplayProvider. R=kylechar@chromium.org Bug: 730660 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I82855e03df1c156e1a0b1c4bbc4eb35ffb3deb51 Reviewed-on: https://chromium-review.googlesource.com/798153 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#521083}
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/catapult.git/+log/9252115c4630..43a5c4971235 $ git log 9252115c4..43a5c4971 --date=short --no-merges --format='%ad %ae %s' 2017-12-01 simonhatch Dashboard - Parse the LOG_URLS diagnostic from histograms and log it. Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I47a8baf752b26ef8890dd52ef139158d6a89109c Reviewed-on: https://chromium-review.googlesource.com/804408 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#521082}
-
Tibor Goldschwendt authored
Tracks the duration from Chrome launch until the assets component is ready to use. Bug: 788768 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I5e500bc2ea3eb8a508aa3453dd62caad496e9e4a Reviewed-on: https://chromium-review.googlesource.com/790971 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Reviewed-by:
Biao She <bshe@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Cr-Commit-Position: refs/heads/master@{#521081}
-
Tarun Bansal authored
* Change ownership of the network properties manager in data reduction proxy: Network properties manager is now created and destroyed on the UI thread, and has access to both UI and IO task runners. This allows it to read/write the prefs on the UI task runner (next CL), while also exposing the network properties to d_r_p_config on IO thread (next CL). * State of the Data saver proxies is now persisted on the disk, and read back at the time of startup, or on connection change events. Bug: 779219 Change-Id: I0276c78541bbd84ef3a2edc5056dc943955c608b Reviewed-on: https://chromium-review.googlesource.com/756646 Commit-Queue: Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Scott Little <sclittle@chromium.org> Cr-Commit-Position: refs/heads/master@{#521080}
-
Julian Pastarmov authored
1. For UnsafelyTreatInsecureOriginAsSecure there is a typo in the policy_test_cases.json file: s/securex/secure/. 2. For SecurityKeyPermitAttestation the policy mapping was incorrectly put in a ifdef that excluded mac which makes it fail on mac. BUG=none Change-Id: I5f0f3b289452bf86fc66f0396cb13f82c8dcea5e Reviewed-on: https://chromium-review.googlesource.com/804314 Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#521079}
-
Hongchan Choi authored
Spec PR (approved): https://github.com/WebAudio/web-audio-api/pull/1445 Based on the spec change, this CL moves audioWorklet from `window` to `BaseAudioContext`. This alters the relationship between BaseAudioContext, AudioWorkletMessagingProxy and AudioWorkletGlobalScope: - Now AWMP/AWGS cannot exist without BaseAudioContext, this reduces the code complexity by removing checks. - With this clear ownership, BaseAudioContext only needs to talk to AudioWorklet. AudioWorkletMessagingProxy can be hidden. - When the script evaluation is completed, AWGS will notify the associated BaseAudioContext via AWObjectProxy - AWMessagingProxy. Bug: 786542 Change-Id: I7b55fcacf304a4a25b527bcbcd285bef80881b8d Reviewed-on: https://chromium-review.googlesource.com/779862 Commit-Queue: Hongchan Choi <hongchan@chromium.org> Reviewed-by:
Raymond Toy <rtoy@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#521078}
-
David Reveman authored
Version 2 additions: - set_parent request that can be used to provide an initial position relative to parent for shell surfaces. - zaura_output extension to wl_output that provides detailed information about supported scale factors. Test: compile Bug: Change-Id: I00aebee4475a7004db84f6f0e2cb5d41d8a823da Reviewed-on: https://chromium-review.googlesource.com/804354 Commit-Queue: David Reveman <reveman@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#521077}
-
Sergey Ulanov authored
Component build was broken on Fuchsia because base::RaiseProcessToHighPriority() was not defined. Bug: 706592 Change-Id: Ie88ffa6c7ad09729249417c6fb094e2194026854 Reviewed-on: https://chromium-review.googlesource.com/804210 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#521076}
-
Peter Kasting authored
This can't be done by mucking with ShouldWindowContentsBeTransparent() as I opriginally thought; update comment there to describe better why. Instead, do this directly in TabStripImpl. The net effect of this should be that on Win 10, the titlebar background color will no longer show through the background tabs in the default theme; for white titlebars, this should make active and inactive tabs a little easier to distinguish. BUG=none TEST=none Change-Id: I1b722ba7ce887a1a32470e794e04b436bc06c22b Reviewed-on: https://chromium-review.googlesource.com/802522Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#521075}
-
Yusuf Ozuysal authored
For both the initial check and the subsequent verification, we were using the url to be loaded to handle DAL verification. But DAL is for origins only, so we should instead split the path from the url before sending it for verification BUG=782905 Change-Id: I380076b3c1de5d10fdaba14238609fde9fdc3463 Reviewed-on: https://chromium-review.googlesource.com/801986 Commit-Queue: Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#521074}
-
Aleksei Seren authored
We have added Chrome.ProcessSingleton.TerminateProcessErrorCode.Windows histogram here: https://codereview.chromium.org/2871793003/ Sadly, it was added to process_singleton_win.cc with mispell as: Chrome.ProcessSingleton.ProcessTerminateErrorCode.Windows This CL fixes histogram name to proper one. R=gab@chromium.org,holte@chromium.org Change-Id: Ice0989f3646aec6942138788e3cce0ebeb4dcffa Reviewed-on: https://chromium-review.googlesource.com/800630 Commit-Queue: Steven Holte <holte@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#521073}
-
Brett Wilson authored
This adds the new TabIcon view to the TabExperimental class and adds the associated plumbing to hook up the basic favicon and throb functionality. Rename experimental observer variables to help differentiate from the regular observers. Bug: 778461 Change-Id: I56a67a6f14d4003ee49818568bb59298e15bf1b8 Reviewed-on: https://chromium-review.googlesource.com/804206 Commit-Queue: Brett Wilson <brettw@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#521072}
-
Luis Hector Chavez authored
This change: * Ensures that the Observers are notified when an Instance's connection errors out. * Relaxes the restrictions upon calling SetInstance() when there is already an InstancePtr bound. This matches the semantics prior to the ConnectionHolder refactoring. Bug: None Test: git cl try Change-Id: I933792f2846dfe614b8d71a52c9f9ebbce3f7c09 Reviewed-on: https://chromium-review.googlesource.com/797970 Commit-Queue: Luis Hector Chavez <lhchavez@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Cr-Commit-Position: refs/heads/master@{#521071}
-
Nasko Oskov authored
This CL disables tests failing on the Site Isolation Win FYI bot until they can be investigated and fixed. Bug: 788390 Change-Id: Ie51cd7dc3fe3559da7e2e3eec8ad9ca19169d794 Reviewed-on: https://chromium-review.googlesource.com/804146Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#521070}
-
Dominik Röttsches authored
Perf bisects indicate that the hb_set changes may be the reason for seing performance regressions in issues 781794 and 782220. This is somewhat speculative as there were issues with reproducibility in the perf_bisect runs. Results from the main perf bot graphs should help figure out whether the hb_set changes were the culprit here. Bug: 782220, 781794 Change-Id: I5462b37503ca76a299c99cf41388d0d195722358 Tbr: behdad@chromium.org Reviewed-on: https://chromium-review.googlesource.com/804374Reviewed-by:
Dominik Röttsches <drott@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#521069}
-
Tom Anderson authored
This CL launches xvfb with +extension RANDR to suppress an error message of the form: Xlib: extension "RANDR" missing on display ":99". that gets printed by Xlib on every test run on the bots. This message cannot be suppressed AFAIK since it's part of libx11. R=dpranke@chromium.org Change-Id: I50e249102a082074dbbc5f501921a2a8d0d99c0b Reviewed-on: https://chromium-review.googlesource.com/802624 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#521068}
-
liberato@chromium.org authored
Previously, MCVD ran on a thread that was owned by the mojo service. If the service was destroyed, then the thread would be also. This made it difficult for things to outlive MCVD (e.g., overlays). Now, it is sufficient to hold the task runner instead. This CL removes the ServiceContextRef, in favor of the task runner. Bug: 789447 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I1f07382a3977685d6a92f6f13a92d5455602d6ec Reviewed-on: https://chromium-review.googlesource.com/801334Reviewed-by:
Sergey Volk <servolk@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Chris Watkins <watk@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#521067}
-
Doug Arnett authored
Adds both a positive check and negative check. Bug: 787185 Change-Id: I4a5c9c450d4500604bbfc4690f7ef6fcc643c87a Reviewed-on: https://chromium-review.googlesource.com/804198Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Doug Arnett <dougarnett@chromium.org> Cr-Commit-Position: refs/heads/master@{#521066}
-
Tarun Bansal authored
flow is complete. When showing the second run promo, Chrome checks if the first run promo has completed. This CL adds a switch to disable that check if a command line switch is set. This switch would be used for UI Automator tests. Bug: 752972,752973 Change-Id: I345fbc89dd7c51cdca4ddf1203a9e1e29045cab4 Reviewed-on: https://chromium-review.googlesource.com/780264 Commit-Queue: Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#521065}
-
Luum Habtemariam authored
Update the GetPrintersURL call to utilize metadata_v2. This allows for certain restrictions to be placed on the model to determine whether or not the printer should be displayed Bug: chromium:773766 Change-Id: Iaade00489a066340a095b3b07bbd853f13f8e35a Reviewed-on: https://chromium-review.googlesource.com/797476 Commit-Queue: Luum Habtemariam <luum@chromium.org> Reviewed-by:
Sean Kau <skau@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#521064}
-
Qiang Xu authored
changes: When window is added to a workspace from another workspace, its current window bounds possibly is not the original-not-changed-by-user bounds, for example a resized bounds truncated by available workarea. Using a member in ash::wm::WindowState to store the windows bounds. It is used in window added to workspace event from another workspace. It is set when window is removing from a workspace and it is nullptr (using pre_auto_manage_window_bounds() if it exists otherwise current window bounds). It gets reset when window bounds is changed by user. DisplayMoveWindowUtilTest.KeepWindowBoundsIfNotChangedByUser, also tested on emulator. Not-user-resized window bounds will not affect the original bounds when moving between displays. Bug: 785017, 778438 Test: added the test coverage in Change-Id: I37d2c79238ea7200b32b5e3a9d5064addc575976 Reviewed-on: https://chromium-review.googlesource.com/770891 Commit-Queue: Qiang(Joe) Xu <warx@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#521063}
-