- 15 Jan, 2021 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/86e4bd2600ce..ff5c7857d90c 2021-01-15 janscheffler@chromium.org [JSDOC2TS]: Migrate cookie_table If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1158760 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I1c4da1c05b30741eb2a7e0bb9b24004e68b61782 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633074Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#844269}
-
Tom Sepez authored
Bug: 1166972 Change-Id: I258c25573d5900e8dae2d3f26bde5eeb200fd8b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633964Reviewed-by:
K. Moon <kmoon@chromium.org> Commit-Queue: Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#844268}
-
Kaiyu Chen authored
This reverts commit 768c05c0. Reason for revert: Should add this GPayAppDynamicUpdate feature flag to components/ instead of chrome/ Original change's description: > Add GPayAppDynamicUpdate feature flag. > > The feature flag controls the GPay native app integration for dynamic update with web payments on Android. > The integration for dynamic update is mainly about adding callback service to notify the browser about changes like shipping address. > Design doc is go/dynamic-update-mweb. > > Bug: 1074423 > Change-Id: I608ca5ddd5aa28f2da5672da83eefd0128720992 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617201 > Commit-Queue: Kaiyu Chen <kylechenkyc@google.com> > Reviewed-by: Sahel Sharify <sahel@chromium.org> > Cr-Commit-Position: refs/heads/master@{#841632} TBR=sahel@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,kylechenkyc@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1074423 Change-Id: I4b80472636a4673e7e96414d4c54fc6555f37bb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628490 Commit-Queue: Kaiyu Chen <kylechenkyc@google.com> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#844267}
-
John Abd-El-Malek authored
Change-Id: I7c3c32972b09c3b508015a5a12d8da8a022c2f2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2634123 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Auto-Submit: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#844266}
-
Xiaodan Zhu authored
The frequency of showing reverse scrolling toast is wrong when the continuous desks animation is enabled. This is because the functions DesksController::GetNext/PreviousDesk were modified to get the next/previous desk of the target active desk instead of the current active desk. This CL modifies the functions GetNext/PreviousDesk to make them can also return next/previous desks of currently active desk. Bug: 1166002 Change-Id: If45e6964bd5c3e382716d4695aa9b18a4ba593cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633875 Commit-Queue: Xiaodan Zhu <zxdan@chromium.org> Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#844265}
-
Anastasia Helfinstein authored
NOTRY=true Bug: None Change-Id: I90dd3a5f54a13d56b4e19667504ecba44d8f42ad AX-Relnotes: n/a. Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633946 Commit-Queue: Josiah Krutz <josiahk@google.com> Auto-Submit: Anastasia Helfinstein <anastasi@google.com> Reviewed-by:
Josiah Krutz <josiahk@google.com> Cr-Commit-Position: refs/heads/master@{#844264}
-
Yuly Novikov authored
Times out listing tests. Remove from the bot while investigating. Bug: 1167314 Change-Id: Idf85933ff83ef8a954e98ae2d403bb18d41b99b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633373Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#844263}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/071c3b1b313a..dabd9655278a 2021-01-15 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: I895eb8ce2b3822225e3956617466a373359d243c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633075Reviewed-by:
-
Sonny Sasaka authored
This fixes a bug where the error log is not printed when stop discovery fails in SecureChannel. Note: this reverts the changes in chromeos/services/secure_channel from CL:2068886. Bug: 1165598 Change-Id: I4959051c6f471b4d71ac96777f06bc484ffe6882 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626098 Commit-Queue: Sonny Sasaka <sonnysasaka@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#844261}
-
Yi Gu authored
This fixes an issue in crrev.com/c/2633342. TBR=tvanderlippe@chromium.org Bug: 1167158 Change-Id: I1855b3c2a20cd7d328b4cfcfb960be5e4773227f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633370Reviewed-by:
Fabrice de Gans-Riberi <fdegans@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Cr-Commit-Position: refs/heads/master@{#844260}
-
James Cook authored
Clean up some leftover logic from when we disabled lacros in M87 for non-google managed users. In particular, don't skip the policy check for developer builds with channel unknown. The LacrosAllowed pref defaults to true, so this doesn't affect developers who aren't working with policy. Bug: 1135494 Test: updated unit_tests Change-Id: I510ada8de5d266626ba8adef64a7dd33202574a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628592Reviewed-by:
Igor <igorcov@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#844259}
-
Klaus Weidner authored
This works around issues where using the screen keyboard (IME) during a WebXR AR session with DOM Overlay active left the compositor view in a confused state with SurfaceControl active. Keep SurfaceControl disabled for the duration of the session, and recreate the SurfaceManager at session exit. Bug: 1166248 Change-Id: I7f816ab0cfec40e316998c7c94ea6973d2d57826 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631470Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#844258}
-
Josh Karlin authored
Renames most occurrences of 'blacklist' with 'blocklist' in safe_browsing. Bug: 1160252 Change-Id: I30cd41f0dd73187745f3f438ac283e3ce36a2586 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597460 Commit-Queue: Josh Karlin <jkarlin@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Reviewed-by:
Chris Thompson <cthomp@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#844257}
-
Yue Zhang authored
This CL makes cart module scrollable by adding side scroll buttons to show previous/next items. The side scroll buttons will only be visible when the cart number goes beyond what we can show. Bug: 1160967 Change-Id: Ib06a3e89d8555a4194d38917f08dcec41994a0d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612126 Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#844256}
-
Torne (Richard Coles) authored
Add the nonembedded WebView code to the 64-bit library, because even though it's not used when running on a "regular" 64-bit device, it's needed if the license viewer (or anything else in the future that needs to load native code in the nonembedded processes) is launched on a 64-bit-only device. Bug: 1167259 Change-Id: I3fd21db8943c4a9b7fb4be2ab9254eb71ea709dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627755Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Auto-Submit: Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#844255}
-
Esmael El-Moslimany authored
When creating many new tabs, requestIdleCallback() seems to hang until there is a mouse action in the content area. This does not happen in the normal use case of opening a single new tab and interacting with it. Adding a timeout to requestIdleCallback() works around this issue. Bug: 1167047 Change-Id: Ic10d7f75f0be0c6ce9b34992df1a4dc09b9d0e3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633068 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
-
arthursonzogni authored
This content/public method shouldn't be used, because this bypass most of the navigation code and will inherit the wrong security properties. It might be good enough for testing, and is currently used only as such. Appending ForTesting to make it clear. Context: I would like to push the sandbox flags from the browser process. There are some unit test running without a browser process and dummy flags will be provided. I need to convince this would be for testing only. Bug: 1151340,1041376 Change-Id: I4004711692713360a3f4517db9f4f3a2962e9c12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631271 Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Auto-Submit: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#844253}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/aedd133cd85f..af4a3a998449 2021-01-15 amaiorano@google.com LLVMReactorDebugInfo: fix location filename always "<unknown>" on Windows If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: Ib48932a61b9c23ccdd3f465b28a9e2d1a610ae1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633175Reviewed-by:
-
Ali Juma authored
This CL disallows navigations to tel: URLs when the target frame is cross-origin with respect to the frame that is initiating the navigation. Change-Id: If2ce2d464065414513ed646e8611a919e5339f45 Bug: 1103119 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627751Reviewed-by:
Mohammad Refaat <mrefaat@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Ali Juma <ajuma@chromium.org> Cr-Commit-Position: refs/heads/master@{#844251}
-
Dan Sanders authored
This CL adds VideoFrame.close() as an alias for VideoFrame.destroy(), adds a deprecation message for VideoFrame.destroy(), and changes all callsites to use close(). Bug: 1166930 Change-Id: I39b9c68262553a6814f6bb0b6b81c02012c2d026 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631405 Commit-Queue: Dan Sanders <sandersd@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Eugene Zemtsov <eugene@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#844250}
-
Alex Turner authored
This is a reland of db1fc486 Reason for reland: The previous changes that led to test flakiness have been removed, but the other changes are retained. A comment has been added to land the removed changes when the flakiness is fixed. Original change's description: > Reland "Finish base::Bind -> Once/Repeating migration for media/blink and /cdm" > > This is a reland of 878c8c7d > > Reason for reland: media_blink_unittests should no longer be flaky after > updating the condition in UpdateBackgroundVideoOptimzationState(). The > flakiness derived from CancelableOnceCallback/Closure::IsCancelled() > returning true after the callback is run. > > Original change's description: > > Finish base::Bind -> Once/Repeating migration for media/blink and /cdm > > > > Use of base::Bind, ::Callback, etc. is deprecated in favor of the more > > explicit Once/Repeating versions. Despite being marked as fixed, a few > > directories have some remaining uses that were missed in the conversion. > > This cl fixes those stragglers in the media/blink and media/cdm > > directories. The presubmit is also enabled for these directories to > > avoid any future regressions. > > > > Bug: 1141533, 1102651, 1007802 > > Change-Id: I0a58ba3165c1c8873a25de76065a7425495b62b1 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505580 > > Reviewed-by: Dirk Pranke <dpranke@google.com> > > Reviewed-by: Chrome Cunningham <chcunningham@chromium.org> > > Commit-Queue: Alex Turner <alexmt@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#822344} > > Bug: 1141533 > Bug: 1102651 > Bug: 1007802 > Change-Id: Id1f87603ca9d41fe4fad91d6a7b389c889669fba > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508930 > Commit-Queue: Alex Turner <alexmt@chromium.org> > Reviewed-by: Dirk Pranke <dpranke@google.com> > Reviewed-by: Chrome Cunningham <chcunningham@chromium.org> > Reviewed-by: Dale Curtis <dalecurtis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#838765} Bug: 1141533 Bug: 1102651 Bug: 1007802 Change-Id: I1d8aa13942b6aa563f0b2cc2ef76b91a5a335418 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633367Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: Alex Turner <alexmt@chromium.org> Cr-Commit-Position: refs/heads/master@{#844249}
-
evliu authored
This CL adds the Speech On-Device API (SODA) language pack components for de-DE, es-ES, fr-FR, and it-IT. The language pack components are implemented as separate components because users will be able to install any combination of language packs. Bug: 1161569 Change-Id: I98f1dc2416056c10ea1d7c528ec45bca07343f48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602579 Commit-Queue: Evan Liu <evliu@google.com> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Reviewed-by:
Abigail Klein <abigailbklein@google.com> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#844248}
-
Becca Hughes authored
Change-Id: I146920685f82875fe610c2edb497711856456a52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2634021Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#844247}
-
Domenic Denicola authored
Although we'll keep the feature name as "OriginIsolationHeader", per the discussion in https://crbug.com/1158853#c8, we should update the comment to discuss the rename, and also remove the outdated reference to origin policy. Bug: 1158853 Change-Id: Idd719c083d5d16dcc2952e834367219f522752b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633423 Auto-Submit: Domenic Denicola <domenic@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Charlie Reis <creis@chromium.org> Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#844246}
-
Sammie Quon authored
Moves Finished to the destructor so it is always paired up with a Launching. Shelf relies on the two being paired up so it is hidden and shown properly. It's possible to modify Replace to have more return codes and handle the case a screenshot is not yet taken more gracefully. However, if a new use of Replace is added the user will have to ensure a new animation is not created on top of an existing one. Bug: 1166475 Test: manual Change-Id: I9d1ca10d4a028ee881af821ee4063ed2576c3b35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633069Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#844245}
-
yilkal authored
This cl fixes the missing next button in the gaia login page of the EduCoexistence flow. Bug: 1166901 Change-Id: Iae8d397079d939257fb65553ee3c9bb67d07ae19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631225Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Dan S <danan@chromium.org> Commit-Queue: Yilkal Abe <yilkal@chromium.org> Cr-Commit-Position: refs/heads/master@{#844244}
-
Yi Gu authored
See linked bug for details. TBR=fergal@chromium.org Bug: 1167300 Change-Id: I0146c5582867103a67e6abd69aae6216fcde9b0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633707Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1610690109-720706a87994e4668591f57ede90f04b6ed715af.profdata to chrome-mac-master-1610733364-fa73893da77d3e325227cfa68293cda0e1656c64.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I2320b80891f5c64db829d33956f2dd87da8d4b5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633882Reviewed-by:
-
Dale Curtis authored
This fuzzer works similarly to the other WebCodecs fuzzers except for corpus generation. The gist is that a protobuf structure for a sequence of ImageDecoder operations is defined and the fuzzer mutates both the number and contents of each operation. Corpus generation differs from the static corpus used by the other WebCodecs fuzzers. The image decoder fuzzer takes a base textproto with unfilled "type" and "data" fields, then fills in those fields using test data files from web_tests/images/resources. Since these are somewhat large image files, the corpus is written out in binary proto form. The generated corpus is ~12mb. Generating the corpus in this way ensures that the interaction of the API with various image types and lengths is well covered by the capabilities accessible to the fuzzer. Bug: 1166925 Test: Locally fuzzer runs fine with the corpus. Change-Id: Ie3d18911d235b184256dec6eac48e64fdd69c9c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2630590 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Jonathan Metzman <metzman@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#844241}
-
Ben Mason authored
R=rubber-stamper@appspot.gserviceaccount.com Change-Id: I1a15c1e427586f25a226435d0979295137ee7927 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633351 Auto-Submit: Ben Mason <benmason@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#844240}
-
Katie Dektar authored
This will let us do things similar to DCHECK for test by logging any bad state in the extension and causing a test failure. It also serves to remind developers to remove verbose logging. AX-Relnotes: N/A Bug: N/A Change-Id: I1011b8818d3e77da2a3bc08fe2f8da1158ffbdab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633366Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#844239}
-
Jan Wilken Dörrie authored
This change extends the PasswordManager.TimesPasswordUsed histograms and makes jdoerrie@ the primary owner. Fixed: 1160895, 1160896, 1160897 Change-Id: Ic93df378bb3a0e309684af5edc651768ed9062ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633265 Auto-Submit: Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#844238}
-
danakj authored
R=dcheng@chromium.org, nasko@chromium.org Bug: 1125106 Change-Id: I42b1c1275f3749f48b8fbc293c1acfc80c983cb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2629289 Commit-Queue: Nasko Oskov <nasko@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Auto-Submit: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#844237}
-
Josh Simmons authored
This includes the page URL and original/current/target language. It's gated by a new feature flag, AssistantIntentTranslateInfo, and is disabled by default. I've opted to include the page URL when translate info is being added (rather than rely on the separate PAGE_URL Feature) because Assistant is required to return it in the Translate intent. Bug: 1140581 Change-Id: Ic04777cb529902d4fdf461ca7e96c5b9dbcaaf9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625961Reviewed-by:
Brandon Wylie <wylieb@chromium.org> Reviewed-by:
-
Alexei Svitkine authored
I ran these locally via an ASAN build running on an emulator and did not see any failures. It's possible whatever issues seen before are already fixed. Bug: 1102747 Change-Id: I6ed6c49b69f2950857ed742856654972d5c0c776 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632054 Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Reviewed-by:
Caitlin Fischer <caitlinfischer@google.com> Cr-Commit-Position: refs/heads/master@{#844235}
-
siashah authored
We expect to show the IPH bubble up to: *A maximum of 3 times without without having the user dismiss it. *A maximum of 2 times if the user accepts the suggestion with the bubble. We do not care about how many bubbles were shown in the current session, this is to maximize the chances of showing the offer iph when the first time an offer is available. Bug: 1156916 Change-Id: Ia419391d350dd04dd1565ebb53334ec1fdd6a76e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625917Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Commit-Queue: Siddharth Shah <siashah@chromium.org> Cr-Commit-Position: refs/heads/master@{#844234}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: I2e29d87ce7fac11f2f24d5fa047cd6b72db05049 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633091Reviewed-by:
-
Ken Rockot authored
All mechanical (relative path) changes. Bug: 1004256 Change-Id: Ie93e691769ef885acdc368cb4524ebd3e373ecb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626983Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#844232}
-
Yi Gu authored
NOTRY=TRUE Bug: 1167309 Change-Id: If905b546159bd773b95490192de0f03da9f109d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633923 Auto-Submit: Yi Gu <yigu@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/d2e76b73efc2..8f5ca26678c1 2021-01-15 syoussefi@chromium.org Vulkan: Move xfb position decl to translator in extension path 2021-01-15 lexa.knyazev@gmail.com OpenGL: Remove avoidDXT1sRGBTextureFormat workaround 2021-01-15 jmadill@chromium.org Capture/Replay tests: Fixes and improvements. 2021-01-15 syoussefi@chromium.org Vulkan: Generate gl_Position.z correction in SPIR-V If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: timvp@google.com Change-Id: Icd410000b1f1a0090dc8a68a6b5e839e2c340388 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633138Reviewed-by:
-
