- 22 May, 2019 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/c9e2283502a7..7a6143385da4 git log c9e2283502a7..7a6143385da4 --date=short --no-merges --format='%ad %ae %s' 2019-05-22 sangwoo.ko@navercorp.com Decode datetime string when it's not utf-8 Created with: gclient setdep -r src/third_party/depot_tools@7a6143385da4 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:955206 TBR=agable@chromium.org Change-Id: I07e2fd4705d6f7d5122e506ba323d1c2567e675d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1622796Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#662066}
-
Torne (Richard Coles) authored
Use the new JavaRef<jobjectArray>::ReadElements helper to iterate through array elements in VrShell::OnTabListCreated. Change-Id: Ib1857000231e896428bc126bbbf08580e7644d8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1623458 Auto-Submit: Richard Coles <torne@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#662065}
-
Alexey Baskakov authored
Plumb WebApp.Icon.HttpStatusCodeClassOnSync histogram name to WebAppDataRetriever. We have deprecated Extensions.BookmarkApp.Icon.HttpStatusCodeClassOnCreate Extensions.BookmarkApp.Icon.HttpStatusCodeClassOnSync histograms in favor of WebApp.Icon.HttpStatusCodeClassOnCreate WebApp.Icon.HttpStatusCodeClassOnSync histograms. Bug: 901226 Change-Id: Ib1b6ced375efdf66f2b64e0803e4e82ad6df4a48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1621423 Commit-Queue: Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#662064}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/4f08faae82cc..bb90cccb7dd1 git log 4f08faae82cc..bb90cccb7dd1 --date=short --no-merges --format='%ad %ae %s' 2019-05-22 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 1216f271..15b783dc (661928:662034) 2019-05-21 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 0c18b1a2..1216f271 (661811:661928) Created with: gclient setdep -r src/third_party/webrtc@bb90cccb7dd1 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:None,chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ia22be9d2279c9adc3d29aca8e31a1799eac7e4a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1622795Reviewed-by:
-
Eugene But authored
loadURL: from other test helpers wait until load is finished. startLoadingURL: name emphasizes that method returns without waiting. Bug: 960407 Change-Id: I50a9f38cb30bece839279a9e46089fca6220af2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1623626 Auto-Submit: Eugene But <eugenebut@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#662062}
-
Jeevan Shikaram authored
ExtensionResource::GetFilePath will DCHECK if it's not called on a background thread. Currently, the App Service calls this method on the UI thread, which causes App Management to crash when DCHECKs are enabled. This CL refactors apps::LoadIconFromExtension to ensure that this method is only called on a background thread. Bug: 916380 Change-Id: I3ba8757e884c6336b4b7b61fc46363c8273fcc86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1619586Reviewed-by:
Nigel Tao <nigeltao@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Jeevan Shikaram <jshikaram@chromium.org> Cr-Commit-Position: refs/heads/master@{#662061}
-
Alan Cutter authored
This CL removes two flags: - enable-desktop-pwas: This is on by default for desktop. - enable-experimental-app-banners: This is on by default for Android These flags are being removed together because AppBannerManager::IsExperimentalAppBannersEnabled() was true if either one was true. This was in effect true for all platforms by default. TBR: vakh@chromium.org Bug: 959086 Change-Id: I0c9f170f3be7ba1cacc7750c9268316912c98ff4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1609744 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Azeem Arshad <azeemarshad@chromium.org> Reviewed-by:
Adrienne Porter Felt <felt@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
-
Alexey Baskakov authored
We need to destroy WebContents early on WebAppProvider::ProfileDestroyed() (as in PendingBookmarkAppManager()) Bug: 901226 Change-Id: I055e04678b5f0eb4c07f0f5d33e0208904033f7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1621986Reviewed-by:
calamity <calamity@chromium.org> Commit-Queue: Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#662059}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/38211554aed6..4b4149fa7025 git log 38211554aed6..4b4149fa7025 --date=short --no-merges --format='%ad %ae %s' 2019-05-22 manojgupta@chromium.org Revert "simple_builders: Disable kernel afdo update." Created with: gclient setdep -r src/third_party/chromite@4b4149fa7025 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Change-Id: I7a5085b78607128b813166195f300da102bae9a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1622901Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/e63b01b364a0..4ef7c2db2184 git log e63b01b364a0..4ef7c2db2184 --date=short --no-merges --format='%ad %ae %s' 2019-05-22 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-05-22 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-05-21 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-05-21 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@4ef7c2db2184 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=csmartdalton@google.com Change-Id: I7e10db40f154f8f1e2e8d081c5e740db04e0490b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1622900Reviewed-by:
-
Takuto Ikuta authored
This is step 2 written in https://chrome-internal-review.googlesource.com/c/infradata/config/+/1324360 I updated suppression list for data race happened in libgobject.so. e.g. https://ci.chromium.org/p/chromium/builders/try/linux_chromium_tsan_rel_ng/282235 Bug: 954450 Change-Id: I08c167b1b4f9077c1f74985b13e89c46f6ca203d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1621768Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#662056}
-
Hiroki Nakagawa authored
According to the issue, each browser-initiated request should have a unique request id. Bug: 937174 Change-Id: I49f27ef4a65aa98697156a5eb03f20f3f14e867d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1623650Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#662055}
-
Asanka Herath authored
The NetLogEventType::AUTH_CONTROLLER BEGIN event is logged the first time an entry point method is invoked on the controller. The END event is logged upon the destruction of the controller if a BEGIN event was logged. R: mmenke@chromium.org Bug: 884313 Change-Id: I884fc21f8208e60d5306bb9ea412b982aa90d2da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1619828 Commit-Queue: Asanka Herath <asanka@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Auto-Submit: Asanka Herath <asanka@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#662054}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=abdulsyed@chromium.org Change-Id: I4a1cc39088ff261134392959ec93d03c9a61916e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1623826Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#662053}
-
Peter Kotwicz authored
This CL re-enables WebApkUpdateManagerTest.testFileDeletedIfStoreWebApkUpdateRequestToFileFails WebApkUpdateManagerTest.testPendingUpdateFileDeletedAfterUpdateCompletion The tests started failing as a result of https://chromium-review.googlesource.com/c/chromium/src/+/1494657 BUG=937109 Change-Id: I7c129cde5d3e57b59be34fc750e5ec45e339c325 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1520208Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/c7e440c0091d..c9e2283502a7 git log c7e440c0091d..c9e2283502a7 --date=short --no-merges --format='%ad %ae %s' 2019-05-22 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-05-22 ehmaldonado@chromium.org Revert "gclient: Require a target ref when applying patches." 2019-05-21 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-05-21 ehmaldonado@chromium.org gclient: Require a target ref when applying patches. 2019-05-21 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@c9e2283502a7 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:956807,chromium:956807 TBR=agable@chromium.org Change-Id: Ibcd1faf80a62a75aa53d2dc388d274fa8dacc9eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1622896Reviewed-by:
-
John Lee authored
The feature that the histograms measure metrics for will continue to run past M76, and we want to continue logging metrics for it. Bug: 960027 Change-Id: Id61be13841aac9bc43366c91f9e633cdf14345b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1620771Reviewed-by:
-
Koji Ishii authored
Following bot results are included. 19864 19871 19875 19882 19902 19918 19936 19941 19942 19944 19945 19962 19968 19973 19974 19978 19985 19996 20007 20011 20020 20039 20052 20063 20078 20085 20089 20100 20117 20126 9 lines were removed and 2 lines were deflaked by consecutive results since 20007. TBR=eae@chromium.org, mstensho@chromium.org NOTRY=true Bug: 591099 Change-Id: I46312353405378c7624ea0b6c713977ea77c43b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617046Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#662049}
-
Yoshifumi Inoue authored
This patch introduces |SECURITY_DCHECK()| in |NGOffsetMapping| constructor and |NGOffsetMappingUnit| constructor to detect wrong behavior of |NGOffsetMappingBuider| for ease of debugging. This patch also remove |CHECK| for offsets in |NGOffsetMapping|[1] in |Element#innerText| because of we check them at construction time. [1] http://crrev.com/c/1619510 Make Element#innerText to use CHECK at StringView construction Bug: 964871, 965702 Change-Id: Ie03709d4eaddea6696f3d1bc009fd5184675ce8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1621803 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#662048}
-
Michael Giuffrida authored
Bug: 957772 Change-Id: I134c1ff6c1f3431ef7f0debc1ae346dd2dd689f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1620766 Auto-Submit: Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Ben Wells <benwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#662047}
-
Gary Kacmarcik authored
Change-Id: I278f34f5cc2d4ce7dc7f01e39ea9cd0e52be0c12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1623266Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Commit-Queue: Jamie Walch <jamiewalch@chromium.org> Cr-Commit-Position: refs/heads/master@{#662046}
-
Ian Vollick authored
Since the existing machinery is tied to the notion of focus, we need to move focus even when performing "focusless" spatial navigation. The rest of the "focusless" idioms apply, however. Layout tests are by default in accessibility mode, so I've had to provide a means to disable this for my tests and add extra tests to ensure that snav behavior is what we expect both in and out of accessibility mode. Bug: 941572 Change-Id: I82890eb27e35c902c27632badf65c1a09ca0667d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1620345Reviewed-by:
Rick Byers <rbyers@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#662045}
-
George Burgess IV authored
This reverts commit dd44cc9c, and updates its bug link. As the new bug mentions, ThinLTO caching appears to be causing Chrome links to take quite a bit longer (in wall-time; I don't think we have visibility on CPU time) than no ThinLTO caching. Until we can figure out why and fix it, disabling caching appears to be our best option Bug: 964328 Change-Id: I109892e6db5654c99e7ef6610b700d8a669e9ac3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1623788Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: George Burgess <gbiv@chromium.org> Cr-Commit-Position: refs/heads/master@{#662044}
-
Ashitha Santhosh authored
Bug: 939657 Change-Id: I3d640f45faac35214f6ef41c80cd55a3a88d6017 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1604067Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Ashitha Santhosh <ashithasantosh@google.com> Cr-Commit-Position: refs/heads/master@{#662043}
-
Paul Irish authored
Bug: 958976 Change-Id: Ia89ac356cf54f41af0daeb217fa7b3a4d43e7a46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1623746 Auto-Submit: Paul Irish <paulirish@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Paul Irish <paulirish@chromium.org> Cr-Commit-Position: refs/heads/master@{#662042}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/b5e56574cb70..38211554aed6 git log b5e56574cb70..38211554aed6 --date=short --no-merges --format='%ad %ae %s' 2019-05-22 akeshet@chromium.org test_stages: use task-result 'success' key Created with: gclient setdep -r src/third_party/chromite@38211554aed6 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Change-Id: I930ffff16a5a74d3cb1f2639a8492c3d91575451 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1622892Reviewed-by:
-
rbpotter authored
Like the controls in the sidebar, the custom margins controls should be disabled if the Print Preview is not ready, there is a validation error on the page, etc. Bug: 940386 Change-Id: I2d92c3c13835626b04288c805273ffbcfc3d364b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618641Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#662040}
-
Kenichi Ishibashi authored
This CL moves logic to top-level script execution from ServiceWorkerGlobalScope to WorkerGlobalScope so that we can use the same logic among other WorkerGlobalScopes. We will use this functionality to avoid a race condition which could happen when off-the-main-thread shared worker script fetch is enabled. Change-Id: Ib34373fe7864189da5ba4c00d19db2c027ce36cc Bug: 945673 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1616863 Auto-Submit: Kenichi Ishibashi <bashi@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#662039}
-
Vladislav Kaznacheev authored
Some decisions regarding shelf visibility are made based on the current mouse position. It leads to counter-intuitive behavior when mouse events are followed by touch and the cursor is hidden (see bug). Bug: 963977 Test: modified ShelfLayoutManagerTest.AutoHide Change-Id: I82e269db0df0429e73270e28c5f431ffc6f0ca7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1623136Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Vladislav Kaznacheev <kaznacheev@chromium.org> Cr-Commit-Position: refs/heads/master@{#662038}
-
Donna Wu authored
Whe GetDevices() is the first method call to be made, we should also need to make sure the connection with the DeviceService. Bug: 699790 Change-Id: Ie5d6b8f606fafba7372bffcfffc4d3e13e2f3603 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617201 Commit-Queue: Donna Wu <donna.wu@intel.com> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#662037}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/6ba8b68b..90984359 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ibeef6c9eeb88ff00dc223c76464a0d89b979a047 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1623371Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#662036}
-
Oystein Eftevaag authored
This is what the old crash-based uploader enforced and is a good starting point for the Perfetto-based ringbuffer size as well. R=ssid@chromium.org Change-Id: I05685589d94583434c59f690620af84e314ee313 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1623492 Commit-Queue: ssid <ssid@chromium.org> Reviewed-by:
ssid <ssid@chromium.org> Cr-Commit-Position: refs/heads/master@{#662035}
-
Kinuko Yasuda authored
I think it's just got mixed up but your cross-checking is appreciated. Bug: N/A Change-Id: I88ee161bdadcf732a01082906d87848fd52a90df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1621789Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#662034}
-
John Budorick authored
Necessary for running arm builds on devices that support aarch64 and arm. Bug: 861509 Change-Id: I87bd1bdae3def36d35313436a7c6f2423532be25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1622715 Auto-Submit: John Budorick <jbudorick@chromium.org> Reviewed-by:
-
Eric Willigers authored
OffscreenCanvas shipped in M69. https://chromestatus.com/features/5681560598609920 The flags OffscreenCanvas and OffscreenCanvasText have been stable since https://chromium-review.googlesource.com/1119156 Bug: 563816 Change-Id: Ie212e1c83f0c366ca6a63a34b842481eb9566845 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1616930 Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#662032}
-
Yeol Park authored
In order to better convey property object ownership, changed MdTextButton::Create() to return std::unique_ptr. Bug: 948287 Change-Id: Ib48fdaff3e647d0178b46871f0ebbb8fe53075a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1612799Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: Yeol Park <peary2@gmail.com> Cr-Commit-Position: refs/heads/master@{#662031}
-
Krishna Govind authored
TBR=meacer@chromium.org Change-Id: I416734d443ad3aa0f99b1df92427166f647d5445 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1623562 Commit-Queue: Krishna Govind <govind@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#662030}
-
Jordy Greenblatt authored
The crbug.com/945632 pointed out that the MultiDevice setup OOBE UI showed an unfortunate behavior in other languages: only one string on the page translated [1]. It turned out there were a few different problems masking one another. First, the start-setup-page element did not bind its translations to I18nBehavior.locale, which is the standard mechanism for passing location data in OOBE. Once that was fixed, it became clear that the OOBE screen 'MultiDeviceSetupScreen' was not notifying any Multidevice Polymer elements of locale updates so the I18nBehavior.locale bindings were not receiving updates. Also, because the buttons and headings were translated in ui_page_container_behavior.js, those translations had to be bound to I18nBehavior.locale separately. I also moved those translations to more visible locations and used the literal string IDs instead of factoring out the string IDs and computing the translations in the UiPageContainerBehavior in an effort to make the data flow more transparent. The next big issue was that the strings with placeholders were not registered appropriately in OOBE localization. This difference didn't become clear until the binding issue was resolved because there was no visible difference in the behavior of the placeholder strings and the other strings until that point. Also, because the registration infrastructure in OOBE uses a totally different API, the placeholder strings were translating correctly post OOBE, which added to the confusion. See multidevice_setup_localized_strings_provider.cc for the relevant change. After this change, the start-setup-page translates strings correctly in OOBE [2] (this is the only MultiDevice screen in the OOBE flow) and post-OOBE [3] along with the password-page [4] and setup-succeeded-page [5]. Once this change is merged into the current branch (i.e. the immediate fire is out), we can simplify multidevice_setup_localized_string_provider.cc by splitting up the strings with placeholders into regular strings and concatenatng them manually in HTML (see crbug.com/961841). [1] https://screenshot.googleplex.com/w2tWTTZJkvj [2] https://screenshot.googleplex.com/dGvFOTQozLH [3] https://screenshot.googleplex.com/9GuB8bwkqS4 [4] https://screenshot.googleplex.com/QGZc9aaEdtE [5] https://screenshot.googleplex.com/FCAWDNTTVn4 Bug: 945632 Change-Id: I141e925e70550b1e33b06aef25ed4f72a06d5988 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1591965 Commit-Queue: Jordy Greenblatt <jordynass@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#662029}
-
Joshua Peraza authored
By default the option consumes the next flag, which happens to be --native-libs=libcrashpad_handler.so for chrome modern bundle modules. Bug: 960534 Change-Id: I09c3df3c6433a85006c7143256cec2a51e14976e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1622661 Auto-Submit: Joshua Peraza <jperaza@chromium.org> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Commit-Queue: Eric Stevenson <estevenson@chromium.org> Commit-Queue: Joshua Peraza <jperaza@chromium.org> Cr-Commit-Position: refs/heads/master@{#662028}
-
François Degros authored
Bug: 778674 Change-Id: Ic01d71c337c22a0f5b573e01d5525c3405aa8942 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1623647 Commit-Queue: François Degros <fdegros@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Auto-Submit: François Degros <fdegros@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#662027}
-
