- 30 Nov, 2017 40 commits
-
-
Victor Costan authored
This CL replaces Blob usage in the value wrapping code with direct construction of the underlying BlobData and BlobDataHandle structures, and removes a SSV data buffer copy. Change-Id: I0c107cd649c60614f6464e4b7587226cfa387893 Reviewed-on: https://chromium-review.googlesource.com/712555 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#520694}
-
Devlin Cronin authored
The extension inline install dialog contains a section for the webstore ratings. This is rendered as a star rating (n / 5 filled stars) and a user count displayed in parentheses. For example, ***** (345) Unfortunately, the accessible text for this is lacking - each star (filled or not) simply says "graphic", followed by the number. So the content read by a screen reader would be: "graphic graphic graphic graphic graphic 345" which is very unhelpful. Introduce a custom view for the ratings section, which hides the star graphics and the user label from the accessibility tree. Instead, provide custom accessible text to give meaning. Now, the screen reader will read: "Rated 5.0 by 345 users" Bug: 747624 Change-Id: I96d829efd098cc6795389b3190f0c2a901f55a93 Reviewed-on: https://chromium-review.googlesource.com/782711 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#520693}
-
Bruce Dawson authored
base::debug::Alias is normally used to force the compiler to retain local variables by making it think that some external data structure contains a pointer to them. Passing an arbitrary pointer to Alias has no effect on the optimizer. Removing this use of Alias will help minimize confusion. Bug: 756589 Change-Id: Iab183c96748f555e1b364a0ea714e5b84c0b6829 Reviewed-on: https://chromium-review.googlesource.com/794553Reviewed-by:
Randy Smith <rdsmith@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#520692}
-
Qiang Xu authored
changes: Add test coverage for multi window resizer dragging to change bounds of two snapped windows. Also in file cleanup. Bug: 783589 Test: covered by tests. Change-Id: I1ce5e5d4aa762c55a5a5933be452ce3fb4c7b1fa Reviewed-on: https://chromium-review.googlesource.com/799810Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Qiang(Joe) Xu <warx@chromium.org> Cr-Commit-Position: refs/heads/master@{#520691}
-
Vlad Tsyrklevich authored
Change-Id: Ie1c21fe556f6e73bb5ab643e56c967fe96f870d0 Reviewed-on: https://chromium-review.googlesource.com/801538Reviewed-by:
Peter Collingbourne <pcc@chromium.org> Commit-Queue: Peter Collingbourne <pcc@chromium.org> Cr-Commit-Position: refs/heads/master@{#520690}
-
Robert Hogan authored
Bug: 784793 Change-Id: Ib41a9a940acddf8737c261c3d14b39bf683aece4 Reviewed-on: https://chromium-review.googlesource.com/789930 Commit-Queue: Robert Hogan <robhogan@gmail.com> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#520689}
-
EhsanK authored
This CL moves some editing methods from WebWidget to WebLocalFrame. The immediate benefit of this move is deduping the code in between WebViewImpl and WebFrameWidgetImpl. Furthermore, most other editing methods are already defined per frame. The logic inside the methods moved in this CL also act on the focused frame inside a widget. Bug: 629721 Change-Id: Iad9c291268aeab65965b016cf50b8863e3a0729f Reviewed-on: https://chromium-review.googlesource.com/789530Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Rick Byers <rbyers@chromium.org> Commit-Queue: Ehsan Karamad <ekaramad@chromium.org> Cr-Commit-Position: refs/heads/master@{#520688}
-
Scott Graham authored
Also, make --dump-tree work with --stdin by sending the tree to stderr. Bug: 790003 Change-Id: Ie9fde86826cb28b873f726543c034f5c9992cd84 Reviewed-on: https://chromium-review.googlesource.com/801092Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#520687}
-
Jinsuk Kim authored
GesatureStateListener has no concrete implementation for any interface methods but declared as class just to avoid having to add many empty methods in the implementation. Now it can take advantage of default interface method and be declared as interface. Bug: 789000 Change-Id: Id0f7515a073ced947cf88bc1e6ded5cd69dc4868 Reviewed-on: https://chromium-review.googlesource.com/798870Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#520686}
-
Dave Tapuska authored
The callsites were updated in https://chromium-review.googlesource.com/c/chromium/src/+/793971 however I left the DCHECK still in and didn't allow nullptr as the return value. This caused the clusterfuzz failures. BUG=789926,789906 Change-Id: I950f4ea72225faa0f9be3afbe022e0152079aa92 Reviewed-on: https://chromium-review.googlesource.com/801637Reviewed-by:
Mustaq Ahmed <mustaq@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#520685}
-
Eugene But authored
Implementors of DownloadTaskObserver::OnDownloadUpdated should be able to call RemoveObserver on a ppased task, if the download is complete. Bug: 780646 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I86f2058e35e9caeb09e32505ef05486f855646eb Reviewed-on: https://chromium-review.googlesource.com/798312Reviewed-by:
Gregory Chatzinoff <gchatz@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#520684}
-
David Dorwin authored
These histograms were just added so this should not affect data. Bug: 788013 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I1937fe84f49212b53cff9e0f5cd6a0af195a9d52 Reviewed-on: https://chromium-review.googlesource.com/795034 Commit-Queue: David Dorwin <ddorwin@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Ian Vollick <vollick@chromium.org> Reviewed-by:
Biao She <bshe@chromium.org> Cr-Commit-Position: refs/heads/master@{#520683}
-
Yash Malik authored
In this CL, if we detect that a VR intent requires a VR core update, we simply ignore it. This is needed because we may enter Chrome in VR mode but can't do anything else (such as show a toast in VR), because we don't have the correct version of gvr. The long term solution here is to have VrCore itself prompt the user to upgrade. Bug: 772514 Change-Id: I18b5a0ec11f4f68edfb408a71ce54c724e50cc3a Reviewed-on: https://chromium-review.googlesource.com/797734 Commit-Queue: Yash Malik <ymalik@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
-
David Tseng authored
1. the initial value change on sliders sometimes did not get dispatched because a client user of the Slider class can and does set the initial slider value before attaching it to a widget and making that widget visible. Fire the value change when visibility changes for the slider if needed. An example of where this occurs is the Chrome OS volume slider which changes without it actually receiving focus. The system tray briefly shows the volume control. 2. ChromeVox specific: make ChromeVox output the entire node including role and any states when it first encounters the node. Note that these nodes are transient so disappear quickly. We don't reset the value of |lastValueChangedTarget_ as a result. Test: manual. Bug: 755392 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I86da8d1f5aed933dcc36a460202402f576a8a5f9 Reviewed-on: https://chromium-review.googlesource.com/777599 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
-
Avi Drissman authored
This reverts commit 9e4a1523. Reason for revert: fast/dom/MutationObserver/weak-callback-gc-crash-case2.html fairly consistently fails on Win7 Tests (dbg)(1) . See https://ci.chromium.org/buildbot/chromium.win/Win7%20Tests%20%28dbg%29%281%29/64920 as an example. Original change's description: > MutationObserver: Do nothing when its execution context is no longer available. > > MutationObserver::DeliverMutations is a static function and > registered to the microtask queue. It maintains active > observers and also makes active observers alive, but nothing > else (the underlying callback function nor execution context). > > So, when DeliverMutations invokes each active observer, > DeliverMutations must make sure that each active observer's > execution context is still available. > > This patch adds the check of the execution context. > > Bug: 788495, 789862 > Change-Id: Ic350603cc8a7b13275adf042e731fdd9605373aa > Reviewed-on: https://chromium-review.googlesource.com/799653 > Commit-Queue: Yuki Shiino <yukishiino@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Cr-Commit-Position: refs/heads/master@{#520509} TBR=peria@chromium.org,yukishiino@chromium.org,haraken@chromium.org Change-Id: I00ea0349a3f441f6d2fb356d179b5e301c253df3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 788495, 789862 Reviewed-on: https://chromium-review.googlesource.com/801222Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#520680}
-
Oskar Sundbom authored
The setting does not seem to be documented, but was easily found by tracking property changes to a device and playing around in settings. This implementation keeps a suppression count and re-enables ambient noise reduction, if it was initially enabled, once all streams requesting this behavior have stopped. Bug: chromium:789152 Change-Id: I1672a44bf185beedef2caaff8f66f5c50a9aad95 Reviewed-on: https://chromium-review.googlesource.com/737873 Commit-Queue: Oskar Sundbom <ossu@chromium.org> Reviewed-by:
Jason Chase <chasej@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Reviewed-by:
Tommi <tommi@chromium.org> Cr-Commit-Position: refs/heads/master@{#520679}
-
Wei-Yin Chen (陳威尹) authored
Log whether the bookmark entry is a user bookmark or a partner bookmark when it is opened. Bug: 787132 Change-Id: Ia42d88125e60ba0fb1710ea9b3eef6c7d63a0b5d Reviewed-on: https://chromium-review.googlesource.com/799030Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
-
pdfium-deps-roller@chromium.org authored
https://pdfium.googlesource.com/pdfium.git/+log/646257d65c65..fee910e6f81f $ git log 646257d65..fee910e6f --date=short --no-merges --format='%ad %ae %s' 2017-11-30 npm Prevent integer overflow in CJBig2_HuffmanTable::ParseFromCodedBuffer Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I55e3ea4fbc1ff2a6f36d7f624a99e80da558b5ff Reviewed-on: https://chromium-review.googlesource.com/801255 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#520677}
-
Robert Hogan authored
Bug: 789653 Change-Id: I5ea9761a687b4c9a64437df032af27d1a96080fb Reviewed-on: https://chromium-review.googlesource.com/797454 Commit-Queue: Robert Hogan <robhogan@gmail.com> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#520676}
-
Stuart Langley authored
This changes is for files in the path //t_p/WebKit/Source/platform/wtf/. Added the include for base/macros.h where needed and moved the macro to the end of the class as per the code guidelines enforced by lint. This CL introduces no logic changes. Bug: 565932 Change-Id: I55718a92a5e919e16aaac01fc33446e5ea169354 Reviewed-on: https://chromium-review.googlesource.com/791411 Commit-Queue: Stuart Langley <slangley@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#520675}
-
Michael Giuffrida authored
This adds counters for key, mouse, and touch events to TabActivityWatcher::WebContentsData. When a tab is logged, these counters are reported in the UKM. The counters are reset on each navigation. These counters are passed to TabSnapshotLogger in a new hierarchical structure, which will be built upon to add browser-, tab- and page- specific metrics. Separating these event counts into a separate struct makes it easier to reset them when a navigation occurs. This CL counts the absolute number of events -- as an improvement, we would prefer to count user actions rather than, say, the exact number of mouse-move events fired. A unit test simulates mouse activity, but key and touch are harder to pipe in from a unit test. Bug: 784639 Change-Id: I693c34f0845c3fdeca6c1fb172e7347f9c2a504f Reviewed-on: https://chromium-review.googlesource.com/794592 Commit-Queue: Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#520674}
-
Xiaochu Liu authored
https://chromium.googlesource.com/chromiumos/platform/system_api.git/+log/9b6a22544458..7092a3102eae $ git log 9b6a22544..7092a3102 --date=short --no-merges --format='%ad %ae %s' 2017-11-29 xiaochu Add constant to imageloader dbus API 2017-11-29 derat system_api: Document potential races in suspend readiness. 2017-11-27 allenvic smbprovider: Add ReadDirectoryOptions and GetMetadataEntryOptions Created with: roll-dep src/third_party/cros_system_api Bug=chromium:780575 TEST=None Change-Id: I0f633691030275ebf8d3e398efc9b9a568a69db9 Reviewed-on: https://chromium-review.googlesource.com/801211Reviewed-by:
Dan Erat <derat@chromium.org> Commit-Queue: Xiaochu Liu <xiaochu@chromium.org> Cr-Commit-Position: refs/heads/master@{#520673}
-
Erik Luo authored
Bug: 700624, 727514 Change-Id: I54f08aa19e76f505303b9314fa56d7deb3fcb348 Reviewed-on: https://chromium-review.googlesource.com/794490Reviewed-by:
Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Commit-Queue: Erik Luo <luoe@chromium.org> Cr-Commit-Position: refs/heads/master@{#520672}
-
Daniel Bratell authored
Includes from the X11 system libraries declare macros with common names such as None, True, False, Status and those complicate the life for other code. To avoid that complication we have moved the common symbol names to the namespace x11 and changed so that you include "ui/gfx/x/x11.h" instead. Bug: 782184 Change-Id: I3d2893425bb79cb29d6c5a602512a0e8d3cc30cd Reviewed-on: https://chromium-review.googlesource.com/800550Reviewed-by:
-
Miguel Casas authored
This CL adds two files to //media/test/data, namely: - test-25fps.vp9_2: VP9 Profile 2 file in an IVF container - test-25fps.vp9_2.md5: md5 version of its thumbnails. to be used with video_decode_accelerator_unittests. This CL also updates Vp9ParserTest to use the new file instead of media/test/data/crowd-vp9.2.ivf, which is removed (the new file is smaller). It also updates media/test/data/README.md with details on how the new files were generated. TEST=compile and run on a soraka: video_decode_accelerator_unittest --test_video_data=test-25fps.vp9_2:320:240:250:250:35:150:14 (Note the last number is a 14 == VideoCodecProfile for VP9.2) Bug: 778093 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I53e1a1802cb4c8b634e5f979d7afba143b259b68 Reviewed-on: https://chromium-review.googlesource.com/797853Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#520670}
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/catapult.git/+log/9968f9b780e9..0ee7aab89cf2 $ git log 9968f9b78..0ee7aab89 --date=short --no-merges --format='%ad %ae %s' 2017-11-30 eakuefner [Dashboard] Remove spurious conditional Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I17e5ab01f8bd08cf0b6aa7bcbc2c457701726912 Reviewed-on: https://chromium-review.googlesource.com/801332 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#520669}
-
David Trainor authored
Add the following system properties to the feedback collection mechanism: - CPU Architecture - GPU Vendor - GPU Model - Total MB memory - Available MB memory - Total MB storage (of data directory) - Available MB storage (of data directory) BUG=773397,773399,773400,773402 Change-Id: I49fdc3955bf71577d77dfac18029e5b4d7895ae0 Reviewed-on: https://chromium-review.googlesource.com/794852 Commit-Queue: David Trainor <dtrainor@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#520668}
-
Sean O'Brien authored
If a trackpad pinch ends at scale level 105% or lower, snap to 100% with a scale animation. BUG=769934 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I6d7e185951900f11afadf80c7eeea16f8a4156b6 Reviewed-on: https://chromium-review.googlesource.com/691202 Commit-Queue: Sean O'Brien <seobrien@chromium.org> Reviewed-by:
Mike Pinkerton <pinkerton@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#520667}
-
Ryan Harrison authored
The lack of conversion was causing an offset error because some of the numbers being used were in the character list index space and some of them were in the text buffer index space. This CL combined with https://pdfium-review.googlesource.com/c/pdfium/+/20014 in PDFium resolves outstanding issues with Find highlights in PDFs with control characters in the text body. BUG=chromium:654578 Change-Id: I5f600a59926f137ed0a0901711a3ff57d3e42e34 Reviewed-on: https://chromium-review.googlesource.com/801310Reviewed-by:
dsinclair <dsinclair@chromium.org> Commit-Queue: Ryan Harrison <rharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#520666}
-
Yuzhu Shen authored
It currently uses URLRequestMockHTTPJob::GetMockUrl(), which is not compatible with network service. BUG=776589 Change-Id: Ie6c46e1376c735b9885ce7d267001fbe2c3e6a09 Reviewed-on: https://chromium-review.googlesource.com/762184 Commit-Queue: Yuzhu Shen <yzshen@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#520665}
-
Victor Costan authored
Change-Id: I39b36b6c1ae97c457c760bf1eff0398d43f07c2d Reviewed-on: https://chromium-review.googlesource.com/799951Reviewed-by:
-
Jiaquan He authored
This commit refactors the relationship among AppListModelBuilder, AppListSyncableService, and AppListModel: - removing the kEnableSyncAppList/kDisableSyncAppList switch; - stressing the fact that AppListModel and AppListModelBuilders are owned by AppListSyncableService independently; - creating AppListModelUpdater as an interface to access the model; - accessing the model from AppListModelBuilder and its derived classes with AppListModelUpdater instead of a real model; - creating a FakeAppListModelUpdater for affected tests; This commit is part of the app list migration. Bug: 733662 Change-Id: I421b1a96694fc6a7ad58d380c1644d16264d354e Reviewed-on: https://chromium-review.googlesource.com/792511Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
-
Bailey Berro authored
This CL adds a class wrapping a provider which is responsible for creating instances of file systems and returning capabilities. This is a necessary change to support native file systems in the future. Service will now lookup the Provider via provider_id to call GetCapabilities() & CreateFileSystem(). Bug: 778791 Test: All unit tests pass. Change-Id: Ic0d8c9cf12d3386755cb147cec0fbd1e277fce5b Reviewed-on: https://chromium-review.googlesource.com/794754 Commit-Queue: Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Tomasz Mikolajewski <mtomasz@chromium.org> Cr-Commit-Position: refs/heads/master@{#520662}
-
Philip Jägenstedt authored
This reverts commit f3535b85. Reason for revert: AccessibilityFullscreenBrowserTest.IgnoreElementsOutsideFullscreenElement is flaky on linux-chromeos-rel Original change's description: > Make elements outside of the fullscreen element inert > > There is no spec for this, but an old open spec issue: > https://github.com/whatwg/fullscreen/issues/15 > > Bug: 787867 > Change-Id: Icde796405fca96e910480aef6f0d6be835f7a27a > Reviewed-on: https://chromium-review.googlesource.com/788052 > Commit-Queue: Philip Jägenstedt <foolip@chromium.org> > Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> > Cr-Commit-Position: refs/heads/master@{#520620} TBR=dmazzoni@chromium.org,mlamouri@chromium.org,foolip@chromium.org Change-Id: I5e042244565404b7735f4e5fecc4d1194ed2a402 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 787867 Reviewed-on: https://chromium-review.googlesource.com/801517Reviewed-by:
-
Luciana Maroun authored
ChromeOS user type is set based on decoded is_child_account information derived from the ID token, and this type is also used to trigger website supervision on the browser. This is part of the migration from the deprecated GetUserInfo call that was used to detect a child account. DD: https://docs.google.com/document/d/13VBL5yBr6cXHX70bs7L1jIH68GXZp67f7cBqICcCESk/edit Bug: 716063 Change-Id: I47177aa8e7a87c4b57ffe1599f8029bc684d7e55 Reviewed-on: https://chromium-review.googlesource.com/792285 Commit-Queue: Luciana Maroun <maroun@google.com> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#520660}
-
Nathan Bruer authored
If a file is changed on the filesystem and is ignored in devtools it will now properly not be created in workspaces. R=lushnikov BUG=754371 Change-Id: Ic0bc61ede57fb1aa17f1483f614bcca414fe14b6 Reviewed-on: https://chromium-review.googlesource.com/798735 Commit-Queue: Blaise Bruer <allada@chromium.org> Reviewed-by:
Andrey Lushnikov <lushnikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#520659}
-
Min Qin authored
The test should pass now after https://chromium-review.googlesource.com/c/chromium/src/+/773483 BUG=715630 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I1850aaf490b1920e9e2bc9766a6e291d0ba50b0f Reviewed-on: https://chromium-review.googlesource.com/795037Reviewed-by:
Xing Liu <xingliu@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#520658}
-
Vlad Tsyrklevich authored
Control Flow Integrity [1] indirect call (cfi-icall) checking can not verify that dynamically resolved function pointers call their intended function. Instead we place the pointer for gdk_set_allowed_backends in ProtectedMemory, a wrapper for keeping variables in read-only memory except for when they are initialized. After setting the pointer in protected memory we can use the UnsanitizedCfiCall wrapper to disable cfi-icall checking when calling it since we know it can not be tampered with. [1] https://www.chromium.org/developers/testing/control-flow-integrity Bug: 771365 Change-Id: I5c359697c466921084aea17cda655231fdc33a92 Reviewed-on: https://chromium-review.googlesource.com/775617Reviewed-by:
Elliot Glaysher <erg@chromium.org> Reviewed-by:
-
Daniel Bratell authored
Jumbo is a unity build system for Chromium, aimed at reducing compilation times by merging cc files into larger translation units. This is 0.1% of the total build time so not very much but also the final remaining part of blink/platform. And all the CPU minutes add up. Bug: 761475 Change-Id: Id0643d869960a660a91a4f3a9a23b4585f9e0073 Reviewed-on: https://chromium-review.googlesource.com/785678Reviewed-by:
-
Alex Vallée authored
TBR: rbyers, foolip Bug: 789707 Change-Id: I9ceb10e4ce74680a1d7d422a2d9391fd8b2a25c7 Reviewed-on: https://chromium-review.googlesource.com/801456Reviewed-by:
Alex Vallee <avallee@chromium.org> Commit-Queue: Alex Vallee <avallee@chromium.org> Cr-Commit-Position: refs/heads/master@{#520655}
-
