GitLab

BUG=119473
TEST=added some unittests

Review URL: http://codereview.chromium.org/10007008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133485 0039d316-1c4b-4281-b951-d872f2087c98

Also adding unittests to FileUtilProxy.

BUG=123558,77454
TEST=FileUtilProxyTest.*


Review URL: http://codereview.chromium.org/10095028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133484 0039d316-1c4b-4281-b951-d872f2087c98

Add a Profile* member to TemplateURL.  This makes some invocations of ReplaceSearchTerms() a bit less verbose, and will be useful later when UIThreadSearchTermsData starts taking a Profile*.

One downside is that there are a number of const_cast<>()s added when we try to access the profile() of a const TemplateURL*.  These will all go away soon when TemplateURLService is switched to using "const" much less, so I didn't worry too much about them.

BUG=none
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10173001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133483 0039d316-1c4b-4281-b951-d872f2087c98

Reverted because it failed to find "flapper.h" in pepper_flash_component_installer

Review URL: http://codereview.chromium.org/10123016

TBR=viettrungluu@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10193001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133482 0039d316-1c4b-4281-b951-d872f2087c98

This is part of Chrome for Android upstreaming.

This CL makes ListenSocket an abstract class instead of a concrete class
implementing a TCP Listen Socket. This abstraction will be used later to make
HttpServer seamlessly operate on TCP sockets and Unix domain sockets (will be
upstreamed in a separate CL).

The TCP Listen socket implementation, previously in listen_socket.{cc,h}, is
now in tcp_listen_socket.{cc,h}.

TEST=net_unittests


Review URL: http://codereview.chromium.org/10108015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133480 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/10183006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133479 0039d316-1c4b-4281-b951-d872f2087c98

DeepCopy creates a ListValue*, which swap (correctly) doesn't free.

CID=103840
R=brettw,raymes

BUG=
TEST=


Review URL: http://codereview.chromium.org/10168015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133478 0039d316-1c4b-4281-b951-d872f2087c98

BUG=124374
TEST=PolicyServiceTest.NotifyObservers is green


Review URL: http://codereview.chromium.org/10174003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133476 0039d316-1c4b-4281-b951-d872f2087c98

Fixed all tests on Windows.

Ignore \Device\Mup on Windows.

Still saw some flakiness on tracing on Windows, to be addressed in a separate
patch.

R=nsylvain@chromium.org
BUG=98834
TEST=Run all the isolate tests on Windows or OSX


Review URL: http://codereview.chromium.org/10091011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133475 0039d316-1c4b-4281-b951-d872f2087c98

R=viettrungluu@chromium.org
TEST=
BUG=


Review URL: http://codereview.chromium.org/10162022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133474 0039d316-1c4b-4281-b951-d872f2087c98

Some users liked it, others hated it, others wanted to be able to toggle it.
This patch just disables the current behavior and should be merged to the
M19 branch, then I'll try a new approach in the trunk.

BUG=112944
TEST=none


Review URL: http://codereview.chromium.org/10146031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133473 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/10123016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133472 0039d316-1c4b-4281-b951-d872f2087c98

Minor cleanups from my working copy.

BUG=None


Review URL: http://codereview.chromium.org/10146017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133471 0039d316-1c4b-4281-b951-d872f2087c98

This includes unit tests for the API, but no uses yet.

This change also involves exposing a new MakeGroupNameId static helper in FieldTrial to assist with the usage of this new API.

BUG=121988
TEST=Ensure that unit_tests GoogleExperimentsTest.* pass.


Review URL: http://codereview.chromium.org/10165014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133470 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
TBR=sky
Review URL: https://chromiumcodereview.appspot.com/10183007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133469 0039d316-1c4b-4281-b951-d872f2087c98

This CL fix the wallpaper fade animation problem. The problem was when user
switched to a new wallpaper, it seems there is a white flashing before new
wallpaper fade in.
The reason was I started the hide animation before loading new wallpaper. And it
took around 300ms to load while the animation finished around 200ms. So there is
100ms period where the background color (white) showed up.
I delayed the hide animation, but then another problem showed up. Now the show
and hide animation happened at the same time. At some point in the animation,
the background color will have 25% opacity and it also cause a flashing.

To fix all, this CL only animate on Show new wallpaper and delete the old widget
after the Show animation completed.

BUG=118651
TEST=Change wallpaper in chromeos, and verify if the animation is smooth.

Review URL: http://codereview.chromium.org/10146016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133468 0039d316-1c4b-4281-b951-d872f2087c98

Remove DOMView.

BUG=none
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10171006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133467 0039d316-1c4b-4281-b951-d872f2087c98

Trivial change to add Ben to owners.

TEST= none
BUG= non
Review URL: https://chromiumcodereview.appspot.com/10139024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133466 0039d316-1c4b-4281-b951-d872f2087c98

BUG=NONE
TEST=NONE
Review URL: https://chromiumcodereview.appspot.com/10166001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133465 0039d316-1c4b-4281-b951-d872f2087c98

I came across this style violation while hacking at http://codereview.chromium.org/9875026/ , this CL fixes it.

BUG=None


Review URL: http://codereview.chromium.org/10155010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133463 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
R=binji
TBR=erg

Review URL: https://chromiumcodereview.appspot.com/10166016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133462 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/10178005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133461 0039d316-1c4b-4281-b951-d872f2087c98

BUG=116553
TEST=Manual

Review URL: http://codereview.chromium.org/10107019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133459 0039d316-1c4b-4281-b951-d872f2087c98

Convert session history ui test to a browser test, renabling all the disabled tests and got rid of flaky patterns. Hopefully they don't fail again.

BUG=121574
Review URL: https://chromiumcodereview.appspot.com/10144015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133458 0039d316-1c4b-4281-b951-d872f2087c98

Make the code more testable by separating argument parsing from main().

R=nsylvain@chromium.org
BUG=98834
TEST=


Review URL: http://codereview.chromium.org/10080013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133457 0039d316-1c4b-4281-b951-d872f2087c98

Change resource handling policy to allow feed types to download so they can be handled by web intents.

BUG=105732
TEST=None


Review URL: http://codereview.chromium.org/10079012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133456 0039d316-1c4b-4281-b951-d872f2087c98

R=sky@chromium.org
BUG=
TEST=


Review URL: http://codereview.chromium.org/10146028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133455 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133454 0039d316-1c4b-4281-b951-d872f2087c98

TBR=dimich@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10191004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133453 0039d316-1c4b-4281-b951-d872f2087c98

BUG=121574
Review URL: https://chromiumcodereview.appspot.com/10161016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133452 0039d316-1c4b-4281-b951-d872f2087c98

Building asan_stub.c with -faddress-sanitizer causes Clang to crash,
see http://code.google.com/p/address-sanitizer/issues/detail?id=67

BUG=address-sanitizer:67
Review URL: https://chromiumcodereview.appspot.com/10134009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133451 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133450 0039d316-1c4b-4281-b951-d872f2087c98

R=jkummerow@chromium.org


Review URL: http://codereview.chromium.org/10185002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133449 0039d316-1c4b-4281-b951-d872f2087c98

Remove the media/encrypted-media/ entry.

TBR=dimich@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10183003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133446 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133444 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:29459
TEST=Changing volume preserves current directory on each volume. Clicking on the current volume changes directory to this volumes root.
Review URL: https://chromiumcodereview.appspot.com/10146008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133443 0039d316-1c4b-4281-b951-d872f2087c98

TBR=dimich@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10186003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133442 0039d316-1c4b-4281-b951-d872f2087c98

R=sadrul@chromium.org
BUG=
TEST=

Review URL: https://chromiumcodereview.appspot.com/10166022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133441 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none


Review URL: http://codereview.chromium.org/10163011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133440 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none


Review URL: http://codereview.chromium.org/10119030

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133439 0039d316-1c4b-4281-b951-d872f2087c98