- 13 Apr, 2018 40 commits
-
-
Emily Hanley authored
Bug: 758632 Change-Id: I12b77b94313845e2b38d03313915a23663363a5e Reviewed-on: https://chromium-review.googlesource.com/1011574Reviewed-by:
Ashley Enstad <ashleymarie@chromium.org> Commit-Queue: Emily Hanley <eyaich@chromium.org> Cr-Commit-Position: refs/heads/master@{#550654}
-
Xing Liu authored
Currently media gallery api reads media data from a blob in browser process with extension's blob reader. This CL abstracts a factory class to create MediaDataSource, so that Android can implement a different source that read data from local file. Eventually, media gallery api will not depend on extension, which is not supported on Android, and can have different data source. Bug: 826021,826975 Change-Id: I6d9d6c0ffc8cbae42cd036af34fb4944cf25e685 Reviewed-on: https://chromium-review.googlesource.com/997012 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#550653}
-
Ted Choc authored
BUG=824954 Change-Id: I473641d51907cdab567df7110b6c4415876c03f8 Reviewed-on: https://chromium-review.googlesource.com/1011583Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#550652}
-
Hiroki Nakagawa authored
This is a follow-up CL for https://chromium-review.googlesource.com/c/chromium/src/+/994552/12/third_party/blink/renderer/platform/scheduler/public/frame_or_worker_global_scope_scheduler.h#13 Bug: 826203 Change-Id: Id43950524c7f74f797942bc43b7f51c5abe805be Reviewed-on: https://chromium-review.googlesource.com/1006837 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Hajime Hoshi <hajimehoshi@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Yuta Kitamura <yutak@chromium.org> Cr-Commit-Position: refs/heads/master@{#550651}
-
Mark Cogan authored
This CL fixes a bug where when zooming out from the tab grid, the selection state change wasn't animated. It also makes the slection state change animations longer. Bug: 804536 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ic3dba63a1c83bb967e66e110de299ce7cb898006 Reviewed-on: https://chromium-review.googlesource.com/1012073 Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#550650}
-
Ben Pastene authored
This reverts commit 7c3d1d13. Reason for revert: WebviewLoginTest.Basic is still flaky on linux-chromeos-rel https://ci.chromium.org/buildbot/chromium.chromiumos/linux-chromeos-rel/6886 https://ci.chromium.org/buildbot/chromium.chromiumos/linux-chromeos-rel/6887 Original change's description: > Reland: Use PostTask to schedule cross-process postMessage forwarding. > > Changes from original attempt at https://crrev.com/c/999182: > - fix flakiness in two additional ChromeOS login tests > - fix CSP WPT tests to not depend on ordering between iframe's onload > and postMessage - see https://crbug.com/832319. > > Previously, we sent the IPC to forward a cross-process postMessage > immediately. This caused a behavioral difference from the > same-process case where the postMessage is always scheduled. Namely, > in a scenario like this: > > frame.postMessage(...); > doSomethingThatSendsIPCsToFrame(frame); > > the IPCs from JS following the postMessage would've been ordered > incorrectly, causing |frame| to see their side effects after the > postMessage dispatch in the cross-process case, whereas they would be > seen before the postMessage dispatch in the same-process case. One > example of this is frame.focus(), and another is a frame element > onload event (dispatched via FrameHostMsg_DispatchLoad) arriving after > a postMessage dispatched from an inline script while the frame was > still loading. > > To resolve these ordering concerns, this CL changes cross-process > postMessage to do a PostTask on the sender side before sending the > message to the browser process. This improves the current state of > the world, but does not yet achieve a perfect match for the IPC > ordering in the same-process case - see discussion on the bug. > > Bug: 828529 > Change-Id: I62a627c501526d09900be4f5bd2c899acf4d1e07 > Reviewed-on: https://chromium-review.googlesource.com/999182 > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Commit-Queue: Alex Moshchuk <alexmos@chromium.org> > Cr-Original-Commit-Position: refs/heads/master@{#550284} > Reviewed-on: https://chromium-review.googlesource.com/1011287 > Cr-Commit-Position: refs/heads/master@{#550621} TBR=xiyuan@chromium.org,dcheng@chromium.org,alexmos@chromium.org Change-Id: Ic0637a6038bed6e5334a26e1934bee81faad3b9e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 828529 Reviewed-on: https://chromium-review.googlesource.com/1012138Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#550649}
-
Lei Zhang authored
Now with only 2 callers to PrintJob::UpdatePrintedDocument(), it is easy to see the "settings_ = " assignment inside it is just a case of: doc_settings = settings_; settings_ = doc_settings; Change-Id: I5a82ab9c0b3631585e3a65a1e74f16bf9b1e4b6c Reviewed-on: https://chromium-review.googlesource.com/1000959 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#550648}
-
Quentin Fiard authored
Design doc: go/chrome-no-searchdomaincheck Bug: 825255 Change-Id: I6be6ca5928a52901fba2fbd24405a1b11fd9d54a Reviewed-on: https://chromium-review.googlesource.com/1002842 Commit-Queue: Quentin Fiard <qfiard@google.com> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#550647}
-
Xiyuan Xia authored
Move MojoChannel code out of ArcBridgeHostImpl into its own file to be shared. Bug: 768439 Change-Id: I730ae1f498893455f3aa2e768f47893409109768 Reviewed-on: https://chromium-review.googlesource.com/1012136Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#550646}
-
Emily Hanley authored
NOTRY=true Bug: 779634 Change-Id: If5bd29aa5715477be41120278d003ebe6dcdeb78 Reviewed-on: https://chromium-review.googlesource.com/1012127 Commit-Queue: Emily Hanley <eyaich@chromium.org> Reviewed-by:
Ashley Enstad <ashleymarie@chromium.org> Cr-Commit-Position: refs/heads/master@{#550645}
-
John Rummell authored
AudioDecoderConfig was changed to a type map a while back. EncryptionPattern has no implementation anyway. BUG=611224 TEST=media_mojo_unittests passes Change-Id: I20a83d4ca20819447c563fd19207914fe04f0381 Reviewed-on: https://chromium-review.googlesource.com/1011360Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: John Rummell <jrummell@chromium.org> Cr-Commit-Position: refs/heads/master@{#550644}
-
Michał Pichliński authored
Bug: 832591 Change-Id: I8d104a7e0ede58f20d71bb5ce00f8b398cf8e28b Reviewed-on: https://chromium-review.googlesource.com/1012023Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Michal Pichlinski <mpichlinski@opera.com> Cr-Commit-Position: refs/heads/master@{#550643}
-
Tim Schumann authored
BUG=832019 Change-Id: I593499bea1ccaad680d96d572f119b19c8fdc6aa Reviewed-on: https://chromium-review.googlesource.com/1010344 Commit-Queue: Tim Schumann <tschumann@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#550642}
-
Stephen McGruer authored
There were three minor bugs left in the implementation: - We threw on lists-in-custom-iterators instead of just ignoring them. - We returned all properties on the keyframe rather than just those defined on the keyframe itself (e.g. we would include prototype properties, against spec). - We didn't access the properties in ascending unicode order. Bug: 827573 Change-Id: I213ae5b24e1f35d7f28d16625025122950a6ba88 Reviewed-on: https://chromium-review.googlesource.com/989261Reviewed-by:Kentaro Hara <haraken@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#550641}
-
Xiaohan Wang authored
Also refator CdmService so that we can override service release delay for testing. Bug: 826039 Change-Id: I595a26c019ee760c49a2bac638c4f928101f6423 Reviewed-on: https://chromium-review.googlesource.com/1011404Reviewed-by:
John Rummell <jrummell@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#550640}
-
Daniel Nicoara authored
dma-buf memory mapping is supported upstream, so there is no longer any need to check for this on non-ChromeOS platforms. Bug: b/72096671 Test: Ran on non-ChromeOS device and ensured DCHECK isn't hit. Change-Id: Id0a1d35207c40167dfa765c89d4e75db79f171f6 Reviewed-on: https://chromium-review.googlesource.com/1012142Reviewed-by:
Alex Sakhartchouk <alexst@chromium.org> Commit-Queue: Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#550639}
-
Brandon Jones authored
Change-Id: I32144548e5427a1e50491259dadf729a743a54df Bug: 831610 Reviewed-on: https://chromium-review.googlesource.com/1000134Reviewed-by:
agrieve <agrieve@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Brandon Jones <bajones@chromium.org> Cr-Commit-Position: refs/heads/master@{#550638}
-
Lei Zhang authored
Replace UpdatePrintedDocument(nullptr) with ClearPrintedDocument(). The two methods are simpler to understand than the existing combined method. Also get rid of all "new" uses in PrintJob. Change-Id: I55a51233b0cc9f30c45301703e57b311738f3891 Reviewed-on: https://chromium-review.googlesource.com/1000956Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#550637}
-
Dave Tapuska authored
arraysize is already exposed via including base/macros.h in the std_lib_extras.h header file. So it makes no sense to reimplement WTF_ARRAY_LENGTH. Replaced via git grep -l WTF_ARRAY_LENGTH | xargs -x sed -i "s/WTF_ARRAY_LENGTH/arraysize/g BUG=None Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I1aa659bb689605d878c09f83ca0d4857baebe683 Reviewed-on: https://chromium-review.googlesource.com/1012125Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#550636}
-
Bailey Berro authored
- Creates a helper class that manages the creation and parsing of a compound file_system_id. - Switches to these functions. Bug: chromium:757625 Change-Id: I611cfdf213da104f1dc63ce7ba442298bd362f41 Reviewed-on: https://chromium-review.googlesource.com/990580 Commit-Queue: Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#550635}
-
Tom Anderson authored
* Adds --tokenize-by-character * This is useful for eg. the blink refactor where fooBar got changed to foo_bar. * Adds --tokenize-whitespace * Adds --skip-visualization * Added this because it was useful for testing. * Ran yapf * Small refactor. BUG=773350 R=dpranke Change-Id: I7596f670ce640ed6bd367dee995628edc13dd6f2 Reviewed-on: https://chromium-review.googlesource.com/1010798Reviewed-by:Dirk Pranke <dpranke@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#550634}
-
Kevin Bailey authored
Turning down obsolete experiment, so cleaning up references. No code changes (and OmniboxRichEntitySuggestions remains.) Change-Id: I67282f51d4a5c6763551d7b050c156e4ceb143b8 Reviewed-on: https://chromium-review.googlesource.com/1010263 Commit-Queue: Kevin Bailey <krb@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#550633}
-
Devlin Cronin authored
Manifest v1 extensions have been deprecated for a long time. Stop loading these extensions unless a special (existing) commandline flag is present. There are a few straggling tests (which rely on packaged extension resources, like .crx files) that still need to be updated; use the commandline flag (or a runtime variant) in those tests. These will be cleaned up in follow-up CLs. Reland note: This was reverted because of a conflict with https://crrev.com/fef93a84a5b56945d02cada97f4ec886ae34c0e2. This has been fixed. TBRing original reviewers: TBR=lazyboy@chromium.org TBR=pastarmovj@chromium.org TBR=qinmin@chromium.org TBR=stevenjb@chromium.org Bug: 831909 Change-Id: I9141db4a15452c9cd601b279f7880e10a08c0a8c Reviewed-on: https://chromium-review.googlesource.com/1011572Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#550632}
-
Ella Ge authored
Remove flaky expectation for layout test virtual/mouseevent_fractional/fast/events/mouse-event-buttons-attribute.html Can't reproduce the failure locally in both Win, Mac and Linux. Bug: 825046 Change-Id: I529606bed85ddc59e09e9937c0b784af51ffdc5a Reviewed-on: https://chromium-review.googlesource.com/992891Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#550631}
-
kylechar authored
This CL implements logic from GLES2CommandBufferStub::Initialize() in InProcessCommandBuffer::InitializeOnGpuThread(). Some differences are not addressed and I've left TODOs instead. Bug: 832243, 811979 Change-Id: I1139a33f594280ea4c17b3a7223391e33bc15ad6 Reviewed-on: https://chromium-review.googlesource.com/1006038Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#550630}
-
Rouslan Solomakhin authored
Before this patch, any iframe could install a Payment Handler by calling `paymentManager.instruments.set()`. This patch checks for the feature policy "payment" before allowing any operations on `paymentManager.instruments`. After this patch, a cross-origin iframe will reject all operations on `paymentManager.instruments` by default. The parent context can explicitly allow the iframe to use the Payment Handler API through feature policy. This can be accomplished via the iframe attribute `allow="payment"`, for example. Note that the same feature policy controls access to Payment Request API as well. Discussion: https://github.com/w3c/payment-handler/issues/281 Spec change: https://github.com/w3c/payment-handler/pull/282 Payment Handlers are behind a flag: chrome://flags/#service-worker-payment-apps Manual test: https://rsolomakhin.github.io/pr/apps/iframe/ Bug: 828948 Change-Id: I0259555692fa0b215d3700c233b3687724e665cb Reviewed-on: https://chromium-review.googlesource.com/1005275 Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#550629}
-
Gauthier Ambard authored
This CL fixes the test suite, fixing the test that should pass and disabling the one for the features not yet implemented. Bug: 832638 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I2138a74a73b18c40ebdee6b22432541d7bc27a91 Reviewed-on: https://chromium-review.googlesource.com/1012104 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#550628}
-
Ian Vollick authored
The issues now seem to be resolved. Bug: 832650 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr Change-Id: Id43bc440805fb4ed74d430ed7384eed78bce289f Reviewed-on: https://chromium-review.googlesource.com/1011678Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#550627}
-
rbpotter authored
Bug: 812097 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ic15ae3735c82875759bf67be8e64bd5beeb7ecb0 Reviewed-on: https://chromium-review.googlesource.com/996301 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#550626}
-
Tatiana Gornak authored
This CL implements the wrapper for the POST request to the FCM server. BUG=801985 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ibba578f7181920e24b39c633111d47b717eb7bb1 Reviewed-on: https://chromium-review.googlesource.com/911108 Commit-Queue: Tatiana Gornak <melandory@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Pavel Yatsuk <pavely@chromium.org> Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#550625}
-
Tommy C. Li authored
This CL tests that double-click triggers unelision of steady state elided URLs with the proper portion selected afterwards. This unelision occurs on the second mousedown. It also tests that triple-click triggers unelision and ends with everything selected. Bug: 797354 Change-Id: I3174242ad5f188ef0808a859a376bc0393a76faf Reviewed-on: https://chromium-review.googlesource.com/1008866 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#550624}
-
Xida Chen authored
Right now touch_action_browsertest.cc has two tests only, one for auto which is the default, and one for none. This CL adds more test cases with janky main thread. There is a special test case where touch ack timeout is triggered, which should allow all gesture event. Bug: 772130 Change-Id: Ifabcb8356cb2526ad55313be01e24ea959ab2330 Reviewed-on: https://chromium-review.googlesource.com/1007864Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#550623}
-
Devlin Cronin authored
Add an origin access blacklist that takes priority over the origin access whitelist. If both the blacklist and the whitelist match an origin, access is not granted. This will allow us to specify a wildcard whitelist while maintaining a list of exceptions which will be off-limits. Add unittests for the same. Bug: 826946 Change-Id: I651cc1e35d05bf20b8ea6e07f34b4b034c297844 Reviewed-on: https://chromium-review.googlesource.com/1011241Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#550622}
-
Alex Moshchuk authored
Changes from original attempt at https://crrev.com/c/999182: - fix flakiness in two additional ChromeOS login tests - fix CSP WPT tests to not depend on ordering between iframe's onload and postMessage - see https://crbug.com/832319. Previously, we sent the IPC to forward a cross-process postMessage immediately. This caused a behavioral difference from the same-process case where the postMessage is always scheduled. Namely, in a scenario like this: frame.postMessage(...); doSomethingThatSendsIPCsToFrame(frame); the IPCs from JS following the postMessage would've been ordered incorrectly, causing |frame| to see their side effects after the postMessage dispatch in the cross-process case, whereas they would be seen before the postMessage dispatch in the same-process case. One example of this is frame.focus(), and another is a frame element onload event (dispatched via FrameHostMsg_DispatchLoad) arriving after a postMessage dispatched from an inline script while the frame was still loading. To resolve these ordering concerns, this CL changes cross-process postMessage to do a PostTask on the sender side before sending the message to the browser process. This improves the current state of the world, but does not yet achieve a perfect match for the IPC ordering in the same-process case - see discussion on the bug. Bug: 828529 Change-Id: I62a627c501526d09900be4f5bd2c899acf4d1e07 Reviewed-on: https://chromium-review.googlesource.com/999182Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#550284} Reviewed-on: https://chromium-review.googlesource.com/1011287 Cr-Commit-Position: refs/heads/master@{#550621}
-
rbpotter authored
Make the close buttons appear again in the Print Preview cr-dialogs. Bug: 827579 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I64999ea9e56ba34509040294dc7178c47facadd3 Reviewed-on: https://chromium-review.googlesource.com/1007626Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#550620}
-
Emily Hanley authored
Bug: 832081 Change-Id: I9e14993b3a771657cc4d7dfc43ba518f4d345ebb Reviewed-on: https://chromium-review.googlesource.com/1010723 Commit-Queue: Emily Hanley <eyaich@chromium.org> Reviewed-by:
Ashley Enstad <ashleymarie@chromium.org> Cr-Commit-Position: refs/heads/master@{#550619}
-
Gauthier Ambard authored
When reporting an issue, the ReportAnIssue module is taking a screenshot of the page. The popup menu needs to be hidden before taking this snapshot. This CL hides the popup menu before taking the snapshot. Bug: 831136 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I7e908b04359453cf1f3d790c712435b3d27fa6d2 Reviewed-on: https://chromium-review.googlesource.com/1009745 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#550618}
-
Aga Wronska authored
Make frequency of status reports upload a parameter of the StatusUploader to allow easy customization. Bug: 826894 Change-Id: Id37890fb5e65d83bb9877decdc23a5e1b9d09de2 Reviewed-on: https://chromium-review.googlesource.com/1000415Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Bartosz Fabianowski <bartfab@chromium.org> Commit-Queue: Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#550617}
-
Joe Medley authored
Change-Id: I4cacf95b98f3f4dbe17c49f4ae566849cbafc4b1 Reviewed-on: https://chromium-review.googlesource.com/1002658Reviewed-by:
Ian Clelland <iclelland@chromium.org> Commit-Queue: Ian Clelland <iclelland@chromium.org> Cr-Commit-Position: refs/heads/master@{#550616}
-
Mihai Sardarescu authored
This CL records the following histograms: * Signin.SigninCompletedAccessPoint.WithDefault * Signin.SigninCompletedAccessPoint.NotDefault * Signin.SigninCompletedAccessPoint.NewAccount Bug: 832066 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I42ecf6be254dcf51133d565e90df56ae1f69ef93 Reviewed-on: https://chromium-review.googlesource.com/1010362 Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#550615}
-