- 26 Aug, 2020 40 commits
-
-
Avi Drissman authored
The OOM death tests used an allocation value of MAX_LONG minus 12k. The problem with that value is that, on systems like the Mac DTKs that have 16k VM pages, that gets rounded up and wraps. Therefore, abstract it into “subtract three pages”. Bug: 1121749 Change-Id: I6c519200cbd848c095b741d78f51317ea6ef18b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376887 Commit-Queue: Avi Drissman <avi@chromium.org> Commit-Queue: Mark Mentovai <mark@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Auto-Submit: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#801831}
-
Matt Menke authored
The NetLogViewer automatically resolves "net_error" fields to net::Error errors, but does do that for "error". I believe this will require a followup CL to update where the NetLogViewer's DNS tab gets network error string from. Fixed: 1122054 Change-Id: Ifd74a988999d6142634f412e73929f568af536ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375602 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#801830}
-
Chong Gu authored
This will add ~20 minutes of bot time and ~2 minutes of run time per build. The bots required to run these tests have been approved in crbug.com/1100546 Bug: 1058255 Change-Id: I542bce2dae6b8d0c84d50d8b595044445c31f406 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377306 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Auto-Submit: Chong Gu <chonggu@google.com> Cr-Commit-Position: refs/heads/master@{#801829}
-
Linkun Chen authored
To hide internal folder names. Test: build locally with internal change Bug: b/165815398 Merge-With: eureka-internal/442206 Change-Id: Ibb17c47f37c796d2513ad1b6dfd52a282903bddf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2373289Reviewed-by:
Michael Spang <spang@chromium.org> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Commit-Queue: Linkun Chen <lkchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#801828}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/e23bb2ed..46f5bd5e Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I6120f4baa4d74393235fb1aecc5b8b2226361ad8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377427Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#801827}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/fb9ee39c41d4..f60cabfb25c4 2020-08-26 tvanderlippe@chromium.org Typecheck bindings/CSSWorkspaceBinding.js with TypeScript If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I50b1279828bdd88bc077c5cb79ec7eb92ff059e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378190Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#801826}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/7023f47299aa..0fdfdcf61cd4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ic987c90c981da679d5d0a34316dabfb3f45fcef9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378086Reviewed-by:
-
Peng Huang authored
Bug: 1034840,1122020 Change-Id: Ia2dceed245c16b66d35b513f614656a27acde076 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377231 Commit-Queue: Peng Huang <penghuang@chromium.org> Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#801824}
-
Brandon Wylie authored
This reverts commit c4aceb16. Reason for revert: ContactsPicker tests failing on android-bfcache-rel see crbug.com/1122069 Original change's description: > Move Contacts Picker to //components/browser_ui/contacts_picker > > Bug: 1016938 > Change-Id: Ib3a86b4a3e3c0356c292ce55291ef0487e94c5ae > Skip-Translation-Screenshots-Check: True > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2325272 > Commit-Queue: Evan Stade <estade@chromium.org> > Reviewed-by: Will Harris <wfh@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Lijin Shen <lazzzis@google.com> > Reviewed-by: Ted Choc <tedchoc@chromium.org> > Reviewed-by: Finnur Thorarinsson <finnur@chromium.org> > Cr-Commit-Position: refs/heads/master@{#801610} TBR=dcheng@chromium.org,finnur@chromium.org,estade@chromium.org,tedchoc@chromium.org,wfh@chromium.org,lazzzis@google.com Change-Id: Ie79da9732fafd575886793b15fc6b1bcf908d9cb No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1016938 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378268Reviewed-by:
Brandon Wylie <wylieb@chromium.org> Commit-Queue: Brandon Wylie <wylieb@chromium.org> Cr-Commit-Position: refs/heads/master@{#801823}
-
Amr Aboelkher authored
This reverts commit 3bc91ccc. Reason for revert: Failure of WebKit Linux ASAN build, and that's the suspect for root cause. See https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Linux%20ASAN/17329 Original change's description: > [Perfect Negotiation] Surface session descriptions at the right time. > > This fixes another timing related issue that blocks Perfect Negotiation. > > Before this CL, current/pending local/remote description attributes do > blocking-invokes on the webrtc thread, fetching the most up-to-date > states. This can prematurely expose the result of "in-parallel" > operations that have not surfaced yet, such as: > - setLocalDescription > - setRemoteDescription > - addIceCandidate > > This CL fixes that by copying the SDP states when any of these > operations complete on the WebRTC thread and carry them over in the > PostTask to the main thread. Here, we store these snapshots in > "internal slots" (variables living on the main thread). With this CL, > reading SDP attributes from RTCPeerConnection is non-blocking and > spec-compliant. > > WPT test coverage added for the exact timing of SLD/SRD and other test > expectations are updated. addIceCandidate updating the SDP is already > covered by old WPTs. > > Bug: chromium:1110347 > Change-Id: Id41ec354465525c6cedf631fe2209fe097148f60 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2323359 > Commit-Queue: Henrik Boström <hbos@chromium.org> > Reviewed-by: Harald Alvestrand <hta@chromium.org> > Cr-Commit-Position: refs/heads/master@{#801798} TBR=hta@chromium.org,hbos@chromium.org Change-Id: I4af12fd1430773ea3d134cfc37b9c5e736f20ed0 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:1110347 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377715Reviewed-by:
Amr Aboelkher <amraboelkher@google.com> Commit-Queue: Amr Aboelkher <amraboelkher@google.com> Cr-Commit-Position: refs/heads/master@{#801822}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/95c5b87ad1a3..ee3d26b3cdc2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC sahel@google.com,amraboelkher@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: sahel@google.com,amraboelkher@google.com Change-Id: I36b0ee36306f65fd58bc14f2e2b4645dd86dd5f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378165Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Reviewed-by:
-
Dave Tapuska authored
The code previously added an IME guard but it was removed when moving this into blink and the showing/hiding of the virtual keyboard was done on the HandlingInputState object itself. (via change https://chromium-review.googlesource.com/c/chromium/src/+/2212805). he IME guard prevents intermediate changes when handling an event. This was problematic for TinyIME because the text input mode changed between the processing of the event which caused the virtual keyboard to be dismissed. This change makes the code behave exactly the same before the move to blink. It can't be merged into M85 due to that branch only having part of the changes. So if it needs to go there it will need to be written separately. BUG=1121179 Change-Id: Ida425dedd240a3c2e36b458d45f04433c6d31963 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2373363 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Auto-Submit: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#801820}
-
Brian Sheedy authored
This reverts commit 8c97b259. Reason for revert: Suspected culprit of crbug.com/1121810 Original change's description: > WebGL: Add a direct uploading path for texImage2D with video frame backed by GPU > > Current fast path for webgl uploading video frame is to render YUV planars to a RGBA8 > intermediate gl texture and than do gpu to gpu copy to update the dst webgl texture. > > It is possible to further optimize this progress by drawing the content from YUV planars > to dst webgl texture directly. This will save the extra gpu-gpu texture copy which may > hurt performance when uploading large resolution video (e.g. 4k/8k video). > > BUG=1108154 > > Change-Id: I0abb269944f9eac9fb77e13b01860152a918ad95 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2319543 > Reviewed-by: Brian Salomon <bsalomon@google.com> > Reviewed-by: Dan Sanders <sandersd@chromium.org> > Reviewed-by: Kenneth Russell <kbr@chromium.org> > Commit-Queue: Shaobo Yan <shaobo.yan@intel.com> > Cr-Commit-Position: refs/heads/master@{#800811} TBR=bsalomon@google.com,kbr@chromium.org,jie.a.chen@intel.com,sandersd@chromium.org,shaobo.yan@intel.com,khushalsagar@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1108154, 1121810 Change-Id: I24a1ddd58e1c29c96bc65e566cf5eb34b26b5f4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376379Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#801819}
-
Roman Sorokin authored
This fixes the issue when both Enrollment screen and Login screen trying to load Gaia at the same time. SigninPartitionManager cancels one attempt to start another one. This might break the enrollment flow when Chrome can't extract oauth_code from the cookies partiton. It's a bit hard to test as it's a race condition. I will add something in a follow-up. Bug: 1119411 Change-Id: I81c7031ae05b2882f4e86feac63e1aee9058c13e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375426Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#801818}
-
Tommy Steimel authored
Bug: b:166321735 Change-Id: I53aa13485ac9f014c6ebc0ab8bf38f65204e0637 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375600Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#801817}
-
Tibor Goldschwendt authored
+ Shrink Kaleidoscope module according to spec. + Add closure compiler annotation to module descriptor. Change-Id: Id99185a8b1ee62d154cc663d2d525beaa91a29b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376460 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
-
Joanmarie Diggs authored
Text alignment and indentation are being exposed as object attributes to support IA2 and minimize work needed to calculate attributes which can only apply to an entire object. However, ATK treats alignment as a text attribute and platform ATs expect text-attribute-changed events (there is no object-attribute-changed event in ATK). Therefore, fire an AtkText text-attribute-changed event to notify ATs when either of these text properties change. It is up to platform ATs to check object attributes for these properties. Bug: 1108872 AX-Relnotes: Orca now includes alignment and indentation when its font- announcement command is used in Chrome/Chromium. It will be possible for Orca to add support for presentation of changes to these properties. Change-Id: I971777ba4a5f672bf129a4687ff2c54c250c41f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343267 Commit-Queue: Joanmarie Diggs <jdiggs@igalia.com> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#801815}
-
Noah Rose Ledesma authored
This change removes the need for communication between the audio device picker UI and the MediaNotificationService. This communication is now done via the UI's delegate class. Bug: 1121367 Change-Id: Ie541b1a3c65a8035fbbdb736bd9c4b9a3cbb89c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2373270 Commit-Queue: Noah Rose Ledesma <noahrose@google.com> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#801814}
-
Christian Larson authored
CaptureEngine is used for VideoOnly so no need to initialize both audio and video. This can cause permissions issues or extra delay during initialize. Note this will fix GUM behavior for video only but not change the GUM with audio behavior. Bug: 1120716 Change-Id: Iaa9147f3e18804d663bf0a4c1163aa9327ea4f71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376366 Commit-Queue: Christian Larson <chrila@microsoft.com> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#801813}
-
Chris Findeisen authored
Provides some helper functions for adding this build info standardized into other crash contexts. BUG=1116135 Change-Id: I597222868a16003ab9c8fa42de1979e10d771807 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354496 Commit-Queue: Chris Findeisen <cfindeisen@chromium.org> Reviewed-by:
Luke Halliwell (slow) <halliwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#801812}
-
Yuta Hijikata authored
As part of an effort to unify logs in Chrome OS, this adds option to enable syslog-compatible log format for chrome for chromeos. e.g. 2020-06-27T23:55:25.094701Z ERROR chrome[3816:3877]: [drm_device_handle.cc(90)] Succeeded authenticating /dev/dri/card0 in 0 ms with 1 attempt(s) For more detail http://go/cros-syslog-format-log-chrome. Related patches: crrev.com/c/2311981 Update tast test. BUG: 1093033 TEST: base_unittests Cq-Depend: chromium:2326511 Change-Id: I55053807d9291dce3b09d3d2e780501fa9383938 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260255 Commit-Queue: Yuta Hijikata <ythjkt@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#801811}
-
Alice Wang authored
This CL batches AccountPickerBottomSheetTest. Bug: 1120258 Change-Id: I0f6ae90b8863aa3dafed3d016086e2f19cca3aae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376816Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#801810}
-
Victor Costan authored
Bug: 488553 Change-Id: I8e138d56c3cf3216997c070ed1545256262ad8a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2371603 Auto-Submit: Victor Costan <pwnall@chromium.org> Commit-Queue: Eric Roman <eroman@chromium.org> Reviewed-by:
-
sauski authored
It is possible to access some forms of client storage while an opaque origin is currently the top frame origin. These serialise to the string 'null' and are of no use to access context auditing. This CL stops the service from recording accesses where the top frame origin is opaque. Bug: 1121932 Change-Id: I90d7c5a48a4f30deb71d5cec3c2ddf5d8d7f97d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377488Reviewed-by:
Martin Šrámek <msramek@chromium.org> Commit-Queue: Theodore Olsauskas-Warren <sauski@google.com> Cr-Commit-Position: refs/heads/master@{#801808}
-
Clemens Arbesser authored
Bug: b/166429363 Change-Id: Ib20ad349a2f1e5efe5e1d6171ddee9563c7cb125 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377491Reviewed-by:
Luca Hunkeler <hluca@google.com> Commit-Queue: Luca Hunkeler <hluca@google.com> Auto-Submit: Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#801807}
-
Eleonora Rocchi authored
This CL adds the logic to close the view dialog of a compromised credential if the reauth time expired. It also adds a test to verify the dialog is correctly dismissed. Bug: 1119796, 1092444 Change-Id: Icbab80bcb312a2d9ac81edacab1f6eb56e3eda23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377810Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Commit-Queue: Eleonora Rocchi <erocchi@google.com> Cr-Commit-Position: refs/heads/master@{#801806}
-
Nnamdi Theodore Johnson-Kanu authored
Bug: 1111477 Change-Id: Icaaaed1d8373c6071992b2936ff34d7c485e5c70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376311 Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#801805}
-
Josh Nohle authored
- The |parent| field was removed from ListContactPeople because contacts are associated with an account and not a device. - The GetDeviceState request/response protos were added to support the newly added RPC that checks if the user's contacts have changed since the device last uploaded contacts. Bug: b/154861518 Change-Id: Ie573d84dfbb02b755c26fcc1e603c0a1dcb4b15e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2370923Reviewed-by:
James Vecore <vecore@google.com> Commit-Queue: Josh Nohle <nohle@chromium.org> Cr-Commit-Position: refs/heads/master@{#801804}
-
Daniele Castagna authored
The internal display resolution metric said it was for external displays. This patch fixes that. Change-Id: I29edade8da6e8036115b0c94ad13f53a62db1db0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376371 Auto-Submit: Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Andres Calderon Jaramillo <andrescj@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#801803}
-
Sean McAllister authored
Currently, ChromeOS defines the OS_LINUX directive as well as OS_CHROMEOS. We're working to separate these two, so we're making the fact that OS_LINUX == OS_LINUX || OS_CHROMEOS explicit. This is changes for /cc This CL was uploaded by git cl split. R=majidvp@chromium.org Bug: 1110266 Change-Id: Icbd028234d6de8b2ef5b2e4dd52b8107006eea86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2371213Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: Sean McAllister <smcallis@google.com> Cr-Commit-Position: refs/heads/master@{#801802}
-
Javier Ernesto Flores Robles authored
Fixed: 1120312 Change-Id: I3997debd3c2a4c3661d1d2330371d8c1e477c8c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377873 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#801801}
-
Sean McAllister authored
Currently, ChromeOS defines the OS_LINUX directive as well as OS_CHROMEOS. We're working to separate these two, so we're making the fact that OS_LINUX == OS_LINUX || OS_CHROMEOS explicit. This is changes for /components/url_formatter This CL was uploaded by git cl split. R=tommycli@chromium.org Bug: 1110266 Change-Id: Id2bb35b50dbebad47317ec0a32fc0efc1aa6f4b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2370294Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Sean McAllister <smcallis@google.com> Cr-Commit-Position: refs/heads/master@{#801800}
-
Sean McAllister authored
Currently, ChromeOS defines the OS_LINUX directive as well as OS_CHROMEOS. We're working to separate these two, so we're making the fact that OS_LINUX == OS_LINUX || OS_CHROMEOS explicit. This is changes for /content/browser/webui This CL was uploaded by git cl split. R=tommycli@chromium.org Bug: 1110266 Change-Id: I4f72f279d97cf9bf4a681d87eab5429a34274e19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2371292Reviewed-by:
-
Henrik Boström authored
This fixes another timing related issue that blocks Perfect Negotiation. Before this CL, current/pending local/remote description attributes do blocking-invokes on the webrtc thread, fetching the most up-to-date states. This can prematurely expose the result of "in-parallel" operations that have not surfaced yet, such as: - setLocalDescription - setRemoteDescription - addIceCandidate This CL fixes that by copying the SDP states when any of these operations complete on the WebRTC thread and carry them over in the PostTask to the main thread. Here, we store these snapshots in "internal slots" (variables living on the main thread). With this CL, reading SDP attributes from RTCPeerConnection is non-blocking and spec-compliant. WPT test coverage added for the exact timing of SLD/SRD and other test expectations are updated. addIceCandidate updating the SDP is already covered by old WPTs. Bug: chromium:1110347 Change-Id: Id41ec354465525c6cedf631fe2209fe097148f60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2323359 Commit-Queue: Henrik Boström <hbos@chromium.org> Reviewed-by:
Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#801798}
-
Charlie Hu authored
According to the rename of image policies, the old default error messages turn out to be awkward. This CL gives more specific error messages to image policies. Bug: 1113375 Change-Id: Ie9d511bf1b4f71dd2d9626dd7a2fb49e12566be0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359151Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Reviewed-by:
Ian Clelland <iclelland@chromium.org> Commit-Queue: Charlie Hu <chenleihu@google.com> Cr-Commit-Position: refs/heads/master@{#801797}
-
Russ Hamilton authored
Small change to measurement of sampled surfaces so that this type can be explicitly disabled as part of the Identifiabilty study settings. Bug: 1112787 Change-Id: I54fddb93276f152fe11dcd39326ad85bb142e1b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375698Reviewed-by:
Asanka Herath <asanka@chromium.org> Commit-Queue: Russ Hamilton <behamilton@google.com> Cr-Commit-Position: refs/heads/master@{#801796}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/7023f47299aa..0fdfdcf61cd4 2020-08-26 lalitm@google.com tp: fix python test runner not returning errors on failure If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I9088250a5c077579c1985b81540eb432cad74a03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377359Reviewed-by:
-
David Tseng authored
This change enables AccessibilityEventRewriter to only process key events from specific types of keyboard input devices. The new public method can be used by clients such as Switch Access to only consider key events from usb or bluetooth switches which show up as keyboard devices. Bug: none Test: ash_unittests --gtest_filter=Switch*.SetKeyboardInputTypes. Requires manual verification with switch devices. Change-Id: I7496b95cb380b9ddf301d7fa7bebb9748bdf40e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376035 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Anastasia Helfinstein <anastasi@google.com> Cr-Commit-Position: refs/heads/master@{#801794}
-
Etienne Pierre-doray authored
It's necessary to temporarily implement both old and new versions of GetMaxConcurrency() until v8-platform makes the old version optional. Bug: 1114823 Change-Id: I284f97a36ffb8718c3b42c05a949cfc29f4f1678 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375505Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#801793}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/b77998026e82..fb9ee39c41d4 2020-08-26 tvanderlippe@chromium.org Typecheck bindings/ContentProviderBasedProject.js with TypeScript 2020-08-26 szuend@chromium.org [ts] Type-check ui/SoftDropDown.js with TypeScript 2020-08-26 tvanderlippe@chromium.org Typecheck bindings/BreakpointManager.js with TypeScript 2020-08-26 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2020-08-26 petermueller@chromium.org Add feedback icon If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ide41a83747fcc7b8ff48986d5de5909f190a0a58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377357Reviewed-by:
-
