- 16 Oct, 2020 40 commits
-
-
Evan Stade authored
Bug: 1138534 Change-Id: Iadcc84d914d8071c8c0a49226b456dd0c01c8c73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2480805Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#818014}
-
Nate Chapin authored
* History is an ExecutionContextClient, so it is primarily associated with a LocalDOMWindow/ExecutionContext. Get state off of LocalDOMWindow instead of LocalFrame or Document where possible, and stop using the ExecutionContextClient::GetFrame() helper. * Add a GetHistoryItem() helper to make it cleaner to walk to the DocumentLoader to get to the HistoryItem. * Remove a bunch of unnecessary null-checks. Change-Id: I8f283586b3ecb164820481184c0fc3f84f8d5d26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2477903 Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Nate Chapin <japhet@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#818013}
-
Kenneth Russell authored
Now that the underlying bug has been fixed by crrev.com/817708, assume that these tests run reliably on Android again. Bug: 1095679 Tbr: backer@chromium.org Tbr: khushalsagar@chromium.org Change-Id: If5e6de3303027ccf9b7a8b1e49f503cbbab446d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2478025Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#818012}
-
Hans Wennborg authored
It's already exported from content.dll. Trying to link it in twice causes duplicate definition error when building with the latest Clang. Bug: 1138934 Change-Id: I7440362ab7b8c3fe4debe0e3aba623c48e94a92d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2480822 Commit-Queue: Hans Wennborg <hans@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Auto-Submit: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#818011}
-
Austin Eng authored
This bot's Vulkan driver is unreliable. See crbug.com/941685, crbug.com/915430 Bug: 1139366 Change-Id: I5cfab5c09efc7494c7c144a6f6dcb3d3d775aa0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2480584 Commit-Queue: Austin Eng <enga@chromium.org> Reviewed-by:
Austin Eng <enga@chromium.org> Reviewed-by:
Kramer Ge <fangzhoug@chromium.org> Cr-Commit-Position: refs/heads/master@{#818010}
-
Peter Kasting authored
Also changes the tests to actually click the buttons instead of just running the button click handlers. Bug: 772945 Change-Id: I34bd91b821398eeeb14d540411c1ae1cec86421b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476720 Auto-Submit: Peter Kasting <pkasting@chromium.org> Commit-Queue: Megan Jablonski <megjablon@chromium.org> Reviewed-by:
Megan Jablonski <megjablon@chromium.org> Cr-Commit-Position: refs/heads/master@{#818009}
-
Daniel Rubery authored
The script to push a new policy has moved to components, but we didn't update the documentation. Change-Id: I34bc6259c88db541056b098b587d7cfab9e0e8ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469460 Auto-Submit: Daniel Rubery <drubery@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#818008}
-
Mike Dougherty authored
Previously, only breadcrumbs associated with BrowserStates were being persisted across sessions. These events were stored inside the BrowserState storage directory. This CL moves the persisted events to files outside of the BrowserState directories. Additionally, it listens for breadcrumbs from all BreadcrumbManager instances. This allows all breadcrumbs to persist across application cold starts. Bug:1117667 Change-Id: Ief43577df397055b854f0beff3d55c92a3ed4289 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438579 Auto-Submit: Mike Dougherty <michaeldo@chromium.org> Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#818007}
-
Edward Lesmes authored
Generate DIR_METADATA files and remove metadata from OWNERS files for //services. R=jam@chromium.org Bug: 1113033 Change-Id: Iecbb630beab2b961a7bc4292a3f5185325a1a132 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473338 Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org> Cr-Commit-Position: refs/heads/master@{#818006}
-
Zentaro Kavanagh authored
- Uses a temporary function to map an enum to it's name - Test names will be localized in future CL Bug: 1125150 Test: browser_tests --gtest_filter=DiagnosticsApp* Change-Id: I0e2159fdb6b1115559af073b49818b45cab072e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462234 Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org> Auto-Submit: Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#818005}
-
Xiaoqian Dai authored
This CL implement the capture label widget bounds change and opacity fade in animation before 3-seconds countdown starts. - If there is a label or label button showing when starting countdown, (as in the case of fullscreen record or region record or window record in tablet mode), we'll do bounds change animation. - If there is no label when starting countdown (as in the case of window record in clamshell mode), we'll do bounds shrink down + opacity fade in animation. Not covered in this CL: - 3 seconds countdown animation. Will do it in a following CL. Bug: 1126669 Change-Id: Iabb836aa79de9018d0259ae1a744a8bfd3bf3925 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476614Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#818004}
-
chromium-autoroll authored
Roll ChromeOS Orderfiles from 87-4277.0-1602498224-benchmark-87.0.4280.21-r1 to 88-4277.0-1602497703-benchmark-88.0.4288.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-orderfile-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I3f5a4b7649466cfe2790ed1c56a54721f1b584e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2480929Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#818003}
-
Elly Fong-Jones authored
This change begins adding test coverage (still quite incomplete) for //ui/views/color_chooser. Bug: None Change-Id: I7ef91fe5b276e90f7e3bd13fcb153b66f90d72c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406390 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#818002}
-
Jeffrey Kardatzke authored
The PlatformVerification mojo object can become invalid during the lifetime of the CdmFactory, so reset it on error and reconnect it. BUG=b:153111783 TEST=ChromeOsCdmFactory works across page refreshes Change-Id: If54667256bcabf8aa2624d6a89c32e4a46f4bcb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476727 Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Auto-Submit: Jeffrey Kardatzke <jkardatzke@google.com> Cr-Commit-Position: refs/heads/master@{#818001}
-
Mark Schillaci authored
This CL updates our approach to the state description member variable of AccessibilityNodeInfo objects on Android. Until now we have picked a single state description based on the node. With this change we now concatenate all potential state descriptions to make sure no information is lost on mixed nodes (e.g. multiselectable listBox). We added a few exceptions to concatenation, namely the case of a multiselectable listbox will not announce the number of items in the list when some are selected. This is to prevent an utterance like: "multiselectable, 2 of 4 selected. 4 items" Instead in the case of a multiselectable listbox, it will be read as either: "multiselectable, none selected. 4 items" or "multiselectable, 2 of 4 selected." Similarly, we make toggle buttons and partially checked checkboxes mutually exclusive to prevent double speak. As of now all other cases are simply concatenated. AX-Relnotes: N/A Change-Id: I5650230b141cae24dfd935be596fb14720b723ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476520Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Mark Schillaci <mschillaci@google.com> Commit-Queue: Mark Schillaci <mschillaci@google.com> Cr-Commit-Position: refs/heads/master@{#818000}
-
Andrew Grieve authored
But hardcode it to false for public tryjobs. This is a quick-fix to avoid sharing links where authenticate=1 is dropped. Note: There is no harm in authenticating unnecessarily (except for users needing to go though the steps of signing in). Bug: 1131568 Change-Id: I96dbd4133df7ca3315c72d88ffb5ad515c401ab2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2477038Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#817999}
-
Greg Thompson authored
BUG=None Change-Id: I61815af5d9779b8379001421c46b8fe1f14d396b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461324 Commit-Queue: Greg Thompson <grt@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#817998}
-
dpapad authored
Bug: 1132403 Change-Id: I690822d909ed5c86bcb1b9c6652bfc9dd61cf3e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2479142 Commit-Queue: John Lee <johntlee@chromium.org> Auto-Submit: dpapad <dpapad@chromium.org> Reviewed-by:
John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#817997}
-
Yuke Liao authored
The goal is to speed-up the compilation and linkinng on linux-lacros-rel to as to offset the extra overhead of enabling 'also_build_ash_chrome' gn arg. Bug: 1129223 Change-Id: I7313fc22cc0115a33c8b4c0325655dae26a1c249 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2477611Reviewed-by:
Erik Staab <estaab@chromium.org> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#817996}
-
Rebekah Potter authored
This reverts commit 593dfd4d. Reason for revert: Collided with history generate grd CL, CQ did not re-run. Original change's description: > WebUI: Add support for resource_path_rewrites to generate_grd > > Support more general resource path rewrites by adding the option to > pass such rewrites from the caller in the form: > "original_file_path|resource_path_for_grd" > Leverage this to rename rollup files, and remove the special-case logic > that was used for this purpose originally. > > Bug: 1132403 > Change-Id: Icffa7d85497ab000044fed1ebcd9542cb5b869bc > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476623 > Reviewed-by: dpapad <dpapad@chromium.org> > Commit-Queue: Rebekah Potter <rbpotter@chromium.org> > Cr-Commit-Position: refs/heads/master@{#817961} TBR=dpapad@chromium.org,rbpotter@chromium.org Change-Id: Iabdc7d8cc3cb45704330e3ba9b79e3ac585446d5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1132403 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481063Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#817995}
-
Omar Morsi authored
Before this CL, ScopedTestSystemNSSKeySlotMixin used ScopedTestNSSDB which used a temp. directory to save the database data. This temp. directory will be deleted after browser pre-tests (tests that start with PRE_). This CL changes ScopedTestSystemNSSKeySlotMixin such that it opens a software slot in the user data directory which is not deleted after browser pre-tests so to allow tests using system slot to simulate browser restarts. Bug: 1136437, 1127284, 1113115 Change-Id: Ie61a6a7f594b996236b709e2db765a240e7b8800 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2460730Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Commit-Queue: Omar Morsi <omorsi@google.com> Cr-Commit-Position: refs/heads/master@{#817994}
-
Maksim Sisov authored
These no longer fail (were fixed at some point). Bug: 1084472 Change-Id: I45dd6e907056825a0bb8788dad7d74fc6446dd2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2445154Reviewed-by:
-
Martin Kreichgauer authored
AuthTokenRequester is a helper class that attempts to obtain a PinUvAuthToken from a FidoAuthenticator. It has a Delegate that collects PINs, updates the UI and receives the result. Follow-up CLs will integrate AuthTokenRequester into FidoRequestHandler implementations and replace the token request logic there. Change-Id: Ie189dab3a02fb1a118e128bb7589461ba5c5fad3 Bug: 1139111 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469404Reviewed-by:
Nina Satragno <nsatragno@chromium.org> Commit-Queue: Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#817992}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1602795589-2bd353ec3fee304a6bd3887aca77b7d3fb1210e3.profdata to chrome-win32-master-1602838722-3d3847c86317a9aa85069273b7be64c1533b4e7a.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Idfac5d1a8893a7ecdba9333cff7b6f12ea9fcf4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2478891Reviewed-by:
-
Jérôme Lebel authored
This reverts commit b2a6b60d. Since this patch is introducing a bug, I need to revert this patch: * sign-in * open the settings * open the account list * open the add SSO account view * cancel the SSO add account view Result: the user can't do sign-out anymore. Original change's description: > [iOS] Dismiss views on top of Settings UI after authentication. > > Currently the sign out UI is dismissed conditionally when the > authentication flow is complete. Remove the conditional since we expect > the sign out UI every time authentication completes. > > Bug: 1125631 > Change-Id: Ide9805e5490377f9ec3cf5d3625622ab08e876a4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472005 > Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> > Reviewed-by: Jérôme Lebel <jlebel@chromium.org> > Cr-Commit-Position: refs/heads/master@{#817863} TBR=jlebel@chromium.org,fernandex@chromium.org Change-Id: I40270d09662e2ccd5d24b8915d540cb5cd28ae49 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1125631 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2480824Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#817990}
-
Abigail Klein authored
settings subpage. To do this, move the component updater observer logic to the captions handler. Introduce a new ChromeOS-specific captions handler which will observe the SODA download from the DLC service (to be implemented in a follow-up). AX-Relnotes: N/A (feature not launched yet) Bug: 1055150, 1111002 Change-Id: I1f752836a1310f8eab44ae5fa31ca34060fb8147 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473446 Commit-Queue: Abigail Klein <abigailbklein@google.com> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#817989}
-
Alice Wang authored
This CL adds metric for the dismissal button in the web sign-in bottom sheet. Bug: 1139309 Change-Id: Idc381b3a79c77aa471b9b1a0b19bcc8fb731a4ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2479426Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#817988}
-
Mitsuru Oshima authored
This is a preparation to add GradientMask[1] support. [1] https://docs.google.com/document/d/1AXgfk66ROEr225roqAuPxrqWNsnDh91lHCQJ_cw8RrI/edit# Bug: 1039003 Change-Id: Ib452c83e3408a1cbdcfb743e0a5ce819258f5ff3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459429Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#817987}
-
Donn Denman authored
Updates the IPH param settings in the testing config file to add the Translations IPH and move the IPH parameters for Longpress into their own experiment. This reflects the Finch config layout we are planning, which gets around the limitation of having an IPH for each experiment when they are both active. BUG=1121867,1086724,1120080 Change-Id: I5d9758845bef2f84ac5a245c1b6967a1bcf7b908 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2477427Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Donn Denman <donnd@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Auto-Submit: Donn Denman <donnd@chromium.org> Commit-Queue: Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#817986}
-
Scott Violet authored
Prior to this patch, if the top-view was configured to only expand at top, then on page load the top-view would not be shown. During a load if current_browser_controls_visibility_constraint_ is BOTH, then cc is called with current and constraints of BOTH. cc doesn't do anything in this case. As we need to ensure the top-view is shown in this scenario this changes the code to supply SHOWN. This code path is only hit if top-view is configured to only-expand-at-top, as when only-expand-at-top is false, current_browser_controls_visibility_constraint_ is set to SHOWN. I experimented with fixing in cc, but cc has no notion of page loading. So, this fix is better done in WebLayer. BUG=1135964 TEST=BrowserControlsTest Change-Id: I7834ade5cd80de6946af0c2f917fb0ea1996e1f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476725 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#817985}
-
Xing Liu authored
IsReadListBookmark only checks the URL, which creates a problem that other bookmark source may have the same URL. Instead, this should check the in memory tree. Also print an error log for a legacy NOTREACHED() in bookmark_bridge.cc, since reading list eventually may be able to delete but not editable. Bug: 1139133 Change-Id: I58d2cbb6e2cd43c94670e2b707f5b4dd6fdd3128 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476750Reviewed-by:
Brandon Wylie <wylieb@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#817984}
-
manukh authored
- Omnibox.DocumentSuggest.Requests - Omnibox.DocumentSuggest.ResultCount We're still running experiments post-enterprise launch and will want to keep an eye on metrics for consumer launch as well. Bug: 1138296 Change-Id: I47004fce1dd132ba5a8e2070db47efe28986a90b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476535Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: manuk hovanesian <manukh@chromium.org> Cr-Commit-Position: refs/heads/master@{#817983}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/04bd4d8e4ece..a23231ea7d91 2020-10-16 cwallez@chromium.org MetalSurface: correctly handle the window resizing. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: Idb6ca255905d38af154876d037454c5c36e9a095 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2480382Reviewed-by:
-
Wez authored
Change-Id: Ie11606d71cd35269cce836407d9a302f45602f2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2479368 Auto-Submit: Wez <wez@chromium.org> Commit-Queue: David Dorwin <ddorwin@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#817981}
-
Xing Liu authored
We have deprecated K, DisableIf can be removed in BookmarkTest. Bug: 807807 Change-Id: I405bed68d1568211affd2ee4f293d019df5dade9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2478142Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#817980}
-
Adam Langley authored
onDestroy is called some time after an Activity is dismissed (i.e. "stopped") in Android terms. But I think caBLE operations should be suspended immediately when the Activity is dismissed. BUG=1002262 Change-Id: Idcc09daa17cd2ad691bd26a24c3f4af1ea1a1a6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2477518Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Commit-Queue: Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#817979}
-
Fredrik Söderqvist authored
This makes sure that the requests for the cursor resources has been issued before the following loadImages(...) call. Bug: 1137716, 1138589 Change-Id: I691360327c0d4f70f8eb50fdae224ab53dcc6111 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2479523 Commit-Queue: Stephen Chenney <schenney@chromium.org> Auto-Submit: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#817978}
-
Aaron Krajeski authored
It used to be the case that all small canvases were rendered in software. This was changed to improve performance, simplify code and improve testing. Unfortunately it caused a ton of crashes for webview devices. crbug.com/994310 A kludge was introduced to prevent these crashes for webview devices only: https://chromium-review.googlesource.com/c/chromium/src/+/1800346 Now that more than a year has gone by and there's been a lot of movement in all the relevant codebases (skia, webview, canvas, oop-r, etc.) it's worth seeing if this spike in crashes still happens. To remove this kludge would allow us to finally clear up the code path and greatly simplify testing. Bug: 1136603 Change-Id: Idca3844ee13f064adf8043ebcdc43808c6588f24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463328 Commit-Queue: Aaron Krajeski <aaronhk@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/master@{#817977}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/db0288d747ae..7db7139f4032 2020-10-16 bsalomon@google.com Revert "Revert "Move all YUVA image creation in GMs into sk_gpu_test::LazyYUVImage."" 2020-10-16 tdenniston@google.com Reland "Add subset of W3C test suite to SVG corpus" 2020-10-16 bsalomon@google.com Revert "Move all YUVA image creation in GMs into sk_gpu_test::LazyYUVImage." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC robertphillips@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: robertphillips@google.com Change-Id: Ie1c0116fca5c584ce8169a7e85f4c895e739ef87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2480403Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/711de82cd1ce..a667f878b15c 2020-10-16 kwiberg@webrtc.org Polish the "Using Abseil in WebRTC" docs 2020-10-16 danilchap@webrtc.org In VP9 wrapper fill information required to produce Dependency Descriptor If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I42722705e199ab16e03eddb20ea26c3792feb876 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2480542Reviewed-by:
-
