GitLab

This is part of the work to rewire the audio playback logic for iOS
(and potentially also for Android).

AudioJitterBuffer acts as a jitter buffer that queues up AudioPackets
once they are received and before they are consumed by a native playback
queue.
This class is basically modified from AudioPlayerBuffer with a few
changes:
* Allow handling packets in different stream formats/sample rate and
  call a callback when the format is changed.
* Move the underrun protection logic from AudioPlayerIos (the
  "PRIMING" state) into the jitter buffer.
* Fix a bug where bytes_extracted_ is ignored when copying audio data.
* Removed the AudioStreamConsumer inheritance, Stop() and other unused
  logic.

Bug: 868088
Change-Id: Ibaee655df28de68f5303d735ef89cf15695ab2ff
Reviewed-on: https://chromium-review.googlesource.com/1150936
Commit-Queue: Yuwei Huang <yuweih@chromium.org>
Reviewed-by: Joe Downing <joedow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580709}

Change-Id: Ia848a3607658a46eaadc1949cf59caf7b75f7528
Reviewed-on: https://chromium-review.googlesource.com/1161391
Commit-Queue: Lucas Gadani <lfg@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580708}

*** I plan to merge this into M69! ***

We are currently storing that a transition happened on first login,
which confuses ARC++. In reality, the profile was just not fully
initialized at the time of the check.

Bug: 869505
Change-Id: If040cea6f99136e024507f1649ae47f7dae4acff
Reviewed-on: https://chromium-review.googlesource.com/1159181
Commit-Queue: Bruno Kim Medeiros Cesar <brunokim@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Ryan Hamilton <rch@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580707}

The viz_fyi_android_gtest suite has stabilized. With the flakes seen being also
seen on general android.

This renames the config to viz_android_gtests and adds it to the general
chromium_android_gtests group to expand coverage.

TEST=viz_content_browsertests, surface_sync_content_browsertests

Bug: 849746
Change-Id: I63087db31fd9d834a0b98c3a7053577a097b92b4
Reviewed-on: https://chromium-review.googlesource.com/1133303
Commit-Queue: Jonathan Ross <jonross@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580706}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/29b7b99e5d9f..82bb756217cd


git log 29b7b99e5d9f..82bb756217cd --date=short --no-merges --format='%ad %ae %s'
2018-08-03 wangqing-hf@loongson.cn [cipd] Detect mips64le vs mips64.


Created with:
  gclient setdep -r src/third_party/depot_tools@82bb756217cd

The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:867819
TBR=agable@chromium.org

Change-Id: I79597c067ff1691bc025b43a2d9c2499d5be98cb
Reviewed-on: https://chromium-review.googlesource.com/1162801Reviewed-by: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#580705}

1 - Fixed a bug in partial rebind attempt
2 - Fixed a bug in custom view rebind where view already has a parent

Bug: 870879
Change-Id: I006e2d0f92a038e3b7a44b01b3e7f0c3075ab9b3
Reviewed-on: https://chromium-review.googlesource.com/1162774Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Shakti Sahu <shaktisahu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580704}

In two recent changes, we added some calls to
AXTreeSerializer::DeleteClientSubtree. This is often a great way to
ensure that portions of the tree are re-serialized.

However, what can happen is that there can be reparenting within a subtree,
and the client doesn't clear out the subtree first before unserializing it,
leading to an unserialization error.

This change introduces the concept of invalidating a subtree
instead of deleting it. That ensures the correct nodes are
re-serialized, while also allowing the code that checks for
reparenting.

Includes a regression test.

Bug: 866293
Change-Id: I257f1a0360d73d2f42dff56fe84a52034941a63b
Reviewed-on: https://chromium-review.googlesource.com/1152180
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580703}

EvalJs has the following improvements over ExecuteScript:
 - One function that works for every return type
   (no AndExtractBool etc variants) and every fancy
   option (isolated worlds, user gestures).
 - No out-params; no out-param variables.
 - |script| doesn't need to call domAutomationController explicitly
   to return a value. Instead, it has eval() semantics -- the statement
   completion value becomes the result.
 - The result of EvalJs can be used directly in EXPECT_EQ; e.g.::
   EXPECT_EQ("about:blank", EvalJs(contents, "window.location.href"));
 - JS exceptions are reliably captured and will appear as C++ assertion
   failures.
 - JS stack traces arising from exceptions are annotated with the
   corresponding source code; this also appears in C++ assertion failures.
 - When a script doesn't produce a result, tests are much less likely
   to hang.
 - Doesn't get confused by crosstalk with other callers
   of domAutomationController.send().
 - Lists, dicts, null values, etc. can be returned as base::Values.

Limitations/warts:
 - The reliance on eval() currently means that a CSP script-src
   directive can interfere with the script runner. There is
   a workaround (use an isolated world), but this limitation
   currently prevents ExecJs from being a drop-in replacement
   for ExecuteScript. Fixing that will be a follow-on.

Change-Id: I260595094f71e7734d29a78e9ffd90b409d74f37
Reviewed-on: https://chromium-review.googlesource.com/1125121
Commit-Queue: Nick Carter <nick@chromium.org>
Reviewed-by: Ben Greenstein <bengr@chromium.org>
Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580702}

Tests SlowLoadingPageTest.testRefreshShouldBlockUntilPageLoads and
ChromeDriverPageLoadTimeoutTest.testRefreshWithPageLoadTimeout are
flaky on Linux build bot on Waterfall.
Disabling these tests.

Bug: chromedriver:2532
Change-Id: Id3ff0730b1b4601dcf238771f863a021dd5d4f95
Reviewed-on: https://chromium-review.googlesource.com/1162821Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: Artur Khachatryan <khachatryan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580701}

BUG=862404

Change-Id: I39a49e01d58fb4c83d8a78002e442f6245bf0ea4
Reviewed-on: https://chromium-review.googlesource.com/1162674Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580700}

Now, changing the HideWebStoreIcon policy will affect the
prepopulated_list when a new profile opens or reopen the browser. The
policy doesn't affect current profile on the NTP. This is because the
browser will cache the prepopulated list so that it can fetch the tiles
quickly.

Bug: 855603
Change-Id: I99ac05040fc44f64ac61151218dcbcc612465e72
Reviewed-on: https://chromium-review.googlesource.com/1137432Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Weilun Shi <sweilun@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580699}

Rename "Trick to Bill" in the code to "Billing".
This CL will change values such as:
- SB_THREAT_TYPE_TRICK_TO_BILL to SB_THREAT_TYPE_BILLING
- SB_REASON_TRICK_TO_BILL to SB_REASON_BILLING

Bug: 867518
Change-Id: I0f1b5f9bb8c21d10053de74001b5af0d493e4363
Reviewed-on: https://chromium-review.googlesource.com/1159228Reviewed-by: Mustafa Emre Acer <meacer@chromium.org>
Reviewed-by: Varun Khaneja <vakh@chromium.org>
Commit-Queue: Varun Khaneja <vakh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580698}

VRDisplayHost serves as the browser side implementation of the XRDevice
mojo interface, so renaming it to make that explicit.

Bug: 842025
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I24fc584f06cfcc50c942e2df8bc451badb67e20f
Reviewed-on: https://chromium-review.googlesource.com/1162693Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Bill Orr <billorr@chromium.org>
Commit-Queue: Anna Offenwanger <offenwanger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580697}

During touch, we want to either announce 'is editing' is a text field is focused, or 'double tap to start editing' when a text field is in ChromeVox range, but not focused.

We want to do this only for touch because keyboard commands,e .g. search+right, will automatically try to focus the text field. Since ChromeVox preemptively reads the new element (and doesn't wait for the focus event on the text field), the output here would be incomplete until the focus event.

Fortunately, we only really need this announcement for touch.

Bug: 869880
Test: manual
Change-Id: I0d25cb28ece2b1a95658108fb5d032a91b705064
Reviewed-on: https://chromium-review.googlesource.com/1162627
Commit-Queue: David Tseng <dtseng@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580696}

This CL adds methods to get all DownloadEntry from InProgressCache,
convert them, and adding them back to the DownloadDB.
This migration step allows us to move from InProgressCache to DownloadDB.

BUG=870502

Change-Id: Id56346886b1cea2df6fa25954c89cdfb4db167d4
Reviewed-on: https://chromium-review.googlesource.com/1161487
Commit-Queue: Min Qin <qinmin@chromium.org>
Reviewed-by: Xing Liu <xingliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580695}

Change-Id: Id1fee120b7d61cc41cd359389bf5d05f28dac674
Reviewed-on: https://chromium-review.googlesource.com/1162430Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580694}

1. Autocomplete works on apps and playstore suggestions.
2. Autocomplete no longer works with less than 2 characters.

Bug: 865543
Change-Id: Ib438083463d76b7dbd4106b8cf8ae574a47fafcc
Reviewed-on: https://chromium-review.googlesource.com/1161511Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Alex Newcomer <newcomer@chromium.org>
Commit-Queue: Daniel Zhang <oxyflush@google.com>
Cr-Commit-Position: refs/heads/master@{#580693}

Moved the feature flag to the mirroring service so that it can be
conveniently accessed by multiple components in coming CLs.

Bug: 734672
Change-Id: I4626b5240592a8d0ccee146675f034bbde8700db
Reviewed-on: https://chromium-review.googlesource.com/1162634Reviewed-by: Takumi Fujimoto <takumif@chromium.org>
Commit-Queue: Xiangjun Zhang <xjz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580692}

Make SearchBoxViewBase have the option to record searchbox activation.

Override RecordSearchBoxActivationHistogram at app_list SearchBoxView.

Bug: 864790
Change-Id: I91001aaf188193f11d7448cb31ee75c76c1c8d6c
Reviewed-on: https://chromium-review.googlesource.com/1142575
Commit-Queue: Alex Newcomer <newcomer@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580691}

TBR=jdburocik@chromium.org

Change-Id: I5791bf6a4473815cd5c8577af6e431649c49f3b7
Reviewed-on: https://chromium-review.googlesource.com/1162834Reviewed-by: Ben Pastene <bpastene@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580690}

Telemetry tests are not idempotent. The original implementation:
https://codereview.chromium.org/1424693002 marked every IsolatedScriptTest as
idempotent=False. This incorrectly marked subsequently added IsolatedScriptTests
such as webkit_layout_tests as idempotent=False. This CL explicitly calls out
telemetry tests as idempotent=False -- other tests will default to
idempotent=True.

This CL adds the flag directly to test_suites.pyl for *telemetry_unittests*,
*telemetry_perf_unittests* and *telemetry_gpu_unittests*. For gpu telemetry
integration tests, the flag is added via generate_gpu_telemetry_test().

Change-Id: Ibd3839c0f24a418e7a87ed3b7bc0cec73963c062
Bug: 549140
Reviewed-on: https://chromium-review.googlesource.com/1161461
Commit-Queue: Erik Chen <erikchen@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580689}

https://chromium.googlesource.com/webm/libvpx.git/+log/2d79df494088..6fd9d0244c7d

$ git log 2d79df494..6fd9d0244 --date=short --no-merges --format='%ad %ae %s'
2018-08-03 marpan vp9: Add screen-content mode to overshoot detection.
2018-08-03 marpan vp9: Adjust qp_thresh on slide change overshoot detection
2018-08-02 marpan vp9: Add zero_temp_sad count to scene detection.
2018-08-02 marpan vp9: Increase min_thresh for slide change detection
2018-08-02 huisu Refactor vp9_full_pixel_search()
2018-08-02 marpan vp9: Disable re_encode_overshoot feature for speed >= 6.
2018-08-01 huisu Handle partition cost better in RD search
2018-07-31 jingning Use mesh full pixel motion search to build the source ARF
2018-08-01 jianj vp9 svc: Adjust overshoot threshold in datarate test.
2018-08-01 jianj vp9: Refactor nonrd pickmode: new mv search
2018-07-30 jianj vp9: Refactor nonrd pickmode: interp filter.
2018-07-30 jianj vp9: Refactor nonrd pickmode: tx_size.
2018-07-31 jianj vp9 svc: Fix the scaling factor in intra only test for 1 SL.
2018-07-31 jzern vp9_encoder: make setup_tpl_stats() static
2018-07-31 marpan vp9: Clamp tx_size in model_rd_large
2018-07-31 jzern vp9: enable tpl model in high-bitdepth w/8-bit output
2018-07-31 jianj vp9: Disable aq mode for some datarate tests.
2018-07-31 marpan vp9: Remove assert from model_rd in non-rd pickmode.
2018-07-27 jingning Add frame pointer to support recon frames in tpl model
2018-07-27 jingning Move frame pointer assignment outside block loop in tpl model
(...)

Created with:
  roll-dep src/third_party/libvpx/source/libvpx
R=johannkoenig@google.com

BUG=b/112123926

Change-Id: I5adddb62cf63654739a3dc8f8ebe398fd5c744e4
Reviewed-on: https://chromium-review.googlesource.com/1162719Reviewed-by: Johann Koenig <johannkoenig@google.com>
Commit-Queue: Jerome Jiang <jianj@google.com>
Cr-Commit-Position: refs/heads/master@{#580688}

Previously, if a user was removed from the Login screen, all the other users' state was reset. This meant that |show_pin|, which is updated only once by a call to PinBackend::CanAuthenticate(), was reset to false even if PIN was enabled for that user.

Bug: 863480
Change-Id: I8824068f58413f8f561cd73836241840747dee27
Reviewed-on: https://chromium-review.googlesource.com/1161398
Commit-Queue: Quan Nguyen <qnnguyen@chromium.org>
Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580687}

This CL does two things(although looking huge):
- Adds a new MediaStreamType to specify getDisplayMedia() requests.(PS#2)
- Renames existing MEDIA_TAB* and MEDIA_DESKTOP* enums by adding
GUM to their name to distinguish these cases that originate from
calls to extension APIs and getUserMedia().(PS#1)

Bug: 326740
Change-Id: I1c4b47f1cb6c2fed478dcd265f9b1d9525efb4cb
Reviewed-on: https://chromium-review.googlesource.com/1160000
Commit-Queue: Emircan Uysaler <emircan@chromium.org>
Reviewed-by: Will Harris <wfh@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Christian Fremerey <chfremer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580686}

This CL addresses an inconsistency in behaviour between explicitly
tapping "Cancel" in the add to home screen dialog and tapping outside
the dialog to dismiss it (also effectively cancelling).

Explicitly tapping on "Cancel" allowed the site to receive a new
beforeinstallpromptevent to trigger a new dialog, but tapping outside
the dialog did not. This CL removes the inconsistency by eliminating the
AddToHomescreenDialog.Delegate#onDialogCancelled() method (previously
only called when explicitly tapping "Cancel"), and maintaining state in
the AppBannerUiDelegateAndroid to determine whether or not to call
AppBannerUiDelegateAndroid#nativeOnUiCancelled(). This ensures a fresh
beforeinstallpromptevent is dispatched when the dialog isn't accepted -
whether it was explicitly cancelled or implicitly dismissed by tapping
elsewhere on the screen.

BUG=867465

Change-Id: I4e37d4a34e2b25797ee5bc386010de0b995e3d93
Reviewed-on: https://chromium-review.googlesource.com/1157945
Commit-Queue: Dominick Ng <dominickn@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580685}

On cold start with a NTP opened as current tab and header is collapsed,
the suggestions status can be updated to explicitly disabled after the
UI is initialized, which removes the entire section including the
expandable header.

We should add the section back if necessary on status changed to
explicitly disabled.

Bug: 851516
Change-Id: Ied7c7737dfb22b3dc22f4a059c48f1b0793b681a
Reviewed-on: https://chromium-review.googlesource.com/1097226Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Becky Zhou <huayinz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580684}

The suggestion container fades in and translates up on entry. It fades
out on exit.

See bug for spec/demo.

Bug: b:112145361
Change-Id: Id6abad171a22920658ce5b760b545c8d29cbed9f
Reviewed-on: https://chromium-review.googlesource.com/1160928
Commit-Queue: David Black <dmblack@google.com>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580683}

Adds support for dynamically changing VrCore's settings during VR tests
using the VR settings service instead of only relying on them being
statically set before the test suite starts. Most tests still use the
old method since dynamic settings have additional overhead. However,
less standard test configurations such as enabling the DON flow are good
candidates for using this functionality.

Also changes the test suites that ran with the DON flow enabled to be
a generic "run with dynamic settings" test suite, which currently only
includes the DON flow tests.

Bug: 870782
Change-Id: I81482c959f0197c743e9a5a827d80c1b30a56757
Reviewed-on: https://chromium-review.googlesource.com/1162352Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580682}

We received a report that key events being delivered to JS did not
have the repeat field set correctly when KB lock was engaged, but
only on Windows.  It turns out this is becuase a low-level KB hook
on Windows is not given any params / flags which would indicate
whether the key event received was a repeat or not.

In order to address this problem, I've added some logic which tracks
the last key seen and compares it to the current event to see if we
should mark the event as a repeat or not.

BUG=869865

Change-Id: I0b3501ebd768e9c8b4c3c792d41b06e3de23eaf4
Reviewed-on: https://chromium-review.googlesource.com/1161458Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Joe Downing <joedow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580681}

Bug: 80048435
Test: User EQ on video device w/ mixer
Change-Id: Iccd7ffb26e1cc75fbc79ec0bb1db04dc6551ee08
Reviewed-on: https://chromium-review.googlesource.com/1159694
Commit-Queue: Benjamin Shaya <bshaya@chromium.org>
Reviewed-by: Kenneth MacKay <kmackay@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580680}

Removes:
- not_site_per_process_interactive_ui_tests
- not_site_per_process_sync_integration_tests
- not_site_per_process_unit_tests

Bug: 870761,843511
Change-Id: I498ae273ffcef62698f0992783dbea89f1bbe7d1
Reviewed-on: https://chromium-review.googlesource.com/1161975Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580679}

This is a follow-up to https://crrev.com/c/1122489, which removed
the BattOr PowerTracingAgent from Chrome.

R=oysteine@chromium.org, dcheng@chromium.org

Bug: 859514
Change-Id: Ib4324289fcf9d1d0e3d34f828550a488a694644b
Reviewed-on: https://chromium-review.googlesource.com/1162626
Commit-Queue: Charlie Andrews <charliea@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: oysteine <oysteine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580678}

This is straight forward except for understanding what's up
with Restore. I've added a comment there, it may be
worth resolving in this change.

Bug:851762

Change-Id: I45b56b3f10dd96dae2b6c502030ced8e8ace026b
Reviewed-on: https://chromium-review.googlesource.com/1161178
Commit-Queue: Johannes Henkel <johannes@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580677}

This reverts commit 0856d23e.

Reason for revert: <INSERT REASONING HERE>

Original change's description:
> Reland "Reland "[Sync::USS] Bookmark sync conflict resolution""
> 
> This is a reland of a445460b
> because it was reverted by mistake.
> 
> TBR=mastiz@chromium.org
> 
> Original change's description:
> > Reland "[Sync::USS] Bookmark sync conflict resolution"
> >
> > This is a reland of 553ec6da
> >
> > Original change's description:
> > > [Sync::USS] Bookmark sync conflict resolution
> > >
> > > This patch addresses the problem of conflict in bookmarks upon
> > > receiving a remote update for a node that has local changes.
> > >
> > > The general polic that is implemented is that server wins except in
> > > case of deletion.
> > >
> > > Bug: 516866
> > > Change-Id: I50a85bde068dd9414e4e22bc1a33529fb3dfffa1
> > > Reviewed-on: https://chromium-review.googlesource.com/1157006
> > > Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
> > > Reviewed-by: Mikel Astiz <mastiz@chromium.org>
> > > Cr-Commit-Position: refs/heads/master@{#580436}
> >
> > Bug: 516866
> > Change-Id: I73bb31e143aa7baadd5fa8c0afd3d91554c9aa6e
> > Reviewed-on: https://chromium-review.googlesource.com/1161861
> > Reviewed-by: Mikel Astiz <mastiz@chromium.org>
> > Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#580496}
> 
> Bug: 516866
> Change-Id: I285dfa50ae5374bc82840b6d140f99f7edddd552
> Reviewed-on: https://chromium-review.googlesource.com/1162181
> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
> Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#580553}

TBR=treib@chromium.org,mastiz@chromium.org,mamir@chromium.org

Change-Id: Ibd5c2c5ddd40a916dd8a2e04866ddedd46458da1
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 516866
Reviewed-on: https://chromium-review.googlesource.com/1162841Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org>
Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580676}

I made it so that clearDeviceOrientationOverride() delegates
to disable(), which is now more careful about clearing out the state.

For reference the PR that introduced the new
InspectorSessionState / InspectorAgentState / Fields
was https://chromium-review.googlesource.com/c/chromium/src/+/1149201.
We're migrating things from state_ to this new mechanism,
which allows incremental updates to flow back to the browser
process.

Bug:851762

Change-Id: I388198b01da77e04943a4c23e90f521e25aeab94
Reviewed-on: https://chromium-review.googlesource.com/1159697
Commit-Queue: Johannes Henkel <johannes@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580675}

Uses CGAffineTransformMakeRotation to do a 180 rotation of
the collection cells accessoryView whenever a chevron is
being used on RTL.

Bug: 869142
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ic10ebc0067e34a7fe8d593d4aafeb25dca4f9e99
Reviewed-on: https://chromium-review.googlesource.com/1162428
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580674}

This reverts commit e8b14cdd.

Reason for revert: Mistakenly reverted.

Original change's description:
> Revert "chromeos: splits ash's file list into public/sources sections"
> 
> This reverts commit 2e803140.
> 
> Reason for revert: speculative revert, seems to have introduced the following failure: https://bugs.chromium.org/p/chromium/issues/detail?id=870827
> Original change's description:
> > chromeos: splits ash's file list into public/sources sections
> > 
> > I'm putting all the '.h' files into public. We can refine the list as necessary
> > later.
> > 
> > I'm doing this as I would like to have private headers that other targets can't
> > include (well, except tests).
> > 
> > BUG=none
> > TEST=none
> > 
> > Change-Id: I84ab155a1449d969076dcd94feaa0150f3e9ad85
> > Reviewed-on: https://chromium-review.googlesource.com/1161498
> > Commit-Queue: Scott Violet <sky@chromium.org>
> > Reviewed-by: James Cook <jamescook@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#580581}
> 
> TBR=jamescook@chromium.org,sky@chromium.org
> 
> Change-Id: Icfed283e1b854f9639fe111fbd83b948b8d6147f
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: none
> Reviewed-on: https://chromium-review.googlesource.com/1162207
> Reviewed-by: Roberto Carrillo <robertocn@chromium.org>
> Commit-Queue: Roberto Carrillo <robertocn@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#580630}

TBR=jamescook@chromium.org,sky@chromium.org,robertocn@chromium.org

Change-Id: I66a38be64c22fb1b6a6f808bfee64517f912e7ad
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: none
Reviewed-on: https://chromium-review.googlesource.com/1162212Reviewed-by: Roberto Carrillo <robertocn@chromium.org>
Commit-Queue: Roberto Carrillo <robertocn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580673}

This requires --enable-features=AudioServiceAudioStreams,AudioServiceOutOfProcess,AudioServiceSandbox

Bug: 850878
Change-Id: I9c759b2537483612f9b3106bdf2ec193b343f198
Reviewed-on: https://chromium-review.googlesource.com/1152080Reviewed-by: Greg Kerr <kerrnel@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580672}

Also use the correct type, size_t, for its size.

Some code cleanup and simplification.

Bug: 817982
Change-Id: I42f4d4230a60d64de8ea483450159c92475e3e4b
Reviewed-on: https://chromium-review.googlesource.com/1157649
Commit-Queue: Chris Palmer <palmer@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580671}

With error page isolation, navigations that result in a chrome error
page (as opposed to HTTP errors such as 404) are isolated in their own
process.

This CL adds some validations at commit time to ensure that invariants
we expect are enforced by the browser. It only includes some of the
possible checks, as more investigations are needed to understand the
behavior of HTTP layer errors.

Bug: 866549
Change-Id: I8389629eb68213681983b37d1cfc945832e35ea7
Reviewed-on: https://chromium-review.googlesource.com/1160877
Commit-Queue: Nasko Oskov <nasko@chromium.org>
Reviewed-by: Charlie Reis <creis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580670}