- 22 Mar, 2018 40 commits
-
-
Balazs Engedy authored
Bug: 780078 Change-Id: I8f538a29306f1f94a2b5b5c307d743d485f33336 Reviewed-on: https://chromium-review.googlesource.com/975542 Commit-Queue: Balazs Engedy <engedy@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#545090}
-
Elly Fong-Jones authored
These tests don't work when using a Mac printing dialog with MacViews, because the modal closure animation makes window closure very asynchronous. Disable it altogether in this set of tests. Bug: 817408 Change-Id: Idb1bd814e9248e0cbd8d07e3426084c72db06d65 Reviewed-on: https://chromium-review.googlesource.com/975521Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#545089}
-
Mark Cogan authored
This CL further refactors the grid animation in preparation for supporting a reversable version. Each of the four primary steps in the animation (positioning and scaling the selected and unselected cells in both the regular and expanded positions) is extracted into a separate method, and common code in those methods is further extracted to reduce repitition. Bug: 804539 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ibabd01e9f01fb58198bcd14f39536a77dcdf2c39 Reviewed-on: https://chromium-review.googlesource.com/975462 Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#545088}
-
Avi Drissman authored
BUG=714018 Change-Id: I33cd6842055c959af25e286b1962c6f902b35971 Reviewed-on: https://chromium-review.googlesource.com/974284Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#545087}
-
erikchen authored
On macOS, measurements for private memory footprint overcount by faulted pages in anonymous shared memory. To discount for this, this CL touches all the resident pages in anonymous shared memory, thus making them faulted as well. This relies on two assumptions: 1) Consumers use shared memory from front to back. Thus, if there are (N) resident pages, those pages represent the first N * PAGE_SIZE bytes in the shared memory region. 2) The faulting logic is run shortly before the logic that calculates phys_footprint, thus ensuring that the discrepancy between faulted and resident pages is minimal. The performance penalty is expected to be small. * Most of the time, we expect the pages to already be resident and faulted, thus incurring a cache penalty read hit [since we read from each resident page]. * Rarely, we expect the pages to be resident but not faulted, resulting in soft faults + cache penalty. * If assumption (1) is invalid, this will potentially fault some previously non-resident pages, thus increasing memory usage, without fixing the accounting. Bug: 812346 Change-Id: I04e91bc09bf6bdf2f9179dd8d678c92425e98fed Reviewed-on: https://chromium-review.googlesource.com/973883Reviewed-by:
Primiano Tucci <primiano@chromium.org> Reviewed-by:
Albert J. Wong <ajwong@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#545086}
-
Emily Hanley authored
Now that the recipe doesn't see each benchmark, we don't want a swarming shard to fail if just the reference build fails. Bug: 758630 Change-Id: I67a11a8ef18e9a3a5405896367e67faa542b584f Reviewed-on: https://chromium-review.googlesource.com/975626Reviewed-by:
Ashley Enstad <ashleymarie@chromium.org> Commit-Queue: Emily Hanley <eyaich@chromium.org> Cr-Commit-Position: refs/heads/master@{#545085}
-
crystallambert@chromium.org authored
Extensions management page has a new UI. Current screen shots of page are outdated. This CL updates the screen shots in the Get Started Tutorial to match the new UI. Bug: 824766 Change-Id: Ie7028dbbe44663eaabf56fec2356c42ac7fbe102 Reviewed-on: https://chromium-review.googlesource.com/975664Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Crystal Lambert <crystallambert@chromium.org> Cr-Commit-Position: refs/heads/master@{#545084}
-
Elly Fong-Jones authored
This test doesn't work on Mac in any mode; it historically hasn't been run on Mac at all. Something is up with the fullscreen transition it does. TBR=robliao@chromium.org Bug: 824757,817408 Change-Id: Ie32cabcaf3d69e7b6944cedb17a2a0ad61da9966 Reviewed-on: https://chromium-review.googlesource.com/975625Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#545083}
-
stkhapugin@chromium.org authored
Adds support for arrows left/right when displaying inline autocomplete. Arrow right accepts the input and moves the cursor to the end of the textfield; arrow left accepts the input and keeps the cursor in the same position - mirroring what desktop does. Bug: 822307 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I58608e6cb41a904ffb12890e238a4ca000cf5b6f Reviewed-on: https://chromium-review.googlesource.com/973525 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#545082}
-
Colin Blundell authored
The chrome.identity.onSigninChanged extension API event is defined as follows: "Fired when signin state changes for an account on the user's profile." (https://developer.chrome.com/apps/identity#event-onSignInChanged) The current browser-side implementation uses gaia::AccountTracker, which ignores events for secondary accounts if there is no primary account (i.e., syncing account) present. Thus, this browser-side implementation also fires events for secondary accounts only if there is a primary account present. However: (1) This behavior is not defined in the documented semantics above (2) In practice, this case has historically never been encountered by end users, as it has been impossible in desktop Chrome to have a secondary account without a primary account present. This CL changes this undocumented behavior, so that events for secondary events will fire regardless of whether a primary account is present. Post-project DICE, it will be possible for this case to be encountered by end users. In that world, it will actually be more sensible for events to fire for secondary accounts regardless of whether or not the user has designated a syncing account. The CL implements this change by porting IdentityAPI away from using gaia::AccountTracker to observing ProfileOAuth2TokenService and AccountTrackerService directly. By doing so, IdentityAPI observes (and fires events for) signin change events for secondary accounts regardless of whether a primary account is present. This change has a side benefit in removing usage of the AccountTracker class, which is deprecated with an eye toward complete removal (see details in crbug.com/729590). It will be followed up by a conversion of this code to use the Identity Service client library. To test, install a Chrome extension with the identity permissions in its manifest. Go to chrome://extensions, enable developer mode, and inspect the background page of the above app. At the JS console that that brings up, execute: chrome.identity.onSignInChanged.addListener((account, signed_in) => {console.log(account.id + " " + signed_in);} ) Sign out of the browser. Verify that you receive a callback at the console with a value of false. Sign back in. Verify that you receive another callback at the console for the same account ID with a value of true. Bug: 729589, 729542, 769700 Change-Id: I99dd48d34b380067ac34a2207effd9d3279191fd Reviewed-on: https://chromium-review.googlesource.com/596368 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#545081}
-
https://chromium.googlesource.com/angle/angle.git/+log/8b92c53b8a8c..c26214de3f86 $ git log 8b92c53b8..c26214de3 --date=short --no-merges --format='%ad %ae %s' 2018-03-16 oetuaho Move AST utilities to a subdirectory Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=jmadill@chromium.org Change-Id: Ib6234fc17cf251a5aba38bfea81ba05c8675c75e Reviewed-on: https://chromium-review.googlesource.com/975345Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#545080}
-
Robert Liao authored
BUG=824517 TBR=rdevlin.cronin@chromium.org Disabling a test. Change-Id: Ieead48926aad1ed9ced951e47a9ff114e4a8e8a1 Reviewed-on: https://chromium-review.googlesource.com/974313Reviewed-by:
Robert Liao <robliao@chromium.org> Reviewed-by:
-
Rob Buis authored
The how parameter is defined as unsigned short in WebIDL. The generated bindings end up calling ToSmallerUInt in V8BindingForCore.cpp. The final cast in this method seems to hit an ARM specific issue [1]. To fix this static cast to int64_t before static casting to the unsigned type. [1] http://www.embeddeduse.com/2013/08/25/casting-a-negative-float-to-an-unsigned-int/ Bug: 823812 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I90c733185b8325984e004224dd72176840d1794e Reviewed-on: https://chromium-review.googlesource.com/970901Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Rob Buis <rob.buis@samsung.com> Cr-Commit-Position: refs/heads/master@{#545078}
-
Wei Li authored
Some extension/app pages are hosted by guest views, which means they have nested web contents. This CL checks nested web contents and always use the outer contents to handle print requests so the entire content can be printed correctly. BUG=819583, 447941 Change-Id: I6b45f4867d13cf5141476a7e748e8c0e5d3b0996 Reviewed-on: https://chromium-review.googlesource.com/969949 Commit-Queue: Wei Li <weili@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#545077}
-
David Bokan authored
This bug would only affect the non-root-layer-scrolling path and only when the page is scrolled. This CL fixes the issue and cleans up the surrounding code a bit. I also took the opportunity to cleanup the drag-and-drop autoscrolling tests: - Modernized using testharness.js and new test style guidelines - I've based them all on the drag-and-drop-autoscroll-frame.js script for commonality. - All the tests now occur at a non-0 scroll offset to make sure we catch these kinds of coordinate space bugs. Change-Id: I3191796917f23b2e9b2cc3f561813176fa2dec9a Reviewed-on: https://chromium-review.googlesource.com/972148 Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by:
Sandra Sun <sunyunjia@chromium.org> Cr-Commit-Position: refs/heads/master@{#545076}
-
Chandan Padhi authored
This CL also wires these constraints to Blink's internal goog_auto_gain_control and goog_noise_suppression respectively. This automatically provides support for these constraints in mediaDevices.getUserMedia(), MediaStreamTrack.applyConstraints() and MediaStreamTrack.getConstraints(). Intent to ship: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/ANta5sQXoGA Bug: 823831 Change-Id: I71c84e6464533de8abfb51fb12d774849b34a91f Reviewed-on: https://chromium-review.googlesource.com/975501Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Chandan Padhi <c.padhi@samsung.com> Cr-Commit-Position: refs/heads/master@{#545075}
-
Joshua Peraza authored
132a61018473 elf: Use compiler macros in crashpad info note f5b486de7416 linux: Make StartHandler methods static f5483cb99fd4 linux: Use HANDLE_EINTR for sendmsg and recvmsg cf9e96b856cb elf: Use compiler macros in crashpad info size test note 6d4626090db2 linux: Add a second CaptureContext symbol name Bug: crashpad:30 Change-Id: I99d6866bc07bc8fa636f736e29ad5ba94e134ea1 Reviewed-on: https://chromium-review.googlesource.com/971833 Commit-Queue: Joshua Peraza <jperaza@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#545074}
-
edchin authored
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: If4b4e2fa6e6a0e091b2e15882fa5c7774efbbbd9 Reviewed-on: https://chromium-review.googlesource.com/972621Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#545073}
-
Elly Fong-Jones authored
This test relies on having a BrowserView to get a ToolbarView. Since ToolbarView is never used without BrowserView, only run this test in Views mode. TBR=pkasting@chromium.org Bug: 817408 Change-Id: I6f3388cf72356f8657f74637967d2e27c0db80d1 Reviewed-on: https://chromium-review.googlesource.com/975624Reviewed-by:
-
Eugene But authored
This is an existing histogram logged for the Old Download Manager. The histogram is already a part of histograms.xml file. Bug: 791806 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I93c0d84e91622654245b7dca88f06c5771e42b65 Reviewed-on: https://chromium-review.googlesource.com/973945Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#545071}
-
edchin authored
This CL animates the appearance of the empty state prompt as the last tab closes. The animation scales and fades in. Bug: 804558 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I1449560d6be676030048e11cf32db21123c37e5f Reviewed-on: https://chromium-review.googlesource.com/974576 Commit-Queue: edchin <edchin@chromium.org> Reviewed-by:
-
Daniel Bratell authored
There are constants for Android SDK versions in build_info.h so nobody has to declare their own. This changes some duplicated custom constants that clashed in jumbo builds to use the global constants. Bug: 598880 Change-Id: I32bc147729e561130eaaf4feab545bd0cd9714c1 Reviewed-on: https://chromium-review.googlesource.com/975641Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#545069}
-
Ian Vollick authored
Updating the strings to match spec. Bug: None Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I3c283baf9224bf9167ed5165d1f4771abac7a500 Reviewed-on: https://chromium-review.googlesource.com/975481Reviewed-by:
Amirhossein Simjour <asimjour@chromium.org> Commit-Queue: Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#545068}
-
Randy Rossi authored
Moving automation manifest handler into //extensions. Other automation bits & pieces to follow in subsequent CLs. Bug: 822747, b/74537394 Test: Tested install of ChromeVox on ChromiumOs and Google branded Chrome build Change-Id: I18d828f76c17cb120e7cc9ed8022f107f3f3a2ea Reviewed-on: https://chromium-review.googlesource.com/964732 Commit-Queue: Randy Rossi <rmrossi@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
-
Amirhossein Simjour authored
Make sure that AnchoredPopupWindow inside of DropdownPopupWindow is always focusable, so the items in the list can be selected. Bug: 820898 Change-Id: I8ede526787cad6bb585013d2c4280d502eff7652 Reviewed-on: https://chromium-review.googlesource.com/974172Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Amirhossein Simjour <asimjour@chromium.org> Cr-Commit-Position: refs/heads/master@{#545066}
-
Dianna Hu authored
This CL lands server change 188737435 by clshepherd. BUG=488484 Change-Id: Iaea875815b0de8713b72b1e7b9773a5bfff029f7 Reviewed-on: https://chromium-review.googlesource.com/974133 Commit-Queue: Bence Béky <bnc@chromium.org> Reviewed-by:
Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#545065}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/b8eac287..2d4815d9 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I1878ae3fc3f0a771f9efe801685e8ed82bf13e3a Reviewed-on: https://chromium-review.googlesource.com/975342Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#545064}
-
Mihai Sardarescu authored
The views implementation of the profile_chooser_view has been launched in M64. This CL removes the cocoa implementation of the profile_choose_view. Change-Id: If349ced487e4c6f2b37b0d52bd215a67f7be8f22 Reviewed-on: https://chromium-review.googlesource.com/968262 Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#545063}
-
Peter Wen authored
Android Studio has split into channels, stable (3.0), beta (3.1) and canary (3.2) with corresponding packages. We should support all three. Bug: 620034 Change-Id: If8ebc37c137d53c5811aa8ce9258ac0dcef3d470 Reviewed-on: https://chromium-review.googlesource.com/974101Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#545062}
-
Mark Pilgrim authored
Explicitly mark GuestCallback as a RepeatingCallback and use BindRepeating on all callers BUG=714018 TBR=sky@chromium.org Change-Id: I5e1d7283b421872291fad9131fb6977d1ba8b3c0 Reviewed-on: https://chromium-review.googlesource.com/970904 Commit-Queue: Mark Pilgrim <pilgrim@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#545061}
-
Jochen Eisinger authored
We shouldn't blanket allow including WebKit or content/public files. BUG=none R=dsinclair@chromium.org Change-Id: I3592f604b33c03984255b1af321db076ebaa17ca Reviewed-on: https://chromium-review.googlesource.com/974962Reviewed-by:
dsinclair <dsinclair@chromium.org> Commit-Queue: Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#545060}
-
https://webrtc.googlesource.com/src.git/+log/3dc0125cf7e8..b3179c75ed40 $ git log 3dc0125cf..b3179c75e --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc BUG=chromium:None,chromium:None,chromium:824111,chromium:824679,chromium:none,chromium:None,chromium:None,chromium:None,chromium:824111,chromium:None,chromium:None,chromium:None,chromium:None,chromium:None,chromium:None,chromium:None,chromium:None,chromium:None,chromium:None,chromium:None,chromium:None The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Icaa35e74c476b297d3c935b54e86d9b172d7703e Reviewed-on: https://chromium-review.googlesource.com/975348Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#545059}
-
edchin authored
Previously, the new tab button would not change until after the page scroll completed the animation. In that case, the user is able to tap on the button during the animation, which potentially resulted in the wrong type of tab being created. This CL ensures that the new tab button, as well as all other visual appearances dependent on the current page gets updated during the scroll, so it is accurate as possible. Bug: 823842, 804580 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I541a2811929b4e0835649c64e76260f4e11962da Reviewed-on: https://chromium-review.googlesource.com/972435 Commit-Queue: edchin <edchin@chromium.org> Reviewed-by:
-
David Roger authored
Bug: 822728 Change-Id: Iaf1de0917be3533d03da0e2aac3b9d33fb03d477 Reviewed-on: https://chromium-review.googlesource.com/966068 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by:
-
Yang Guo authored
The debug() function is going to be extended by a condition string argument. R=machenbach@chromium.org Bug: v8:178 Change-Id: I7d9a15bc3f17e9c23e4011d7f4ee55671519df3c Reviewed-on: https://chromium-review.googlesource.com/975402Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#545056}
-
Mark Cogan authored
This CL refactors the tab grid transition animation by separating the transition animator-specific logic (including getting state information vie the transition state provider) from the animation itself. The new GridTransitionAnimator object is a UIView sublcass that hosts the proxy cell views used for the animation. It isn't dependent on the specific view setup or timing of a transition animator, and so could be used anywhere. The transition animator still handles fading out the tab view (the BVC). A future CL may move this logic into the BVC's -viewWillDisappear:. This is a preparatory step to making the animator such that the reverse animation can use it as well. Bug: 804539 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I69382950f1fcc7b62f0afe365b1f1d85293d8f25 Reviewed-on: https://chromium-review.googlesource.com/973612 Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by:
-
Peter Beverloo authored
The NotificationJobService needs to copy the data stored in a notification's PendingIntent to one that is safe to be used for starting a background job. It did so for most data members, but not for the scope. Bug: 824729 Change-Id: Ifbb7d8b22e15074545fd756a012f84f6a17b68e1 Reviewed-on: https://chromium-review.googlesource.com/975128 Commit-Queue: Peter Beverloo <peter@chromium.org> Commit-Queue: Peter Conn <peconn@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#545054}
-
Jérôme Lebel authored
This patch is to fix crrev.com/c/973303. The new method for GetAccessToken (without the secret client) needs to be the main method. And the old method needs to have a the fallback to the new one if it is still called. Related to crrev.com/i/480972 and crrev.com/c/973229. Bug: 516021 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I5086c2e26f8456a8a741072be2f46e0f90f8f91b Reviewed-on: https://chromium-review.googlesource.com/975127Reviewed-by:
-
Robert Liao authored
These textfields often return nothing. BUG=823532 Change-Id: I3e55d7c26ad46f065101ab8b5cf0fc3f085ae8f3 Reviewed-on: https://chromium-review.googlesource.com/974644 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
-
Robert Liao authored
This test contains an illegal thread join that likely impacts other platforms. Windows doesn't hit it because Windows does not yet DCHECK on thread joins on the UI thread. BUG=824570 Change-Id: If8e8f4b0620f6184986478c20eeef21fa68f749a Reviewed-on: https://chromium-review.googlesource.com/974569 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
-
