GitLab

Blink allows use of the //base histogram helpers, so switch away from
the Blink-specific histogram helpers and standardize on //base. The
long-term goal is to remove the Blink helpers, which differ from the
//base ones in some interesting and surprising ways.

Miscellaneous cleanup:
- use the histogram functions where appropriate (i.e. for metrics that
  aren't recorded on performance-critical paths)
- simplify enum histogram recording by changing the enum metric to be
  an enum class and defining kMaxValue where needed.

Bug: 742517, 1047547
Change-Id: I8db8405076975992a02efb8a73e6a692e3678d91
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2046534Reviewed-by: Adam Rice <ricea@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Auto-Submit: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#740764}

When the Permissions Prompt is dismissed due to navigation, the callback
passed to it may not be run. Due to the fact that this callback owns the
mojo RequestSessionCallback, that callback ends up getting dropped, and
then DCHECKs since the associated pipe is still open. This change causes
the SessionRequestData struct to attempt to run the callback when it is
destroyed.

Given that the exact reason for the callback being dropped is unknown, a
new generic error type is also introduced.

Bug: 1051228
Change-Id: Ib388c7c7a513759d373fed2af1a040adf9d3cd03
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050035Reviewed-by: Klaus Weidner <klausw@chromium.org>
Reviewed-by: Alex Gough <ajgo@chromium.org>
Commit-Queue: Alexander Cooper <alcooper@chromium.org>
Cr-Commit-Position: refs/heads/master@{#740763}

Change BatteryChargeMode default value from Standard to Adaptive.

BUG=b:147869098
TEST=chromeos_unittests && ash_unittests

Change-Id: I3163b5c16b54af23d5b3b29f2d779f97a07a0c5f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007410Reviewed-by: Jenny Zhang <jennyz@chromium.org>
Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Oleh Lamzin <lamzin@google.com>
Cr-Commit-Position: refs/heads/master@{#740762}

[Sheriff] Disable SignedExchangePrefetchBrowserTest.PrefetchMainResourceSXG_SignatureExpire on Linux TSan

Example flakes:
https://ci.chromium.org/p/chromium/builders/ci/Linux%20TSan%20Tests/50958
https://ci.chromium.org/p/chromium/builders/ci/Linux%20TSan%20Tests/50960

TBR=horo@chromium.org

Bug: 1050879
Change-Id: I2f03a1d714d06759947ce54847c2ec78bfe1dd0e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2052203Reviewed-by: Kristi Park <kristipark@chromium.org>
Commit-Queue: Kristi Park <kristipark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#740761}

This removes libevdev and gestures from third_party. Nobody should be
using these; they haven't been updated since being added 3 years ago.
Having them is causing confusion as we actually use these libraries via
sysroot (either Chrome SDK or Chrome OS chroot environment).

We can add them back later if we need them, but they need some
portability fixes before we can even do that (I tried rolling them first,
but they don't even compile with our compiler).

This reverts commit 968d2048.

Bug: 888172

Change-Id: I297ce60796225e32e947ef9977c8c63207f0a2fd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2048906
Commit-Queue: Michael Spang <spang@chromium.org>
Reviewed-by: Nicholas Verne <nverne@chromium.org>
Reviewed-by: Sean O'Brien <seobrien@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#740760}

Change-Id: I7f751a0fbfc049636a110b1edf0f5515ec1f6108
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2048275
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Charlie Reis <creis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#740759}

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/e54f66edc586..378c0f1b0817

git log e54f66edc586..378c0f1b0817 --date=short --first-parent --format='%ad %ae %s'
2020-02-12 jacktfranklin@chromium.org [Unittests] Add tests to `StaticContentProvider`
2020-02-12 tvanderlippe@chromium.org Add test for showing document storage values
2020-02-12 szuend@chromium.org [utilities] Replace {valuesArray} with {values} and/or spread operator
2020-02-12 tvanderlippe@chromium.org Migrate protocol_monitor/ to import cross-module
2020-02-12 tvanderlippe@chromium.org Migrate resources/ to import cross-module
2020-02-12 tvanderlippe@chromium.org Migrate security/ to import cross-module
2020-02-12 tvanderlippe@chromium.org Add test to verify multiple workers are shown as different entrypoints
2020-02-12 liviurau@chromium.org [doc] Updated branches handling

Created with:
  gclient setdep -r src/third_party/devtools-frontend/src@378c0f1b0817

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: chromium:1006759,chromium:1009443,chromium:1044632,chromium:1050549
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: I259d7e39d7a2c72b516794f299b77348c9bb88a7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2052187Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#740758}

This CL adds a crbug component and team mailing list for the Storage
Service. It also fixes the crbug component for //components/services.

Bug: 994911
Change-Id: I8c3448ca350e7534aba02336c09ea4065925725d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051814
Auto-Submit: Victor Costan <pwnall@chromium.org>
Commit-Queue: Ken Rockot <rockot@google.com>
Reviewed-by: Ken Rockot <rockot@google.com>
Cr-Commit-Position: refs/heads/master@{#740757}

The property aria-goog-editable was really added for a single odd case
in Google Slides, and isn't a great candidate for a new ARIA property.

It exists to avoid double speaking in NVDA with the tree view used for
Google Slides' thumbnail view. This issue goes away if the tree items
are not considered editable (they really aren't), but there is no
standard ARIA attribute to state that.

The reason the tree items need to inside a contenteditable is because
that enables pasting in slides to work. This also requires setting DOM
selection on each tree item / thumb.

The double speaking occurs because aria-activedescendant is also used to
point to the currently active tree item. This is necessary in order to
get more than just the selected text to be spoken -- to get the full
tree item treatment.

This CL removes aria-goog-editable, and instead clears IA2_STATE_EDITABLE
in the odd situation where an editor has a subwidget like a tree item or
list option, and the editor uses an active descendant.

The requirement for an active descendant on the editor means that a
subwidget can still be made editable in an HTML editor use case.

Bug: 1049746
Change-Id: Icd67b825b49712ac3fda7ba57f7ba93b4cd99a17
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042282
Commit-Queue: Aaron Leventhal <aleventhal@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Nektarios Paisios <nektar@chromium.org>
Auto-Submit: Aaron Leventhal <aleventhal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#740756}

https://android.googlesource.com/platform/external/perfetto.git/+log/7270d81dce8a..f440b92c2422

git log 7270d81dce8a..f440b92c2422 --date=short --first-parent --format='%ad %ae %s'
2020-02-12 fmayer@google.com Fix query for unsymbolized frames.
2020-02-12 treehugger-gerrit@google.com Merge "profiling: put proto enums into namespace"
2020-02-12 fmayer@google.com Merge "Improve error message when llvm-symbolizer is missing."
2020-02-12 skyostil@google.com Increase timeout for PerfettoTest.VeryLargePackets
2020-02-12 treehugger-gerrit@google.com Merge "traced_perf: add to android build by default (initially disabled)"

Created with:
  gclient setdep -r src/third_party/perfetto@f440b92c2422

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: perfetto-bugs@google.com
Change-Id: I0986ce588bdc4f87ab01d371d8249c4518e9a7cc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050730Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#740755}

The repro case creates an AudioWorkletNode after the ExecutionContext
goes away. (detached iframe) AudioWorkletNode is equipped with a
MessageChannel which requires a valid ExecutionContext.

AudioWorkletNode is not fully functional without message ports anyway,
so we can throw an exception in this case.

Test: Locally confirmed the ASAN build doesn't crash with the repro anymore.
Bug: 1050419
Change-Id: I52af9f877e2ad31923c6380dc0732eb6c97ab407
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051386Reviewed-by: Raymond Toy <rtoy@chromium.org>
Commit-Queue: Hongchan Choi <hongchan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#740754}

This reverts commit 9c078ea7.

Reason for revert: The fix isn't memory efficient enough.

Original change's description:
> [Printing] Write file to file descriptor directly on Android
> 
> Android's policy doesn't allow to exchange file ownership. It should be
> caught by our test but we don't have up-to-date bots setup in Chromium
> yet.
> 
> Bug: 1050064
> Change-Id: I26c82e538817e68fd49f40c0c7c414c5a76078b8
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2048271
> Commit-Queue: Shimi Zhang <ctzsm@chromium.org>
> Reviewed-by: Lei Zhang <thestig@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#740491}

TBR=thestig@chromium.org,ctzsm@chromium.org

Change-Id: Ie33bf740f4221072059e2cd82eedc53c1974286f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1050064
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2049836Reviewed-by: Shimi Zhang <ctzsm@chromium.org>
Commit-Queue: Shimi Zhang <ctzsm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#740753}

DrmOverlayValidatorTest calls MockDrmDevice::InitializeState one time in
SetUp and another in the test itself when the default crtc state needs
to change.
MockDrmDevice::InitializeState creates a new HardwareDisplayPlaneManager
every time it's initialized, which destructs all planes used by
ScreenManager controllers.

BUG=987274
TEST=DrmOverlayValidatorTest*

Change-Id: I42ef144377fb3b304573becd9be1467ad1636af3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051198Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
Commit-Queue: Mark Yacoub <markyacoub@google.com>
Auto-Submit: Mark Yacoub <markyacoub@google.com>
Cr-Commit-Position: refs/heads/master@{#740752}

Enables a virtual test for mouse-interactions-dsf-2.html on Mac.

Bug: 1009892
Change-Id: I0af1f4122fa1ef9519c21a01ec5f5e365558680b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2048849Reviewed-by: David Bokan <bokan@chromium.org>
Commit-Queue: Rahul Arakeri <arakeri@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#740751}

This reverts commit 786379ee.

Reason for revert: Broke "generate_build_files" step for 
release builders.

Original change's description:
> [proguard] Include proguard info in sourcefile attribute.
> 
> Instead of setting the sourcefile to PG when obfuscating Java, set it
> to :chromium:{mapping file}:{channel}:{version code} so that
> 
> a) We can recognise chrome/webview stack frames by this string
> b) The information required to uniquely identify the proguard mapping
>    file in question is directly available in stack traces.
> 
> Bug: 1044585
> Change-Id: Ib4fabccfb7693e5e97edc6f29be1cd6cb61fa1e6
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036091
> Commit-Queue: Tobias Sargeant <tobiasjs@chromium.org>
> Reviewed-by: Andrew Grieve <agrieve@chromium.org>
> Reviewed-by: Piotr Bialecki <bialpio@chromium.org>
> Reviewed-by: Richard Coles <torne@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#740625}

TBR=torne@chromium.org,agrieve@chromium.org,tobiasjs@chromium.org,bialpio@chromium.org

Change-Id: Iad5e489fbb13b1d9b89545bc648e94206e0c7c90
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1044585
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050022Reviewed-by: Brandon Wylie <wylieb@chromium.org>
Commit-Queue: Brandon Wylie <wylieb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#740750}

This CL prepares content_browsertests for when the feature is turned
on by default. The fix here is make DoesScrollbarScrollOnMainThread
rely on the base::Feature rather than just returning a hardcoded
value.

Bug: 1049814
Change-Id: I0055df6d1abcb31b928a7985dad7eecf7882ad7b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042762Reviewed-by: Daniel Libby <dlibby@microsoft.com>
Reviewed-by: David Bokan <bokan@chromium.org>
Commit-Queue: Rahul Arakeri <arakeri@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#740749}

Switching users can lead to a display reconfiguration.
We used reapply the current color temperature immediately
on display config changes with disregard to the possibility
of an on-going animation towards the same temperature.

As a result the target value was incorrectly set in the middle
of the animation, then the animation continues towards that
target value, resulting in a blue flash.

This CL fixes this issue.

BUG=999395
TEST=Manually, switch users (one with NL on, and the other off)
and see no blue flashes.

Change-Id: Ib41dadcd3e45defbc5b09f32d1a8c0c2aa49e5dd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051525Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: Ahmed Fakhry <afakhry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#740748}

https://chromium.googlesource.com/openscreen.git/+log/7d8b92dfc7b5..6b138fb083cf

git log 7d8b92dfc7b5..6b138fb083cf --date=short --first-parent --format='%ad %ae %s'
2020-02-12 jophba@chromium.org Fix linux-rel bot in Chromium autoroller
2020-02-12 miu@chromium.org Reland "Cast Streaming Sender: Introduce SenderPacketRouter."
2020-02-12 jophba@chromium.org Add IP address argument to standalone receiver
2020-02-12 jophba@chromium.org Cleanup ffmpeg, libsdl2 deps scripts
2020-02-11 btolsch@chromium.org Move WeakPtr to util/
2020-02-10 rwkeane@google.com Discovery E2E Test
2020-02-10 rwkeane@google.com mDNS: Address Top-Level Threading Concerns
2020-02-10 mfoltz@chromium.org Revert "Cast Streaming Sender: Introduce SenderPacketRouter."
2020-02-08 miu@chromium.org Cast Streaming Sender: Introduce SenderPacketRouter.
2020-02-07 mfoltz@chromium.org [Open Screen] Allow PlatformClientPosix to take a TaskRunner.

Created with:
  gclient setdep -r src/third_party/openscreen/src@6b138fb083cf

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/openscreen-chromium
Please CC jophba@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: jophba@chromium.org
Change-Id: Ia89bb09d41636400b3df8c2aecc9c8c1caebbd5c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051712Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#740747}

while at it i removed tabModel mentions from perf_test_with_bvc_ios
Also i deleted tests from tab_model_unittest that are sessions related
and moved the one related to NTP to session_restoration_agent_unittest,
however it's disabled as it needs to be converted to eg test.

Bug: 1050110, 1045226, 1049843
Change-Id: I84e137efa14258bed002094ad87dd0db6ca7ea74
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2045759Reviewed-by: Mark Cogan <marq@chromium.org>
Commit-Queue: Mohammad Refaat <mrefaat@chromium.org>
Cr-Commit-Position: refs/heads/master@{#740746}

Adding trace events for the database functions.

SQLite is suspected to have higher impact on IO than previously
expected. We are suspecting LockFile contention and Flush
contention.

Adding these trace events will help seeing the interaction
between these tasks and other tasks in chrome via slow-reports.

Bug: 1051180
Change-Id: Ife21c619bd8fafc6e892d6e9d45818d0813018c5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050167
Commit-Queue: Etienne Bergeron <etienneb@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#740745}

https://chromium.googlesource.com/chromiumos/platform2/system_api.git/+log/0024e74067a1..b2cdc6cc701d

$ git log 0024e7406..b2cdc6cc7 --date=short --no-merges --format='%ad %ae %s'
2020-02-05 kevinptt runtime_probe: Add network-related fields in protos
2019-12-18 cylai system_api: remove SetSystemSalt from attestation
2020-01-14 dverkamp system_api: vm_concierge: add ResizeDiskImage method
2020-01-16 andrewlassalle dlcservice: Move the definition of kDlcMetadataRootpath
2020-02-06 enshuo system_api: Add CRAS battery changed constants
2020-01-07 garrick system_api: Add plugin vm messages for patchpanel.
2020-02-05 dtor system_api: vm_concierge: add option to generate digest when exporting a VM

Created with:
  roll-dep src/third_party/cros_system_api

Bug: chromium:785758,b:140783217
Change-Id: I7ce344da4b20102ce809439b4e6c7d50d4fde265
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051791
Auto-Submit: En-Shuo Hsu <enshuo@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#740744}

Previously, an element could be removed from the current_render_widget_set_
while still observing it, which would cause a crash after the
WebContentController was destroyed.

Bug: b/149197915
Change-Id: I830c5caba702ce2d9e94a33c669cf05cb2d354a4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050009
Commit-Queue: Kevin Schoedel <kpschoedel@chromium.org>
Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
Cr-Commit-Position: refs/heads/master@{#740743}

This reverts commit d22ad89d.

Reason for revert: Crashes in SetProbeSuccess()

Original change's description:
> Track DoH probe results per-context
>
> DoH probes are now run for every created NetworkContext.
>
> Swap to using per-context DoH probe results stored in the
> ResolveContext and delete old probe result tracking in DnsSession. Some
> interfacing back to DnsSession where we're still storing non-probe
> failure tracking and ServerStats, but that will be moving over to
> ResolveContext too in a subsequent CL.
>
> Bug: 1022059
> Change-Id: Ib2db72340f9fc5dd5b0ec0024f1cef60f1ba7465
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001144
> Reviewed-by: Matt Menke <mmenke@chromium.org>
> Commit-Queue: Eric Orth <ericorth@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#740422}

TBR=mmenke@chromium.org,ericorth@chromium.org

Change-Id: Icb3267ae7e433d2609898032c21ed9f6398a96a6
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1022059,1051399
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050749
Commit-Queue: Eric Orth <ericorth@chromium.org>
Reviewed-by: Eric Orth <ericorth@chromium.org>
Cr-Commit-Position: refs/heads/master@{#740742}

Introduce key overrides for existing cached values in SharedPrefs so
the behavior does not change. These overrides can be removed when all
variations using it are removed.

Bug: 1012975
Change-Id: Ie392f3bb830a082dbb2a736efad3fa492653e230
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2044921
Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#740741}

https://skia.googlesource.com/skia.git/+log/125d3820d6b5..55b137ca7dd9

git log 125d3820d6b5..55b137ca7dd9 --date=short --first-parent --format='%ad %ae %s'
2020-02-12 jvanverth@google.com More tweaks to iOS build instructions.
2020-02-12 egdaniel@google.com Update generated effects to use views.
2020-02-12 herb@google.com Simplify SkStrike ctor
2020-02-12 nihohit@gmail.com This change allows users of PropertyObserver to compose a full keypath for each of the modified properties.

Created with:
  gclient setdep -r src/third_party/skia@55b137ca7dd9

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC stani@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: stani@google.com
Change-Id: I4b8c178e107d58f184040543655b6e4a1698e334
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2052093Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#740740}

This is a reland of ae806eaa

Original change's description:
> Refactor extended crash reporting initialization.
> 
> Bug: 1044707
> Change-Id: I51ae9d5fd4d0972f9145927d265f36cef3a4e98c
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037711
> Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org>
> Reviewed-by: Brian White <bcwhite@chromium.org>
> Reviewed-by: François Doray <fdoray@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#740420}

Bug: 1044707
Change-Id: Ib665bb0b3e4e5ad83c2f2a9bf6a1ea8c552d894c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051194Reviewed-by: Brian White <bcwhite@chromium.org>
Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#740739}

CityHash has some known defects, but there are various things that
depend on using this specific version of CityHash

Rather than exposing this directly from //third_party/smhasher, move
the entry point to the base::legacy namespace and begin documenting
best practices for hashes.

Bug: 902789
Change-Id: I6af900ddbb5511e8d38700209b2ff5ac4bab10cc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594477Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#740738}

Trybot linux_layout_tests_composite_after_paint runs almost all web
tests. Any change of web_tests may cause change of test results of
the bot. Trigger the bot to ensure no breakage of it.

This will increase the load of the bot from about 10-20 runs/day to
20-30 runs per day. Because the bot shares with other high load bots
(e.g. linux-rel) in a big pool of 580 bots which support thousands runs
per day, the increase will be trivial.

Change-Id: Ibc80588372356ba88a7cafd2a829c2c2ec7884aa
Bug: 524134
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050326Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#740737}

Fix error message for device_only flag in policy presubmit.

BUG=none
TEST=none

Change-Id: I4c1b50f6257de6054b2308ca72872ae4de335a81
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051270Reviewed-by: Alexander Hendrich <hendrich@chromium.org>
Reviewed-by: Amr Aboelkher <amraboelkher@google.com>
Commit-Queue: Oleh Lamzin <lamzin@google.com>
Cr-Commit-Position: refs/heads/master@{#740736}

Bug: 1044038
Change-Id: Ia814046bba4698759b865993bde7c9dadaee52f0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051276Reviewed-by: Marc Treib <treib@chromium.org>
Reviewed-by: Friedrich [CET] <fhorschig@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
Cr-Commit-Position: refs/heads/master@{#740735}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/889e8e57..16cb8948

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: Ia40fb22c3c8636a8e88bdca9e35c208be695e822
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051197Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#740734}

Reader mode only shows in the menu on distillable pages, or
pages which have already been distilled.

Also fixes reader mode string in Mac to match other platforms
(should be "Toggle reader mode / Toggle Reader Mode in title
case).

Bug: 1050798,1016611
Change-Id: I7b2981fa77bc5793428ac54c5ce2069c44e61c93
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2047975Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Katie Dektar <katie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#740733}

This patch embeds the UserConsentViewController into the sign-in view
host. Interactivity and consent buttons will be added separately.

This CL is part of a series of refactors to move the existing sign-in
architecture to the Coordinator-Mediator design paradigm.

Fore more information, see go/chrome-ios-signin-migration.

Bug: 971989
Change-Id: Ie0e87842036c68a72aed2a404dfe6a98a1d8cae5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041599
Commit-Queue: Nohemi Fernandez <fernandex@chromium.org>
Reviewed-by: Jérôme Lebel <jlebel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#740732}

This CL makes sure that whitelisted web app
opened in a tab will not be blocked when web
time limit is reached.

Bug: 1015661
Change-Id: If9ab8bfe5fe51a58e256ee129ee0ba1257d3032d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2048024
Commit-Queue: Yilkal Abe <yilkal@chromium.org>
Reviewed-by: Aga Wronska <agawronska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#740731}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/cb8992a734b2..5dcdb89598ea

git log cb8992a734b2..5dcdb89598ea --date=short --first-parent --format='%ad %ae %s'
2020-02-11 cjmcdonald@chromium.org Reland: Remove ChrootPaths class

Created with:
  gclient setdep -r src/third_party/chromite@5dcdb89598ea

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromite-chromium-autoroll
Please CC chrome-os-gardeners@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:chromeos-kevin-rel
Bug: None
Tbr: chrome-os-gardeners@google.com
Change-Id: I35c54fd49a64acaa40f745c9d360a5134599c9f7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2052087Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#740730}

Prior to switching IPC over to Mojo, the RenderView ID was sufficient.
With Mojo IPC, the connection to the PrerenderProcessor is RenderFrame
local via BrowserInterfaceBroker. This means we have to worry about the
case where the top-frame is out-of-process relative to the child frame
is generating prefetch hints.

The solution is to plumb the WebLocalFrame through WillAddPrerender.
This enables the chrome/renderer/prerender/ code to know which frame is
making the request, and it can use that frame's BrowserInterfaceBroker
to talk to the PrerenderProcessor.

The CL https://chromium-review.googlesource.com/c/chromium/src/+/2042139
will eliminate WillAddPrerender without re-introducing this bug.

Bug: 1050429
Change-Id: I47ea17af034c1b379489d23c53713346b4311dae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051144Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Commit-Queue: Darin Fisher <darin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#740729}

Fix use after move inside BrowserDesktopWindowTreeHostWin::Init.
Moving const & param to other const & param function has no effect.

Change-Id: Ie3d41c680b4edd5ff225e55aedd709ba1a01d92b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051929
Commit-Queue: Bret Sepulveda <bsep@chromium.org>
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#740728}

This result now records metrics and events correctly instead of passing
as a SUCCESS result.

Bug: 1049712
Change-Id: Ic104d271e53c13d0b78942dfb57effe59e1ef522
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042216Reviewed-by: Daniel Rubery <drubery@chromium.org>
Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#740727}

Bug: 1050094
Change-Id: I971bc0bc091b5a32684518ecb14f9527267df1f4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050012
Commit-Queue: Justin DeWitt <dewittj@chromium.org>
Auto-Submit: Sky Malice <skym@chromium.org>
Reviewed-by: Justin DeWitt <dewittj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#740726}

This seems to work now.

Probably fixed by https://reviews.llvm.org/D73374
(see also issue 1045291).

Bug: 426868,1045291
Change-Id: I327d06c7a3357970a09fcc725c0d1d080e5b1a3c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050803Reviewed-by: Hans Wennborg <hans@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#740725}