- 13 Oct, 2020 40 commits
-
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8567edac4fdf..c0568abaca2d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC tnagel@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: tnagel@google.com Change-Id: I39cf9325ed7a8af8e312cd0928b5313a41f0d45c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466922Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#816639}
-
Dave Tapuska authored
These histograms are now logged inside blink and the appropriate tests should move as well. BUG=1097816 Change-Id: Ic84798cf223bf0dafe73bd813952d6678ba066aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461986 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#816638}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Ie167bdcfa494f7b6a7aaa0345c245167fcc9cded Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466732Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#816637}
-
Anthony Vallee-Dubois authored
1/ RemoteCommandsInvalidator needs its Shutdown method called before destruction. 2/ RemoteCommandsInvalidator calls Start() itself after initialization is complete, no need to call it manually. Bug: 1137832 Change-Id: I4a76369100c2bc1d599ddb8b43fc055d6fd301d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463715Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: anthonyvd <anthonyvd@chromium.org> Cr-Commit-Position: refs/heads/master@{#816636}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/4fe1d403a22d..7c9f31beb6db 2020-10-13 inglorion@chromium.org cros_sdk: inform and raise vm.max_map_count if too low 2020-10-12 saklein@chromium.org Revert "deploy: Refactor SplitCPV to parse." 2020-10-12 saklein@chromium.org api/tutorials: Add part 4, faux decorators. 2020-10-12 jettrink@chromium.org build_api: add handlers for tot fw builder API 2020-10-12 jettrink@chromium.org generate: initial commit of firmware proto file 2020-10-12 manojgupta@chromium.org config_lib.py: Add hwtests for trogdor64 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel Tbr: chrome-os-gardeners@google.com Change-Id: If4857d6142f47d4d1db7674cfd5c220aa8701837 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466929Reviewed-by:
-
Joon Ahn authored
Obtained via `wget https://unpkg.com/d3@5.16.0/` on corp network Bug: 1136195 Change-Id: I786c7a1e6a21f84392d455d15feeba5011cf231d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2458847Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Commit-Queue: Joon Ahn <joonbug@chromium.org> Cr-Commit-Position: refs/heads/master@{#816634}
-
Roman Sorokin authored
Fixes the issue when the user does not have the stored hour clock type preference - it uses the previous user preference. Bug: b/168759134 Change-Id: I415b85456dd578ac0565b42c819ef9d0b3590d94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443009Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Auto-Submit: Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#816633}
-
Chris Lu authored
Removes all confirm Messages and any unused classes from the legacy implementation. Bug: 1024288, 961343 Change-Id: I60ac68d040e33b08b677665670186631054d37ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416940 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#816632}
-
Weiliang Chen authored
When the display compositor is offscreen, and the passed in surface handle is null, return a stub class for overlay processor. This removes enable_overlay and could_overlay bools from other overlay processor classes. R=Khushal Bug: 898680 Change-Id: I75f72ba3dfabcc3ab0e2fe80509bb6cad7a74910 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446463Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
Maggie Chen <magchen@chromium.org> Commit-Queue: weiliangc <weiliangc@chromium.org> Cr-Commit-Position: refs/heads/master@{#816631}
-
Hitoshi Yoshida authored
A flag to check if a new RenderFrameHost is really new in WebTestControlHost::HandleNewRenderFrameHost(), we check if its RenderViewHost is already contained in |main_window_render_view_hosts_|. This detection is based on our past design that we don't delete RenderViewHosts in a web test, and we don't erase entries of |main_window_render_view_hosts_|. But it can happen if we start to swap RenderFrameHosts and RenderViewHosts with Browsing Instance Swap and/or Back-Forward Cache. After deleting an old RenderViewHost, a new RenderViewHost can be created on the address where the old one was allocated. This address conflict can lead a misjudge of the check of new RenderFrameHosts. This CL handles delete events of RenderViewHosts for main windows on WebTestControlHost, and removes their addresses from the list. Bug: 1136383, 1132180 Change-Id: I442ad67d2207a822dec37fb676d623dd035f0b9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462997 Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/master@{#816630}
-
Siyu An authored
In browsertests we don't wait for the bubble to be actually shown before verifying the view. Fix it by having the tests wait for extra events. Bug: 1133332 Change-Id: I898ae939a7b604dff6d170d54d136566ad34799f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464025 Commit-Queue: Siyu An <siyua@chromium.org> Reviewed-by:
Christoph Schwering <schwering@google.com> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#816629}
-
Xiaocheng Hu authored
crrev.com/c/2415244 introduced a new runtime flag for 'advance-override' but didn't properly handle it in the parser. As a result, the descriptor is leaked to web. This patch fixes the parser to make sure it's properly hidden behind the flag. Bug: 1137624 Change-Id: I69f161932aede553b1cb31b181187e687eba1df0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466979Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#816628}
-
Morten Stenshorne authored
As part of bug 800764 I'm working on getting rid of BUILD.gn files in core sub-directories, and merge (almost) everything into one large core target. This was the only fuzzer whose target wasn't defined in core/BUILD.gn, so I moved it there. Bug: 800764 Change-Id: I468dc316795a2cc4e17fe424e35c7fea8da1de21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2467856Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#816627}
-
Lan Wei authored
When we are using gpuBenchmarking.PointerActionSequence to simulate three mouse click, it only set the click count to 2, not 3. It should keep the mouse click count and decide if we should increase the count or set to 1 when we have a mouse press based on the interval of two mouse presses and difference between the current mouse positions and the last one. Bug: 1119679 Change-Id: If95c4da4aa62ae897204badfe1b1035f5240e0c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446637Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#816626}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/4159ffc366a3..320cf8513172 2020-10-13 bmeurer@chromium.org [third_party] Roll wasmparser 3.2.0 2020-10-13 sigurds@chromium.org Refactor static member to proper accessors 2020-10-13 tvanderlippe@chromium.org Use Node module resolution for tests If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1135143 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I7cbe3e1f1e9164262e138fb983cd34d2534d9512 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468138Reviewed-by:
-
Alexandre Courbot authored
BUG=b:153935975 TEST=Chromium builds for arm-generic. Change-Id: I633a3b6df23fc097920dc1101fd08bc89ed71e90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2460753 Auto-Submit: Alexandre Courbot <acourbot@chromium.org> Commit-Queue: Fritz Koenig <frkoenig@chromium.org> Reviewed-by:
Fritz Koenig <frkoenig@chromium.org> Cr-Commit-Position: refs/heads/master@{#816624}
-
Zhaoyang Li authored
This is duplicated to the same config set in build/config/BUILDCONFIG.gn causing 2 sets of coverage compiler flags in compile command. Bug: 1137569 Change-Id: Ic4f712ff098e6e8b036576782d5f1a09f693da32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463853Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org> Cr-Commit-Position: refs/heads/master@{#816623}
-
David Black authored
This reverts commit bbf55256. Reason for revert: Better fix in: https://chromium-review.googlesource.com/c/chromium/src/+/2468338 Original change's description: > Handle ChromeVox Search + Space to "press" holding space items. > > Search + Space propagates to the view as mouse events. Unfortunately we > can't tell from the mouse event if the event was created by ChromeVox > but its good enough to just check if ChromeVox is enabled. > > Bug: 1137039 > Change-Id: I0ed18774632b0e46bf6100d86a27abbf5df29f85 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466165 > Reviewed-by: Ahmed Mehfooz <amehfooz@chromium.org> > Commit-Queue: David Black <dmblack@google.com> > Cr-Commit-Position: refs/heads/master@{#816340} TBR=dmblack@google.com,amehfooz@chromium.org Change-Id: Ic438b2da85cceb76d66521e11c5520787e456dee No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1137039 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468339Reviewed-by:
David Black <dmblack@google.com> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#816622}
-
Ian Barkley-Yeung authored
This will control a feature which will send reports if the JavaScript on a WebUI surface has a serious error, such as an unhandled exception. Following instruction from go/finch-feature-api Launch bug: https://crbug.com/1134416 Bug: chromium:1121816 Change-Id: Iaf2ac7935bf0546a9d1cc3709448ab5695b62196 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462487Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Ian Barkley-Yeung <iby@chromium.org> Cr-Commit-Position: refs/heads/master@{#816621}
-
ssid authored
This reverts commit 989724c3. Reason for revert: Fixing test failures. The msan failures were due to hash operator trying to hash uninitialized padded bytes of the struct. Fix the struct to not have any padding. Original change's description: > Revert "[tracing] Remove special handling of task execution and log events" > > This reverts commit f79b1513. > > Reason for revert: Breaks WebKit Linux MSAN > > The following tests started failing since this landed: > > * http/tests/devtools/tracing.js > * http/tests/devtools/tracing/decode-resize.js > * http/tests/devtools/tracing/timeline-paint/update-layer-tree.js > * http/tests/devtools/tracing/timeline-style/parse-author-style-sheet.js > * http/tests/devtools/tracing/tracing-record-input-events.js > * http/tests/devtools/tracing/user-timing.js > * http/tests/devtools/tracing/worker-events.js > * http/tests/devtools/tracing/worker-js-frames.js > * inspector-protocol/sessions/tracing-start.js > * inspector-protocol/timeline/tracing-proto-format.js > > First run that failed, also the run where the CL landed: > https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Linux%20MSAN/7830 > > Original change's description: > > [tracing] Remove special handling of task execution and log events > > > > The task execution and log events are handled specially for writing > > proto arguments because we did not have the support for typed events in > > base and interning support for the event macros. Now these events can > > use the new client library API. > > The events have to be migrated together because the source location > > interning index is common for all events in the API and does not > > account for the special handling in event sink. > > > > BUG=1136635 > > TBR=chirantan@chromium.org > > > > Change-Id: I381e8c90e49c3fbd9ce4d8fb2e9db3d166b9b06d > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462636 > > Reviewed-by: ssid <ssid@chromium.org> > > Reviewed-by: Sami Kyöstilä <skyostil@chromium.org> > > Reviewed-by: danakj <danakj@chromium.org> > > Reviewed-by: Erik Chen <erikchen@chromium.org> > > Reviewed-by: Eric Seckler <eseckler@chromium.org> > > Commit-Queue: ssid <ssid@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#815911} > > TBR=danakj@chromium.org,chirantan@chromium.org,erikchen@chromium.org,skyostil@chromium.org,ssid@chromium.org,eseckler@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 1136635 > Change-Id: I7a84356400bbdcae3144fd65afdcab7a4407dcd9 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462895 > Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org> > Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> > Cr-Commit-Position: refs/heads/master@{#816069} TBR=danakj@chromium.org,chirantan@chromium.org,erikchen@chromium.org,skyostil@chromium.org,ssid@chromium.org,ortuno@chromium.org,eseckler@chromium.org # Not skipping CQ checks because this is a reland. Bug: 1136635 Change-Id: Ia659185ebeb265dc47ff6c2ef47bd9d8cc43dd65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466507Reviewed-by:
Eric Seckler <eseckler@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
ssid <ssid@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Commit-Queue: ssid <ssid@chromium.org> Cr-Commit-Position: refs/heads/master@{#816620}
-
Xiyuan Xia authored
- Add a CustomReportData struct to report data for kCustom typed FrameSequenceTracker to include jank_count as part of the report; - Update the report code path, changing from ThroughputData by value to CustomReportData by const reference; - Update autotest private api to use the new struct and report jank_count as part of animation metrics data; Bug: 1132017 Change-Id: I30d932c2e64a0e2e0e2f3c99afa4918fc38d97b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465872Reviewed-by:
Jun Mukai <mukai@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#816619}
-
George Burgess IV authored
This new clang-tidy check complains when param names /*in_comments=*/ don't match up with the actual parameter name they're being passed to. Sometimes this is benign, other times, actual bugs are found. Since callees and the definition used `quad_layer_rect` here, flip the decl to use that, too. Bug: 1136209 Change-Id: Ifb6a7e11d2816f1d05f5403b77af8382e605467b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2458892Reviewed-by:
Jonathan Backer <backer@chromium.org> Commit-Queue: George Burgess <gbiv@chromium.org> Cr-Commit-Position: refs/heads/master@{#816618}
-
David Tseng authored
AX-Relnotes: n/a Change-Id: If9025b31fb1fceb89e4c691cc89f632eca632de8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466137Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#816617}
-
Victor Hugo Vianna Silva authored
ConstructAboutInformation() gathers debugging information about the sync state. It's employed both to power the sync-internals page - a debugging page only accessible locally - as well as to compose logs sent to Google in case of crashes (provided the user has agreed to this). For the latter use case, the caller used to manually filter a section containing PII, for privacy. Delegating this responsibility to the caller was bad since the return value is quite "weakly typed" (base::DictionaryValue). This meant that one might easily add new sensitive information to the return value while forgetting to update the filter in the caller. In this CL we transfer this responsibility to the method, by exposing an include_sensitive_data parameter. Additionally, we now force the constructor of a "section" to specify whether it is sensitive or not. This last part makes the code more privacy-aware, which should make it less likely to accidentally leak any data (even if this solution isn't bullet-proof). Bug: 973820 Change-Id: I99138a741c26755e138ac0a60dd08815aa90a10c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2467939 Commit-Queue: Victor Vianna <victorvianna@google.com> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#816616}
-
Victor Hugo Vianna Silva authored
See the linked bug for the renaming rationale. Fixed: 1103583 Change-Id: Ifcb673542ec3514f30c811ce0edac7dc048cd846 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468117 Commit-Queue: Victor Vianna <victorvianna@google.com> Commit-Queue: Marc Treib <treib@chromium.org> Auto-Submit: Victor Vianna <victorvianna@google.com> Reviewed-by:
-
Jeff Yoon authored
mac_upload_clang had set static version of xcode to use. This change removes these static properties such that it uses a version of xcode calculated from the OS in the osx_sdk recipe module. Bug: 1137520 Change-Id: Ia184c03abad326656989402655645938437d37e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468236 Commit-Queue: Jeff Yoon <jeffyoon@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#816614}
-
Marc Treib authored
ServerConnectionManager (and its implementations, plus some related helper classes) returned an HttpResponse as an output parameter. Output parameters are generally discouraged, and here in particular, they made the logic hard to follow since the whole thing went through many layers. Before this CL, the methods in question returned a bool that roughly meant "success", but it was inconsistent (in some layers, an HTTP error would be counted as success, in others as failure). Now, they return the HttpResponse instead. Clients now query the "success" they're interested in from the HttpResponse. Bug: 951350 Change-Id: Idd7867246506caf069287e4dc34c8b59a1da59fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465910 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#816613}
-
Dominique Fauteux-Chapleau authored
This is a reland of crrev.com/c/2412693 This should not change deep scanning behaviour with Connectors. The corresponding enums are kept until crbug.com/1109242 is fixed. Removing these policies completely is safe since they were marked as future and they have only been delivered as cloud policies. Bug: 1103390 Change-Id: Ia0fd596313b15f20efd24958326a77da3342b485 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463446Reviewed-by:
Daniel Rubery <drubery@chromium.org> Reviewed-by:
-
Chris Sharp authored
Bug: 1018157 Change-Id: I3b72659190a78405f3201c85ad2cfe2672413ea9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2456038 Commit-Queue: Chris Sharp <csharp@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#816611}
-
Daniel Clark authored
The non-virtual version of external/wpt/html/semantics/scripting-1/the-script-element/json-module/json-module-service-worker-test.https.tentative fails by-design without --enable-features=JSONModules, but it's missing the expectations file for this failure and is instead disabled in TestExpectations. This CR adds the expectations file so that the disable in VirtualTestSuites can be removed, and crbug.com/967018, which is actually the implementation bug for Synthetic Modules, can be resolved (which should have happened a while back when we finished that feature). Bug: 967018 Change-Id: I8046fc66861e077f5d5d9515118f19ac768aec0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466204Reviewed-by:
-
Tanmoy Mollik authored
Test that signed in account is shown at the top of the list of accounts in AccountManagementFragment page. Bug: 1105800 Change-Id: I4990400862acf4b794f205062b47acc46365fbb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465747Reviewed-by:
-
chromium-internal-autoroll authored
Release_Notes: http://go/help_app-x20/relnotes/Main/help_app_nightly_202010130700_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/help_app/app/+/T-N5zwsSNhguTsU3uUhXyI74IImSdHGJ-z8uc9QLdUsC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/help-app-chromium-autoroll Please CC help-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: help-app@grotations.appspotmail.com Change-Id: I51048d21e10493a45147ece8a6ad51550a1b0ec7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466927Reviewed-by:
-
Muyao Xu authored
Bug: b/165366974, 1117673 Change-Id: Ieec1543d9fb6cd5a6e77d5790ee4c2138174b305 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466388Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Commit-Queue: Muyao Xu <muyaoxu@google.com> Cr-Commit-Position: refs/heads/master@{#816607}
-
Kyle Horimoto authored
These classes were in //chrome, making them inaccessible to tests that are not also in //chrome due to dependency issues. This CL moves them to //chromeos/services/nearby, alongside their associated .mojom definitions. These mocks are used in a follow-up CL to implement tests. This CL also initializes a SharedRemote associated with these classes and a getter to retrieve a reference to the SharedRemote. Bug: 1130069 Change-Id: I1bb87403a64a17c5b6f4da1b9f9daaf3ce414d64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464844Reviewed-by:
James Vecore <vecore@google.com> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#816606}
-
chromium-autoroll authored
Roll ChromeOS Orderfiles from 87-4265.0-1601890590-benchmark-87.0.4280.16-r1 to 87-4277.0-1602498224-benchmark-87.0.4280.18-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-orderfile-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: Id9b4cc97108e0099d712b1243560ae4cb70538d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468196Reviewed-by:
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/afdo-chromium-autoroll Please CC gbiv@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: gbiv@chromium.org Change-Id: Iaa9c8d0ab9bbbc7ccb61248483c1bd907771fe4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468141Reviewed-by:
-
Benoit Lize authored
The thread cache is disabled on Windows, as TLS is not implemented there. Add a Windows TLS implementation, and enable the thread cache. Bug: 998048 Change-Id: Ia9d90d5d5e78611e00e6456a770bdf00f44bb773 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426323 Commit-Queue: Benoit L <lizeb@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#816603}
-
Adam Langley authored
When a GMSCore FIDO operation fails, it'll return a non-zero status and null for the other parameters. This change causes the null byte arrays to be translated into empty spans rather than crashing. BUG=1002262 Change-Id: Idc3cb81e4ef17216634677e1d595b7357f2fb70e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463807 Commit-Queue: Adam Langley <agl@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#816602}
-
chinsenj authored
When a user fine tunes their capture region, it's useful to have more precision. This CL adds a magnifying glass to the capture region to address this. Test: manual + added test. Fixed: 1133751 Change-Id: I24f9652d1f97b2fbf29da6b771c6cc465b36d4dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453772 Commit-Queue: Jeremy Chinsen <chinsenj@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#816601}
-
chromium-internal-autoroll authored
Release_Notes: http://go/media_app-x20/relnotes/Main/media_app_202010130700_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/fMicjS5JtS2sakj0BWcnD-WvPzJtgucl2EnBXFOBEnQC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/media-app-chromium-autoroll Please CC media-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome;luci.chrome.try:linux-chromeos-chrome-easwa Bug: b/159848445 Tbr: media-app@grotations.appspotmail.com Change-Id: I6c506c5a13cafb922b74971f2d249a6ec8a56c71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2467237Reviewed-by:
-
