- 11 Apr, 2020 33 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/07e64e6eeffc..6812621f27e9 git log 07e64e6eeffc..6812621f27e9 --date=short --first-parent --format='%ad %ae %s' 2020-04-11 jophba@chromium.org Upgrade ARM64 bot configuration Created with: gclient setdep -r src/third_party/openscreen/src@6812621f27e9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: jophba@chromium.org Change-Id: Id5db5d3ea77b3bf5c6897c68aa170dd0afd5f61e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146338Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#758390}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/daf94c56bcb3..459ecee2cbdc git log daf94c56bcb3..459ecee2cbdc --date=short --first-parent --format='%ad %ae %s' 2020-04-11 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update Go Deps Created with: gclient setdep -r src/third_party/skia@459ecee2cbdc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC csmartdalton@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: csmartdalton@google.com Change-Id: I5793cd915a6abedc56b0a12f6bd92354ad5ecd75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146336Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/868bd943887c..1d4198aab5e3 Created with: gclient setdep -r src-internal@1d4198aab5e3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC nhiroki@google.com,reillyg@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1058152 Tbr: nhiroki@google.com,reillyg@google.com Change-Id: I0c346e80bdd7cf58b5a6ecc8f05bc54c11b31dc1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146327Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#758388}
-
Yuki Shiino authored
This patch adds [Exposed=Window] IDL extended attribute to the IDL interface definitions that are missing the extended attribute. The necessity of [Exposed] is determined by the current behavior regardless of what each web spec specifies. In a follow-up patch, the bindings generator will be fixed so that it won't expose IDL interfaces unless [Exposed] is specified. Bug: 839389 Change-Id: Ib2cdb8801d1e3648c2e41d16617c41171fda0005 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143173Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#758387}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/8da8c788..a9439a50 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I446d54418dbda6e997ddb394e8c3e865b7a384ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143866Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#758386}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/b36549d189fb..8fb658105806 git log b36549d189fb..8fb658105806 --date=short --first-parent --format='%ad %ae %s' 2020-04-11 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. Created with: gclient setdep -r src/third_party/devtools-frontend/src@8fb658105806 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I23afe6a050dc7a6482b61614d0c7120115fe553e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146329Reviewed-by:
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/8619cbe2379c..5b7292c8f8e2 git log 8619cbe2379c..5b7292c8f8e2 --date=short --first-parent --format='%ad %ae %s' 2020-04-11 zmo@chromium.org Fix more compilation warnings. Created with: gclient setdep -r src/third_party/dawn@5b7292c8f8e2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: chromium:1064305 Tbr: cwallez@google.com Change-Id: I7e4cbdfbe5f52a3b3c494800e2c27a4198e0b03e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146322Reviewed-by:
-
Dominic Mazzoni authored
I was so confused as to why these tests had wrong expectations compared to what output they gave locally. Then I finally figured out that they were disabled in a totally different file. Bug: none Change-Id: Ia418e732e27f944731670ca64ed0c881f97f15e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145753 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Mark Schillaci <mschillaci@google.com> Cr-Commit-Position: refs/heads/master@{#758383}
-
jameshollyer authored
Recent changes to pointer lock requests(https://crrev.com/c/2069199) caused an error in logic which allowed requests made while not in focus to be able to succeed. This meant that a request made while changing focus would cause a strange state. I also added an earlier check for focus so that we error out before reaching the browser. Bug: 1068339 Change-Id: If706d2a693ca6a9aa2a8cf6c85ed622b429b97fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138501Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Commit-Queue: James Hollyer <jameshollyer@chromium.org> Cr-Commit-Position: refs/heads/master@{#758382}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/da1fe3609158..868bd943887c Created with: gclient setdep -r src-internal@868bd943887c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC nhiroki@google.com,reillyg@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1067290 Tbr: nhiroki@google.com,reillyg@google.com Change-Id: I484ced4bf76cdfcf7a0d608012be7b3eac5fecea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146316Reviewed-by:
-
rbpotter authored
Bug: 829414 Change-Id: Ib5d24dab8540513e1f5179c3c0914c4572395980 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975305 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#758380}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/c0d7928ef7b0..b8b3f5ffc0ea git log c0d7928ef7b0..b8b3f5ffc0ea --date=short --first-parent --format='%ad %ae %s' 2020-04-11 nigi@chromium.org Update pixel/corpus tests to handle expected results for Skia. Created with: gclient setdep -r src/third_party/pdfium@b8b3f5ffc0ea If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: pdfium-deps-rolls@chromium.org Change-Id: Ie4b4bf5a51b27fd311e37b214612f5668d6ecbaf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146110Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I5a9dcb95a981990497a4264d9fc4cea4ea08755e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146314Reviewed-by:
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/afdo-chromium-autoroll Please CC gbiv@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: gbiv@chromium.org Change-Id: Ic963ff48b5a18849b5a2a6acab3d88219c769a00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146320Reviewed-by:
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=mmoss@chromium.org Change-Id: I9a5464835ef17d3f723ed11b70d0830d77251781 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146113Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#758376}
-
Bruce Dawson authored
google.com, not chromium.org. Change-Id: Ic89c09bb251d09635f4d164706c8cc17984f7e2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145089Reviewed-by:
Jesse McKenna <jessemckenna@google.com> Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#758375}
-
Krishna Govind authored
TBR=benmason@chromium.org Change-Id: I6bee4ae4c054e265162d7165fd0ae8cce4151151 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145686Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#758374}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a07910e9e064..da1fe3609158 Created with: gclient setdep -r src-internal@da1fe3609158 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC nhiroki@google.com,reillyg@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:790886 Tbr: nhiroki@google.com,reillyg@google.com Change-Id: I29f3e272f4fe3931861509b7b15e910ffc70c8a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146100Reviewed-by:
-
Jimmy Gong authored
- Fixes a regression where the learn more link was referencing a bad URL. Bug: 1038646 Test: local Change-Id: I010531e4749c8421963c98107ea0305657192913 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146061 Commit-Queue: jimmy gong <jimmyxgong@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Auto-Submit: jimmy gong <jimmyxgong@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#758372}
-
Thomas Lukaszewicz authored
Bug: None Change-Id: If46d7accf1681d26f8aec80086412f4fc4a27774 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144477 Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#758371}
-
Chromium WPT Sync authored
Using wpt-import in Chromium b795ffdd. With Chromium commits locally applied on WPT: d0ad7cf8 "UpgradeInsecureRequest: Add WPTs for static-import in dedicated/shared workers" c53a40f4 "Update size.attributes.parse.trailingjunk" 86131ac4 "Add a test for ReplaceTrack that verifies video track content." 380347e7 "[css-masking] Migrate clip-path-columns-svg-clippath-usou.html to WPT" 1f1bb9a6 "Adds ability to clear out assigned nodes to slot when slot is removed from shadow root." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I6fc020a8d3ee6a1dfd8f689dec152d9d5fab40f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146154Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#758370}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/8cc69b103725..c0d7928ef7b0 git log 8cc69b103725..c0d7928ef7b0 --date=short --first-parent --format='%ad %ae %s' 2020-04-11 thestig@chromium.org Remove page parameter from FORM_SetFocusedAnnot(). 2020-04-10 tsepez@chromium.org Cover CJX_Form methods from JavaScript 2020-04-10 dhoss@chromium.org Remove spaces adjacent to bracket characters in some PDFs 2020-04-10 ankk@microsoft.com Modify input stream from files to have LF line endings Created with: gclient setdep -r src/third_party/pdfium@c0d7928ef7b0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: pdfium-deps-rolls@chromium.org Change-Id: Ibebd28b498dc0fb555dc635810b8a4c2472c0e4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146099Reviewed-by:
-
Kyle Horimoto authored
UX has requested that we update two strings related to UMA consent. Additionally, this CL moves two strings which were OS-specific from settings_strings.grdp to os_settings_strings.grdp. Fixed: 1043688 Bug: 967883 Change-Id: I906c942ad4b093e95fad6ddc77960d49e879a281 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146081 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
-
Sam Bowen authored
* Allow string whenever a property is text, Thing, or Enum type. * Allow URL whenever a property is Thing or Enum type, /as long as/ the URL is a schema.org ID of an appropriate thing or enum. https://schema.org/docs/gs.html#schemaorg_expected Change-Id: I72edef99f705c64838f09829de6c34058b10b860 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144401Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Commit-Queue: Sam Bowen <sgbowen@google.com> Cr-Commit-Position: refs/heads/master@{#758367}
-
Thomas Guilbert authored
This CL renames the video.requestAnimationFrame into the video.requestVideoFrameCallback API. It also updates non WPTs to use the new API. WPTs will updated in their own CL. Bug: 1012063 Change-Id: Id41c3979e1f74df51ab10bbff68a9a0b39b7ccd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144625 Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#758366}
-
Andrew Comminos authored
Adds performance tests for both |includeContinuous: true| as well as the default event set. Removes existing test suppression. Bug: 1069468 Change-Id: I42ca33dfc07a9fdd97011aa81d05c430d4fbd204 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146098Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Reviewed-by:
-
Andres Calderon Jaramillo authored
This CL fixes a problem where VaapiWrapper would detect a given codec as being supported when in reality it wasn't. This occurs because before this CL, VaapiWrapper::GetEntryPointsForProfile() ignored the CodecMode. So, for example, in lulu, JPEG decoding is supported but encoding is not. However, since GetEntryPointsForProfile() didn't care about the decoding or encoding mode, it would return VAEntrypointVLD for both. This would cause VaapiWrapper::IsJpegEncodeSupported() to return true. This CL makes VaapiWrapper::GetEntryPointsForProfile() take the CodecMode into consideration by grouping the VAEntrypoints according to the corresponding CodecMode. Additionally, a test is added to ensure that the default VAEntrypoint (as determined by VaapiWrapper::GetDefaultVaEntryPoint()) is actually supported. This is useful because we use the default entrypoint in VaapiWrapper::Initialize() and we never check if it's actually supported, so this test serves as an assertion on all boards. Bug: 1068440 Test: ./vaapi_unittest --gtest_filter="VaapiTest.*" on lulu and grunt. Change-Id: Ib4cceb75d67a4d26582874f810c04deacd1b51f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144863 Commit-Queue: Andres Calderon Jaramillo <andrescj@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#758364}
-
Oksana Zhuravlova authored
Change-Id: Ie3133d8a9d1b9887265639bea52066cf9c8cf869 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146112Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#758363}
-
Regan Hsu authored
* No results UI shown when there are no results and the input text is nonempty. * Dropdown is closed if input text is empty. * Adds a separator that covers top box-shadow of dropdown. Mock (See Zero State): https://docs.google.com/presentation/d/1-DftlpMfwFvvCi5RDpT4chSRpNk13EUTyX3AzT80I1c Screenshot: * No results UI and no shadow on top of dropdown section: https://screenshot.googleplex.com/iv7QUkg28wn Bug: 1056909 Change-Id: I1a26e1c9b933f540bf294db6165ef0c11e187c53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138165 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
-
Christian Biesinger authored
This makes FlexNG support the aspect-ratio property. Bug: 1045668 Change-Id: I3cd7883846dd3d087850bccf5b5f1d3ce0c3d8c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144365 Auto-Submit: Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
David Grogan <dgrogan@chromium.org> Cr-Commit-Position: refs/heads/master@{#758361}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/3431cbde4e5a..a07910e9e064 Created with: gclient setdep -r src-internal@a07910e9e064 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC nhiroki@google.com,reillyg@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1058152,chromium:1061193,chromium:1067290,chromium:1067765 Tbr: nhiroki@google.com,reillyg@google.com Change-Id: I9010d2a701e367ca18f8fc3138bf878030026555 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145928Reviewed-by:
-
Orin Jaworski authored
This CL introduces a new omnibox view to contain the button row. The layout and element handling will be reworked but initially the goal is to preserve as much as possible from the working logic in the result view. Bug: 1046523 Change-Id: Ibf5f20b0494d35669991da343d62afa4f036ba4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141234 Commit-Queue: Orin Jaworski <orinj@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#758359}
-
Bettina authored
Commonly spoofed domains are mostly only raw domains but the matching domains to the reuse saved passwords are now eTLD+1. (i.e. login.live.com vs live.com). Thus, the matching domains should either be equal to the raw domains or have the suffix of "." concatenated with the commonly spoofed domains. The first part of this was https://crrev.com/c/2133974. Screenshot: http://screen/xGQJbODneQe.png Bug: 1067401,1069578 Change-Id: I3d50f768c7bd4c445cd050c286ec0c510e0c39c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2140623Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Bettina Dea <bdea@chromium.org> Cr-Commit-Position: refs/heads/master@{#758358}
-
- 10 Apr, 2020 7 commits
-
-
David Bertoni authored
This was disabled in 2013 as flaky, but I ran 3000 iterations on the bots with no flakes. Bug: 248047 Change-Id: I7f8e791a587ee9cc3c396890296a4a88f7b3328e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144742Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#758357}
-
dpapad authored
GetRawDataResource assumes that underlying files are not compressed, whereas LoadDataResourceString automatically decompresses if necessary. This is one of many CLs, in preparation of compressing all HTML, JS, CSS, SVG files by default (meaning without requiring compress="gzip" to be specified). Bug: 1068407 Change-Id: Icb1dc7f1911d6b3bce54fa8132d66fb0acf71be5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145819 Commit-Queue: dpapad <dpapad@chromium.org> Reviewed-by:
-
Michael Chang authored
Before integrating the new updater with Chromium src, there needs to be end-to-end validation of the updater features. Adding a simple test app will help in easily determining this. Bug: 1063435 Change-Id: I44d9ddaceec035be75158af5f6824c5410be0a0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133169 Commit-Queue: Michael Chang <donchan@microsoft.com> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#758355}
-
Peter Kasting authored
Mostly this reworks the sync change processing order to try to declare variables near their first use, factor out common bits, and reduce indenting. It does change the error message on ACTION_INVALID (shouldn't be a problem). Bug: none Change-Id: I843a76353bae9cba6f693f996ab60deec1b01e4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145913 Commit-Queue: Peter Kasting <pkasting@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
-
Reilly Grant authored
This reverts commit c195e902. Reason for revert: Causing local build failures. Original change's description: > [base] Move the CHECK and CHECK_op macros to more light-weight headers > > This provides cheaper (in terms of compile time) alternatives for code > that just wants to do a few simple CHECKs without pulling in the full > weight of logging.h. On Linux, the preprocessed size of check.h and > check_op.h are 2% and 62% of logging.h, respectively. > > Splitting the CHECK and CHECK_op macros out to separate files also > reduces the complexity of logging.h which has become very complicated. > > As a bonus, the new implementation is leaner, causing a 3% local > compile-time reduction for the chrome target on Linux even though no > includes have been changed yet. > > Bug: 1031540 > Change-Id: If7aca321f077110bea0907e487d2e8d29a8c50fd > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128112 > Commit-Queue: Nico Weber <thakis@chromium.org> > Reviewed-by: Nico Weber <thakis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#758287} TBR=thakis@chromium.org,hans@chromium.org Change-Id: Ia5cc40588e336a9d35420b862157ff9286c2370a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1031540 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146055Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#758353}
-
Derek Schuff authored
NaCl processes exit directly via ExitProcess rather than returning from the content main function back to ChromeMain (see comment on NaClExit in native_client/src/shared/platform/win/nacl_exit.c). This means we have to disable the default behavior of crashing on process detach; otherwise all exits are reported as crashes R=bbudge@chromium.org Bug: 1008178 Change-Id: I87e1e3e70a50ed587f6ef7c637fc4b874574e1d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144468 Commit-Queue: Derek Schuff <dschuff@chromium.org> Reviewed-by:
Bill Budge <bbudge@chromium.org> Cr-Commit-Position: refs/heads/master@{#758352}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/50f449b1dfd7..e14328694186 git log 50f449b1dfd7..e14328694186 --date=short --first-parent --format='%ad %ae %s' 2020-04-10 lalitm@google.com Merge "Fix max trace_bounds" Created with: gclient setdep -r src/third_party/perfetto@e14328694186 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I98aa93ed81d8b753c5256e0468e619d5aa7c7b44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144843Reviewed-by:
-
