- 17 Jun, 2019 40 commits
-
-
David Grogan authored
LevelDBEnv.IDB.LockFileAncestorsNotFound LevelDBEnv.ServiceWorker.LockFileAncestorsNotFound LevelDBEnv.LockFileAncestorsNotFound Bug: 969973 Change-Id: Ie8f55d5ad09fe00e63e95681c2781283a822281c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663036Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: David Grogan <dgrogan@chromium.org> Cr-Commit-Position: refs/heads/master@{#669894}
-
Sergey Ulanov authored
Previously AudioOutputStreamFuchsia was starting playing before receiving the first OnMinLeadTime. As result it was starting playback with an invalid min_lead_time value, which may result in some samples being dropped. Now it waits for the first OnMinLeadTime event before pumping the first audio buffer. Bug: 973754 Change-Id: I47e828120c392b1ddb2f7d7a74422bf05c8aa43c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1658951Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Auto-Submit: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#669893}
-
Piotr Bialecki authored
This fixes plane detection sample when running w/o WebXRHitTest. Change-Id: Ic48751677a1e1d2aef702513346993909f783bfa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663314 Commit-Queue: Piotr Bialecki <bialpio@chromium.org> Commit-Queue: Bill Orr <billorr@chromium.org> Auto-Submit: Piotr Bialecki <bialpio@chromium.org> Reviewed-by:
Bill Orr <billorr@chromium.org> Cr-Commit-Position: refs/heads/master@{#669892}
-
Matt Reynolds authored
Affected histograms: * Gamepad.KnownGamepadConnectedWithId * Gamepad.UnknownGamepadConnected BUG=969919 Change-Id: I4b7bbd12d0f86cc201591ab2733949fb5f3b5870 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1657549Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Matt Reynolds <mattreynolds@chromium.org> Cr-Commit-Position: refs/heads/master@{#669891}
-
Jinsuk Kim authored
This CL reverts a change made about gesture navigation navigation bubble dimension in https://crrev.com/c/1650205. Since it is not a touch target, doesn't have to be as big as explained in the CL for a11y. Bug: 974633 Change-Id: I5b1a36b6c2d166f0964caae039f98f67458f6c5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663228Reviewed-by:
Becky Zhou <huayinz@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#669890}
-
Sean Topping authored
More content::WebContentsObserver logic has been moved into CastWebContentsImpl in order to reduce interal //content dependencies. Merge-With: eureka-internal/271377 Bug: internal b/120675407 Test: CQ, Play media on display Assistant Change-Id: If537c4155afe48858a14f4468af8744861440250 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1604043Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Commit-Queue: Sean Topping <seantopping@chromium.org> Cr-Commit-Position: refs/heads/master@{#669889}
-
Reilly Grant authored
This change passes along the test parameter to the serial_test function so that web_tests/serial can use promise_rejects instead of custom logic to check for errors. Bug: 884928 Change-Id: I9e3705e1d62c62bc87562478ada38d62a6bdf3c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1661043Reviewed-by:
Matt Reynolds <mattreynolds@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#669888}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/8b2600f715e5..2a888de1db05 git log 8b2600f715e5..2a888de1db05 --date=short --no-merges --format='%ad %ae %s' 2019-06-17 google-shaderc-autoroll@skia.org Roll third_party/glslang def9662348b0..9db72785beb3 (1 commits) (#721) 2019-06-17 google-shaderc-autoroll@skia.org Roll third_party/spirv-cross 4104e363005a..146dc453bcec (2 commits) (#722) 2019-06-17 zoddicus@users.noreply.github.com Manually roll DEPS to get past test failure (#717) Created with: gclient setdep -r src/third_party/shaderc/src@2a888de1db05 The AutoRoll server is located here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=radial-bots+chrome-roll@google.com Change-Id: Icc54c2f6c3111b7a0572b64c036ed109037e309a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662948Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#669887}
-
wutao authored
This is a clean up cl to add a specific DISALLOWED_BY_KIOSK_MODE type. Bug: 973197 Test: manual Change-Id: Ie7e2d8f8ddc310fbf8c5d4aa07be4f76bfc26747 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1658939 Commit-Queue: Tao Wu <wutao@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#669886}
-
Jon Mann authored
On settings rows which have a toggle and link to a sub-page, the area around the toggle is no longer a click target. This prevents accidental navigations which attempting to flip the toggle. Bug: 917328 Change-Id: I546e34b7814706ceee14b4e75ef991d5c9ef03c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1658711Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Jon Mann <jonmann@chromium.org> Cr-Commit-Position: refs/heads/master@{#669885}
-
Josh Karlin authored
What: Label async tasks as ad or not. Why: So that the AdTracker knows if a running task is due to an async task registered while ad script was on the stack. How: Modified the async probes to take a AsyncTaskId* instead of a void*. The AsyncTaskId* stores the bit of whether ad script was on the stack at the time of creation. This is *much* better than the previous approach (https://crrev.com/c/1291232) in that there are no memory leaks, no extra map lookups, and we don't have to worry about cancelasynctask being called. It does require a modification to all probe locations to hold a AsyncTaskId member. Bug: 851531 Change-Id: I92e25b3ab3b8746611c3a3f9a9a7265bab4a601e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648886 Commit-Queue: Josh Karlin <jkarlin@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#669884}
-
Michael Thiessen authored
The body can't be unfocused, so we shouldn't report that it can be, and in any case unfocusing the body would not be useful. Bug: 968157 Change-Id: Ie77bedeef0a70084eea1344d6c69ee3daaed916e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1661069Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#669883}
-
cassiezhang authored
So that the filter file can take in effect. Bug: 957284 Change-Id: I07118f06cdc346d81da47f0b7fd564e94b5d9767 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1661000Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Cassie Zhang <cassiez@google.com> Cr-Commit-Position: refs/heads/master@{#669882}
-
Jessica Tallon authored
Problems with the kTextChanged event that were fixed: 1. The events were being emited after the selected item changed. Thus the screen reader could get and present stale information to the user. 2. The events were being emitted for all six Omnibox items each and every time the user inserted or deleted any text. While emitting the event for all six Omnibox items is arguably technically correct, it is functionally not helpful. When the user is typing in the Omnibox, the screen reader will typically only present changes to the Omnibox. Thus these events are just noise to the screen reader. To address both issues, remove the call from SetMatch and add it to OnSelected immediately before ax::mojom::Event::kSelection gets emitted. Also add emitting of kSelectionChildrenChanged event to Omnibox to notify when a selection has occurred. Bug: 896706 Bug: 952272 Change-Id: I3b77c00159da40ee1ce7d5fcaf235e3a1bc31420 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1596671Reviewed-by:
Kevin Bailey <krb@chromium.org> Commit-Queue: Jessica Tallon <jtallon@igalia.com> Cr-Commit-Position: refs/heads/master@{#669881}
-
Jerome Jiang authored
https://chromium.googlesource.com/webm/libvpx.git/+log/28cc5f3646ba..bb9511684f70 $ git log 28cc5f364..bb9511684 --date=short --no-merges --format='%ad %ae %s' 2019-06-14 harish.mahendrakar vpx_dec_fuzzer: Remove fmemopen dependency 2019-06-14 jianj Fix memory leak for vp8 multi-res encoder. 2019-06-13 johannkoenig ppc: disable vsx for small predictors 2019-06-12 harish.mahendrakar vpx_dec_fuzzer: Add -fsanitize=fuzzer-no-link 2019-04-09 deepa.kg Use previous ARF as GOLDEN frame for the next GOP 2019-06-10 johannkoenig sse: remove unused HAVE_SSE files 2019-06-10 johannkoenig ppc: disable vsx optimizations with hbd 2019-06-07 jzern update libwebm to libwebm-1.0.0.27-361-g81de00c Created with: roll-dep src/third_party/libvpx/source/libvpx R=johannkoenig@google.com Change-Id: If04725adae027fef553690d39d5c75647fecc96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662590Reviewed-by:
Johann Koenig <johannkoenig@google.com> Commit-Queue: Jerome Jiang <jianj@google.com> Cr-Commit-Position: refs/heads/master@{#669880}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/3390eddc9717..2313020206fc git log 3390eddc9717..2313020206fc --date=short --no-merges --format='%ad %ae %s' 2019-06-17 vadimsh@chromium.org [cipd] Update CIPD client to v2.2.19. Created with: gclient setdep -r src/third_party/depot_tools@2313020206fc The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:972203 TBR=agable@chromium.org Change-Id: I46011e9df215daf184ae670e8667107536862acb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663049Reviewed-by:
-
Clark DuVall authored
d85f898a696a Refactor MemorySnapshotGeneric to use ProcessMemory instead of ProcessReader e5abe92b2e1e Add user minidump stream support for ELF 3a6f57178acf [fuchsia] clean up exception handler overload with exception port de22b8d05097 Opt tests into the ambient-replace-as-executable feature Change-Id: I74023e2beb6d852fb9e6386229929c8953432646 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662869Reviewed-by:Mark Mentovai <mark@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#669878}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/ba0eb777bf5a..2baf86e86ee2 git log ba0eb777bf5a..2baf86e86ee2 --date=short --no-merges --format='%ad %ae %s' 2019-06-17 ilkos@google.com Merge "Split out LMK metric from android_mem" Created with: gclient setdep -r src/third_party/perfetto@2baf86e86ee2 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I7d6a036abad6b821fe75f8926f6117f041371362 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662675Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/material-components/material-components-ios/+log/df4ef89b8001..0f1656a03a06 git log df4ef89b8001..0f1656a03a06 --date=short --no-merges --format='%ad %ae %s' 2019-06-17 yarneo@gmail.com Merge branch 'release-candidate' into stable Created with: gclient setdep -r src/ios/third_party/material_components_ios/src@0f1656a03a06 The AutoRoll server is located here: https://autoroll.skia.org/r/material-components-ios-chromium Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:ios-internal-mdc TBR=bling-p10-rolls@google.com Change-Id: I799559bd1b86c779b7b265a442c11f68a9d2aeb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662026Reviewed-by:
-
Nicolas Ouellet-payeur authored
This is a reland of r/668010 that fixes some CQ issues. This command-line flag can be used to run the auditor with the `python_script' backend, although it still defaults to the `clang_tool' backend. TESTED= * ran extractor_tests.py (tested on Linux + Windows) * ran `check_annotations.py --complete' before & after adding `extractor-backend=python_script' in it. There is only 1 annotation that gives different output, because of how the script works: https://pastebin.com/gWJ2WSDH (tested both on Linux, only tested python_script on Windows) * changed some annotations in C++ code, and checked that both modes suggest annotations.xml changes (tested on Linux + Windows) Bug: 966883 Change-Id: I47f10434b65fda5233dcdb0063143170a8e9569f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660773 Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Reviewed-by:Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#669875}
-
Peter Boström authored
Makes the ExtensionToolbarContainer aware of hover, active and other state changes. Uses the plumbing and visual treatment already implemented in ToolbarPageActionIconContainerView. Bug: None Change-Id: I0fa8dbabe15ac2883a5fe4e09d95e07127fe3bbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663034 Commit-Queue: Peter Boström <pbos@chromium.org> Commit-Queue: Siyu An <siyua@chromium.org> Auto-Submit: Peter Boström <pbos@chromium.org> Reviewed-by:
Siyu An <siyua@chromium.org> Cr-Commit-Position: refs/heads/master@{#669874}
-
Ce Chen authored
We will load the new model and clean up the old one when COMPONENT_UPDATED event from updater is received. Bug: 925072 Change-Id: I7ba69c352e20869aea3f8ea406b39a486a6bed27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1652628Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Ce Chen <cch@chromium.org> Cr-Commit-Position: refs/heads/master@{#669873}
-
Kyle Milka authored
Explicitly set the size of the browser window so that the customizate button will always appear. Bug: 971853 Change-Id: I61e33767456031d5104554279e1cb19c09a10621 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663052Reviewed-by:
Kristi Park <kristipark@chromium.org> Commit-Queue: Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#669872}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/b97824d4d1d1..2935638a1b16 git log b97824d4d1d1..2935638a1b16 --date=short --no-merges --format='%ad %ae %s' 2019-06-17 bsalomon@google.com Make SkASSERT not break build in constexpr GrSwizzle method on GCC 2019-06-17 bsalomon@google.com Add function to GrDataUtils to handle color conversions. Created with: gclient setdep -r src/third_party/skia@2935638a1b16 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=bsalomon@google.com Change-Id: Ic85a1c4ea6f395f16b8c5e9e1ce87aa9705078f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662025Reviewed-by:
-
Mason Freed authored
Prior to this CL, src_image->makeSubset() was always called, regardless of whether anything was actually being cropped. Now, it is only called if needed. Change-Id: I9469ac523b6ac365829cc245b1c576eeab7b6e7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660781 Auto-Submit: Mason Freed <masonfreed@chromium.org> Commit-Queue: enne <enne@chromium.org> Reviewed-by:
enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#669870}
-
Mike Wasserman authored
Replace mojom with an abstract singleton controller, c++ struct & enums. Update impl & tests, expose a protected static helper for simplicity. Remove an unnecessary test subclass, unit test passes without this. Bug: 958129 Test: Automated; no accessibility focus ring regressions. Change-Id: I34acd91fa9e093309a89edf74e2395d5de5ec2c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660107 Auto-Submit: Michael Wasserman <msw@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#669869}
-
Gil Dekel authored
This CL generalizes some functions in VaapiWrapper that will be shared by all potential implementing classes of VaapiImageDecoder. In addition, this CL refactors (cleans up) the way VaapiImageDecoder initializes the VaapiWrapper member. Bug: 877694 Test: jpeg_decode_accelerator_unittest Change-Id: Ic1fe5a1c4a104ed1cf27533af65f811e7db5e534 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660829Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Andres Calderon Jaramillo <andrescj@chromium.org> Commit-Queue: Gil Dekel <gildekel@chromium.org> Cr-Commit-Position: refs/heads/master@{#669868}
-
Dale Curtis authored
https://chromium.googlesource.com/external/github.com/videolan/dav1d.git/+log/fc3777b44c04..a1e3f35842de $ git log fc3777b44..a1e3f3584 --date=short --no-merges --format='%ad %ae %s' 2019-04-09 krishnaniyer97 arm:mc: NEON implementation of blend, blend_h and blend_v function 2019-06-04 lu_zero checkasm: Add an option to benchmark the C code as well 2019-06-04 lu_zero checkasm: Add a --help option to checkasm 2019-06-03 lu_zero checkasm: Add a readtime impl for ppc 2019-06-03 lu_zero Initial PowerPC support 2019-06-10 martin meson: Look for librt if clock_gettime isn't found without it 2019-06-05 jamrial meson: simplify a few checks for x86 targets 2019-06-05 jamrial x86: include config.asm in x86inc instead of every asm file 2019-06-06 martin checkasm: Check for __ARM_ARCH >= 7 for the arm cpu timer inline assembly 2019-06-06 thresh CI: Added ppc64le build and test jobs 2019-05-22 jb Update NEWS for 0.4.0 2019-06-05 tmatth output: automatically use null muxer for /dev/null 2019-06-04 epirat07 meson: Fix nasm detection 2019-06-01 gramner checkasm: Fix out-of-bounds read in warp8x8 tests 2019-05-31 gramner x86: Optimize warp8x8 AVX2 asm 2019-05-24 janne-vlc build: add option for fuzzer specific LDFLAGS 2019-05-23 martin arm: Mark the stack as non-executable on ELF 2019-05-23 gramner Optimize coefficient decoding 2019-05-21 jamrial dav1d: reserve some bytes in Dav1dSettings 2019-05-16 gramner build: Enable SSE2 by default on x86-32 2019-05-16 gramner x86: Enable msac asm on x86-32 2019-05-20 me Update THANKS.md 2019-05-18 me Hard wrap contribs. Add self for logo 2019-05-19 martin ci: Add full testdata tests on aarch64 2019-05-19 gramner checkasm: Update the mc test to check all valid heights 2019-05-19 martin arm: mc: Fix 8tap_v w8 with OBMC 3/4 heights 2019-05-18 gramner Optimize obmc blend 2019-05-17 ltrudeau Remove one multiply in Z2 filter top left 2019-05-17 ltrudeau Reduce branching in intra angle to mode 2019-05-17 ltrudeau small code cleaning in intra_edge init_mode Created with: roll-dep src/third_party/dav1d/libdav1d TBR=chcunningham BUG=none Change-Id: Icc4493c607089696d19f17ae212448168975b202 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662833Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#669867}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d00e241a16e0..b9797b31f7a1 Created with: gclient setdep -r src-internal@b9797b31f7a1 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome BUG=chromium:972709 TBR=huangdarwin@google.com,sdy@google.com,alancutter@google.com,tschumann@google.com Change-Id: Iacaef8cca0ca154e4a68ed458729ea9aa86a8846 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662888Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#669866}
-
Peter Kasting authored
https://groups.google.com/a/chromium.org/d/topic/cxx/gv7E_n4AnP4/discussion Bug: none Change-Id: I5d787e8965d5d6ed0d5037550405aba0375ba2ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1661211 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#669865}
-
Sunny Sachanandani authored
An earlier CL (crrev.com/c/1588933) added new GL enums without running build_gles2_cmd_buffer.py. This change wasn't caught by PRESUBMIT because it was a header only change. The PRESUBMIT needs to be fixed to fixed (crrev.com/c/1662711) so that it doesn't reject this CL because it only contains autogen changes without a corresponding change to the generator scripts. TEST=git cl presubmit works Bug: 974337 Change-Id: I0e09893282298574264c5380ae7d10e3fe39fad6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660418 Auto-Submit: Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#669864}
-
Tomasz Wiszkowski authored
In cases where Omnibox interaction executes a complete cycle (from highlight to navigate / close) before native code completes loading, we trip UnsatisfiedLinkError causing application to crash. This fix ensures we only attempt to record metrics if we know the Native is initialized. BUG: 971626 Change-Id: Ic0ef632d6da993516170b943ae20e5cda427fd94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662840Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Ender <ender@google.com> Cr-Commit-Position: refs/heads/master@{#669863}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/7e5908802f90..79b2847f611f git log 7e5908802f90..79b2847f611f --date=short --no-merges --format='%ad %ae %s' 2019-06-17 thestig@chromium.org Remove core/fxcodec/codec. 2019-06-17 thestig@chromium.org Move more code out of core/fxcodec/codec. 2019-06-17 thestig@chromium.org Remove core/fxcodec/codec/codec_int.h. 2019-06-17 thestig@chromium.org Move more codec modules into their own directories. 2019-06-17 thestig@chromium.org Move XFA codec code into their own directories. Created with: gclient setdep -r src/third_party/pdfium@79b2847f611f The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=pdfium-deps-rolls@chromium.org Change-Id: If480382460b5384948eed2702608f12bd41a7a7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662677Reviewed-by:
-
Sunny Sachanandani authored
Current implementation of PRESUBMIT makes it impossible to fix autogen files by running the generator if it wasn't run by accident and missed by PRESUBMIT earlier. New implementation removes this check, and replaces it with a more robust check for running the generator which won't reject changes unless there's an actual mismatch with generator output. TEST=Ran git cl presubmit on CL from running build_gles2_cmd_buffer.py Bug: 974337 Change-Id: Ic812bf44b921fd0718a58b70892b042876e3d357 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662711 Auto-Submit: Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/e1d02819..83ce6ba1 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I54c811146dca716cf17bb51057de288e99903a51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662602Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#669860}
-
Peter Kasting authored
The caller just wants to check the full container, so do so. Bug: 956419 Change-Id: Ib661e0bce4e9888b0394c7a6961fd68a28f790ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1661296Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#669859}
-
Alex Gough authored
- Regularised capitalisation of Windows. - Removed some hemming and hawing about out of support Windows versions. - Tidied a couple of broken links and references. Change-Id: I2e84b9ee6ec83ad77a31f4998273989c9dd1852b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649299Reviewed-by:
Will Harris <wfh@chromium.org> Commit-Queue: Alex Gough <ajgo@chromium.org> Cr-Commit-Position: refs/heads/master@{#669858}
-
Johannes Henkel authored
New revision: 83b1154a9661d22bba9a368d368214cc20880419 This updates the usages of the protocol types to the new definitions, using std::vector-based implementations of protocol::Array. - In many places we can now use the C++11 style for( : ) loops. - We use std::make_unique for creation. - We use emplace_back to insert elements, which sometimes allows us to create strings etc. in place. - Accessing strings in arrays is cheaper, since vector[i] returns a reference (protocol::Array::get made a copy!). - One can assert equivalence of vectors with strings in tests (EXPECT_THAT(foo, testing::ElementsAre("bar", "baz")); - Overall the code is shorter, as the vector API is more concise. Change-Id: I6c8e152987fb0dcfbb01f9086ee48b284a0e5adb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1657628 Commit-Queue: Johannes Henkel <johannes@chromium.org> Reviewed-by:Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#669857}
-
Christopher Cameron authored
Bug: 938241 Change-Id: I6e93338c53a5fc407a19d07d2d5b7626bf26afc1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1659561Reviewed-by:
Alan Cutter <alancutter@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#669856}
-
khmel@chromium.org authored
As described TEST=Locally BUG=b/132709527 Change-Id: I94572a590724969e54d865d54bf1f40fc4c7d088 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662734Reviewed-by:
-
