GitLab

Now that we have a patch for the ARM A12/A17 errata, it is safe to try
building ARM Thumb without frame-pointers again, since we don't need
them.

We leave frame-pointers enabled in ChromeOS for 64-bit.

The Windows case is tweaked to use current_cpu rather than target_cpu,
and the Android case is explicitly gated on is_android.

Bug: 740806, 711784
Change-Id: I2fff46d1a3a8d78d12c389f95a20acf54013318d
Reviewed-on: https://chromium-review.googlesource.com/567608
Commit-Queue: Wez <wez@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486165}

e1396f8a changed the presubmit to allow
ScopedAllowIO in browser tests. From the discussion it seemed like the
intention was to allow it in all tests though. This changes the
presubmit to at least allow usage in unit tests.

Also update the error message to no longer refer to the deprecated
blocking pool and FILE thread.

Change-Id: Ibcc18f502b8c47a50a424a2ffe6eab04291e685b
Reviewed-on: https://chromium-review.googlesource.com/569014Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486164}

No functional changes.

Bug: 
Change-Id: I02c494be7028763e017f5bd01710d2285e98dd01
Reviewed-on: https://chromium-review.googlesource.com/568693Reviewed-by: Yash Malik <ymalik@chromium.org>
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486163}

Change-Id: I4aad3d6e360b3e7c02366c9eee65399cfbec82cb
Reviewed-on: https://chromium-review.googlesource.com/564298Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Michael Case <mikecase@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486162}

Bug: 
Change-Id: Id828c8df4eed5d104b4ce311bf7aa1f4bcd6411c
Reviewed-on: https://chromium-review.googlesource.com/568701
Commit-Queue: Pavel Feldman <pfeldman@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486161}

Also add request_origin to this struct.

Bug: 734753
Change-Id: I210bf0fa177f1379693b6b432c12f48b89d8cd28
Reviewed-on: https://chromium-review.googlesource.com/558564Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Filip Gorski <fgorski@chromium.org>
Reviewed-by: vitaliii <vitaliii@chromium.org>
Reviewed-by: Justin DeWitt <dewittj@chromium.org>
Commit-Queue: Cathy Li <chili@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486160}

As long as chrome://media-internals is open, it should preserve log
entries. Log entries are still removed from the backing store, so these
players will be removed if the page is reloaded.

This CL also changes the trigger for backing store removal to include
tab crashes. Previously there was no reliable way to remove a logs for a
player from a crashed tab, which is problematic if the tab is incognito.

Bug: 741132
Change-Id: I92b152fa6578c3728ab22a45786e188d93fb87f2
Reviewed-on: https://chromium-review.googlesource.com/567644
Commit-Queue: Dan Sanders <sandersd@chromium.org>
Reviewed-by: Matthew Wolenetz <wolenetz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486159}

This CL adds a browser test to check that the ChromeExpectCTReporter is properly
created and set up to receive reports, particularly for dynamic Expect-CT
violations. It also enables the dynamic Expect-CT feature on the waterfall.

BUG=679012,642517

Change-Id: I3ea01207ea5852b9bd0bbb1d90799ee4555c854e
Reviewed-on: https://chromium-review.googlesource.com/566572Reviewed-by: Jesse Doherty <jwd@chromium.org>
Reviewed-by: Mustafa Emre Acer <meacer@chromium.org>
Commit-Queue: Emily Stark <estark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486158}

Also fixes up some formatting errors that have snuck into histograms.xml.

BUG=none
TEST=none
R=mek@chromium.org

Change-Id: If99bf87ea428dbe61204cad9092d3e0ad2c77d7d
Reviewed-on: https://chromium-review.googlesource.com/568854Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Commit-Queue: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486157}

Updates the total number of menu items to reflect the fact that an item
was deleted. Also added a comment in order to prevent this from
happening again.

Bug: 682880
Change-Id: I0893cd9e4eda6f1b7238cc2fcfe892d30a1cb42c
Reviewed-on: https://chromium-review.googlesource.com/565175
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Reviewed-by: Jean-François Geyelin <jif@chromium.org>
Reviewed-by: Louis Romero <lpromero@chromium.org>
Reviewed-by: Ed Chin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486156}

Replace callbacks with promises.

Bug: 
Change-Id: I677ec63941ec827f559921dc4205fff9eae6a841
Reviewed-on: https://chromium-review.googlesource.com/564086
Commit-Queue: Eugene Ostroukhov <eostroukhov@chromium.org>
Reviewed-by: Alexei Filippov <alph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486155}

This change adds Adaptive Icons (Android API 26 feature) for the
Chromoting Android Client.  I generated the new foreground and round
icons using Android Studio (based off of the legacy xxxhdpi logo) and am
using a base white background.

Note that I needed to add a suppression for the new XML files.  This
apprears to be due to the version of lint being used as previous
versions of Android did not require xml files in the mipmap or drawable
folders.

BUG=704154

Change-Id: I7f58634fdc758aec25e67369d26f68b41262ae5b
Reviewed-on: https://chromium-review.googlesource.com/566992
Commit-Queue: Joe Downing <joedow@chromium.org>
Reviewed-by: Lambros Lambrou <lambroslambrou@chromium.org>
Reviewed-by: Peter Wen <wnwen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486154}

Views a11y: Obey DialogDelegate::GetAccessibleWindowRole() rather than making a dialog-within-a-dialog

Currently both views::RootView and a dialog's ContentsView() are
populating AX_ROLE_DIALOG. This sets up a weird dialog-within-a-dialog.
Also, since the ContentsView doesn't include the title and dialog
buttons, it creates a nested group that excludes the dialog buttons and
is hard to navigate with a11y tools since it hides the dialog contents
inside the group.

To fix, just rely on views::RootView to populate the window role, and
obey GetAccessibleWindowRole() when deciding whether to notify a11y
tools of the window appearance.

BUG=741285

Review-Url: https://codereview.chromium.org/2980713002
Cr-Commit-Position: refs/heads/master@{#486153}

Cmd+B and gutter click both toggle breakpoint on a line. Gutter click + shift
also disabled the current breakpoint. This CL aligns Cmd+Shift+B to disable the
current breakpoint as well.

BUG=741115

Review-Url: https://codereview.chromium.org/2977753002
Cr-Commit-Position: refs/heads/master@{#486152}

Bug: 734219
Change-Id: If2e79ab1b2a86ad704ff579d78fd94a7e14df752
Reviewed-on: https://chromium-review.googlesource.com/567660
Commit-Queue: Jared Saul <jsaul@google.com>
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486151}

This is ported form skia fixing https://skia-review.googlesource.com/c/17327/
and https://skia-review.googlesource.com/c/16427/

BUG=710443
TEST=WebGL conformance test:framebuffer-texture-clear.html
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2934733002
Cr-Commit-Position: refs/heads/master@{#486150}

This includes all of filters/ but primarily we want this for any
GpuVideoDecoder changes. Many of the other things in filters/ are
related to VDA/GVD processing, so just include them all.

There doesn't seem to be a PostUploadHook which allows you to
filter based on files anyways...

BUG=none
TEST=none

Change-Id: I53cb8d74ec9bff4152e6bac87e0047410cc58f72
Reviewed-on: https://chromium-review.googlesource.com/567722Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486149}

Change-Id: I3d454f70f477b5ada2608c85dd8b54badf89fa71
Reviewed-on: https://chromium-review.googlesource.com/569000Reviewed-by: Jeff Carpenter <jeffcarp@chromium.org>
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486148}

Bug: None
Change-Id: I619491887eb97abc493debfeaf20ae260c222f33
Reviewed-on: https://chromium-review.googlesource.com/568820Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486147}

This is needed to run Mus in-process until crbug.com/741106 is fixed.

BUG=722527

Review-Url: https://codereview.chromium.org/2978833002
Cr-Commit-Position: refs/heads/master@{#486146}

I am factoring out some code in DropdownPopupWindow.measureContentWidth() that
determines the widest view in a ListView into a helper method in UiUtils so I
can use it for the spell check menu I'm working on in
https://codereview.chromium.org/2931443003.

Bug: 715365
Change-Id: I59bfc348eac62d07c6deb375bca6b808856911dd
Reviewed-on: https://chromium-review.googlesource.com/566594
Commit-Queue: Ryan Landay <rlanday@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486145}

Right now in html canvas 2d's drawImage API, the image decoding are done
on the main thread, and this task could be heavy when the image is big.
What we hope is to give people an option to call createImageBitmap(SVG)
which does the image decoding in a background thread, and then canvas
drawImage API can draw the image bitmap which is already in a decoded
state.

Bug: 580202
Change-Id: I79cfd46b4e2f154e9fde111b932125a9745571a2
Reviewed-on: https://chromium-review.googlesource.com/558398Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Justin Novosad <junov@chromium.org>
Commit-Queue: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486144}

The counters added here are for methods and attributes that take up
a non-trivial portion (4-10%) of time spent doing Blink C++ on some websites
from the v8_top25 benchmark.

Bug: 724543
Change-Id: Idbab1de4b7128a4a934ca22a7b739c2fa5b035bc
Reviewed-on: https://chromium-review.googlesource.com/565682
Commit-Queue: Adithya Srinivasan <adithyas@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486143}

These methods are never called by other classes, no need to mark them public.

Bug: 
Change-Id: I453e5831d60ac2970029c16fdd3011b012120695
Reviewed-on: https://chromium-review.googlesource.com/565963Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486142}

Bug: 713188
Change-Id: If8d923129a063160caaef22d3908f6f5f7aef2bc
Reviewed-on: https://chromium-review.googlesource.com/565446Reviewed-by: Eugene But <eugenebut@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Misha Efimov <mef@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486141}

This new Mojo channel connects the profiling process and the browser process. It should be run only when the enable_oop_heap_profiling is enabled, and when run with --memlog.

Fixes a bug on Posix memlog streams because sendmsg is not atomic for large messages.

Various refactoring of the profiling process. The separate IO thread has been removed and the main thread is now the IO thread.

NOPRESUBMIT=true (seems to crash presubmit checks, bug filed)

Change-Id: I93909bb95bfbd10348c0c7d51c80aa44cb26f7aa
Reviewed-on: https://chromium-review.googlesource.com/564157
Commit-Queue: Brett Wilson <brettw@chromium.org>
Reviewed-by: Albert J. Wong <ajwong@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486140}

Remove the parameter in ChromeLauncherActivity#launchTabbedMode() because the
function is always called with false

BUG=None

Change-Id: Ia17c3dbcd98c9b30014dedbc85d82ffbe791ac1d
Reviewed-on: https://chromium-review.googlesource.com/565843Reviewed-by: Ganggui Tang <gogerald@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486139}

This CL fixes discrepancies between the histogram names used in LocalNetworkRequestsPageLoadMetricsObserver and the ones registered in histograms.xml. The desired histogram names are the ones present in histograms.xml.

This CL also sets the histogram prefixes in histograms.xml associated with LocalNetworkRequestsPLMO as histogram bases so they are not generated unnecessarily.

BUG=

Change-Id: Ib8370037078f924ec44472f463724025593eb0cc
Reviewed-on: https://chromium-review.googlesource.com/568681Reviewed-by: Bryan McQuade <bmcquade@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Commit-Queue: U Thakore <uthakore@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486138}

According to the EME spec, during update(), expiration should be updated
before resolving the update() promise.

BUG=730762
TEST=Fixes and enables a test case.

Change-Id: I145f707aee8cbc53413417654282dafe6edc9f28
Reviewed-on: https://chromium-review.googlesource.com/567873Reviewed-by: John Rummell <jrummell@chromium.org>
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486137}

BUG=741310

Change-Id: I324c0403af2d351373536897a7f2bc282c870e41
Reviewed-on: https://chromium-review.googlesource.com/568682Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Patrick Hulce <phulce@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486136}

This matches the behavior of old Options, but it will also show
up an all Polymer WebUI pages using cr-dialog.

Bug: 740771
Change-Id: Ieb5db50b4796264a87be38e01ebfd1f362ff9d39
Reviewed-on: https://chromium-review.googlesource.com/566093Reviewed-by: Scott Chen <scottchen@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486135}

Bug: 741709
Change-Id: I7b57cd6bb597d0a28bb32acffe801284d15c9c07
Reviewed-on: https://chromium-review.googlesource.com/568486Reviewed-by: Tim Song <tengs@chromium.org>
Commit-Queue: Gustavo Sacomoto <sacomoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486134}

Some fallout from https://chromium-review.googlesource.com/c/567267

Bug=skia:6836
NOTRY=true
TBR=reed@google.com

Change-Id: Ib30e51f7877ca70c23a8980373b27114608abcfe
Reviewed-on: https://chromium-review.googlesource.com/569007Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Florin Malita <fmalita@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486133}

This reverts commit 5ddcccf7.

Reason for revert: Breaks ubsan on clusterfuzz.

Original change's description:
> Roll buildtools to 3d2d34
> 
> This roll includes only a single revision:
> https://chromium.googlesource.com/chromium/buildtools/+/3d2d34dde457f07ca410d1c06f4f3b9063c28643
> 
> TBR=michaelpg@chromium.org
> 
> Bug: 701919
> Change-Id: I2924e4db1cad21ce8aa4c99f5090dea69d53a720
> Reviewed-on: https://chromium-review.googlesource.com/567777
> Commit-Queue: Peter Collingbourne <pcc@chromium.org>
> Reviewed-by: Nico Weber <thakis@chromium.org>
> Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#485860}

TBR=thakis@chromium.org,michaelpg@chromium.org,pcc@chromium.org,thomasanderson@chromium.org

Change-Id: I51fd086f9f486b24727549f385c1238b8d4c39fe
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 701919, 741604
Reviewed-on: https://chromium-review.googlesource.com/568414Reviewed-by: Peter Collingbourne <pcc@chromium.org>
Commit-Queue: Peter Collingbourne <pcc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486132}

When a link is opened in a new tab, the source tab value might be delayed.
This change makes it so that if the source tab id is present, and the task
tracker doesn't have a matching parent id, it will overwrite the tasks for that
tab with the tasks from the source tab.

This fixes the case where the user deliberately opens a link in a new tab
via middle click.

Bug: 707978
Change-Id: I74be1a3527a6cda0187d7eb24477d83b57d2adbe
Reviewed-on: https://chromium-review.googlesource.com/567649
Commit-Queue: Nicolas Zea <zea@chromium.org>
Reviewed-by: Sky Malice <skym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486131}

The new(ish) FileDescriptorWatcher POSIX wrapper automagically maintains
the watch, so don't keep re-creating it.

Also fixes a typo in the name of a constant.

Bug: 
Change-Id: I595ef09575e6079f3aa97f7c31f789ef24f270fc
Reviewed-on: https://chromium-review.googlesource.com/568598Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486130}

When the "Spurious power button window" flag is set to a
nonzero value, additionally log the duration that the tablet
power button was held whenever it's released. This will be
used to gather more information from user tests.

BUG=736936
TEST=enabled the flag and checked
     /home/chronos/user/log/chrome after pressing the power
     button

Change-Id: Ic34e788035323c4493be0d082ff88c8440510275
Reviewed-on: https://chromium-review.googlesource.com/568174Reviewed-by: Qiang(Joe) Xu <warx@chromium.org>
Commit-Queue: Dan Erat <derat@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486129}

Revert of Allow presenting DXGI share handles as overlays. (patchset #5 id:80001 of https://codereview.chromium.org/2968503003/ )

Reason for revert:
On NVIDIA drivers it causes an error -
 [396:4308:0711/184358.172:ERROR:direct_composition_surface_win.cc(640)] Error acquiring keyed mutex: 887a0001

See https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.gpu.fyi%2FWin10_Debug__NVIDIA_%2F1504%2F%2B%2Frecipes%2Fsteps%2Fpixel_test_on_NVIDIA_GPU_on_Windows_on_Windows-10%2F0%2Fstdout

Original issue's description:
> Allow presenting DXGI share handles as overlays.
>
> Create a new type of GLImage representing an NV12 DXGI share handle (and
> array level) and support displaying it in an overlay.
>
> BUG=729238
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
>
> Review-Url: https://codereview.chromium.org/2968503003
> Cr-Commit-Position: refs/heads/master@{#485701}
> Committed: https://chromium.googlesource.com/chromium/src/+/fc666dc7bc9d5141a6457ee08b0004c705463140

TBR=sunnyps@chromium.org,sandersd@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=729238

Review-Url: https://codereview.chromium.org/2981713002
Cr-Commit-Position: refs/heads/master@{#486128}

Added jamesr, kmarshall, scottmg, sergeyu and wez to OWNERS for
testing/buildbot/filters/fuchsia*.

Change-Id: I02f7a67f46300667fee8be71416f185163fd7d6e
Reviewed-on: https://chromium-review.googlesource.com/568563Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486127}

With these changes it's possible to compile mojo unittests on Fuchsia

Bug: 740791
Change-Id: I6b558a5415d7a11b3fbd3b2711125da14bc5719f
Reviewed-on: https://chromium-review.googlesource.com/566259
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Yuzhu Shen <yzshen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486126}