GitLab

Previously, if the decision was false and we had fetched already or
couldn't fetch, we would wait until DidFinishNavigation to invoke any
registered callbacks.

Change-Id: I0536ff5307d89265863c91845dc3a500a2ecd631
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128526
Commit-Queue: Sophie Chang <sophiechang@chromium.org>
Reviewed-by: Michael Crouse <mcrouse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754713}

Currently, the test sends two beforeunload IPCs for main frame and
subframe, then waits for the subframe's beforeunload to trigger a
dialog, and then assumes that the main frame's beforeunload has
completed by that point when it checks the number of outstanding
beforeunload requests.  This need not be true -- even though the main
frame does not have a beforeunload handler, we still (currently) send
the beforeunload IPC to it, and it could still reply slower than the
subframe's IPC to put up a dialog.

This CL fixes the test to instead check the number of outstanding
beforeunload requests on the same event loop iteration, before we wait
for a dialog, since at that point we know we couldn't have processed
any beforeunload ACKs yet.  Then, after the beforeunload dialog is
shown, we only check that the subframe has an outstanding beforeunload
request, and don't check anything about the main frame beforeunload
(which may or may not have completed at that point).

Bug: 1044599
Change-Id: I3eb53b3a390a1945cc5e40ca388cb985a60b6d36
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128587Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org>
Commit-Queue: Alex Moshchuk <alexmos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754712}

When an Assistant query has been submitted, you should not be able to
interact with the suggestion chips anymore.
Mouse clicks had always been disabled, but a bug still allowed the
user to submit queries using |TAB| and |ENTER|.

This CL also introduces some extra unittests that were missing.

Bug: b/151800188
Change-Id: I15fe1b946ae92c1f74b7a98656793e4d00b2a12c
Tests: ash_unittests "AssistantPageViewTest.*" and view_unittests
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119388Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Commit-Queue: Jeroen Dhollander <jeroendh@google.com>
Cr-Commit-Position: refs/heads/master@{#754711}

Found while working on AshTestHelper.

Bug: none
Change-Id: I8d38fbe29fa1db613abf9b3e4447bff18365449f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2125231
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754710}

This means callers only need to call TearDown() if they need to do
something between teardown and destruction, which most don't; and they
cannot fail to call TearDown() (and thus leave objects alive).  So it's
both simpler and safer.

Bug: none
Change-Id: Iba7ad30e64dca62d060b8c572253117d7952db3b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124979
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754709}

We need CookieSettings for adding the header necessary for the manage
accounts feature.

Bug: 1054160
Change-Id: I736267acaed75d23362ff96c77bd4a1b1634c707
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127418Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754708}

This is yet more precursor work for making AshTestHelper an
AuraTestHelper subclass.  It moves into the constructor things that
are more "general-purpose" and don't rely on any state that might be
customized after construction (e.g. reading the ViewsDelegate), and
leaves SetUp() focused more on the ash-specific shell/windowing stuff.

This changes the parameters passed to the constructor vs. setup, since
ultimately some will be relevant to the Aura side and some won't.  For
now, this requires storing the |context_factory_| on the object to
pass it from the constructor to setup, but that will go away later.

This also adds a no-args SetUp() function, which just calls the main
SetUp() function.  This is a precursor to making SetUp() and TearDown()
be virtual method overrides.

A few other trivial changes:
* Explicitly resets |session_controller_client_| during TearDown(),
  since I forgot that previously.  (Should have no effect)
* Puts GetLocalStatePrefService() into the same order in the .cc file
  as the .h file.

Should be no functional effects.

Bug: none
Change-Id: Ida64c3fc0779f3bb38a032cf8d3f490104fe88ab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124934
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754707}

Bug: 1009124
Change-Id: Id35faff3cc3f0caa0a4200c40d803a07a32cf01f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128460
Commit-Queue: Kyle Milka <kmilka@chromium.org>
Commit-Queue: Matthew Jones <mdjones@chromium.org>
Auto-Submit: Kyle Milka <kmilka@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754706}

Removing register*() wrapper functions, using runMochaSuite()
instead.

Bug: 1026426
Change-Id: I802eb09bb4640dc673c213dc53796a219ce71f99
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127417
Auto-Submit: dpapad <dpapad@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754705}

The test is flaky. This CL fixes the typo in the test rename to ensure
the test is actually disabled.

TBR=miersh@google.com,tiborg@chromium.org

Bug: 1065812
Change-Id: Ib6adf89dbe8bfa35034114f86cc892cdd5252f2c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127988
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754704}

TBR=rsleevi@chromium.org

Change-Id: Ic6b261d11baa5c6b4999c975266ad8d8b6e3eede
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127726Reviewed-by: Nick Harper <nharper@chromium.org>
Reviewed-by: Ryan Sleevi <rsleevi@chromium.org>
Commit-Queue: Nick Harper <nharper@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754703}

Expand the computation of cross schemeness of same-site contexts to
include CROSS_SITE.

Change-Id: I397fcbc79d62977069e2ec20bcdda027fdd35f9a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124546
Commit-Queue: Steven Bingler <bingler@chromium.org>
Reviewed-by: Maksim Orlovich <morlovich@chromium.org>
Reviewed-by: Lily Chen <chlily@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754702}

Fixed by adding a WeakPtrFactory to SpeechMonitor so all posted task callbacks don't run if we destroy SpeechMonitor previously.

Failure in asan:
READ of size 8 at 0x7f8dc614c068 thread T0 (browser_tests)
    #0 0x559e511d3be4 in time_since_epoch ./../../buildtools/third_party/libc++/trunk/include/chrono:1383:103
    #1 0x559e511d3be4 in operator-<std::__1::chrono::steady_clock, std::__1::chrono::duration<long long, std::__1::ratio<1, 1000000000> >, std::__1::chrono::duration<long long, std::__1::ratio<1, 1000000000> > > ./../../buildtools/third_party/libc++/trunk/include/chrono:1564:45
    #2 0x559e511d3be4 in CalculateUtteranceDelayMS ./../../chrome/browser/chromeos/accessibility/speech_monitor.cc:93:15
    #3 0x559e511d3be4 in chromeos::SpeechMonitor::MaybePrintExpectations() ./../../chrome/browser/chromeos/accessibility/speech_monitor.cc:230:7
    #4 0x559e5edf6c45 in Run ./../../base/callback.h:98:12
    #5 0x559e5edf6c45 in base::TaskAnnotator::RunTask(char const*, base::PendingTask*) ./../../base/task/common/task_annotator.cc:142:33
    #6 0x559e5ee2dfe8 in base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWorkImpl(base::sequence_manager::LazyNow*, bool*) ./../../base/task/sequence_manager/thread_controller_with_message_pump_impl.cc:324:23
    #7 0x559e5ee2d93a in base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoSomeWork() ./../../base/task/sequence_manager/thread_controller_with_message_pump_impl.cc:248:7
    #8 0x559e5ef7c9d6 in base::MessagePumpLibevent::Run(base::MessagePump::Delegate*) ./../../base/message_loop/message_pump_libevent.cc:208:55
    #9 0x559e5ee2f188 in base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::Run(bool, base::TimeDelta) ./../../base/task/sequence_manager/thread_controller_with_message_pump_impl.cc:429:12
    #10 0x559e5eda978d in base::RunLoop::Run() ./../../base/run_loop.cc:124:14
    #11 0x559e5ecac5eb in RunUntilBrowserProcessQuits ./../../chrome/test/base/in_process_browser_test.cc:362:38
    #12 0x559e5ecac5eb in InProcessBrowserTest::QuitBrowsers() ./../../chrome/test/base/in_process_browser_test.cc:584:3
    #13 0x559e5ecac2f7 in InProcessBrowserTest::PostRunTestOnMainThread() ./../../chrome/test/base/in_process_browser_test.cc:559:3
    #14 0x559e601dc870 in content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() ./../../content/public/test/browser_test_base.cc:699:3
    #15 0x559e5f0c5e8f in Run ./../../base/callback.h:98:12
    #16 0x559e5f0c5e8f in ChromeBrowserMainParts::PreMainMessageLoopRunImpl() ./../../chrome/browser/chrome_browser_main.cc:1640:38
    #17 0x559e5f0c3bdb in ChromeBrowserMainParts::PreMainMessageLoopRun() ./../../chrome/browser/chrome_browser_main.cc:1043:18
    #18 0x559e5324fc2f in chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun() ./../../chrome/browser/chromeos/chrome_browser_main_chromeos.cc:597:32
    #19 0x559e57b9c078 in content::BrowserMainLoop::PreMainMessageLoopRun() ./../../content/browser/browser_main_loop.cc:1020:13
    #20 0x559e58ab7d34 in Run ./../../base/callback.h:98:12
    #21 0x559e58ab7d34 in content::StartupTaskRunner::RunAllTasksNow() ./../../content/browser/startup_task_runner.cc:41:29
    #22 0x559e57b993a4 in content::BrowserMainLoop::CreateStartupTasks() ./../../content/browser/browser_main_loop.cc:929:25
    #23 0x559e57ba10ce in content::BrowserMainRunnerImpl::Initialize(content::MainFunctionParams const&) ./../../content/browser/browser_main_runner_impl.cc:129:15
    #24 0x559e57b94ae5 in content::BrowserMain(content::MainFunctionParams const&) ./../../content/browser/browser_main.cc:43:32
    #25 0x559e5d885212 in RunBrowserProcessMain ./../../content/app/content_main_runner_impl.cc:529:10
    #26 0x559e5d885212 in content::ContentMainRunnerImpl::RunServiceManager(content::MainFunctionParams&, bool) ./../../content/app/content_main_runner_impl.cc:978:10
    #27 0x559e5d8844d8 in content::ContentMainRunnerImpl::Run(bool) ./../../content/app/content_main_runner_impl.cc:878:12
    #28 0x559e667f3da4 in service_manager::Main(service_manager::MainParams const&) ./../../services/service_manager/embedder/main.cc:457:29
    #29 0x559e5ab9eec2 in content::ContentMain(content::ContentMainParams const&) ./../../content/app/content_main.cc:19:10
    #30 0x559e601da293 in content::BrowserTestBase::SetUp() ./../../content/public/test/browser_test_base.cc:513:3
    #31 0x559e5eca7ca9 in InProcessBrowserTest::SetUp() ./../../chrome/test/base/in_process_browser_test.cc:303:20
    #32 0x559e5220cb97 in HotseatShelfAppBrowserTest::SetUp() ./../../chrome/browser/ui/ash/launcher/chrome_launcher_controller_browsertest.cc:2274:26
    #33 0x559e540b8f08 in HandleExceptionsInMethodIfSupported<testing::Test, void> ./../../third_party/googletest/src/googletest/src/gtest.cc:0:0
    #34 0x559e540b8f08 in testing::Test::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2663:3
    #35 0x559e540bb736 in testing::TestInfo::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2845:11
    #36 0x559e540bcc76 in testing::TestSuite::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2977:28
    #37 0x559e540e3716 in testing::internal::UnitTestImpl::RunAllTests() ./../../third_party/googletest/src/googletest/src/gtest.cc:5518:44
    #38 0x559e540e23f3 in HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool> ./../../third_party/googletest/src/googletest/src/gtest.cc:0:0
    #39 0x559e540e23f3 in testing::UnitTest::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:5105:10
    #40 0x559e5efb6539 in RUN_ALL_TESTS ./../../third_party/googletest/src/googletest/include/gtest/gtest.h:2472:46
    #41 0x559e5efb6539 in base::TestSuite::Run() ./../../base/test/test_suite.cc:458:16
    #42 0x559e5ec63f38 in BrowserTestSuiteRunnerChromeOS::RunTestSuite(int, char**) ./../../chrome/test/base/browser_tests_main_chromeos.cc:37:23
    #43 0x559e6029ce29 in content::LaunchTests(content::TestLauncherDelegate*, unsigned long, int, char**) ./../../content/public/test/test_launcher.cc:375:31
    #44 0x559e5ec651cb in LaunchChromeTests(unsigned long, content::TestLauncherDelegate*, int, char**) ./../../chrome/test/base/chrome_test_launcher.cc:247:10
    #45 0x559e5ec63d69 in main ./../../chrome/test/base/browser_tests_main_chromeos.cc:52:10
    #46 0x7f8dc93aabba in __libc_start_main /build/glibc-QG9qOO/glibc-2.29/csu/../csu/libc-start.c:308:16

Address 0x7f8dc614c068 is located in stack of thread T0 (browser_tests) at offset 104 in frame
    #0 0x559e625d8a0f in base::circular_deque<mojo::Message>::DestructRange(unsigned long, unsigned long) ./../../base/containers/circular_deque.h:998:0

Original change
https://chromium-review.googlesource.com/c/chromium/src/+/2124701

TBR=nancylingwang@chromium.org, dmazzoni@chromium.org

Fixed: 1065746
Test: ran tests against asan, debug, and release
Change-Id: Ie3b245933969ffe182962e017515e4cf656ef05b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128027Reviewed-by: David Tseng <dtseng@chromium.org>
Commit-Queue: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754701}

This reverts commit ddc36acb.

Reason for revert: 
The added tests fail consistently on ios-simulator-noncq, see e.g. https://ci.chromium.org/p/chromium/builders/ci/ios-simulator-noncq/3424

Original change's description:
> [iOS] Hook up chrome://interstitials page.
> 
> This CL adds support for the chrome://interstitials WebUI, which
> contains links for dummy interstitials.  Currently only a subset of the
> available links are implemented for iOS.
> 
> Bug: 1064803
> Change-Id: I8577b92cdebf5110847ca835d952953171f2d172
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121134
> Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org>
> Reviewed-by: Livvie Lin <livvielin@chromium.org>
> Reviewed-by: Eugene But <eugenebut@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#754581}

TBR=eugenebut@chromium.org,kkhorimoto@chromium.org,livvielin@chromium.org,livvielin@google.com

Change-Id: I44f5e7a818e581331d7278956ce5588df5dc705b
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1064803
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128931Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754700}

* Replaces search results that were type String to mojom.SearchResult.
* Modifies elements and tests to account for type change.
* Does not remove fakeSettingsSearchHandlerSearch() yet as it will still
  be used to test a variety of cases and enable faster dev.

Bug: 1056909
Change-Id: I4ec246fa50a5076eea6f1d99efa4116d82d43e6d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2122617
Commit-Queue: Regan Hsu <hsuregan@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754699}

Previously CastRunner was implementing Audio protocol to redirect
CreateAudioCapturer() message to the agent that created the component.
The agent also needs to be able to intercept CreateAudioRenderer()
requests, particularly to set stream usage (WebEngine doesn't set
usage for AudioRenderer ATM).

This CL updates the runner to redirect fuchsia.media.Audio protocol,
so then the agent can handle AudioRenderer and AudioCapturer requests
as appropriate.

This affects WebRTC audio output, but not regular media playback which
is handled by the fuchsia.media.AudioConsumer protocol.

Bug: 1059836
Change-Id: If68efdd2e1e4f0cbe84051e22ebaf90c2877b08e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2125610
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: David Dorwin <ddorwin@chromium.org>
Auto-Submit: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754698}

Found while working on AshTestHelper.

Bug: none
Change-Id: Ia942c7662dea4b3194a31930efe9ce244286effe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2125396Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Yuchen Liu <yucliu@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754697}

https://swiftshader.googlesource.com/SwiftShader.git/+log/45755df21024..5cf1e9a31c90

git log 45755df21024..5cf1e9a31c90 --date=short --first-parent --format='%ad %ae %s'
2020-03-30 capn@google.com Fix implicit narrowing cast

Created with:
  gclient setdep -r src/third_party/swiftshader@5cf1e9a31c90

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-chromium-autoroll
Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: swiftshader-team+autoroll@google.com
Change-Id: I7d769239f440d43c0929a07888cec009759f7feb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128381Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#754696}

https://chromium.googlesource.com/external/github.com/google/shaderc/+log/f085b9745fc1..aface10e934e

git log f085b9745fc1..aface10e934e --date=short --first-parent --format='%ad %ae %s'
2020-03-30 rharrison@google.com Rolling 5 dependencies and updated exceptions (#1026)

Created with:
  gclient setdep -r src/third_party/shaderc/src@aface10e934e

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/shaderc-chromium-autoroll
Please CC radial-bots+chrome-roll@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: radial-bots+chrome-roll@google.com
Change-Id: I4aa846b16bb27d48f567b9a070848dbc364cba45
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128383Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#754695}

BUG=1063749
R=cbiesinger@chromium.org

Change-Id: I14718b6bb2b9c48653e737fb08a9f780f86da000
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128426
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754694}

This enables all non-blacklisted checks at verbosity 1 and above.  I
locally spot-checked the verbose=0 errors and found them useless
(mostly false complaints about "more than one command on the same line"
for lambdas), so not going down that far.

This should prevent regressing on any of the failures I've fixed.

Bug: none
Change-Id: Ia5db45e7e372a6147d58f463bbc47c81e00aac5e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2126254
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Robert Liao <robliao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754693}

Now that Contextual Search is the only Overlay Panel (due to Preview Tab
moving to a Bottom Sheet) we no longer need coordination with other
Overlays.

This CL removes the coorindation logic in ContextualSearchTabHelper and
the usage of the OverlayObserver, and usage of TabImpl.getActivity.

BUG=952703

Change-Id: I477cdbfb0e7edc43069d451b48de30fda460f314
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2125437Reviewed-by: Donn Denman <donnd@chromium.org>
Reviewed-by: Jinsuk Kim <jinsukkim@chromium.org>
Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
Auto-Submit: Donn Denman <donnd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754692}

Removal requested via email, verified via DNS TXT record.

Change-Id: Ifb236fd7ef53c1ed08c5fa6a32cd5d8b6d25f2f8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127903
Commit-Queue: Nick Harper <nharper@chromium.org>
Commit-Queue: Ryan Sleevi <rsleevi@chromium.org>
Auto-Submit: Nick Harper <nharper@chromium.org>
Reviewed-by: Ryan Sleevi <rsleevi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754691}

Fuchsia packages are cached rather than installed into a device's
package filesystem, and when resolving packages the system is at liberty
to return a cached package that may be older than the version that had
previously been run, if the package server is unavailable.

Ensure that the package server remains running for the duration of
RunPackage(), to ensure that the expected version is run.

Bug: 956100, fuchsia:49180
Change-Id: I4aeacbf451f5c2bde84e16b3ea35461d2b88fa4b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127368
Commit-Queue: Wez <wez@chromium.org>
Auto-Submit: Wez <wez@chromium.org>
Reviewed-by: Kevin Marshall <kmarshall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754690}

We were trying to track down the root cause of a strange flaky failure.
Where the test runner itself was crashing as a side effect of getting incorrect data from Chrome.
We added some logging to the blink_web_tests test runner:
https://chromium-review.googlesource.com/c/chromium/src/+/2003029

Since then there has been no exact reproduction. Thought a similar error appeared due to being OOM.
We can't do anything about that.

Removing the unneeded logs.

Bug: 1021563
TEST=vulkan_native_blink_web_tests

Change-Id: Ib6c55e2229be4129d7d066bf805cab5b32505653
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128380Reviewed-by: Robert Ma <robertma@chromium.org>
Commit-Queue: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754689}

This PLM Observer is the one that logs the PrefetchProxy UKM event
which I need to add to for IsolatedPrerender. For now the subresource
loading metrics are left alone, those are still nice to have until we
get to the NSP impl.

No functional changes, just a rename.

Bug: 1064726
Change-Id: Ic1dbbe22d8cfe5e6a343b9a5eb4be09590f54424
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2125565
Auto-Submit: Robert Ogden <robertogden@chromium.org>
Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Commit-Queue: Robert Ogden <robertogden@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754688}

Bug: 1066140
Change-Id: I54dc64bc0138ce3cb9ca30542e662e556e7e6f5e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128457
Commit-Queue: Peng Huang <penghuang@chromium.org>
Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org>
Auto-Submit: Peng Huang <penghuang@chromium.org>
Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754687}

The --force-gpu-rasterization flag just ignores the gpu process
capabilities, whereas the --enable-gpu-rasterization flag changes
the capabilities to always allow gpu raster.

We'd like to delete the --force-gpu-rasterization flag as it seems
to provide the same functionality as --enable-gpu-rasterization but in
a much more round-a-bout way.

This has the effect of actually turning on gpu rasterization in the
gpu process in web tests, since --force-gpu-rasterizatoin would not be
passed to the gpu process and web tests would (in the gpu process) then
add the --disable-gpu-rasterization flag in that process. Rebased
web tests reflect that change.

R=kylechar@chromium.org, vmpstr@chromium.org

NOTRY=true

Bug: 866140, 1065893
Change-Id: I049b8909e4a38a7dcb136b2a5e33829e3fe177c1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124890
Commit-Queue: danakj <danakj@chromium.org>
Reviewed-by: vmpstr <vmpstr@chromium.org>
Reviewed-by: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754686}

https://skia.googlesource.com/skia.git/+log/46de36f99362..6e2af5c326c4

git log 46de36f99362..6e2af5c326c4 --date=short --first-parent --format='%ad %ae %s'
2020-03-30 egdaniel@google.com Remove alpha versions of constant blend coeffs.
2020-03-30 bsalomon@google.com Revert "Assert that all GrCaps colortype/format -> swizzle queries are legal."
2020-03-30 jvanverth@google.com Fill in some D3D texture creation routines.
2020-03-30 bsalomon@google.com Assert that all GrCaps colortype/format -> swizzle queries are legal.
2020-03-30 sgilhuly@chromium.org Roll Dawn and add dependencies
2020-03-30 bsalomon@google.com Revert "Remove GrCaps::isFormatTexturableAndUploadable"
2020-03-30 csmartdalton@google.com Use GL_ANGLE_base_vertex_base_instance
2020-03-30 mtklein@google.com remove Builder inheritance
2020-03-30 mtklein@google.com fix unpremul()
2020-03-30 fmalita@chromium.org [skottie] Lazy adapter sync
2020-03-30 bsalomon@google.com Make memcmps in GrResourceKey::op== safe.
2020-03-30 brianosman@google.com Remove some legacy GN defines for Flutter
2020-03-30 mtklein@google.com don't run clang-tidy on third_party
2020-03-30 mtklein@google.com way more p-> inference
2020-03-30 bsalomon@google.com Remove GrCaps::isFormatTexturableAndUploadable
2020-03-30 mtklein@google.com remove negate()
2020-03-30 mtklein@google.com remove inv()

Created with:
  gclient setdep -r src/third_party/skia@6e2af5c326c4

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC michaelludwig@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: chromium:1064563
Tbr: michaelludwig@google.com
Change-Id: I7e952e8ba7448553ad0b768431813fff2178dde9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128376Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#754685}

Instead of returning by value - this makes
ComputePartialAbsoluteWithChildInlineSize mutable an in parameter.

This is so in a subsequent patch the block dimensions can be computed
before the inline dimensions.

This also performs some renames:
ComputePartialAbsoluteWithChildInlineSize -> ComputeOutOfFlowInlineDimensions
ComputeFullAbsoluteWithChildBlockSize -> ComputeOutOfFlowBlockDimensions
As "full"/"partial" don't particularly apply now.

Change-Id: Id03b0ba8f923d72db12896d9955179953626c7b2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2122456Reviewed-by: Aleks Totic <atotic@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754684}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/012fbeb999c6..adc61409cbf9


Created with:
  gclient setdep -r src-internal@adc61409cbf9

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: chromium:1063851,chromium:760187,chromium:832124
Tbr: jbudorick@google.com
Change-Id: I2803b71eb83df110de5c6207389dc30e9cd36b9b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128067
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#754683}

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll
Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast
Tbr: cr-fuchsia+bot@chromium.org
Change-Id: I20677067ba79d53741071fd81f05f17ef4617549
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128384Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#754682}

Tested with --ozone-platform=x11.

Bug: 1065499
Change-Id: I57299267c6c496f77a2004ca6017bc2c0c8dabf1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2126248
Commit-Queue: Peng Huang <penghuang@chromium.org>
Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Auto-Submit: Peng Huang <penghuang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754681}

- Add FrameSequenceTrackerType::kCustom;
- Add FrameSequenceTrackerCollection::StartCustomSequence to create
  a kCustom typed tracker to represent a sequence;
- Add FrameSequenceTrackerCollection::StopCustomSequence to schedule
  termination of a tracker for a sequence;
- Data collected by custom trackers are reported via the return
  value of FrameSequenceTrackerCollection::TakeCustomTrackerResults;

Bug: 1021774
Change-Id: I62d9c2eb833e1d40e01b3b452d515ce361233a64
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007937
Commit-Queue: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754680}

ContentsView::ResetForShow was resetting the contents view state to
match the closed app list view state, unless the contents view state
already was set for the closed app list view (so if ResetForShow is
called mid closing animation the contents view contents doesn't jump to
the closed state, which would make show animation seem janky).

Additionally, the contents view state was not updated if the contents
view state was not previously updated for app list view state. This
meant that on initial app list show, the app list contents view elements
were animating from 1.0 opacity, instead of 0.0 opacity (i.e. the
opacity for closed app list view) - specifically, this made search box
view visible behind the shelf when the app list view was initially
shown.

This cl changes ResetForShow to reset the contents view state to closed
app list view state in the latter case (so the initial app list view
show animation looks smoother).

BUG=1066249

Change-Id: Icb27965cdf635c76bd910f249ce3d613dd59b223
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2125454
Commit-Queue: Toni Baržić <tbarzic@chromium.org>
Reviewed-by: Alex Newcomer <newcomer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754679}

This reverts commit b818b458.

Reason for revert: My measurement was wrong. The call to v8::Isolate isn't nearly as slow as previously though. Reverting the optimization as it just adds unnecessary complexity.

Original change's description:
> Optimize SourceLocation::Capture
> 
> Determining the v8::Isolate can take ~25% of the time
> required to capture the top of the stack. This CL gets the Isolate
> from the ExecutionContext when it's available to speed things up.
> 
> Bug: 851531
> Change-Id: Ia823fbb0643c62f1a4da3cc289b23ca6fb43da2b
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2122568
> Commit-Queue: Josh Karlin <jkarlin@chromium.org>
> Reviewed-by: Nate Chapin <japhet@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#754054}

TBR=japhet@chromium.org,jkarlin@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 851531
Change-Id: I36e9be81b06598ed29484df2997c22cbd4dc170f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128090Reviewed-by: Josh Karlin <jkarlin@chromium.org>
Commit-Queue: Josh Karlin <jkarlin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754678}

MediaCanPlayTypeTest.CodecSupportTest_NewVp9Variants test fails on Windows on ARM64 currently.
The test expects ARM platforms (excluding specific android versions) not to support Profile 2 and 3 Vp9 codecs but they are supported on WoA.

Bug: 1058748
Change-Id: Ie2157ccd453c052d5ba11240f337798a22f1dbf2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2104467
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Johann Koenig <johannkoenig@google.com>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754677}

The [Badging API](https://wicg.github.io/badging/) is a new API
allowing the setting of application/document badges. This change
converts the Badging API web tests into Web Platform Tests.

This change adds a no-op MockBadgeService to the content_shell.
This is necessary because the RenderProcessHostImpl will terminate
the render process if unknown Mojo messages are received.

Bug: 1051684
Change-Id: I61e29b8f197a754fea489ebb2d0dcd41484f6cf4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088297Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Matt Giuca <mgiuca@chromium.org>
Commit-Queue: Chris Mumford <cmumford@google.com>
Cr-Commit-Position: refs/heads/master@{#754676}

When the legend is smaller than the fieldset border-top, the legend's
margin box gets pushed down. In the case of fragmentation, allow
this adjustment if the legend fits inside the first fragment.
Otherwise, don't adjust the legend block offset.

Bug: 875235
Change-Id: Id93474cf0ee94975093391e71b87250f547852b3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2125230
Commit-Queue: Alison Maher <almaher@microsoft.com>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754675}

Needs build-side CL:
https://chromium-review.googlesource.com/c/chromium/tools/build/+/2125157

BUG=1060273
R=estaab

Change-Id: I0171772e75df4b71536ba955e973859c8d793439
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2125234
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Erik Staab <estaab@chromium.org>
Reviewed-by: Aaron Gable <agable@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754674}